[Mutopia-discuss] reviewing pull requests in github

[Federico Bruni]

Hi all

I'm reading this guide:
https://help.github.com/articles/checking-out-pull-requests-locally/

I see that I can easily checkout the branch submitted through a pull 
request with this command:


git fetch origin pull/ID/head:BRANCHNAME
git checkout BRANCHNAME

Now, if the author of the pull request add one or more commits, what's 
the best way to update it to the last commit?

If I repeat the fetch above I get this error:

fatal: Refusing to fetch into current branch refs/heads/search of 
non-bare repository


The simple (stupid) solution I found is deleting the branch so I can 
repeat the two commands above without any problem. But I'm sure that 
there's something better.
Mmmmh, I think I found it. If I checkout master again and run the fetch 
again it works.

I guess that I'm missing what the fetch does.

Anyway, do you think it's worth adding a small page  in the wiki about 
reviewing patches?


Cheers
Federico

PS For Glen and Javier: what about another round of updates? Or some 
focus to close the Phase 3 milestone?
I got a bit stuck on writing a piece from scratch. But during Christmas 
I might have some time to get some things done.
___
Mutopia-discuss mailing list
Mutopia-discuss@mutopiaproject.org
http://lists.bcn.mythic-beasts.com/mailman/listinfo/mutopia-discuss

Re: [Mutopia-discuss] reviewing pull requests in github

[Javier Ruiz-Alma]

Hi Federico,
Having a link to this guide would've made things easier for the few times I've 
copy/pasted code to compile some else's pull-requests.  This doesn't happen 
often, though, so maybe you can create a new wiki page for advanced topics.Is 
it possible to also submit changes to someone else's open pull-request via 
github?  If so, add a link to this too.  Speaking for myself: I'd be lost on 
how to process a change request to one of my open PR's thru github.
I'm open to the next round of updates from Glenupdating Mutopia code sounds 
like a great plan for the Christmas time off...season of giving :)

Javier



 On Tuesday, December 2, 2014 2:44 PM, Federico Bruni  
wrote:
   
 

 Hi all
I'm reading this 
guide:https://help.github.com/articles/checking-out-pull-requests-locally/
I see that I can easily checkout the branch submitted through a pull request 
with this command:
git fetch origin pull/ID/head:BRANCHNAMEgit checkout BRANCHNAME
Now, if the author of the pull request add one or more commits, what's the best 
way to update it to the last commit?If I repeat the fetch above I get this 
error:
fatal: Refusing to fetch into current branch refs/heads/search of non-bare 
repository
The simple (stupid) solution I found is deleting the branch so I can repeat the 
two commands above without any problem. But I'm sure that there's something 
better.Mmmmh, I think I found it. If I checkout master again and run the fetch 
again it works.I guess that I'm missing what the fetch does.
Anyway, do you think it's worth adding a small page  in the wiki about 
reviewing patches?
CheersFederico
PS For Glen and Javier: what about another round of updates? Or some focus to 
close the Phase 3 milestone?I got a bit stuck on writing a piece from scratch. 
But during Christmas I might have some time to get some things done.
___
Mutopia-discuss mailing list
Mutopia-discuss@mutopiaproject.org
http://lists.bcn.mythic-beasts.com/mailman/listinfo/mutopia-discuss

 
   ___
Mutopia-discuss mailing list
Mutopia-discuss@mutopiaproject.org
http://lists.bcn.mythic-beasts.com/mailman/listinfo/mutopia-discuss