Re: RFR: 8273243: Fix indentations in java.net.InetAddress methods [v2]

2021-09-02 Thread Daniel Fuchs 
On Wed, 1 Sep 2021 23:11:53 GMT, Aleksei Efimov  wrote:

>> Hi,
>> 
>> The fix changes indentations in the following `java.net.InetAddress` methods:
>> - getAddressesFromNameService
>> - getHostFromNameService
>> 
>> It helps to improve code readability. Can't say the same about 
>> `getHostFromNameService` diffs shown in this PR.
>
> Aleksei Efimov has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   8273243: looks -> looks like

Marked as reviewed by dfuchs (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/5336

Re: RFR: 8273243: Fix indentations in java.net.InetAddress methods [v2]

2021-09-01 Thread Aleksei Efimov 
> Hi,
> 
> The fix changes indentations in the following `java.net.InetAddress` methods:
> - getAddressesFromNameService
> - getHostFromNameService
> 
> It helps to improve code readability. Can't say the same about 
> `getHostFromNameService` diffs shown in this PR.

Aleksei Efimov has updated the pull request incrementally with one additional 
commit since the last revision:

  8273243: looks -> looks like

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/5336/files
  - new: https://git.openjdk.java.net/jdk/pull/5336/files/27c03f4d..f5627f73

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk=5336=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk=5336=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/5336.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/5336/head:pull/5336

PR: https://git.openjdk.java.net/jdk/pull/5336

Re: RFR: 8273243: Fix indentations in java.net.InetAddress methods [v2]

2021-09-01 Thread Aleksei Efimov 
On Wed, 1 Sep 2021 17:08:24 GMT, Brian Burkhalter  wrote:

>> Aleksei Efimov has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   8273243: looks -> looks like
>
> src/java.base/share/classes/java/net/InetAddress.java line 689:
> 
>> 687: }
>> 688: 
>> 689: //XXX: if it looks a spoof just return the address?
> 
> looks _like_ a spoof

Thanks Brian. Changed it as suggested :)

-

PR: https://git.openjdk.java.net/jdk/pull/5336