Re: [PATCH 4/13] [IPV6] Clean up BACKTRACK().

2006-10-16 Thread David Miller
From: Ville Nuorvala <[EMAIL PROTECTED]>
Date: Tue, 17 Oct 2006 03:06:27 +0300

> The fn check is unnecessary as fn can never be NULL in BACKTRACK().
> 
> Signed-off-by: Ville Nuorvala <[EMAIL PROTECTED]>

Applied, especially valid since we're walking parents up to
the, we break out at hitting root, and root's parent is
itself :-)

Thanks.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH 4/13] [IPV6] Clean up BACKTRACK().

2006-10-16 Thread Ville Nuorvala

The fn check is unnecessary as fn can never be NULL in BACKTRACK().

Signed-off-by: Ville Nuorvala <[EMAIL PROTECTED]>
---
 net/ipv6/route.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index a1b0f07..263c057 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -484,7 +484,7 @@ #define BACKTRACK(saddr) \
 do { \
if (rt == &ip6_null_entry) { \
struct fib6_node *pn; \
-   while (fn) { \
+   while (1) { \
if (fn->fn_flags & RTN_TL_ROOT) \
goto out; \
pn = fn->parent; \
-- 
1.4.2.3
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html