Re: [PATCH net-next 0/8] Bug fixes in ena ethernet driver
Ack. resubmitting to net branch and adding "Fixes" mark. From: David Miller <da...@davemloft.net> Sent: Saturday, June 10, 2017 11:11 PM To: f.faine...@gmail.com Cc: Belgazal, Netanel; netdev@vger.kernel.org; Woodhouse, David; Machulsky, Zorik; Matushevsky, Alexander; BSHARA, Said; Wilson, Matt; Liguori, Anthony; Bshara, Nafea; Schmeilin, Evgeny Subject: Re: [PATCH net-next 0/8] Bug fixes in ena ethernet driver From: Florian Fainelli <f.faine...@gmail.com> Date: Fri, 9 Jun 2017 15:19:54 -0700 > On 06/09/2017 03:13 PM, neta...@amazon.com wrote: >> From: Netanel Belgazal <neta...@amazon.com> >> >> This patchset contains fixes for the bugs that were discovered so far. > > If these are all fixes you should submit them against the "net" tree. > net-next is for features [1]. > > Since these are fixes, you may also want to provide a Fixes: 12-digit > commit ("commit subject") [2] such that David can queue these patches > for stable trees and this can be retrofitted into kernel distributions. > > [1]: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/networking/netdev-FAQ.txt#n25 > > [2]: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst#n183 Yeah I agree. If they are genuine bug fixes they should be submitted against 'net'. And yes, Fixes: tags are quite desirable as well.
Re: [PATCH net-next 0/8] Bug fixes in ena ethernet driver
From: Florian FainelliDate: Fri, 9 Jun 2017 15:19:54 -0700 > On 06/09/2017 03:13 PM, neta...@amazon.com wrote: >> From: Netanel Belgazal >> >> This patchset contains fixes for the bugs that were discovered so far. > > If these are all fixes you should submit them against the "net" tree. > net-next is for features [1]. > > Since these are fixes, you may also want to provide a Fixes: 12-digit > commit ("commit subject") [2] such that David can queue these patches > for stable trees and this can be retrofitted into kernel distributions. > > [1]: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/networking/netdev-FAQ.txt#n25 > > [2]: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst#n183 Yeah I agree. If they are genuine bug fixes they should be submitted against 'net'. And yes, Fixes: tags are quite desirable as well.
Re: [PATCH net-next 0/8] Bug fixes in ena ethernet driver
On 06/09/2017 03:13 PM, neta...@amazon.com wrote: > From: Netanel Belgazal> > This patchset contains fixes for the bugs that were discovered so far. If these are all fixes you should submit them against the "net" tree. net-next is for features [1]. Since these are fixes, you may also want to provide a Fixes: 12-digit commit ("commit subject") [2] such that David can queue these patches for stable trees and this can be retrofitted into kernel distributions. [1]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/networking/netdev-FAQ.txt#n25 [2]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst#n183 > > Netanel Belgazal (8): > net: ena: fix rare uncompleted admin command false alarm > net: ena: fix bug that might cause hang after consecutive open/close > interface. > net: ena: add missing return when ena_com_get_io_handlers() fails > net: ena: fix race condition between submit and completion admin > command > net: ena: add missing unmap bars on device removal > net: ena: fix theoretical Rx hang on low memory systems > net: ena: disable admin msix while working in polling mode > net: ena: bug fix in lost tx packets detection mechanism > > drivers/net/ethernet/amazon/ena/ena_com.c | 35 +++-- > drivers/net/ethernet/amazon/ena/ena_ethtool.c | 2 +- > drivers/net/ethernet/amazon/ena/ena_netdev.c | 179 > +++--- > drivers/net/ethernet/amazon/ena/ena_netdev.h | 16 ++- > 4 files changed, 168 insertions(+), 64 deletions(-) > -- Florian
[PATCH net-next 0/8] Bug fixes in ena ethernet driver
From: Netanel BelgazalThis patchset contains fixes for the bugs that were discovered so far. Netanel Belgazal (8): net: ena: fix rare uncompleted admin command false alarm net: ena: fix bug that might cause hang after consecutive open/close interface. net: ena: add missing return when ena_com_get_io_handlers() fails net: ena: fix race condition between submit and completion admin command net: ena: add missing unmap bars on device removal net: ena: fix theoretical Rx hang on low memory systems net: ena: disable admin msix while working in polling mode net: ena: bug fix in lost tx packets detection mechanism drivers/net/ethernet/amazon/ena/ena_com.c | 35 +++-- drivers/net/ethernet/amazon/ena/ena_ethtool.c | 2 +- drivers/net/ethernet/amazon/ena/ena_netdev.c | 179 +++--- drivers/net/ethernet/amazon/ena/ena_netdev.h | 16 ++- 4 files changed, 168 insertions(+), 64 deletions(-) -- 2.7.4
Re: [PATCH net-next 0/8] Bug fixes in ena ethernet driver
I the last minute I fixed patchset #6 commit subject from stuck to hang and I forget to remove it. Sorry for that. resubmitted. From: David Miller <da...@davemloft.net> Sent: Friday, June 9, 2017 10:33 PM To: Belgazal, Netanel Cc: netdev@vger.kernel.org; Woodhouse, David; Machulsky, Zorik; Matushevsky, Alexander; BSHARA, Said; Wilson, Matt; Liguori, Anthony; Bshara, Nafea; Schmeilin, Evgeny Subject: Re: [PATCH net-next 0/8] Bug fixes in ena ethernet driver From: <neta...@amazon.com> Date: Fri, 9 Jun 2017 09:55:16 +0300 > This patchset contains fixes for the bugs that were discovered so far. You submitted patch #6 twice, once with the word "stuck" in the subject line, once with the word "hang" in the subject line. Please sort this out and resubmit, thanks.
Re: [PATCH net-next 0/8] Bug fixes in ena ethernet driver
From:Date: Fri, 9 Jun 2017 09:55:16 +0300 > This patchset contains fixes for the bugs that were discovered so far. You submitted patch #6 twice, once with the word "stuck" in the subject line, once with the word "hang" in the subject line. Please sort this out and resubmit, thanks.
Re: [PATCH net-next 0/8] Bug fixes in ena ethernet driver
My apologies, I was not aware. Will make sure this won't happen again. Regards, Netanel From: David Miller <da...@davemloft.net> Sent: Friday, June 9, 2017 2:17 AM To: Belgazal, Netanel Cc: netdev@vger.kernel.org; Woodhouse, David; Machulsky, Zorik; Matushevsky, Alexander; BSHARA, Said; Wilson, Matt; Liguori, Anthony; Bshara, Nafea; Schmeilin, Evgeny Subject: Re: [PATCH net-next 0/8] Bug fixes in ena ethernet driver Two parallel patch series to the same driver and targetting the same GIT tree is extremely undesirable, please don't do this. Submit one series, and once applied submit the second series. I'm deleting all of your patches from my queue, please resubmit things properly. Thank you.
[PATCH net-next 0/8] Bug fixes in ena ethernet driver
From: Netanel BelgazalThis patchset contains fixes for the bugs that were discovered so far. Netanel Belgazal (8): net: ena: fix rare uncompleted admin command false alarm net: ena: fix bug that might cause hang after consecutive open/close interface. net: ena: add missing return when ena_com_get_io_handlers() fails net: ena: fix race condition between submit and completion admin command net: ena: add missing unmap bars on device removal net: ena: fix theoretical Rx hang on low memory systems net: ena: disable admin msix while working in polling mode net: ena: bug fix in lost tx packets detection mechanism drivers/net/ethernet/amazon/ena/ena_com.c | 35 +++-- drivers/net/ethernet/amazon/ena/ena_ethtool.c | 2 +- drivers/net/ethernet/amazon/ena/ena_netdev.c | 179 +++--- drivers/net/ethernet/amazon/ena/ena_netdev.h | 16 ++- 4 files changed, 168 insertions(+), 64 deletions(-) -- 2.7.4
Re: [PATCH net-next 0/8] Bug fixes in ena ethernet driver
Two parallel patch series to the same driver and targetting the same GIT tree is extremely undesirable, please don't do this. Submit one series, and once applied submit the second series. I'm deleting all of your patches from my queue, please resubmit things properly. Thank you.
[PATCH net-next 0/8] Bug fixes in ena ethernet driver
From: Netanel BelgazalThis patchset contains fixes for the bugs that were discovered so far. Netanel Belgazal (8): net: ena: fix rare uncompleted admin command false alarm net: ena: fix bug that might cause hang after consecutive open/close interface. net: ena: add missing return when ena_com_get_io_handlers() fails net: ena: fix race condition between submit and completion admin command net: ena: add missing unmap bars on device removal net: ena: fix theoretical Rx hang on low memory systems net: ena: disable admin msix while working in polling mode net: ena: bug fix in lost tx packets detection mechanism drivers/net/ethernet/amazon/ena/ena_com.c | 35 +++-- drivers/net/ethernet/amazon/ena/ena_ethtool.c | 2 +- drivers/net/ethernet/amazon/ena/ena_netdev.c | 179 +++--- drivers/net/ethernet/amazon/ena/ena_netdev.h | 16 ++- 4 files changed, 168 insertions(+), 64 deletions(-) -- 2.7.4