Re: Fw: 2.6.18-rc4-mm3: BUG: warning at include/net/dst.h:154/dst_release()

2006-08-29 Thread Valdis . Kletnieks
On Tue, 29 Aug 2006 20:24:33 +0200, Thomas Graf said:

> > Seeing this a lot on 2.6.18-rc4-mm3 with 2 different stack tracebacks
> > (one for received packets, other for sending).  I already picked up the
> > fix for the ^ / confusion in fib_rules.c and that didn't help matters.
> 
> Should be fixed by this patch:
> 
> commit 4305fabb7e4c63ddc3a4fd38aab9ec3f6575b111
> Author: YOSHIFUJI Hideaki <[EMAIL PROTECTED]>
> Date:   Mon Aug 28 13:19:30 2006 -0700
> 
> [IPV6] ROUTE: Fix dst reference counting in ip6_pol_route_lookup().
> 
> In ip6_pol_route_lookup(), when we finish backtracking at the
> top-level root entry, we need to hold it.

Confirming patch fixes the problem I'm seeing, thanks...


pgpbHPZHNFMaY.pgp
Description: PGP signature


Re: Fw: 2.6.18-rc4-mm3: BUG: warning at include/net/dst.h:154/dst_release()

2006-08-29 Thread Thomas Graf
* Andrew Morton <[EMAIL PROTECTED]> 2006-08-29 09:16
> 
> 
> Begin forwarded message:
> 
> Date: Tue, 29 Aug 2006 10:25:07 -0400
> From: [EMAIL PROTECTED]
> To: Andrew Morton <[EMAIL PROTECTED]>
> Cc: linux-kernel@vger.kernel.org
> Subject: 2.6.18-rc4-mm3: BUG: warning at include/net/dst.h:154/dst_release()
> 
> 
> Seeing this a lot on 2.6.18-rc4-mm3 with 2 different stack tracebacks
> (one for received packets, other for sending).  I already picked up the
> fix for the ^ / confusion in fib_rules.c and that didn't help matters.

Should be fixed by this patch:

commit 4305fabb7e4c63ddc3a4fd38aab9ec3f6575b111
Author: YOSHIFUJI Hideaki <[EMAIL PROTECTED]>
Date:   Mon Aug 28 13:19:30 2006 -0700

[IPV6] ROUTE: Fix dst reference counting in ip6_pol_route_lookup().

In ip6_pol_route_lookup(), when we finish backtracking at the
top-level root entry, we need to hold it.

Bug noticed by Mitsuru Chinen <[EMAIL PROTECTED]>.

Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]>
Signed-off-by: David S. Miller <[EMAIL PROTECTED]>

diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index ad3e3fb..4a46a85 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -510,8 +510,8 @@ restart:
rt = fn->leaf;
rt = rt6_device_match(rt, fl->oif, flags);
BACKTRACK(&fl->fl6_src);
-   dst_hold(&rt->u.dst);
 out:
+   dst_hold(&rt->u.dst);
read_unlock_bh(&table->tb6_lock);

rt->u.dst.lastuse = jiffies;

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Fw: 2.6.18-rc4-mm3: BUG: warning at include/net/dst.h:154/dst_release()

2006-08-29 Thread Andrew Morton


Begin forwarded message:

Date: Tue, 29 Aug 2006 10:25:07 -0400
From: [EMAIL PROTECTED]
To: Andrew Morton <[EMAIL PROTECTED]>
Cc: linux-kernel@vger.kernel.org
Subject: 2.6.18-rc4-mm3: BUG: warning at include/net/dst.h:154/dst_release()


Seeing this a lot on 2.6.18-rc4-mm3 with 2 different stack tracebacks
(one for received packets, other for sending).  I already picked up the
fix for the ^ / confusion in fib_rules.c and that didn't help matters.

[  731.252000] BUG: warning at include/net/dst.h:154/dst_release()
[  731.252000]  [] dump_trace+0x64/0x1b2
[  731.252000]  [] show_trace_log_lvl+0x12/0x25
[  731.252000]  [] show_trace+0xd/0x10
[  731.252000]  [] dump_stack+0x19/0x1b
[  731.252000]  [] fib6_rule_action+0x79/0xad
[  731.253000]  [] fib_rules_lookup+0x4e/0x93
[  731.255000]  [] fib6_rule_lookup+0x2d/0x7d
[  731.256000]  [] rt6_lookup+0x45/0x83
[  731.257000]  [] addrconf_prefix_rcv+0xf4/0x743
[  731.258000]  [] ndisc_rcv+0x7d5/0xaf3
[  731.259000]  [] icmpv6_rcv+0x767/0x7e9
[  731.26]  [] ip6_input+0x1e0/0x2a2
[  731.262000]  [] ip6_mc_input+0x32/0x40
[  731.263000]  [] ipv6_rcv+0x19f/0x1cd
[  731.264000]  [] netif_receive_skb+0x143/0x1b6
[  731.265000]  [] process_backlog+0x71/0xf3
[  731.266000]  [] net_rx_action+0x56/0xcf
[  731.267000]  [] __do_softirq+0x38/0x7a
[  731.267000]  [] do_softirq+0x3e/0x87
[  731.267000]  [] irq_exit+0x28/0x34
[  731.267000]  [] do_IRQ+0xab/0xb8
[  731.267000]  [] common_interrupt+0x1a/0x20

[ 1498.555000] BUG: warning at include/net/dst.h:154/dst_release()
[ 1498.555000]  [] dump_trace+0x64/0x1b2
[ 1498.555000]  [] show_trace_log_lvl+0x12/0x25
[ 1498.555000]  [] show_trace+0xd/0x10
[ 1498.555000]  [] dump_stack+0x19/0x1b
[ 1498.555000]  [] fib6_rule_action+0x79/0xad
[ 1498.557000]  [] fib_rules_lookup+0x4e/0x93
[ 1498.558000]  [] fib6_rule_lookup+0x2d/0x7d
[ 1498.56]  [] ip6_route_output+0x21/0x24
[ 1498.561000]  [] ip6_dst_lookup_tail+0x19/0x92
[ 1498.562000]  [] ip6_dst_lookup+0xe/0x10
[ 1498.563000]  [] ip6_datagram_connect+0x322/0x50a
[ 1498.565000]  [] inet_dgram_connect+0x4b/0x55
[ 1498.566000]  [] sys_connect+0x67/0x84
[ 1498.567000]  [] sys_socketcall+0x8c/0x186
[ 1498.568000]  [] syscall_call+0x7/0xb
[ 1498.568000] DWARF2 unwinder stuck at syscall_call+0x7/0xb


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html