RE: [PATCH] Fix ethernet multicast for ucc_geth.
> -Original Message- > From: Joakim Tjernlund [mailto:[EMAIL PROTECTED] > Sent: Wednesday, October 17, 2007 5:06 PM > To: Netdev; Li Yang-r58472 > Subject: [PATCH] Fix ethernet multicast for ucc_geth. > > >From 5761a9e5924b34615c748fba2dcb977ed04c1243 Mon Sep 17 > 00:00:00 2001 > From: Joakim Tjernlund <[EMAIL PROTECTED]> > Date: Wed, 17 Oct 2007 11:01:44 +0200 > Subject: [PATCH] Fix ethernet multicast for ucc_geth. > hw_add_addr_in_hash() already swaps byte order, don't do it > in ucc_geth_set_multi() too. > > > Signed-off-by: Joakim Tjernlund <[EMAIL PROTECTED]> Acked-by: Li Yang <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] Fix ethernet multicast for ucc_geth.
> -Original Message- > From: Li Yang-r58472 [mailto:[EMAIL PROTECTED] > Sent: den 18 oktober 2007 16:24 > To: [EMAIL PROTECTED]; Netdev; [EMAIL PROTECTED] > Subject: RE: [PATCH] Fix ethernet multicast for ucc_geth. > > > -Original Message- > > From: Joakim Tjernlund [mailto:[EMAIL PROTECTED] > > Sent: Wednesday, October 17, 2007 5:06 PM > > To: Netdev; Li Yang-r58472 > > Subject: [PATCH] Fix ethernet multicast for ucc_geth. > > > > >From 5761a9e5924b34615c748fba2dcb977ed04c1243 Mon Sep 17 > > 00:00:00 2001 > > From: Joakim Tjernlund <[EMAIL PROTECTED]> > > Date: Wed, 17 Oct 2007 11:01:44 +0200 > > Subject: [PATCH] Fix ethernet multicast for ucc_geth. > > hw_add_addr_in_hash() already swaps byte order, don't do it > > in ucc_geth_set_multi() too. > > > > > > Signed-off-by: Joakim Tjernlund <[EMAIL PROTECTED]> > > Acked-by: Li Yang <[EMAIL PROTECTED]> > Ping? Did this make into a someones tree? Jocke - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Fix ethernet multicast for ucc_geth.
Joakim Tjernlund wrote: From 5761a9e5924b34615c748fba2dcb977ed04c1243 Mon Sep 17 00:00:00 2001 From: Joakim Tjernlund <[EMAIL PROTECTED]> Date: Wed, 17 Oct 2007 11:01:44 +0200 Subject: [PATCH] Fix ethernet multicast for ucc_geth. hw_add_addr_in_hash() already swaps byte order, don't do it in ucc_geth_set_multi() too. Signed-off-by: Joakim Tjernlund <[EMAIL PROTECTED]> --- drivers/net/ucc_geth.c | 15 ++- 1 files changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/net/ucc_geth.c b/drivers/net/ucc_geth.c index 61f5cce..f649b1e 100644 --- a/drivers/net/ucc_geth.c +++ b/drivers/net/ucc_geth.c @@ -2214,9 +2214,7 @@ static void ucc_geth_set_multi(struct net_device *dev) struct dev_mc_list *dmi; struct ucc_fast *uf_regs; struct ucc_geth_82xx_address_filtering_pram *p_82xx_addr_filt; - u8 tempaddr[6]; - u8 *mcptr, *tdptr; - int i, j; + int i; ugeth = netdev_priv(dev); @@ -2255,19 +2253,10 @@ static void ucc_geth_set_multi(struct net_device *dev) if (!(dmi->dmi_addr[0] & 1)) continue; -/* The address in dmi_addr is LSB first, -* and taddr is MSB first. We have to -* copy bytes MSB first from dmi_addr. -*/ - mcptr = (u8 *) dmi->dmi_addr + 5; - tdptr = (u8 *) tempaddr; - for (j = 0; j < 6; j++) - *tdptr++ = *mcptr--; - /* Ask CPM to run CRC and set bit in * filter mask. */ - hw_add_addr_in_hash(ugeth, tempaddr); + hw_add_addr_in_hash(ugeth, dmi->dmi_addr); did the maintainer ever ACK this? - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] Fix ethernet multicast for ucc_geth.
> > @@ -2255,19 +2253,10 @@ static void > ucc_geth_set_multi(struct net_device *dev) > > if (!(dmi->dmi_addr[0] & 1)) > > continue; > > > > - /* The address in dmi_addr is LSB first, > > -* and taddr is MSB first. We have to > > -* copy bytes MSB first from dmi_addr. > > -*/ > > - mcptr = (u8 *) dmi->dmi_addr + 5; > > - tdptr = (u8 *) tempaddr; > > - for (j = 0; j < 6; j++) > > - *tdptr++ = *mcptr--; > > - > > /* Ask CPM to run CRC and set bit in > > * filter mask. > > */ > > - hw_add_addr_in_hash(ugeth, tempaddr); > > + hw_add_addr_in_hash(ugeth, > dmi->dmi_addr); > > did the maintainer ever ACK this? Yes, I did. :) - Leo - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Fix ethernet multicast for ucc_geth.
Joakim Tjernlund wrote: From 5761a9e5924b34615c748fba2dcb977ed04c1243 Mon Sep 17 00:00:00 2001 From: Joakim Tjernlund <[EMAIL PROTECTED]> Date: Wed, 17 Oct 2007 11:01:44 +0200 Subject: [PATCH] Fix ethernet multicast for ucc_geth. hw_add_addr_in_hash() already swaps byte order, don't do it in ucc_geth_set_multi() too. Signed-off-by: Joakim Tjernlund <[EMAIL PROTECTED]> --- drivers/net/ucc_geth.c | 15 ++- 1 files changed, 2 insertions(+), 13 deletions(-) applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
