Re: [net-next PATCH 3/3] net sched actions: aggregate dumping of actions timeinfo

[Jamal Hadi Salim]

On 16-06-06 01:39 AM, Cong Wang wrote:

On Sun, Jun 5, 2016 at 7:26 AM, Jamal Hadi Salim  wrote:

diff --git a/include/net/act_api.h b/include/net/act_api.h
index 8389c00..5453f52 100644
--- a/include/net/act_api.h
+++ b/include/net/act_api.h
@@ -80,6 +80,14 @@ static inline void tcf_lastuse_update(struct tcf_t *tm)
 tm->firstuse = now;
  }

+static inline void tcf_tm_dump(struct tcf_t *dtm, struct tcf_t *stm)


Nit: const struct tcf_t *stm. ;)



Ok, here comes a patch ;->

cheers,
jamal

Re: [net-next PATCH 3/3] net sched actions: aggregate dumping of actions timeinfo

[Cong Wang]

On Sun, Jun 5, 2016 at 7:26 AM, Jamal Hadi Salim  wrote:
> diff --git a/include/net/act_api.h b/include/net/act_api.h
> index 8389c00..5453f52 100644
> --- a/include/net/act_api.h
> +++ b/include/net/act_api.h
> @@ -80,6 +80,14 @@ static inline void tcf_lastuse_update(struct tcf_t *tm)
> tm->firstuse = now;
>  }
>
> +static inline void tcf_tm_dump(struct tcf_t *dtm, struct tcf_t *stm)

Nit: const struct tcf_t *stm. ;)

The rest looks good.

Thanks.