Re: [PATCH nf-next] netfilter: nf_conntrack: Increase __IPS_MAX_BIT with new bit IPS_OFFLOAD_BIT

2018-06-07 Thread Pablo Neira Ayuso 
On Thu, Jun 07, 2018 at 06:15:14PM +0800, gfree.w...@vip.163.com wrote:
> From: Gao Feng 
> 
> The __IPS_MAX_BIT is used in __ctnetlink_change_status as the max bit
> value. When add new bit IPS_OFFLOAD_BIT whose value is 14, we should
> increase the __IPS_MAX_BIT too, from 14 to 15.
> 
> There is no any bug in current codes, although it lost one loop in
> __ctnetlink_change_status. Because the new bit IPS_OFFLOAD_BIT belongs
> the IPS_UNCHANGEABLE_MASK.

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH nf-next] netfilter: nf_conntrack: Increase __IPS_MAX_BIT with new bit IPS_OFFLOAD_BIT

2018-06-07 Thread gfree . wind 
From: Gao Feng 

The __IPS_MAX_BIT is used in __ctnetlink_change_status as the max bit
value. When add new bit IPS_OFFLOAD_BIT whose value is 14, we should
increase the __IPS_MAX_BIT too, from 14 to 15.

There is no any bug in current codes, although it lost one loop in
__ctnetlink_change_status. Because the new bit IPS_OFFLOAD_BIT belongs
the IPS_UNCHANGEABLE_MASK.

Signed-off-by: Gao Feng 
---
 include/uapi/linux/netfilter/nf_conntrack_common.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/uapi/linux/netfilter/nf_conntrack_common.h 
b/include/uapi/linux/netfilter/nf_conntrack_common.h
index c712eb6..336014b 100644
--- a/include/uapi/linux/netfilter/nf_conntrack_common.h
+++ b/include/uapi/linux/netfilter/nf_conntrack_common.h
@@ -112,7 +112,7 @@ enum ip_conntrack_status {
 IPS_EXPECTED | IPS_CONFIRMED | IPS_DYING |
 IPS_SEQ_ADJUST | IPS_TEMPLATE | IPS_OFFLOAD),
 
-   __IPS_MAX_BIT = 14,
+   __IPS_MAX_BIT = 15,
 };
 
 /* Connection tracking event types */
-- 
1.9.1


--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html