[GitHub] [apisix] monkeyDluffy6017 commented on a diff in pull request #9927: chore(ci): automate management of unresponded issues
monkeyDluffy6017 commented on code in PR #9927: URL: https://github.com/apache/apisix/pull/9927#discussion_r1282613816 ## .github/workflows/remove-wait-for-update-label.yml: ## Review Comment: I think you should rename this file? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] monkeyDluffy6017 commented on a diff in pull request #9927: chore(ci): automate management of unresponded issues
monkeyDluffy6017 commented on code in PR #9927: URL: https://github.com/apache/apisix/pull/9927#discussion_r1282982508 ## .github/workflows/update-labels.yml: ## @@ -0,0 +1,18 @@ +name: Update label when user responds +permissions: + issues: write + +on: + issue_comment: +types: [created] Review Comment: Do we need to trigger this every comment? how about just like the `close-unresponded.yml`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] monkeyDluffy6017 commented on a diff in pull request #9927: chore(ci): automate management of unresponded issues
monkeyDluffy6017 commented on code in PR #9927: URL: https://github.com/apache/apisix/pull/9927#discussion_r1282982980 ## .github/workflows/update-labels.yml: ## @@ -0,0 +1,18 @@ +name: Update label when user responds +permissions: + issues: write + +on: + issue_comment: +types: [created] + +jobs: + run-check: +runs-on: ubuntu-latest +steps: + - name: Remove label when user responds Review Comment: ```suggestion - name: Rename the label when user responds ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] monkeyDluffy6017 commented on a diff in pull request #9927: chore(ci): automate management of unresponded issues
monkeyDluffy6017 commented on code in PR #9927: URL: https://github.com/apache/apisix/pull/9927#discussion_r1282988073 ## .github/workflows/update-labels.yml: ## @@ -0,0 +1,18 @@ +name: Update label when user responds +permissions: + issues: write + +on: + issue_comment: +types: [created] + +jobs: + run-check: +runs-on: ubuntu-latest +steps: + - name: Remove label when user responds +uses: andymckay/labeler@master +if: ${{ github.event.comment.user.login == github.event.issue.user.login && contains(github.event.issue.labels.*.name, 'wait for update') && !contains(github.event.issue.labels.*.name, 'user responded') }} Review Comment: What happends if the user respond an issue with the label "no response"? Should we change the label "no response" to "user responded"? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] monkeyDluffy6017 commented on a diff in pull request #9927: chore(ci): automate management of unresponded issues
monkeyDluffy6017 commented on code in PR #9927: URL: https://github.com/apache/apisix/pull/9927#discussion_r1284051933 ## .github/workflows/update-labels.yml: ## @@ -0,0 +1,22 @@ +name: Update label when user responds +permissions: + issues: write + +on: + issue_comment: +types: [created] + +jobs: + run-check: +runs-on: ubuntu-latest +steps: + - name: update labels when user responds +uses: andymckay/labeler@master +if: ${{ github.event.comment.user.login == github.event.issue.user.login && contains(github.event.issue.labels.*.name, 'wait for update') && !contains(github.event.issue.labels.*.name, 'user responded') }} +with: + add-labels: 'user responded' + remove-labels: 'wait for update' +if: ${{ github.event.comment.user.login == github.event.issue.user.login && contains(github.event.issue.labels.*.name, 'no response') && contains(github.event.issue.labels.*.name, 'wait for update') && !contains(github.event.issue.labels.*.name, 'user responded') }} Review Comment: Why do you add this condition `contains(github.event.issue.labels.*.name, 'no response') && contains(github.event.issue.labels.*.name, 'wait for update')` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] monkeyDluffy6017 commented on a diff in pull request #9927: chore(ci): automate management of unresponded issues
monkeyDluffy6017 commented on code in PR #9927: URL: https://github.com/apache/apisix/pull/9927#discussion_r1285450825 ## .github/workflows/update-labels.yml: ## @@ -0,0 +1,22 @@ +name: Update label when user responds +permissions: + issues: write + +on: + issue_comment: +types: [created] + +jobs: + run-check: +runs-on: ubuntu-latest +steps: + - name: update labels when user responds +uses: andymckay/labeler@master +if: ${{ github.event.comment.user.login == github.event.issue.user.login && contains(github.event.issue.labels.*.name, 'wait for update') && !contains(github.event.issue.labels.*.name, 'user responded') }} +with: + add-labels: 'user responded' + remove-labels: 'wait for update' +if: ${{ github.event.comment.user.login == github.event.issue.user.login && contains(github.event.issue.labels.*.name, 'no response') && contains(github.event.issue.labels.*.name, 'wait for update') && !contains(github.event.issue.labels.*.name, 'user responded') }} Review Comment: It's very werid, do you notice the logic relationship `&&`, does it mean the label should contain both `no response` and `wait for update`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] monkeyDluffy6017 commented on a diff in pull request #9927: chore(ci): automate management of unresponded issues
monkeyDluffy6017 commented on code in PR #9927: URL: https://github.com/apache/apisix/pull/9927#discussion_r1285457174 ## .github/workflows/update-labels.yml: ## @@ -0,0 +1,22 @@ +name: Update label when user responds +permissions: + issues: write + +on: + issue_comment: +types: [created] + +jobs: + run-check: +runs-on: ubuntu-latest +steps: + - name: update labels when user responds +uses: andymckay/labeler@master +if: ${{ github.event.comment.user.login == github.event.issue.user.login && contains(github.event.issue.labels.*.name, 'wait for update') && !contains(github.event.issue.labels.*.name, 'user responded') }} +with: + add-labels: 'user responded' + remove-labels: 'wait for update' +if: ${{ github.event.comment.user.login == github.event.issue.user.login && contains(github.event.issue.labels.*.name, 'no response') && contains(github.event.issue.labels.*.name, 'wait for update') && !contains(github.event.issue.labels.*.name, 'user responded') }} Review Comment: OK, i get you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org