[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #774: fix: delete the cluster object when give up the leadership

2021-12-07 Thread GitBox


tokers commented on a change in pull request #774:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/774#discussion_r763953716



##
File path: tools.go
##
@@ -1,3 +1,4 @@
+//go:build tools

Review comment:
   I have updated it but I don't have time to validate the e2e case until 
this weekend.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #774: fix: delete the cluster object when give up the leadership

2021-11-29 Thread GitBox


tokers commented on a change in pull request #774:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/774#discussion_r758871044



##
File path: tools.go
##
@@ -1,3 +1,4 @@
+//go:build tools

Review comment:
   Removed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org