Change in asterixdb[master]: [NO ISSUE][HYR][*DB][HTTP][TEST] Minor refactoring / test fu...

[Till Westmann (Code Review)]

Till Westmann has submitted this change and it was merged.

Change subject: [NO ISSUE][HYR][*DB][HTTP][TEST] Minor refactoring / test 
functionality
..


[NO ISSUE][HYR][*DB][HTTP][TEST] Minor refactoring / test functionality

Adds ability to indicate which status code(s) to accept for an HTTP
request, instead of just 200.

Change-Id: I1f134d7874cc7de712e60911e89dac446c5c2cfd
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1948
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
Contrib: Jenkins 
Integration-Tests: Jenkins 
Reviewed-by: Till Westmann 
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterApiServlet.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
M 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/utils/HttpUtil.java
3 files changed, 76 insertions(+), 49 deletions(-)

Approvals:
  Till Westmann: Looks good to me, approved
  Jenkins: Verified; No violations found; ; Verified

Objections:
  Anon. E. Moose #1000171: 



diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterApiServlet.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterApiServlet.java
index 82e8f7a..b24a9a1 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterApiServlet.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterApiServlet.java
@@ -26,7 +26,6 @@
 import java.util.function.Predicate;
 import java.util.logging.Level;
 import java.util.logging.Logger;
-import java.util.regex.Pattern;
 
 import org.apache.asterix.runtime.utils.CcApplicationContext;
 import org.apache.asterix.runtime.utils.ClusterStateManager;
@@ -50,7 +49,6 @@
 public class ClusterApiServlet extends AbstractServlet {
 
 private static final Logger LOGGER = 
Logger.getLogger(ClusterApiServlet.class.getName());
-private static final Pattern PARENT_DIR = 
Pattern.compile("/[^./]+/\\.\\./");
 protected static final String NODE_ID_KEY = "node_id";
 protected static final String CONFIG_URI_KEY = "configUri";
 protected static final String STATS_URI_KEY = "statsUri";
@@ -104,15 +102,8 @@
 Section.COMMON, getConfigSelector()));
 
 ArrayNode ncs = (ArrayNode) json.get("ncs");
-final StringBuilder requestURL = new StringBuilder("http://;);
-requestURL.append(request.getHeader(HttpHeaderNames.HOST));
-requestURL.append(request.getHttpRequest().uri());
-if (requestURL.charAt(requestURL.length() - 1) != '/') {
-requestURL.append('/');
-}
-requestURL.append(pathToNode);
-String clusterURL = canonicalize(requestURL);
-String adminURL = canonicalize(clusterURL + "../");
+String clusterURL = resolveClusterUrl(request, pathToNode);
+String adminURL = HttpUtil.canonicalize(clusterURL + "../");
 String nodeURL = clusterURL + "node/";
 for (int i = 0; i < ncs.size(); i++) {
 ObjectNode nc = (ObjectNode) ncs.get(i);
@@ -137,18 +128,20 @@
 return json;
 }
 
+protected String resolveClusterUrl(IServletRequest request, String 
pathToNode) {
+final StringBuilder requestURL = new StringBuilder("http://;);
+requestURL.append(request.getHeader(HttpHeaderNames.HOST));
+requestURL.append(request.getHttpRequest().uri());
+if (requestURL.charAt(requestURL.length() - 1) != '/') {
+requestURL.append('/');
+}
+requestURL.append(pathToNode);
+return HttpUtil.canonicalize(requestURL);
+}
+
 protected Predicate getConfigSelector() {
 return option -> !option.hidden() && option != 
ControllerConfig.Option.CONFIG_FILE
 && option != ControllerConfig.Option.CONFIG_FILE_URL;
 }
 
-private String canonicalize(CharSequence requestURL) {
-String clusterURL = "";
-String newClusterURL = requestURL.toString();
-while (!clusterURL.equals(newClusterURL)) {
-clusterURL = newClusterURL;
-newClusterURL = PARENT_DIR.matcher(clusterURL).replaceAll("/");
-}
-return clusterURL;
-}
 }
diff --git 
a/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
 
b/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
index a96adc0..e07ec72 100644
--- 
a/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
+++ 
b/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
@@ -103,17 +103,18 @@
 // see
 // 

Change in asterixdb[master]: [NO ISSUE][HYR][*DB][HTTP][TEST] Minor refactoring / test fu...

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: [NO ISSUE][HYR][*DB][HTTP][TEST] Minor refactoring / test 
functionality
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1948
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1f134d7874cc7de712e60911e89dac446c5c2cfd
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON
..


Patch Set 15: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3765/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1885
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357
Gerrit-PatchSet: 15
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: shi...@uci.edu
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Shiva Jahangiri 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON
..


Patch Set 15:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3765/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1885
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357
Gerrit-PatchSet: 15
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: shi...@uci.edu
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Shiva Jahangiri 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON
..


Patch Set 15:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/1600/ (11/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1885
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357
Gerrit-PatchSet: 15
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: shi...@uci.edu
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Shiva Jahangiri 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON
..


Patch Set 15:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/679/ (4/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1885
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357
Gerrit-PatchSet: 15
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: shi...@uci.edu
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Shiva Jahangiri 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON
..


Patch Set 15:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/1422/ 
(2/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1885
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357
Gerrit-PatchSet: 15
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: shi...@uci.edu
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Shiva Jahangiri 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON
..


Patch Set 15:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/4758/ (3/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1885
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357
Gerrit-PatchSet: 15
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: shi...@uci.edu
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Shiva Jahangiri 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON
..


Patch Set 15:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/683/
 (6/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1885
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357
Gerrit-PatchSet: 15
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: shi...@uci.edu
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Shiva Jahangiri 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON
..


Patch Set 15:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-rebalance-cancellation/500/
 (9/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1885
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357
Gerrit-PatchSet: 15
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: shi...@uci.edu
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Shiva Jahangiri 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON
..


Patch Set 15:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/6239/ (1/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1885
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357
Gerrit-PatchSet: 15
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: shi...@uci.edu
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Shiva Jahangiri 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON
..


Patch Set 15:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1364/
 (8/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1885
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357
Gerrit-PatchSet: 15
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: shi...@uci.edu
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Shiva Jahangiri 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON
..


Patch Set 15:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/1298/ (10/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1885
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357
Gerrit-PatchSet: 15
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: shi...@uci.edu
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Shiva Jahangiri 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON
..


Patch Set 15:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/684/ 
(7/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1885
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357
Gerrit-PatchSet: 15
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: shi...@uci.edu
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Shiva Jahangiri 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON
..


Patch Set 15:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1020/ 
(5/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1885
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357
Gerrit-PatchSet: 15
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: shi...@uci.edu
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Shiva Jahangiri 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON

[Anon. E. Moose (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1885

to look at the new patch set (#15).

Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON
..

[UI] Allow logical plan to be viewed as JSON / formatted JSON

- user model changes: no
- storage format changes: no
- interface changes: enhancements to the web interface

details:
Added drop-down menu for printing logical plan and optimized
logical plan in string,json, and clean-json.

Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SessionConfig.java
M asterixdb/asterix-app/pom.xml
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/RestApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/java/AsterixJavaClient.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/drivers/AsterixClientDriver.java
M asterixdb/asterix-app/src/main/resources/webui/querytemplate.html
M asterixdb/asterix-app/src/main/resources/webui/static/css/style.css
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/jsonplan/JsonLogicalPlanTest.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/jsonplan/JsonOptimizedLogicalPlanTest.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractLogicalOperator.java
A 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitorJson.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/PlanPrettyPrinter.java
M 
hyracks-fullstack/algebricks/algebricks-examples/piglet-example/src/main/java/org/apache/hyracks/algebricks/examples/piglet/compiler/PigletCompiler.java
16 files changed, 1,216 insertions(+), 137 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/85/1885/15
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1885
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357
Gerrit-PatchSet: 15
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: shi...@uci.edu
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Shiva Jahangiri 
Gerrit-Reviewer: Till Westmann 

Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON

[Shiva Jahangiri (Code Review)]

Shiva Jahangiri has posted comments on this change.

Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON
..


Patch Set 14:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1885/14/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/RestApiServlet.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/RestApiServlet.java:

Line 96: 
> MAJOR SonarQube violation:
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1885
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357
Gerrit-PatchSet: 14
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: shi...@uci.edu
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Shiva Jahangiri 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: Yes

[jira] [Closed] (ASTERIXDB-2044) Listify in subqueries

[Yingyi Bu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ASTERIXDB-2044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yingyi Bu closed ASTERIXDB-2044.

Resolution: Fixed

> Listify in subqueries
> -
>
> Key: ASTERIXDB-2044
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-2044
> Project: Apache AsterixDB
>  Issue Type: Bug
>  Components: COMP - Compiler
>Reporter: Yingyi Bu
>Assignee: Yingyi Bu
>
> The following query will result in unnecessary listifies in the optimized 
> query plan.
> {noformat}
> DROP  DATAVERSE tpch IF EXISTS;
> CREATE  dataverse tpch;
> USE tpch;
> CREATE TYPE LineItemType AS CLOSED {
>   l_orderkey : integer,
>   l_partkey : integer,
>   l_suppkey : integer,
>   l_linenumber : integer,
>   l_quantity : double,
>   l_extendedprice : double,
>   l_discount : double,
>   l_tax : double,
>   l_returnflag : string,
>   l_linestatus : string,
>   l_shipdate : string,
>   l_commitdate : string,
>   l_receiptdate : string,
>   l_shipinstruct : string,
>   l_shipmode : string,
>   l_comment : string
> }
> CREATE DATASET LineItem(LineItemType) PRIMARY KEY l_orderkey,l_linenumber;
> SELECT l_returnflag AS l_returnflag,
>l_linestatus AS l_linestatus,
>coll_count(cheap) AS count_cheaps,
>coll_count(expensive) AS count_expensives
> FROM LineItem AS l
> /* +hash */
> GROUP BY l.l_returnflag AS l_returnflag,l.l_linestatus AS l_linestatus
> GROUP AS g
> LET cheap = (
>   SELECT ELEMENT m
>   FROM (FROM g SELECT VALUE l) AS m
>   WHERE m.l_discount > 0.05
> ),
> expensive = (
>   SELECT ELEMENT m
>   FROM (FROM g SELECT VALUE l) AS m
>   WHERE m.l_discount <= 0.05
> )
> ORDER BY l_returnflag,l_linestatus
> ;
> {noformat}
> {noformat}
> distribute result [$$31]
> -- DISTRIBUTE_RESULT  |PARTITIONED|
>   exchange
>   -- ONE_TO_ONE_EXCHANGE  |PARTITIONED|
> project ([$$31])
> -- STREAM_PROJECT  |PARTITIONED|
>   assign [$$31] <- [{"l_returnflag": $$l_returnflag, "l_linestatus": 
> $$l_linestatus, "count_cheaps": $$36, "count_expensives": $$37}]
>   -- ASSIGN  |PARTITIONED|
> exchange
> -- SORT_MERGE_EXCHANGE [$$l_returnflag(ASC), $$l_linestatus(ASC) ]  
> |PARTITIONED|
>   project ([$$l_returnflag, $$l_linestatus, $$36, $$37])
>   -- STREAM_PROJECT  |PARTITIONED|
> subplan {
>   aggregate [$$37] <- [agg-count($$m)]
>   -- AGGREGATE  |LOCAL|
> select (le($$39, 0.05))
> -- STREAM_SELECT  |LOCAL|
>   assign [$$39] <- [$$m.getField(6)]
>   -- ASSIGN  |LOCAL|
> unnest $$m <- scan-collection($$24)
> -- UNNEST  |LOCAL|
>   subplan {
> aggregate [$$24] <- [listify($$23)]
> -- AGGREGATE  |LOCAL|
>   assign [$$23] <- [$$g.getField(0)]
>   -- ASSIGN  |LOCAL|
> unnest $$g <- 
> scan-collection($$15)
> -- UNNEST  |LOCAL|
>   nested tuple source
>   -- NESTED_TUPLE_SOURCE  |LOCAL|
>  }
>   -- SUBPLAN  |LOCAL|
> nested tuple source
> -- NESTED_TUPLE_SOURCE  |LOCAL|
>}
> -- SUBPLAN  |PARTITIONED|
>   subplan {
> aggregate [$$36] <- [agg-count($$m)]
> -- AGGREGATE  |LOCAL|
>   select (gt($$38, 0.05))
>   -- STREAM_SELECT  |LOCAL|
> assign [$$38] <- [$$m.getField(6)]
> -- ASSIGN  |LOCAL|
>   unnest $$m <- scan-collection($$18)
>   -- UNNEST  |LOCAL|
> subplan {
>   aggregate [$$18] <- [listify($$17)]
>   -- AGGREGATE  |LOCAL|
> assign [$$17] <- [$$g.getField(0)]
> -- ASSIGN  |LOCAL|
>   unnest $$g <- 
> scan-collection($$15)
>   -- UNNEST  |LOCAL|
> nested tuple source
> -- NESTED_TUPLE_SOURCE  
> |LOCAL|
>}
> 

[jira] [Commented] (ASTERIXDB-2044) Listify in subqueries

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ASTERIXDB-2044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131526#comment-16131526
 ] 

ASF subversion and git services commented on ASTERIXDB-2044:


Commit 5170fb212aa0e2c1e93327553fc38b6acd22c73b in asterixdb's branch 
refs/heads/master from [~buyingyi]
[ https://git-wip-us.apache.org/repos/asf?p=asterixdb.git;h=5170fb2 ]

[ASTERIXDB-2044][COMP] Eliminate listify for complex group-by

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Fix EliminateSubplanWithInputCardinalityOneRule to handle recursive
  subplans;
- Fix various places that assumes the nested plans inside a group-by
  operator cannot be empty;
- Added regression tests.

Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1946
Integration-Tests: Jenkins 
Tested-by: Jenkins 
Contrib: Jenkins 
Reviewed-by: Yingyi Bu 


> Listify in subqueries
> -
>
> Key: ASTERIXDB-2044
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-2044
> Project: Apache AsterixDB
>  Issue Type: Bug
>  Components: COMP - Compiler
>Reporter: Yingyi Bu
>Assignee: Yingyi Bu
>
> The following query will result in unnecessary listifies in the optimized 
> query plan.
> {noformat}
> DROP  DATAVERSE tpch IF EXISTS;
> CREATE  dataverse tpch;
> USE tpch;
> CREATE TYPE LineItemType AS CLOSED {
>   l_orderkey : integer,
>   l_partkey : integer,
>   l_suppkey : integer,
>   l_linenumber : integer,
>   l_quantity : double,
>   l_extendedprice : double,
>   l_discount : double,
>   l_tax : double,
>   l_returnflag : string,
>   l_linestatus : string,
>   l_shipdate : string,
>   l_commitdate : string,
>   l_receiptdate : string,
>   l_shipinstruct : string,
>   l_shipmode : string,
>   l_comment : string
> }
> CREATE DATASET LineItem(LineItemType) PRIMARY KEY l_orderkey,l_linenumber;
> SELECT l_returnflag AS l_returnflag,
>l_linestatus AS l_linestatus,
>coll_count(cheap) AS count_cheaps,
>coll_count(expensive) AS count_expensives
> FROM LineItem AS l
> /* +hash */
> GROUP BY l.l_returnflag AS l_returnflag,l.l_linestatus AS l_linestatus
> GROUP AS g
> LET cheap = (
>   SELECT ELEMENT m
>   FROM (FROM g SELECT VALUE l) AS m
>   WHERE m.l_discount > 0.05
> ),
> expensive = (
>   SELECT ELEMENT m
>   FROM (FROM g SELECT VALUE l) AS m
>   WHERE m.l_discount <= 0.05
> )
> ORDER BY l_returnflag,l_linestatus
> ;
> {noformat}
> {noformat}
> distribute result [$$31]
> -- DISTRIBUTE_RESULT  |PARTITIONED|
>   exchange
>   -- ONE_TO_ONE_EXCHANGE  |PARTITIONED|
> project ([$$31])
> -- STREAM_PROJECT  |PARTITIONED|
>   assign [$$31] <- [{"l_returnflag": $$l_returnflag, "l_linestatus": 
> $$l_linestatus, "count_cheaps": $$36, "count_expensives": $$37}]
>   -- ASSIGN  |PARTITIONED|
> exchange
> -- SORT_MERGE_EXCHANGE [$$l_returnflag(ASC), $$l_linestatus(ASC) ]  
> |PARTITIONED|
>   project ([$$l_returnflag, $$l_linestatus, $$36, $$37])
>   -- STREAM_PROJECT  |PARTITIONED|
> subplan {
>   aggregate [$$37] <- [agg-count($$m)]
>   -- AGGREGATE  |LOCAL|
> select (le($$39, 0.05))
> -- STREAM_SELECT  |LOCAL|
>   assign [$$39] <- [$$m.getField(6)]
>   -- ASSIGN  |LOCAL|
> unnest $$m <- scan-collection($$24)
> -- UNNEST  |LOCAL|
>   subplan {
> aggregate [$$24] <- [listify($$23)]
> -- AGGREGATE  |LOCAL|
>   assign [$$23] <- [$$g.getField(0)]
>   -- ASSIGN  |LOCAL|
> unnest $$g <- 
> scan-collection($$15)
> -- UNNEST  |LOCAL|
>   nested tuple source
>   -- NESTED_TUPLE_SOURCE  |LOCAL|
>  }
>   -- SUBPLAN  |LOCAL|
> nested tuple source
> -- NESTED_TUPLE_SOURCE  |LOCAL|
>}
> -- SUBPLAN  |PARTITIONED|
>   subplan {
> aggregate [$$36] <- [agg-count($$m)]
> -- AGGREGATE  |LOCAL|
>   select (gt($$38, 0.05))
>   -- STREAM_SELECT  |LOCAL|
>  

Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by

[Yingyi Bu (Code Review)]

Yingyi Bu has submitted this change and it was merged.

Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
..


[ASTERIXDB-2044][COMP] Eliminate listify for complex group-by

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Fix EliminateSubplanWithInputCardinalityOneRule to handle recursive
  subplans;
- Fix various places that assumes the nested plans inside a group-by
  operator cannot be empty;
- Added regression tests.

Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1946
Integration-Tests: Jenkins 
Tested-by: Jenkins 
Contrib: Jenkins 
Reviewed-by: Yingyi Bu 
---
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/query-ASTERIXDB-810-2.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/query-ASTERIXDB-810.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/query-ASTERIXDB-810-2.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/query-ASTERIXDB-810.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/udfs/query-ASTERIXDB-1308-1.plan
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/PreclusteredGroupByPOperator.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/typing/AbstractTypeEnvironment.java
M 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/AbstractIntroduceGroupByCombinerRule.java
M 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/PushNestedOrderByUnderPreSortedGroupByRule.java
M 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/subplan/EliminateSubplanWithInputCardinalityOneRule.java
10 files changed, 277 insertions(+), 46 deletions(-)

Approvals:
  Yingyi Bu: Looks good to me, approved
  Anon. E. Moose #1000171: 
  Jenkins: Verified; ; Verified

Objections:
  Jenkins: Violations found



diff --git 
a/asterixdb/asterix-app/src/test/resources/optimizerts/queries/query-ASTERIXDB-810-2.sqlpp
 
b/asterixdb/asterix-app/src/test/resources/optimizerts/queries/query-ASTERIXDB-810-2.sqlpp
new file mode 100644
index 000..b6f6159
--- /dev/null
+++ 
b/asterixdb/asterix-app/src/test/resources/optimizerts/queries/query-ASTERIXDB-810-2.sqlpp
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+/*
+ * Description  : This test case is to verify the fix for issue810
+ * https://code.google.com/p/asterixdb/issues/detail?id=810
+ * Expected Res : SUCCESS
+ * Date : 16th Nov. 2014
+ */
+
+DROP  DATAVERSE tpch IF EXISTS;
+CREATE  dataverse tpch;
+
+USE tpch;
+
+
+CREATE TYPE LineItemType AS CLOSED {
+  l_orderkey : integer,
+  l_partkey : integer,
+  l_suppkey : integer,
+  l_linenumber : integer,
+  l_quantity : double,
+  l_extendedprice : double,
+  l_discount : double,
+  l_tax : double,
+  l_returnflag : string,
+  l_linestatus : string,
+  l_shipdate : string,
+  l_commitdate : string,
+  l_receiptdate : string,
+  l_shipinstruct : string,
+  l_shipmode : string,
+  l_comment : string
+}
+
+CREATE DATASET LineItem(LineItemType) PRIMARY KEY l_orderkey,l_linenumber;
+
+
+SELECT l_returnflag AS l_returnflag,
+   l_linestatus AS l_linestatus,
+   coll_count(cheap) AS count_cheaps,
+   coll_count(expensive) AS count_expensives
+FROM LineItem AS l
+/* +hash */
+GROUP BY l.l_returnflag AS l_returnflag,l.l_linestatus AS l_linestatus
+GROUP AS g
+LET cheap = (
+  SELECT ELEMENT g.l
+  FROM g
+  WHERE g.l.l_discount > 0.05
+),
+expensive = (
+  SELECT ELEMENT g.l
+  FROM g
+  WHERE g.l.l_discount <= 0.05
+)
+ORDER BY l_returnflag,l_linestatus
+;
diff --git 
a/asterixdb/asterix-app/src/test/resources/optimizerts/queries/query-ASTERIXDB-810.sqlpp
 

Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
..


Patch Set 5: Code-Review+2

Fwd Dmitry's +2.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1946
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by

[Anon. E. Moose (Code Review)]

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
..


Patch Set 5: Contrib+1

Analytics Compatibility Tests Successful Build 2466
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1946
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

[jira] [Created] (ASTERIXDB-2047) Strange/wrong behavior in console with Formatted JSON and multiple statements

[Michael J. Carey (JIRA)]

Michael J. Carey created ASTERIXDB-2047:
---

 Summary: Strange/wrong behavior in console with Formatted JSON and 
multiple statements
 Key: ASTERIXDB-2047
 URL: https://issues.apache.org/jira/browse/ASTERIXDB-2047
 Project: Apache AsterixDB
  Issue Type: Bug
  Components: *DB - AsterixDB, UI - Web Interface
Reporter: Michael J. Carey
Assignee: Xikui Wang


Consider running the following kind of statement sequence two ways - first with 
unformatted and with formatted JSON.  With larger JSON objects than this 
unsuccessful repro attempt, sometimes the formatted version doesn't show all of 
the returned data from the query.  Also, it leaves the browser in a bad way so 
that it no longer reliably shows all of the results of subsequent queries.  

DELETE FROM foo;

SELECT s FROM foo s;

INSERT INTO foo
{
  "key": "xxx123",
  "class": "CS122a",
  "content": {
"DateFrom": "Jan 31, 2012",
"DateTo": "Apr 09, 2013"
  }
};

SELECT s FROM foo s;

INSERT INTO foo
  {
"rec": {
  "binary": false,
  "class": "CS122b",
  "content": {
"backOrder": false,
"frontOrder": true,
"width": 100
  },
  "multiplicationKey": "12"
}
  };

SELECT s FROM foo s;




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
..


Patch Set 5: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1657/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1946
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
..


Patch Set 5:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1657/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1946
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

[jira] [Commented] (ASTERIXDB-2045) Failed flush shouldn't wait for lagging merge

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ASTERIXDB-2045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131361#comment-16131361
 ] 

ASF subversion and git services commented on ASTERIXDB-2045:


Commit fcd89f5a92a80b2b69d99845471856a5909be9a8 in asterixdb's branch 
refs/heads/master from [~mhubail]
[ https://git-wip-us.apache.org/repos/asf?p=asterixdb.git;h=fcd89f5 ]

[ASTERIXDB-2045][STO] Do Not Wait For Lagging Merge on Failed Flush

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Failed flush operations shouldn't wait for lagging merges
  since they won't add any new disk components.
- Use logger to log exceptions.

Change-Id: I915e993a76d5c692a276b1d7f3426a25f910cf46
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1947
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
Contrib: Jenkins 
Integration-Tests: Jenkins 
Reviewed-by: abdullah alamoudi 


> Failed flush shouldn't wait for lagging merge
> -
>
> Key: ASTERIXDB-2045
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-2045
> Project: Apache AsterixDB
>  Issue Type: Bug
>Reporter: Murtadha Hubail
>Assignee: Murtadha Hubail
>
> A failed flush shouldn't wait for lagging merge since it is not going to add 
> more disk components.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Change in asterixdb[master]: [ASTERIXDB-2045][STO] Do Not Wait For Lagging Merge on Faile...

[Murtadha Hubail (Code Review)]

Murtadha Hubail has submitted this change and it was merged.

Change subject: [ASTERIXDB-2045][STO] Do Not Wait For Lagging Merge on Failed 
Flush
..


[ASTERIXDB-2045][STO] Do Not Wait For Lagging Merge on Failed Flush

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Failed flush operations shouldn't wait for lagging merges
  since they won't add any new disk components.
- Use logger to log exceptions.

Change-Id: I915e993a76d5c692a276b1d7f3426a25f910cf46
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1947
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
Contrib: Jenkins 
Integration-Tests: Jenkins 
Reviewed-by: abdullah alamoudi 
---
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java
1 file changed, 45 insertions(+), 16 deletions(-)

Approvals:
  Anon. E. Moose #1000171: 
  abdullah alamoudi: Looks good to me, approved
  Jenkins: Verified; No violations found; ; Verified



diff --git 
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java
 
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java
index d0dc4b3..35c93ba 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java
@@ -120,6 +120,7 @@
 // There is only a single component. There is 
nothing to merge.
 return false;
 }
+break;
 default:
 break;
 }
@@ -161,7 +162,9 @@
 }
 entranceSuccessful = numEntered == components.size();
 } catch (Throwable e) {
-e.printStackTrace();
+if (LOGGER.isLoggable(Level.SEVERE)) {
+LOGGER.log(Level.SEVERE, opType.name() + " failed to enter 
components on " + lsmIndex, e);
+}
 throw e;
 } finally {
 if (!entranceSuccessful) {
@@ -223,12 +226,8 @@
  */
 if (opType == LSMOperationType.FLUSH) {
 opTracker.notifyAll();
-while (mergePolicy.isMergeLagging(lsmIndex)) {
-try {
-opTracker.wait();
-} catch (InterruptedException e) {
-//ignore
-}
+if (!failedOperation) {
+waitForLaggingMerge();
 }
 } else if (opType == LSMOperationType.MERGE) {
 opTracker.notifyAll();
@@ -274,7 +273,7 @@
 switch (opType) {
 case FLUSH:
 // newComponent is null if the flush op. was not 
performed.
-if (newComponent != null) {
+if (!failedOperation && newComponent != null) {
 lsmIndex.addDiskComponent(newComponent);
 if (replicationEnabled) {
 componentsToBeReplicated.clear();
@@ -286,7 +285,7 @@
 break;
 case MERGE:
 // newComponent is null if the merge op. was not 
performed.
-if (newComponent != null) {
+if (!failedOperation && newComponent != null) {
 lsmIndex.subsumeMergedComponents(newComponent, 
ctx.getComponentHolder());
 if (replicationEnabled) {
 componentsToBeReplicated.clear();
@@ -300,7 +299,9 @@
 break;
 }
 } catch (Throwable e) {
-e.printStackTrace();
+if (LOGGER.isLoggable(Level.SEVERE)) {
+LOGGER.log(Level.SEVERE, e.getMessage(), e);
+}
 throw e;
 } finally {
 if (failedOperation && (opType == 
LSMOperationType.MODIFICATION
@@ -351,7 +352,9 @@
 ((AbstractLSMDiskComponent) c).destroy();
 }
 } catch (Throwable e) {
-LOGGER.log(Level.WARNING, 

Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/683/ 
(11/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1946
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2045][STO] Do Not Wait For Lagging Merge on Faile...

[abdullah alamoudi (Code Review)]

abdullah alamoudi has posted comments on this change.

Change subject: [ASTERIXDB-2045][STO] Do Not Wait For Lagging Merge on Failed 
Flush
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1947
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I915e993a76d5c692a276b1d7f3426a25f910cf46
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
..


Patch Set 5: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3764/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1946
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
..


Patch Set 5:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3764/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1946
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
..


Patch Set 5:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1946
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1363/
 (9/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1946
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/6238/ (11/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1946
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
..


Patch Set 5:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/678/ (1/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1946
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-rebalance-cancellation/499/
 (5/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1946
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/1297/ (8/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1946
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/4757/ (2/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1946
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/682/
 (3/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1946
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1019/ 
(6/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1946
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/1421/ 
(10/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1946
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/682/ 
(7/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1946
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by

[Yingyi Bu (Code Review)]

Hello Jenkins, Dmitry Lychagin,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1946

to look at the new patch set (#5).

Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
..

[ASTERIXDB-2044][COMP] Eliminate listify for complex group-by

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Fix EliminateSubplanWithInputCardinalityOneRule to handle recursive
  subplans;
- Fix various places that assumes the nested plans inside a group-by
  operator cannot be empty;
- Added regression tests.

Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21
---
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/query-ASTERIXDB-810-2.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/query-ASTERIXDB-810.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/query-ASTERIXDB-810-2.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/query-ASTERIXDB-810.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/udfs/query-ASTERIXDB-1308-1.plan
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/PreclusteredGroupByPOperator.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/typing/AbstractTypeEnvironment.java
M 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/AbstractIntroduceGroupByCombinerRule.java
M 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/PushNestedOrderByUnderPreSortedGroupByRule.java
M 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/subplan/EliminateSubplanWithInputCardinalityOneRule.java
10 files changed, 277 insertions(+), 46 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/46/1946/5
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1946
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 

Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/1599/ (4/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1946
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][HYR][*DB][HTTP][TEST] Minor refactoring / test fu...

[Anon. E. Moose (Code Review)]

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][HYR][*DB][HTTP][TEST] Minor refactoring / test 
functionality
..


Patch Set 1: Contrib-1

Analytics Compatibility Tests Failed Build 2465
: UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1948
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1f134d7874cc7de712e60911e89dac446c5c2cfd
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
..


Patch Set 4:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3763/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1946
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][HYR][*DB][HTTP][TEST] Minor refactoring / test fu...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][HYR][*DB][HTTP][TEST] Minor refactoring / test 
functionality
..


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3762/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1948
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1f134d7874cc7de712e60911e89dac446c5c2cfd
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/4756/ (2/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1946
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/1598/ (3/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1946
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-rebalance-cancellation/498/
 (6/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1946
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/1420/ 
(10/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1946
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/681/ 
(7/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1946
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/6237/ (1/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1946
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1362/
 (8/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1946
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/681/
 (4/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1946
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1018/ 
(5/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1946
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
..


Patch Set 4:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/677/ (9/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1946
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/1296/ (11/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1946
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by

[Dmitry Lychagin (Code Review)]

Dmitry Lychagin has posted comments on this change.

Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
..


Patch Set 3: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1946
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][HYR][*DB][HTTP][TEST] Minor refactoring / test fu...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][HYR][*DB][HTTP][TEST] Minor refactoring / test 
functionality
..


Patch Set 1: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1656/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1948
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1f134d7874cc7de712e60911e89dac446c5c2cfd
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][HYR][*DB][HTTP][TEST] Minor refactoring / test fu...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][HYR][*DB][HTTP][TEST] Minor refactoring / test 
functionality
..


Patch Set 1:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1656/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1948
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1f134d7874cc7de712e60911e89dac446c5c2cfd
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][HYR][*DB][HTTP][TEST] Minor refactoring / test fu...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][HYR][*DB][HTTP][TEST] Minor refactoring / test 
functionality
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3762/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1948
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1f134d7874cc7de712e60911e89dac446c5c2cfd
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][HYR][*DB][HTTP][TEST] Minor refactoring / test fu...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][HYR][*DB][HTTP][TEST] Minor refactoring / test 
functionality
..


Patch Set 1:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1948
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1f134d7874cc7de712e60911e89dac446c5c2cfd
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][HYR][*DB][HTTP][TEST] Minor refactoring / test fu...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][HYR][*DB][HTTP][TEST] Minor refactoring / test 
functionality
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/676/ 
(11/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1948
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1f134d7874cc7de712e60911e89dac446c5c2cfd
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][HYR][*DB][HTTP][TEST] Minor refactoring / test fu...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][HYR][*DB][HTTP][TEST] Minor refactoring / test 
functionality
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/1295/ (10/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1948
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1f134d7874cc7de712e60911e89dac446c5c2cfd
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][HYR][*DB][HTTP][TEST] Minor refactoring / test fu...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][HYR][*DB][HTTP][TEST] Minor refactoring / test 
functionality
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/1419/ 
(4/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1948
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1f134d7874cc7de712e60911e89dac446c5c2cfd
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][HYR][*DB][HTTP][TEST] Minor refactoring / test fu...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][HYR][*DB][HTTP][TEST] Minor refactoring / test 
functionality
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/4755/ (2/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1948
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1f134d7874cc7de712e60911e89dac446c5c2cfd
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][HYR][*DB][HTTP][TEST] Minor refactoring / test fu...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][HYR][*DB][HTTP][TEST] Minor refactoring / test 
functionality
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/680/
 (5/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1948
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1f134d7874cc7de712e60911e89dac446c5c2cfd
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][HYR][*DB][HTTP][TEST] Minor refactoring / test fu...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][HYR][*DB][HTTP][TEST] Minor refactoring / test 
functionality
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/1597/ (3/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1948
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1f134d7874cc7de712e60911e89dac446c5c2cfd
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][HYR][*DB][HTTP][TEST] Minor refactoring / test fu...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][HYR][*DB][HTTP][TEST] Minor refactoring / test 
functionality
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/6236/ (1/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1948
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1f134d7874cc7de712e60911e89dac446c5c2cfd
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][HYR][*DB][HTTP][TEST] Minor refactoring / test fu...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][HYR][*DB][HTTP][TEST] Minor refactoring / test 
functionality
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1361/
 (9/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1948
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1f134d7874cc7de712e60911e89dac446c5c2cfd
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][HYR][*DB][HTTP][TEST] Minor refactoring / test fu...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][HYR][*DB][HTTP][TEST] Minor refactoring / test 
functionality
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/680/ 
(8/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1948
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1f134d7874cc7de712e60911e89dac446c5c2cfd
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][HYR][*DB][HTTP][TEST] Minor refactoring / test fu...

[Michael Blow (Code Review)]

Michael Blow has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1948

Change subject: [NO ISSUE][HYR][*DB][HTTP][TEST] Minor refactoring / test 
functionality
..

[NO ISSUE][HYR][*DB][HTTP][TEST] Minor refactoring / test functionality

Adds ability to indicate which status code(s) to accept for an HTTP
request, instead of just 200.

Change-Id: I1f134d7874cc7de712e60911e89dac446c5c2cfd
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterApiServlet.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
M 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/utils/HttpUtil.java
3 files changed, 76 insertions(+), 49 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/48/1948/1

diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterApiServlet.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterApiServlet.java
index 82e8f7a..b24a9a1 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterApiServlet.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterApiServlet.java
@@ -26,7 +26,6 @@
 import java.util.function.Predicate;
 import java.util.logging.Level;
 import java.util.logging.Logger;
-import java.util.regex.Pattern;
 
 import org.apache.asterix.runtime.utils.CcApplicationContext;
 import org.apache.asterix.runtime.utils.ClusterStateManager;
@@ -50,7 +49,6 @@
 public class ClusterApiServlet extends AbstractServlet {
 
 private static final Logger LOGGER = 
Logger.getLogger(ClusterApiServlet.class.getName());
-private static final Pattern PARENT_DIR = 
Pattern.compile("/[^./]+/\\.\\./");
 protected static final String NODE_ID_KEY = "node_id";
 protected static final String CONFIG_URI_KEY = "configUri";
 protected static final String STATS_URI_KEY = "statsUri";
@@ -104,15 +102,8 @@
 Section.COMMON, getConfigSelector()));
 
 ArrayNode ncs = (ArrayNode) json.get("ncs");
-final StringBuilder requestURL = new StringBuilder("http://;);
-requestURL.append(request.getHeader(HttpHeaderNames.HOST));
-requestURL.append(request.getHttpRequest().uri());
-if (requestURL.charAt(requestURL.length() - 1) != '/') {
-requestURL.append('/');
-}
-requestURL.append(pathToNode);
-String clusterURL = canonicalize(requestURL);
-String adminURL = canonicalize(clusterURL + "../");
+String clusterURL = resolveClusterUrl(request, pathToNode);
+String adminURL = HttpUtil.canonicalize(clusterURL + "../");
 String nodeURL = clusterURL + "node/";
 for (int i = 0; i < ncs.size(); i++) {
 ObjectNode nc = (ObjectNode) ncs.get(i);
@@ -137,18 +128,20 @@
 return json;
 }
 
+protected String resolveClusterUrl(IServletRequest request, String 
pathToNode) {
+final StringBuilder requestURL = new StringBuilder("http://;);
+requestURL.append(request.getHeader(HttpHeaderNames.HOST));
+requestURL.append(request.getHttpRequest().uri());
+if (requestURL.charAt(requestURL.length() - 1) != '/') {
+requestURL.append('/');
+}
+requestURL.append(pathToNode);
+return HttpUtil.canonicalize(requestURL);
+}
+
 protected Predicate getConfigSelector() {
 return option -> !option.hidden() && option != 
ControllerConfig.Option.CONFIG_FILE
 && option != ControllerConfig.Option.CONFIG_FILE_URL;
 }
 
-private String canonicalize(CharSequence requestURL) {
-String clusterURL = "";
-String newClusterURL = requestURL.toString();
-while (!clusterURL.equals(newClusterURL)) {
-clusterURL = newClusterURL;
-newClusterURL = PARENT_DIR.matcher(clusterURL).replaceAll("/");
-}
-return clusterURL;
-}
 }
diff --git 
a/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
 
b/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
index a96adc0..e07ec72 100644
--- 
a/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
+++ 
b/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
@@ -103,17 +103,18 @@
 // see
 // 
https://stackoverflow.com/questions/417142/what-is-the-maximum-length-of-a-url-in-different-browsers/417184
 private static final long MAX_URL_LENGTH = 2000l;
-private static final Pattern JAVA_BLOCK_COMMENT_PATTERN =
-Pattern.compile("/\\*.*\\*/", Pattern.MULTILINE | Pattern.DOTALL);
+private static final Pattern JAVA_BLOCK_COMMENT_PATTERN = 
Pattern.compile("/\\*.*\\*/",
+Pattern.MULTILINE | 

Change in asterixdb[master]: [NO ISSUE][HYR][*DB][HTTP][TEST] Minor refactoring / test fu...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][HYR][*DB][HTTP][TEST] Minor refactoring / test 
functionality
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1017/ 
(6/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1948
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1f134d7874cc7de712e60911e89dac446c5c2cfd
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][HYR][*DB][HTTP][TEST] Minor refactoring / test fu...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][HYR][*DB][HTTP][TEST] Minor refactoring / test 
functionality
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-rebalance-cancellation/497/
 (7/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1948
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1f134d7874cc7de712e60911e89dac446c5c2cfd
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1371 - Define new datatype 'geometry'

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1371 - Define new datatype 'geometry'
..


Patch Set 21: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3761/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1838
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If32dbfcc11350a81e6a64f6abeec0595aa7872d2
Gerrit-PatchSet: 21
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Riyafa Abdul Hameed 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [TEST] Add performance test for AsterixDB

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [TEST] Add performance test for AsterixDB
..


Patch Set 56:

BAD Compatibility Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1655/ : UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1879
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9ff8efa0be71bde67190ba6f9fbd647c7799084
Gerrit-PatchSet: 56
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: [TEST] Add performance test for AsterixDB

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [TEST] Add performance test for AsterixDB
..


Patch Set 56:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1655/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1879
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9ff8efa0be71bde67190ba6f9fbd647c7799084
Gerrit-PatchSet: 56
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2045][STO] Do Not Wait For Lagging Merge on Faile...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2045][STO] Do Not Wait For Lagging Merge on Failed 
Flush
..


Patch Set 2: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3760/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1947
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I915e993a76d5c692a276b1d7f3426a25f910cf46
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1371 - Define new datatype 'geometry'

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1371 - Define new datatype 'geometry'
..


Patch Set 21:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3761/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1838
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If32dbfcc11350a81e6a64f6abeec0595aa7872d2
Gerrit-PatchSet: 21
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Riyafa Abdul Hameed 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2045][STO] Do Not Wait For Lagging Merge on Faile...

[Anon. E. Moose (Code Review)]

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2045][STO] Do Not Wait For Lagging Merge on Failed 
Flush
..


Patch Set 2: Contrib+1

Analytics Compatibility Tests Successful Build 2464
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1947
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I915e993a76d5c692a276b1d7f3426a25f910cf46
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1371 - Define new datatype 'geometry'

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1371 - Define new datatype 'geometry'
..


Patch Set 21:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/4754/ (11/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1838
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If32dbfcc11350a81e6a64f6abeec0595aa7872d2
Gerrit-PatchSet: 21
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Riyafa Abdul Hameed 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1371 - Define new datatype 'geometry'

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1371 - Define new datatype 'geometry'
..


Patch Set 21:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-rebalance-cancellation/496/
 (4/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1838
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If32dbfcc11350a81e6a64f6abeec0595aa7872d2
Gerrit-PatchSet: 21
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Riyafa Abdul Hameed 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1371 - Define new datatype 'geometry'

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1371 - Define new datatype 'geometry'
..


Patch Set 21:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/675/ (8/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1838
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If32dbfcc11350a81e6a64f6abeec0595aa7872d2
Gerrit-PatchSet: 21
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Riyafa Abdul Hameed 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1371 - Define new datatype 'geometry'

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1371 - Define new datatype 'geometry'
..


Patch Set 21:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1360/
 (5/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1838
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If32dbfcc11350a81e6a64f6abeec0595aa7872d2
Gerrit-PatchSet: 21
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Riyafa Abdul Hameed 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1371 - Define new datatype 'geometry'

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1371 - Define new datatype 'geometry'
..


Patch Set 21:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1016/ 
(7/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1838
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If32dbfcc11350a81e6a64f6abeec0595aa7872d2
Gerrit-PatchSet: 21
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Riyafa Abdul Hameed 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1371 - Define new datatype 'geometry'

[Riyafa Abdul Hameed (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1838

to look at the new patch set (#21).

Change subject: ASTERIXDB-1371 - Define new datatype 'geometry'
..

ASTERIXDB-1371 - Define new datatype 'geometry'

user model changes: Add new builtin type 'geometry'
storage format changes: Add parsing  functionality and functions for datatype 
'geometry'
interface changes: no

Change-Id: If32dbfcc11350a81e6a64f6abeec0595aa7872d2
---
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_datatype/metadata_datatype.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/GeoJSONQueries.xml
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/constructors/point.1.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/constructors/point.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/constructors/point.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/datatype_definition.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/datatype_definition.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/datatype_definition.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/datatype_definition.4.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/spatial_aggregates/union.1.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/spatial_predicates/intersects.1.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/spatial_predicates/intersects.2.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/constructors/point.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/constructors/point.2.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/constructors/point.3.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/area.4.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/datatype.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/spatial_aggregates/union.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/spatial_predicates/intersects.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/spatial_predicates/intersects.2.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M asterixdb/asterix-external-data/pom.xml
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/BuiltinTypeMap.java
M asterixdb/asterix-om/pom.xml
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AObjectPrinterFactory.java
A 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/clean/AGeometryPrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/clean/AObjectPrinterFactory.java
A 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/AGeometrySerializerDeserializer.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/AObjectSerializerDeserializer.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/formats/nontagged/SerializerDeserializerProvider.java
A asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/AGeomety.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/BuiltinFunctions.java
A 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/AGeometryTypeComputer.java
M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/ATypeTag.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/BuiltinType.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/TypeTagUtil.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/utils/NonTaggedFormatUtil.java
M asterixdb/asterix-runtime/pom.xml
A 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/scalar/ScalarSTUnionAggregateDescriptor.java
A 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/STUnionAggregateDescriptor.java
A 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/STUnionAggregateFunction.java
A 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/AbstractGetValDescriptor.java
A 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/AbstractSTDoubleGeometryDescriptor.java
A 

Change in asterixdb[master]: ASTERIXDB-1371 - Define new datatype 'geometry'

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1371 - Define new datatype 'geometry'
..


Patch Set 21:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/1418/ 
(10/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1838
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If32dbfcc11350a81e6a64f6abeec0595aa7872d2
Gerrit-PatchSet: 21
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Riyafa Abdul Hameed 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1371 - Define new datatype 'geometry'

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1371 - Define new datatype 'geometry'
..


Patch Set 21:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/679/
 (3/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1838
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If32dbfcc11350a81e6a64f6abeec0595aa7872d2
Gerrit-PatchSet: 21
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Riyafa Abdul Hameed 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1371 - Define new datatype 'geometry'

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1371 - Define new datatype 'geometry'
..


Patch Set 21:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/679/ 
(6/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1838
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If32dbfcc11350a81e6a64f6abeec0595aa7872d2
Gerrit-PatchSet: 21
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Riyafa Abdul Hameed 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1371 - Define new datatype 'geometry'

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1371 - Define new datatype 'geometry'
..


Patch Set 21:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/1294/ (1/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1838
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If32dbfcc11350a81e6a64f6abeec0595aa7872d2
Gerrit-PatchSet: 21
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Riyafa Abdul Hameed 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1371 - Define new datatype 'geometry'

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1371 - Define new datatype 'geometry'
..


Patch Set 21:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/1596/ (2/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1838
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If32dbfcc11350a81e6a64f6abeec0595aa7872d2
Gerrit-PatchSet: 21
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Riyafa Abdul Hameed 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2045][STO] Do Not Wait For Lagging Merge on Faile...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2045][STO] Do Not Wait For Lagging Merge on Failed 
Flush
..


Patch Set 2: -Integration-Tests

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3760/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1947
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I915e993a76d5c692a276b1d7f3426a25f910cf46
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2045][STO] Do Not Wait For Lagging Merge on Faile...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2045][STO] Do Not Wait For Lagging Merge on Failed 
Flush
..


Patch Set 2: Integration-Tests-1

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3759/ 
: UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1947
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I915e993a76d5c692a276b1d7f3426a25f910cf46
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2045][STO] Do Not Wait For Lagging Merge on Faile...

[Anon. E. Moose (Code Review)]

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2045][STO] Do Not Wait For Lagging Merge on Failed 
Flush
..


Patch Set 2: Contrib-1

Analytics Compatibility Tests Failed Build 2463
: UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1947
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I915e993a76d5c692a276b1d7f3426a25f910cf46
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2045][STO] Do Not Wait For Lagging Merge on Faile...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2045][STO] Do Not Wait For Lagging Merge on Failed 
Flush
..


Patch Set 2: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1654/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1947
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I915e993a76d5c692a276b1d7f3426a25f910cf46
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2045][STO] Do Not Wait For Lagging Merge on Faile...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2045][STO] Do Not Wait For Lagging Merge on Failed 
Flush
..


Patch Set 2:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1654/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1947
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I915e993a76d5c692a276b1d7f3426a25f910cf46
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2045][STO] Do Not Wait For Lagging Merge on Faile...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2045][STO] Do Not Wait For Lagging Merge on Failed 
Flush
..


Patch Set 2:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3759/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1947
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I915e993a76d5c692a276b1d7f3426a25f910cf46
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2045][STO] Do Not Wait For Lagging Merge on Faile...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2045][STO] Do Not Wait For Lagging Merge on Failed 
Flush
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1015/ 
(3/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1947
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I915e993a76d5c692a276b1d7f3426a25f910cf46
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2045][STO] Do Not Wait For Lagging Merge on Faile...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2045][STO] Do Not Wait For Lagging Merge on Failed 
Flush
..


Patch Set 2:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/674/ (8/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1947
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I915e993a76d5c692a276b1d7f3426a25f910cf46
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No