[jira] [Commented] (ASTERIXDB-2288) Problems in SQL++ compilation when types "open up"
[ https://issues.apache.org/jira/browse/ASTERIXDB-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16845609#comment-16845609 ] Ali Alsuliman commented on ASTERIXDB-2288: -- Indeed :) > Problems in SQL++ compilation when types "open up" > -- > > Key: ASTERIXDB-2288 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-2288 > Project: Apache AsterixDB > Issue Type: Bug > Components: COMP - Compiler >Affects Versions: 0.9.4 >Reporter: Michael J. Carey >Assignee: Ali Alsuliman >Priority: Major > Labels: triaged > Fix For: 0.9.4.2 > > > USE TinySocial; > -- This works based on the TinySocial tutorial schema > SELECT VALUE a FROM (SELECT VALUE c FROM ChirpUsers c UNION ALL SELECT VALUE > g FROM GleambookUsers g) AS a; > -- This doesn't work properly (field accesses broken) > SELECT name FROM (SELECT VALUE c FROM ChirpUsers c UNION ALL SELECT VALUE g > FROM GleambookUsers g) AS a; > -- This one is weird (returns some empty records) > SELECT alias FROM (SELECT VALUE c FROM ChirpUsers c UNION ALL SELECT VALUE g > FROM GleambookUsers g) AS a; -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Change in asterixdb[master]: [ASTERIXDB-2569][TEST] Refactor type computer tests
Hussain Towaileb has submitted this change and it was merged. (
https://asterix-gerrit.ics.uci.edu/3393 )
Change subject: [ASTERIXDB-2569][TEST] Refactor type computer tests
..
[ASTERIXDB-2569][TEST] Refactor type computer tests
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Converted type computer tests to be parameterized.
- Moved the tests to appropriate packages to use the
log4j logger.
- Type computer instances check is based on the field
type instead of field name.
Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90
Reviewed-on: https://asterix-gerrit.ics.uci.edu/3393
Contrib: Jenkins
Sonar-Qube: Jenkins
Tested-by: Jenkins
Integration-Tests: Jenkins
Reviewed-by: Dmitry Lychagin
---
M asterixdb/asterix-om/pom.xml
D
asterixdb/asterix-om/src/test/java/org/apache/asterix/om/typecomputer/ExceptionTest.java
D
asterixdb/asterix-om/src/test/java/org/apache/asterix/om/typecomputer/TypeComputerTest.java
A
asterixdb/asterix-om/src/test/java/org/apache/asterix/test/om/typecomputer/ExceptionTest.java
A
asterixdb/asterix-om/src/test/java/org/apache/asterix/test/om/typecomputer/TypeComputerTest.java
R
asterixdb/asterix-om/src/test/java/org/apache/asterix/test/om/util/JSONDeserializerForTypesTest.java
6 files changed, 464 insertions(+), 301 deletions(-)
Approvals:
Jenkins: Verified; No violations found; ; Verified
Anon. E. Moose (1000171):
Dmitry Lychagin: Looks good to me, approved
diff --git a/asterixdb/asterix-om/pom.xml b/asterixdb/asterix-om/pom.xml
index b2beb41..f536be1 100644
--- a/asterixdb/asterix-om/pom.xml
+++ b/asterixdb/asterix-om/pom.xml
@@ -129,5 +129,10 @@
jaxb-api
test
+
+ org.apache.logging.log4j
+ log4j-api
+ test
+
diff --git
a/asterixdb/asterix-om/src/test/java/org/apache/asterix/om/typecomputer/ExceptionTest.java
b/asterixdb/asterix-om/src/test/java/org/apache/asterix/om/typecomputer/ExceptionTest.java
deleted file mode 100644
index 29cb9a7..000
---
a/asterixdb/asterix-om/src/test/java/org/apache/asterix/om/typecomputer/ExceptionTest.java
+++ /dev/null
@@ -1,133 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- *http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied. See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-package org.apache.asterix.om.typecomputer;
-
-import static org.mockito.Mockito.mock;
-import static org.mockito.Mockito.when;
-
-import java.lang.reflect.Field;
-import java.lang.reflect.Modifier;
-import java.util.ArrayList;
-import java.util.List;
-import java.util.Set;
-
-import org.apache.asterix.om.typecomputer.base.IResultTypeComputer;
-import org.apache.asterix.om.types.ATypeTag;
-import org.apache.asterix.om.types.BuiltinType;
-import org.apache.asterix.om.types.IAType;
-import org.apache.commons.lang3.mutable.Mutable;
-import org.apache.commons.lang3.mutable.MutableObject;
-import org.apache.hyracks.algebricks.common.exceptions.AlgebricksException;
-import org.apache.hyracks.algebricks.core.algebra.base.ILogicalExpression;
-import
org.apache.hyracks.algebricks.core.algebra.expressions.AbstractFunctionCallExpression;
-import
org.apache.hyracks.algebricks.core.algebra.expressions.IVariableTypeEnvironment;
-import org.apache.hyracks.algebricks.core.algebra.functions.FunctionIdentifier;
-import org.apache.hyracks.algebricks.core.algebra.metadata.IMetadataProvider;
-import org.junit.Assert;
-import org.junit.Test;
-import org.reflections.Reflections;
-import org.reflections.scanners.SubTypesScanner;
-
-public class ExceptionTest {
-
-@Test
-public void test() throws Exception {
-// Tests all usual type computers.
-Reflections reflections = new
Reflections("org.apache.asterix.om.typecomputer", new SubTypesScanner(false));
-Set> classes =
reflections.getSubTypesOf(IResultTypeComputer.class);
-int numTypeComputers = 0;
-for (Class c : classes) {
-if (Modifier.isAbstract(c.getModifiers())) {
-continue;
-}
-testTypeComputer(c);
-++numTypeComputers;
-}
-// Currently, there are 83 type computers.
-Assert.assertTrue(numTypeComputers >= 83);
-}
-
-private void testType
[jira] [Commented] (ASTERIXDB-2569) Refactor type computer tests
[ https://issues.apache.org/jira/browse/ASTERIXDB-2569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16845613#comment-16845613 ] ASF subversion and git services commented on ASTERIXDB-2569: Commit a63c059b23d04a2de72a2b5318041fdcc2ba9bf7 in asterixdb's branch refs/heads/master from Hussain Towaileb [ https://gitbox.apache.org/repos/asf?p=asterixdb.git;h=a63c059 ] [ASTERIXDB-2569][TEST] Refactor type computer tests - user model changes: no - storage format changes: no - interface changes: no Details: - Converted type computer tests to be parameterized. - Moved the tests to appropriate packages to use the log4j logger. - Type computer instances check is based on the field type instead of field name. Change-Id: I4426efcc9e825ebb00e04e3783d18bb1cbb63a90 Reviewed-on: https://asterix-gerrit.ics.uci.edu/3393 Contrib: Jenkins Sonar-Qube: Jenkins Tested-by: Jenkins Integration-Tests: Jenkins Reviewed-by: Dmitry Lychagin > Refactor type computer tests > > > Key: ASTERIXDB-2569 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-2569 > Project: Apache AsterixDB > Issue Type: Task > Components: TEST - Test Framework >Affects Versions: 0.9.4 >Reporter: Hussain Towaileb >Assignee: Hussain Towaileb >Priority: Major > Fix For: 0.9.5 > > > Refactor the type computer tests to Parameterized tests. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (ASTERIXDB-2288) Problems in SQL++ compilation when types "open up"
[ https://issues.apache.org/jira/browse/ASTERIXDB-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ali Alsuliman resolved ASTERIXDB-2288. -- Resolution: Fixed > Problems in SQL++ compilation when types "open up" > -- > > Key: ASTERIXDB-2288 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-2288 > Project: Apache AsterixDB > Issue Type: Bug > Components: COMP - Compiler >Affects Versions: 0.9.4 >Reporter: Michael J. Carey >Assignee: Ali Alsuliman >Priority: Major > Labels: triaged > Fix For: 0.9.4.2 > > > USE TinySocial; > -- This works based on the TinySocial tutorial schema > SELECT VALUE a FROM (SELECT VALUE c FROM ChirpUsers c UNION ALL SELECT VALUE > g FROM GleambookUsers g) AS a; > -- This doesn't work properly (field accesses broken) > SELECT name FROM (SELECT VALUE c FROM ChirpUsers c UNION ALL SELECT VALUE g > FROM GleambookUsers g) AS a; > -- This one is weird (returns some empty records) > SELECT alias FROM (SELECT VALUE c FROM ChirpUsers c UNION ALL SELECT VALUE g > FROM GleambookUsers g) AS a; -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (ASTERIXDB-2569) Refactor type computer tests
[ https://issues.apache.org/jira/browse/ASTERIXDB-2569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hussain Towaileb resolved ASTERIXDB-2569. - Resolution: Fixed > Refactor type computer tests > > > Key: ASTERIXDB-2569 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-2569 > Project: Apache AsterixDB > Issue Type: Task > Components: TEST - Test Framework >Affects Versions: 0.9.4 >Reporter: Hussain Towaileb >Assignee: Hussain Towaileb >Priority: Major > Fix For: 0.9.5 > > > Refactor the type computer tests to Parameterized tests. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Change in asterixdb[master]: [ASTERIXDB-2562][FUN] Add support for bitwise functions
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3377 ) Change subject: [ASTERIXDB-2562][FUN] Add support for bitwise functions .. Patch Set 14: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5726/ (13/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3377 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70a6376d6ca12da55eeff88fa0b1c85f970ef8e6 Gerrit-Change-Number: 3377 Gerrit-PatchSet: 14 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 22 May 2019 13:59:16 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2562][FUN] Add support for bitwise functions
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3377 ) Change subject: [ASTERIXDB-2562][FUN] Add support for bitwise functions .. Patch Set 14: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/750/ (11/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3377 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70a6376d6ca12da55eeff88fa0b1c85f970ef8e6 Gerrit-Change-Number: 3377 Gerrit-PatchSet: 14 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 22 May 2019 13:59:12 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2562][FUN] Add support for bitwise functions
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3377 ) Change subject: [ASTERIXDB-2562][FUN] Add support for bitwise functions .. Patch Set 14: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/591/ (12/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3377 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70a6376d6ca12da55eeff88fa0b1c85f970ef8e6 Gerrit-Change-Number: 3377 Gerrit-PatchSet: 14 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 22 May 2019 13:59:14 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2562][FUN] Add support for bitwise functions
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3377 ) Change subject: [ASTERIXDB-2562][FUN] Add support for bitwise functions .. Patch Set 14: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/6182/ (8/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3377 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70a6376d6ca12da55eeff88fa0b1c85f970ef8e6 Gerrit-Change-Number: 3377 Gerrit-PatchSet: 14 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 22 May 2019 13:59:05 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2562][FUN] Add support for bitwise functions
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3377 ) Change subject: [ASTERIXDB-2562][FUN] Add support for bitwise functions .. Patch Set 14: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/6392/ (5/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3377 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70a6376d6ca12da55eeff88fa0b1c85f970ef8e6 Gerrit-Change-Number: 3377 Gerrit-PatchSet: 14 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 22 May 2019 13:59:00 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2562][FUN] Add support for bitwise functions
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3377 ) Change subject: [ASTERIXDB-2562][FUN] Add support for bitwise functions .. Patch Set 14: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/988/ (7/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3377 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70a6376d6ca12da55eeff88fa0b1c85f970ef8e6 Gerrit-Change-Number: 3377 Gerrit-PatchSet: 14 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 22 May 2019 13:59:04 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2562][FUN] Add support for bitwise functions
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3377 ) Change subject: [ASTERIXDB-2562][FUN] Add support for bitwise functions .. Patch Set 14: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9768/ (4/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3377 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70a6376d6ca12da55eeff88fa0b1c85f970ef8e6 Gerrit-Change-Number: 3377 Gerrit-PatchSet: 14 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 22 May 2019 13:58:59 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2562][FUN] Add support for bitwise functions
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3377 ) Change subject: [ASTERIXDB-2562][FUN] Add support for bitwise functions .. Patch Set 14: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5809/ (10/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3377 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70a6376d6ca12da55eeff88fa0b1c85f970ef8e6 Gerrit-Change-Number: 3377 Gerrit-PatchSet: 14 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 22 May 2019 13:59:09 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2562][FUN] Add support for bitwise functions
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3377 ) Change subject: [ASTERIXDB-2562][FUN] Add support for bitwise functions .. Patch Set 14: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/1086/ (6/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3377 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70a6376d6ca12da55eeff88fa0b1c85f970ef8e6 Gerrit-Change-Number: 3377 Gerrit-PatchSet: 14 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 22 May 2019 13:59:02 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2562][FUN] Add support for bitwise functions
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3377 ) Change subject: [ASTERIXDB-2562][FUN] Add support for bitwise functions .. Patch Set 14: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5977/ (9/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3377 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70a6376d6ca12da55eeff88fa0b1c85f970ef8e6 Gerrit-Change-Number: 3377 Gerrit-PatchSet: 14 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 22 May 2019 13:59:07 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2562][FUN] Add support for bitwise functions
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3377 ) Change subject: [ASTERIXDB-2562][FUN] Add support for bitwise functions .. Patch Set 14: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/6032/ (3/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3377 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70a6376d6ca12da55eeff88fa0b1c85f970ef8e6 Gerrit-Change-Number: 3377 Gerrit-PatchSet: 14 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 22 May 2019 13:58:58 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2562][FUN] Add support for bitwise functions
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3377 ) Change subject: [ASTERIXDB-2562][FUN] Add support for bitwise functions .. Patch Set 14: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/11301/ (1/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3377 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70a6376d6ca12da55eeff88fa0b1c85f970ef8e6 Gerrit-Change-Number: 3377 Gerrit-PatchSet: 14 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 22 May 2019 13:58:57 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2562][FUN] Add support for bitwise functions
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3377 ) Change subject: [ASTERIXDB-2562][FUN] Add support for bitwise functions .. Patch Set 14: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8588/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3377 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70a6376d6ca12da55eeff88fa0b1c85f970ef8e6 Gerrit-Change-Number: 3377 Gerrit-PatchSet: 14 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 22 May 2019 14:00:41 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2562][FUN] Add support for bitwise functions
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3377 ) Change subject: [ASTERIXDB-2562][FUN] Add support for bitwise functions .. Patch Set 14: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5790/ (15/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3377 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70a6376d6ca12da55eeff88fa0b1c85f970ef8e6 Gerrit-Change-Number: 3377 Gerrit-PatchSet: 14 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 22 May 2019 13:59:19 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2562][FUN] Add support for bitwise functions
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3377 ) Change subject: [ASTERIXDB-2562][FUN] Add support for bitwise functions .. Patch Set 14: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5827/ (14/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3377 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70a6376d6ca12da55eeff88fa0b1c85f970ef8e6 Gerrit-Change-Number: 3377 Gerrit-PatchSet: 14 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 22 May 2019 13:59:17 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2562][FUN] Add support for bitwise functions
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3377 ) Change subject: [ASTERIXDB-2562][FUN] Add support for bitwise functions .. Patch Set 14: Analytics Compatibility Compilation Successful https://cbjenkins.page.link/XmLCo66vERvcBtTL9 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3377 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70a6376d6ca12da55eeff88fa0b1c85f970ef8e6 Gerrit-Change-Number: 3377 Gerrit-PatchSet: 14 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 22 May 2019 14:02:56 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2562][FUN] Add support for bitwise functions
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3377 ) Change subject: [ASTERIXDB-2562][FUN] Add support for bitwise functions .. Patch Set 14: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3821/ (2/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3377 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70a6376d6ca12da55eeff88fa0b1c85f970ef8e6 Gerrit-Change-Number: 3377 Gerrit-PatchSet: 14 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 22 May 2019 13:58:58 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2562][FUN] Add support for bitwise functions
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3377 ) Change subject: [ASTERIXDB-2562][FUN] Add support for bitwise functions .. Patch Set 14: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4438/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3377 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70a6376d6ca12da55eeff88fa0b1c85f970ef8e6 Gerrit-Change-Number: 3377 Gerrit-PatchSet: 14 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 22 May 2019 14:02:03 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2562][FUN] Add support for bitwise functions
Hello Anon. E. Moose (1000171), Till Westmann, Ali Alsuliman, Jenkins, Hussain Towaileb, Dmitry Lychagin, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/3377 to look at the new patch set (#14). Change subject: [ASTERIXDB-2562][FUN] Add support for bitwise functions .. [ASTERIXDB-2562][FUN] Add support for bitwise functions - user model changes: yes Added AND, OR, XOR, NOT, SET, CLEAR, SHIFT, TEST, ISSET and COUNT bitwise functions. - storage format changes: no - interface changes: no Details: - Introduced the AND, OR, XOR, NOT, SET, CLEAR, SHIFT, TEST, ISSET and COUNT bitwise functions. - Added test cases. Change-Id: I70a6376d6ca12da55eeff88fa0b1c85f970ef8e6 --- A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/bitwise/bit_and_01/bit_and_01.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/bitwise/bit_and_02/bit_and_02.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/bitwise/bit_and_03/bit_and_03.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/bitwise/bit_clear_01/bit_clear_01.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/bitwise/bit_clear_02/bit_clear_02.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/bitwise/bit_count_01/bit_count_01.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/bitwise/bit_count_02/bit_count_02.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/bitwise/bit_not_01/bit_not_01.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/bitwise/bit_not_02/bit_not_02.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/bitwise/bit_or_01/bit_or_01.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/bitwise/bit_or_02/bit_or_02.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/bitwise/bit_or_03/bit_or_03.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/bitwise/bit_set_01/bit_set_01.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/bitwise/bit_set_02/bit_set_02.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/bitwise/bit_shift_01/bit_shift_01.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/bitwise/bit_shift_02/bit_shift_02.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/bitwise/bit_test_01/bit_test_01.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/bitwise/bit_test_02/bit_test_02.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/bitwise/bit_xor_01/bit_xor_01.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/bitwise/bit_xor_02/bit_xor_02.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/bitwise/bit_xor_03/bit_xor_03.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/bitwise/is_bit_set_01/is_bit_set_01.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/bitwise/is_bit_set_02/is_bit_set_02.1.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/results/bitwise/bit_and_01/bit_and_01.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/bitwise/bit_and_02/bit_and_02.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/bitwise/bit_clear_01/bit_clear_01.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/bitwise/bit_clear_02/bit_clear_02.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/bitwise/bit_count_01/bit_count_01.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/bitwise/bit_count_02/bit_count_02.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/bitwise/bit_not_01/bit_not_01.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/bitwise/bit_not_02/bit_not_02.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/bitwise/bit_or_01/bit_or_01.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/bitwise/bit_or_02/bit_or_02.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/bitwise/bit_set_01/bit_set_01.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/bitwise/bit_set_02/bit_set_02.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/bitwise/bit_shift_01/bit_shift_01.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/bitwise/bit_shift_02/bit_shift_02.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/bitwise/bit_test_01/bit_test_01.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/bitwise/bit_test_02/bit_test_02.1.adm A aste
Change in asterixdb[master]: [ASTERIXDB-2562][FUN] Add support for bitwise functions
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3377 ) Change subject: [ASTERIXDB-2562][FUN] Add support for bitwise functions .. Patch Set 14: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1177/ (16/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3377 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70a6376d6ca12da55eeff88fa0b1c85f970ef8e6 Gerrit-Change-Number: 3377 Gerrit-PatchSet: 14 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 22 May 2019 14:08:57 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2562][FUN] Add support for bitwise functions
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3377 ) Change subject: [ASTERIXDB-2562][FUN] Add support for bitwise functions .. Patch Set 14: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4438/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3377 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70a6376d6ca12da55eeff88fa0b1c85f970ef8e6 Gerrit-Change-Number: 3377 Gerrit-PatchSet: 14 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 22 May 2019 14:18:49 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2562][FUN] Add support for bitwise functions
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3377 ) Change subject: [ASTERIXDB-2562][FUN] Add support for bitwise functions .. Patch Set 14: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8588/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3377 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70a6376d6ca12da55eeff88fa0b1c85f970ef8e6 Gerrit-Change-Number: 3377 Gerrit-PatchSet: 14 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 22 May 2019 15:16:03 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2562][FUN] Add support for bitwise functions
Hussain Towaileb has posted comments on this change. (
https://asterix-gerrit.ics.uci.edu/3377 )
Change subject: [ASTERIXDB-2562][FUN] Add support for bitwise functions
..
Patch Set 14:
(14 comments)
https://asterix-gerrit.ics.uci.edu/#/c/3377/13/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/PointableHelper.java
File
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/PointableHelper.java:
https://asterix-gerrit.ics.uci.edu/#/c/3377/13/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/PointableHelper.java@317
PS13, Line 317:
> Do we need to handle NaN here?
Done.
https://asterix-gerrit.ics.uci.edu/#/c/3377/13/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/PointableHelper.java@327
PS13, Line 327:
> Do we need to handle NaN here?
Done.
https://asterix-gerrit.ics.uci.edu/#/c/3377/13/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/PointableHelper.java@351
PS13, Line 351:
> We already have ATypeHierarchy.getLongValue(). Can we use that instead of c
Done.
I was not aware of such a method, I removed the new method and switched all to
use ATypeHierarchy.getLongValue().
https://asterix-gerrit.ics.uci.edu/#/c/3377/13/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/AbstractBitMultipleValuesEvaluator.java
File
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/AbstractBitMultipleValuesEvaluator.java:
https://asterix-gerrit.ics.uci.edu/#/c/3377/13/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/AbstractBitMultipleValuesEvaluator.java@150
PS13, Line 150:
> there's no need to use resultMutableInt64 at all in this loop.
Done
https://asterix-gerrit.ics.uci.edu/#/c/3377/13/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/AbstractBitSingleValueEvaluator.java
File
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/AbstractBitSingleValueEvaluator.java:
https://asterix-gerrit.ics.uci.edu/#/c/3377/13/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/AbstractBitSingleValueEvaluator.java@58
PS13, Line 58: FunctionIdentifier functionIdentifier,
SourceLocation sourceLocation) throws HyracksDataException {
> bitnot() only uses int64 mutable/serde, but bitcount() only uses int32 muta
Done
https://asterix-gerrit.ics.uci.edu/#/c/3377/13/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/AbstractBitSingleValueEvaluator.java@103
PS13, Line 103:
> why do we need to write the value to resultMutableInt64 and then immediatel
Done
https://asterix-gerrit.ics.uci.edu/#/c/3377/13/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/AbstractBitValuePositionFlagEvaluator.java
File
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/AbstractBitValuePositionFlagEvaluator.java:
https://asterix-gerrit.ics.uci.edu/#/c/3377/13/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/AbstractBitValuePositionFlagEvaluator.java@85
PS13, Line 85:
> We don't need to create this object if there's no flagEvaluator available.
Done
https://asterix-gerrit.ics.uci.edu/#/c/3377/13/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/AbstractBitValuePositionFlagEvaluator.java@104
PS13, Line 104:
> do you need hasFlagArgument at all? Check the length of argEvaluatorFactori
Done
https://asterix-gerrit.ics.uci.edu/#/c/3377/13/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/AbstractBitValuePositionFlagEvaluator.java@123
PS13, Line 123:
> if 'flagEvaluator' is null then flagPointable is not properly initialized.
checkAndSetMissingOrNull() only assumes the first 2 arguments are not null,
first argument is the result Pointable to write to, second argument is the
first pointable to be checked. So passing null for the other pointables will
have no impact and cause no issues.
Although I'm wondering if I should check if the result pointable and first
pointable are null before using them, however, ideally, I thought it might be
safe to assume that when this method is called, at least the result to write to
and the first pointable should be not null, because if those 2 are null, then
something is off and an exception needs to be thrown.
What do you think?
https://asterix-gerrit.ics.uci.edu/#/c/3377/13/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/AbstractBitValuePositionFlagEvaluator.
Change in asterixdb[master]: [ASTERIXDB-2562][FUN] Add support for bitwise functions
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3377 ) Change subject: [ASTERIXDB-2562][FUN] Add support for bitwise functions .. Patch Set 14: Contrib-2 Analytics Compatibility Tests Failed https://cbjenkins.page.link/aCs1GDLtrvbXXcgy9 : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/3377 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70a6376d6ca12da55eeff88fa0b1c85f970ef8e6 Gerrit-Change-Number: 3377 Gerrit-PatchSet: 14 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 22 May 2019 17:01:20 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2562][FUN] Add support for bitwise functions
Dmitry Lychagin has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3377 ) Change subject: [ASTERIXDB-2562][FUN] Add support for bitwise functions .. Patch Set 14: Code-Review+2 (2 comments) I think we can merge it, but there's one thing we should improve. 1. We need to add tests where each function is called multiple times. something like. FROM range(0, 10) i SELECT VALUE bitset(i , ..) . The purpose is to test how each function runtime performs on subsequent invocations. (we can do this in a separate change) 2. (minor) You're using the following pattern in test queries. "t1" : (SELECT VALUE f(...))[0] It works but is equivalent to just "t1": f(...) We can keep existing tests as is because they work fine. This is just for future reference. https://asterix-gerrit.ics.uci.edu/#/c/3377/13/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/AbstractBitValuePositionFlagEvaluator.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/AbstractBitValuePositionFlagEvaluator.java: https://asterix-gerrit.ics.uci.edu/#/c/3377/13/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/AbstractBitValuePositionFlagEvaluator.java@123 PS13, Line 123: > checkAndSetMissingOrNull() only assumes the first 2 arguments are not null, I think it's fine. flagPointable was never null in your previous code, that's why I made this comment. but if it's always null if there's no flag, then passing it to checkAndSetMissingOrNull is ok. Regarding assuming that first 2 arguments are not null. I think it's ok to do. Those two should alway be present, otherwise there's no point in calling checkAndSetMissingOrNull method. https://asterix-gerrit.ics.uci.edu/#/c/3377/13/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/BitClearDescriptor.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/BitClearDescriptor.java: https://asterix-gerrit.ics.uci.edu/#/c/3377/13/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/bitwise/BitClearDescriptor.java@130 PS13, Line 130: > It seems in both cases, the item gets written eventually to the provided po Yes, you're right. So we don't need to look at the result value -- To view, visit https://asterix-gerrit.ics.uci.edu/3377 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70a6376d6ca12da55eeff88fa0b1c85f970ef8e6 Gerrit-Change-Number: 3377 Gerrit-PatchSet: 14 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 22 May 2019 19:10:15 + Gerrit-HasComments: Yes
Change in asterixdb[master]: [ASTERIXDB-2562][FUN] Add support for bitwise functions
Hussain Towaileb has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3377 ) Change subject: [ASTERIXDB-2562][FUN] Add support for bitwise functions .. Patch Set 14: Noted, I'll make sure to address your comments in future changes, I'll merge this one for now. -- To view, visit https://asterix-gerrit.ics.uci.edu/3377 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70a6376d6ca12da55eeff88fa0b1c85f970ef8e6 Gerrit-Change-Number: 3377 Gerrit-PatchSet: 14 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Comment-Date: Wed, 22 May 2019 19:28:52 + Gerrit-HasComments: No
[jira] [Commented] (ASTERIXDB-2562) Add support for bitwise functions.
[ https://issues.apache.org/jira/browse/ASTERIXDB-2562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16846179#comment-16846179 ] ASF subversion and git services commented on ASTERIXDB-2562: Commit c420e45165187c14fdc61d0c631c4c1bc5df76e5 in asterixdb's branch refs/heads/master from Hussain Towaileb [ https://gitbox.apache.org/repos/asf?p=asterixdb.git;h=c420e45 ] [ASTERIXDB-2562][FUN] Add support for bitwise functions - user model changes: yes Added AND, OR, XOR, NOT, SET, CLEAR, SHIFT, TEST, ISSET and COUNT bitwise functions. - storage format changes: no - interface changes: no Details: - Introduced the AND, OR, XOR, NOT, SET, CLEAR, SHIFT, TEST, ISSET and COUNT bitwise functions. - Added test cases. Change-Id: I70a6376d6ca12da55eeff88fa0b1c85f970ef8e6 Reviewed-on: https://asterix-gerrit.ics.uci.edu/3377 Contrib: Jenkins Tested-by: Jenkins Integration-Tests: Jenkins Reviewed-by: Dmitry Lychagin > Add support for bitwise functions. > -- > > Key: ASTERIXDB-2562 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-2562 > Project: Apache AsterixDB > Issue Type: Improvement > Components: FUN - Functions >Affects Versions: 0.9.4 >Reporter: Hussain Towaileb >Assignee: Hussain Towaileb >Priority: Major > Fix For: 0.9.5 > > > Add support for bitwise functions. The bitwise functions operate on int64 > signed integers. > BITAND > BITCLEAR > BITNOT > BITOR > BITSET > BITSHIFT > BITTEST > BITXOR > BITCOUNT > ISBITSET (is a synonym for BITTEST) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (ASTERIXDB-2562) Add support for bitwise functions.
[ https://issues.apache.org/jira/browse/ASTERIXDB-2562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hussain Towaileb resolved ASTERIXDB-2562. - Resolution: Fixed > Add support for bitwise functions. > -- > > Key: ASTERIXDB-2562 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-2562 > Project: Apache AsterixDB > Issue Type: Improvement > Components: FUN - Functions >Affects Versions: 0.9.4 >Reporter: Hussain Towaileb >Assignee: Hussain Towaileb >Priority: Major > Fix For: 0.9.5 > > > Add support for bitwise functions. The bitwise functions operate on int64 > signed integers. > BITAND > BITCLEAR > BITNOT > BITOR > BITSET > BITSHIFT > BITTEST > BITXOR > BITCOUNT > ISBITSET (is a synonym for BITTEST) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (ASTERIXDB-2570) Add documentation for bitwise functions
Hussain Towaileb created ASTERIXDB-2570: --- Summary: Add documentation for bitwise functions Key: ASTERIXDB-2570 URL: https://issues.apache.org/jira/browse/ASTERIXDB-2570 Project: Apache AsterixDB Issue Type: Improvement Components: DOC - Documentation Affects Versions: 0.9.4 Reporter: Hussain Towaileb Assignee: Hussain Towaileb Fix For: 0.9.5 Need to add documentation for the bitwise functions -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5828/ (2/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:21:29 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/592/ (3/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:21:29 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Dmitry Lychagin has uploaded this change for review. ( https://asterix-gerrit.ics.uci.edu/3402 Change subject: [WIP] Convert docs from markdown to asciidoc .. [WIP] Convert docs from markdown to asciidoc Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 --- M asterixdb/asterix-doc/pom.xml A asterixdb/asterix-doc/src/main/asciidoc/builtins/0_toc.adoc A asterixdb/asterix-doc/src/main/asciidoc/builtins/10_comparison.adoc A asterixdb/asterix-doc/src/main/asciidoc/builtins/11_type.adoc A asterixdb/asterix-doc/src/main/asciidoc/builtins/12_misc.adoc A asterixdb/asterix-doc/src/main/asciidoc/builtins/13_conditional.adoc A asterixdb/asterix-doc/src/main/asciidoc/builtins/1_numeric_common.adoc A asterixdb/asterix-doc/src/main/asciidoc/builtins/1_numeric_delta.adoc A asterixdb/asterix-doc/src/main/asciidoc/builtins/2_string_common.adoc A asterixdb/asterix-doc/src/main/asciidoc/builtins/2_string_delta.adoc A asterixdb/asterix-doc/src/main/asciidoc/builtins/3_binary.adoc A asterixdb/asterix-doc/src/main/asciidoc/builtins/4_spatial.adoc A asterixdb/asterix-doc/src/main/asciidoc/builtins/5_similarity.adoc A asterixdb/asterix-doc/src/main/asciidoc/builtins/6_tokenizing.adoc A asterixdb/asterix-doc/src/main/asciidoc/builtins/7_allens.adoc A asterixdb/asterix-doc/src/main/asciidoc/builtins/7_temporal.adoc A asterixdb/asterix-doc/src/main/asciidoc/builtins/8_record.adoc A asterixdb/asterix-doc/src/main/asciidoc/builtins/9_aggregate_aql.adoc A asterixdb/asterix-doc/src/main/asciidoc/builtins/9_aggregate_sql.adoc A asterixdb/asterix-doc/src/main/asciidoc/datamodel/datamodel_composite.adoc A asterixdb/asterix-doc/src/main/asciidoc/datamodel/datamodel_header.adoc A asterixdb/asterix-doc/src/main/asciidoc/datamodel/datamodel_incomplete.adoc A asterixdb/asterix-doc/src/main/asciidoc/datamodel/datamodel_primitive_common.adoc A asterixdb/asterix-doc/src/main/asciidoc/datamodel/datamodel_primitive_delta.adoc A asterixdb/asterix-doc/src/main/asciidoc/sqlpp/0_toc.adoc A asterixdb/asterix-doc/src/main/asciidoc/sqlpp/1_intro.adoc A asterixdb/asterix-doc/src/main/asciidoc/sqlpp/2_expr.adoc A asterixdb/asterix-doc/src/main/asciidoc/sqlpp/2_expr_title.adoc A asterixdb/asterix-doc/src/main/asciidoc/sqlpp/3_declare_dataverse.adoc A asterixdb/asterix-doc/src/main/asciidoc/sqlpp/3_declare_function.adoc A asterixdb/asterix-doc/src/main/asciidoc/sqlpp/3_query.adoc A asterixdb/asterix-doc/src/main/asciidoc/sqlpp/3_query_title.adoc A asterixdb/asterix-doc/src/main/asciidoc/sqlpp/4_error.adoc A asterixdb/asterix-doc/src/main/asciidoc/sqlpp/4_error_title.adoc A asterixdb/asterix-doc/src/main/asciidoc/sqlpp/5_ddl_dataset_index.adoc A asterixdb/asterix-doc/src/main/asciidoc/sqlpp/5_ddl_dml.adoc A asterixdb/asterix-doc/src/main/asciidoc/sqlpp/5_ddl_function_removal.adoc A asterixdb/asterix-doc/src/main/asciidoc/sqlpp/5_ddl_head.adoc A asterixdb/asterix-doc/src/main/asciidoc/sqlpp/appendix_1_keywords.adoc A asterixdb/asterix-doc/src/main/asciidoc/sqlpp/appendix_1_title.adoc A asterixdb/asterix-doc/src/main/asciidoc/sqlpp/appendix_2_index_only.adoc A asterixdb/asterix-doc/src/main/asciidoc/sqlpp/appendix_2_parameters.adoc A asterixdb/asterix-doc/src/main/asciidoc/sqlpp/appendix_2_title.adoc A asterixdb/asterix-doc/src/main/asciidoc/sqlpp/appendix_3_resolution.adoc A asterixdb/asterix-doc/src/main/asciidoc/sqlpp/appendix_3_title.adoc A asterixdb/asterix-doc/src/main/data_ingestion/feeds.adoc D asterixdb/asterix-doc/src/main/data_ingestion/feeds.md A asterixdb/asterix-doc/src/main/data_ingestion/feeds_title.adoc D asterixdb/asterix-doc/src/main/data_ingestion/feeds_title.md A asterixdb/asterix-doc/src/main/installation/ansible.adoc D asterixdb/asterix-doc/src/main/installation/ansible.md A asterixdb/asterix-doc/src/main/installation/ansible_title.adoc D asterixdb/asterix-doc/src/main/installation/ansible_title.md A asterixdb/asterix-doc/src/main/installation/aws.adoc D asterixdb/asterix-doc/src/main/installation/aws.md A asterixdb/asterix-doc/src/main/installation/aws_title.adoc D asterixdb/asterix-doc/src/main/installation/aws_title.md D asterixdb/asterix-doc/src/main/markdown/builtins/0_toc.md D asterixdb/asterix-doc/src/main/markdown/builtins/10_comparison.md D asterixdb/asterix-doc/src/main/markdown/builtins/11_type.md D asterixdb/asterix-doc/src/main/markdown/builtins/12_misc.md D asterixdb/asterix-doc/src/main/markdown/builtins/13_conditional.md D asterixdb/asterix-doc/src/main/markdown/builtins/1_numeric_common.md D asterixdb/asterix-doc/src/main/markdown/builtins/1_numeric_delta.md D asterixdb/asterix-doc/src/main/markdown/builtins/2_string_common.md D asterixdb/asterix-doc/src/main/markdown/builtins/2_string_delta.md D asterixdb/asterix-doc/src/main/markdown/builtins/3_binary.md D asterixdb/asterix-doc/src/main/markdown/builtins/4_spatial.md D asterixdb/asterix-doc/src/main/markdown/builtins/5_similarity.md D asterixdb/asterix-doc/src/main/markdown/builtins/6_tokenizing.
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5727/ (1/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:21:29 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1178/ (8/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:21:32 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/6183/ (12/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:21:40 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/6033/ (6/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:21:31 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/6393/ (10/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:21:36 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5810/ (16/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:21:47 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9769/ (7/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:21:31 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5978/ (15/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:21:46 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/1087/ (9/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:21:34 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/989/ (11/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:21:38 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/751/ (13/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:21:43 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 1: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4439/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:24:36 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8589/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:25:24 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 1: Contrib-2 Analytics Compatibility Compilation Failed https://cbjenkins.page.link/66TM6a5zxKhCA8wbA : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:25:39 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/11302/ (4/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:21:30 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5791/ (5/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:21:30 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3822/ (14/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:21:44 + Gerrit-HasComments: No
[jira] [Created] (ASTERIXDB-2571) Memory assigned out of the budget in hash join for large objects
Shiva Jahangiri created ASTERIXDB-2571: -- Summary: Memory assigned out of the budget in hash join for large objects Key: ASTERIXDB-2571 URL: https://issues.apache.org/jira/browse/ASTERIXDB-2571 Project: Apache AsterixDB Issue Type: Bug Components: *DB - AsterixDB Affects Versions: 0.9.4.1 Reporter: Shiva Jahangiri Currently in optimized hybrid hash join in case of lack of memory asterix flushes the big prob object to the disk. For flushing a big object, a variable sized frame will be created from hyracks context not join memory budget. This means we may use more than the given budget. Possible solutions: 1) Have a way to flush the incoming frame/buffer directly to the disk. 2) Spill enough data to be able to fit the large object(less preferred as it hurts the performance). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 1: Contrib-2 BAD Compatibility Tests Failed https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4439/ : FAILURE -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:34:43 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 1: Integration-Tests-1 Integration Tests Failed https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8589/ : FAILURE -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:30:54 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/6034/ (3/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:34:51 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9770/ (5/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:34:52 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/6394/ (7/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:34:54 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/1088/ (6/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:34:53 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1179/ (4/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:34:51 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/752/ (10/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:34:59 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/990/ (8/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:34:56 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/593/ (12/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:35:03 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5792/ (1/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:34:50 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8590/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:35:54 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5829/ (14/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:35:07 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5728/ (16/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:35:11 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5811/ (13/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:35:05 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 2: Analytics Compatibility Compilation Successful https://cbjenkins.page.link/rMxYuDsEhxMnq7Mk8 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:39:05 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/6184/ (9/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:34:57 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3823/ (2/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:34:50 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 2: Integration-Tests-1 Integration Tests Failed https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8590/ : FAILURE -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:41:36 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/11303/ (15/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:35:09 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5979/ (11/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 22:35:01 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Remove unnecessary inner classes
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3403 ) Change subject: [NO ISSUE][FUN] Remove unnecessary inner classes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3824/ (5/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3403 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cc8c57888e62b26684082dd07a4314b45f9fa7f Gerrit-Change-Number: 3403 Gerrit-PatchSet: 1 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 23:30:25 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Remove unnecessary inner classes
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3403 ) Change subject: [NO ISSUE][FUN] Remove unnecessary inner classes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/6185/ (3/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3403 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cc8c57888e62b26684082dd07a4314b45f9fa7f Gerrit-Change-Number: 3403 Gerrit-PatchSet: 1 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 23:30:24 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Remove unnecessary inner classes
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3403 ) Change subject: [NO ISSUE][FUN] Remove unnecessary inner classes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5830/ (2/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3403 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cc8c57888e62b26684082dd07a4314b45f9fa7f Gerrit-Change-Number: 3403 Gerrit-PatchSet: 1 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 23:30:24 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Remove unnecessary inner classes
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3403 ) Change subject: [NO ISSUE][FUN] Remove unnecessary inner classes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5729/ (1/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3403 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cc8c57888e62b26684082dd07a4314b45f9fa7f Gerrit-Change-Number: 3403 Gerrit-PatchSet: 1 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 23:30:24 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Remove unnecessary inner classes
Hussain Towaileb has uploaded this change for review. (
https://asterix-gerrit.ics.uci.edu/3403
Change subject: [NO ISSUE][FUN] Remove unnecessary inner classes
..
[NO ISSUE][FUN] Remove unnecessary inner classes
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Remove unnecessary inner classes. Use the evaluator
factories length to check if the end position argument
is passed.
Change-Id: I5cc8c57888e62b26684082dd07a4314b45f9fa7f
---
R
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArraySliceEvaluator.java
M
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArraySliceWithEndPositionDescriptor.java
M
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArraySliceWithoutEndPositionDescriptor.java
3 files changed, 23 insertions(+), 59 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/03/3403/1
diff --git
a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/AbstractArraySliceEval.java
b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArraySliceEvaluator.java
similarity index 90%
rename from
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/AbstractArraySliceEval.java
rename to
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArraySliceEvaluator.java
index 036447a..c907720 100644
---
a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/AbstractArraySliceEval.java
+++
b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArraySliceEvaluator.java
@@ -75,32 +75,31 @@
*
*/
-public abstract class AbstractArraySliceEval extends AbstractScalarEval {
+class ArraySliceEvaluator extends AbstractScalarEval {
+
// List type
private final IAType inputListType;
// Storage
-private final ArrayBackedValueStorage storage = new
ArrayBackedValueStorage();
+private final ArrayBackedValueStorage resultStorage = new
ArrayBackedValueStorage();
-// Evaluators
+// Evaluators and pointables
private final IScalarEvaluator listEval;
private final IScalarEvaluator startPositionEval;
-private final IScalarEvaluator endPositionEval;
-
-// Pointables
+private IScalarEvaluator endPositionEval;
private final IPointable listPointable = new VoidPointable();
private final IPointable startPositionPointable = new VoidPointable();
-private final IPointable endPositionPointable = new VoidPointable();
+private IPointable endPositionPointable;
// Accessors
private final ListAccessor listAccessor = new ListAccessor();
// List Builders
-private IAsterixListBuilder orderedListBuilder = new OrderedListBuilder();
-private IAsterixListBuilder unorderedListBuilder = new
UnorderedListBuilder();
+private final IAsterixListBuilder orderedListBuilder = new
OrderedListBuilder();
+private final IAsterixListBuilder unorderedListBuilder = new
UnorderedListBuilder();
// Constructor
-public AbstractArraySliceEval(IScalarEvaluatorFactory[] args,
IHyracksTaskContext ctx, SourceLocation sourceLoc,
+ArraySliceEvaluator(IScalarEvaluatorFactory[] argEvalFactories,
IHyracksTaskContext ctx, SourceLocation sourceLoc,
FunctionIdentifier functionIdentifier, IAType inputListType)
throws HyracksDataException {
// Source location
super(sourceLoc, functionIdentifier);
@@ -109,20 +108,18 @@
this.inputListType = inputListType;
// Evaluators
-listEval = args[0].createScalarEvaluator(ctx);
-startPositionEval = args[1].createScalarEvaluator(ctx);
+listEval = argEvalFactories[0].createScalarEvaluator(ctx);
+startPositionEval = argEvalFactories[1].createScalarEvaluator(ctx);
// Check for optional parameter
-endPositionEval = getEndPositionEval(args, ctx);
+if (argEvalFactories.length > 2) {
+endPositionEval = argEvalFactories[2].createScalarEvaluator(ctx);
+endPositionPointable = new VoidPointable();
+}
}
-
-protected abstract IScalarEvaluator
getEndPositionEval(IScalarEvaluatorFactory[] args, IHyracksTaskContext ctx)
-throws HyracksDataException;
@Override
public void evaluate(IFrameTupleReference tuple, IPointable result) throws
HyracksDataException {
-// Reset storage
-storage.reset();
// Evaluate
listEval.evaluate(tuple, listPointable);
@@ -231,18 +228,18 @@
try {
// Create the subset list based on the positions
for (int i = startPositionValue; i < endPositionValue; i++) {
-storage.reset();
-
Change in asterixdb[master]: [NO ISSUE][FUN] Remove unnecessary inner classes
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3403 ) Change subject: [NO ISSUE][FUN] Remove unnecessary inner classes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/753/ (4/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3403 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cc8c57888e62b26684082dd07a4314b45f9fa7f Gerrit-Change-Number: 3403 Gerrit-PatchSet: 1 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 23:30:25 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Remove unnecessary inner classes
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3403 ) Change subject: [NO ISSUE][FUN] Remove unnecessary inner classes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/6035/ (12/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3403 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cc8c57888e62b26684082dd07a4314b45f9fa7f Gerrit-Change-Number: 3403 Gerrit-PatchSet: 1 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 23:30:35 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Remove unnecessary inner classes
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3403 ) Change subject: [NO ISSUE][FUN] Remove unnecessary inner classes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9771/ (13/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3403 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cc8c57888e62b26684082dd07a4314b45f9fa7f Gerrit-Change-Number: 3403 Gerrit-PatchSet: 1 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 23:30:38 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Remove unnecessary inner classes
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3403 ) Change subject: [NO ISSUE][FUN] Remove unnecessary inner classes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/991/ (16/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3403 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cc8c57888e62b26684082dd07a4314b45f9fa7f Gerrit-Change-Number: 3403 Gerrit-PatchSet: 1 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 23:30:44 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Remove unnecessary inner classes
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3403 ) Change subject: [NO ISSUE][FUN] Remove unnecessary inner classes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5980/ (7/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3403 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cc8c57888e62b26684082dd07a4314b45f9fa7f Gerrit-Change-Number: 3403 Gerrit-PatchSet: 1 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 23:30:27 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Remove unnecessary inner classes
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3403 ) Change subject: [NO ISSUE][FUN] Remove unnecessary inner classes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/6395/ (14/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3403 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cc8c57888e62b26684082dd07a4314b45f9fa7f Gerrit-Change-Number: 3403 Gerrit-PatchSet: 1 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 23:30:40 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Remove unnecessary inner classes
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3403 ) Change subject: [NO ISSUE][FUN] Remove unnecessary inner classes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5812/ (6/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3403 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cc8c57888e62b26684082dd07a4314b45f9fa7f Gerrit-Change-Number: 3403 Gerrit-PatchSet: 1 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 23:30:26 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Remove unnecessary inner classes
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3403 ) Change subject: [NO ISSUE][FUN] Remove unnecessary inner classes .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8591/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3403 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cc8c57888e62b26684082dd07a4314b45f9fa7f Gerrit-Change-Number: 3403 Gerrit-PatchSet: 1 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 23:31:35 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Remove unnecessary inner classes
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3403 ) Change subject: [NO ISSUE][FUN] Remove unnecessary inner classes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/594/ (8/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3403 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cc8c57888e62b26684082dd07a4314b45f9fa7f Gerrit-Change-Number: 3403 Gerrit-PatchSet: 1 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 23:30:28 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Remove unnecessary inner classes
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3403 ) Change subject: [NO ISSUE][FUN] Remove unnecessary inner classes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/1089/ (15/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3403 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cc8c57888e62b26684082dd07a4314b45f9fa7f Gerrit-Change-Number: 3403 Gerrit-PatchSet: 1 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 23:30:42 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Remove unnecessary inner classes
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3403 ) Change subject: [NO ISSUE][FUN] Remove unnecessary inner classes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5793/ (9/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3403 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cc8c57888e62b26684082dd07a4314b45f9fa7f Gerrit-Change-Number: 3403 Gerrit-PatchSet: 1 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 23:30:30 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Remove unnecessary inner classes
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3403 ) Change subject: [NO ISSUE][FUN] Remove unnecessary inner classes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/11304/ (10/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3403 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cc8c57888e62b26684082dd07a4314b45f9fa7f Gerrit-Change-Number: 3403 Gerrit-PatchSet: 1 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 23:30:32 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Remove unnecessary inner classes
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3403 ) Change subject: [NO ISSUE][FUN] Remove unnecessary inner classes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1180/ (11/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3403 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cc8c57888e62b26684082dd07a4314b45f9fa7f Gerrit-Change-Number: 3403 Gerrit-PatchSet: 1 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 23:30:33 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Remove unnecessary inner classes
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3403 ) Change subject: [NO ISSUE][FUN] Remove unnecessary inner classes .. Patch Set 1: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4440/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3403 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cc8c57888e62b26684082dd07a4314b45f9fa7f Gerrit-Change-Number: 3403 Gerrit-PatchSet: 1 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 23:33:47 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Remove unnecessary inner classes
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3403 ) Change subject: [NO ISSUE][FUN] Remove unnecessary inner classes .. Patch Set 1: Analytics Compatibility Compilation Successful https://cbjenkins.page.link/bN5SXAQT3RPttBWK6 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3403 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cc8c57888e62b26684082dd07a4314b45f9fa7f Gerrit-Change-Number: 3403 Gerrit-PatchSet: 1 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 23:34:42 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Remove unnecessary inner classes
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3403 ) Change subject: [NO ISSUE][FUN] Remove unnecessary inner classes .. Patch Set 1: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4440/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3403 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cc8c57888e62b26684082dd07a4314b45f9fa7f Gerrit-Change-Number: 3403 Gerrit-PatchSet: 1 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Wed, 22 May 2019 23:50:45 + Gerrit-HasComments: No
Change in asterixdb[master]: [WIP] Convert docs from markdown to asciidoc
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3402 ) Change subject: [WIP] Convert docs from markdown to asciidoc .. Patch Set 2: Contrib-2 Analytics Compatibility Tests Failed https://cbjenkins.page.link/38mxmC5EfqBXMJfr8 : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/3402 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaea656cdd446cf0c2868c35c557b8a2488ceffd7 Gerrit-Change-Number: 3402 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 23 May 2019 00:33:34 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Remove unnecessary inner classes
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3403 ) Change subject: [NO ISSUE][FUN] Remove unnecessary inner classes .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8591/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3403 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cc8c57888e62b26684082dd07a4314b45f9fa7f Gerrit-Change-Number: 3403 Gerrit-PatchSet: 1 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 23 May 2019 00:43:42 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Remove unnecessary inner classes
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3403 ) Change subject: [NO ISSUE][FUN] Remove unnecessary inner classes .. Patch Set 1: Contrib-2 Analytics Compatibility Tests Failed https://cbjenkins.page.link/L3s9pjGtMryZvJqF9 : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/3403 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cc8c57888e62b26684082dd07a4314b45f9fa7f Gerrit-Change-Number: 3403 Gerrit-PatchSet: 1 Gerrit-Owner: Hussain Towaileb Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Thu, 23 May 2019 01:14:00 + Gerrit-HasComments: No
