Change in asterixdb[master]: [ASTERIXDB-2491][TXN] Fix(hack) to 16-bit offset overflow
Michael Blow has abandoned this change. Change subject: [ASTERIXDB-2491][TXN] Fix(hack) to 16-bit offset overflow .. Abandoned obsoleted by https://asterix-gerrit.ics.uci.edu/#/c/3065/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3140 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I2ab49af8ce7c4753404dbb38ac58e28f75cae8fe Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wail Alkowaileet Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins
Change in asterixdb[master]: [ASTERIXDB-2491][TXN] Fix(hack) to 16-bit offset overflow
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2491][TXN] Fix(hack) to 16-bit offset overflow .. Patch Set 1: Contrib-2 Analytics Compatibility Tests Failed https://goo.gl/A9Ax6K : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/3140 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ab49af8ce7c4753404dbb38ac58e28f75cae8fe Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wail Alkowaileet Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2491][TXN] Fix(hack) to 16-bit offset overflow
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2491][TXN] Fix(hack) to 16-bit offset overflow .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/136/ (15/15) -- To view, visit https://asterix-gerrit.ics.uci.edu/3140 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ab49af8ce7c4753404dbb38ac58e28f75cae8fe Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wail Alkowaileet Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2491][TXN] Fix(hack) to 16-bit offset overflow
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2491][TXN] Fix(hack) to 16-bit offset overflow .. Patch Set 1: Integration-Tests-1 Integration Tests Failed https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7845/ : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/3140 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ab49af8ce7c4753404dbb38ac58e28f75cae8fe Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wail Alkowaileet Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2491][TXN] Fix(hack) to 16-bit offset overflow
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2491][TXN] Fix(hack) to 16-bit offset overflow .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5352/ (14/15) -- To view, visit https://asterix-gerrit.ics.uci.edu/3140 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ab49af8ce7c4753404dbb38ac58e28f75cae8fe Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wail Alkowaileet Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2491][TXN] Fix(hack) to 16-bit offset overflow
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2491][TXN] Fix(hack) to 16-bit offset overflow .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3030/ (9/15) -- To view, visit https://asterix-gerrit.ics.uci.edu/3140 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ab49af8ce7c4753404dbb38ac58e28f75cae8fe Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wail Alkowaileet Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2491][TXN] Fix(hack) to 16-bit offset overflow
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2491][TXN] Fix(hack) to 16-bit offset overflow .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/423/ (2/15) -- To view, visit https://asterix-gerrit.ics.uci.edu/3140 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ab49af8ce7c4753404dbb38ac58e28f75cae8fe Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wail Alkowaileet Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2491][TXN] Fix(hack) to 16-bit offset overflow
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2491][TXN] Fix(hack) to 16-bit offset overflow .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/186/ (8/15) -- To view, visit https://asterix-gerrit.ics.uci.edu/3140 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ab49af8ce7c4753404dbb38ac58e28f75cae8fe Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wail Alkowaileet Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2491][TXN] Fix(hack) to 16-bit offset overflow
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2491][TXN] Fix(hack) to 16-bit offset overflow .. Patch Set 1: Analytics Compatibility Compilation Successful https://goo.gl/FRpYuc : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3140 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ab49af8ce7c4753404dbb38ac58e28f75cae8fe Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wail Alkowaileet Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2491][TXN] Fix(hack) to 16-bit offset overflow
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2491][TXN] Fix(hack) to 16-bit offset overflow .. Patch Set 1: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/3140 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ab49af8ce7c4753404dbb38ac58e28f75cae8fe Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wail Alkowaileet Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2491][TXN] Fix(hack) to 16-bit offset overflow
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2491][TXN] Fix(hack) to 16-bit offset overflow .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5028/ (13/15) -- To view, visit https://asterix-gerrit.ics.uci.edu/3140 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ab49af8ce7c4753404dbb38ac58e28f75cae8fe Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wail Alkowaileet Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2491][TXN] Fix(hack) to 16-bit offset overflow
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2491][TXN] Fix(hack) to 16-bit offset overflow .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7845/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3140 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ab49af8ce7c4753404dbb38ac58e28f75cae8fe Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wail Alkowaileet Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2491][TXN] Fix(hack) to 16-bit offset overflow
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2491][TXN] Fix(hack) to 16-bit offset overflow .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/5243/ (12/15) -- To view, visit https://asterix-gerrit.ics.uci.edu/3140 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ab49af8ce7c4753404dbb38ac58e28f75cae8fe Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wail Alkowaileet Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2491][TXN] Fix(hack) to 16-bit offset overflow
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2491][TXN] Fix(hack) to 16-bit offset overflow .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/5403/ (1/15) -- To view, visit https://asterix-gerrit.ics.uci.edu/3140 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ab49af8ce7c4753404dbb38ac58e28f75cae8fe Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wail Alkowaileet Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2491][TXN] Fix(hack) to 16-bit offset overflow
Wail Alkowaileet has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/3140
Change subject: [ASTERIXDB-2491][TXN] Fix(hack) to 16-bit offset overflow
..
[ASTERIXDB-2491][TXN] Fix(hack) to 16-bit offset overflow
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Add unsigned short deserializer
- Try to detect overflowed offsets and try to ensure
offsets are monotonically increasing.
- As a last resort, it sets the last field's (payload's)
end offset as the size of the value.
- Add recovery test (passed 100KB record)
Change-Id: I2ab49af8ce7c4753404dbb38ac58e28f75cae8fe
---
M
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/LogRecord.java
A
asterixdb/asterix-server/src/test/resources/transactionts/queries/recover_after_abort/large_object_100K/large_object_100K.1.script.aql
A
asterixdb/asterix-server/src/test/resources/transactionts/queries/recover_after_abort/large_object_100K/large_object_100K.2.ddl.aql
A
asterixdb/asterix-server/src/test/resources/transactionts/queries/recover_after_abort/large_object_100K/large_object_100K.3.update.aql
A
asterixdb/asterix-server/src/test/resources/transactionts/queries/recover_after_abort/large_object_100K/large_object_100K.4.txnqbc.aql
A
asterixdb/asterix-server/src/test/resources/transactionts/queries/recover_after_abort/large_object_100K/large_object_100K.5.script.aql
A
asterixdb/asterix-server/src/test/resources/transactionts/queries/recover_after_abort/large_object_100K/large_object_100K.6.script.aql
A
asterixdb/asterix-server/src/test/resources/transactionts/queries/recover_after_abort/large_object_100K/large_object_100K.7.txnqar.aql
A
asterixdb/asterix-server/src/test/resources/transactionts/queries/recover_after_abort/large_object_100K/large_object_100K.8.script.aql
A
asterixdb/asterix-server/src/test/resources/transactionts/scripts/recover_after_abort/large_object_100K/create_and_start.sh
A
asterixdb/asterix-server/src/test/resources/transactionts/scripts/recover_after_abort/large_object_100K/kill_cc_and_nc.sh
A
asterixdb/asterix-server/src/test/resources/transactionts/scripts/recover_after_abort/large_object_100K/stop_and_delete.sh
A
asterixdb/asterix-server/src/test/resources/transactionts/scripts/recover_after_abort/large_object_100K/stop_and_start.sh
M asterixdb/asterix-server/src/test/resources/transactionts/testsuite.xml
M
hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/primitive/ShortPointable.java
M
hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/tuples/SimpleTupleReference.java
M
hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/tuples/SimpleTupleWriter.java
17 files changed, 342 insertions(+), 19 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/40/3140/1
diff --git
a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/LogRecord.java
b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/LogRecord.java
index 7a1079d..c8da50a 100644
---
a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/LogRecord.java
+++
b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/LogRecord.java
@@ -415,8 +415,8 @@
if (srcBuffer.position() + size > srcBuffer.limit()) {
throw new BufferUnderflowException();
}
+destTuple.resetByTupleOffset(srcBuffer.array(), srcBuffer.position(),
size);
destTuple.setFieldCount(fieldCnt);
-destTuple.resetByTupleOffset(srcBuffer.array(), srcBuffer.position());
srcBuffer.position(srcBuffer.position() + size);
return destTuple;
}
diff --git
a/asterixdb/asterix-server/src/test/resources/transactionts/queries/recover_after_abort/large_object_100K/large_object_100K.1.script.aql
b/asterixdb/asterix-server/src/test/resources/transactionts/queries/recover_after_abort/large_object_100K/large_object_100K.1.script.aql
new file mode 100644
index 000..7d441cd
--- /dev/null
+++
b/asterixdb/asterix-server/src/test/resources/transactionts/queries/recover_after_abort/large_object_100K/large_object_100K.1.script.aql
@@ -0,0 +1,19 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the
Change in asterixdb[master]: [ASTERIXDB-2491][TXN] Fix(hack) to 16-bit offset overflow
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2491][TXN] Fix(hack) to 16-bit offset overflow .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4932/ (4/15) -- To view, visit https://asterix-gerrit.ics.uci.edu/3140 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ab49af8ce7c4753404dbb38ac58e28f75cae8fe Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wail Alkowaileet Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2491][TXN] Fix(hack) to 16-bit offset overflow
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2491][TXN] Fix(hack) to 16-bit offset overflow .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/423/ (10/15) -- To view, visit https://asterix-gerrit.ics.uci.edu/3140 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ab49af8ce7c4753404dbb38ac58e28f75cae8fe Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wail Alkowaileet Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2491][TXN] Fix(hack) to 16-bit offset overflow
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2491][TXN] Fix(hack) to 16-bit offset overflow .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5020/ (6/15) -- To view, visit https://asterix-gerrit.ics.uci.edu/3140 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ab49af8ce7c4753404dbb38ac58e28f75cae8fe Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wail Alkowaileet Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2491][TXN] Fix(hack) to 16-bit offset overflow
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2491][TXN] Fix(hack) to 16-bit offset overflow .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/10502/ (3/15) -- To view, visit https://asterix-gerrit.ics.uci.edu/3140 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ab49af8ce7c4753404dbb38ac58e28f75cae8fe Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wail Alkowaileet Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2491][TXN] Fix(hack) to 16-bit offset overflow
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2491][TXN] Fix(hack) to 16-bit offset overflow .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4986/ (11/15) -- To view, visit https://asterix-gerrit.ics.uci.edu/3140 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ab49af8ce7c4753404dbb38ac58e28f75cae8fe Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wail Alkowaileet Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2491][TXN] Fix(hack) to 16-bit offset overflow
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2491][TXN] Fix(hack) to 16-bit offset overflow .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8969/ (5/15) -- To view, visit https://asterix-gerrit.ics.uci.edu/3140 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ab49af8ce7c4753404dbb38ac58e28f75cae8fe Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wail Alkowaileet Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2491][TXN] Fix(hack) to 16-bit offset overflow
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2491][TXN] Fix(hack) to 16-bit offset overflow .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/5593/ (7/15) -- To view, visit https://asterix-gerrit.ics.uci.edu/3140 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ab49af8ce7c4753404dbb38ac58e28f75cae8fe Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wail Alkowaileet Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
