[GitHub] codecov-io commented on issue #1745: New threadLocal provides more performance.
codecov-io commented on issue #1745: New threadLocal provides more performance. URL: https://github.com/apache/incubator-dubbo/pull/1745#issuecomment-386791924 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr&el=h1) Report > Merging [#1745](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/ddc1ea4149d3e6879be21a55981f4ccb5ad14920?src=pr&el=desc) will **decrease** coverage by `0.02%`. > The diff coverage is `46.82%`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0)](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#1745 +/- ## - Coverage 39.67% 39.65% -0.03% - Complexity 4285 4308 +23 Files 622 626 +4 Lines 2990730077 +170 Branches 5297 5318 +21 + Hits 1186711928 +61 - Misses1613816243 +105 - Partials 1902 1906 +4 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mmon/threadpool/support/fixed/FixedThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9maXhlZC9GaXhlZFRocmVhZFBvb2wuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [.../threadpool/support/limited/LimitedThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9saW1pdGVkL0xpbWl0ZWRUaHJlYWRQb29sLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...on/threadpool/support/cached/CachedThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9jYWNoZWQvQ2FjaGVkVGhyZWFkUG9vbC5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...mmon/threadpool/support/eager/EagerThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9lYWdlci9FYWdlclRocmVhZFBvb2wuamF2YQ==) | `90% <ø> (ø)` | `2 <0> (ø)` | :arrow_down: | | [...alibaba/dubbo/common/utils/NamedThreadFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3V0aWxzL05hbWVkVGhyZWFkRmFjdG9yeS5qYXZh) | `64.7% <100%> (ø)` | `3 <2> (ø)` | :arrow_down: | | [...rc/main/java/com/alibaba/dubbo/rpc/RpcContext.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvUnBjQ29udGV4dC5qYXZh) | `30.93% <100%> (ø)` | `27 <1> (ø)` | :arrow_down: | | [...common/threadlocal/NamedInternalThreadFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL05hbWVkSW50ZXJuYWxUaHJlYWRGYWN0b3J5LmphdmE=) | `20% <20%> (ø)` | `1 <1> (?)` | | | [...ibaba/dubbo/common/threadlocal/InternalThread.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL0ludGVybmFsVGhyZWFkLmphdmE=) | `26.31% <26.31%> (ø)` | `3 <3> (?)` | | | [.../dubbo/common/threadlocal/InternalThreadLocal.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL0ludGVybmFsVGhyZWFkTG9jYWwuamF2YQ==) | `35.82% <35.82%> (ø)` | `8 <8> (?)` | | | [...bbo/common/threadlocal/InternalThreadLocalMap.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL0ludGVybmFsVGhyZWFkTG9jYWxNYXAuamF2YQ==) | `63.51% <63.51%> (ø)` | `15 <15> (?)` | | | ... and [10 more](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr&el=continue). > **Legend** - [Click here to learn more
[GitHub] codecov-io commented on issue #1745: New threadLocal provides more performance.
codecov-io commented on issue #1745: New threadLocal provides more performance. URL: https://github.com/apache/incubator-dubbo/pull/1745#issuecomment-386791924 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr&el=h1) Report > Merging [#1745](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/ddc1ea4149d3e6879be21a55981f4ccb5ad14920?src=pr&el=desc) will **increase** coverage by `0.01%`. > The diff coverage is `46.82%`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/graphs/tree.svg?token=VnEIkiFQT0&width=650&src=pr&height=150)](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#1745 +/- ## + Coverage 39.67% 39.69% +0.01% - Complexity 4285 4309 +24 Files 622 626 +4 Lines 2990730077 +170 Branches 5297 5318 +21 + Hits 1186711938 +71 - Misses1613816232 +94 - Partials 1902 1907 +5 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../threadpool/support/limited/LimitedThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9saW1pdGVkL0xpbWl0ZWRUaHJlYWRQb29sLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...mmon/threadpool/support/eager/EagerThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9lYWdlci9FYWdlclRocmVhZFBvb2wuamF2YQ==) | `90% <ø> (ø)` | `2 <0> (ø)` | :arrow_down: | | [...mmon/threadpool/support/fixed/FixedThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9maXhlZC9GaXhlZFRocmVhZFBvb2wuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...on/threadpool/support/cached/CachedThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9jYWNoZWQvQ2FjaGVkVGhyZWFkUG9vbC5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...alibaba/dubbo/common/utils/NamedThreadFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3V0aWxzL05hbWVkVGhyZWFkRmFjdG9yeS5qYXZh) | `64.7% <100%> (ø)` | `3 <2> (ø)` | :arrow_down: | | [...rc/main/java/com/alibaba/dubbo/rpc/RpcContext.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvUnBjQ29udGV4dC5qYXZh) | `30.93% <100%> (ø)` | `27 <1> (ø)` | :arrow_down: | | [...common/threadlocal/NamedInternalThreadFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL05hbWVkSW50ZXJuYWxUaHJlYWRGYWN0b3J5LmphdmE=) | `20% <20%> (ø)` | `1 <1> (?)` | | | [...ibaba/dubbo/common/threadlocal/InternalThread.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL0ludGVybmFsVGhyZWFkLmphdmE=) | `26.31% <26.31%> (ø)` | `3 <3> (?)` | | | [.../dubbo/common/threadlocal/InternalThreadLocal.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL0ludGVybmFsVGhyZWFkTG9jYWwuamF2YQ==) | `35.82% <35.82%> (ø)` | `8 <8> (?)` | | | [...bbo/common/threadlocal/InternalThreadLocalMap.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL0ludGVybmFsVGhyZWFkTG9jYWxNYXAuamF2YQ==) | `63.51% <63.51%> (ø)` | `15 <15> (?)` | | | ... and [10 more](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr&el=continue). > **Legend** - [Click here to learn more
[GitHub] codecov-io commented on issue #1745: New threadLocal provides more performance.
codecov-io commented on issue #1745: New threadLocal provides more performance. URL: https://github.com/apache/incubator-dubbo/pull/1745#issuecomment-386791924 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr&el=h1) Report > Merging [#1745](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/ddc1ea4149d3e6879be21a55981f4ccb5ad14920?src=pr&el=desc) will **increase** coverage by `0.02%`. > The diff coverage is `46.82%`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0)](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #1745 +/- ## === + Coverage 39.67% 39.7% +0.02% - Complexity 42854309 +24 === Files 622 626 +4 Lines 29907 30077 +170 Branches 52975318 +21 === + Hits 11867 11943 +76 - Misses16138 16225 +87 - Partials 19021909 +7 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...on/threadpool/support/cached/CachedThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9jYWNoZWQvQ2FjaGVkVGhyZWFkUG9vbC5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...mmon/threadpool/support/eager/EagerThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9lYWdlci9FYWdlclRocmVhZFBvb2wuamF2YQ==) | `90% <ø> (ø)` | `2 <0> (ø)` | :arrow_down: | | [.../threadpool/support/limited/LimitedThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9saW1pdGVkL0xpbWl0ZWRUaHJlYWRQb29sLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...mmon/threadpool/support/fixed/FixedThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9maXhlZC9GaXhlZFRocmVhZFBvb2wuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...alibaba/dubbo/common/utils/NamedThreadFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3V0aWxzL05hbWVkVGhyZWFkRmFjdG9yeS5qYXZh) | `64.7% <100%> (ø)` | `3 <2> (ø)` | :arrow_down: | | [...rc/main/java/com/alibaba/dubbo/rpc/RpcContext.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvUnBjQ29udGV4dC5qYXZh) | `30.93% <100%> (ø)` | `27 <1> (ø)` | :arrow_down: | | [...common/threadlocal/NamedInternalThreadFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL05hbWVkSW50ZXJuYWxUaHJlYWRGYWN0b3J5LmphdmE=) | `20% <20%> (ø)` | `1 <1> (?)` | | | [...ibaba/dubbo/common/threadlocal/InternalThread.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL0ludGVybmFsVGhyZWFkLmphdmE=) | `26.31% <26.31%> (ø)` | `3 <3> (?)` | | | [.../dubbo/common/threadlocal/InternalThreadLocal.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL0ludGVybmFsVGhyZWFkTG9jYWwuamF2YQ==) | `35.82% <35.82%> (ø)` | `8 <8> (?)` | | | [...bbo/common/threadlocal/InternalThreadLocalMap.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL0ludGVybmFsVGhyZWFkTG9jYWxNYXAuamF2YQ==) | `63.51% <63.51%> (ø)` | `15 <15> (?)` | | | ... and [10 more](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr&el=continue). > **Legend** - [Click here to learn more](https://doc
[GitHub] codecov-io commented on issue #1745: New threadLocal provides more performance.
codecov-io commented on issue #1745: New threadLocal provides more performance. URL: https://github.com/apache/incubator-dubbo/pull/1745#issuecomment-386791924 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr&el=h1) Report > Merging [#1745](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/ddc1ea4149d3e6879be21a55981f4ccb5ad14920?src=pr&el=desc) will **increase** coverage by `0.02%`. > The diff coverage is `46.82%`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/graphs/tree.svg?height=150&width=650&token=VnEIkiFQT0&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #1745 +/- ## === + Coverage 39.67% 39.7% +0.02% - Complexity 42854309 +24 === Files 622 626 +4 Lines 29907 30077 +170 Branches 52975318 +21 === + Hits 11867 11943 +76 - Misses16138 16225 +87 - Partials 19021909 +7 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...on/threadpool/support/cached/CachedThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9jYWNoZWQvQ2FjaGVkVGhyZWFkUG9vbC5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...mmon/threadpool/support/eager/EagerThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9lYWdlci9FYWdlclRocmVhZFBvb2wuamF2YQ==) | `90% <ø> (ø)` | `2 <0> (ø)` | :arrow_down: | | [.../threadpool/support/limited/LimitedThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9saW1pdGVkL0xpbWl0ZWRUaHJlYWRQb29sLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...mmon/threadpool/support/fixed/FixedThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9maXhlZC9GaXhlZFRocmVhZFBvb2wuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...rc/main/java/com/alibaba/dubbo/rpc/RpcContext.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvUnBjQ29udGV4dC5qYXZh) | `30.93% <100%> (ø)` | `27 <1> (ø)` | :arrow_down: | | [...alibaba/dubbo/common/utils/NamedThreadFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3V0aWxzL05hbWVkVGhyZWFkRmFjdG9yeS5qYXZh) | `64.7% <100%> (ø)` | `3 <2> (ø)` | :arrow_down: | | [...common/threadlocal/NamedInternalThreadFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL05hbWVkSW50ZXJuYWxUaHJlYWRGYWN0b3J5LmphdmE=) | `20% <20%> (ø)` | `1 <1> (?)` | | | [...ibaba/dubbo/common/threadlocal/InternalThread.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL0ludGVybmFsVGhyZWFkLmphdmE=) | `26.31% <26.31%> (ø)` | `3 <3> (?)` | | | [.../dubbo/common/threadlocal/InternalThreadLocal.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL0ludGVybmFsVGhyZWFkTG9jYWwuamF2YQ==) | `35.82% <35.82%> (ø)` | `8 <8> (?)` | | | [...bbo/common/threadlocal/InternalThreadLocalMap.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL0ludGVybmFsVGhyZWFkTG9jYWxNYXAuamF2YQ==) | `63.51% <63.51%> (ø)` | `15 <15> (?)` | | | ... and [10 more](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr&el=continue). > **Legend** - [Click here to learn more](https://doc
[GitHub] codecov-io commented on issue #1745: New threadLocal provides more performance.
codecov-io commented on issue #1745: New threadLocal provides more performance. URL: https://github.com/apache/incubator-dubbo/pull/1745#issuecomment-386791924 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr&el=h1) Report > Merging [#1745](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/ddc1ea4149d3e6879be21a55981f4ccb5ad14920?src=pr&el=desc) will **increase** coverage by `0.02%`. > The diff coverage is `46.82%`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/graphs/tree.svg?token=VnEIkiFQT0&width=650&src=pr&height=150)](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #1745 +/- ## === + Coverage 39.67% 39.7% +0.02% - Complexity 42854309 +24 === Files 622 626 +4 Lines 29907 30077 +170 Branches 52975318 +21 === + Hits 11867 11943 +76 - Misses16138 16225 +87 - Partials 19021909 +7 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...on/threadpool/support/cached/CachedThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9jYWNoZWQvQ2FjaGVkVGhyZWFkUG9vbC5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...mmon/threadpool/support/eager/EagerThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9lYWdlci9FYWdlclRocmVhZFBvb2wuamF2YQ==) | `90% <ø> (ø)` | `2 <0> (ø)` | :arrow_down: | | [.../threadpool/support/limited/LimitedThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9saW1pdGVkL0xpbWl0ZWRUaHJlYWRQb29sLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...mmon/threadpool/support/fixed/FixedThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9maXhlZC9GaXhlZFRocmVhZFBvb2wuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...rc/main/java/com/alibaba/dubbo/rpc/RpcContext.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvUnBjQ29udGV4dC5qYXZh) | `30.93% <100%> (ø)` | `27 <1> (ø)` | :arrow_down: | | [...alibaba/dubbo/common/utils/NamedThreadFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3V0aWxzL05hbWVkVGhyZWFkRmFjdG9yeS5qYXZh) | `64.7% <100%> (ø)` | `3 <2> (ø)` | :arrow_down: | | [...common/threadlocal/NamedInternalThreadFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL05hbWVkSW50ZXJuYWxUaHJlYWRGYWN0b3J5LmphdmE=) | `20% <20%> (ø)` | `1 <1> (?)` | | | [...ibaba/dubbo/common/threadlocal/InternalThread.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL0ludGVybmFsVGhyZWFkLmphdmE=) | `26.31% <26.31%> (ø)` | `3 <3> (?)` | | | [.../dubbo/common/threadlocal/InternalThreadLocal.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL0ludGVybmFsVGhyZWFkTG9jYWwuamF2YQ==) | `35.82% <35.82%> (ø)` | `8 <8> (?)` | | | [...bbo/common/threadlocal/InternalThreadLocalMap.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL0ludGVybmFsVGhyZWFkTG9jYWxNYXAuamF2YQ==) | `63.51% <63.51%> (ø)` | `15 <15> (?)` | | | ... and [10 more](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr&el=continue). > **Legend** - [Click here to learn more](https://doc
[GitHub] codecov-io commented on issue #1745: New threadLocal provides more performance.
codecov-io commented on issue #1745: New threadLocal provides more performance. URL: https://github.com/apache/incubator-dubbo/pull/1745#issuecomment-386791924 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr&el=h1) Report > Merging [#1745](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/04c93e8b98250230c4d22423372acd1c29e2c770?src=pr&el=desc) will **increase** coverage by `0.1%`. > The diff coverage is `46.82%`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/graphs/tree.svg?height=150&width=650&src=pr&token=VnEIkiFQT0)](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#1745 +/- ## === + Coverage 37.92% 38.02% +0.1% - Complexity 4024 4055 +31 === Files 618 622 +4 Lines 2973029900+170 Branches 5244 5265 +21 === + Hits 1127511370 +95 - Misses1661016682 +72 - Partials 1845 1848 +3 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mmon/threadpool/support/fixed/FixedThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9maXhlZC9GaXhlZFRocmVhZFBvb2wuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [.../threadpool/support/limited/LimitedThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9saW1pdGVkL0xpbWl0ZWRUaHJlYWRQb29sLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...mmon/threadpool/support/eager/EagerThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9lYWdlci9FYWdlclRocmVhZFBvb2wuamF2YQ==) | `90% <ø> (ø)` | `2 <0> (ø)` | :arrow_down: | | [...on/threadpool/support/cached/CachedThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9jYWNoZWQvQ2FjaGVkVGhyZWFkUG9vbC5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...alibaba/dubbo/common/utils/NamedThreadFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3V0aWxzL05hbWVkVGhyZWFkRmFjdG9yeS5qYXZh) | `64.7% <100%> (ø)` | `3 <2> (ø)` | :arrow_down: | | [...rc/main/java/com/alibaba/dubbo/rpc/RpcContext.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvUnBjQ29udGV4dC5qYXZh) | `30.93% <100%> (ø)` | `27 <1> (ø)` | :arrow_down: | | [...common/threadlocal/NamedInternalThreadFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL05hbWVkSW50ZXJuYWxUaHJlYWRGYWN0b3J5LmphdmE=) | `20% <20%> (ø)` | `1 <1> (?)` | | | [...ibaba/dubbo/common/threadlocal/InternalThread.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL0ludGVybmFsVGhyZWFkLmphdmE=) | `26.31% <26.31%> (ø)` | `3 <3> (?)` | | | [.../dubbo/common/threadlocal/InternalThreadLocal.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL0ludGVybmFsVGhyZWFkTG9jYWwuamF2YQ==) | `35.82% <35.82%> (ø)` | `8 <8> (?)` | | | [...bbo/common/threadlocal/InternalThreadLocalMap.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL0ludGVybmFsVGhyZWFkTG9jYWxNYXAuamF2YQ==) | `63.51% <63.51%> (ø)` | `15 <15> (?)` | | | ... and [13 more](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs