[GitHub] [dubbo] LinShunKang commented on issue #5004: RpcUtils.getReturnTypes(Invocation) 性能问题
@chickenlj 你好,我看了 `performance-tuning-2.7.x` 分支上相关代码,整体思路和我的差不多,但是,实现方式不太一样: * Dubbo 的实现方式是在生成每一个 `RpcInvocation` 对象的时候从缓存中获取 `returnTypes` 并放到 `RpcInvocation` 对象中保存起来 * 我的实现方式是直接修改 `RpcUtils.getReturnTypes(Invocation)` 的实现,从缓存中获 `returnTypes`并返回 个人观点: Dubbo 的实现方式会导致每一个 RpcInvocation 对象的占用空间变大,如果 Consumer 对外的请求量比较高,会对 GC 有一些影响,虽然不大。 [ Full content available at: https://github.com/apache/dubbo/issues/5004 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] 1076572358 opened issue #5081: 有人碰到dubbo跟rabbitmq消费者一起启动有冲突吗
使用rebbitmq消费机打开后批量消费数据,dubbo消费者调用dubbo生产者就调不通了,超时。有人碰到过吗。 [ Full content available at: https://github.com/apache/dubbo/issues/5081 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] chickenlj commented on issue #4899: [Dubbo-4882] Add support for overriding Map properties in AbstractConfig.refresh
change format to `dubbo.application.parameters=[{a:1}, {b:2}]` [ Full content available at: https://github.com/apache/dubbo/pull/4899 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] 1076572358 commented on issue #5081: 有人碰到dubbo跟rabbitmq消费者一起启动有冲突吗
spring.rabbitmq.listener.simple.concurrency = 3 ,这里开启的并发concurrency大于3就调用不到服务生产者这里来了 实在是百思不得其解 [ Full content available at: https://github.com/apache/dubbo/issues/5081 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #208: fix issue#207: common/utils/net_test.go:25 cannot pass
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/208?src=pr&el=h1) Report > Merging [#208](https://codecov.io/gh/apache/dubbo-go/pull/208?src=pr&el=desc) > into > [master](https://codecov.io/gh/apache/dubbo-go/commit/4cf8f0e6097b79d03980fe0cf3f2d8ba008173d6?src=pr&el=desc) > will **increase** coverage by `1.04%`. > The diff coverage is `66.66%`. [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/208/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/208?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #208 +/- ## == + Coverage 66.62% 67.66% +1.04% == Files 94 94 Lines5821 5824 +3 == + Hits 3878 3941 +63 + Misses 1541 1478 -63 - Partials 402 405 +3 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/208?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [common/utils/net.go](https://codecov.io/gh/apache/dubbo-go/pull/208/diff?src=pr&el=tree#diff-Y29tbW9uL3V0aWxzL25ldC5nbw==) | `68.57% <66.66%> (-3.31%)` | :arrow_down: | | [registry/etcdv3/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/208/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL3JlZ2lzdHJ5Lmdv) | `56.89% <0%> (+1.14%)` | :arrow_up: | | [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/208/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `80.64% <0%> (+2.15%)` | :arrow_up: | | [protocol/dubbo/readwriter.go](https://codecov.io/gh/apache/dubbo-go/pull/208/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcmVhZHdyaXRlci5nbw==) | `70.37% <0%> (+2.46%)` | :arrow_up: | | [protocol/dubbo/codec.go](https://codecov.io/gh/apache/dubbo-go/pull/208/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY29kZWMuZ28=) | `82.35% <0%> (+5.88%)` | :arrow_up: | | [protocol/dubbo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/208/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vbGlzdGVuZXIuZ28=) | `64.02% <0%> (+14.02%)` | :arrow_up: | | [protocol/dubbo/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/208/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcG9vbC5nbw==) | `73.6% <0%> (+15.73%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/208?src=pr&el=continue). > **Legend** - [Click here to learn > more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by > [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/208?src=pr&el=footer). > Last update > [4cf8f0e...9961541](https://codecov.io/gh/apache/dubbo-go/pull/208?src=pr&el=lastupdated). > Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). [ Full content available at: https://github.com/apache/dubbo-go/pull/208 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] mzorro commented on issue #4899: [Dubbo-4882] Add support for overriding Map properties in AbstractConfig.refresh
> change format to `dubbo.application.parameters=[{a:1}, {b:2}]` @chickenlj why do you think this format is more readable? It's not even standard JSON. [ Full content available at: https://github.com/apache/dubbo/pull/4899 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] cvictory closed pull request #4899: [Dubbo-4882] Add support for overriding Map properties in AbstractConfig.refresh
[ pull request closed by cvictory ] [ Full content available at: https://github.com/apache/dubbo/pull/4899 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] lxf-NewBanker commented on issue #1070: com.alibaba.dubbo.rpc.RpcException: Forbid consumer 169.254.226.207 access service com.base.service.AppService from registry localhost:2181 use
@jkxqj https://github.com/apache/dubbo/issues/684 中,[david1228用户](https://github.com/david1228) 评论说: > 我的本地环境中也遇到类似的问题, 报错信息: Forbid consumer 10.58.95.10 access service com.xxx.mms.api.service.IAlbumService from registry 36.110.219.106:2181 use dubbo version 2.5.3, Please check registry access list (whitelist/blacklist). 当provider启动后,在zk中的providers节点下面能够看到注册信息,当消费端consumer启动后,zk中providers下注册信息丢失了,而consumers节点中有2份注册信息。 这个问题是因为IDEA中使用同一个Tomcat启动provider和consumer服务就会出现上述异常,使用两个tomcat分别启动provider和consumer就没问题,或者都用jetty插件方式启动也没问题。 [ Full content available at: https://github.com/apache/dubbo/issues/1070 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] codecov-io commented on issue #5070: [Dubbo-4331] Improve api doc #4331
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/5070?src=pr&el=h1) Report > Merging [#5070](https://codecov.io/gh/apache/dubbo/pull/5070?src=pr&el=desc) > into > [master](https://codecov.io/gh/apache/dubbo/commit/b53624e4e88a545a3478525bac58aac3ac12afba?src=pr&el=desc) > will **decrease** coverage by `0.03%`. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/5070/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/dubbo/pull/5070?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5070 +/- ## - Coverage 64.01% 63.98% -0.04% - Complexity 451 452 +1 Files 769 769 Lines 3324633246 Branches 5246 5246 - Hits 2128421273 -11 - Misses 9530 9546 +16 + Partials 2432 2427 -5 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/5070?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../apache/dubbo/qos/protocol/QosProtocolWrapper.java](https://codecov.io/gh/apache/dubbo/pull/5070/diff?src=pr&el=tree#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL3Byb3RvY29sL1Fvc1Byb3RvY29sV3JhcHBlci5qYXZh) | `65.85% <0%> (-17.08%)` | `0% <0%> (ø)` | | | [...ng/transport/dispatcher/all/AllChannelHandler.java](https://codecov.io/gh/apache/dubbo/pull/5070/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvZGlzcGF0Y2hlci9hbGwvQWxsQ2hhbm5lbEhhbmRsZXIuamF2YQ==) | `51.42% <0%> (-5.72%)` | `0% <0%> (ø)` | | | [...pache/dubbo/registry/support/AbstractRegistry.java](https://codecov.io/gh/apache/dubbo/pull/5070/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9zdXBwb3J0L0Fic3RyYWN0UmVnaXN0cnkuamF2YQ==) | `78.54% <0%> (-3.07%)` | `0% <0%> (ø)` | | | [.../rpc/protocol/dubbo/LazyConnectExchangeClient.java](https://codecov.io/gh/apache/dubbo/pull/5070/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0xhenlDb25uZWN0RXhjaGFuZ2VDbGllbnQuamF2YQ==) | `56.47% <0%> (-2.36%)` | `0% <0%> (ø)` | | | [.../dubbo/remoting/transport/netty4/NettyChannel.java](https://codecov.io/gh/apache/dubbo/pull/5070/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5Q2hhbm5lbC5qYXZh) | `64.77% <0%> (+1.13%)` | `0% <0%> (ø)` | :arrow_down: | | [...c/main/java/org/apache/dubbo/rpc/RpcException.java](https://codecov.io/gh/apache/dubbo/pull/5070/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNFeGNlcHRpb24uamF2YQ==) | `83.33% <0%> (+3.33%)` | `0% <0%> (ø)` | :arrow_down: | | [...e/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/dubbo/pull/5070/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eUNoYW5uZWwuamF2YQ==) | `60.22% <0%> (+4.54%)` | `21% <0%> (+1%)` | :arrow_up: | | [...onfig/spring/extension/SpringExtensionFactory.java](https://codecov.io/gh/apache/dubbo/pull/5070/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvZXh0ZW5zaW9uL1NwcmluZ0V4dGVuc2lvbkZhY3RvcnkuamF2YQ==) | `85.36% <0%> (+4.87%)` | `0% <0%> (ø)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/5070?src=pr&el=continue). > **Legend** - [Click here to learn > more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by > [Codecov](https://codecov.io/gh/apache/dubbo/pull/5070?src=pr&el=footer). > Last update > [b53624e...ccade13](https://codecov.io/gh/apache/dubbo/pull/5070?src=pr&el=lastupdated). > Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). [ Full content available at: https://github.com/apache/dubbo/pull/5070 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] codecov-io commented on issue #3850: Fix registry check=false invalid
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/3850?src=pr&el=h1) Report > Merging [#3850](https://codecov.io/gh/apache/dubbo/pull/3850?src=pr&el=desc) > into > [master](https://codecov.io/gh/apache/dubbo/commit/87c78878c639cfd0b055ed370d9daa4f4d9b1373?src=pr&el=desc) > will **increase** coverage by `<.01%`. > The diff coverage is `92.3%`. [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/3850/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/dubbo/pull/3850?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#3850 +/- ## + Coverage 63.99% 63.99% +<.01% Complexity 453 453 Files 769 769 Lines 3321333247 +34 Branches 5239 5247 +8 + Hits 2125521277 +22 - Misses 9534 9546 +12 Partials 2424 2424 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/3850?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...n/java/org/apache/dubbo/config/RegistryConfig.java](https://codecov.io/gh/apache/dubbo/pull/3850/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9SZWdpc3RyeUNvbmZpZy5qYXZh) | `89.65% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...g/apache/dubbo/config/AbstractInterfaceConfig.java](https://codecov.io/gh/apache/dubbo/pull/3850/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9BYnN0cmFjdEludGVyZmFjZUNvbmZpZy5qYXZh) | `71.67% <91.66%> (+0.08%)` | `0 <0> (ø)` | :arrow_down: | | [.../apache/dubbo/qos/protocol/QosProtocolWrapper.java](https://codecov.io/gh/apache/dubbo/pull/3850/diff?src=pr&el=tree#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL3Byb3RvY29sL1Fvc1Byb3RvY29sV3JhcHBlci5qYXZh) | `65.85% <0%> (-4.88%)` | `0% <0%> (ø)` | | | [...e/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/dubbo/pull/3850/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eUNoYW5uZWwuamF2YQ==) | `55.68% <0%> (-4.55%)` | `20% <0%> (-1%)` | | | [...g/apache/dubbo/rpc/protocol/rest/RestProtocol.java](https://codecov.io/gh/apache/dubbo/pull/3850/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1yZXN0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvcHJvdG9jb2wvcmVzdC9SZXN0UHJvdG9jb2wuamF2YQ==) | `68.21% <0%> (-3.11%)` | `0% <0%> (ø)` | | | [.../rpc/protocol/dubbo/LazyConnectExchangeClient.java](https://codecov.io/gh/apache/dubbo/pull/3850/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0xhenlDb25uZWN0RXhjaGFuZ2VDbGllbnQuamF2YQ==) | `56.47% <0%> (-2.36%)` | `0% <0%> (ø)` | | | [...he/dubbo/registry/multicast/MulticastRegistry.java](https://codecov.io/gh/apache/dubbo/pull/3850/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktbXVsdGljYXN0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9tdWx0aWNhc3QvTXVsdGljYXN0UmVnaXN0cnkuamF2YQ==) | `67.87% <0%> (-1.36%)` | `0% <0%> (ø)` | | | [...ava/org/apache/dubbo/common/utils/ConfigUtils.java](https://codecov.io/gh/apache/dubbo/pull/3850/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvQ29uZmlnVXRpbHMuamF2YQ==) | `80% <0%> (-0.75%)` | `0% <0%> (ø)` | | | [...apache/dubbo/common/extension/ExtensionLoader.java](https://codecov.io/gh/apache/dubbo/pull/3850/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vZXh0ZW5zaW9uL0V4dGVuc2lvbkxvYWRlci5qYXZh) | `79.06% <0%> (-0.26%)` | `0% <0%> (ø)` | | | [.../apache/dubbo/remoting/transport/AbstractPeer.java](https://codecov.io/gh/apache/dubbo/pull/3850/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RQZWVyLmphdmE=) | `63.04% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: | | ... and [8 more](https://codecov.io/gh/apache/dubbo/pull/3850/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/3850?src=pr&el=continue). > **Legend** - [Click here to learn > more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by > [Codecov](https://codecov.io/gh/apache/dubbo/pull/3850?src=pr&el=footer). > Last update > [87c7887...313afea](https://codecov.io/gh/apache/dubbo/pull/3850?src=pr&el=lastupdated). > Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). [ Ful
[GitHub] [dubbo] vio-lin opened issue #5082: ProtobufTypeBuilder should support generate type definition which contains Bytes List or Bytes Map
- [x] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate. - [x] I have checked the [FAQ](https://github.com/apache/dubbo/blob/master/FAQ.md) of this repository and believe that this is not a duplicate. ### Environment * Dubbo version: 2.7.3 * Operating System version: win7 * Java version: jdk8 ### Steps to reproduce this issue 1. write a goole proto file contain bytes list or bytes map. ` syntax = "proto2"; package org.apache.dubbo.metadata.definition.protobuf.model; message PBRequestType { optional bytes msg = 7; repeated bytes bytesList = 10; map bytesMap = 11; } ` 2. generate goolgle pb entity and used as service parameter. 3. add dependency ` com.google.protobuf dubbo-metadata-definition-protobuf ` 5. service log exception when generate service definition. see org.apache.dubbo.metadata.definition.protobuf.ProtobufTypeBuilderTest ### Expected Result serviceDefinition should be generated successfully. ### Actual Result If there is an exception, please attach the exception trace: ``` java.lang.IllegalArgumentException: Map protobuf property bytesMapof Type java.util.Map can't be parsed.Map with unString key or ByteString value is not supported. at org.apache.dubbo.metadata.definition.protobuf.ProtobufTypeBuilder.validateMapType(ProtobufTypeBuilder.java:164) at org.apache.dubbo.metadata.definition.protobuf.ProtobufTypeBuilder.buildProtobufTypeDefinition(ProtobufTypeBuilder.java:103) at org.apache.dubbo.metadata.definition.protobuf.ProtobufTypeBuilder.build(ProtobufTypeBuilder.java:72) at org.apache.dubbo.metadata.definition.TypeDefinitionBuilder.build(TypeDefinitionBuilder.java:52) at org.apache.dubbo.metadata.definition.TypeDefinitionBuilder.build(TypeDefinitionBuilder.java:81) at org.apache.dubbo.metadata.definition.ServiceDefinitionBuilder.build(ServiceDefinitionBuilder.java:77) at org.apache.dubbo.metadata.definition.ServiceDefinitionBuilder.buildFullDefinition(ServiceDefinitionBuilder.java:50) at org.apache.dubbo.metadata.definition.protobuf.ProtobufTypeBuilderTest.testProtobufBuilder(ProtobufTypeBuilderTest.java:40) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.platform.commons.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:628) at org.junit.jupiter.engine.execution.ExecutableInvoker.invoke(ExecutableInvoker.java:117) at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeTestMethod$7(TestMethodTestDescriptor.java:184) at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73) at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.invokeTestMethod(TestMethodTestDescriptor.java:180) at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:127) at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:68) at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$5(NodeTestTask.java:135) at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73) at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$7(NodeTestTask.java:125) at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:135) at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:123) at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73) at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:122) at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:80) at java.util.ArrayList.forEach(ArrayList.java:1249) at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.invokeAll(SameThreadHierarchicalTestExecutorService.java:38) at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$5(NodeTestTask.java:139) at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73) at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$7(NodeTestTask.java:125) at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:135) at org.junit.platform.engine.support.
[GitHub] [dubbo] cvictory closed pull request #5079: fix set generic method error
[ pull request closed by cvictory ] [ Full content available at: https://github.com/apache/dubbo/pull/5079 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] cvictory closed issue #3629: ServiceConfig duplicate export produces misleading exception
[ issue closed by cvictory ] [ Full content available at: https://github.com/apache/dubbo/issues/3629 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] cvictory closed pull request #5078: delete 'config.' prefix for url generated from ConfigCenterConfig
[ pull request closed by cvictory ] [ Full content available at: https://github.com/apache/dubbo/pull/5078 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] cvictory closed issue #5001: dubbo:config-center timeout配置不生效
[ issue closed by cvictory ] [ Full content available at: https://github.com/apache/dubbo/issues/5001 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] voyagertanyao commented on issue #117: dubbo2.5.3注解方式无效
@wangjunwei87 方案可行 [ Full content available at: https://github.com/apache/dubbo/issues/117 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] htynkn commented on issue #5070: [Dubbo-4331] Improve api doc #4331
What maven command should use with this change? I try `./mvnw clean javadoc:aggregate -Dmaven.javadoc.skip=false` somehow those changes can't apply to javadoc [ Full content available at: https://github.com/apache/dubbo/pull/5070 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] beiwei30 closed pull request #208: fix issue#207: common/utils/net_test.go:25 cannot pass
[ pull request closed by beiwei30 ] [ Full content available at: https://github.com/apache/dubbo-go/pull/208 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] beiwei30 opened pull request #209: fix issue #207: common/utils/net_test.go:25 cannot pass
**What this PR does**: **Which issue(s) this PR fixes**: Fixes #207 **Special notes for your reviewer**: **Does this PR introduce a user-facing change?**: ```release-note ``` [ Full content available at: https://github.com/apache/dubbo-go/pull/209 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] wongoo commented on pull request #209: fix issue #207: common/utils/net_test.go:25 cannot pass
just return here [ Full content available at: https://github.com/apache/dubbo-go/pull/209 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #209: fix issue #207: common/utils/net_test.go:25 cannot pass
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=h1) Report > Merging [#209](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=desc) > into > [develop](https://codecov.io/gh/apache/dubbo-go/commit/a977cc9975bd9041816fe87c3f26badbb732eecd?src=pr&el=desc) > will **decrease** coverage by `0.1%`. > The diff coverage is `63.63%`. [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/209/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## develop #209 +/- ## === - Coverage65.28% 65.17% -0.11% === Files 96 96 Lines 6444 6461 +17 === + Hits 4207 4211 +4 - Misses1798 1806 +8 - Partials 439 444 +5 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [common/utils/net.go](https://codecov.io/gh/apache/dubbo-go/pull/209/diff?src=pr&el=tree#diff-Y29tbW9uL3V0aWxzL25ldC5nbw==) | `63.26% <63.63%> (-8.61%)` | :arrow_down: | | [protocol/jsonrpc/server.go](https://codecov.io/gh/apache/dubbo-go/pull/209/diff?src=pr&el=tree#diff-cHJvdG9jb2wvanNvbnJwYy9zZXJ2ZXIuZ28=) | `59.79% <0%> (-1.51%)` | :arrow_down: | | [registry/etcdv3/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/209/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL3JlZ2lzdHJ5Lmdv) | `50.5% <0%> (-1.02%)` | :arrow_down: | | [config\_center/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/209/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci96b29rZWVwZXIvbGlzdGVuZXIuZ28=) | `86.95% <0%> (+4.34%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=continue). > **Legend** - [Click here to learn > more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by > [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=footer). > Last update > [a977cc9...26b50d9](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=lastupdated). > Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). [ Full content available at: https://github.com/apache/dubbo-go/pull/209 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] codecov-io commented on issue #5069: [Dubbo 5052] Fix Executes take no effect when using generic call #5052
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/5069?src=pr&el=h1) Report > Merging [#5069](https://codecov.io/gh/apache/dubbo/pull/5069?src=pr&el=desc) > into > [master](https://codecov.io/gh/apache/dubbo/commit/a3c89e2e47bcb4c690d454a7c2a6eca712b64a75?src=pr&el=desc) > will **increase** coverage by `0.05%`. > The diff coverage is `81.25%`. [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/5069/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/dubbo/pull/5069?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5069 +/- ## + Coverage 63.93% 63.98% +0.05% Complexity 451 451 Files 769 769 Lines 3321633257 +41 Branches 5221 5250 +29 + Hits 2123521279 +44 + Misses 9553 9548 -5 - Partials 2428 2430 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/5069?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...rg/apache/dubbo/rpc/filter/ExecuteLimitFilter.java](https://codecov.io/gh/apache/dubbo/pull/5069/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9maWx0ZXIvRXhlY3V0ZUxpbWl0RmlsdGVyLmphdmE=) | `81.25% <81.25%> (+12.01%)` | `0 <0> (ø)` | :arrow_down: | | [.../remoting/transport/netty4/NettyClientHandler.java](https://codecov.io/gh/apache/dubbo/pull/5069/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5Q2xpZW50SGFuZGxlci5qYXZh) | `61.4% <0%> (-7.02%)` | `0% <0%> (ø)` | | | [...dubbo/common/status/support/LoadStatusChecker.java](https://codecov.io/gh/apache/dubbo/pull/5069/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc3RhdHVzL3N1cHBvcnQvTG9hZFN0YXR1c0NoZWNrZXIuamF2YQ==) | `46.15% <0%> (-3.85%)` | `0% <0%> (ø)` | | | [...pache/dubbo/remoting/transport/AbstractServer.java](https://codecov.io/gh/apache/dubbo/pull/5069/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RTZXJ2ZXIuamF2YQ==) | `44.79% <0%> (-3.13%)` | `0% <0%> (ø)` | | | [...ting/exchange/support/header/HeartbeatHandler.java](https://codecov.io/gh/apache/dubbo/pull/5069/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L2hlYWRlci9IZWFydGJlYXRIYW5kbGVyLmphdmE=) | `83.72% <0%> (-2%)` | `0% <0%> (ø)` | | | [.../main/java/org/apache/dubbo/qos/textui/TTable.java](https://codecov.io/gh/apache/dubbo/pull/5069/diff?src=pr&el=tree#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL3RleHR1aS9UVGFibGUuamF2YQ==) | `83.79% <0%> (-0.87%)` | `0% <0%> (ø)` | | | [...rg/apache/dubbo/common/timer/HashedWheelTimer.java](https://codecov.io/gh/apache/dubbo/pull/5069/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdGltZXIvSGFzaGVkV2hlZWxUaW1lci5qYXZh) | `62.41% <0%> (-0.35%)` | `0% <0%> (ø)` | | | [...org/apache/dubbo/registry/redis/RedisRegistry.java](https://codecov.io/gh/apache/dubbo/pull/5069/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktcmVkaXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlZ2lzdHJ5L3JlZGlzL1JlZGlzUmVnaXN0cnkuamF2YQ==) | `48.15% <0%> (-0.26%)` | `31% <0%> (ø)` | | | [...n/java/org/apache/dubbo/common/utils/UrlUtils.java](https://codecov.io/gh/apache/dubbo/pull/5069/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvVXJsVXRpbHMuamF2YQ==) | `78.04% <0%> (-0.2%)` | `0% <0%> (ø)` | | | [...mon/src/main/java/org/apache/dubbo/common/URL.java](https://codecov.io/gh/apache/dubbo/pull/5069/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vVVJMLmphdmE=) | `50.22% <0%> (-0.08%)` | `0% <0%> (ø)` | | | ... and [21 more](https://codecov.io/gh/apache/dubbo/pull/5069/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/5069?src=pr&el=continue). > **Legend** - [Click here to learn > more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by > [Codecov](https://codecov.io/gh/apache/dubbo/pull/5069?src=pr&el=footer). > Last update > [a3c89e2...a7c449e](https://codecov.io/gh/apache/dubbo/pull/5069?src=pr&el=lastupdated). > Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). [ Full content available at: https://github.com/apache/dubbo/pull/5069 ]
[GitHub] [dubbo-go] codecov-io commented on issue #209: fix issue #207: common/utils/net_test.go:25 cannot pass
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=h1) Report > Merging [#209](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=desc) > into > [develop](https://codecov.io/gh/apache/dubbo-go/commit/a977cc9975bd9041816fe87c3f26badbb732eecd?src=pr&el=desc) > will **decrease** coverage by `0.1%`. > The diff coverage is `63.63%`. [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/209/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## develop #209 +/- ## === - Coverage65.28% 65.17% -0.11% === Files 96 96 Lines 6444 6461 +17 === + Hits 4207 4211 +4 - Misses1798 1806 +8 - Partials 439 444 +5 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [common/utils/net.go](https://codecov.io/gh/apache/dubbo-go/pull/209/diff?src=pr&el=tree#diff-Y29tbW9uL3V0aWxzL25ldC5nbw==) | `63.26% <63.63%> (-8.61%)` | :arrow_down: | | [protocol/jsonrpc/server.go](https://codecov.io/gh/apache/dubbo-go/pull/209/diff?src=pr&el=tree#diff-cHJvdG9jb2wvanNvbnJwYy9zZXJ2ZXIuZ28=) | `59.79% <0%> (-1.51%)` | :arrow_down: | | [registry/etcdv3/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/209/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL3JlZ2lzdHJ5Lmdv) | `50.5% <0%> (-1.02%)` | :arrow_down: | | [config\_center/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/209/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci96b29rZWVwZXIvbGlzdGVuZXIuZ28=) | `86.95% <0%> (+4.34%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=continue). > **Legend** - [Click here to learn > more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by > [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=footer). > Last update > [a977cc9...bf4734a](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=lastupdated). > Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). [ Full content available at: https://github.com/apache/dubbo-go/pull/209 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on pull request #209: fix issue #207: common/utils/net_test.go:25 cannot pass
pls delete this ref. thx. [ Full content available at: https://github.com/apache/dubbo-go/pull/209 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-website] realabbas opened issue #474: Poor Browser Leverage Caching
I just ran a Page Speed test on http://dubbo.apache.org/ and found that it lacks browser caching. ![image](https://user-images.githubusercontent.com/43527087/65164446-8a142a80-da5a-11e9-8709-09bc86bbb7f0.png) ![image](https://user-images.githubusercontent.com/43527087/65164465-939d9280-da5a-11e9-8cee-8f3cd81f5577.png) The page speed can be increased using **.htaccess file.** I can make the necessary changes and increase the page speed. Page Report: https://gtmetrix.com/reports/dubbo.apache.org/LkB3zF1a [ Full content available at: https://github.com/apache/dubbo-website/issues/474 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #209: fix issue #207: common/utils/net_test.go:25 cannot pass
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=h1) Report > Merging [#209](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=desc) > into > [develop](https://codecov.io/gh/apache/dubbo-go/commit/a977cc9975bd9041816fe87c3f26badbb732eecd?src=pr&el=desc) > will **decrease** coverage by `0.1%`. > The diff coverage is `63.63%`. [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/209/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## develop #209 +/- ## === - Coverage65.28% 65.17% -0.11% === Files 96 96 Lines 6444 6461 +17 === + Hits 4207 4211 +4 - Misses1798 1806 +8 - Partials 439 444 +5 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [common/utils/net.go](https://codecov.io/gh/apache/dubbo-go/pull/209/diff?src=pr&el=tree#diff-Y29tbW9uL3V0aWxzL25ldC5nbw==) | `63.26% <63.63%> (-8.61%)` | :arrow_down: | | [protocol/jsonrpc/server.go](https://codecov.io/gh/apache/dubbo-go/pull/209/diff?src=pr&el=tree#diff-cHJvdG9jb2wvanNvbnJwYy9zZXJ2ZXIuZ28=) | `59.79% <0%> (-1.51%)` | :arrow_down: | | [registry/etcdv3/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/209/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL3JlZ2lzdHJ5Lmdv) | `50.5% <0%> (-1.02%)` | :arrow_down: | | [config\_center/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/209/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci96b29rZWVwZXIvbGlzdGVuZXIuZ28=) | `86.95% <0%> (+4.34%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=continue). > **Legend** - [Click here to learn > more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by > [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=footer). > Last update > [a977cc9...61a0641](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=lastupdated). > Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). [ Full content available at: https://github.com/apache/dubbo-go/pull/209 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #209: fix issue #207: common/utils/net_test.go:25 cannot pass
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=h1) Report > Merging [#209](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=desc) > into > [develop](https://codecov.io/gh/apache/dubbo-go/commit/a977cc9975bd9041816fe87c3f26badbb732eecd?src=pr&el=desc) > will **decrease** coverage by `0.1%`. > The diff coverage is `63.63%`. [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/209/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## develop #209 +/- ## === - Coverage65.28% 65.17% -0.11% === Files 96 96 Lines 6444 6461 +17 === + Hits 4207 4211 +4 - Misses1798 1806 +8 - Partials 439 444 +5 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [common/utils/net.go](https://codecov.io/gh/apache/dubbo-go/pull/209/diff?src=pr&el=tree#diff-Y29tbW9uL3V0aWxzL25ldC5nbw==) | `63.26% <63.63%> (-8.61%)` | :arrow_down: | | [protocol/jsonrpc/server.go](https://codecov.io/gh/apache/dubbo-go/pull/209/diff?src=pr&el=tree#diff-cHJvdG9jb2wvanNvbnJwYy9zZXJ2ZXIuZ28=) | `59.79% <0%> (-1.51%)` | :arrow_down: | | [registry/etcdv3/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/209/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL3JlZ2lzdHJ5Lmdv) | `50.5% <0%> (-1.02%)` | :arrow_down: | | [config\_center/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/209/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci96b29rZWVwZXIvbGlzdGVuZXIuZ28=) | `86.95% <0%> (+4.34%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=continue). > **Legend** - [Click here to learn > more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by > [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=footer). > Last update > [a977cc9...42715c6](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=lastupdated). > Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). [ Full content available at: https://github.com/apache/dubbo-go/pull/209 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #209: fix issue #207: common/utils/net_test.go:25 cannot pass
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=h1) Report > Merging [#209](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=desc) > into > [develop](https://codecov.io/gh/apache/dubbo-go/commit/a977cc9975bd9041816fe87c3f26badbb732eecd?src=pr&el=desc) > will **increase** coverage by `<.01%`. > The diff coverage is `63.88%`. [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/209/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## develop #209 +/- ## === + Coverage65.28% 65.28% +<.01% === Files 96 96 Lines 6444 6462 +18 === + Hits 4207 4219 +12 - Misses1798 1801 +3 - Partials 439 442 +3 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [common/utils/net.go](https://codecov.io/gh/apache/dubbo-go/pull/209/diff?src=pr&el=tree#diff-Y29tbW9uL3V0aWxzL25ldC5nbw==) | `62% <63.88%> (-9.88%)` | :arrow_down: | | [remoting/zookeeper/client.go](https://codecov.io/gh/apache/dubbo-go/pull/209/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2NsaWVudC5nbw==) | `64.45% <0%> (+0.57%)` | :arrow_up: | | [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/209/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `47.93% <0%> (+1.03%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=continue). > **Legend** - [Click here to learn > more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by > [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=footer). > Last update > [a977cc9...42715c6](https://codecov.io/gh/apache/dubbo-go/pull/209?src=pr&el=lastupdated). > Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). [ Full content available at: https://github.com/apache/dubbo-go/pull/209 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] zhaoxilingcheng commented on issue #346: zookeeper一直出现大量连接断开
看你的业务逻辑处理是个长处理还是?一般接口3~5秒可以了 -- 原始邮件 -- 发件人: "machelcheng"; 发送时间: 2019年9月18日(星期三) 晚上10:48 收件人: "apache/dubbo"; 抄送: "得不到"<308870...@qq.com>; "Comment"; 主题: Re: [apache/dubbo] zookeeper一直出现大量连接断开 (#346) 原因是timeout设置时间太短,导致在验证时写入超时,所以要检查一下connect接口上的timeout,记得*time.Second hi,这个timeout设置为多少合适呢? — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread. [ Full content available at: https://github.com/apache/dubbo/issues/346 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] zlba111 closed issue #5068: 如何通过代码或者接口调用的方式获取dubbo服务的参数列表和参数类型?
[ issue closed by zlba111 ] [ Full content available at: https://github.com/apache/dubbo/issues/5068 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] gaoxinge opened pull request #210: skip subscribe on provider side when using consul
**What this PR does**: - skip subscribe on provider side when using consul **Which issue(s) this PR fixes**: Fixes # **Special notes for your reviewer**: - none **Does this PR introduce a user-facing change?**: ```release-note none ``` [ Full content available at: https://github.com/apache/dubbo-go/pull/210 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] wongoo commented on issue #131: fix emoji encode error
@fangyincheng @pantianying @aliiohs @AlexStocks pls review [ Full content available at: https://github.com/apache/dubbo-go-hessian2/pull/131 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks closed pull request #209: fix issue #207: common/utils/net_test.go:25 cannot pass
[ pull request closed by AlexStocks ] [ Full content available at: https://github.com/apache/dubbo-go/pull/209 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] sonymoon commented on issue #5070: [Dubbo-4331] Improve api doc #4331
> What maven command should use with this change? > I try `./mvnw clean javadoc:aggregate -Dmaven.javadoc.skip=false` somehow > those changes can't apply to javadoc `./mvnw clean javadoc:aggregate -Dmaven.javadoc.skip=false -Prelease` . `-P release` is required because the javadoc maven plugin is configured under profile `release` @htynkn [ Full content available at: https://github.com/apache/dubbo/pull/5070 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] beiwei30 closed issue #207: common/utils/net_test.go:25 cannot pass
[ issue closed by beiwei30 ] [ Full content available at: https://github.com/apache/dubbo-go/issues/207 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go]
[ Full content available at: https://github.com/apache/dubbo-go/issues/103 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] lovepoem commented on pull request #131: fix emoji encode error
Please remove author [ Full content available at: https://github.com/apache/dubbo-go-hessian2/pull/131 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-js] KeithZhang commented on issue #127: 不支持callback?
KeithZhang commented on issue #127: 不支持callback? URL: https://github.com/apache/dubbo-js/issues/127#issuecomment-532946474 现在还不支持 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] wayilau closed pull request #4746: Remove unnecessary extend.
[ pull request closed by wayilau ] [ Full content available at: https://github.com/apache/dubbo/pull/4746 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] cvictory closed pull request #5084: revert #5072 by logging error msg.
[ pull request closed by cvictory ] [ Full content available at: https://github.com/apache/dubbo/pull/5084 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] CodingSinger opened issue #5085: 修复ZookeeperRegistry在监听所有接口的情况下,接口目录丢失导致的bug
- [x] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate. - [x] I have checked the [FAQ](https://github.com/apache/dubbo/blob/master/FAQ.md) of this repository and believe that this is not a duplicate. ### Environment * Dubbo version: 2.7.4-SNAPSHOT * Operating System version: macOS10.12.6 * Java version: 1.8 ### Steps to reproduce this issue 主要是配合dubbo admin的时候,如果意外删除了接口目录,导致之后该接口的实例将不再被发现 1. 启动dubbo-admin 2. 启动dubbo生产者,此时dubbo-admin有该生产者记录 3. 关闭生产者,并且删除该生产者的接口目录 4. 重启生产者,将不会在dubbo-admin上看到相关记录 主要原因是以下回调对anyServices只有add操作,没有delete操作,导致下一次目录变化时,也不会进入if中进行订阅新增接口。 ```java listeners.putIfAbsent(listener, (parentPath, currentChilds) -> { for (String child : currentChilds) { child = URL.decode(child); if (!anyServices.contains(child)) { anyServices.add(child); subscribe(url.setPath(child).addParameters(INTERFACE_KEY, child, Constants.CHECK_KEY, String.valueOf(false)), listener); } }); ``` [ Full content available at: https://github.com/apache/dubbo/issues/5085 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] CodingSinger opened pull request #5086: fix the bug can't subscribe the interface #5085
fix the bug #5085 [ Full content available at: https://github.com/apache/dubbo/pull/5086 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] htynkn commented on issue #5071: Revert 1 2.7.2 release
please provide more detail for your PR. I'm going to close this, feel free to reopen it when you think it's ready [ Full content available at: https://github.com/apache/dubbo/pull/5071 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] htynkn closed pull request #5071: Revert 1 2.7.2 release
[ pull request closed by htynkn ] [ Full content available at: https://github.com/apache/dubbo/pull/5071 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] htynkn closed pull request #5070: [Dubbo-4331] Improve api doc #4331
[ pull request closed by htynkn ] [ Full content available at: https://github.com/apache/dubbo/pull/5070 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] htynkn commented on issue #4331: [API-DOC] Improve api doc
Script in jenkins job (https://builds.apache.org/job/Apache%20Dubbo/job/apache-dubbo-apidoc-deployment/) also updated [ Full content available at: https://github.com/apache/dubbo/issues/4331 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-website] htynkn commented on issue #474: Poor Browser Leverage Caching
because website is hosted in apache server, I'm not sure if it allow custom `.htaccess` for single project site. I'm trying to check if any other apache project website are using `.htaccess` [ Full content available at: https://github.com/apache/dubbo-website/issues/474 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-samples] maslke opened a new issue #118: consumer.xml for dubbo-samples-direct can't work.
maslke opened a new issue #118: consumer.xml for dubbo-samples-direct can't work. URL: https://github.com/apache/dubbo-samples/issues/118 in this demo, there is "url" config in . something like but it does not work. I have to add group and version part to url to make this demo work. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-js] binlaniua opened a new pull request #139: fix network break, heart beat check not work
binlaniua opened a new pull request #139: fix network break, heart beat check not work URL: https://github.com/apache/dubbo-js/pull/139 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] fangyincheng commented on pull request #131: fix emoji encode error
are `HessianTool` and `HexTool` already used? [ Full content available at: https://github.com/apache/dubbo-go-hessian2/pull/131 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org