[GitHub] daanhan commented on issue #1723: dubbo demo start failure
daanhan commented on issue #1723: dubbo demo start failure URL: https://github.com/apache/incubator-dubbo/issues/1723#issuecomment-386648564 2.6.1 demo, got same error message. My issue #1739 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] daanhan commented on issue #1739: 2.6.1的demo程序报错
daanhan commented on issue #1739: 2.6.1的demo程序报错 URL: https://github.com/apache/incubator-dubbo/issues/1739#issuecomment-386651594 It goes normal when change `http://www.w3.org/2001/XMLSchema-instance; xmlns:dubbo="http://dubbo.apache.org/schema/dubbo; xmlns="http://www.springframework.org/schema/beans; xsi:schemaLocation="http://www.springframework.org/schema/beans http://www.springframework.org/schema/beans/spring-beans-4.3.xsd http://dubbo.apache.org/schema/dubbo http://dubbo.apache.org/schema/dubbo/dubbo.xsd;> ` to `http://www.w3.org/2001/XMLSchema-instance; xmlns:dubbo="http://code.alibabatech.com/schema/dubbo; xmlns="http://www.springframework.org/schema/beans; xsi:schemaLocation="http://www.springframework.org/schema/beans http://www.springframework.org/schema/beans/spring-beans-4.3.xsd http://code.alibabatech.com/schema/dubbo http://code.alibabatech.com/schema/dubbo/dubbo.xsd;> ` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] satansk commented on issue #1738: [Dubbo-1691] Add unit tests for MulticastRegister #1691
satansk commented on issue #1738: [Dubbo-1691] Add unit tests for MulticastRegister #1691 URL: https://github.com/apache/incubator-dubbo/pull/1738#issuecomment-386638830 There's still one thing to mention, there are some typos in `MulticastRegister` which I did not correct this time: ```Java private final InetAddress mutilcastAddress; private final MulticastSocket mutilcastSocket; private final int mutilcastPort; ``` The reason that I did not correct them is they have some public method related to names, if modified, the public interface will be damaged. So what can we do here? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] daanhan opened a new issue #1739: 2.6.1的demo程序报错
daanhan opened a new issue #1739: 2.6.1的demo程序报错 URL: https://github.com/apache/incubator-dubbo/issues/1739 2.6.1版本的dubbo-demo，在eclipse中运行dubbo-demo-provider里的Provider，得到以下错误，请解决，谢谢！ 由于是dubbo新手，暂时猜测是xmlns:dubbo的路径问题。 > [04/05/18 23:49:42:042 CST] main INFO support.ClassPathXmlApplicationContext: Refreshing org.springframework.context.support.ClassPathXmlApplicationContext@4d49af10: startup date [Fri May 04 23:49:42 CST 2018]; root of context hierarchy [04/05/18 23:49:42:042 CST] main INFO xml.XmlBeanDefinitionReader: Loading XML bean definitions from class path resource [META-INF/spring/dubbo-demo-provider.xml] Exception in thread "main" org.springframework.beans.factory.parsing.BeanDefinitionParsingException: **Configuration problem: Unable to locate Spring NamespaceHandler for XML schema namespace [http://dubbo.apache.org/schema/dubbo]** Offending resource: class path resource [META-INF/spring/dubbo-demo-provider.xml] at org.springframework.beans.factory.parsing.FailFastProblemReporter.error(FailFastProblemReporter.java:70) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] codecov-io commented on issue #1738: [Dubbo-1691] Add unit tests for MulticastRegister #1691
codecov-io commented on issue #1738: [Dubbo-1691] Add unit tests for MulticastRegister #1691 URL: https://github.com/apache/incubator-dubbo/pull/1738#issuecomment-386634909 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1738?src=pr=h1) Report > Merging [#1738](https://codecov.io/gh/apache/incubator-dubbo/pull/1738?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/04c93e8b98250230c4d22423372acd1c29e2c770?src=pr=desc) will **increase** coverage by `0.64%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-dubbo/pull/1738?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1738 +/- ## + Coverage 37.92% 38.56% +0.64% - Complexity 4024 4213 +189 Files 618 628 +10 Lines 2973030861+1131 Branches 5244 5421 +177 + Hits 1127511903 +628 - Misses1661017039 +429 - Partials 1845 1919 +74 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1738?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ba/dubbo/registry/multicast/MulticastRegistry.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1738/diff?src=pr=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktbXVsdGljYXN0L3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVnaXN0cnkvbXVsdGljYXN0L011bHRpY2FzdFJlZ2lzdHJ5LmphdmE=) | `57.56% <ø> (+13.02%)` | `41 <0> (+13)` | :arrow_up: | | [...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1738/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby9DaGFubmVsV3JhcHBlZEludm9rZXIuamF2YQ==) | `37.5% <0%> (-12.5%)` | `3% <0%> (ø)` | | | [...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1738/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby90ZWxuZXQvSW52b2tlVGVsbmV0SGFuZGxlci5qYXZh) | `51.89% <0%> (-3.8%)` | `11% <0%> (-2%)` | | | [.../com/alibaba/dubbo/monitor/dubbo/DubboMonitor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1738/diff?src=pr=tree#diff-ZHViYm8tbW9uaXRvci9kdWJiby1tb25pdG9yLWRlZmF1bHQvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9tb25pdG9yL2R1YmJvL0R1YmJvTW9uaXRvci5qYXZh) | `74.76% <0%> (-1.87%)` | `7% <0%> (ø)` | | | [...main/java/com/alibaba/dubbo/common/json/Yylex.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1738/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL2pzb24vWXlsZXguamF2YQ==) | `65.56% <0%> (ø)` | `46% <0%> (?)` | | | [...java/com/alibaba/dubbo/common/json/JSONReader.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1738/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL2pzb24vSlNPTlJlYWRlci5qYXZh) | `68.42% <0%> (ø)` | `7% <0%> (?)` | | | [.../main/java/com/alibaba/dubbo/common/json/JSON.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1738/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL2pzb24vSlNPTi5qYXZh) | `52.65% <0%> (ø)` | `47% <0%> (?)` | | | [...java/com/alibaba/dubbo/common/json/JSONObject.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1738/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL2pzb24vSlNPTk9iamVjdC5qYXZh) | `17.5% <0%> (ø)` | `5% <0%> (?)` | | | [.../com/alibaba/dubbo/common/json/ParseException.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1738/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL2pzb24vUGFyc2VFeGNlcHRpb24uamF2YQ==) | `0% <0%> (ø)` | `0% <0%> (?)` | | | [...java/com/alibaba/dubbo/common/json/J2oVisitor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1738/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL2pzb24vSjJvVmlzaXRvci5qYXZh) | `42.42% <0%> (ø)` | `29% <0%> (?)` | | | ... and [8 more](https://codecov.io/gh/apache/incubator-dubbo/pull/1738/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1738?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by
[GitHub] qq282485068 opened a new issue #1742: Dubbo2..6.1报线程池已满错误
qq282485068 opened a new issue #1742: Dubbo2..6.1报线程池已满错误 URL: https://github.com/apache/incubator-dubbo/issues/1742 Caused by: com.alibaba.dubbo.remoting.RemotingException: Server side(172.17.218.167,20888) threadpool is exhausted ,detail msg:Thread pool is EXHAUSTED! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] codecov-io commented on issue #1740: some little ajust
codecov-io commented on issue #1740: some little ajust URL: https://github.com/apache/incubator-dubbo/pull/1740#issuecomment-386776663 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1740?src=pr=h1) Report > Merging [#1740](https://codecov.io/gh/apache/incubator-dubbo/pull/1740?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/04c93e8b98250230c4d22423372acd1c29e2c770?src=pr=desc) will **increase** coverage by `<.01%`. > The diff coverage is `66.66%`. [](https://codecov.io/gh/apache/incubator-dubbo/pull/1740?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1740 +/- ## + Coverage 37.92% 37.93% +<.01% - Complexity 4024 4026 +2 Files 618 618 Lines 2973029726 -4 Branches 5244 5242 -2 + Hits 1127511276 +1 + Misses1661016607 -3 + Partials 1845 1843 -2 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1740?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...rpc/cluster/configurator/AbstractConfigurator.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1740/diff?src=pr=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL2NvbmZpZ3VyYXRvci9BYnN0cmFjdENvbmZpZ3VyYXRvci5qYXZh) | `40.81% <66.66%> (+3.08%)` | `8 <0> (ø)` | :arrow_down: | | [...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1740/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby9DaGFubmVsV3JhcHBlZEludm9rZXIuamF2YQ==) | `37.5% <0%> (-12.5%)` | `3% <0%> (ø)` | | | [...om/alibaba/dubbo/rpc/filter/ActiveLimitFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1740/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvZmlsdGVyL0FjdGl2ZUxpbWl0RmlsdGVyLmphdmE=) | `77.77% <0%> (-5.56%)` | `5% <0%> (-1%)` | | | [...ba/dubbo/remoting/transport/netty/NettyServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1740/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlTZXJ2ZXIuamF2YQ==) | `70.9% <0%> (+3.63%)` | `9% <0%> (+1%)` | :arrow_up: | | [...a/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1740/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDaGFubmVsLmphdmE=) | `66.25% <0%> (+8.75%)` | `21% <0%> (+2%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1740?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1740?src=pr=footer). Last update [04c93e8...bc9049c](https://codecov.io/gh/apache/incubator-dubbo/pull/1740?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] gMan1990 opened a new issue #1743: use CuratorFrameworkFactory.DEFAULT_CONNECTION_TIMEOUT_MS
gMan1990 opened a new issue #1743: use CuratorFrameworkFactory.DEFAULT_CONNECTION_TIMEOUT_MS URL: https://github.com/apache/incubator-dubbo/issues/1743 https://github.com/apache/incubator-dubbo/blob/04c93e8b98250230c4d22423372acd1c29e2c770/dubbo-remoting/dubbo-remoting-zookeeper/src/main/java/com/alibaba/dubbo/remoting/zookeeper/curator/CuratorZookeeperClient.java#L49 rt This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] MoneyHacker opened a new pull request #1740: some little ajust
MoneyHacker opened a new pull request #1740: some little ajust URL: https://github.com/apache/incubator-dubbo/pull/1740 ## What is the purpose of the change 1.change variable name 2.change compare This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] JackCaptain1015 opened a new pull request #1750: Such logic already exists in findAnnotationName
JackCaptain1015 opened a new pull request #1750: Such logic already exists in findAnnotationName URL: https://github.com/apache/incubator-dubbo/pull/1750 ## What is the purpose of the change Such logic already exists in findAnnotationName.Remove duplicate code ## Brief changelog ExtensionLoader Remove logical repeat code ## Verifying this change 1.start DubboDemoProvider 2.start DubboDemoConsumer Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/alibaba/dubbo/tree/master/dubbo-test). - [ ] Run `mvn clean install -DskipTests` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass. - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] qiaohhgz commented on issue #127: NoClassDefFoundError
qiaohhgz commented on issue #127: NoClassDefFoundError URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/127#issuecomment-386947926 ```xml com.101tec zkclient 0.7 ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] qiaohhgz commented on issue #127: NoClassDefFoundError
qiaohhgz commented on issue #127: NoClassDefFoundError URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/127#issuecomment-386947926 com.101tec zkclient 0.7 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] diecui1202 commented on issue #934: Extension of LoadBalance (a small suggestion for loadbalance policy when there's less than 2 providers)
diecui1202 commented on issue #934: Extension of LoadBalance (a small suggestion for loadbalance policy when there's less than 2 providers) URL: https://github.com/apache/incubator-dubbo/issues/934#issuecomment-386971248 After discussing with @chickenlj , we decide to remove 140-142 lines, as the following shows: ```java private Invoker doSelect(LoadBalance loadbalance, Invocation invocation, Listinvokers, List selected) throws RpcException { if (invokers == null || invokers.isEmpty()) return null; if (invokers.size() == 1) return invokers.get(0); // If we only have two invokers, use round-robin instead. 140//if (invokers.size() == 2 && selected != null && !selected.isEmpty()) { 141//return selected.get(0) == invokers.get(0) ? invokers.get(1) : invokers.get(0); 142//} if (loadbalance == null) { loadbalance = ExtensionLoader.getExtensionLoader(LoadBalance.class).getExtension(Constants.DEFAULT_LOADBALANCE); } Invoker invoker = loadbalance.select(invokers, getUrl(), invocation); //If the `invoker` is in the `selected` or invoker is unavailable && availablecheck is true, reselect. if ((selected != null && selected.contains(invoker)) ``` Because the `selected` param is only not null when retry or in ForkingClusterInvoker. And the reselect function will finally select a avaliable invoker. So these 3 lines code seems unnecessary. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] diecui1202 commented on issue #934: Extension of LoadBalance (a small suggestion for loadbalance policy when there's less than 2 providers)
diecui1202 commented on issue #934: Extension of LoadBalance (a small suggestion for loadbalance policy when there's less than 2 providers) URL: https://github.com/apache/incubator-dubbo/issues/934#issuecomment-386971248 After discussing with @chickenlj , we decide to remove 140-142 lines, as the following shows: ```java private Invoker doSelect(LoadBalance loadbalance, Invocation invocation, Listinvokers, List selected) throws RpcException { if (invokers == null || invokers.isEmpty()) return null; if (invokers.size() == 1) return invokers.get(0); // If we only have two invokers, use round-robin instead. //if (invokers.size() == 2 && selected != null && !selected.isEmpty()) { //return selected.get(0) == invokers.get(0) ? invokers.get(1) : invokers.get(0); //} if (loadbalance == null) { loadbalance = ExtensionLoader.getExtensionLoader(LoadBalance.class).getExtension(Constants.DEFAULT_LOADBALANCE); } Invoker invoker = loadbalance.select(invokers, getUrl(), invocation); //If the `invoker` is in the `selected` or invoker is unavailable && availablecheck is true, reselect. if ((selected != null && selected.contains(invoker)) ``` Because the `selected` param is only not null when retry or in ForkingClusterInvoker. And the reselect function will finally select a avaliable invoker. So these 3 lines code seems unnecessary. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] fuyongde opened a new issue #1752: Why is the implementation-version in Dubbo 2.5.10 is 2.0.1?
fuyongde opened a new issue #1752: Why is the implementation-version in Dubbo 2.5.10 is 2.0.1? URL: https://github.com/apache/incubator-dubbo/issues/1752 Why is the implementation-version in Dubbo 2.5.10 is 2.0.1? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #26: typo fix
ralf0131 commented on issue #26: typo fix URL: https://github.com/apache/incubator-dubbo-docs/pull/26#issuecomment-386999305 Looks good to me! Thanks for the pull request! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #1727: HessianProtocolTest is unstable
ralf0131 commented on issue #1727: HessianProtocolTest is unstable URL: https://github.com/apache/incubator-dubbo/issues/1727#issuecomment-387026527 It is a duplicated issue. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] codecov-io commented on issue #1745: New threadLocal provides more performance.
codecov-io commented on issue #1745: New threadLocal provides more performance. URL: https://github.com/apache/incubator-dubbo/pull/1745#issuecomment-386791924 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr=h1) Report > Merging [#1745](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/04c93e8b98250230c4d22423372acd1c29e2c770?src=pr=desc) will **increase** coverage by `0.1%`. > The diff coverage is `46.82%`. [](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1745 +/- ## === + Coverage 37.92% 38.02% +0.1% - Complexity 4024 4055 +31 === Files 618 622 +4 Lines 2973029900+170 Branches 5244 5265 +21 === + Hits 1127511370 +95 - Misses1661016682 +72 - Partials 1845 1848 +3 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mmon/threadpool/support/fixed/FixedThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9maXhlZC9GaXhlZFRocmVhZFBvb2wuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [.../threadpool/support/limited/LimitedThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9saW1pdGVkL0xpbWl0ZWRUaHJlYWRQb29sLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...mmon/threadpool/support/eager/EagerThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9lYWdlci9FYWdlclRocmVhZFBvb2wuamF2YQ==) | `90% <ø> (ø)` | `2 <0> (ø)` | :arrow_down: | | [...on/threadpool/support/cached/CachedThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9jYWNoZWQvQ2FjaGVkVGhyZWFkUG9vbC5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...alibaba/dubbo/common/utils/NamedThreadFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3V0aWxzL05hbWVkVGhyZWFkRmFjdG9yeS5qYXZh) | `64.7% <100%> (ø)` | `3 <2> (ø)` | :arrow_down: | | [...rc/main/java/com/alibaba/dubbo/rpc/RpcContext.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvUnBjQ29udGV4dC5qYXZh) | `30.93% <100%> (ø)` | `27 <1> (ø)` | :arrow_down: | | [...common/threadlocal/NamedInternalThreadFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL05hbWVkSW50ZXJuYWxUaHJlYWRGYWN0b3J5LmphdmE=) | `20% <20%> (ø)` | `1 <1> (?)` | | | [...ibaba/dubbo/common/threadlocal/InternalThread.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL0ludGVybmFsVGhyZWFkLmphdmE=) | `26.31% <26.31%> (ø)` | `3 <3> (?)` | | | [.../dubbo/common/threadlocal/InternalThreadLocal.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL0ludGVybmFsVGhyZWFkTG9jYWwuamF2YQ==) | `35.82% <35.82%> (ø)` | `8 <8> (?)` | | | [...bbo/common/threadlocal/InternalThreadLocalMap.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL0ludGVybmFsVGhyZWFkTG9jYWxNYXAuamF2YQ==) | `63.51% <63.51%> (ø)` | `15 <15> (?)` | | | ... and [13 more](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø
[GitHub] codecov-io commented on issue #1746: [Dubbo-1744] Enable tcp no delay for netty 3 server implementation
codecov-io commented on issue #1746: [Dubbo-1744] Enable tcp no delay for netty 3 server implementation URL: https://github.com/apache/incubator-dubbo/pull/1746#issuecomment-386801732 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1746?src=pr=h1) Report > Merging [#1746](https://codecov.io/gh/apache/incubator-dubbo/pull/1746?src=pr=desc) into [2.5.x](https://codecov.io/gh/apache/incubator-dubbo/commit/b3a8f1c296248973d88f8422daf5047f9f1dede3?src=pr=desc) will **increase** coverage by `0.77%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-dubbo/pull/1746?src=pr=tree) ```diff @@Coverage Diff @@ ##2.5.x#1746 +/- ## == + Coverage 27.52% 28.29% +0.77% == Files 791 791 Lines 4075441736 +982 Branches 8166 8529 +363 == + Hits1121811811 +593 - Misses 2764927853 +204 - Partials 1887 2072 +185 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1746?src=pr=tree) | Coverage Δ | | |---|---|---| | [...ba/dubbo/remoting/transport/netty/NettyServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1746/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlTZXJ2ZXIuamF2YQ==) | `71.92% <100%> (+0.5%)` | :arrow_up: | | [...ava/com/alibaba/dubbo/rpc/filter/tps/StatItem.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1746/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvZmlsdGVyL3Rwcy9TdGF0SXRlbS5qYXZh) | `79.16% <0%> (-15.84%)` | :arrow_down: | | [...o/rpc/cluster/support/MergeableClusterInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1746/diff?src=pr=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL3N1cHBvcnQvTWVyZ2VhYmxlQ2x1c3Rlckludm9rZXIuamF2YQ==) | `35.13% <0%> (-9.58%)` | :arrow_down: | | [.../alibaba/dubbo/rpc/cluster/merger/ArrayMerger.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1746/diff?src=pr=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL21lcmdlci9BcnJheU1lcmdlci5qYXZh) | `61.9% <0%> (-6.52%)` | :arrow_down: | | [...alibaba/dubbo/remoting/transport/CodecSupport.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1746/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L0NvZGVjU3VwcG9ydC5qYXZh) | `69.23% <0%> (-4.69%)` | :arrow_down: | | [.../java/com/alibaba/dubbo/config/ConsumerConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1746/diff?src=pr=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvQ29uc3VtZXJDb25maWcuamF2YQ==) | `53.84% <0%> (-4.49%)` | :arrow_down: | | [...n/java/com/alibaba/dubbo/rpc/support/RpcUtils.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1746/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvc3VwcG9ydC9ScGNVdGlscy5qYXZh) | `20.27% <0%> (-4.32%)` | :arrow_down: | | [...rpc/protocol/dubbo/telnet/ChangeTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1746/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kZWZhdWx0L3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL3RlbG5ldC9DaGFuZ2VUZWxuZXRIYW5kbGVyLmphdmE=) | `90.9% <0%> (-4.1%)` | :arrow_down: | | [.../rpc/cluster/router/condition/ConditionRouter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1746/diff?src=pr=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL3JvdXRlci9jb25kaXRpb24vQ29uZGl0aW9uUm91dGVyLmphdmE=) | `71.11% <0%> (-3.89%)` | :arrow_down: | | [...bbo/rpc/cluster/loadbalance/RandomLoadBalance.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1746/diff?src=pr=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL2xvYWRiYWxhbmNlL1JhbmRvbUxvYWRCYWxhbmNlLmphdmE=) | `50% <0%> (-2.95%)` | :arrow_down: | | ... and [220 more](https://codecov.io/gh/apache/incubator-dubbo/pull/1746/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1746?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by
[GitHub] nobodyiam opened a new issue #1744: Client side response time is slower than actual when client side is in tcp delayed ack mode
nobodyiam opened a new issue #1744: Client side response time is slower than
actual when client side is in tcp delayed ack mode
URL: https://github.com/apache/incubator-dubbo/issues/1744
## Issue Description
Dubbo's [netty 3 server
implementation](https://github.com/apache/incubator-dubbo/blob/master/dubbo-remoting/dubbo-remoting-netty/src/main/java/com/alibaba/dubbo/remoting/transport/netty/NettyServer.java#L70)
does not enable `TCP_NODELAY` option, which causes the server side not
responding in time when client side is in delayed ack mode and the response
size is less than MSS.
However, the [netty 4 server
implementation](https://github.com/apache/incubator-dubbo/blob/master/dubbo-remoting/dubbo-remoting-netty4/src/main/java/com/alibaba/dubbo/remoting/transport/netty4/NettyServer.java#L81)
does enable this option.
```java
bootstrap.group(bossGroup, workerGroup)
.channel(NioServerSocketChannel.class)
---> .childOption(ChannelOption.TCP_NODELAY, Boolean.TRUE)
.childOption(ChannelOption.SO_REUSEADDR, Boolean.TRUE)
.childOption(ChannelOption.ALLOCATOR,
PooledByteBufAllocator.DEFAULT)
```
Considering Netty 4 enables this option by default([Enable TCP_NODELAY and
SCTP_NODELAY by
default](https://github.com/netty/netty/commit/39357f3835f971e6cc1a0e41a805fa1293e7005e)),
dubbo's [netty 3 server
implementation](https://github.com/apache/incubator-dubbo/blob/master/dubbo-remoting/dubbo-remoting-netty/src/main/java/com/alibaba/dubbo/remoting/transport/netty/NettyServer.java#L70)
should also enable this option by default.
## Solution
Simply set this option when constructing ServerBootstrap:
```java
bootstrap.setOption("child.tcpNoDelay", true);
```
## Issue Screenshots
Here is an actual example captured in our environment, with 10.5.160.181 as
the client side and 10.5.169.180 as the server side.
### Case with normal ack
The demo server side logic costs 10-11 ms, so normally, the client side
response time is around 12 ms.
The frame 9 highlighted below is a normal request, whose request id is 0x02.
The frame 11 highlighted below is the response, whose response id is 0x02.
The actual response time is 12 ms.
Also we can see from the above screenshots that both client side and server
side respond `ack` normally.
### Case with delayed ack
Now let's take a look when client side is in delayed ack mode.
From the screen shots below, there is no single `ack` packets, which means
it's in delayed ack mode - `ack` is returned with a data packet.
The frame 239 highlighted below is a request, whose request id is 0x7f.
We can see the 240 packet responded immediately when 239 is sent to server,
considering the server logic costs 10-11 ms, this packet is not the response.
As we can see, the frame 240's response id is 0x7e, which is the response to
the previous request.
Then frame 241 is sent, whose request id is 0x80.
Until then, the response to request 0x7f is returned (frame 242)
Request 0x7f was sent in 14:37:53.267, so we know that the response was
ready around 14:37:53.277 in the server side. However, since the server side
does not enable `TCP_NODELAY`, so according to Nagel algorithm, the response
cannot be sent until an `ack` is received or a timeout occurrs(40ms).
So the response is hold in server side and is sent when another request is
sent from client side, which was 14:37:53.292730.
In this case, the client side response time (25ms) is much slower than
actual (12ms).
Even worse, in this situation, the response time is determined by the
interval in which the client side sends the request.
We've done some experiments and the results shows in this situation, if
client side sends requests in qps 50, then the client side response time is
20ms, because the client side request sending interval is 20ms (1000/50). If
client side qps is 40, the the response time is 25ms. If client side qps is 30,
then the response time is 33ms.
The response time increases when the qps decreases, until the qps is 25.
Because when the interval is larger
[GitHub] carryxyh opened a new pull request #1745: New threadLocal provides more performance.
carryxyh opened a new pull request #1745: New threadLocal provides more performance. URL: https://github.com/apache/incubator-dubbo/pull/1745 Faster ThreadLocal impl in internal use * Used in RpcContext`s LOCAL field. * Compatible traditional ThreadLocal. * Faster get than the traditional ThreadLocal. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] nobodyiam opened a new pull request #1746: [Dubbo-1744]enable tcp no delay for netty 3 server implementation
nobodyiam opened a new pull request #1746: [Dubbo-1744]enable tcp no delay for netty 3 server implementation URL: https://github.com/apache/incubator-dubbo/pull/1746 ## What is the purpose of the change Fix #1744 ## Brief changelog Enable `TCP_NODELAY` for netty 3 server implementation ## Verifying this change The accepted channel's socket in server side returns true when calling java.net.Socket#getTcpNoDelay Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [x] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/alibaba/dubbo/tree/master/dubbo-test). - [x] Run `mvn clean install -DskipTests` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass. - [x] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] EdwardLee03 commented on issue #1393: Please subscribe the Apache incubator mailing list
EdwardLee03 commented on issue #1393: Please subscribe the Apache incubator mailing list URL: https://github.com/apache/incubator-dubbo/issues/1393#issuecomment-387052884 subscribed This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] qinnnyul opened a new pull request #1736: Add unit tests for dubbo-filter-validation module
qinnnyul opened a new pull request #1736: Add unit tests for dubbo-filter-validation module URL: https://github.com/apache/incubator-dubbo/pull/1736 ## What is the purpose of the change Add unit tests for dubbo-filter-validation module, in order to increase the overall test coverage. more details, please refer to #1687 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] XuKer commented on issue #1012: Wanted: who's using dubbo
XuKer commented on issue #1012: Wanted: who's using dubbo URL: https://github.com/apache/incubator-dubbo/issues/1012#issuecomment-386552685 组织：个人 地点：中国北京 联系方式：[ wxk1...@gmail.com](url) 场景：分布式服务 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] XuKer commented on issue #1012: Wanted: who's using dubbo
XuKer commented on issue #1012: Wanted: who's using dubbo URL: https://github.com/apache/incubator-dubbo/issues/1012#issuecomment-386552685 组织：个人 地点：中国北京 联系方式：[ wxk1...@gmail.com](url) 场景：分布式服务 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] XuKer commented on issue #1012: Wanted: who's using dubbo
XuKer commented on issue #1012: Wanted: who's using dubbo URL: https://github.com/apache/incubator-dubbo/issues/1012#issuecomment-386552998 组织：个人 地点：中国北京 联系方式： wxk1...@gmail.com 场景：分布式服务 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] feelwing1314 commented on issue #1735: 采用zookeeper集群配置，把所有zookeeper都停掉以后为什么还能调用服务
feelwing1314 commented on issue #1735: 采用zookeeper集群配置，把所有zookeeper都停掉以后为什么还能调用服务 URL: https://github.com/apache/incubator-dubbo/issues/1735#issuecomment-386547934 dubbo的消费端Consumer会local cache 服务提供端Provider的信息，启动Provider和Consumer后，如果服务没有变更；完全可以正常调用，没有任何影响。Provider和Consumer启动后，zk的作用是当有服务变更时通知订阅者更新信息 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] beiwei30 closed issue #1666: Does need invoke startClose() in this function
beiwei30 closed issue #1666: Does need invoke startClose() in this function URL: https://github.com/apache/incubator-dubbo/issues/1666 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] chickenlj closed issue #906: JSON.json(Locale) throw StackOverflowError
chickenlj closed issue #906: JSON.json(Locale) throw StackOverflowError URL: https://github.com/apache/incubator-dubbo/issues/906 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] beiwei30 commented on a change in pull request #1738: [Dubbo-1691] Add unit tests for MulticastRegister #1691
beiwei30 commented on a change in pull request #1738: [Dubbo-1691] Add unit
tests for MulticastRegister #1691
URL: https://github.com/apache/incubator-dubbo/pull/1738#discussion_r187861452
##
File path:
dubbo-registry/dubbo-registry-multicast/src/test/java/com/alibaba/dubbo/registry/multicast/MulticastRegistryTest.java
##
@@ -27,92 +27,165 @@
import java.util.List;
import java.util.Map;
import java.util.Set;
-import java.util.concurrent.atomic.AtomicReference;
import static org.hamcrest.CoreMatchers.is;
-import static org.junit.Assert.assertThat;
-import static org.junit.Assert.assertTrue;
-import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.*;
public class MulticastRegistryTest {
-private String service = "com.alibaba.dubbo.test.injvmServie";
+private String service = "com.apache.dubbo.test.injvmServie";
Review comment:
why change this from alibaba to apache?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] carryxyh commented on issue #1745: New threadLocal provides more performance.
carryxyh commented on issue #1745: New threadLocal provides more performance. URL: https://github.com/apache/incubator-dubbo/pull/1745#issuecomment-388745592 @beiwei30 done. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] codecov-io commented on issue #1745: New threadLocal provides more performance.
codecov-io commented on issue #1745: New threadLocal provides more performance. URL: https://github.com/apache/incubator-dubbo/pull/1745#issuecomment-386791924 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr=h1) Report > Merging [#1745](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/ddc1ea4149d3e6879be21a55981f4ccb5ad14920?src=pr=desc) will **increase** coverage by `0.02%`. > The diff coverage is `46.82%`. [](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #1745 +/- ## === + Coverage 39.67% 39.7% +0.02% - Complexity 42854309 +24 === Files 622 626 +4 Lines 29907 30077 +170 Branches 52975318 +21 === + Hits 11867 11943 +76 - Misses16138 16225 +87 - Partials 19021909 +7 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...on/threadpool/support/cached/CachedThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9jYWNoZWQvQ2FjaGVkVGhyZWFkUG9vbC5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...mmon/threadpool/support/eager/EagerThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9lYWdlci9FYWdlclRocmVhZFBvb2wuamF2YQ==) | `90% <ø> (ø)` | `2 <0> (ø)` | :arrow_down: | | [.../threadpool/support/limited/LimitedThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9saW1pdGVkL0xpbWl0ZWRUaHJlYWRQb29sLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...mmon/threadpool/support/fixed/FixedThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9maXhlZC9GaXhlZFRocmVhZFBvb2wuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...rc/main/java/com/alibaba/dubbo/rpc/RpcContext.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvUnBjQ29udGV4dC5qYXZh) | `30.93% <100%> (ø)` | `27 <1> (ø)` | :arrow_down: | | [...alibaba/dubbo/common/utils/NamedThreadFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3V0aWxzL05hbWVkVGhyZWFkRmFjdG9yeS5qYXZh) | `64.7% <100%> (ø)` | `3 <2> (ø)` | :arrow_down: | | [...common/threadlocal/NamedInternalThreadFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL05hbWVkSW50ZXJuYWxUaHJlYWRGYWN0b3J5LmphdmE=) | `20% <20%> (ø)` | `1 <1> (?)` | | | [...ibaba/dubbo/common/threadlocal/InternalThread.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL0ludGVybmFsVGhyZWFkLmphdmE=) | `26.31% <26.31%> (ø)` | `3 <3> (?)` | | | [.../dubbo/common/threadlocal/InternalThreadLocal.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL0ludGVybmFsVGhyZWFkTG9jYWwuamF2YQ==) | `35.82% <35.82%> (ø)` | `8 <8> (?)` | | | [...bbo/common/threadlocal/InternalThreadLocalMap.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL0ludGVybmFsVGhyZWFkTG9jYWxNYXAuamF2YQ==) | `63.51% <63.51%> (ø)` | `15 <15> (?)` | | | ... and [10 more](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø
[GitHub] codecov-io commented on issue #1745: New threadLocal provides more performance.
codecov-io commented on issue #1745: New threadLocal provides more performance. URL: https://github.com/apache/incubator-dubbo/pull/1745#issuecomment-386791924 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr=h1) Report > Merging [#1745](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/ddc1ea4149d3e6879be21a55981f4ccb5ad14920?src=pr=desc) will **increase** coverage by `0.02%`. > The diff coverage is `46.82%`. [](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #1745 +/- ## === + Coverage 39.67% 39.7% +0.02% - Complexity 42854309 +24 === Files 622 626 +4 Lines 29907 30077 +170 Branches 52975318 +21 === + Hits 11867 11943 +76 - Misses16138 16225 +87 - Partials 19021909 +7 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...on/threadpool/support/cached/CachedThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9jYWNoZWQvQ2FjaGVkVGhyZWFkUG9vbC5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...mmon/threadpool/support/eager/EagerThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9lYWdlci9FYWdlclRocmVhZFBvb2wuamF2YQ==) | `90% <ø> (ø)` | `2 <0> (ø)` | :arrow_down: | | [.../threadpool/support/limited/LimitedThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9saW1pdGVkL0xpbWl0ZWRUaHJlYWRQb29sLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...mmon/threadpool/support/fixed/FixedThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9maXhlZC9GaXhlZFRocmVhZFBvb2wuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...rc/main/java/com/alibaba/dubbo/rpc/RpcContext.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvUnBjQ29udGV4dC5qYXZh) | `30.93% <100%> (ø)` | `27 <1> (ø)` | :arrow_down: | | [...alibaba/dubbo/common/utils/NamedThreadFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3V0aWxzL05hbWVkVGhyZWFkRmFjdG9yeS5qYXZh) | `64.7% <100%> (ø)` | `3 <2> (ø)` | :arrow_down: | | [...common/threadlocal/NamedInternalThreadFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL05hbWVkSW50ZXJuYWxUaHJlYWRGYWN0b3J5LmphdmE=) | `20% <20%> (ø)` | `1 <1> (?)` | | | [...ibaba/dubbo/common/threadlocal/InternalThread.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL0ludGVybmFsVGhyZWFkLmphdmE=) | `26.31% <26.31%> (ø)` | `3 <3> (?)` | | | [.../dubbo/common/threadlocal/InternalThreadLocal.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL0ludGVybmFsVGhyZWFkTG9jYWwuamF2YQ==) | `35.82% <35.82%> (ø)` | `8 <8> (?)` | | | [...bbo/common/threadlocal/InternalThreadLocalMap.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL0ludGVybmFsVGhyZWFkTG9jYWxNYXAuamF2YQ==) | `63.51% <63.51%> (ø)` | `15 <15> (?)` | | | ... and [10 more](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø
[GitHub] codecov-io commented on issue #1745: New threadLocal provides more performance.
codecov-io commented on issue #1745: New threadLocal provides more performance. URL: https://github.com/apache/incubator-dubbo/pull/1745#issuecomment-386791924 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr=h1) Report > Merging [#1745](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/ddc1ea4149d3e6879be21a55981f4ccb5ad14920?src=pr=desc) will **increase** coverage by `0.02%`. > The diff coverage is `46.82%`. [](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #1745 +/- ## === + Coverage 39.67% 39.7% +0.02% - Complexity 42854309 +24 === Files 622 626 +4 Lines 29907 30077 +170 Branches 52975318 +21 === + Hits 11867 11943 +76 - Misses16138 16225 +87 - Partials 19021909 +7 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...on/threadpool/support/cached/CachedThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9jYWNoZWQvQ2FjaGVkVGhyZWFkUG9vbC5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...mmon/threadpool/support/eager/EagerThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9lYWdlci9FYWdlclRocmVhZFBvb2wuamF2YQ==) | `90% <ø> (ø)` | `2 <0> (ø)` | :arrow_down: | | [.../threadpool/support/limited/LimitedThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9saW1pdGVkL0xpbWl0ZWRUaHJlYWRQb29sLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...mmon/threadpool/support/fixed/FixedThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9maXhlZC9GaXhlZFRocmVhZFBvb2wuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...alibaba/dubbo/common/utils/NamedThreadFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3V0aWxzL05hbWVkVGhyZWFkRmFjdG9yeS5qYXZh) | `64.7% <100%> (ø)` | `3 <2> (ø)` | :arrow_down: | | [...rc/main/java/com/alibaba/dubbo/rpc/RpcContext.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvUnBjQ29udGV4dC5qYXZh) | `30.93% <100%> (ø)` | `27 <1> (ø)` | :arrow_down: | | [...common/threadlocal/NamedInternalThreadFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL05hbWVkSW50ZXJuYWxUaHJlYWRGYWN0b3J5LmphdmE=) | `20% <20%> (ø)` | `1 <1> (?)` | | | [...ibaba/dubbo/common/threadlocal/InternalThread.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL0ludGVybmFsVGhyZWFkLmphdmE=) | `26.31% <26.31%> (ø)` | `3 <3> (?)` | | | [.../dubbo/common/threadlocal/InternalThreadLocal.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL0ludGVybmFsVGhyZWFkTG9jYWwuamF2YQ==) | `35.82% <35.82%> (ø)` | `8 <8> (?)` | | | [...bbo/common/threadlocal/InternalThreadLocalMap.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL0ludGVybmFsVGhyZWFkTG9jYWxNYXAuamF2YQ==) | `63.51% <63.51%> (ø)` | `15 <15> (?)` | | | ... and [10 more](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø
[GitHub] beiwei30 opened a new pull request #1794: clean up work for config-api unit test
beiwei30 opened a new pull request #1794: clean up work for config-api unit test URL: https://github.com/apache/incubator-dubbo/pull/1794 ## What is the purpose of the change cleanup work to finalize unit test in config-api module, including removing useless classes, move class into correct package ## Brief changelog ## Verifying this change Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/alibaba/dubbo/tree/master/dubbo-test). - [ ] Run `mvn clean install -DskipTests` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass. - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] beiwei30 closed issue #1254: Upgrade tomcat version to 8.5.x
beiwei30 closed issue #1254: Upgrade tomcat version to 8.5.x URL: https://github.com/apache/incubator-dubbo/issues/1254 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] suclogger commented on issue #135: 刷星星哦
suclogger commented on issue #135: 刷星星哦 URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/135#issuecomment-388706200 @XUZHOUWANG 推广技术，邀请大家关注和共同推动，这才是社区化的出发点和力量根源。 你完全不了解小马哥的工作和这个项目的意义就开一个无关的issue，你确定你了解这个社区？ 有幸观摩了你的博客，感觉你跟我一直以来了解到的有赞的技术氛围格格不入。 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] 0oo closed pull request #1497: when using simpleregistry, provider throwed a exception
0oo closed pull request #1497: when using simpleregistry, provider throwed a
exception
URL: https://github.com/apache/incubator-dubbo/pull/1497
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/dubbo-simple/dubbo-registry-simple/src/main/java/com/alibaba/dubbo/registry/simple/SimpleRegistryService.java
b/dubbo-simple/dubbo-registry-simple/src/main/java/com/alibaba/dubbo/registry/simple/SimpleRegistryService.java
index f75415220a..7dfdec788b 100644
---
a/dubbo-simple/dubbo-registry-simple/src/main/java/com/alibaba/dubbo/registry/simple/SimpleRegistryService.java
+++
b/dubbo-simple/dubbo-registry-simple/src/main/java/com/alibaba/dubbo/registry/simple/SimpleRegistryService.java
@@ -57,7 +57,7 @@ public boolean isAvailable() {
List urls = new ArrayList();
for (URL u : getRegistered()) {
if (UrlUtils.isMatch(url, u)) {
-urls.add(u);
+ urls.add(u.clearParameters());
}
}
return urls;
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] blinkingso commented on issue #136: how to config provider ?
blinkingso commented on issue #136: how to config provider ?
URL:
https://github.com/apache/incubator-dubbo-spring-boot-project/issues/136#issuecomment-388757758
dubbo:
application:
name: ms-member-web
registry:
address: redis://${spring.redis.host}:${spring.redis.port}
username: root
password: ${spring.redis.password}
check: true
dynamic: true
server: true
protocol:
name: dubbo
port: 20880
consumer:
check: false
provider:
dynamic: true
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] mercyblitz commented on issue #135: 刷星星哦
mercyblitz commented on issue #135: 刷星星哦 URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/135#issuecomment-388716180 @XUZHOUWANG @suclogger 两位都是非常关心社区发展的小伙伴，实际上，我想请大家帮忙的原因也是提升社区的活跃度。里面并没有刷单式的利益输送，小伙伴之所以支持主要是因为大家相互帮助，我也在微信群里面答疑解惑，当然这也是交流的一部分。我希望大家共同关注在本工程的发展上，多提出建设性意见和建议，实现社区成长。不希望此等话题不断以及口舌之争，后续我将本 issue 关闭。 **如果本人之前的行为对您的生活有打扰，我在此想您道歉。** This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] mercyblitz commented on issue #135: 刷星星哦
mercyblitz commented on issue #135: 刷星星哦 URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/135#issuecomment-388716180 @XUZHOUWANG @suclogger 两位都是非常关心社区发展的小伙伴，实际上，我想请大家帮忙的原因也是提升社区的活跃度。里面并没有刷单式的利益输送，小伙伴之所以支持主要是因为大家相互帮助，我也在微信群里面答疑解惑，当然这也是交流的一部分。我希望大家共同关注在本工程的发展上，多提出建设性意见和建议，实现社区成长。不希望此等话题不断以及口舌之争，后续我将本 issue 关闭。 *如果本人之前的行为对您的生活有打扰，我在此想您道歉。* This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] mercyblitz commented on issue #134: 一定要在service里面加这些东西? 不能设置默认值吗。。。
mercyblitz commented on issue #134: 一定要在service里面加这些东西? 不能设置默认值吗。。。 URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/134#issuecomment-388716553 @piglingcn It's optional attributes of `@Service` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #28: change invalid link address
ralf0131 commented on issue #28: change invalid link address URL: https://github.com/apache/incubator-dubbo-docs/pull/28#issuecomment-388752353 Thanks for the pull request, it looks good to me! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 closed pull request #28: change invalid link address
ralf0131 closed pull request #28: change invalid link address URL: https://github.com/apache/incubator-dubbo-docs/pull/28 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/dubbo-admin-book-en/install/admin-console.md b/dubbo-admin-book-en/install/admin-console.md index 516a4f6..7f2a743 100644 --- a/dubbo-admin-book-en/install/admin-console.md +++ b/dubbo-admin-book-en/install/admin-console.md @@ -5,7 +5,7 @@ Include: route rule, dynamic configuration, service downgrade, access control, w Install: ```sh -wget http://apache.etoak.com/tomcat/tomcat-6/v6.0.35/bin/apache-tomcat-6.0.35.tar.gz +wget https://archive.apache.org/dist/tomcat/tomcat-6/v6.0.35/bin/apache-tomcat-6.0.35.tar.gz tar zxvf apache-tomcat-6.0.35.tar.gz cd apache-tomcat-6.0.35 rm -rf webapps/ROOT diff --git a/dubbo-admin-book-en/install/redis.md b/dubbo-admin-book-en/install/redis.md index ce48780..2a1f4c7 100644 --- a/dubbo-admin-book-en/install/redis.md +++ b/dubbo-admin-book-en/install/redis.md @@ -11,7 +11,7 @@ Redis configuration center cluster [^2] write multiple server in client side and Install: ```sh -wget http://redis.googlecode.com/files/redis-2.4.8.tar.gz +wget https://storage.googleapis.com/google-code-archive-downloads/v2/code.google.com/redis/redis-2.4.8.tar.gz tar xzf redis-2.4.8.tar.gz cd redis-2.4.8 make diff --git a/dubbo-admin-book/install/admin-console.md b/dubbo-admin-book/install/admin-console.md index d93f0f7..bdaf303 100644 --- a/dubbo-admin-book/install/admin-console.md +++ b/dubbo-admin-book/install/admin-console.md @@ -5,7 +5,7 @@ 安装: ```sh -wget http://apache.etoak.com/tomcat/tomcat-6/v6.0.35/bin/apache-tomcat-6.0.35.tar.gz +wget https://archive.apache.org/dist/tomcat/tomcat-6/v6.0.35/bin/apache-tomcat-6.0.35.tar.gz tar zxvf apache-tomcat-6.0.35.tar.gz cd apache-tomcat-6.0.35 rm -rf webapps/ROOT diff --git a/dubbo-admin-book/install/redis.md b/dubbo-admin-book/install/redis.md index b7b518c..fe46707 100644 --- a/dubbo-admin-book/install/redis.md +++ b/dubbo-admin-book/install/redis.md @@ -11,7 +11,7 @@ Redis 注册中心集群 [^2] 采用在客户端同时写入多个服务器， 安装: ```sh -wget http://redis.googlecode.com/files/redis-2.4.8.tar.gz +wget https://storage.googleapis.com/google-code-archive-downloads/v2/code.google.com/redis/redis-2.4.8.tar.gz tar xzf redis-2.4.8.tar.gz cd redis-2.4.8 make diff --git a/dubbo-user-book-en/benchmark-tool.md b/dubbo-user-book-en/benchmark-tool.md index e74d781..b64112e 100644 --- a/dubbo-user-book-en/benchmark-tool.md +++ b/dubbo-user-book-en/benchmark-tool.md @@ -1,6 +1,8 @@ # Beanchmark testing tool installer -Download the [benchmark installer](http://code.alibabatech.com/wiki/download/attachments/7669075/dubbo.benchmark-2.0.14.tar.gz)，and unzip it +* download： git clone https://github.com/apache/incubator-dubbo.git +* compile benchmark: cd incubator-dubbo/dubbo-test/dubbo-test-benchmark; mvn clean install +* uncompress benchmark： incubator-dubbo/dubbo-test/dubbo-test-benchmark/target/dubbo-test-benchmark-2.6.2-SNAPSHOT.tar.gz Read ReadMe.txt (the contents are as follows, in the compressed package.) diff --git a/dubbo-user-book-en/configuration/xml.md b/dubbo-user-book-en/configuration/xml.md index 99e5973..6789ffc 100644 --- a/dubbo-user-book-en/configuration/xml.md +++ b/dubbo-user-book-en/configuration/xml.md @@ -9,8 +9,8 @@ About the XML configuration items, see：[XML References](../references/xml/intr http://www.springframework.org/schema/beans; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; -xmlns:dubbo="http://code.alibabatech.com/schema/dubbo; -xsi:schemaLocation="http://www.springframework.org/schema/beans http://www.springframework.org/schema/beans/spring-beans.xsd http://code.alibabatech.com/schema/dubbo http://code.alibabatech.com/schema/dubbo/dubbo.xsd;> +xmlns:dubbo="http://dubbo.apache.org/schema/dubbo; +xsi:schemaLocation="http://www.springframework.org/schema/beans http://www.springframework.org/schema/beans/spring-beans-4.3.xsd http://dubbo.apache.org/schema/dubbo http://dubbo.apache.org/schema/dubbo/dubbo.xsd;> @@ -32,9 +32,9 @@ Or: ``` xml http://www.springframework.org/schema/beans; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; -xmlns:dubbo="http://code.alibabatech.com/schema/dubbo; +xmlns:dubbo="http://dubbo.apache.org/schema/dubbo; xmlns:p="http://www.springframework.org/schema/p; -xsi:schemaLocation="http://www.springframework.org/schema/beans http://www.springframework.org/schema/beans/spring-beans.xsd http://code.alibabatech.com/schema/dubbo http://code.alibabatech.com/schema/dubbo/dubbo.xsd;> +xsi:schemaLocation="http://www.springframework.org/schema/beans
[GitHub] ralf0131 closed issue #9: Update the legacy links in docs
ralf0131 closed issue #9: Update the legacy links in docs URL: https://github.com/apache/incubator-dubbo-docs/issues/9 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #9: Update the legacy links in docs
ralf0131 commented on issue #9: Update the legacy links in docs URL: https://github.com/apache/incubator-dubbo-docs/issues/9#issuecomment-388752789 This issue has been fixed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] beiwei30 opened a new pull request #1795: clean up: finish unit test for config-api
beiwei30 opened a new pull request #1795: clean up: finish unit test for config-api URL: https://github.com/apache/incubator-dubbo/pull/1795 ## What is the purpose of the change finish unit test for config-api module, remove useless classes and move class into right packages. ## Brief changelog ## Verifying this change Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/alibaba/dubbo/tree/master/dubbo-test). - [ ] Run `mvn clean install -DskipTests` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass. - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] beiwei30 closed pull request #1741: add test for monitor module
beiwei30 closed pull request #1741: add test for monitor module
URL: https://github.com/apache/incubator-dubbo/pull/1741
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/dubbo-monitor/dubbo-monitor-api/src/test/java/com/alibaba/dubbo/monitor/support/AbstractMonitorFactoryTest.java
b/dubbo-monitor/dubbo-monitor-api/src/test/java/com/alibaba/dubbo/monitor/support/AbstractMonitorFactoryTest.java
index cc19f5ae86..64847af251 100644
---
a/dubbo-monitor/dubbo-monitor-api/src/test/java/com/alibaba/dubbo/monitor/support/AbstractMonitorFactoryTest.java
+++
b/dubbo-monitor/dubbo-monitor-api/src/test/java/com/alibaba/dubbo/monitor/support/AbstractMonitorFactoryTest.java
@@ -21,7 +21,7 @@
import com.alibaba.dubbo.monitor.Monitor;
import com.alibaba.dubbo.monitor.MonitorFactory;
-import junit.framework.Assert;
+import org.junit.Assert;
import org.junit.Test;
import java.util.List;
diff --git
a/dubbo-monitor/dubbo-monitor-api/src/test/java/com/alibaba/dubbo/monitor/support/MonitorFilterTest.java
b/dubbo-monitor/dubbo-monitor-api/src/test/java/com/alibaba/dubbo/monitor/support/MonitorFilterTest.java
index 5b8a303a48..3450eb438e 100644
---
a/dubbo-monitor/dubbo-monitor-api/src/test/java/com/alibaba/dubbo/monitor/support/MonitorFilterTest.java
+++
b/dubbo-monitor/dubbo-monitor-api/src/test/java/com/alibaba/dubbo/monitor/support/MonitorFilterTest.java
@@ -28,15 +28,21 @@
import com.alibaba.dubbo.rpc.RpcContext;
import com.alibaba.dubbo.rpc.RpcException;
import com.alibaba.dubbo.rpc.RpcInvocation;
-
-import junit.framework.Assert;
+import org.junit.Assert;
import org.junit.Test;
+import org.mockito.Mockito;
import java.io.UnsupportedEncodingException;
import java.net.URLEncoder;
import java.util.Arrays;
import java.util.List;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.BDDMockito.given;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.never;
+import static org.mockito.Mockito.verify;
+
/**
* MonitorFilterTest
*/
@@ -125,6 +131,20 @@ public void testFilter() throws Exception {
Assert.assertEquals(invocation, lastInvocation);
}
+@Test
+public void testSkipMonitorIfNotHasKey() {
+MonitorFilter monitorFilter = new MonitorFilter();
+MonitorFactory mockMonitorFactory = mock(MonitorFactory.class);
+monitorFilter.setMonitorFactory(mockMonitorFactory);
+Invocation invocation = new RpcInvocation("aaa", new Class[0], new
Object[0]);
+Invoker invoker = mock(Invoker.class);
+given(invoker.getUrl()).willReturn(URL.valueOf("dubbo://" +
NetUtils.getLocalHost() + ":20880?" + Constants.APPLICATION_KEY + "=abc&" +
Constants.SIDE_KEY + "=" + Constants.CONSUMER_SIDE));
+
+monitorFilter.invoke(invoker, invocation);
+
+verify(mockMonitorFactory, never()).getMonitor(any(URL.class));
+}
+
@Test
public void testGenericFilter() throws Exception {
MonitorFilter monitorFilter = new MonitorFilter();
@@ -147,4 +167,17 @@ public void testGenericFilter() throws Exception {
Assert.assertEquals(invocation, lastInvocation);
}
+@Test
+public void testSafeFailForMonitorCollectFail() {
+MonitorFilter monitorFilter = new MonitorFilter();
+MonitorFactory mockMonitorFactory = mock(MonitorFactory.class);
+Monitor mockMonitor = mock(Monitor.class);
+Mockito.doThrow(new
RuntimeException()).when(mockMonitor).collect(any(URL.class));
+
+monitorFilter.setMonitorFactory(mockMonitorFactory);
+
given(mockMonitorFactory.getMonitor(any(URL.class))).willReturn(mockMonitor);
+Invocation invocation = new RpcInvocation("aaa", new Class[0], new
Object[0]);
+
+monitorFilter.invoke(serviceInvoker, invocation);
+}
}
diff --git
a/dubbo-monitor/dubbo-monitor-default/src/test/java/com/alibaba/dubbo/monitor/dubbo/DubboMonitorFactoryTest.java
b/dubbo-monitor/dubbo-monitor-default/src/test/java/com/alibaba/dubbo/monitor/dubbo/DubboMonitorFactoryTest.java
new file mode 100644
index 00..759a0d97eb
--- /dev/null
+++
b/dubbo-monitor/dubbo-monitor-default/src/test/java/com/alibaba/dubbo/monitor/dubbo/DubboMonitorFactoryTest.java
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by
[GitHub] beiwei30 closed issue #1688: Enhance the test coverage part-9 :dubbo-monitor module
beiwei30 closed issue #1688: Enhance the test coverage part-9 :dubbo-monitor module URL: https://github.com/apache/incubator-dubbo/issues/1688 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] XUZHOUWANG commented on issue #135: 刷星星哦
XUZHOUWANG commented on issue #135: 刷星星哦 URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/135#issuecomment-388705116 这跟在淘宝刷单有什么区别？ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] codecov-io commented on issue #1792: zk Unsubscribe issue
codecov-io commented on issue #1792: zk Unsubscribe issue URL: https://github.com/apache/incubator-dubbo/pull/1792#issuecomment-388708105 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1792?src=pr=h1) Report > Merging [#1792](https://codecov.io/gh/apache/incubator-dubbo/pull/1792?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/203078981bb23517703e7bbb60925b8542bc8983?src=pr=desc) will **increase** coverage by `0.08%`. > The diff coverage is `33.33%`. [](https://codecov.io/gh/apache/incubator-dubbo/pull/1792?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1792 +/- ## + Coverage 39.24% 39.32% +0.08% - Complexity 4197 4216 +19 Files 618 618 Lines 2974229747 +5 Branches 5257 5259 +2 + Hits 1167211699 +27 + Misses1621116185 -26 - Partials 1859 1863 +4 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1792?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ba/dubbo/registry/zookeeper/ZookeeperRegistry.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1792/diff?src=pr=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktem9va2VlcGVyL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVnaXN0cnkvem9va2VlcGVyL1pvb2tlZXBlclJlZ2lzdHJ5LmphdmE=) | `65.98% <33.33%> (-1.62%)` | `31 <0> (+1)` | | | [...libaba/com/caucho/hessian/util/IdentityIntMap.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1792/diff?src=pr=tree#diff-aGVzc2lhbi1saXRlL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvY29tL2NhdWNoby9oZXNzaWFuL3V0aWwvSWRlbnRpdHlJbnRNYXAuamF2YQ==) | `25% <0%> (-5.96%)` | `5% <0%> (-2%)` | | | [.../com/alibaba/dubbo/monitor/dubbo/DubboMonitor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1792/diff?src=pr=tree#diff-ZHViYm8tbW9uaXRvci9kdWJiby1tb25pdG9yLWRlZmF1bHQvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9tb25pdG9yL2R1YmJvL0R1YmJvTW9uaXRvci5qYXZh) | `74.76% <0%> (-1.87%)` | `7% <0%> (ø)` | | | [.../alibaba/dubbo/config/AbstractInterfaceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1792/diff?src=pr=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvQWJzdHJhY3RJbnRlcmZhY2VDb25maWcuamF2YQ==) | `81.53% <0%> (+0.45%)` | `81% <0%> (+1%)` | :arrow_up: | | [...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1792/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby90ZWxuZXQvSW52b2tlVGVsbmV0SGFuZGxlci5qYXZh) | `55.69% <0%> (+3.79%)` | `13% <0%> (+2%)` | :arrow_up: | | [...n/java/com/alibaba/dubbo/config/ServiceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1792/diff?src=pr=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvU2VydmljZUNvbmZpZy5qYXZh) | `46.6% <0%> (+6.79%)` | `59% <0%> (+16%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1792?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1792?src=pr=footer). Last update [2030789...a5d3846](https://codecov.io/gh/apache/incubator-dubbo/pull/1792?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] beiwei30 closed pull request #1776: Extracting public code to the parent class
beiwei30 closed pull request #1776: Extracting public code to the parent class
URL: https://github.com/apache/incubator-dubbo/pull/1776
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/dubbo-remoting/dubbo-remoting-api/src/main/java/com/alibaba/dubbo/remoting/transport/dispatcher/WrappedChannelHandler.java
b/dubbo-remoting/dubbo-remoting-api/src/main/java/com/alibaba/dubbo/remoting/transport/dispatcher/WrappedChannelHandler.java
index fea2d6a53c..d660b52d3f 100644
---
a/dubbo-remoting/dubbo-remoting-api/src/main/java/com/alibaba/dubbo/remoting/transport/dispatcher/WrappedChannelHandler.java
+++
b/dubbo-remoting/dubbo-remoting-api/src/main/java/com/alibaba/dubbo/remoting/transport/dispatcher/WrappedChannelHandler.java
@@ -109,4 +109,12 @@ public URL getUrl() {
return url;
}
+public ExecutorService getExecutorService() {
+ExecutorService cexecutor = executor;
+if (cexecutor == null || cexecutor.isShutdown()) {
+cexecutor = SHARED_EXECUTOR;
+}
+return cexecutor;
+}
+
}
diff --git
a/dubbo-remoting/dubbo-remoting-api/src/main/java/com/alibaba/dubbo/remoting/transport/dispatcher/all/AllChannelHandler.java
b/dubbo-remoting/dubbo-remoting-api/src/main/java/com/alibaba/dubbo/remoting/transport/dispatcher/all/AllChannelHandler.java
index 9e5b331cb2..d44f0655e8 100644
---
a/dubbo-remoting/dubbo-remoting-api/src/main/java/com/alibaba/dubbo/remoting/transport/dispatcher/all/AllChannelHandler.java
+++
b/dubbo-remoting/dubbo-remoting-api/src/main/java/com/alibaba/dubbo/remoting/transport/dispatcher/all/AllChannelHandler.java
@@ -88,12 +88,4 @@ public void caught(Channel channel, Throwable exception)
throws RemotingExceptio
throw new ExecutionException("caught event", channel, getClass() +
" error when process caught event .", t);
}
}
-
-private ExecutorService getExecutorService() {
-ExecutorService cexecutor = executor;
-if (cexecutor == null || cexecutor.isShutdown()) {
-cexecutor = SHARED_EXECUTOR;
-}
-return cexecutor;
-}
}
diff --git
a/dubbo-remoting/dubbo-remoting-api/src/main/java/com/alibaba/dubbo/remoting/transport/dispatcher/connection/ConnectionOrderedChannelHandler.java
b/dubbo-remoting/dubbo-remoting-api/src/main/java/com/alibaba/dubbo/remoting/transport/dispatcher/connection/ConnectionOrderedChannelHandler.java
index 1b162d5b6e..fb432a8563 100644
---
a/dubbo-remoting/dubbo-remoting-api/src/main/java/com/alibaba/dubbo/remoting/transport/dispatcher/connection/ConnectionOrderedChannelHandler.java
+++
b/dubbo-remoting/dubbo-remoting-api/src/main/java/com/alibaba/dubbo/remoting/transport/dispatcher/connection/ConnectionOrderedChannelHandler.java
@@ -75,10 +75,7 @@ public void disconnected(Channel channel) throws
RemotingException {
@Override
public void received(Channel channel, Object message) throws
RemotingException {
-ExecutorService cexecutor = executor;
-if (cexecutor == null || cexecutor.isShutdown()) {
-cexecutor = SHARED_EXECUTOR;
-}
+ExecutorService cexecutor = getExecutorService();
try {
cexecutor.execute(new ChannelEventRunnable(channel, handler,
ChannelState.RECEIVED, message));
} catch (Throwable t) {
@@ -100,10 +97,7 @@ public void received(Channel channel, Object message)
throws RemotingException {
@Override
public void caught(Channel channel, Throwable exception) throws
RemotingException {
-ExecutorService cexecutor = executor;
-if (cexecutor == null || cexecutor.isShutdown()) {
-cexecutor = SHARED_EXECUTOR;
-}
+ExecutorService cexecutor = getExecutorService();
try {
cexecutor.execute(new ChannelEventRunnable(channel, handler,
ChannelState.CAUGHT, exception));
} catch (Throwable t) {
diff --git
a/dubbo-remoting/dubbo-remoting-api/src/main/java/com/alibaba/dubbo/remoting/transport/dispatcher/execution/ExecutionChannelHandler.java
b/dubbo-remoting/dubbo-remoting-api/src/main/java/com/alibaba/dubbo/remoting/transport/dispatcher/execution/ExecutionChannelHandler.java
index 8a19bdd5a3..d31840b688 100644
---
a/dubbo-remoting/dubbo-remoting-api/src/main/java/com/alibaba/dubbo/remoting/transport/dispatcher/execution/ExecutionChannelHandler.java
+++
b/dubbo-remoting/dubbo-remoting-api/src/main/java/com/alibaba/dubbo/remoting/transport/dispatcher/execution/ExecutionChannelHandler.java
@@ -27,6 +27,7 @@
import
com.alibaba.dubbo.remoting.transport.dispatcher.ChannelEventRunnable.ChannelState;
import com.alibaba.dubbo.remoting.transport.dispatcher.WrappedChannelHandler;
+import java.util.concurrent.ExecutorService;
[GitHub] mercyblitz commented on issue #135: 刷星星哦
mercyblitz commented on issue #135: 刷星星哦 URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/135#issuecomment-388716180 @XUZHOUWANG @suclogger 两位都是非常关心社区发展的小伙伴，实际上，我想请大家帮忙的原因也是提升社区的活跃度。里面并没有刷单式的利益输送，小伙伴之所以支持主要是因为大家相互帮助，我也在微信群里面答疑解惑，当然这也是交流的一部分。我希望大家共同关注在本工程的发展上，多提出建设性意见和建议，实现社区成长。不希望此等话题不断以及口舌之争，后续我将本 issue 关闭。 **如果本人之前的行为对您的生活有打扰，我在此向您道歉。** This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] mercyblitz closed issue #135: 刷星星哦
mercyblitz closed issue #135: 刷星星哦 URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/135 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] beiwei30 closed pull request #1794: clean up work for config-api unit test
beiwei30 closed pull request #1794: clean up work for config-api unit test
URL: https://github.com/apache/incubator-dubbo/pull/1794
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/AbstractConfigTest.java
b/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/AbstractConfigTest.java
index 7cd83f0b28..5366b90910 100644
---
a/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/AbstractConfigTest.java
+++
b/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/AbstractConfigTest.java
@@ -18,6 +18,7 @@
import com.alibaba.dubbo.common.Constants;
import com.alibaba.dubbo.common.utils.ConfigUtils;
+import com.alibaba.dubbo.config.api.Greeting;
import com.alibaba.dubbo.config.support.Parameter;
import junit.framework.TestCase;
import org.junit.Test;
diff --git
a/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/AbstractInterfaceConfigTest.java
b/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/AbstractInterfaceConfigTest.java
index 94578b2cfd..f34c31ffbe 100644
---
a/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/AbstractInterfaceConfigTest.java
+++
b/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/AbstractInterfaceConfigTest.java
@@ -19,6 +19,12 @@
import com.alibaba.dubbo.common.Constants;
import com.alibaba.dubbo.common.URL;
import com.alibaba.dubbo.common.utils.ConfigUtils;
+import com.alibaba.dubbo.config.api.Greeting;
+import com.alibaba.dubbo.config.mock.GreetingLocal1;
+import com.alibaba.dubbo.config.mock.GreetingLocal2;
+import com.alibaba.dubbo.config.mock.GreetingLocal3;
+import com.alibaba.dubbo.config.mock.GreetingMock1;
+import com.alibaba.dubbo.config.mock.GreetingMock2;
import com.alibaba.dubbo.monitor.MonitorService;
import com.alibaba.dubbo.registry.RegistryService;
import junit.framework.TestCase;
diff --git
a/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/ProtocolConfigTest.java
b/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/ProtocolConfigTest.java
index 43f3621e28..c9d904622e 100644
---
a/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/ProtocolConfigTest.java
+++
b/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/ProtocolConfigTest.java
@@ -18,6 +18,7 @@
package com.alibaba.dubbo.config;
import com.alibaba.dubbo.common.extension.ExtensionLoader;
+import com.alibaba.dubbo.config.mock.MockProtocol2;
import com.alibaba.dubbo.rpc.Protocol;
import org.junit.Test;
import org.mockito.Mockito;
diff --git
a/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/RegistryConfigTest.java
b/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/RegistryConfigTest.java
new file mode 100644
index 00..1d9bbe2038
--- /dev/null
+++
b/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/RegistryConfigTest.java
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.alibaba.dubbo.config;
+
+import com.alibaba.dubbo.common.Constants;
+import org.junit.Test;
+
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.Map;
+
+import static org.hamcrest.CoreMatchers.is;
+import static org.hamcrest.Matchers.equalTo;
+import static org.hamcrest.Matchers.hasEntry;
+import static org.hamcrest.Matchers.hasKey;
+import static org.hamcrest.Matchers.not;
+import static org.junit.Assert.assertThat;
+
+public class RegistryConfigTest {
+@Test
+public void testProtocol() throws Exception {
+RegistryConfig registry = new RegistryConfig();
+registry.setProtocol("protocol");
+assertThat(registry.getProtocol(), equalTo(registry.getProtocol()));
+}
+
+@Test
+public void testAddress() throws Exception {
+RegistryConfig registry = new RegistryConfig();
+
[GitHub] beiwei30 closed pull request #1736: [Dubbo-1687]Add unit tests for dubbo-filter-validation module
beiwei30 closed pull request #1736: [Dubbo-1687]Add unit tests for
dubbo-filter-validation module
URL: https://github.com/apache/incubator-dubbo/pull/1736
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/dubbo-filter/dubbo-filter-validation/pom.xml
b/dubbo-filter/dubbo-filter-validation/pom.xml
index 758434779d..936777d36b 100644
--- a/dubbo-filter/dubbo-filter-validation/pom.xml
+++ b/dubbo-filter/dubbo-filter-validation/pom.xml
@@ -39,5 +39,35 @@
javax.validation
validation-api
+
+org.hibernate
+hibernate-validator
+test
+${hibernate_validator_version}
+
+
+javax.el
+javax.el-api
+test
+${el_api_version}
+
+
+javax.xml.bind
+jaxb-api
+test
+${jaxb_api_version}
+
+
+com.sun.xml.bind
+jaxb-impl
+test
+${jaxb_api_version}
+
+
+com.sun.xml.bind
+jaxb-core
+test
+${jaxb_api_version}
+
\ No newline at end of file
diff --git
a/dubbo-filter/dubbo-filter-validation/src/test/java/com/alibaba/dubbo/validation/filter/ValidationFilterTest.java
b/dubbo-filter/dubbo-filter-validation/src/test/java/com/alibaba/dubbo/validation/filter/ValidationFilterTest.java
new file mode 100644
index 00..c1a0ae1ade
--- /dev/null
+++
b/dubbo-filter/dubbo-filter-validation/src/test/java/com/alibaba/dubbo/validation/filter/ValidationFilterTest.java
@@ -0,0 +1,129 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package com.alibaba.dubbo.validation.filter;
+
+import com.alibaba.dubbo.common.URL;
+import com.alibaba.dubbo.rpc.*;
+import com.alibaba.dubbo.validation.Validation;
+import com.alibaba.dubbo.validation.Validator;
+import org.junit.Before;
+import org.junit.Test;
+
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.hamcrest.core.Is.is;
+import static org.mockito.BDDMockito.given;
+import static org.mockito.Mockito.mock;
+
+public class ValidationFilterTest {
+private Invoker invoker = mock(Invoker.class);
+private Validation validation = mock(Validation.class);
+private Validator validator = mock(Validator.class);
+private RpcInvocation invocation = mock(RpcInvocation.class);
+
+private ValidationFilter validationFilter;
+
+@Before
+public void setUp() throws Exception {
+this.validationFilter = new ValidationFilter();
+}
+
+@Test
+public void testItWithNotExistClass() throws Exception {
+URL url = URL.valueOf("test://test:11/test?default.validation=true");
+
+given(validation.getValidator(url)).willThrow(new
IllegalStateException("Not found class test, cause: test"));
+given(invoker.invoke(invocation)).willReturn(new RpcResult("success"));
+given(invoker.getUrl()).willReturn(url);
+given(invocation.getMethodName()).willReturn("echo1");
+given(invocation.getParameterTypes()).willReturn(new
Class[]{String.class});
+given(invocation.getArguments()).willReturn(new Object[]{"arg1"});
+
+validationFilter.setValidation(validation);
+Result result = validationFilter.invoke(invoker, invocation);
+
+assertThat(result.getException().getMessage(), is("Not found class
test, cause: test"));
+
+}
+
+@Test
+public void testItWithExistClass() throws Exception {
+URL url = URL.valueOf("test://test:11/test?default.validation=true");
+
+given(validation.getValidator(url)).willReturn(validator);
+given(invoker.invoke(invocation)).willReturn(new RpcResult("success"));
+given(invoker.getUrl()).willReturn(url);
+given(invocation.getMethodName()).willReturn("echo1");
+given(invocation.getParameterTypes()).willReturn(new
Class[]{String.class});
+
[GitHub] blinkingso opened a new issue #136: how to config provider ?
blinkingso opened a new issue #136: how to config provider ? URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/136 how to config registry or provider with redis registry? i want to del api from redis when i stop service provider . i tried with provider:dynamic and set true. but it does no work. any help? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] beiwei30 opened a new pull request #1796: unit test for com.alibaba.dubbo.common.status.support
beiwei30 opened a new pull request #1796: unit test for com.alibaba.dubbo.common.status.support URL: https://github.com/apache/incubator-dubbo/pull/1796 ## What is the purpose of the change unit test for com.alibaba.dubbo.common.status.support ## Brief changelog ## Verifying this change Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/alibaba/dubbo/tree/master/dubbo-test). - [ ] Run `mvn clean install -DskipTests` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass. - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] XUZHOUWANG opened a new issue #135: 刷星星哦
XUZHOUWANG opened a new issue #135: 刷星星哦 URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/135  please give me a star!!! haha it's normal!!! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] JarVZhao opened a new issue #1793: will version 3.0 be developped here?
JarVZhao opened a new issue #1793: will version 3.0 be developped here? URL: https://github.com/apache/incubator-dubbo/issues/1793 i wonder if version 3.0 will be developped here or started in a new project This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] mercyblitz closed issue #134: 一定要在service里面加这些东西? 不能设置默认值吗。。。
mercyblitz closed issue #134: 一定要在service里面加这些东西? 不能设置默认值吗。。。 URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/134 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] blinkingso commented on issue #136: how to config provider ?
blinkingso commented on issue #136: how to config provider ?
URL:
https://github.com/apache/incubator-dubbo-spring-boot-project/issues/136#issuecomment-388757758
` dubbo:
application:
name: ms-member-web
registry:
address: redis://${spring.redis.host}:${spring.redis.port}
username: root
password: ${spring.redis.password}
check: true
dynamic: true
server: true
protocol:
name: dubbo
port: 20880
consumer:
check: false
provider:
dynamic: true`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] diecui1202 commented on issue #1347: [Dubbo-1330] Fix Support MetaspaceSize and MaxMetaspaceSize vm args in java8+
diecui1202 commented on issue #1347: [Dubbo-1330] Fix Support MetaspaceSize and
MaxMetaspaceSize vm args in java8+
URL: https://github.com/apache/incubator-dubbo/pull/1347#issuecomment-388711874
@web1992 your shell is not work on my mac os. you can use this way:
```
JAVA_VERSION=`$JAVA_HOME"/bin/java" -version 2>&1` || { echo
$JAVA_HOME"/bin/java -version failed"; exit 1; }
JAVA_VERSION_MAJOR=${JAVA_VERSION:16:1}
if [ "$JAVA_VERSION_MAJOR" -ge 8 ]; then
..
```
It works on mac and linux.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] codecov-io commented on issue #1795: clean up: finish unit test for config-api
codecov-io commented on issue #1795: clean up: finish unit test for config-api URL: https://github.com/apache/incubator-dubbo/pull/1795#issuecomment-388728876 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1795?src=pr=h1) Report > Merging [#1795](https://codecov.io/gh/apache/incubator-dubbo/pull/1795?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/9c4017e9ba7ba170262f388ac159bcccb11ce209?src=pr=desc) will **increase** coverage by `0.05%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-dubbo/pull/1795?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1795 +/- ## + Coverage 39.28% 39.34% +0.05% - Complexity 4209 4216 +7 Files 618 618 Lines 2974229742 Branches 5257 5257 + Hits 1168411701 +17 + Misses1619016176 -14 + Partials 1868 1865 -3 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1795?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ba/dubbo/remoting/transport/netty/NettyServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1795/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlTZXJ2ZXIuamF2YQ==) | `67.85% <0%> (-3.58%)` | `8% <0%> (-1%)` | | | [...java/com/alibaba/dubbo/config/ReferenceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1795/diff?src=pr=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvUmVmZXJlbmNlQ29uZmlnLmphdmE=) | `48.33% <0%> (-0.37%)` | `36% <0%> (-1%)` | | | [...bo/remoting/transport/netty/NettyCodecAdapter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1795/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDb2RlY0FkYXB0ZXIuamF2YQ==) | `54.68% <0%> (+1.56%)` | `3% <0%> (ø)` | :arrow_down: | | [...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1795/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby90ZWxuZXQvSW52b2tlVGVsbmV0SGFuZGxlci5qYXZh) | `55.69% <0%> (+3.79%)` | `13% <0%> (+2%)` | :arrow_up: | | [...om/alibaba/dubbo/rpc/filter/ActiveLimitFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1795/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvZmlsdGVyL0FjdGl2ZUxpbWl0RmlsdGVyLmphdmE=) | `83.33% <0%> (+5.55%)` | `6% <0%> (+1%)` | :arrow_up: | | [...libaba/com/caucho/hessian/util/IdentityIntMap.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1795/diff?src=pr=tree#diff-aGVzc2lhbi1saXRlL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvY29tL2NhdWNoby9oZXNzaWFuL3V0aWwvSWRlbnRpdHlJbnRNYXAuamF2YQ==) | `30.95% <0%> (+5.95%)` | `7% <0%> (+2%)` | :arrow_up: | | [...a/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1795/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDaGFubmVsLmphdmE=) | `66.25% <0%> (+8.75%)` | `21% <0%> (+2%)` | :arrow_up: | | [...onfig/invoker/DelegateProviderMetaDataInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1795/diff?src=pr=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvaW52b2tlci9EZWxlZ2F0ZVByb3ZpZGVyTWV0YURhdGFJbnZva2VyLmphdmE=) | `100% <0%> (+18.18%)` | `7% <0%> (+2%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1795?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1795?src=pr=footer). Last update [9c4017e...f24a410](https://codecov.io/gh/apache/incubator-dubbo/pull/1795?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above
[GitHub] beiwei30 closed pull request #1795: clean up: finish unit test for config-api
beiwei30 closed pull request #1795: clean up: finish unit test for config-api
URL: https://github.com/apache/incubator-dubbo/pull/1795
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/AbstractConfigTest.java
b/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/AbstractConfigTest.java
index 7cd83f0b28..5366b90910 100644
---
a/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/AbstractConfigTest.java
+++
b/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/AbstractConfigTest.java
@@ -18,6 +18,7 @@
import com.alibaba.dubbo.common.Constants;
import com.alibaba.dubbo.common.utils.ConfigUtils;
+import com.alibaba.dubbo.config.api.Greeting;
import com.alibaba.dubbo.config.support.Parameter;
import junit.framework.TestCase;
import org.junit.Test;
diff --git
a/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/AbstractInterfaceConfigTest.java
b/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/AbstractInterfaceConfigTest.java
index 94578b2cfd..f34c31ffbe 100644
---
a/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/AbstractInterfaceConfigTest.java
+++
b/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/AbstractInterfaceConfigTest.java
@@ -19,6 +19,12 @@
import com.alibaba.dubbo.common.Constants;
import com.alibaba.dubbo.common.URL;
import com.alibaba.dubbo.common.utils.ConfigUtils;
+import com.alibaba.dubbo.config.api.Greeting;
+import com.alibaba.dubbo.config.mock.GreetingLocal1;
+import com.alibaba.dubbo.config.mock.GreetingLocal2;
+import com.alibaba.dubbo.config.mock.GreetingLocal3;
+import com.alibaba.dubbo.config.mock.GreetingMock1;
+import com.alibaba.dubbo.config.mock.GreetingMock2;
import com.alibaba.dubbo.monitor.MonitorService;
import com.alibaba.dubbo.registry.RegistryService;
import junit.framework.TestCase;
diff --git
a/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/ProtocolConfigTest.java
b/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/ProtocolConfigTest.java
index 43f3621e28..c9d904622e 100644
---
a/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/ProtocolConfigTest.java
+++
b/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/ProtocolConfigTest.java
@@ -18,6 +18,7 @@
package com.alibaba.dubbo.config;
import com.alibaba.dubbo.common.extension.ExtensionLoader;
+import com.alibaba.dubbo.config.mock.MockProtocol2;
import com.alibaba.dubbo.rpc.Protocol;
import org.junit.Test;
import org.mockito.Mockito;
diff --git
a/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/ServiceConfigTest.java
b/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/ServiceConfigTest.java
index 632cbd18ea..d0eb6bc8d0 100644
---
a/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/ServiceConfigTest.java
+++
b/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/ServiceConfigTest.java
@@ -20,7 +20,10 @@
import com.alibaba.dubbo.common.Constants;
import com.alibaba.dubbo.common.URL;
import com.alibaba.dubbo.config.api.DemoService;
+import com.alibaba.dubbo.config.api.Greeting;
import com.alibaba.dubbo.config.provider.impl.DemoServiceImpl;
+import com.alibaba.dubbo.config.mock.MockProtocol2;
+import com.alibaba.dubbo.config.mock.MockRegistryFactory2;
import com.alibaba.dubbo.registry.Registry;
import com.alibaba.dubbo.rpc.Exporter;
import com.alibaba.dubbo.rpc.Invoker;
@@ -55,7 +58,7 @@
@Before
public void setUp() throws Exception {
MockProtocol2.delegate = protocolDelegate;
-MockRegistryFactory.registry = registryDelegate;
+MockRegistryFactory2.registry = registryDelegate;
Mockito.when(protocolDelegate.export(Mockito.any(Invoker.class))).thenReturn(exporter);
ApplicationConfig app = new ApplicationConfig("app");
diff --git
a/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/Greeting.java
b/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/api/Greeting.java
similarity index 87%
rename from
dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/Greeting.java
rename to
dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/api/Greeting.java
index 65ab0f3b52..0ceca89d9f 100644
---
a/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/Greeting.java
+++
b/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/api/Greeting.java
@@ -6,7 +6,7 @@
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a
[GitHub] codecov-io commented on issue #1745: New threadLocal provides more performance.
codecov-io commented on issue #1745: New threadLocal provides more performance. URL: https://github.com/apache/incubator-dubbo/pull/1745#issuecomment-386791924 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr=h1) Report > Merging [#1745](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/ddc1ea4149d3e6879be21a55981f4ccb5ad14920?src=pr=desc) will **increase** coverage by `0.01%`. > The diff coverage is `46.82%`. [](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1745 +/- ## + Coverage 39.67% 39.69% +0.01% - Complexity 4285 4309 +24 Files 622 626 +4 Lines 2990730077 +170 Branches 5297 5318 +21 + Hits 1186711938 +71 - Misses1613816232 +94 - Partials 1902 1907 +5 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../threadpool/support/limited/LimitedThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9saW1pdGVkL0xpbWl0ZWRUaHJlYWRQb29sLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...mmon/threadpool/support/eager/EagerThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9lYWdlci9FYWdlclRocmVhZFBvb2wuamF2YQ==) | `90% <ø> (ø)` | `2 <0> (ø)` | :arrow_down: | | [...mmon/threadpool/support/fixed/FixedThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9maXhlZC9GaXhlZFRocmVhZFBvb2wuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...on/threadpool/support/cached/CachedThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9jYWNoZWQvQ2FjaGVkVGhyZWFkUG9vbC5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...alibaba/dubbo/common/utils/NamedThreadFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3V0aWxzL05hbWVkVGhyZWFkRmFjdG9yeS5qYXZh) | `64.7% <100%> (ø)` | `3 <2> (ø)` | :arrow_down: | | [...rc/main/java/com/alibaba/dubbo/rpc/RpcContext.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvUnBjQ29udGV4dC5qYXZh) | `30.93% <100%> (ø)` | `27 <1> (ø)` | :arrow_down: | | [...common/threadlocal/NamedInternalThreadFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL05hbWVkSW50ZXJuYWxUaHJlYWRGYWN0b3J5LmphdmE=) | `20% <20%> (ø)` | `1 <1> (?)` | | | [...ibaba/dubbo/common/threadlocal/InternalThread.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL0ludGVybmFsVGhyZWFkLmphdmE=) | `26.31% <26.31%> (ø)` | `3 <3> (?)` | | | [.../dubbo/common/threadlocal/InternalThreadLocal.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL0ludGVybmFsVGhyZWFkTG9jYWwuamF2YQ==) | `35.82% <35.82%> (ø)` | `8 <8> (?)` | | | [...bbo/common/threadlocal/InternalThreadLocalMap.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL0ludGVybmFsVGhyZWFkTG9jYWxNYXAuamF2YQ==) | `63.51% <63.51%> (ø)` | `15 <15> (?)` | | | ... and [10 more](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute
[GitHub] codecov-io commented on issue #1745: New threadLocal provides more performance.
codecov-io commented on issue #1745: New threadLocal provides more performance. URL: https://github.com/apache/incubator-dubbo/pull/1745#issuecomment-386791924 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr=h1) Report > Merging [#1745](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/ddc1ea4149d3e6879be21a55981f4ccb5ad14920?src=pr=desc) will **decrease** coverage by `0.02%`. > The diff coverage is `46.82%`. [](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1745 +/- ## - Coverage 39.67% 39.65% -0.03% - Complexity 4285 4308 +23 Files 622 626 +4 Lines 2990730077 +170 Branches 5297 5318 +21 + Hits 1186711928 +61 - Misses1613816243 +105 - Partials 1902 1906 +4 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mmon/threadpool/support/fixed/FixedThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9maXhlZC9GaXhlZFRocmVhZFBvb2wuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [.../threadpool/support/limited/LimitedThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9saW1pdGVkL0xpbWl0ZWRUaHJlYWRQb29sLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...on/threadpool/support/cached/CachedThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9jYWNoZWQvQ2FjaGVkVGhyZWFkUG9vbC5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...mmon/threadpool/support/eager/EagerThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9lYWdlci9FYWdlclRocmVhZFBvb2wuamF2YQ==) | `90% <ø> (ø)` | `2 <0> (ø)` | :arrow_down: | | [...alibaba/dubbo/common/utils/NamedThreadFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3V0aWxzL05hbWVkVGhyZWFkRmFjdG9yeS5qYXZh) | `64.7% <100%> (ø)` | `3 <2> (ø)` | :arrow_down: | | [...rc/main/java/com/alibaba/dubbo/rpc/RpcContext.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvUnBjQ29udGV4dC5qYXZh) | `30.93% <100%> (ø)` | `27 <1> (ø)` | :arrow_down: | | [...common/threadlocal/NamedInternalThreadFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL05hbWVkSW50ZXJuYWxUaHJlYWRGYWN0b3J5LmphdmE=) | `20% <20%> (ø)` | `1 <1> (?)` | | | [...ibaba/dubbo/common/threadlocal/InternalThread.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL0ludGVybmFsVGhyZWFkLmphdmE=) | `26.31% <26.31%> (ø)` | `3 <3> (?)` | | | [.../dubbo/common/threadlocal/InternalThreadLocal.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL0ludGVybmFsVGhyZWFkTG9jYWwuamF2YQ==) | `35.82% <35.82%> (ø)` | `8 <8> (?)` | | | [...bbo/common/threadlocal/InternalThreadLocalMap.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL0ludGVybmFsVGhyZWFkTG9jYWxNYXAuamF2YQ==) | `63.51% <63.51%> (ø)` | `15 <15> (?)` | | | ... and [10 more](https://codecov.io/gh/apache/incubator-dubbo/pull/1745/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1745?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute
[GitHub] beiwei30 closed pull request #1796: unit test for com.alibaba.dubbo.common.status.support
beiwei30 closed pull request #1796: unit test for
com.alibaba.dubbo.common.status.support
URL: https://github.com/apache/incubator-dubbo/pull/1796
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/dubbo-common/src/main/java/com/alibaba/dubbo/common/status/Status.java
b/dubbo-common/src/main/java/com/alibaba/dubbo/common/status/Status.java
index 940e17f570..ad598c94db 100644
--- a/dubbo-common/src/main/java/com/alibaba/dubbo/common/status/Status.java
+++ b/dubbo-common/src/main/java/com/alibaba/dubbo/common/status/Status.java
@@ -54,7 +54,7 @@ public String getDescription() {
/**
* Level
*/
-public static enum Level {
+public enum Level {
/**
* OK
*/
diff --git
a/dubbo-common/src/main/java/com/alibaba/dubbo/common/status/support/LoadStatusChecker.java
b/dubbo-common/src/main/java/com/alibaba/dubbo/common/status/support/LoadStatusChecker.java
index 018bce7807..20715c5d71 100644
---
a/dubbo-common/src/main/java/com/alibaba/dubbo/common/status/support/LoadStatusChecker.java
+++
b/dubbo-common/src/main/java/com/alibaba/dubbo/common/status/support/LoadStatusChecker.java
@@ -41,7 +41,8 @@ public Status check() {
load = -1;
}
int cpu = operatingSystemMXBean.getAvailableProcessors();
-return new Status(load < 0 ? Status.Level.UNKNOWN : (load < cpu ?
Status.Level.OK : Status.Level.WARN), (load < 0 ? "" : "load:" + load + ",") +
"cpu:" + cpu);
+return new Status(load < 0 ? Status.Level.UNKNOWN : (load < cpu ?
Status.Level.OK : Status.Level.WARN),
+(load < 0 ? "" : "load:" + load + ",") + "cpu:" + cpu);
}
}
diff --git
a/dubbo-common/src/test/java/com/alibaba/dubbo/common/status/StatusTest.java
b/dubbo-common/src/test/java/com/alibaba/dubbo/common/status/StatusTest.java
new file mode 100644
index 00..bc8e531483
--- /dev/null
+++ b/dubbo-common/src/test/java/com/alibaba/dubbo/common/status/StatusTest.java
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.alibaba.dubbo.common.status;
+
+import org.junit.Test;
+
+import static com.alibaba.dubbo.common.status.Status.Level.OK;
+import static org.hamcrest.Matchers.equalTo;
+import static org.hamcrest.Matchers.is;
+import static org.hamcrest.Matchers.isEmptyOrNullString;
+import static org.junit.Assert.assertThat;
+
+public class StatusTest {
+@Test
+public void testConstructor1() throws Exception {
+Status status = new Status(OK, "message", "description");
+assertThat(status.getLevel(), is(OK));
+assertThat(status.getMessage(), equalTo("message"));
+assertThat(status.getDescription(), equalTo("description"));
+}
+
+@Test
+public void testConstructor2() throws Exception {
+Status status = new Status(OK, "message");
+assertThat(status.getLevel(), is(OK));
+assertThat(status.getMessage(), equalTo("message"));
+assertThat(status.getDescription(), isEmptyOrNullString());
+}
+
+@Test
+public void testConstructor3() throws Exception {
+Status status = new Status(OK);
+assertThat(status.getLevel(), is(OK));
+assertThat(status.getMessage(), isEmptyOrNullString());
+assertThat(status.getDescription(), isEmptyOrNullString());
+}
+}
diff --git
a/dubbo-common/src/test/java/com/alibaba/dubbo/common/status/support/LoadStatusCheckerTest.java
b/dubbo-common/src/test/java/com/alibaba/dubbo/common/status/support/LoadStatusCheckerTest.java
new file mode 100644
index 00..121da3bb3b
--- /dev/null
+++
b/dubbo-common/src/test/java/com/alibaba/dubbo/common/status/support/LoadStatusCheckerTest.java
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License,
[GitHub] beiwei30 opened a new pull request #1797: unit test for SimpleDataStore
beiwei30 opened a new pull request #1797: unit test for SimpleDataStore URL: https://github.com/apache/incubator-dubbo/pull/1797 ## What is the purpose of the change unit test for SimpleDataStore ## Brief changelog ## Verifying this change Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/alibaba/dubbo/tree/master/dubbo-test). - [ ] Run `mvn clean install -DskipTests` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass. - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] codecov-io commented on issue #1797: unit test for SimpleDataStore
codecov-io commented on issue #1797: unit test for SimpleDataStore URL: https://github.com/apache/incubator-dubbo/pull/1797#issuecomment-389025831 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1797?src=pr=h1) Report > Merging [#1797](https://codecov.io/gh/apache/incubator-dubbo/pull/1797?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/04eacfeac7e4e25d3c2f0a2de12fa05708ee6b59?src=pr=desc) will **increase** coverage by `0.03%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-dubbo/pull/1797?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1797 +/- ## + Coverage 39.82% 39.85% +0.03% - Complexity 4324 4327 +3 Files 626 626 Lines 3007830078 Branches 5319 5319 + Hits 1197911989 +10 + Misses1618516174 -11 - Partials 1914 1915 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1797?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...a/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1797/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDaGFubmVsLmphdmE=) | `57.5% <0%> (-8.75%)` | `19% <0%> (-2%)` | | | [.../com/alibaba/dubbo/monitor/dubbo/DubboMonitor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1797/diff?src=pr=tree#diff-ZHViYm8tbW9uaXRvci9kdWJiby1tb25pdG9yLWRlZmF1bHQvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9tb25pdG9yL2R1YmJvL0R1YmJvTW9uaXRvci5qYXZh) | `89.71% <0%> (+1.86%)` | `15% <0%> (ø)` | :arrow_down: | | [...ba/dubbo/remoting/transport/netty/NettyServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1797/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlTZXJ2ZXIuamF2YQ==) | `71.42% <0%> (+3.57%)` | `9% <0%> (+1%)` | :arrow_up: | | [...om/alibaba/dubbo/rpc/filter/ActiveLimitFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1797/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvZmlsdGVyL0FjdGl2ZUxpbWl0RmlsdGVyLmphdmE=) | `83.33% <0%> (+5.55%)` | `6% <0%> (+1%)` | :arrow_up: | | [...aba/dubbo/remoting/transport/mina/MinaChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1797/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9taW5hL01pbmFDaGFubmVsLmphdmE=) | `53.52% <0%> (+11.26%)` | `16% <0%> (+1%)` | :arrow_up: | | [...ba/dubbo/common/store/support/SimpleDataStore.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1797/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3N0b3JlL3N1cHBvcnQvU2ltcGxlRGF0YVN0b3JlLmphdmE=) | `94.44% <0%> (+16.66%)` | `8% <0%> (+2%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1797?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1797?src=pr=footer). Last update [04eacfe...2307d15](https://codecov.io/gh/apache/incubator-dubbo/pull/1797?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] kivenhu commented on issue #818: mock 能在提供方统一 类名Mock，在消费方配置此类吗
kivenhu commented on issue #818: mock 能在提供方统一 类名Mock，在消费方配置此类吗 URL: https://github.com/apache/incubator-dubbo/issues/818#issuecomment-389026948 https://github.com/apache/incubator-dubbo/issues/1798 可以参考这个，统一抛出异常 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] YoungHu commented on issue #1624: [Design bug] unreasonable design for register dubbo service
YoungHu commented on issue #1624: [Design bug] unreasonable design for register dubbo service URL: https://github.com/apache/incubator-dubbo/issues/1624#issuecomment-389040288 @EdwardLee03 Yeah, our solution is to change the ZookeeperRegistry.toServicePath(URL) implementation, for our company use `group` more frequent than `version`, so our zk path like this(`interface:group`). for community version, I have two suggestion. the first, change the zk path to `interface:group:version`; the second, don't change zk path, just filter the zk item under `interface` path This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] beiwei30 closed pull request #1745: New threadLocal provides more performance.
beiwei30 closed pull request #1745: New threadLocal provides more performance.
URL: https://github.com/apache/incubator-dubbo/pull/1745
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/dubbo-common/src/main/java/com/alibaba/dubbo/common/threadlocal/InternalThread.java
b/dubbo-common/src/main/java/com/alibaba/dubbo/common/threadlocal/InternalThread.java
new file mode 100644
index 00..a836561c50
--- /dev/null
+++
b/dubbo-common/src/main/java/com/alibaba/dubbo/common/threadlocal/InternalThread.java
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.alibaba.dubbo.common.threadlocal;
+
+/**
+ * InternalThread
+ */
+public class InternalThread extends Thread {
+
+private InternalThreadLocalMap threadLocalMap;
+
+public InternalThread() {
+}
+
+public InternalThread(Runnable target) {
+super(target);
+}
+
+public InternalThread(ThreadGroup group, Runnable target) {
+super(group, target);
+}
+
+public InternalThread(String name) {
+super(name);
+}
+
+public InternalThread(ThreadGroup group, String name) {
+super(group, name);
+}
+
+public InternalThread(Runnable target, String name) {
+super(target, name);
+}
+
+public InternalThread(ThreadGroup group, Runnable target, String name) {
+super(group, target, name);
+}
+
+public InternalThread(ThreadGroup group, Runnable target, String name,
long stackSize) {
+super(group, target, name, stackSize);
+}
+
+/**
+ * Returns the internal data structure that keeps the threadLocal
variables bound to this thread.
+ * Note that this method is for internal use only, and thus is subject to
change at any time.
+ */
+public final InternalThreadLocalMap threadLocalMap() {
+return threadLocalMap;
+}
+
+/**
+ * Sets the internal data structure that keeps the threadLocal variables
bound to this thread.
+ * Note that this method is for internal use only, and thus is subject to
change at any time.
+ */
+public final void setThreadLocalMap(InternalThreadLocalMap threadLocalMap)
{
+this.threadLocalMap = threadLocalMap;
+}
+}
diff --git
a/dubbo-common/src/main/java/com/alibaba/dubbo/common/threadlocal/InternalThreadLocal.java
b/dubbo-common/src/main/java/com/alibaba/dubbo/common/threadlocal/InternalThreadLocal.java
new file mode 100644
index 00..4eed57c4e8
--- /dev/null
+++
b/dubbo-common/src/main/java/com/alibaba/dubbo/common/threadlocal/InternalThreadLocal.java
@@ -0,0 +1,197 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.alibaba.dubbo.common.threadlocal;
+
+import java.util.Collections;
+import java.util.IdentityHashMap;
+import java.util.Set;
+
+/**
+ * InternalThreadLocal
+ * A special variant of {@link ThreadLocal} that yields higher access
performance when accessed from a
+ * {@link InternalThread}.
+ *
+ * Internally, a {@link InternalThread} uses a constant index in an array,
instead of using hash code and hash table,
+ * to look for a variable. Although seemingly very subtle, it yields slight
performance advantage over using a hash
+ * table, and it is useful when
[GitHub] mercyblitz closed pull request #133: Ensure UT pass on Java 10. #128
mercyblitz closed pull request #133: Ensure UT pass on Java 10. #128
URL: https://github.com/apache/incubator-dubbo-spring-boot-project/pull/133
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/dubbo-spring-boot-parent/pom.xml b/dubbo-spring-boot-parent/pom.xml
index 68ffc1ab..db16bc3e 100644
--- a/dubbo-spring-boot-parent/pom.xml
+++ b/dubbo-spring-boot-parent/pom.xml
@@ -26,6 +26,10 @@
3.4.9
2.12.0
1.5
+3.0.2
+3.6.0
+3.0.1
+3.0.0-M1
@@ -174,6 +178,7 @@
org.apache.maven.plugins
maven-jar-plugin
+${maven-jar.version}
true
@@ -188,15 +193,16 @@
org.apache.maven.plugins
maven-compiler-plugin
+${maven-compiler.version}
${java.version}
${java.version}
-true
org.apache.maven.plugins
maven-enforcer-plugin
+${maven-enforcer.version}
enforce-rules
@@ -223,6 +229,7 @@
org.apache.maven.plugins
maven-source-plugin
+${maven-source.version}
attach-sources
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] blinkingso opened a new issue #137: providers' ip address at docker
blinkingso opened a new issue #137: providers' ip address at docker URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/137 how to use hostip instead of docker virtual ip on the registry. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] XUZHOUWANG commented on issue #135: 刷星星哦
XUZHOUWANG commented on issue #135: 刷星星哦 URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/135#issuecomment-389050283 希望已价值的方式输出，而非利用famous来做star的堆积。假如项目okay，自然会有人star。而非先找一波人star，再来搞社区什么的。阿里还是很牛逼的。只是不欣赏这种方式。 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] XUZHOUWANG commented on issue #135: 刷星星哦
XUZHOUWANG commented on issue #135: 刷星星哦 URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/135#issuecomment-389050833 @mercyblitz 希望用价值的方式输出，而非利用famous来做star的堆积。假如项目okay，自然会有人star。而非先找一波人star，再来搞社区什么的。阿里还是很牛逼的。只是不欣赏这种方式。 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 opened a new issue #11: dubbo.apache.org does not reflect the latest code
ralf0131 opened a new issue #11: dubbo.apache.org does not reflect the latest code URL: https://github.com/apache/incubator-dubbo-website/issues/11 When push the latest code to asf-site branch, dubbo.apache.org does not reflect the latest code. For example: We have changed the download link in [1], however, when visiting the website [2], it is not updated. [1] https://github.com/apache/incubator-dubbo-website/blob/asf-site/books/dubbo-admin-book-en/install/admin-console.html#L293 [2] http://dubbo.apache.org/books/dubbo-admin-book-en/install/admin-console.html This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] codecov-io commented on issue #1801: support generic invoke for http protocol #1768
codecov-io commented on issue #1801: support generic invoke for http protocol #1768 URL: https://github.com/apache/incubator-dubbo/pull/1801#issuecomment-389065493 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1801?src=pr=h1) Report > Merging [#1801](https://codecov.io/gh/apache/incubator-dubbo/pull/1801?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/f78f6d4fa2e600ec212371d5afdf4124fbfd46f0?src=pr=desc) will **increase** coverage by `0.16%`. > The diff coverage is `62.5%`. [](https://codecov.io/gh/apache/incubator-dubbo/pull/1801?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1801 +/- ## + Coverage 39.81% 39.97% +0.16% - Complexity 4327 4336 +9 Files 626 627 +1 Lines 3007830203 +125 Branches 5314 5343 +29 + Hits 1197512075 +100 - Misses1619016206 +16 - Partials 1913 1922 +9 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1801?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...om/alibaba/dubbo/rpc/filter/GenericImplFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1801/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvZmlsdGVyL0dlbmVyaWNJbXBsRmlsdGVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [.../alibaba/dubbo/rpc/protocol/http/HttpProtocol.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1801/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1odHRwL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcnBjL3Byb3RvY29sL2h0dHAvSHR0cFByb3RvY29sLmphdmE=) | `64.8% <64.51%> (ø)` | `7 <2> (?)` | | | [...baba/dubbo/remoting/transport/mina/MinaClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1801/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9taW5hL01pbmFDbGllbnQuamF2YQ==) | `57.81% <0%> (-1.57%)` | `8% <0%> (-1%)` | | | [...aba/dubbo/common/compiler/support/JdkCompiler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1801/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL2NvbXBpbGVyL3N1cHBvcnQvSmRrQ29tcGlsZXIuamF2YQ==) | `61.81% <0%> (ø)` | `2% <0%> (ø)` | :arrow_down: | | [...m/alibaba/com/caucho/hessian/io/Hessian2Input.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1801/diff?src=pr=tree#diff-aGVzc2lhbi1saXRlL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvY29tL2NhdWNoby9oZXNzaWFuL2lvL0hlc3NpYW4ySW5wdXQuamF2YQ==) | `19.27% <0%> (+0.11%)` | `63% <0%> (ø)` | :arrow_down: | | [...bo/remoting/transport/netty/NettyCodecAdapter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1801/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDb2RlY0FkYXB0ZXIuamF2YQ==) | `54.68% <0%> (+1.56%)` | `3% <0%> (ø)` | :arrow_down: | | [.../dubbo/rpc/protocol/dubbo/DecodeableRpcResult.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1801/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby9EZWNvZGVhYmxlUnBjUmVzdWx0LmphdmE=) | `59.09% <0%> (+2.27%)` | `8% <0%> (ø)` | :arrow_down: | | [...a/com/alibaba/dubbo/remoting/exchange/Request.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1801/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVtb3RpbmcvZXhjaGFuZ2UvUmVxdWVzdC5qYXZh) | `85.71% <0%> (+2.38%)` | `20% <0%> (ø)` | :arrow_down: | | [...bo/rpc/protocol/dubbo/telnet/LogTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1801/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby90ZWxuZXQvTG9nVGVsbmV0SGFuZGxlci5qYXZh) | `71.42% <0%> (+2.85%)` | `3% <0%> (ø)` | :arrow_down: | | ... and [2 more](https://codecov.io/gh/apache/incubator-dubbo/pull/1801/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1801?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1801?src=pr=footer). Last update
[GitHub] diecui1202 commented on issue #1799: 泛化调用返回结果解析不正
diecui1202 commented on issue #1799: 泛化调用返回结果解析不正 URL: https://github.com/apache/incubator-dubbo/issues/1799#issuecomment-389065577 Please use `gson.toJson()` for the result of generic invocation. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] mahaixue opened a new issue #1800: 泛化调用-zookeeper实例化失败之后 没有重新实例化
mahaixue opened a new issue #1800: 泛化调用-zookeeper实例化失败之后 没有重新实例化 URL: https://github.com/apache/incubator-dubbo/issues/1800 泛化调用通过zookeeper调用。第一次调用的ZK不存在（实例失败），再换一个存在的ZK调用，没有重新实例导致调用不成功 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] nzomkxia opened a new pull request #29: add DubboX doc #27
nzomkxia opened a new pull request #29: add DubboX doc #27 URL: https://github.com/apache/incubator-dubbo-docs/pull/29 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #11: dubbo.apache.org does not reflect the latest code
ralf0131 commented on issue #11: dubbo.apache.org does not reflect the latest code URL: https://github.com/apache/incubator-dubbo-website/issues/11#issuecomment-389056422 Filed an Infra ticket to track it: https://issues.apache.org/jira/browse/INFRA-16529 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] beiwei30 closed pull request #1797: unit test for SimpleDataStore
beiwei30 closed pull request #1797: unit test for SimpleDataStore
URL: https://github.com/apache/incubator-dubbo/pull/1797
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/dubbo-common/src/test/java/com/alibaba/dubbo/common/store/support/SimpleDataStoreTest.java
b/dubbo-common/src/test/java/com/alibaba/dubbo/common/store/support/SimpleDataStoreTest.java
index 42de80d517..0b81a9ad67 100644
---
a/dubbo-common/src/test/java/com/alibaba/dubbo/common/store/support/SimpleDataStoreTest.java
+++
b/dubbo-common/src/test/java/com/alibaba/dubbo/common/store/support/SimpleDataStoreTest.java
@@ -18,14 +18,18 @@
import org.junit.Test;
+import java.util.Map;
+
import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotEquals;
import static org.junit.Assert.assertNull;
+import static org.junit.Assert.assertTrue;
public class SimpleDataStoreTest {
-SimpleDataStore dataStore = new SimpleDataStore();
+private SimpleDataStore dataStore = new SimpleDataStore();
@Test
-public void testPut_Get() throws Exception {
+public void testPutGet() throws Exception {
assertNull(dataStore.get("xxx", "yyy"));
dataStore.put("name", "key", "1");
@@ -42,4 +46,15 @@ public void testRemove() throws Exception {
dataStore.remove("name", "key");
assertNull(dataStore.get("name", "key"));
}
+
+@Test
+public void testGetComponent() throws Exception {
+Map map = dataStore.get("component");
+assertTrue(map != null && map.isEmpty());
+dataStore.put("component", "key", "value");
+map = dataStore.get("component");
+assertTrue(map != null && map.size() == 1);
+dataStore.remove("component", "key");
+assertNotEquals(map, dataStore.get("component"));
+}
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] XUZHOUWANG commented on issue #135: 刷星星哦
XUZHOUWANG commented on issue #135: 刷星星哦 URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/135#issuecomment-389050283 希望已价值的方式输出，而非利用famous来做star的堆积。假如项目okay，自然会有人star。而非先找一波人star，再来搞社区什么的。阿里还是很牛逼的。只是不欣赏这种方式。 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] mahaixue opened a new issue #1799: 泛化调用返回结果解析不正
mahaixue opened a new issue #1799: 泛化调用返回结果解析不正
URL: https://github.com/apache/incubator-dubbo/issues/1799
参照图1调用接口，返回格式正确，参照返回结果格式说明
通过泛化调用返回结果：[{class=org.json.JSONObject}, {class=org.json.JSONObject},
{class=org.json.JSONObject}]
由于dubbo测试现在做了个平台通过泛化调用来获取，这个BUG导致结果无法展示，求优先处理
返回结果格式：
[
{
"map": {
"lineUrl": "//bbs.wtoip.com/article/1517899684455020036.html",
"articleTitle": "20180206\u003d\u003d\u003d\u003d投票贴",
"articleCreateTime": 1517899685861,
"tagObj": "3D打印"
}
},
{
"map": {
"lineUrl": "//bbs.wtoip.com/article/1516959574329020005.html",
"articleTitle": "20180126\u003d\u003d\u003d\u003d\u003d",
"articleCreateTime": 1516959574329,
"tagObj": "影视动漫"
}
},
{
"map": {
"lineUrl": "//bbs.wtoip.com/article/1514865621766.html",
"articleTitle": "测试投票人数",
"articleCreateTime": 1514865622317,
"tagObj": "汇桔人"
}
}
]
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] beiwei30 closed pull request #29: add DubboX doc #27
beiwei30 closed pull request #29: add DubboX doc #27
URL: https://github.com/apache/incubator-dubbo-docs/pull/29
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/dubbo-user-book/SUMMARY.md b/dubbo-user-book/SUMMARY.md
index c1eebd8..0cc3f96 100644
--- a/dubbo-user-book/SUMMARY.md
+++ b/dubbo-user-book/SUMMARY.md
@@ -57,6 +57,7 @@
* [6.42 分布式事务](./demos/distributed-transaction.md)
* [6.43 线程栈自动dump](./demos/dump.md)
* [6.44 Netty4](./demos/netty4.md)
+* [6.45 Kryo和FST序列化](./demos/serialization.md)
* [7 API 参考手册](./references/api.md)
* [8 schema 配置参考手册](./references/xml/introduction.md)
* [8.1 dubbo:service](./references/xml/dubbo-service.md)
@@ -80,6 +81,7 @@
* [9.6 thrift://](./references/protocol/thrift.md)
* [9.7 memcached://](./references/protocol/memcached.md)
* [9.8 redis://](./references/protocol/redis.md)
+* [9.9 rest://](./references/protocol/rest.md)
* [10 注册中心参考手册](./references/registry/introduction.md)
* [10.1 Multicast 注册中心](./references/registry/multicast.md)
* [10.2 Zookeeper 注册中心](./references/registry/zookeeper.md)
diff --git a/dubbo-user-book/demos/serialization.md
b/dubbo-user-book/demos/serialization.md
new file mode 100644
index 000..4722d21
--- /dev/null
+++ b/dubbo-user-book/demos/serialization.md
@@ -0,0 +1,80 @@
+# 在Dubbo中使用高效的Java序列化（Kryo和FST）
+
+
+## 启用Kryo和FST
+
+使用Kryo和FST非常简单，只需要在dubbo RPC的XML配置中添加一个属性即可：
+
+```xml
+
+```
+
+```xml
+
+```
+
+## 注册被序列化类
+
+要让Kryo和FST完全发挥出高性能，最好将那些需要被序列化的类注册到dubbo系统中，例如，我们可以实现如下回调接口：
+
+```java
+public class SerializationOptimizerImpl implements SerializationOptimizer {
+
+public Collection getSerializableClasses() {
+List classes = new LinkedList();
+classes.add(BidRequest.class);
+classes.add(BidResponse.class);
+classes.add(Device.class);
+classes.add(Geo.class);
+classes.add(Impression.class);
+classes.add(SeatBid.class);
+return classes;
+}
+}
+```
+
+然后在XML配置中添加：
+
+```xml
+
+```
+
+在注册这些类后，序列化的性能可能被大大提升，特别针对小数量的嵌套对象的时候。
+
+当然，在对一个类做序列化的时候，可能还级联引用到很多类，比如Java集合类。针对这种情况，我们已经自动将JDK中的常用类进行了注册，所以你不需要重复注册它们（当然你重复注册了也没有任何影响），包括：
+
+```
+GregorianCalendar
+InvocationHandler
+BigDecimal
+BigInteger
+Pattern
+BitSet
+URI
+UUID
+HashMap
+ArrayList
+LinkedList
+HashSet
+TreeSet
+Hashtable
+Date
+Calendar
+ConcurrentHashMap
+SimpleDateFormat
+Vector
+BitSet
+StringBuffer
+StringBuilder
+Object
+Object[]
+String[]
+byte[]
+char[]
+int[]
+float[]
+double[]
+```
+
+由于注册被序列化的类仅仅是出于性能优化的目的，所以即使你忘记注册某些类也没有关系。事实上，即使不注册任何类，Kryo和FST的性能依然普遍优于hessian和dubbo序列化。
+
diff --git a/dubbo-user-book/references/protocol/rest.md
b/dubbo-user-book/references/protocol/rest.md
new file mode 100644
index 000..c12bae5
--- /dev/null
+++ b/dubbo-user-book/references/protocol/rest.md
@@ -0,0 +1,741 @@
+# rest://
+
+基于标准的Java REST API——JAX-RS 2.0（Java API for RESTful Web Services的简写）实现的REST调用支持
+
+
+## 快速入门
+
+在dubbo中开发一个REST风格的服务会比较简单，下面以一个注册用户的简单服务为例说明。
+
+这个服务要实现的功能是提供如下URL（注：这个URL不是完全符合REST的风格，但是更简单实用）：
+
+```
+http://localhost:8080/users/register
+```
+
+而任何客户端都可以将包含用户信息的JSON字符串POST到以上URL来完成用户注册。
+
+首先，开发服务的接口：
+
+```java
+public class UserService {
+ void registerUser(User user);
+}
+```
+
+然后，开发服务的实现：
+
+```java
+@Path("users")
+public class UserServiceImpl implements UserService {
+
+@POST
+@Path("register")
+@Consumes({MediaType.APPLICATION_JSON})
+public void registerUser(User user) {
+// save the user...
+}
+}
+```
+上面的服务实现代码非常简单，但是由于REST服务是要被发布到特定HTTP
URL，供任意语言客户端甚至浏览器来访问，所以这里要额外添加了几个JAX-RS的标准annotation来做相关的配置：
+
+@Path("users")：指定访问UserService的URL相对路径是/users，即http://localhost:8080/users
+
+@Path("register")：指定访问registerUser()方法的URL相对路径是/register，再结合上一个@Path为UserService指定的路径，则调用UserService.register()的完整路径为http://localhost:8080/users/register
+
+@POST：指定访问registerUser()用HTTP POST方法
+
+@Consumes({MediaType.APPLICATION_JSON})：指定registerUser()接收JSON格式的数据。REST框架会自动将JSON数据反序列化为User对象
+
+最后，在spring配置文件中添加此服务，即完成所有服务开发工作：
+
+ ```xml
+
+
+
+
+
+
+
+
+```
+
+## REST服务提供端详解
+
+下面我们扩充“快速入门”中的UserService，进一步展示在dubbo中REST服务提供端的开发要点。
+
+### HTTP POST/GET的实现
+
+REST服务中虽然建议使用HTTP协议中四种标准方法POST、DELETE、PUT、GET来分别实现常见的“增删改查”，但实际中，我们一般情况直接用POST来实现“增改”，GET来实现“删查”即可（DELETE和PUT甚至会被一些防火墙阻挡）。
+
+前面已经简单演示了POST的实现，在此，我们为UserService添加一个获取注册用户资料的功能，来演示GET的实现。
+
+这个功能就是要实现客户端通过访问如下不同URL来获取不同ID的用户资料：
+
+```
+http://localhost:8080/users/1001
+http://localhost:8080/users/1002
+http://localhost:8080/users/1003
+```
+
+当然，也可以通过其他形式的URL来访问不同ID的用户资料，例如：
+
+```
+http://localhost:8080/users/load?id=1001
+```
+
+JAX-RS本身可以支持所有这些形式。但是上面那种在URL路径中包含查询参数的形式（http://localhost:8080/users/1001）
更符合REST的一般习惯，所以更推荐大家来使用。下面我们就为UserService添加一个getUser()方法来实现这种形式的URL访问：
+
+```java
+@GET
+@Path("{id : \\d+}")
[GitHub] lovepoem opened a new issue #1682: Enhance the test coverage part-4 : dubbo-common/src/main/java/com/alibaba/dubbo/common/status(store|threadpoolutils) modules
lovepoem opened a new issue #1682: Enhance the test coverage part-4 : dubbo-common/src/main/java/com/alibaba/dubbo/common/status(store|threadpoolutils) modules URL: https://github.com/apache/incubator-dubbo/issues/1682 Add unit test,modules: dubbo-common/src/main/java/com/alibaba/dubbo/common/status dubbo-common/src/main/java/com/alibaba/dubbo/common/store dubbo-common/src/main/java/com/alibaba/dubbo/common/threadpool dubbo-common/src/main/java/com/alibaba/dubbo/common/utils This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] beiwei30 opened a new pull request #1802: Thread pool unit test
beiwei30 opened a new pull request #1802: Thread pool unit test URL: https://github.com/apache/incubator-dubbo/pull/1802 ## What is the purpose of the change unit test for package com.alibaba.dubbo.common.threadpool ## Brief changelog ## Verifying this change Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/alibaba/dubbo/tree/master/dubbo-test). - [ ] Run `mvn clean install -DskipTests` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass. - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] codecov-io commented on issue #1802: Thread pool unit test
codecov-io commented on issue #1802: Thread pool unit test URL: https://github.com/apache/incubator-dubbo/pull/1802#issuecomment-389067591 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1802?src=pr=h1) Report > Merging [#1802](https://codecov.io/gh/apache/incubator-dubbo/pull/1802?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/f78f6d4fa2e600ec212371d5afdf4124fbfd46f0?src=pr=desc) will **increase** coverage by `0.18%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-dubbo/pull/1802?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1802 +/- ## + Coverage 39.81% 39.99% +0.18% - Complexity 4327 4345 +18 Files 626 626 Lines 3007830078 Branches 5314 5319 +5 + Hits 1197512031 +56 + Misses1619016136 -54 + Partials 1913 1911 -2 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1802?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...om/alibaba/dubbo/rpc/filter/ActiveLimitFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1802/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvZmlsdGVyL0FjdGl2ZUxpbWl0RmlsdGVyLmphdmE=) | `77.77% <0%> (-11.12%)` | `5% <0%> (-2%)` | | | [...aba/dubbo/common/compiler/support/JdkCompiler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1802/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL2NvbXBpbGVyL3N1cHBvcnQvSmRrQ29tcGlsZXIuamF2YQ==) | `61.81% <0%> (ø)` | `2% <0%> (ø)` | :arrow_down: | | [...m/alibaba/com/caucho/hessian/io/Hessian2Input.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1802/diff?src=pr=tree#diff-aGVzc2lhbi1saXRlL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvY29tL2NhdWNoby9oZXNzaWFuL2lvL0hlc3NpYW4ySW5wdXQuamF2YQ==) | `19.27% <0%> (+0.11%)` | `63% <0%> (ø)` | :arrow_down: | | [...on/src/main/java/com/alibaba/dubbo/common/URL.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1802/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL1VSTC5qYXZh) | `26.34% <0%> (+0.44%)` | `77% <0%> (+1%)` | :arrow_up: | | [.../dubbo/rpc/protocol/dubbo/DecodeableRpcResult.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1802/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby9EZWNvZGVhYmxlUnBjUmVzdWx0LmphdmE=) | `59.09% <0%> (+2.27%)` | `8% <0%> (ø)` | :arrow_down: | | [...a/com/alibaba/dubbo/remoting/exchange/Request.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1802/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVtb3RpbmcvZXhjaGFuZ2UvUmVxdWVzdC5qYXZh) | `85.71% <0%> (+2.38%)` | `20% <0%> (ø)` | :arrow_down: | | [...bo/rpc/protocol/dubbo/telnet/LogTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1802/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby90ZWxuZXQvTG9nVGVsbmV0SGFuZGxlci5qYXZh) | `71.42% <0%> (+2.85%)` | `3% <0%> (ø)` | :arrow_down: | | [...a/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1802/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDaGFubmVsLmphdmE=) | `66.25% <0%> (+8.75%)` | `21% <0%> (+2%)` | :arrow_up: | | [...mmon/threadpool/support/eager/EagerThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1802/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9lYWdlci9FYWdlclRocmVhZFBvb2wuamF2YQ==) | `100% <0%> (+10%)` | `3% <0%> (+1%)` | :arrow_up: | | [...ibaba/dubbo/common/threadlocal/InternalThread.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1802/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL0ludGVybmFsVGhyZWFkLmphdmE=) | `36.84% <0%> (+10.52%)` | `4% <0%> (+1%)` | :arrow_up: | | ... and [6 more](https://codecov.io/gh/apache/incubator-dubbo/pull/1802/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1802?src=pr=continue). > **Legend** - [Click here
[GitHub] liaozan opened a new pull request #1764: Remove unnecessary null check.
liaozan opened a new pull request #1764: Remove unnecessary null check. URL: https://github.com/apache/incubator-dubbo/pull/1764 Remove unnecessary null check. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] beiwei30 closed pull request #1758: Config api unit test
beiwei30 closed pull request #1758: Config api unit test
URL: https://github.com/apache/incubator-dubbo/pull/1758
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/dubbo-config/dubbo-config-api/src/main/java/com/alibaba/dubbo/config/ArgumentConfig.java
b/dubbo-config/dubbo-config-api/src/main/java/com/alibaba/dubbo/config/ArgumentConfig.java
index 61fff8defc..e752726a0c 100644
---
a/dubbo-config/dubbo-config-api/src/main/java/com/alibaba/dubbo/config/ArgumentConfig.java
+++
b/dubbo-config/dubbo-config-api/src/main/java/com/alibaba/dubbo/config/ArgumentConfig.java
@@ -27,7 +27,7 @@
private static final long serialVersionUID = -2165482463925213595L;
-//arugment index -1 represents not set
+//argument: index -1 represents not set
private Integer index = -1;
//argument type
diff --git
a/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/ApplicationConfigTest.java
b/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/ApplicationConfigTest.java
new file mode 100644
index 00..f60bb85698
--- /dev/null
+++
b/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/ApplicationConfigTest.java
@@ -0,0 +1,177 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.alibaba.dubbo.config;
+
+import com.alibaba.dubbo.common.Constants;
+import org.junit.Test;
+
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.Map;
+
+import static org.hamcrest.Matchers.contains;
+import static org.hamcrest.Matchers.equalTo;
+import static org.hamcrest.Matchers.hasEntry;
+import static org.hamcrest.Matchers.is;
+import static org.hamcrest.Matchers.sameInstance;
+import static org.hamcrest.collection.IsCollectionWithSize.hasSize;
+import static org.junit.Assert.assertThat;
+
+public class ApplicationConfigTest {
+@Test
+public void testName() throws Exception {
+ApplicationConfig application = new ApplicationConfig();
+application.setName("app");
+assertThat(application.getName(), equalTo("app"));
+application = new ApplicationConfig("app2");
+assertThat(application.getName(), equalTo("app2"));
+Map parameters = new HashMap();
+ApplicationConfig.appendParameters(parameters, application);
+assertThat(parameters, hasEntry(Constants.APPLICATION_KEY, "app2"));
+}
+
+@Test
+public void testVersion() throws Exception {
+ApplicationConfig application = new ApplicationConfig("app");
+application.setVersion("1.0.0");
+assertThat(application.getVersion(), equalTo("1.0.0"));
+Map parameters = new HashMap();
+ApplicationConfig.appendParameters(parameters, application);
+assertThat(parameters, hasEntry("application.version", "1.0.0"));
+}
+
+@Test
+public void testOwner() throws Exception {
+ApplicationConfig application = new ApplicationConfig("app");
+application.setOwner("owner");
+assertThat(application.getOwner(), equalTo("owner"));
+}
+
+@Test
+public void testOrganization() throws Exception {
+ApplicationConfig application = new ApplicationConfig("app");
+application.setOrganization("org");
+assertThat(application.getOrganization(), equalTo("org"));
+}
+
+@Test
+public void testArchitecture() throws Exception {
+ApplicationConfig application = new ApplicationConfig("app");
+application.setArchitecture("arch");
+assertThat(application.getArchitecture(), equalTo("arch"));
+}
+
+@Test
+public void testEnvironment1() throws Exception {
+ApplicationConfig application = new ApplicationConfig("app");
+application.setEnvironment("develop");
+assertThat(application.getEnvironment(), equalTo("develop"));
+application.setEnvironment("test");
+assertThat(application.getEnvironment(),
[GitHub] codecov-io commented on issue #1762: Remove unnecessary null check.
codecov-io commented on issue #1762: Remove unnecessary null check. URL: https://github.com/apache/incubator-dubbo/pull/1762#issuecomment-387686777 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1762?src=pr=h1) Report > Merging [#1762](https://codecov.io/gh/apache/incubator-dubbo/pull/1762?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/6ec0225cfa9b45c8349d19019f965d5c52d40a09?src=pr=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/incubator-dubbo/pull/1762?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1762 +/- ## - Coverage 37.93% 37.92% -0.02% Complexity 4023 4023 Files 618 618 Lines 2972729738 +11 Branches 5241 5241 Hits 1127811278 - Misses1660816619 +11 Partials 1841 1841 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1762?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...om/alibaba/dubbo/config/spring/AnnotationBean.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1762/diff?src=pr=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL0Fubm90YXRpb25CZWFuLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...om/alibaba/dubbo/rpc/filter/ActiveLimitFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1762/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvZmlsdGVyL0FjdGl2ZUxpbWl0RmlsdGVyLmphdmE=) | `83.33% <0%> (-5.56%)` | `6% <0%> (-1%)` | | | [...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1762/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby9DaGFubmVsV3JhcHBlZEludm9rZXIuamF2YQ==) | `41.66% <0%> (-4.17%)` | `3% <0%> (ø)` | | | [...baba/dubbo/remoting/transport/mina/MinaClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1762/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9taW5hL01pbmFDbGllbnQuamF2YQ==) | `57.81% <0%> (-1.57%)` | `8% <0%> (-1%)` | | | [...bo/remoting/transport/netty/NettyCodecAdapter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1762/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDb2RlY0FkYXB0ZXIuamF2YQ==) | `54.68% <0%> (+1.56%)` | `3% <0%> (ø)` | :arrow_down: | | [.../com/alibaba/dubbo/monitor/dubbo/DubboMonitor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1762/diff?src=pr=tree#diff-ZHViYm8tbW9uaXRvci9kdWJiby1tb25pdG9yLWRlZmF1bHQvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9tb25pdG9yL2R1YmJvL0R1YmJvTW9uaXRvci5qYXZh) | `76.63% <0%> (+1.86%)` | `7% <0%> (ø)` | :arrow_down: | | [...ba/dubbo/remoting/transport/netty/NettyServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1762/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlTZXJ2ZXIuamF2YQ==) | `70.9% <0%> (+3.63%)` | `9% <0%> (+1%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1762?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1762?src=pr=footer). Last update [6ec0225...a42fa2d](https://codecov.io/gh/apache/incubator-dubbo/pull/1762?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] justinmclean commented on issue #27: Enable rest and serialization documentation
justinmclean commented on issue #27: Enable rest and serialization documentation URL: https://github.com/apache/incubator-dubbo-docs/issues/27#issuecomment-387696290 Hi, > Yes. A software grant has been filed. > Great! Just not obvious from the name and perhaps the process has not been correct followed as I don’t see it listed here: http://incubator.apache.org/ip-clearance/ It may just need to be updated and/or lazy consensus of IP clearance asked on the incubator list. [1] Thanks, Justin 1. http://apache.org/foundation/how-it-works/legal.html#incoming-code This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] diecui1202 commented on a change in pull request #1267: [dubbo-1267]add consistentHashLoadBalance test
diecui1202 commented on a change in pull request #1267: [dubbo-1267]add
consistentHashLoadBalance test
URL: https://github.com/apache/incubator-dubbo/pull/1267#discussion_r186943993
##
File path:
dubbo-cluster/src/test/java/com/alibaba/dubbo/rpc/cluster/loadbalance/LoadBalanceTest.java
##
@@ -71,6 +73,14 @@ public void setUp() throws Exception {
invoker3 = EasyMock.createMock(Invoker.class);
invoker4 = EasyMock.createMock(Invoker.class);
invoker5 = EasyMock.createMock(Invoker.class);
+invocationList = new ArrayList();
+for(int i=0; i<1000; i++){
Review comment:
Could you format the code ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] diecui1202 commented on a change in pull request #1267: [dubbo-1267]add consistentHashLoadBalance test
diecui1202 commented on a change in pull request #1267: [dubbo-1267]add
consistentHashLoadBalance test
URL: https://github.com/apache/incubator-dubbo/pull/1267#discussion_r186944119
##
File path:
dubbo-cluster/src/test/java/com/alibaba/dubbo/rpc/cluster/loadbalance/LoadBalanceTest.java
##
@@ -71,6 +73,14 @@ public void setUp() throws Exception {
invoker3 = EasyMock.createMock(Invoker.class);
invoker4 = EasyMock.createMock(Invoker.class);
invoker5 = EasyMock.createMock(Invoker.class);
+invocationList = new ArrayList();
+for(int i=0; i<1000; i++){
+Invocation invocation1 = EasyMock.createMock(Invocation.class);
Review comment:
`invocation` is a better variable name here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] codecov-io commented on issue #1764: Remove unnecessary null check.
codecov-io commented on issue #1764: Remove unnecessary null check. URL: https://github.com/apache/incubator-dubbo/pull/1764#issuecomment-387691253 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1764?src=pr=h1) Report > Merging [#1764](https://codecov.io/gh/apache/incubator-dubbo/pull/1764?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/6ec0225cfa9b45c8349d19019f965d5c52d40a09?src=pr=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/incubator-dubbo/pull/1764?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1764 +/- ## - Coverage 37.93% 37.93% -0.01% + Complexity 4023 4022 -1 Files 618 618 Lines 2972729728 +1 Branches 5241 5241 - Hits 1127811277 -1 - Misses1660816611 +3 + Partials 1841 1840 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1764?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...om/alibaba/dubbo/config/spring/AnnotationBean.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1764/diff?src=pr=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL0Fubm90YXRpb25CZWFuLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1764/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby9DaGFubmVsV3JhcHBlZEludm9rZXIuamF2YQ==) | `41.66% <0%> (-4.17%)` | `3% <0%> (ø)` | | | [...bo/remoting/transport/netty/NettyCodecAdapter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1764/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDb2RlY0FkYXB0ZXIuamF2YQ==) | `54.68% <0%> (+1.56%)` | `3% <0%> (ø)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1764?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1764?src=pr=footer). Last update [6ec0225...3d4edd1](https://codecov.io/gh/apache/incubator-dubbo/pull/1764?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ChoingHyun opened a new issue #29: 启动报错：Exception in thread "main" java.lang.NoClassDefFoundError: javax/servlet/FilterChain
ChoingHyun opened a new issue #29: 启动报错：Exception in thread "main" java.lang.NoClassDefFoundError: javax/servlet/FilterChain URL: https://github.com/apache/incubator-dubbo-ops/issues/29 `Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=128m; support was removed in 8.0 Java HotSpot(TM) 64-Bit Server VM warning: UseCMSCompactAtFullCollection is deprecated and will likely be removed in a future release. INFO logger.LoggerFactory - using logger: com.alibaba.dubbo.common.logger.log4j.Log4jLoggerAdapter INFO container.Main - [DUBBO] Use container type([log4j, spring, registry, jetty]) to run dubbo serivce., dubbo version: 2.6.0, current host: 127.0.0.1 Exception in thread "main" java.lang.NoClassDefFoundError: javax/servlet/FilterChain at java.lang.ClassLoader.defineClass1(Native Method) at java.lang.ClassLoader.defineClass(ClassLoader.java:760) at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142) at java.net.URLClassLoader.defineClass(URLClassLoader.java:467) at java.net.URLClassLoader.access$100(URLClassLoader.java:73) at java.net.URLClassLoader$1.run(URLClassLoader.java:368) at java.net.URLClassLoader$1.run(URLClassLoader.java:362) at java.security.AccessController.doPrivileged(Native Method) at java.net.URLClassLoader.findClass(URLClassLoader.java:361) at java.lang.ClassLoader.loadClass(ClassLoader.java:424) at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:331) at java.lang.ClassLoader.loadClass(ClassLoader.java:357) at com.alibaba.dubbo.container.jetty.JettyContainer.start(JettyContainer.java:56) at com.alibaba.dubbo.container.Main.main(Main.java:85) Caused by: java.lang.ClassNotFoundException: javax.servlet.FilterChain at java.net.URLClassLoader.findClass(URLClassLoader.java:381) at java.lang.ClassLoader.loadClass(ClassLoader.java:424) at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:331) at java.lang.ClassLoader.loadClass(ClassLoader.java:357) ... 14 more ` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] beiwei30 closed pull request #1746: [Dubbo-1744] Enable tcp no delay for netty 3 server implementation
beiwei30 closed pull request #1746: [Dubbo-1744] Enable tcp no delay for netty
3 server implementation
URL: https://github.com/apache/incubator-dubbo/pull/1746
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/dubbo-remoting/dubbo-remoting-netty/src/main/java/com/alibaba/dubbo/remoting/transport/netty/NettyServer.java
b/dubbo-remoting/dubbo-remoting-netty/src/main/java/com/alibaba/dubbo/remoting/transport/netty/NettyServer.java
index d08ff257f2..0d1103b426 100644
---
a/dubbo-remoting/dubbo-remoting-netty/src/main/java/com/alibaba/dubbo/remoting/transport/netty/NettyServer.java
+++
b/dubbo-remoting/dubbo-remoting-netty/src/main/java/com/alibaba/dubbo/remoting/transport/netty/NettyServer.java
@@ -74,6 +74,7 @@ protected void doOpen() throws Throwable {
// https://issues.jboss.org/browse/NETTY-365
// https://issues.jboss.org/browse/NETTY-379
// final Timer timer = new HashedWheelTimer(new
NamedThreadFactory("NettyIdleTimer", true));
+bootstrap.setOption("child.tcpNoDelay", true);
bootstrap.setPipelineFactory(new ChannelPipelineFactory() {
public ChannelPipeline getPipeline() {
NettyCodecAdapter adapter = new NettyCodecAdapter(getCodec(),
getUrl(), NettyServer.this);
@@ -153,4 +154,4 @@ public boolean isBound() {
return channel.isBound();
}
-}
\ No newline at end of file
+}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
