[jira] [Commented] (OFBIZ-12659) Lookups: No result option should not be selectable
[ https://issues.apache.org/jira/browse/OFBIZ-12659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620434#comment-17620434 ] Florian Motteau commented on OFBIZ-12659: - ok, thanks again ! > Lookups: No result option should not be selectable > -- > > Key: OFBIZ-12659 > URL: https://issues.apache.org/jira/browse/OFBIZ-12659 > Project: OFBiz > Issue Type: Bug > Components: themes >Affects Versions: 18.12.05, 22.01.01, Upcoming Branch >Reporter: Florian Motteau >Assignee: Jacques Le Roux >Priority: Minor > Fix For: 22.01.01 > > Attachments: OFBIZ-12659.patch, image-2022-10-19-14-26-49-350.png, > lookups-no-record-found.mp4 > > > On lookups, if the search request returns nothing, we have a dropdown with > only one option : "No records found". > This option is selectable, and when the user clicks it the input is filled > with the string "No records found". When the form is submitted, this value is > submitted as well. > The "No records found" option should not be selectable, it should not be > possible to submit the field with this value. When clicking on this option, > we could either : > * leave the input with its previous value (do nothing) > * empty the input -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-12659) Lookups: No result option should not be selectable
[ https://issues.apache.org/jira/browse/OFBIZ-12659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-12659. --- Fix Version/s: 22.01.01 Resolution: Fixed > Lookups: No result option should not be selectable > -- > > Key: OFBIZ-12659 > URL: https://issues.apache.org/jira/browse/OFBIZ-12659 > Project: OFBiz > Issue Type: Bug > Components: themes >Affects Versions: 18.12.05, 22.01.01, Upcoming Branch >Reporter: Florian Motteau >Assignee: Jacques Le Roux >Priority: Minor > Fix For: 22.01.01 > > Attachments: OFBIZ-12659.patch, image-2022-10-19-14-26-49-350.png, > lookups-no-record-found.mp4 > > > On lookups, if the search request returns nothing, we have a dropdown with > only one option : "No records found". > This option is selectable, and when the user clicks it the input is filled > with the string "No records found". When the form is submitted, this value is > submitted as well. > The "No records found" option should not be selectable, it should not be > possible to submit the field with this value. When clicking on this option, > we could either : > * leave the input with its previous value (do nothing) > * empty the input -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12659) Lookups: No result option should not be selectable
[ https://issues.apache.org/jira/browse/OFBIZ-12659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620429#comment-17620429 ] Jacques Le Roux commented on OFBIZ-12659: - Florian, I guess I'm too used to URLs, indeed Néréides has accents, thanks. Yes I wanted to assign you, but we can't because you are not a committer, forgot that. Anyway, I assign my self and close now. > Lookups: No result option should not be selectable > -- > > Key: OFBIZ-12659 > URL: https://issues.apache.org/jira/browse/OFBIZ-12659 > Project: OFBiz > Issue Type: Bug > Components: themes >Affects Versions: 18.12.05, 22.01.01, Upcoming Branch >Reporter: Florian Motteau >Assignee: Jacques Le Roux >Priority: Minor > Attachments: OFBIZ-12659.patch, image-2022-10-19-14-26-49-350.png, > lookups-no-record-found.mp4 > > > On lookups, if the search request returns nothing, we have a dropdown with > only one option : "No records found". > This option is selectable, and when the user clicks it the input is filled > with the string "No records found". When the form is submitted, this value is > submitted as well. > The "No records found" option should not be selectable, it should not be > possible to submit the field with this value. When clicking on this option, > we could either : > * leave the input with its previous value (do nothing) > * empty the input -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12659) Lookups: No result option should not be selectable
[
https://issues.apache.org/jira/browse/OFBIZ-12659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620427#comment-17620427
]
Jacques Le Roux commented on OFBIZ-12659:
-
Argh, I'm stupid. I should have changed the commit comment when backporting.
Now I need to do it here by hand :/ Anyway not a big deal, here it is:
{quote}
jleroux pushed a commit to branch release22.01
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git
The following commit(s) were added to refs/heads/release22.01 by this push:
new cc646de260 Improved: Make lookup's no result message not selectable
(#553)
cc646de260 is described below
commit
[cc646de2601dce99f34dbedf4fcfc7e8e680aed7|https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;a=commit;h=cc646de2601dce99f34dbedf4fcfc7e8e680aed7]
Author: Florian Motteau
AuthorDate: Wed Oct 19 13:41:01 2022 +0200
Improved: Make lookup's no result message not selectable (#553)
{quote}
> Lookups: No result option should not be selectable
> --
>
> Key: OFBIZ-12659
> URL: https://issues.apache.org/jira/browse/OFBIZ-12659
> Project: OFBiz
> Issue Type: Bug
> Components: themes
>Affects Versions: 18.12.05, 22.01.01, Upcoming Branch
>Reporter: Florian Motteau
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: OFBIZ-12659.patch, image-2022-10-19-14-26-49-350.png,
> lookups-no-record-found.mp4
>
>
> On lookups, if the search request returns nothing, we have a dropdown with
> only one option : "No records found".
> This option is selectable, and when the user clicks it the input is filled
> with the string "No records found". When the form is submitted, this value is
> submitted as well.
> The "No records found" option should not be selectable, it should not be
> possible to submit the field with this value. When clicking on this option,
> we could either :
> * leave the input with its previous value (do nothing)
> * empty the input
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-6747) Replace ConcurrentLinkedHashMap by Caffeine
[
https://issues.apache.org/jira/browse/OFBIZ-6747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620413#comment-17620413
]
Jacques Le Roux commented on OFBIZ-6747:
Finally, I has a serious look at UtilCache.
I wrote above:
bq. CLHM is only used in 2 places: UtilCache and ServiceDispatcher classes.
Moreover in UtilCache it's only really used OOTB by
EntityPerformanceTest.groovy.
Actually last sentence is wrong. CLHM in UtilCache is OOTB only used by
UtilCacheTests class.
I traced it back. CLHM was put in UtilCache by Adam more than 10 years ago. I
guess he used it on his side. It's not used OOTB apart that. And we have a
problem with UtilCacheTests, because we can't cast Caffeine to a Map without
using its asMap() method. So we get the errors below when running tests with
OFBIZ-6747.patch applied, when all the rest is OK.
{noformat}
> Task :test
org.apache.ofbiz.base.util.cache.UtilCacheTests > testCreateUtilCache FAILED
java.lang.ClassCastException at UtilCacheTests.java:216
org.apache.ofbiz.base.util.cache.UtilCacheTests > testPutIfAbsent FAILED
java.lang.ClassCastException at UtilCacheTests.java:184
org.apache.ofbiz.base.util.cache.UtilCacheTests > testPutIfAbsentAndGet FAILED
java.lang.ClassCastException at UtilCacheTests.java:184
org.apache.ofbiz.base.util.cache.UtilCacheTests > testExpire FAILED
java.lang.ClassCastException at UtilCacheTests.java:184
org.apache.ofbiz.base.util.cache.UtilCacheTests > testSimple FAILED
java.lang.ClassCastException at UtilCacheTests.java:184
org.apache.ofbiz.base.util.cache.UtilCacheTests > testChangeMemSize FAILED
java.lang.ClassCastException at UtilCacheTests.java:184
for UtilCacheTests to
{noformat}
Only for these specific cases we would need to create a UtilCacheAsMap class to
set the inner memoryTable as a Map using asMap() method.
Let's summarize the OOTB situation: because of maxInMemory parameter, UtilCache
never uses CLHM (Caffeine in our case) but in UtilCacheTests
Here are the options:
# Using Caffeine, we create a specific UtilCacheAsMap class, only to satisfy
UtilCacheTests
# We remove both CLHM from UtilCache and UtilCacheTests
# We let things as they are
# is complicated for no OOTB gains, and I guess even for users (Adam no longer
seems to worry about OFBiz)
# is cleaner but needs some work and could annoy some old users migration
# seems the best option to me
Here is the patch [^OFBIZ-6747.patch]
> Replace ConcurrentLinkedHashMap by Caffeine
> ---
>
> Key: OFBIZ-6747
> URL: https://issues.apache.org/jira/browse/OFBIZ-6747
> Project: OFBiz
> Issue Type: Improvement
> Components: framework/base, framework/service
>Affects Versions: Upcoming Branch
>Reporter: Ben Manes
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-6747.patch
>
>
> Similar to OFBIZ-3779, please consider upgrading the library used by
> [UtilCache|https://github.com/apache/ofbiz/blob/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/cache/UtilCache.java]
> (v1.2). The current version is 1.4.2 and is the last major release planned.
> The preferable alternative would be to upgrade to
> [Caffeine|https://github.com/ben-manes/caffeine]. This is a Java 8 rewrite
> based on what I've learned since developing CLHM and Guava's cache. As
> expected it provides [superior
> performance|https://github.com/ben-manes/caffeine/wiki/Benchmarks]. It also
> provides a [near
> optimal|https://github.com/ben-manes/caffeine/wiki/Efficiency] eviction
> policy.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (OFBIZ-6747) Replace ConcurrentLinkedHashMap by Caffeine
[ https://issues.apache.org/jira/browse/OFBIZ-6747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-6747: --- Attachment: OFBIZ-6747.patch > Replace ConcurrentLinkedHashMap by Caffeine > --- > > Key: OFBIZ-6747 > URL: https://issues.apache.org/jira/browse/OFBIZ-6747 > Project: OFBiz > Issue Type: Improvement > Components: framework/base, framework/service >Affects Versions: Upcoming Branch >Reporter: Ben Manes >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-6747.patch > > > Similar to OFBIZ-3779, please consider upgrading the library used by > [UtilCache|https://github.com/apache/ofbiz/blob/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/cache/UtilCache.java] > (v1.2). The current version is 1.4.2 and is the last major release planned. > The preferable alternative would be to upgrade to > [Caffeine|https://github.com/ben-manes/caffeine]. This is a Java 8 rewrite > based on what I've learned since developing CLHM and Guava's cache. As > expected it provides [superior > performance|https://github.com/ben-manes/caffeine/wiki/Benchmarks]. It also > provides a [near > optimal|https://github.com/ben-manes/caffeine/wiki/Efficiency] eviction > policy. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12659) Lookups: No result option should not be selectable
[ https://issues.apache.org/jira/browse/OFBIZ-12659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620321#comment-17620321 ] Florian Motteau commented on OFBIZ-12659: - ...and Néréide has accents, even in all caps :D ! !image-2022-10-19-14-26-49-350.png! > Lookups: No result option should not be selectable > -- > > Key: OFBIZ-12659 > URL: https://issues.apache.org/jira/browse/OFBIZ-12659 > Project: OFBiz > Issue Type: Bug > Components: themes >Affects Versions: 18.12.05, 22.01.01, Upcoming Branch >Reporter: Florian Motteau >Assignee: Jacques Le Roux >Priority: Minor > Attachments: OFBIZ-12659.patch, image-2022-10-19-14-26-49-350.png, > lookups-no-record-found.mp4 > > > On lookups, if the search request returns nothing, we have a dropdown with > only one option : "No records found". > This option is selectable, and when the user clicks it the input is filled > with the string "No records found". When the form is submitted, this value is > submitted as well. > The "No records found" option should not be selectable, it should not be > possible to submit the field with this value. When clicking on this option, > we could either : > * leave the input with its previous value (do nothing) > * empty the input -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-12659) Lookups: No result option should not be selectable
[ https://issues.apache.org/jira/browse/OFBIZ-12659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Florian Motteau updated OFBIZ-12659: Attachment: image-2022-10-19-14-26-49-350.png > Lookups: No result option should not be selectable > -- > > Key: OFBIZ-12659 > URL: https://issues.apache.org/jira/browse/OFBIZ-12659 > Project: OFBiz > Issue Type: Bug > Components: themes >Affects Versions: 18.12.05, 22.01.01, Upcoming Branch >Reporter: Florian Motteau >Assignee: Jacques Le Roux >Priority: Minor > Attachments: OFBIZ-12659.patch, image-2022-10-19-14-26-49-350.png, > lookups-no-record-found.mp4 > > > On lookups, if the search request returns nothing, we have a dropdown with > only one option : "No records found". > This option is selectable, and when the user clicks it the input is filled > with the string "No records found". When the form is submitted, this value is > submitted as well. > The "No records found" option should not be selectable, it should not be > possible to submit the field with this value. When clicking on this option, > we could either : > * leave the input with its previous value (do nothing) > * empty the input -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12659) Lookups: No result option should not be selectable
[
https://issues.apache.org/jira/browse/OFBIZ-12659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620316#comment-17620316
]
Florian Motteau commented on OFBIZ-12659:
-
Thanks for the review/approval [~jleroux] ! I'll try to figure out why the PR
description is not always included in the commit message. OK for the Jira id in
the commit message.
{quote}I tried to assign you as FloMo or using "Florian Motteau" to no avail.
I'm not sure why. Please try yourself, TIA
{quote}
You mean to assign this Jira to me (I don't have the permission to assign
tickets AFAIK) ? On Github I'm "florianMo", here I'm "FloMo"
> Lookups: No result option should not be selectable
> --
>
> Key: OFBIZ-12659
> URL: https://issues.apache.org/jira/browse/OFBIZ-12659
> Project: OFBiz
> Issue Type: Bug
> Components: themes
>Affects Versions: 18.12.05, 22.01.01, Upcoming Branch
>Reporter: Florian Motteau
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: OFBIZ-12659.patch, lookups-no-record-found.mp4
>
>
> On lookups, if the search request returns nothing, we have a dropdown with
> only one option : "No records found".
> This option is selectable, and when the user clicks it the input is filled
> with the string "No records found". When the form is submitted, this value is
> submitted as well.
> The "No records found" option should not be selectable, it should not be
> possible to submit the field with this value. When clicking on this option,
> we could either :
> * leave the input with its previous value (do nothing)
> * empty the input
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-12659) Lookups: No result option should not be selectable
[ https://issues.apache.org/jira/browse/OFBIZ-12659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620289#comment-17620289 ] Jacques Le Roux commented on OFBIZ-12659: - Also Florian, I tried to assign you as FloMo or using "Florian Motteau" to no avail. I'm not sure why. Please try yourself, TIA > Lookups: No result option should not be selectable > -- > > Key: OFBIZ-12659 > URL: https://issues.apache.org/jira/browse/OFBIZ-12659 > Project: OFBiz > Issue Type: Bug > Components: themes >Affects Versions: 18.12.05, 22.01.01, Upcoming Branch >Reporter: Florian Motteau >Assignee: Jacques Le Roux >Priority: Minor > Attachments: OFBIZ-12659.patch, lookups-no-record-found.mp4 > > > On lookups, if the search request returns nothing, we have a dropdown with > only one option : "No records found". > This option is selectable, and when the user clicks it the input is filled > with the string "No records found". When the form is submitted, this value is > submitted as well. > The "No records found" option should not be selectable, it should not be > possible to submit the field with this value. When clicking on this option, > we could either : > * leave the input with its previous value (do nothing) > * empty the input -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12659) Lookups: No result option should not be selectable
[
https://issues.apache.org/jira/browse/OFBIZ-12659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620286#comment-17620286
]
Jacques Le Roux commented on OFBIZ-12659:
-
I pushed the PR and will backport from there.
I thought that the commit message would content what is in the GH issue
description, ie
{quote}
Improved: Make lookup's no result message not selectable
(OFBIZ-12659)
Explanation
On lookups, the "No result" dropdown option should no be selectable. With this
PR, clicking on "No result" empties the input (removes the search text).
See
https://issues.apache.org/jira/secure/attachment/13045667/lookups-no-record-found.mp4
Thanks: Nereide Team (actually Nereide as no accent, if I'm right ;) )
{quote}
But actually only the title was there:
bq. Improved: Make lookup's no result message not selectable #553
So here I copy some more information from the commit (not the code part)
{quote}
the following commit(s) were added to refs/heads/trunk by this push:
new a7f5a03845 Improved: Make lookup's no result message not selectable
(#553)
a7f5a03845 is described below
commit
[a7f5a03845500a513897f7a8d815a48a447749f2|https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;a=commit;h=a7f5a03845500a513897f7a8d815a48a447749f2]
Author: Florian Motteau
AuthorDate: Wed Oct 19 13:41:01 2022 +0200
Improved: Make lookup's no result message not selectable (#553)
{quote}
This is stil obscure to me. Sometimes the description is incluced when you push
a PR, sometimes not?
Anyway better to always include the Jira ref in the title to be sure that it
will be intercepted and included as a Jira comment.
> Lookups: No result option should not be selectable
> --
>
> Key: OFBIZ-12659
> URL: https://issues.apache.org/jira/browse/OFBIZ-12659
> Project: OFBiz
> Issue Type: Bug
> Components: themes
>Affects Versions: 18.12.05, 22.01.01, Upcoming Branch
>Reporter: Florian Motteau
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: OFBIZ-12659.patch, lookups-no-record-found.mp4
>
>
> On lookups, if the search request returns nothing, we have a dropdown with
> only one option : "No records found".
> This option is selectable, and when the user clicks it the input is filled
> with the string "No records found". When the form is submitted, this value is
> submitted as well.
> The "No records found" option should not be selectable, it should not be
> possible to submit the field with this value. When clicking on this option,
> we could either :
> * leave the input with its previous value (do nothing)
> * empty the input
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (OFBIZ-12659) Lookups: No result option should not be selectable
[ https://issues.apache.org/jira/browse/OFBIZ-12659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-12659: --- Assignee: Jacques Le Roux > Lookups: No result option should not be selectable > -- > > Key: OFBIZ-12659 > URL: https://issues.apache.org/jira/browse/OFBIZ-12659 > Project: OFBiz > Issue Type: Bug > Components: themes >Affects Versions: 18.12.05, 22.01.01, Upcoming Branch >Reporter: Florian Motteau >Assignee: Jacques Le Roux >Priority: Minor > Attachments: OFBIZ-12659.patch, lookups-no-record-found.mp4 > > > On lookups, if the search request returns nothing, we have a dropdown with > only one option : "No records found". > This option is selectable, and when the user clicks it the input is filled > with the string "No records found". When the form is submitted, this value is > submitted as well. > The "No records found" option should not be selectable, it should not be > possible to submit the field with this value. When clicking on this option, > we could either : > * leave the input with its previous value (do nothing) > * empty the input -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [ofbiz-framework] JacquesLeRoux merged pull request #553: Improved: Make lookup's no result message not selectable
JacquesLeRoux merged PR #553: URL: https://github.com/apache/ofbiz-framework/pull/553 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #553: Improved: Make lookup's no result message not selectable
JacquesLeRoux commented on PR #553: URL: https://github.com/apache/ofbiz-framework/pull/553#issuecomment-1283872897 I tested, it works :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-6747) Replace ConcurrentLinkedHashMap by Caffeine
[ https://issues.apache.org/jira/browse/OFBIZ-6747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620078#comment-17620078 ] Jacques Le Roux commented on OFBIZ-6747: Forgot to mention that I fixed the EntityPerformanceTest.groovy error in log with OFBIZ-12706 > Replace ConcurrentLinkedHashMap by Caffeine > --- > > Key: OFBIZ-6747 > URL: https://issues.apache.org/jira/browse/OFBIZ-6747 > Project: OFBiz > Issue Type: Improvement > Components: framework/base, framework/service >Affects Versions: Upcoming Branch >Reporter: Ben Manes >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > Similar to OFBIZ-3779, please consider upgrading the library used by > [UtilCache|https://github.com/apache/ofbiz/blob/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/cache/UtilCache.java] > (v1.2). The current version is 1.4.2 and is the last major release planned. > The preferable alternative would be to upgrade to > [Caffeine|https://github.com/ben-manes/caffeine]. This is a Java 8 rewrite > based on what I've learned since developing CLHM and Guava's cache. As > expected it provides [superior > performance|https://github.com/ben-manes/caffeine/wiki/Benchmarks]. It also > provides a [near > optimal|https://github.com/ben-manes/caffeine/wiki/Efficiency] eviction > policy. -- This message was sent by Atlassian Jira (v8.20.10#820010)
