[jira] [Closed] (OFBIZ-12749) Use non string parameters on a update-area failed when comme from a JWToken
[ https://issues.apache.org/jira/browse/OFBIZ-12749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin closed OFBIZ-12749. - Resolution: Fixed > Use non string parameters on a update-area failed when comme from a JWToken > --- > > Key: OFBIZ-12749 > URL: https://issues.apache.org/jira/browse/OFBIZ-12749 > Project: OFBiz > Issue Type: Bug >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > > When define a update-area with some parameters as List or Map the conversion > failed due to a bad management of this case when the creation come from a > JWToken. > {code:xml} > > > > > > > > > {code} > The link generate for the callback contains the variable myField with the > class name and not serialized List "{_}['myCase']"{_} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: 41c0c9e0bdb2a9568092d78e75f3f757e3592dd4 / Jacques Le Roux Improved: Fixed: Use non string parameters on a update-area failed when comme from a JWToken (OFBIZ-12749) Fixes a typo that annoys checkstyle: <> Report URL: https://github.com/apache/ofbiz-framework/actions/runs/4026953407 With regards, GitHub Actions via GitBox
[jira] [Assigned] (OFBIZ-12749) Use non string parameters on a update-area failed when comme from a JWToken
[ https://issues.apache.org/jira/browse/OFBIZ-12749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-12749: --- Assignee: Nicolas Malin > Use non string parameters on a update-area failed when comme from a JWToken > --- > > Key: OFBIZ-12749 > URL: https://issues.apache.org/jira/browse/OFBIZ-12749 > Project: OFBiz > Issue Type: Bug >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > > When define a update-area with some parameters as List or Map the conversion > failed due to a bad management of this case when the creation come from a > JWToken. > {code:xml} > > > > > > > > > {code} > The link generate for the callback contains the variable myField with the > class name and not serialized List "{_}['myCase']"{_} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12749) Use non string parameters on a update-area failed when comme from a JWToken
[ https://issues.apache.org/jira/browse/OFBIZ-12749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17681426#comment-17681426 ] ASF subversion and git services commented on OFBIZ-12749: - Commit 41c0c9e0bdb2a9568092d78e75f3f757e3592dd4 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=41c0c9e0bd ] Improved: Fixed: Use non string parameters on a update-area failed when comme from a JWToken (OFBIZ-12749) Fixes a typo that annoys checkstyle: <> > Use non string parameters on a update-area failed when comme from a JWToken > --- > > Key: OFBIZ-12749 > URL: https://issues.apache.org/jira/browse/OFBIZ-12749 > Project: OFBiz > Issue Type: Bug >Reporter: Nicolas Malin >Priority: Minor > > When define a update-area with some parameters as List or Map the conversion > failed due to a bad management of this case when the creation come from a > JWToken. > {code:xml} > > > > > > > > > {code} > The link generate for the callback contains the variable myField with the > class name and not serialized List "{_}['myCase']"{_} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user nmalin (triggered by nmalin). Head commit for run: aaee98002e34b68da214a16d35ffc4372979b18d / Nicolas Malin Fixed: Use non string parameters on a update-area failed when comme from a JWToken (OFBIZ-12749) When define a update-area with some parameters as List or Map the conversion failed due to a bad management of this case when the creation come from a JWToken. The link generate for the callback contains the variable myField with the class name and not serialized List "['myCase']" Report URL: https://github.com/apache/ofbiz-framework/actions/runs/4026312359 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework] gilPts commented on a diff in pull request #517: Codenarc integration
gilPts commented on code in PR #517: URL: https://github.com/apache/ofbiz-framework/pull/517#discussion_r1089174447 ## framework/webtools/src/main/groovy/org/apache/ofbiz/webtools/log/FetchLogs.groovy: ## @@ -16,23 +16,22 @@ * specific language governing permissions and limitations Review Comment: Reviewed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] gilPts commented on a diff in pull request #517: Codenarc integration
gilPts commented on code in PR #517: URL: https://github.com/apache/ofbiz-framework/pull/517#discussion_r1089173659 ## settings.gradle: ## @@ -20,8 +20,8 @@ apply from: 'common.gradle' Review Comment: Reviewed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-12749) Use non string parameters on a update-area failed when comme from a JWToken
[ https://issues.apache.org/jira/browse/OFBIZ-12749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17681397#comment-17681397 ] ASF subversion and git services commented on OFBIZ-12749: - Commit aaee98002e34b68da214a16d35ffc4372979b18d in ofbiz-framework's branch refs/heads/trunk from Nicolas Malin [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=aaee98002e ] Fixed: Use non string parameters on a update-area failed when comme from a JWToken (OFBIZ-12749) When define a update-area with some parameters as List or Map the conversion failed due to a bad management of this case when the creation come from a JWToken. The link generate for the callback contains the variable myField with the class name and not serialized List "['myCase']" > Use non string parameters on a update-area failed when comme from a JWToken > --- > > Key: OFBIZ-12749 > URL: https://issues.apache.org/jira/browse/OFBIZ-12749 > Project: OFBiz > Issue Type: Bug >Reporter: Nicolas Malin >Priority: Minor > > When define a update-area with some parameters as List or Map the conversion > failed due to a bad management of this case when the creation come from a > JWToken. > {code:xml} > > > > > > > > > {code} > The link generate for the callback contains the variable myField with the > class name and not serialized List "{_}['myCase']"{_} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [ofbiz-framework] gilPts commented on a diff in pull request #517: Codenarc integration
gilPts commented on code in PR #517: URL: https://github.com/apache/ofbiz-framework/pull/517#discussion_r1089171839 ## applications/accounting/groovyScripts/admin/FilterOutReceipts.groovy: ## @@ -20,4 +20,4 @@ Review Comment: Reviewed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] gilPts commented on a diff in pull request #517: Codenarc integration
gilPts commented on code in PR #517: URL: https://github.com/apache/ofbiz-framework/pull/517#discussion_r1089170827 ## applications/accounting/groovyScripts/admin/AcctgAdminServices.groovy: ## @@ -25,45 +25,47 @@ import org.apache.ofbiz.entity.GenericValue import org.apache.ofbiz.entity.util.EntityUtil Review Comment: Reviewed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] gilPts commented on a diff in pull request #517: Codenarc integration
gilPts commented on code in PR #517: URL: https://github.com/apache/ofbiz-framework/pull/517#discussion_r1089170578 ## applications/accounting/groovyScripts/admin/ListInvoiceItemTypesGlAccount.groovy: ## @@ -20,8 +20,8 @@ import org.apache.ofbiz.entity.condition.EntityConditionBuilder Review Comment: Reviewed by @danwatford -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user gilPts (triggered by gilPts). Head commit for run: 217c5a5225682c797f61aed242236284c3fb4382 / Gil Portenseigne Improved: apply codenarc rules to new RequirementServices.groovy script Report URL: https://github.com/apache/ofbiz-framework/actions/runs/4026159805 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #517: Codenarc integration
sonarcloud[bot] commented on PR #517: URL: https://github.com/apache/ofbiz-framework/pull/517#issuecomment-1406709243 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=517) [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=517=false=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=517=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=517=false=BUG) [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=517=false=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=517=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=517=false=VULNERABILITY) [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=517=false=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=517=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=517=false=SECURITY_HOTSPOT) [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=517=false=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=517=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=517=false=CODE_SMELL) [![No Coverage information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png 'No Coverage information')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=517) No Coverage information [![2.1%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '2.1%')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=517=new_duplicated_lines_density=list) [2.1% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=517=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user gilPts (triggered by gilPts). Head commit for run: c80896ea7ec0db2956aa9f6fdda52039589f3ba1 / Gil Portenseigne Revert "Add commented text report type for codenarc" This reverts commit d2396ea601cc8deacbb5c8f351fabdb4b1fcabc9. Report URL: https://github.com/apache/ofbiz-framework/actions/runs/4025837603 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #517: Codenarc integration
sonarcloud[bot] commented on PR #517: URL: https://github.com/apache/ofbiz-framework/pull/517#issuecomment-1406657687 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=517) [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=517=false=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=517=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=517=false=BUG) [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=517=false=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=517=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=517=false=VULNERABILITY) [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=517=false=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=517=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=517=false=SECURITY_HOTSPOT) [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=517=false=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=517=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=517=false=CODE_SMELL) [![No Coverage information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png 'No Coverage information')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=517) No Coverage information [![2.1%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '2.1%')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=517=new_duplicated_lines_density=list) [2.1% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=517=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] gilPts commented on a diff in pull request #517: Codenarc integration
gilPts commented on code in PR #517: URL: https://github.com/apache/ofbiz-framework/pull/517#discussion_r1088742354 ## applications/accounting/groovyScripts/admin/ListInvoiceItemTypesGlAccount.groovy: ## @@ -30,25 +30,25 @@ invoiceItemTypes = from('InvoiceItemType').where(exprBldr.LIKE(invoiceItemTypeId context.invoiceItemTypes = invoiceItemTypes.collect { invoiceItemType -> defaultAccount = true glAccount = null -invoiceItemTypeOrgs = invoiceItemType.getRelated("InvoiceItemTypeGlAccount", [organizationPartyId : organizationPartyId], null, false) +invoiceItemTypeOrgs = invoiceItemType.getRelated('InvoiceItemTypeGlAccount', [organizationPartyId: organizationPartyId], null, false) overrideGlAccountId = null if (invoiceItemTypeOrgs) { invoiceItemTypeOrg = invoiceItemTypeOrgs[0] overrideGlAccountId = invoiceItemTypeOrg.glAccountId -glAccounts = invoiceItemTypeOrg.getRelated("GlAccount", null, null, false) +glAccounts = invoiceItemTypeOrg.getRelated('GlAccount', null, null, false) if (glAccounts) { glAccount = glAccounts[0] defaultAccount = false } } else { -glAccount = invoiceItemType.getRelatedOne("DefaultGlAccount", false) +glAccount = invoiceItemType.getRelatedOne('DefaultGlAccount', false) } -return [invoiceItemTypeId : invoiceItemType.invoiceItemTypeId, - description : invoiceItemType.description, - defaultGlAccountId : invoiceItemType.defaultGlAccountId, - overrideGlAccountId : overrideGlAccountId, - defaultAccount : defaultAccount, - activeGlDescription : glAccount?.accountName] +return [invoiceItemTypeId: invoiceItemType.invoiceItemTypeId, +description: invoiceItemType.description, +defaultGlAccountId: invoiceItemType.defaultGlAccountId, +overrideGlAccountId: overrideGlAccountId, +defaultAccount: defaultAccount, +activeGlDescriptio: glAccount?.accountName] Review Comment: Nice Catch, Thanks :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org