[jira] [Created] (OFBIZ-9374) Fix TemporalExpressions.Frequency to avoid moving job start times away from given freqCount raster
Tobias Laufkötter created OFBIZ-9374:
Summary: Fix TemporalExpressions.Frequency to avoid moving job
start times away from given freqCount raster
Key: OFBIZ-9374
URL: https://issues.apache.org/jira/browse/OFBIZ-9374
Project: OFBiz
Issue Type: Bug
Components: framework
Affects Versions: Trunk
Reporter: Tobias Laufkötter
If a job is scheduled using TemporalExpressions.Frequency the start time of the
job will gradually move forward when the excecution of the job is delayed by
one or more units of the frequency type.
Example: Job is set up to start at 2017-01-01 00:00:00 and run every ten
minutes. One month later due to some circumstances the job starts at 2017-02-01
00:01:01 which results in the next execution to be scheduled at 2017-02-01
01:11:00 in stead of 2017-02-01 01:10:00.
The reason behind this behaviour is the
TemporalExpressions.Frequency#prepareCal function. It has the purpose to jump
from the first starting time to the latest possible execution of the job. But
instead it just sets it to the current time (with the precision of the chosen
frequency type) and calculates the next execution time from this point.
{code:title=Frequencies.java}
protected Calendar prepareCal(Calendar cal) {
protected Calendar prepareCal(Calendar cal) {
// Performs a "sane" skip forward in time - avoids time consuming
loops
// like incrementing every second from Jan 1 2000 until today
Calendar skip = (Calendar) cal.clone();
skip.setTime(this.start);
long deltaMillis = cal.getTimeInMillis() - this.start.getTime();
if (deltaMillis < 1000) {
return skip;
}
long divisor = deltaMillis;
if (this.freqType == Calendar.DAY_OF_MONTH) {
divisor = 8640;
} else if (this.freqType == Calendar.HOUR) {
divisor = 360;
} else if (this.freqType == Calendar.MINUTE) {
divisor = 6;
} else if (this.freqType == Calendar.SECOND) {
divisor = 1000;
} else {
return skip;
}
float units = deltaMillis / divisor;
units = (units / this.freqCount) * this.freqCount;
skip.add(this.freqType, (int)units);
while (skip.after(cal)) {
skip.add(this.freqType, -this.freqCount);
}
return skip;
}
{code}
The error is at {{units = (units / this.freqCount) * this.freqCount;}}. This is
no operation. What should have been done (and to me it looks like this was the
intention), is a substraction of the remainder of an integer division of
{{units}} and {{this.freqCount}} to get the number of units of the frequency
type that have passed since the first start time.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (OFBIZ-9374) Fix TemporalExpressions.Frequency to avoid moving job start times away from given freqCount raster
[
https://issues.apache.org/jira/browse/OFBIZ-9374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tobias Laufkötter updated OFBIZ-9374:
-
Attachment: OFBIZ-9374.patch
> Fix TemporalExpressions.Frequency to avoid moving job start times away from
> given freqCount raster
> ---
>
> Key: OFBIZ-9374
> URL: https://issues.apache.org/jira/browse/OFBIZ-9374
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Trunk
>Reporter: Tobias Laufkötter
> Attachments: OFBIZ-9374.patch
>
>
> If a job is scheduled using TemporalExpressions.Frequency the start time of
> the job will gradually move forward when the excecution of the job is delayed
> by one or more units of the frequency type.
> Example: Job is set up to start at 2017-01-01 00:00:00 and run every ten
> minutes. One month later due to some circumstances the job starts at
> 2017-02-01 00:01:01 which results in the next execution to be scheduled at
> 2017-02-01 01:11:00 in stead of 2017-02-01 01:10:00.
> The reason behind this behaviour is the
> TemporalExpressions.Frequency#prepareCal function. It has the purpose to jump
> from the first starting time to the latest possible execution of the job. But
> instead it just sets it to the current time (with the precision of the chosen
> frequency type) and calculates the next execution time from this point.
> {code:title=Frequencies.java}
> protected Calendar prepareCal(Calendar cal) {
> protected Calendar prepareCal(Calendar cal) {
> // Performs a "sane" skip forward in time - avoids time consuming
> loops
> // like incrementing every second from Jan 1 2000 until today
> Calendar skip = (Calendar) cal.clone();
> skip.setTime(this.start);
> long deltaMillis = cal.getTimeInMillis() - this.start.getTime();
> if (deltaMillis < 1000) {
> return skip;
> }
> long divisor = deltaMillis;
> if (this.freqType == Calendar.DAY_OF_MONTH) {
> divisor = 8640;
> } else if (this.freqType == Calendar.HOUR) {
> divisor = 360;
> } else if (this.freqType == Calendar.MINUTE) {
> divisor = 6;
> } else if (this.freqType == Calendar.SECOND) {
> divisor = 1000;
> } else {
> return skip;
> }
> float units = deltaMillis / divisor;
> units = (units / this.freqCount) * this.freqCount;
> skip.add(this.freqType, (int)units);
> while (skip.after(cal)) {
> skip.add(this.freqType, -this.freqCount);
> }
> return skip;
> }
> {code}
> The error is at {{units = (units / this.freqCount) * this.freqCount;}}. This
> is no operation. What should have been done (and to me it looks like this was
> the intention), is a substraction of the remainder of an integer division of
> {{units}} and {{this.freqCount}} to get the number of units of the frequency
> type that have passed since the first start time.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (OFBIZ-9374) Fix TemporalExpressions.Frequency to avoid moving job start times away from given freqCount raster
[
https://issues.apache.org/jira/browse/OFBIZ-9374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tobias Laufkötter updated OFBIZ-9374:
-
Description:
If a job is scheduled using TemporalExpressions.Frequency the start time of the
job will gradually move forward when the excecution of the job is delayed by
one or more units of the frequency type.
Example: Job is set up to start at 2017-01-01 00:00:00 and run every ten
minutes. One month later due to some circumstances the job starts at 2017-02-01
00:01:01 which results in the next execution to be scheduled at 2017-02-01
01:11:00 in stead of 2017-02-01 01:10:00.
The reason behind this behaviour is the
TemporalExpressions.Frequency#prepareCal function. It has the purpose to jump
from the first starting time to the latest possible execution of the job. But
instead it just sets it to the current time (with the precision of the chosen
frequency type) and calculates the next execution time from this point.
{code:title=Frequencies.java}
protected Calendar prepareCal(Calendar cal) {
// Performs a "sane" skip forward in time - avoids time consuming
loops
// like incrementing every second from Jan 1 2000 until today
Calendar skip = (Calendar) cal.clone();
skip.setTime(this.start);
long deltaMillis = cal.getTimeInMillis() - this.start.getTime();
if (deltaMillis < 1000) {
return skip;
}
long divisor = deltaMillis;
if (this.freqType == Calendar.DAY_OF_MONTH) {
divisor = 8640;
} else if (this.freqType == Calendar.HOUR) {
divisor = 360;
} else if (this.freqType == Calendar.MINUTE) {
divisor = 6;
} else if (this.freqType == Calendar.SECOND) {
divisor = 1000;
} else {
return skip;
}
float units = deltaMillis / divisor;
units = (units / this.freqCount) * this.freqCount;
skip.add(this.freqType, (int)units);
while (skip.after(cal)) {
skip.add(this.freqType, -this.freqCount);
}
return skip;
}
{code}
The error is at {{units = (units / this.freqCount) * this.freqCount;}}. This is
no operation. What should have been done (and to me it looks like this was the
intention), is a substraction of the remainder of an integer division of
{{units}} and {{this.freqCount}} to get the number of units of the frequency
type that have passed since the first start time.
was:
If a job is scheduled using TemporalExpressions.Frequency the start time of the
job will gradually move forward when the excecution of the job is delayed by
one or more units of the frequency type.
Example: Job is set up to start at 2017-01-01 00:00:00 and run every ten
minutes. One month later due to some circumstances the job starts at 2017-02-01
00:01:01 which results in the next execution to be scheduled at 2017-02-01
01:11:00 in stead of 2017-02-01 01:10:00.
The reason behind this behaviour is the
TemporalExpressions.Frequency#prepareCal function. It has the purpose to jump
from the first starting time to the latest possible execution of the job. But
instead it just sets it to the current time (with the precision of the chosen
frequency type) and calculates the next execution time from this point.
{code:title=Frequencies.java}
protected Calendar prepareCal(Calendar cal) {
protected Calendar prepareCal(Calendar cal) {
// Performs a "sane" skip forward in time - avoids time consuming
loops
// like incrementing every second from Jan 1 2000 until today
Calendar skip = (Calendar) cal.clone();
skip.setTime(this.start);
long deltaMillis = cal.getTimeInMillis() - this.start.getTime();
if (deltaMillis < 1000) {
return skip;
}
long divisor = deltaMillis;
if (this.freqType == Calendar.DAY_OF_MONTH) {
divisor = 8640;
} else if (this.freqType == Calendar.HOUR) {
divisor = 360;
} else if (this.freqType == Calendar.MINUTE) {
divisor = 6;
} else if (this.freqType == Calendar.SECOND) {
divisor = 1000;
} else {
return skip;
}
float units = deltaMillis / divisor;
units = (units / this.freqCount) * this.freqCount;
skip.add(this.freqType, (int)units);
while (skip.after(cal)) {
skip.add(this.freqType, -this.freqCount);
}
return skip;
}
{code}
The error is at {{units = (units / this.freqCount) * this.freqCount;}}. This is
no operation. What should have been done (and to me it looks like thi
[jira] [Commented] (OFBIZ-9373) create new blog article entry error.
[ https://issues.apache.org/jira/browse/OFBIZ-9373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16019244#comment-16019244 ] Jacques Le Roux commented on OFBIZ-9373: Hi Yao, Yes it's a known problem related with http://svn.apache.org/viewvc?view=revision&revision=1759065 Recently in the context of [Flexible Report|https://blogs.apache.org/ofbiz/entry/the-birt-flexible-reports-a] I used the [OWASP Java HTML Sanitizer Project|https://www.owasp.org/index.php/OWASP_Java_HTML_Sanitizer_Project] to create and use a specific BIRT_FLEXIBLE_REPORT_POLICY used by encoder.sanitize() (HtmlEncoder type) in ContentWorker.renderContentAsText(). This allows for more flexibility than "any" or "none" when sanitizing or checking HTML code. We could use the PERMISSIVE_POLICY for the removed "safe" case or even allows to use a policy name for allow-html value. As soon as I'll get a chance I'll have a look at this idea. In the meantime if you believe you are safe to use "any" just do that. > create new blog article entry error. > > > Key: OFBIZ-9373 > URL: https://issues.apache.org/jira/browse/OFBIZ-9373 > Project: OFBiz > Issue Type: Bug > Components: content >Affects Versions: Trunk >Reporter: yao > > 1、when i try to create a new blog article, i get the following error message: > In field [articleData] less-than (<) and greater-than (>) > symbols are not allowed. > it seems that this field does not support html text ! > 2、after i use plain text for the field [articleData], when i post the form, i > get the following error message: > The following required parameter is missing: [IN] > [createElectronicText.dataResourceId]] > and i go through the code that handles the request and the log record, to > find that the following eca does not execute which causes the error: > > > > > > result-to-context="true"/> > > does the problem lies in the framework code ? -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (OFBIZ-9373) create new blog article entry error.
[ https://issues.apache.org/jira/browse/OFBIZ-9373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-9373: -- Assignee: Jacques Le Roux > create new blog article entry error. > > > Key: OFBIZ-9373 > URL: https://issues.apache.org/jira/browse/OFBIZ-9373 > Project: OFBiz > Issue Type: Bug > Components: content >Affects Versions: Trunk >Reporter: yao >Assignee: Jacques Le Roux > > 1、when i try to create a new blog article, i get the following error message: > In field [articleData] less-than (<) and greater-than (>) > symbols are not allowed. > it seems that this field does not support html text ! > 2、after i use plain text for the field [articleData], when i post the form, i > get the following error message: > The following required parameter is missing: [IN] > [createElectronicText.dataResourceId]] > and i go through the code that handles the request and the log record, to > find that the following eca does not execute which causes the error: > > > > > > result-to-context="true"/> > > does the problem lies in the framework code ? -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Closed] (OFBIZ-9279) Sort Links in Lookup for Owner Content Id causes unwanted behaviour on Find Content page
[ https://issues.apache.org/jira/browse/OFBIZ-9279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-9279. -- Resolution: Fixed Hi Aditya, I was not able to reproduce today, not sure what happened then. I close. > Sort Links in Lookup for Owner Content Id causes unwanted behaviour on Find > Content page > > > Key: OFBIZ-9279 > URL: https://issues.apache.org/jira/browse/OFBIZ-9279 > Project: OFBiz > Issue Type: Bug >Reporter: Aditya Sharma >Assignee: Aditya Sharma > Fix For: Upcoming Release, Release Branch 15.12, Release Branch > 14.12 > > Attachments: OFBIZ-9279.patch, screenshot-1.png > > > How to reproduce : > 1. Log in the Content component > 2. Go to the Content tab. https://localhost:8443/content/control/findContent > 3. In the search form, open the lookup of the field ' Owner Content Id ' > 4. Click on any of the table header links to sort the table. Results will be > displayed on a new unstyled window closing the Lookup dialog. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (OFBIZ-9279) Sort Links in Lookup for Owner Content Id causes unwanted behaviour on Find Content page
[ https://issues.apache.org/jira/browse/OFBIZ-9279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-9279: --- Fix Version/s: (was: Upcoming Release) 16.11.02 > Sort Links in Lookup for Owner Content Id causes unwanted behaviour on Find > Content page > > > Key: OFBIZ-9279 > URL: https://issues.apache.org/jira/browse/OFBIZ-9279 > Project: OFBiz > Issue Type: Bug >Reporter: Aditya Sharma >Assignee: Aditya Sharma > Fix For: Release Branch 14.12, Release Branch 15.12, 16.11.02 > > Attachments: OFBIZ-9279.patch, screenshot-1.png > > > How to reproduce : > 1. Log in the Content component > 2. Go to the Content tab. https://localhost:8443/content/control/findContent > 3. In the search form, open the lookup of the field ' Owner Content Id ' > 4. Click on any of the table header links to sort the table. Results will be > displayed on a new unstyled window closing the Lookup dialog. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Issue Comment Deleted] (OFBIZ-9351) Remove unnecessary field types
[
https://issues.apache.org/jira/browse/OFBIZ-9351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux updated OFBIZ-9351:
---
Comment: was deleted
(was: Replaced fields with "id-ne", "id-long-ne" and "id-vlong-ne" with "id",
"id-long" and "id-vlong" respectively which are primary keys.
The patch also covers the field names like "parentTypeId" as it will always be
empty for some record that starts the hierarchy.)
> Remove unnecessary field types
> --
>
> Key: OFBIZ-9351
> URL: https://issues.apache.org/jira/browse/OFBIZ-9351
> Project: OFBiz
> Issue Type: Task
>Reporter: Aditya Sharma
>Assignee: Aditya Sharma
>Priority: Trivial
> Attachments: OFBIZ-9351.patch, OFBIZ-9351_plugins.patch
>
>
> As discussed in http://markmail.org/message/d2tpovewhtotukwa the "not empty"
> field types ("id-ne", "id-long-ne" and "id-vlong-ne") were initially added
> to implement validations on data. But, because the validations where only
> implemented in some place like webtools, it contradicts the distinction to be
> upheld on various layers. So it is better to remove these field types. So we
> will remove all those field types and will create sub tickets to replace them
> in entity definitions by corresponding "id" types.
> When replacing the "not empty" field types in entity definitions by
> corresponding "id" types we will add a *not-null="true"* attribute to "makes
> the field NOT NULL on the database (like primary key fields)" as explained in
> "not-null" documentation in fieldtypemodel.xsd. We will finally clean the
> documentation of the "not-null" in fieldtypemodel.xsd.
> Related Links:
> http://ofbiz.135035.n4.nabble.com/EntityEngine-field-types-td2251546.html
> http://markmail.org/message/otec62xiwkpjttkq
> A more vivid description:
> http://ofbiz.markmail.org/thread/c6ee3ewyo6jpik7k
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Created] (OFBIZ-9375) Missing Java Option solr.log.dir. Logging may be missing or incomplete
Jacques Le Roux created OFBIZ-9375:
--
Summary: Missing Java Option solr.log.dir. Logging may be missing
or incomplete
Key: OFBIZ-9375
URL: https://issues.apache.org/jira/browse/OFBIZ-9375
Project: OFBiz
Issue Type: Improvement
Components: lucene, solr
Affects Versions: Trunk
Reporter: Jacques Le Roux
Assignee: Jacques Le Roux
Priority: Minor
Fix For: Upcoming Release
I noticed this error in trunk demo error.log
bq. 2017-05-16 03:05:38,898 |0.0.0.0-startStop-1 |StartupLoggingUtils
|E| Missing Java Option solr.log.dir. Logging may be missing or incomplete.
It's thrown by
https://github.com/apache/lucene-solr/blob/master/solr/core/src/java/org/apache/solr/servlet/StartupLoggingUtils.java
I can't see nothing at https://localhost:8443/solr/#/~logging
On dev ML Jinghai suggested to add
{code}
def jvmArguments = ['-Xms128M', '-Xmx1024M',
'-Dsolr.log.dir=runtime/logs',
'-Dsolr.log.level=INFO']
{code}
to main gradle. Taher mentionned that "The master build.gradle file should not
point to any plugins"
I put the same in both lucene and solr components build. gradle (Solrs relies
on Lucene but our usage is specific) and saw no drawbacks.
I must say I was not able to reproduce the "error" locally. But I anyway I
propose to commit in the 2 plugins to reassur people who could else wonder.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OFBIZ-9375) Missing Java Option solr.log.dir. Logging may be missing or incomplete
[
https://issues.apache.org/jira/browse/OFBIZ-9375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16019345#comment-16019345
]
Jacques Le Roux commented on OFBIZ-9375:
I did not create this issue as a bug because it's not really one though there
is an error showing in the log. But I'll not backport it because it's really
minor and has not other effects. Committed at revision: 1795781
> Missing Java Option solr.log.dir. Logging may be missing or incomplete
> --
>
> Key: OFBIZ-9375
> URL: https://issues.apache.org/jira/browse/OFBIZ-9375
> Project: OFBiz
> Issue Type: Improvement
> Components: lucene, solr
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Release
>
>
> I noticed this error in trunk demo error.log
> bq. 2017-05-16 03:05:38,898 |0.0.0.0-startStop-1 |StartupLoggingUtils
> |E| Missing Java Option solr.log.dir. Logging may be missing or incomplete.
> It's thrown by
> https://github.com/apache/lucene-solr/blob/master/solr/core/src/java/org/apache/solr/servlet/StartupLoggingUtils.java
> I can't see nothing at https://localhost:8443/solr/#/~logging
> On dev ML Jinghai suggested to add
> {code}
> def jvmArguments = ['-Xms128M', '-Xmx1024M',
> '-Dsolr.log.dir=runtime/logs',
> '-Dsolr.log.level=INFO']
> {code}
> to main gradle. Taher mentionned that "The master build.gradle file should
> not point to any plugins"
> I put the same in both lucene and solr components build. gradle (Solrs relies
> on Lucene but our usage is specific) and saw no drawbacks.
> I must say I was not able to reproduce the "error" locally. But I anyway I
> propose to commit in the 2 plugins to reassur people who could else wonder.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Closed] (OFBIZ-9375) Missing Java Option solr.log.dir. Logging may be missing or incomplete
[
https://issues.apache.org/jira/browse/OFBIZ-9375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux closed OFBIZ-9375.
--
Resolution: Implemented
> Missing Java Option solr.log.dir. Logging may be missing or incomplete
> --
>
> Key: OFBIZ-9375
> URL: https://issues.apache.org/jira/browse/OFBIZ-9375
> Project: OFBiz
> Issue Type: Improvement
> Components: lucene, solr
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Release
>
>
> I noticed this error in trunk demo error.log
> bq. 2017-05-16 03:05:38,898 |0.0.0.0-startStop-1 |StartupLoggingUtils
> |E| Missing Java Option solr.log.dir. Logging may be missing or incomplete.
> It's thrown by
> https://github.com/apache/lucene-solr/blob/master/solr/core/src/java/org/apache/solr/servlet/StartupLoggingUtils.java
> I can't see nothing at https://localhost:8443/solr/#/~logging
> On dev ML Jinghai suggested to add
> {code}
> def jvmArguments = ['-Xms128M', '-Xmx1024M',
> '-Dsolr.log.dir=runtime/logs',
> '-Dsolr.log.level=INFO']
> {code}
> to main gradle. Taher mentionned that "The master build.gradle file should
> not point to any plugins"
> I put the same in both lucene and solr components build. gradle (Solrs relies
> on Lucene but our usage is specific) and saw no drawbacks.
> I must say I was not able to reproduce the "error" locally. But I anyway I
> propose to commit in the 2 plugins to reassur people who could else wonder.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OFBIZ-9255) The Tax information have not been filled for "Tax adjustment due to order change" in service recalcTaxTotal
[ https://issues.apache.org/jira/browse/OFBIZ-9255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16019356#comment-16019356 ] Jacques Le Roux commented on OFBIZ-9255: Hi Marie-Aline, I don't know if your read the threas referenced above, but a majority would prefer to have a complete solution. Thanks for this start! > The Tax information have not been filled for "Tax adjustment due to order > change" in service recalcTaxTotal > --- > > Key: OFBIZ-9255 > URL: https://issues.apache.org/jira/browse/OFBIZ-9255 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Release Branch 13.07, Trunk > Environment: Xubuntu, POSTGRES >Reporter: Marie-Aline Pantais >Assignee: Jacques Le Roux > Attachments: Capture d’écran_2017-03-14_15-34-13.png, OFBIZ-9255.patch > > > As per example, when you remove carrier cost and modify it a new line is > created in OrderAjustment mentioning "Tax adjustment due to order change" in > the description but Tax information as taxAuthorityRateSeqId, > sourcePercentage, taxAuthGeoId, taxAuthPartyId are not filled -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Comment Edited] (OFBIZ-9255) The Tax information have not been filled for "Tax adjustment due to order change" in service recalcTaxTotal
[ https://issues.apache.org/jira/browse/OFBIZ-9255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16019356#comment-16019356 ] Jacques Le Roux edited comment on OFBIZ-9255 at 5/22/17 9:24 AM: - Hi Marie-Aline, I don't know if your read the thread referenced above, but a majority would prefer to have a complete solution. Thanks for this start! was (Author: jacques.le.roux): Hi Marie-Aline, I don't know if your read the threas referenced above, but a majority would prefer to have a complete solution. Thanks for this start! > The Tax information have not been filled for "Tax adjustment due to order > change" in service recalcTaxTotal > --- > > Key: OFBIZ-9255 > URL: https://issues.apache.org/jira/browse/OFBIZ-9255 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Release Branch 13.07, Trunk > Environment: Xubuntu, POSTGRES >Reporter: Marie-Aline Pantais >Assignee: Jacques Le Roux > Attachments: Capture d’écran_2017-03-14_15-34-13.png, OFBIZ-9255.patch > > > As per example, when you remove carrier cost and modify it a new line is > created in OrderAjustment mentioning "Tax adjustment due to order change" in > the description but Tax information as taxAuthorityRateSeqId, > sourcePercentage, taxAuthGeoId, taxAuthPartyId are not filled -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9255) The Tax information have not been filled for "Tax adjustment due to order change" in service recalcTaxTotal
[ https://issues.apache.org/jira/browse/OFBIZ-9255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16019363#comment-16019363 ] Marie-Aline Pantais commented on OFBIZ-9255: Yes I read it. I think about but have not yet time to test a complete solution. I think for that we have to change the service. > The Tax information have not been filled for "Tax adjustment due to order > change" in service recalcTaxTotal > --- > > Key: OFBIZ-9255 > URL: https://issues.apache.org/jira/browse/OFBIZ-9255 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Release Branch 13.07, Trunk > Environment: Xubuntu, POSTGRES >Reporter: Marie-Aline Pantais >Assignee: Jacques Le Roux > Attachments: Capture d’écran_2017-03-14_15-34-13.png, OFBIZ-9255.patch > > > As per example, when you remove carrier cost and modify it a new line is > created in OrderAjustment mentioning "Tax adjustment due to order change" in > the description but Tax information as taxAuthorityRateSeqId, > sourcePercentage, taxAuthGeoId, taxAuthPartyId are not filled -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9373) create new blog article entry error.
[ https://issues.apache.org/jira/browse/OFBIZ-9373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16019559#comment-16019559 ] yao commented on OFBIZ-9373: Thanks ! and what about my second question ? When i post a new blog article , i get the following error message : The following required parameter is missing: [IN] [createElectronicText.dataResourceId]] I see that creating a blog article will invoke the "createElectronicText" service . This service uses an eca to check if the field [dataResourceId] is empty. If it's empty , then will invoke the "createDataResource" service first to get a dataResourceId . But it seems that the eca wasn't invoked, and give me the "dataResourceId missing" message. don't have a glue about how to solve it . Would you please help me with that or give me some advice. Thanks very much ! > create new blog article entry error. > > > Key: OFBIZ-9373 > URL: https://issues.apache.org/jira/browse/OFBIZ-9373 > Project: OFBiz > Issue Type: Bug > Components: content >Affects Versions: Trunk >Reporter: yao >Assignee: Jacques Le Roux > > 1、when i try to create a new blog article, i get the following error message: > In field [articleData] less-than (<) and greater-than (>) > symbols are not allowed. > it seems that this field does not support html text ! > 2、after i use plain text for the field [articleData], when i post the form, i > get the following error message: > The following required parameter is missing: [IN] > [createElectronicText.dataResourceId]] > and i go through the code that handles the request and the log record, to > find that the following eca does not execute which causes the error: > > > > > > result-to-context="true"/> > > does the problem lies in the framework code ? -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Closed] (OFBIZ-9370) FindProject page gives "EntityListIterator Not Closed" error in logs
[ https://issues.apache.org/jira/browse/OFBIZ-9370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-9370. -- Resolution: Duplicate Actually this duplicates OFBIZ-7406. > FindProject page gives "EntityListIterator Not Closed" error in logs > > > Key: OFBIZ-9370 > URL: https://issues.apache.org/jira/browse/OFBIZ-9370 > Project: OFBiz > Issue Type: Bug > Components: projectmgr >Reporter: Aditya Sharma >Assignee: Jacques Le Roux >Priority: Trivial > Attachments: screenshot-1.png, screenshot-2.png > > > Steps to reproduce: > 1. Go to Project component (https://localhost:8443/projectmgr/control/main) > 2. Click on Projects from > submenu.(https://localhost:8443/catalog/control/FindProject) > 3. Provide search preference and click on Find button. > 4. Observe the logs. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9369) Add order priority management on sale order creation
[ https://issues.apache.org/jira/browse/OFBIZ-9369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16019714#comment-16019714 ] Leila Mekika commented on OFBIZ-9369: - Thanks [~swash78] and [~pfm.smits] for your comments. [~swash78], yes, a "Sales Order Reservation Rules Guide" wiil be very useful ! [~pfm.smits], no , i didn't suggest to add it to the front (i agree this will be a problem).I think I just misunderstood your words about "importance of customer" :-D > Add order priority management on sale order creation > > > Key: OFBIZ-9369 > URL: https://issues.apache.org/jira/browse/OFBIZ-9369 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Leila Mekika >Priority: Minor > Attachments: OFBIZ-9369.patch > > > I made a patch to allow order priority setting when creating sale order. > This add option on order first step creation an add it to the OrderHeader > during creation so that reservation SECA is triggered. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (OFBIZ-9376) Add shipmentId list to quickshippurchaseorder return parameters
Gaudin Pierre created OFBIZ-9376: Summary: Add shipmentId list to quickshippurchaseorder return parameters Key: OFBIZ-9376 URL: https://issues.apache.org/jira/browse/OFBIZ-9376 Project: OFBiz Issue Type: Improvement Components: product Affects Versions: Trunk Reporter: Gaudin Pierre Priority: Minor The method " quickshippurchaseorder " allows to create a reception for every ship group of a purchasing order. This method works correctly but it does not return id of the receptions which it creates. The purpose of this patch is to modify the service so that it returns the list of the receptions which it creates To test this patch: - Create a purchase order with several ships groups - approve it - from webtools execute the service " quickshippurchaseorder " with the parameters: order Id: reference of order facilityId: WebStoreWarehouse results : The service returns the parameter shipmentIds -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (OFBIZ-9376) Add shipmentId list to quickshippurchaseorder return parameters
[ https://issues.apache.org/jira/browse/OFBIZ-9376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gaudin Pierre updated OFBIZ-9376: - Attachment: quickShipPurchaseOrder.patch > Add shipmentId list to quickshippurchaseorder return parameters > --- > > Key: OFBIZ-9376 > URL: https://issues.apache.org/jira/browse/OFBIZ-9376 > Project: OFBiz > Issue Type: Improvement > Components: product >Affects Versions: Trunk >Reporter: Gaudin Pierre >Priority: Minor > Attachments: quickShipPurchaseOrder.patch > > > The method " quickshippurchaseorder " allows to create a reception for every > ship group of a purchasing order. This method works correctly but it does not > return id of the receptions which it creates. The purpose of this patch is to > modify the service so that it returns the list of the receptions which it > creates > To test this patch: > - Create a purchase order with several ships groups > - approve it > - from webtools execute the service " quickshippurchaseorder " with the > parameters: order Id: reference of order facilityId: WebStoreWarehouse > results : > The service returns the parameter shipmentIds -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (OFBIZ-9377) fix tag "disable-if-empty" in menus if field has no value
Gaudin Pierre created OFBIZ-9377: Summary: fix tag "disable-if-empty" in menus if field has no value Key: OFBIZ-9377 URL: https://issues.apache.org/jira/browse/OFBIZ-9377 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Trunk Reporter: Gaudin Pierre Priority: Minor The purpose of this patch is to correct the behavior of the tag "disable-if-empty" in menus. Indeed in certain cases it happens that the value defines in "disable-if-empty" is present in the context but with no valuee. In this case the menu item is shown while it should be masked. This patch corrects it by testing if emptie and without value. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (OFBIZ-9376) Add shipmentId list to quickshippurchaseorder return parameters
[ https://issues.apache.org/jira/browse/OFBIZ-9376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gaudin Pierre updated OFBIZ-9376: - Attachment: (was: menu-disable-if-empty.patch) > Add shipmentId list to quickshippurchaseorder return parameters > --- > > Key: OFBIZ-9376 > URL: https://issues.apache.org/jira/browse/OFBIZ-9376 > Project: OFBiz > Issue Type: Improvement > Components: product >Affects Versions: Trunk >Reporter: Gaudin Pierre >Priority: Minor > Attachments: quickShipPurchaseOrder.patch > > > The method " quickshippurchaseorder " allows to create a reception for every > ship group of a purchasing order. This method works correctly but it does not > return id of the receptions which it creates. The purpose of this patch is to > modify the service so that it returns the list of the receptions which it > creates > To test this patch: > - Create a purchase order with several ships groups > - approve it > - from webtools execute the service " quickshippurchaseorder " with the > parameters: order Id: reference of order facilityId: WebStoreWarehouse > results : > The service returns the parameter shipmentIds -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (OFBIZ-9376) Add shipmentId list to quickshippurchaseorder return parameters
[ https://issues.apache.org/jira/browse/OFBIZ-9376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gaudin Pierre updated OFBIZ-9376: - Attachment: menu-disable-if-empty.patch > Add shipmentId list to quickshippurchaseorder return parameters > --- > > Key: OFBIZ-9376 > URL: https://issues.apache.org/jira/browse/OFBIZ-9376 > Project: OFBiz > Issue Type: Improvement > Components: product >Affects Versions: Trunk >Reporter: Gaudin Pierre >Priority: Minor > Attachments: quickShipPurchaseOrder.patch > > > The method " quickshippurchaseorder " allows to create a reception for every > ship group of a purchasing order. This method works correctly but it does not > return id of the receptions which it creates. The purpose of this patch is to > modify the service so that it returns the list of the receptions which it > creates > To test this patch: > - Create a purchase order with several ships groups > - approve it > - from webtools execute the service " quickshippurchaseorder " with the > parameters: order Id: reference of order facilityId: WebStoreWarehouse > results : > The service returns the parameter shipmentIds -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (OFBIZ-9377) fix tag "disable-if-empty" in menus if field has no value
[ https://issues.apache.org/jira/browse/OFBIZ-9377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gaudin Pierre updated OFBIZ-9377: - Attachment: menu-disable-if-empty.patch > fix tag "disable-if-empty" in menus if field has no value > - > > Key: OFBIZ-9377 > URL: https://issues.apache.org/jira/browse/OFBIZ-9377 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Gaudin Pierre >Priority: Minor > Attachments: menu-disable-if-empty.patch > > > The purpose of this patch is to correct the behavior of the tag > "disable-if-empty" in menus. Indeed in certain cases it happens that the > value defines in "disable-if-empty" is present in the context but with no > valuee. In this case the menu item is shown while it should be masked. This > patch corrects it by testing if emptie and without value. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (OFBIZ-9378) set auto completion only in lookup field
Gaudin Pierre created OFBIZ-9378: Summary: set auto completion only in lookup field Key: OFBIZ-9378 URL: https://issues.apache.org/jira/browse/OFBIZ-9378 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Gaudin Pierre Priority: Minor The puspose of this patch is to allow to generate only the auto-completion on a lookup and to remove lookup icon. Indeed, often the auto-completion is sufficient and the lookup of search is not used. By putting as value " autocompletion-only " in the attribute "presentation" of the tag " lookup ", only the auto-completion is active. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (OFBIZ-9378) set auto completion only in lookup field
[ https://issues.apache.org/jira/browse/OFBIZ-9378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gaudin Pierre updated OFBIZ-9378: - Attachment: lookup-autocompletion-only.patch > set auto completion only in lookup field > > > Key: OFBIZ-9378 > URL: https://issues.apache.org/jira/browse/OFBIZ-9378 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Gaudin Pierre >Priority: Minor > Attachments: lookup-autocompletion-only.patch > > > The puspose of this patch is to allow to generate only the auto-completion > on a lookup and to remove lookup icon. Indeed, often the auto-completion is > sufficient and the lookup of search is not used. By putting as value " > autocompletion-only " in the attribute "presentation" of the tag " lookup ", > only the auto-completion is active. > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
