[GitHub] incubator-rya pull request #303: RYA-135 Hard code triples collection
Github user isper3at closed the pull request at: https://github.com/apache/incubator-rya/pull/303 ---
[jira] [Commented] (RYA-135) Confusing configuration: CONF_TBL_PREFIX versus MONGO_COLLECTION_PREFIX versus RyaInstance
[
https://issues.apache.org/jira/browse/RYA-135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16630745#comment-16630745
]
ASF GitHub Bot commented on RYA-135:
Github user isper3at closed the pull request at:
https://github.com/apache/incubator-rya/pull/303
> Confusing configuration: CONF_TBL_PREFIX versus MONGO_COLLECTION_PREFIX
> versus RyaInstance
> ---
>
> Key: RYA-135
> URL: https://issues.apache.org/jira/browse/RYA-135
> Project: Rya
> Issue Type: Improvement
> Components: sail
>Reporter: David W. Lotts
>Assignee: Andrew Smith
>Priority: Minor
>
> These THREE constants [#1] [#2] [#3] are somewhat redundant. They are the
> the same as the Rya Instance in most cases. For MongoDB, the table
> prefix[#2] may be used incorrectly instead of the collection prefix[#1].
> They should probably be melded into one config key and method and be called
> the rya instance. The RyaDetails has this concept. There is a
> ConfigUtil.getTablePrefix() and TablePrefixLayoutStrategy.getTablePrefix()
> that should be refactored as part of this.
> Some have suggested that the collection prefix is not needed at all since it
> is scoped inside a single Mongo Database which contains only one rya instance.
> {anchor:1}1 {code} conf.set(MongoDBRdfConfiguration.MONGO_COLLECTION_PREFIX,
> "rya_");{code}
> {anchor:2}2 {code}conf.set(RdfCloudTripleStoreConfiguration.CONF_TBL_PREFIX,
> "rya_");{code}
> {anchor:3}3 {code}TablePrefixLayoutStrategy.tablePrefix =
> RdfCloudTripleStoreConstants.TBL_PRFX_DEF; // = "rya_";{code}
> Some unit tests set them as different values.
> Look at
> extras/indexing/src/main/java/mvm/rya/sail/config/RyaSailFactory.java around
> line 73 for a good example of the confusion. Look for this comment:
> // XXX Should(?) be MongoDBRdfConfiguration.MONGO_COLLECTION_PREFIX inside
> the if below.
> One more redundant field: TablePrefixLayoutStrategy.tablePrefix See RYA-138
> It is defaults to "rya_" but has a getter and setter.
> {code}
> TablePrefixLayoutStrategy implements TableLayoutStrategy{
> private String tablePrefix = RdfCloudTripleStoreConstants.TBL_PRFX_DEF;
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] incubator-rya issue #303: RYA-135 Hard code triples collection
Github user isper3at commented on the issue: https://github.com/apache/incubator-rya/pull/303 opening a new PR against RYA master after 3.x https://github.com/apache/incubator-rya/pull/300 is in ---
[GitHub] incubator-rya issue #304: RYA-501 Change guava Iterators to Collections
Github user isper3at commented on the issue: https://github.com/apache/incubator-rya/pull/304 Closing until the #302 is in ---
[GitHub] incubator-rya issue #302: RYA-501 Change guava Iterators to Collections
Github user asfgit commented on the issue: https://github.com/apache/incubator-rya/pull/302 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/778/ ---
[jira] [Commented] (RYA-501) Guava changed the Iterators api.
[ https://issues.apache.org/jira/browse/RYA-501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16630883#comment-16630883 ] ASF GitHub Bot commented on RYA-501: Github user asfgit commented on the issue: https://github.com/apache/incubator-rya/pull/302 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/778/ > Guava changed the Iterators api. > > > Key: RYA-501 > URL: https://issues.apache.org/jira/browse/RYA-501 > Project: Rya > Issue Type: Improvement >Reporter: Andrew Smith >Assignee: Andrew Smith >Priority: Trivial > > Guava changed scope of Iterators.emptyIterator(). > This can cause problems for anything that uses rya as a dependency or if rya > ever upgrades it's guava version. Java now has the Collections api with > emptyIterator. Changing to that will resolve this problem. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
