notmuch release 0.32.2 now available
Where to obtain notmuch 0.32.2 === https://notmuchmail.org/releases/notmuch-0.32.2.tar.xz Which can be verified with: https://notmuchmail.org/releases/notmuch-0.32.2.tar.xz.sha256.asc -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 8e0a7eb8ff2e6011ef48b2bf11d79b9c4bb74511cfe2987758b64898c2a2ded7 notmuch-0.32.2.tar.xz -BEGIN PGP SIGNATURE- iQIzBAEBCAAdFiEEkiyHYXwaY0SiY6fqA0U5G1WqFSEFAmDYa+MACgkQA0U5G1Wq FSEXkg//W+If8uUYk9PI82c9gnb+HyjMeosiAgJRTsh0PoyexMXLPqVvhP704uR5 eUMgl4ebb2ZUgk8qPVstzlJ7E+P7aLmz4O9RBT/yNEytC5AdAycouC6x5Snc3kvW Z9d7A6dc3Vkje9OVfKNhTpaYJg+MMIuVN8PGUKnAcR6a0RHI5IlZD9PWbGi2O+Hx wrKhh2vbhD/+2bGYOzNKoUwKlS7yNPh28hZDCAmLdMIbpZiegpp4l/Z8s52upOuM zk3WTMc3ThRz8+4oJeZM89oeJOpFZ06iks917VDKyJ2RnxpYaLOnAi4HBRBeUeMs Jt5NRFjFHqgxK7p37vaT4VZh9+ZBxDuyHs0xga9lSajmcsOzjs1N9HC4+LQJzPMj AOJFF8F/eABJW+Ov0AW/zqzgJBw56g7ToxJBwQ6+PyS334k/MbR82A+dP2kYjqMR lHUPBGZ7oHOiBDyosauGFCXkLv/Fu3DoJ5qoe42fBOImD7GbNm0+nT3nilTzrKHT 8lxeUwHl+Fwv0GzzbpuBfE7sSQAk64s+2sLECqBD35ZG0nfgJPy+Zi39Dm53VwXR 49XSZgZOSRnzVcuc+iePz8RJ25OtZUaxFiIducES5C9x8c+0gRaepwd00LIilWXF f/BAUQlHLantC2E31t5kmVYt8DYxDFTefm82fEnqHH8GjoOEcLU= =R3OX -END PGP SIGNATURE- https://notmuchmail.org/releases/notmuch-0.32.2.tar.xz.asc (signed by David Bremner) What's new in notmuch 0.32.2 = General --- Fix a bug from 2017 that can add duplicate thread-id terms to message documents. CLI --- Fix small memory leak in notmuch new. Emacs - Add `(require 'seq)` for `seq-some`. Documentation - Fix man page build for Sphinx 4.x. Fix variable name in emacs docs. Tests - Fix backup creation in `perf-test/T00-new`. Check openssl prerequisite in `add_gpgsm_home`. What is notmuch === Notmuch is a system for indexing, searching, reading, and tagging large collections of email messages in maildir or mh format. It uses the Xapian library to provide fast, full-text search with a convenient search syntax. For more about notmuch, see https://notmuchmail.org signature.asc Description: PGP signature ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
Re: [PATCH] emacs: Prefer email address over User ID when showing valid signature
On Sat 2021-06-26 13:41:44 -0300, David Bremner wrote: > From: Daniel Kahn Gillmor > > Most concrete verification steps are likely only taken on the e-mail > address in the first place, and e-mail addresses render more > intelligibly than arbitrary User IDs in the first place. > > Signed-off-by: Daniel Kahn Gillmor > Amended-by: db, apply dme restructuring suggestions. > --- > emacs/notmuch-crypto.el | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/emacs/notmuch-crypto.el b/emacs/notmuch-crypto.el > index db7cb75d..5edfe94c 100644 > --- a/emacs/notmuch-crypto.el > +++ b/emacs/notmuch-crypto.el > @@ -119,14 +119,14 @@ mode." > (cond > ((string= status "good") >(let ((fingerprint (concat "0x" (plist-get sigstatus :fingerprint))) > - (userid (plist-get sigstatus :userid))) > - ;; If userid is present it has full or greater validity. > - (if userid > - (progn > - (setq label (concat "Good signature by: " userid)) > - (setq face 'notmuch-crypto-signature-good)) > - (setq label (concat "Good signature by key: " fingerprint)) > - (setq face 'notmuch-crypto-signature-good-key)) > + (email-or-userid (or (plist-get sigstatus :email) > + (plist-get sigstatus :userid > + ;; If email or userid are present, they have full or greater validity. > + (setq label (concat "Good signature by key: " fingerprint)) > + (setq face 'notmuch-crypto-signature-good-key) > + (when email-or-userid > + (setq label (concat "Good signature by: " email-or-user-id)) > + (setq face 'notmuch-crypto-signature-good)) > (setq button-action 'notmuch-crypto-sigstatus-good-callback) > (setq help-msg (concat "Click to list key ID 0x" fingerprint "." > ((string= status "error") > -- > 2.30.2 LGTM. Thanks, Bremner! --dkg signature.asc Description: PGP signature ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
Re: [PATCH] emacs: use new face for notmuch-jump and related
Protesilaos Stavrou writes: > The use of a named face, notmuch-jump-key, makes it possible for users > or theme developers to apply properties that are specific to each of > those two cases. > applied to master, thanks d ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
Re: Commit after some number of transactions
David Bremner writes: > The main rational is explained in the commit message to > > [PATCH 4/5] lib: autocommit after some number of completed > > I'm not super-happy with the documentation in [5/5], as it explains > things in terms of database concepts the user shouldn't really need to > understand. > I have applied the series to master. Documentation improvements welcome. d ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
Re: [PATCH v2 1/2] ruby: add keyword arguments to db.query
Felipe Contreras writes: > That way we don't need pass them to the query object ourselves. > I have applied this change to master. As we discussed previously, I prefer to leave the sort order explicit in the tests. d ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
Re: [PATCH 1/2] cli/show: produce "email" element in sigstatus
Daniel Kahn Gillmor writes: > When the certificate that signs a message is known to be valid, GMime > is capable of reporting on the e-mail address embedded in the > certificate. applied to master. ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
Re: [PATCH] emacs: Prefer email address over User ID when showing valid signature
David Bremner writes: > From: Daniel Kahn Gillmor > > Most concrete verification steps are likely only taken on the e-mail > address in the first place, and e-mail addresses render more > intelligibly than arbitrary User IDs in the first place. > > Signed-off-by: Daniel Kahn Gillmor > Amended-by: db, apply dme restructuring suggestions. applied this version to master ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
Re: [PATCH v2] emacs: remap send-message and send-message-and-exit
edef writes: > All three of C-c C-c, , > and are bound to message-send-and-exit by > message.el, but notmuch-mua.el only had an explicit override for the > keyboard binding. This mostly manifests as confusing Fcc behaviour for > GUI users. > > Patching the bindings for specific keys is rather brittle, since it has > to be aware of every relevant binding. This change switches to instead > using a remap binding, which turns any binding for message-send or > message-send-and-exit into a binding for the corresponding notmuch-mua > command. > --- > Fixed up the nits reported by Tomi Ollila. applied to master, thanks d ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
Re: [PATCH] emacs: use new face for notmuch-jump and related
On 2021-06-27, 13:39 -0300, David Bremner wrote: > Protesilaos Stavrou writes: > >> The use of a named face, notmuch-jump-key, makes it possible for users >> or theme developers to apply properties that are specific to each of >> those two cases. >> > > applied to master, thanks You are welcome! I just noticed a mistake from my side. Please refer to the attached patch. Shall I start a new thread of will this one suffice? -- Protesilaos Stavrou https://protesilaos.com >From 7a83f7e978ab47ebd75438af3ede6280c870f529 Mon Sep 17 00:00:00 2001 Message-Id: <7a83f7e978ab47ebd75438af3ede6280c870f529.1624814747.git.i...@protesilaos.com> From: Protesilaos Stavrou Date: Sun, 27 Jun 2021 20:25:26 +0300 Subject: [PATCH] Amend commit 5cc106b0 about notmuch-jump-key face The intent of that face is to allow users/themes to differentiate the text of the minibuffer prompt from the keys that are associated with jump actions. Commit 5cc106b0 correctly introduced the new 'notmuch-jump-key' face for keys, but mistakenly applied it to the prompt as well. --- emacs/notmuch-jump.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/emacs/notmuch-jump.el b/emacs/notmuch-jump.el index e228c8a2..5ec8eb9c 100644 --- a/emacs/notmuch-jump.el +++ b/emacs/notmuch-jump.el @@ -93,7 +93,7 @@ (defun notmuch-jump (action-map prompt) (buffer-string))) (full-prompt (concat table "\n\n" - (propertize prompt 'face 'notmuch-jump-key))) + (propertize prompt 'face 'minibuffer-prompt))) ;; By default, the minibuffer applies the minibuffer face to ;; the entire prompt. However, we want to clearly ;; distinguish bindings (which we put in the prompt face -- 2.32.0 ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
Re: [PATCH 3/3] emacs/tree use notmuch-show-single-message
David Bremner writes: > This is more efficient than notmuch-show-only-matching-messages, since > we do not parse the potentially large thread structure to find a > single message. > > This is only a partial fix for notmuch-tree view, because displaying > the thread structure in the tree-mode window still crashes on long > threads. It is however enough to make unthreaded view handle long > threads. I have applied these changes to master. ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
Re: [PATCH 1/3] ruby: add new Database.open_with_config
Felipe Contreras writes: > +ret = notmuch_database_open_with_config (database_path, mode, > + config_path, profile, &db, > + NULL); I'm curious why you ignore the error_message ouput parameter. Of course it's valid and supported for library users to do this, but this way there is no way for users of the ruby bindings to retrieve the additional information about the error. Particularly in the case of Xapian exceptions, this can be helpful for debugging. ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
Re: [PATCH 1/3] ruby: add new Database.open_with_config
On Sun, Jun 27, 2021 at 1:02 PM David Bremner wrote: > > Felipe Contreras writes: > > > +ret = notmuch_database_open_with_config (database_path, mode, > > + config_path, profile, &db, > > + NULL); > > I'm curious why you ignore the error_message ouput parameter. Of course > it's valid and supported for library users to do this, but this way > there is no way for users of the ruby bindings to retrieve the > additional information about the error. Particularly in the case of > Xapian exceptions, this can be helpful for debugging. Because the patch is complex enough as it is. It shouldn't be that difficult to add a new notmuch_rb_status_raise function that takes an error message and produces a proper Ruby exception with that message, but that should be done in a separate patch. -- Felipe Contreras ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
