[jira] [Updated] (OAK-4250) DocumentStore: add test coverage for find() with ultra-long keys

2016-05-10 Thread Julian Reschke (JIRA)

 [ 
https://issues.apache.org/jira/browse/OAK-4250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-4250:

Fix Version/s: 1.4.3

> DocumentStore: add test coverage for find() with ultra-long keys
> 
>
> Key: OAK-4250
> URL: https://issues.apache.org/jira/browse/OAK-4250
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: documentmk
>Affects Versions: 1.4.1, 1.0.30, 1.2.14, 1.5.1
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Trivial
>  Labels: candidate_oak_1_0, candidate_oak_1_2
> Fix For: 1.5.2, 1.4.3
>
>
> (also make sure that there are no misleading error messages in the system log)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OAK-4250) DocumentStore: add test coverage for find() with ultra-long keys

2016-05-10 Thread Julian Reschke (JIRA)

[ 
https://issues.apache.org/jira/browse/OAK-4250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15278264#comment-15278264
 ] 

Julian Reschke commented on OAK-4250:
-

trunk: http://svn.apache.org/r1740116
1.4: http://svn.apache.org/r1743211


> DocumentStore: add test coverage for find() with ultra-long keys
> 
>
> Key: OAK-4250
> URL: https://issues.apache.org/jira/browse/OAK-4250
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: documentmk
>Affects Versions: 1.4.1, 1.0.30, 1.2.14, 1.5.1
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Trivial
>  Labels: candidate_oak_1_0, candidate_oak_1_2
> Fix For: 1.5.2, 1.4.3
>
>
> (also make sure that there are no misleading error messages in the system log)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Issue Comment Deleted] (OAK-4250) DocumentStore: add test coverage for find() with ultra-long keys

2016-05-10 Thread Julian Reschke (JIRA)

 [ 
https://issues.apache.org/jira/browse/OAK-4250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-4250:

Comment: was deleted

(was: trunk: http://svn.apache.org/r1740116)

> DocumentStore: add test coverage for find() with ultra-long keys
> 
>
> Key: OAK-4250
> URL: https://issues.apache.org/jira/browse/OAK-4250
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: documentmk
>Affects Versions: 1.4.1, 1.0.30, 1.2.14, 1.5.1
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Trivial
>  Labels: candidate_oak_1_0, candidate_oak_1_2
> Fix For: 1.5.2, 1.4.3
>
>
> (also make sure that there are no misleading error messages in the system log)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OAK-4250) DocumentStore: add test coverage for find() with ultra-long keys

2016-05-10 Thread Julian Reschke (JIRA)

 [ 
https://issues.apache.org/jira/browse/OAK-4250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-4250:

Labels: candidate_oak_1_0 candidate_oak_1_2  (was: candidate_oak_1_0 
candidate_oak_1_2 candidate_oak_1_4)

> DocumentStore: add test coverage for find() with ultra-long keys
> 
>
> Key: OAK-4250
> URL: https://issues.apache.org/jira/browse/OAK-4250
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: documentmk
>Affects Versions: 1.4.1, 1.0.30, 1.2.14, 1.5.1
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Trivial
>  Labels: candidate_oak_1_0, candidate_oak_1_2
> Fix For: 1.5.2, 1.4.3
>
>
> (also make sure that there are no misleading error messages in the system log)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (OAK-4289) Remove the gc generation from the segment meta data

2016-05-10 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/OAK-4289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Dürig resolved OAK-4289.

Resolution: Fixed

Fixed at http://svn.apache.org/viewvc?rev=1743209=rev

> Remove the gc generation from the segment meta data
> ---
>
> Key: OAK-4289
> URL: https://issues.apache.org/jira/browse/OAK-4289
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: run, segment-tar
>Reporter: Michael Dürig
>Assignee: Michael Dürig
>Priority: Minor
>  Labels: compaction, gc, tooling
> Fix For: 1.6
>
>
> The segment meta info (OAK-3550) still contains the segment's gc generation. 
> As with OAK-3348 the gc generation gets written to the segment header 
> directly we should remove it from the segment meta info and update {{oak-run 
> graph}} accordingly. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OAK-4199) RDBBlobStore: garbage collection fails to delete DATA records when there was subsequent blobstore activity

2016-05-10 Thread Julian Reschke (JIRA)

[ 
https://issues.apache.org/jira/browse/OAK-4199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15278234#comment-15278234
 ] 

Julian Reschke commented on OAK-4199:
-

trunk: http://svn.apache.org/r1738957 http://svn.apache.org/r1738950
1.4: http://svn.apache.org/r1743208
1.2: http://svn.apache.org/r1738961
1.0: http://svn.apache.org/r1738965


> RDBBlobStore: garbage collection fails to delete DATA records when there was 
> subsequent blobstore activity
> --
>
> Key: OAK-4199
> URL: https://issues.apache.org/jira/browse/OAK-4199
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: blob, rdbmk
>Affects Versions: 1.2.13, 1.0.29, 1.4.1, 1.5.1
>Reporter: Julian Reschke
>Assignee: Julian Reschke
> Fix For: 1.0.30, 1.2.14, 1.5.2, 1.4.3
>
>
> The {{countDeleteChunks}}, the statement used to cleanup the DATA table will 
> not affect any rows if there are *any* rows never than {{maxLastModified}}. 
> This is because the alias m matches the wrong table name.
> Will add test case.
> The fix likely is to use fully qualified table names, like:
> {noformat}
> dataStatement.append(" and not exists(select * from " + this.tnMeta + 
>   " where " + this.tnMeta + ".ID = " + this.tnData + ".ID and LASTMOD > ?)");
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Issue Comment Deleted] (OAK-4199) RDBBlobStore: garbage collection fails to delete DATA records when there was subsequent blobstore activity

2016-05-10 Thread Julian Reschke (JIRA)

 [ 
https://issues.apache.org/jira/browse/OAK-4199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-4199:

Comment: was deleted

(was: trunk: http://svn.apache.org/r1738957 http://svn.apache.org/r1738950
1.2: http://svn.apache.org/r1738961
1.0: http://svn.apache.org/r1738965
)

> RDBBlobStore: garbage collection fails to delete DATA records when there was 
> subsequent blobstore activity
> --
>
> Key: OAK-4199
> URL: https://issues.apache.org/jira/browse/OAK-4199
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: blob, rdbmk
>Affects Versions: 1.2.13, 1.0.29, 1.4.1, 1.5.1
>Reporter: Julian Reschke
>Assignee: Julian Reschke
> Fix For: 1.0.30, 1.2.14, 1.5.2, 1.4.3
>
>
> The {{countDeleteChunks}}, the statement used to cleanup the DATA table will 
> not affect any rows if there are *any* rows never than {{maxLastModified}}. 
> This is because the alias m matches the wrong table name.
> Will add test case.
> The fix likely is to use fully qualified table names, like:
> {noformat}
> dataStatement.append(" and not exists(select * from " + this.tnMeta + 
>   " where " + this.tnMeta + ".ID = " + this.tnData + ".ID and LASTMOD > ?)");
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OAK-4199) RDBBlobStore: garbage collection fails to delete DATA records when there was subsequent blobstore activity

2016-05-10 Thread Julian Reschke (JIRA)

 [ 
https://issues.apache.org/jira/browse/OAK-4199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-4199:

Labels:   (was: candidate_oak_1_4)

> RDBBlobStore: garbage collection fails to delete DATA records when there was 
> subsequent blobstore activity
> --
>
> Key: OAK-4199
> URL: https://issues.apache.org/jira/browse/OAK-4199
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: blob, rdbmk
>Affects Versions: 1.2.13, 1.0.29, 1.4.1, 1.5.1
>Reporter: Julian Reschke
>Assignee: Julian Reschke
> Fix For: 1.0.30, 1.2.14, 1.5.2, 1.4.3
>
>
> The {{countDeleteChunks}}, the statement used to cleanup the DATA table will 
> not affect any rows if there are *any* rows never than {{maxLastModified}}. 
> This is because the alias m matches the wrong table name.
> Will add test case.
> The fix likely is to use fully qualified table names, like:
> {noformat}
> dataStatement.append(" and not exists(select * from " + this.tnMeta + 
>   " where " + this.tnMeta + ".ID = " + this.tnData + ".ID and LASTMOD > ?)");
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (OAK-4215) Improve test-coverage for External Authentication

2016-05-10 Thread angela (JIRA)

 [ 
https://issues.apache.org/jira/browse/OAK-4215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

angela resolved OAK-4215.
-
Resolution: Fixed

> Improve test-coverage for External Authentication
> -
>
> Key: OAK-4215
> URL: https://issues.apache.org/jira/browse/OAK-4215
> Project: Jackrabbit Oak
>  Issue Type: Epic
>  Components: auth-external
>Reporter: angela
>Assignee: angela
> Fix For: 1.6
>
>
> IMO it would be really beneficial to have more tests with the 
> {{oak-auth-external}} module in order to provide us is more stability when 
> making fixes or introducing enhancements.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OAK-4199) RDBBlobStore: garbage collection fails to delete DATA records when there was subsequent blobstore activity

2016-05-10 Thread Julian Reschke (JIRA)

 [ 
https://issues.apache.org/jira/browse/OAK-4199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-4199:

Fix Version/s: 1.4.3

> RDBBlobStore: garbage collection fails to delete DATA records when there was 
> subsequent blobstore activity
> --
>
> Key: OAK-4199
> URL: https://issues.apache.org/jira/browse/OAK-4199
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: blob, rdbmk
>Affects Versions: 1.2.13, 1.0.29, 1.4.1, 1.5.1
>Reporter: Julian Reschke
>Assignee: Julian Reschke
> Fix For: 1.0.30, 1.2.14, 1.5.2, 1.4.3
>
>
> The {{countDeleteChunks}}, the statement used to cleanup the DATA table will 
> not affect any rows if there are *any* rows never than {{maxLastModified}}. 
> This is because the alias m matches the wrong table name.
> Will add test case.
> The fix likely is to use fully qualified table names, like:
> {noformat}
> dataStatement.append(" and not exists(select * from " + this.tnMeta + 
>   " where " + this.tnMeta + ".ID = " + this.tnData + ".ID and LASTMOD > ?)");
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (OAK-4264) Improve testing of SyncMBeanImpl

2016-05-10 Thread angela (JIRA)

 [ 
https://issues.apache.org/jira/browse/OAK-4264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

angela reassigned OAK-4264:
---

Assignee: angela

> Improve testing of SyncMBeanImpl
> 
>
> Key: OAK-4264
> URL: https://issues.apache.org/jira/browse/OAK-4264
> Project: Jackrabbit Oak
>  Issue Type: Test
>  Components: auth-external
>Reporter: angela
>Assignee: angela
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OAK-4357) javadoc plugin should be java 7

2016-05-10 Thread Davide Giannella (JIRA)
Davide Giannella created OAK-4357:
-

 Summary: javadoc plugin should be java 7
 Key: OAK-4357
 URL: https://issues.apache.org/jira/browse/OAK-4357
 Project: Jackrabbit Oak
  Issue Type: Bug
Reporter: Davide Giannella
Assignee: Davide Giannella
Priority: Blocker
 Fix For: 1.6, 1.5.2


With OAK-4189 we decided to go java 7 for trunk but we left behind the
javadoc plugin

https://github.com/apache/jackrabbit-oak/blob/5427f6c6aa88f9a3d5c24b871c9515a94659df54/oak-parent/pom.xml#L104





--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (OAK-4166) Simple versionable nodes are invalid after migration

2016-05-10 Thread JIRA

[ 
https://issues.apache.org/jira/browse/OAK-4166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15241045#comment-15241045
 ] 

Tomek Rękawek edited comment on OAK-4166 at 5/10/16 2:37 PM:
-

Fixed for trunk in [r1739069|http://svn.apache.org/r1739069] and 
[r1743198|https://svn.apache.org/r1743198].


was (Author: tomek.rekawek):
Fixed for trunk in [r1739069|http://svn.apache.org/r1739069].

> Simple versionable nodes are invalid after migration
> 
>
> Key: OAK-4166
> URL: https://issues.apache.org/jira/browse/OAK-4166
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: upgrade
>Reporter: Tomek Rękawek
>Assignee: Tomek Rękawek
> Fix For: 1.6, 1.4.2, 1.5.2
>
> Attachments: OAK-4166-extended-test.patch
>
>
> OAK-3836 introduces a support for migrating {{mix:simpleVersionable}} nodes 
> from JCR2 to {{mix:versionable}} nodes in Oak. It changes the mixin type, 
> however it doesn't add required properties: {{jcr:versionHistory}}, 
> {{jcr:baseVersion}} and {{jcr:predecessors}}. As a result, versioning-related 
> methods invoked on such nodes doesn't work correctly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OAK-4193) RDBBlobStore: logging for garbage collection has parameters reversed

2016-05-10 Thread Julian Reschke (JIRA)

 [ 
https://issues.apache.org/jira/browse/OAK-4193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-4193:

Labels:   (was: candidate_oak_1_4)

> RDBBlobStore: logging for garbage collection has parameters reversed
> 
>
> Key: OAK-4193
> URL: https://issues.apache.org/jira/browse/OAK-4193
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: rdbmk
>Affects Versions: 1.2.13, 1.0.29, 1.4.1, 1.5.1
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Fix For: 1.0.30, 1.2.14, 1.5.2, 1.4.3
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OAK-4193) RDBBlobStore: logging for garbage collection has parameters reversed

2016-05-10 Thread Julian Reschke (JIRA)

[ 
https://issues.apache.org/jira/browse/OAK-4193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15278162#comment-15278162
 ] 

Julian Reschke commented on OAK-4193:
-

trunk: http://svn.apache.org/r1738833
1.4: http://svn.apache.org/r1743194
1.2: http://svn.apache.org/r1738834
1.0: http://svn.apache.org/r1738860


> RDBBlobStore: logging for garbage collection has parameters reversed
> 
>
> Key: OAK-4193
> URL: https://issues.apache.org/jira/browse/OAK-4193
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: rdbmk
>Affects Versions: 1.2.13, 1.0.29, 1.4.1, 1.5.1
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Fix For: 1.0.30, 1.2.14, 1.5.2, 1.4.3
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OAK-4193) RDBBlobStore: logging for garbage collection has parameters reversed

2016-05-10 Thread Julian Reschke (JIRA)

 [ 
https://issues.apache.org/jira/browse/OAK-4193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-4193:

Fix Version/s: 1.4.3

> RDBBlobStore: logging for garbage collection has parameters reversed
> 
>
> Key: OAK-4193
> URL: https://issues.apache.org/jira/browse/OAK-4193
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: rdbmk
>Affects Versions: 1.2.13, 1.0.29, 1.4.1, 1.5.1
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Fix For: 1.0.30, 1.2.14, 1.5.2, 1.4.3
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Issue Comment Deleted] (OAK-4193) RDBBlobStore: logging for garbage collection has parameters reversed

2016-05-10 Thread Julian Reschke (JIRA)

 [ 
https://issues.apache.org/jira/browse/OAK-4193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-4193:

Comment: was deleted

(was: trunk: http://svn.apache.org/r1738833
1.2: http://svn.apache.org/r1738834
1.0: http://svn.apache.org/r1738860
)

> RDBBlobStore: logging for garbage collection has parameters reversed
> 
>
> Key: OAK-4193
> URL: https://issues.apache.org/jira/browse/OAK-4193
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: rdbmk
>Affects Versions: 1.2.13, 1.0.29, 1.4.1, 1.5.1
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Fix For: 1.0.30, 1.2.14, 1.5.2, 1.4.3
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Issue Comment Deleted] (OAK-4156) RDBConnectionHandler: add logging when getting the connection takes long

2016-05-10 Thread Julian Reschke (JIRA)

 [ 
https://issues.apache.org/jira/browse/OAK-4156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-4156:

Comment: was deleted

(was: trunk: http://svn.apache.org/r1737349
1.2: http://svn.apache.org/r1737352
1.0: http://svn.apache.org/r1737362
)

> RDBConnectionHandler: add logging when getting the connection takes long
> 
>
> Key: OAK-4156
> URL: https://issues.apache.org/jira/browse/OAK-4156
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: rdbmk
>Affects Versions: 1.2.13, 1.0.29, 1.4.1, 1.5.0
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Fix For: 1.0.30, 1.2.14, 1.5.1, 1.4.3
>
>
> Where "long" could be something like 1/10s (does this need to be 
> configurable?), and the log level would be DEBUG.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OAK-4156) RDBConnectionHandler: add logging when getting the connection takes long

2016-05-10 Thread Julian Reschke (JIRA)

 [ 
https://issues.apache.org/jira/browse/OAK-4156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-4156:

Fix Version/s: 1.4.3

> RDBConnectionHandler: add logging when getting the connection takes long
> 
>
> Key: OAK-4156
> URL: https://issues.apache.org/jira/browse/OAK-4156
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: rdbmk
>Affects Versions: 1.2.13, 1.0.29, 1.4.1, 1.5.0
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Fix For: 1.0.30, 1.2.14, 1.5.1, 1.4.3
>
>
> Where "long" could be something like 1/10s (does this need to be 
> configurable?), and the log level would be DEBUG.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OAK-4156) RDBConnectionHandler: add logging when getting the connection takes long

2016-05-10 Thread Julian Reschke (JIRA)

[ 
https://issues.apache.org/jira/browse/OAK-4156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15278156#comment-15278156
 ] 

Julian Reschke commented on OAK-4156:
-

trunk: http://svn.apache.org/r1737349
1.4: http://svn.apache.org/r1743193
1.2: http://svn.apache.org/r1737352
1.0: http://svn.apache.org/r1737362


> RDBConnectionHandler: add logging when getting the connection takes long
> 
>
> Key: OAK-4156
> URL: https://issues.apache.org/jira/browse/OAK-4156
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: rdbmk
>Affects Versions: 1.2.13, 1.0.29, 1.4.1, 1.5.0
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Fix For: 1.0.30, 1.2.14, 1.5.1, 1.4.3
>
>
> Where "long" could be something like 1/10s (does this need to be 
> configurable?), and the log level would be DEBUG.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OAK-4156) RDBConnectionHandler: add logging when getting the connection takes long

2016-05-10 Thread Julian Reschke (JIRA)

 [ 
https://issues.apache.org/jira/browse/OAK-4156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-4156:

Labels:   (was: candidate_oak_1_4)

> RDBConnectionHandler: add logging when getting the connection takes long
> 
>
> Key: OAK-4156
> URL: https://issues.apache.org/jira/browse/OAK-4156
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: rdbmk
>Affects Versions: 1.2.13, 1.0.29, 1.4.1, 1.5.0
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Fix For: 1.0.30, 1.2.14, 1.5.1, 1.4.3
>
>
> Where "long" could be something like 1/10s (does this need to be 
> configurable?), and the log level would be DEBUG.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (OAK-4288) TarReader.calculateForwardReferences only used by oak-run graph tool

2016-05-10 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/OAK-4288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Dürig resolved OAK-4288.

Resolution: Fixed

Removed the remaining FIXME tag at 
http://svn.apache.org/viewvc?rev=1743191=rev as this is merely a cosmetic 
issue and that method might turn out useful further beyond tooling further down 
the line. I.e. if we decide to (again) build reachability based gc. 

> TarReader.calculateForwardReferences only used by oak-run graph tool
> 
>
> Key: OAK-4288
> URL: https://issues.apache.org/jira/browse/OAK-4288
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: segment-tar
>Reporter: Michael Dürig
>Assignee: Michael Dürig
>Priority: Minor
>  Labels: cleanup, gc, tooling
> Fix For: 1.6
>
>
> {{TarReader.calculateForwardReferences}} is not used for production but only 
> for tooling so it would be good if we could remove that method from the 
> production code an put it into a tooling specific module. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OAK-4163) LastRevRecoveryAgent: improve startup diagnostics

2016-05-10 Thread Julian Reschke (JIRA)

[ 
https://issues.apache.org/jira/browse/OAK-4163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15278113#comment-15278113
 ] 

Julian Reschke commented on OAK-4163:
-

trunk: http://svn.apache.org/r1737334
1.4: http://svn.apache.org/r1743182
1.2: http://svn.apache.org/r1737336
1.0: http://svn.apache.org/r1737337


> LastRevRecoveryAgent: improve startup diagnostics
> -
>
> Key: OAK-4163
> URL: https://issues.apache.org/jira/browse/OAK-4163
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: documentmk
>Affects Versions: 1.2.13, 1.0.29, 1.4.1, 1.5.0
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Fix For: 1.0.30, 1.2.14, 1.5.1, 1.4.3
>
> Attachments: OAK-4163.diff
>
>
> The {{recover()}} method could be more verbose:
> a) state how {{startTime}} was derived (there are two ways),
> b) dump hex equivalent of start time (makes it easier to compare with 
> revision ids)
> Both changes could come handy when debugging potential problems related to 
> LastRevRecovery.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Issue Comment Deleted] (OAK-4163) LastRevRecoveryAgent: improve startup diagnostics

2016-05-10 Thread Julian Reschke (JIRA)

 [ 
https://issues.apache.org/jira/browse/OAK-4163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-4163:

Comment: was deleted

(was: trunk: http://svn.apache.org/r1737334
1.2: http://svn.apache.org/r1737336
1.0: http://svn.apache.org/r1737337
)

> LastRevRecoveryAgent: improve startup diagnostics
> -
>
> Key: OAK-4163
> URL: https://issues.apache.org/jira/browse/OAK-4163
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: documentmk
>Affects Versions: 1.2.13, 1.0.29, 1.4.1, 1.5.0
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Fix For: 1.0.30, 1.2.14, 1.5.1, 1.4.3
>
> Attachments: OAK-4163.diff
>
>
> The {{recover()}} method could be more verbose:
> a) state how {{startTime}} was derived (there are two ways),
> b) dump hex equivalent of start time (makes it easier to compare with 
> revision ids)
> Both changes could come handy when debugging potential problems related to 
> LastRevRecovery.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OAK-4163) LastRevRecoveryAgent: improve startup diagnostics

2016-05-10 Thread Julian Reschke (JIRA)

 [ 
https://issues.apache.org/jira/browse/OAK-4163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-4163:

Fix Version/s: 1.4.3

> LastRevRecoveryAgent: improve startup diagnostics
> -
>
> Key: OAK-4163
> URL: https://issues.apache.org/jira/browse/OAK-4163
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: documentmk
>Affects Versions: 1.2.13, 1.0.29, 1.4.1, 1.5.0
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Fix For: 1.0.30, 1.2.14, 1.5.1, 1.4.3
>
> Attachments: OAK-4163.diff
>
>
> The {{recover()}} method could be more verbose:
> a) state how {{startTime}} was derived (there are two ways),
> b) dump hex equivalent of start time (makes it easier to compare with 
> revision ids)
> Both changes could come handy when debugging potential problems related to 
> LastRevRecovery.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OAK-4163) LastRevRecoveryAgent: improve startup diagnostics

2016-05-10 Thread Julian Reschke (JIRA)

 [ 
https://issues.apache.org/jira/browse/OAK-4163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-4163:

Labels:   (was: candidate_oak_1_4)

> LastRevRecoveryAgent: improve startup diagnostics
> -
>
> Key: OAK-4163
> URL: https://issues.apache.org/jira/browse/OAK-4163
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: documentmk
>Affects Versions: 1.2.13, 1.0.29, 1.4.1, 1.5.0
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Fix For: 1.0.30, 1.2.14, 1.5.1, 1.4.3
>
> Attachments: OAK-4163.diff
>
>
> The {{recover()}} method could be more verbose:
> a) state how {{startTime}} was derived (there are two ways),
> b) dump hex equivalent of start time (makes it easier to compare with 
> revision ids)
> Both changes could come handy when debugging potential problems related to 
> LastRevRecovery.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OAK-4134) RDBBlobStore: improve error handling and logging

2016-05-10 Thread Julian Reschke (JIRA)

[ 
https://issues.apache.org/jira/browse/OAK-4134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15278108#comment-15278108
 ] 

Julian Reschke commented on OAK-4134:
-

trunk: http://svn.apache.org/r1735588
1.4: http://svn.apache.org/r1743180 http://svn.apache.org/r1735988 
http://svn.apache.org/r1735592
1.2: http://svn.apache.org/r1735594
1.0: http://svn.apache.org/r1735596


> RDBBlobStore: improve error handling and logging
> 
>
> Key: OAK-4134
> URL: https://issues.apache.org/jira/browse/OAK-4134
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: blob, rdbmk
>Affects Versions: 1.2.12, 1.0.28, 1.4.0
>Reporter: Julian Reschke
>Assignee: Julian Reschke
> Fix For: 1.6, 1.2.13, 1.0.29, 1.5.0, 1.4.3
>
>
> Enhance logging and error handling by:
> - TRACE-level log inserts and deletes
> - check the return codes of inserts (do not rely on SQLException to be thrown)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Issue Comment Deleted] (OAK-4134) RDBBlobStore: improve error handling and logging

2016-05-10 Thread Julian Reschke (JIRA)

 [ 
https://issues.apache.org/jira/browse/OAK-4134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-4134:

Comment: was deleted

(was: trunk: http://svn.apache.org/r1735588
1.4: (pending)
1.2: http://svn.apache.org/r1735594
1.0: http://svn.apache.org/r1735596
)

> RDBBlobStore: improve error handling and logging
> 
>
> Key: OAK-4134
> URL: https://issues.apache.org/jira/browse/OAK-4134
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: blob, rdbmk
>Affects Versions: 1.2.12, 1.0.28, 1.4.0
>Reporter: Julian Reschke
>Assignee: Julian Reschke
> Fix For: 1.6, 1.2.13, 1.0.29, 1.5.0, 1.4.3
>
>
> Enhance logging and error handling by:
> - TRACE-level log inserts and deletes
> - check the return codes of inserts (do not rely on SQLException to be thrown)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OAK-4134) RDBBlobStore: improve error handling and logging

2016-05-10 Thread Julian Reschke (JIRA)

 [ 
https://issues.apache.org/jira/browse/OAK-4134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-4134:

Labels:   (was: candidate_oak_1_4)

> RDBBlobStore: improve error handling and logging
> 
>
> Key: OAK-4134
> URL: https://issues.apache.org/jira/browse/OAK-4134
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: blob, rdbmk
>Affects Versions: 1.2.12, 1.0.28, 1.4.0
>Reporter: Julian Reschke
>Assignee: Julian Reschke
> Fix For: 1.6, 1.2.13, 1.0.29, 1.5.0, 1.4.3
>
>
> Enhance logging and error handling by:
> - TRACE-level log inserts and deletes
> - check the return codes of inserts (do not rely on SQLException to be thrown)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OAK-4134) RDBBlobStore: improve error handling and logging

2016-05-10 Thread Julian Reschke (JIRA)

 [ 
https://issues.apache.org/jira/browse/OAK-4134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-4134:

Fix Version/s: 1.4.3

> RDBBlobStore: improve error handling and logging
> 
>
> Key: OAK-4134
> URL: https://issues.apache.org/jira/browse/OAK-4134
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: blob, rdbmk
>Affects Versions: 1.2.12, 1.0.28, 1.4.0
>Reporter: Julian Reschke
>Assignee: Julian Reschke
> Fix For: 1.6, 1.2.13, 1.0.29, 1.5.0, 1.4.3
>
>
> Enhance logging and error handling by:
> - TRACE-level log inserts and deletes
> - check the return codes of inserts (do not rely on SQLException to be thrown)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (OAK-4321) Improve conflict exception message to show if conflict is unexpected

2016-05-10 Thread Marcel Reutegger (JIRA)

 [ 
https://issues.apache.org/jira/browse/OAK-4321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marcel Reutegger resolved OAK-4321.
---
   Resolution: Fixed
Fix Version/s: 1.5.2

Implemented in trunk: http://svn.apache.org/r1743172

> Improve conflict exception message to show if conflict is unexpected
> 
>
> Key: OAK-4321
> URL: https://issues.apache.org/jira/browse/OAK-4321
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: core, documentmk
>Reporter: Vikas Saurabh
>Assignee: Marcel Reutegger
>Priority: Minor
>  Labels: candidate_oak_1_0, candidate_oak_1_2, candidate_oak_1_4
> Fix For: 1.6, 1.5.2
>
> Attachments: OAK-4321-1.0.diff
>
>
> Merge exception (aka OakMerge) are often expected when concurrent 
> sessions do conflicting writes. But in some occasions, we've seen bugs in oak 
> which also lead to merge exception.
> This creates confusion during investigation to isolate if it's an issue in 
> oak or a genuine concurrent conflict.
> It'd be useful if the exception message has information to distinguish that.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (OAK-4349) Commands in oak-run should not implement NodeStore creation logic from scratch

2016-05-10 Thread Davide Giannella (JIRA)

[ 
https://issues.apache.org/jira/browse/OAK-4349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15278061#comment-15278061
 ] 

Davide Giannella edited comment on OAK-4349 at 5/10/16 1:18 PM:


as by http://markmail.org/message/6rmufo7xqzoali2p it seems it's going
to be needed for other projects beside oak-run (ie oak-upgrade); maybe
it will be better to put this in something like oak-commons and export
it properly.

WDYT?

+1 for the approach anyway.




was (Author: edivad):
as by http://markmail.org/message/6rmufo7xqzoali2p it seems it's going
to be needed for other projects beside oak-run (ie oak-upgrade); maybe
it will be better to put this in something like oak-commons and export
it properly.

WDYT?



> Commands in oak-run should not implement NodeStore creation logic from scratch
> --
>
> Key: OAK-4349
> URL: https://issues.apache.org/jira/browse/OAK-4349
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: run
>Reporter: Francesco Mari
>Assignee: Francesco Mari
> Attachments: OAK-4349-01.patch
>
>
> Many commands in oak-run implement the same logic over and over to create a 
> {{NodeStore}} from command line arguments. I think it would be better to have 
> this logic in a single  place and reuse it from every command.
> In OAK-4246 I proposed an approach based on URIs. Instead of specified 
> command line arguments and flags, a connection to a specific backend could be 
> specified using a URI with application specific schemas. On OAK-4246 I showed 
> some examples specific to the {{SegmentNodeStore}}:
> - {{segment:///path/to/dir}} opens an "old style" segment store at the 
> specified folder.
> - {{segment:tar:///path/to/dir}} opens a"new style" segment store at the 
> specified folder.
> - {{segment:tar:///path/to/dir?mm=false}} opens a "new style" segment store 
> at the specified folder and disables memory mapped files.
> A solution based on URIs can be extended to other {{NodeStore}} 
> implementations by using other schemes like {{segment:mem}}, 
> {{document:mongo}}, {{document:rdb}}, and so on.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (OAK-4134) RDBBlobStore: improve error handling and logging

2016-05-10 Thread Julian Reschke (JIRA)

[ 
https://issues.apache.org/jira/browse/OAK-4134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15201409#comment-15201409
 ] 

Julian Reschke edited comment on OAK-4134 at 5/10/16 1:15 PM:
--

trunk: http://svn.apache.org/r1735588
1.4: (pending)
1.2: http://svn.apache.org/r1735594
1.0: http://svn.apache.org/r1735596



was (Author: reschke):
trunk: http://svn.apache.org/r1735588
1.4: http://svn.apache.org/r1735592
1.2: http://svn.apache.org/r1735594
1.0: http://svn.apache.org/r1735596


> RDBBlobStore: improve error handling and logging
> 
>
> Key: OAK-4134
> URL: https://issues.apache.org/jira/browse/OAK-4134
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: blob, rdbmk
>Affects Versions: 1.2.12, 1.0.28, 1.4.0
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>  Labels: candidate_oak_1_4
> Fix For: 1.6, 1.2.13, 1.0.29, 1.5.0
>
>
> Enhance logging and error handling by:
> - TRACE-level log inserts and deletes
> - check the return codes of inserts (do not rely on SQLException to be thrown)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OAK-4029) RDBDocumentStore: optimize the bulk update method

2016-05-10 Thread Julian Reschke (JIRA)

 [ 
https://issues.apache.org/jira/browse/OAK-4029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-4029:

Fix Version/s: 1.4.3

> RDBDocumentStore: optimize the bulk update method
> -
>
> Key: OAK-4029
> URL: https://issues.apache.org/jira/browse/OAK-4029
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: rdbmk
>Reporter: Tomek Rękawek
>Assignee: Julian Reschke
> Fix For: 1.6, 1.5.0, 1.4.3
>
> Attachments: OAK-4029.patch
>
>
> It seems that the {{RDBDocumentStoreJDBC.update()}} method contains a 
> redundant SELECT statement, between the UPDATE and INSERT phase. It's used to 
> find out whether we should INSERT remaining documents or if they already 
> exists in the DB. However, we may skip the middle SELECT and try to INSERT 
> all documents with mod_count = 1.
> The second possible optimisation in this method is skipping the first bulk 
> UPDATE operation if there are no documents to be updated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OAK-4029) RDBDocumentStore: optimize the bulk update method

2016-05-10 Thread Julian Reschke (JIRA)

[ 
https://issues.apache.org/jira/browse/OAK-4029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15278063#comment-15278063
 ] 

Julian Reschke commented on OAK-4029:
-

trunk: http://svn.apache.org/r1734941
1.4: http://svn.apache.org/r1743171


> RDBDocumentStore: optimize the bulk update method
> -
>
> Key: OAK-4029
> URL: https://issues.apache.org/jira/browse/OAK-4029
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: rdbmk
>Reporter: Tomek Rękawek
>Assignee: Julian Reschke
> Fix For: 1.6, 1.5.0, 1.4.3
>
> Attachments: OAK-4029.patch
>
>
> It seems that the {{RDBDocumentStoreJDBC.update()}} method contains a 
> redundant SELECT statement, between the UPDATE and INSERT phase. It's used to 
> find out whether we should INSERT remaining documents or if they already 
> exists in the DB. However, we may skip the middle SELECT and try to INSERT 
> all documents with mod_count = 1.
> The second possible optimisation in this method is skipping the first bulk 
> UPDATE operation if there are no documents to be updated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OAK-4029) RDBDocumentStore: optimize the bulk update method

2016-05-10 Thread Julian Reschke (JIRA)

 [ 
https://issues.apache.org/jira/browse/OAK-4029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-4029:

Labels:   (was: candidate_oak_1_4)

> RDBDocumentStore: optimize the bulk update method
> -
>
> Key: OAK-4029
> URL: https://issues.apache.org/jira/browse/OAK-4029
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: rdbmk
>Reporter: Tomek Rękawek
>Assignee: Julian Reschke
> Fix For: 1.6, 1.5.0, 1.4.3
>
> Attachments: OAK-4029.patch
>
>
> It seems that the {{RDBDocumentStoreJDBC.update()}} method contains a 
> redundant SELECT statement, between the UPDATE and INSERT phase. It's used to 
> find out whether we should INSERT remaining documents or if they already 
> exists in the DB. However, we may skip the middle SELECT and try to INSERT 
> all documents with mod_count = 1.
> The second possible optimisation in this method is skipping the first bulk 
> UPDATE operation if there are no documents to be updated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OAK-4154) SynchronizationMBean.syncUsers(...) should optionally not force group sync.

2016-05-10 Thread angela (JIRA)

[ 
https://issues.apache.org/jira/browse/OAK-4154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15278053#comment-15278053
 ] 

angela commented on OAK-4154:
-

and btw: the original description states:

{quote}
[...] featuring an additional boolean argument to enable or disable group sync.
{quote}

This is not achieved by the changes you made because 
{{SyncContext.setForceGroupSync(boolean force)}} is not the flag to turn on or 
off group synchronization. Instead it can be used to _enforce_ the group 
synchronization irrespective of the expiration time. In other words: 
- upon initial synchronization (not expiration time stored) the groups will be 
synced up to the configured depth irrespective of the force-group-sync flag
- if a given group is found to be expired it will be synchronized again 
irrespective of the force-group-sync flag

So, either the description is bit misleading or the fix doesn't do what it 
promises :-)
May I kindly ask for additional clarification on this in addition to the test? 
And again: proper tests would be helpful to identify the subtle differences 
between group-expirationtime, force-group-sync, membership sync etc.etc.

Unless this is fully clarify I would opt for reverting the changes made so far.

On an architectural side note: the extra {{forceGroupSync}} looks a bit weired 
to me as it's correspondent flag {{forceUserSync}} is missing. In particular as 
all the methods not only can be used to sync user accounts but can also be fed 
with groupIds, externalGroupIds... that's not obviously from the naming of the 
methods but 
I happened to spot (with some surprise) while working on OAK-4264.

> SynchronizationMBean.syncUsers(...) should optionally not force group sync.
> ---
>
> Key: OAK-4154
> URL: https://issues.apache.org/jira/browse/OAK-4154
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: auth-external
>Reporter: Manfred Baedke
>Assignee: Manfred Baedke
> Fix For: 1.6
>
>
> SynchronizationMBean.syncUsers(...) and related methods always force group 
> synchronization. This may have a huge negative impact on the performance of 
> these methods.
> Additional methods should be added to the interface 
> org.apache.jackrabbit.oak.spi.security.authentication.external.impl.jmx.SynchronizationMBean,
>  featuring an additional boolean argument to enable or disable group sync.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (OAK-4321) Improve conflict exception message to show if conflict is unexpected

2016-05-10 Thread Marcel Reutegger (JIRA)

 [ 
https://issues.apache.org/jira/browse/OAK-4321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marcel Reutegger reassigned OAK-4321:
-

Assignee: Marcel Reutegger  (was: Vikas Saurabh)

> Improve conflict exception message to show if conflict is unexpected
> 
>
> Key: OAK-4321
> URL: https://issues.apache.org/jira/browse/OAK-4321
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: core, documentmk
>Reporter: Vikas Saurabh
>Assignee: Marcel Reutegger
>Priority: Minor
>  Labels: candidate_oak_1_0, candidate_oak_1_2, candidate_oak_1_4
> Fix For: 1.6
>
> Attachments: OAK-4321-1.0.diff
>
>
> Merge exception (aka OakMerge) are often expected when concurrent 
> sessions do conflicting writes. But in some occasions, we've seen bugs in oak 
> which also lead to merge exception.
> This creates confusion during investigation to isolate if it's an issue in 
> oak or a genuine concurrent conflict.
> It'd be useful if the exception message has information to distinguish that.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (OAK-4094) RDBDocumentStore: upgrade PostgreSQL JDBC driver dependency to 9.4.1208

2016-05-10 Thread Julian Reschke (JIRA)

[ 
https://issues.apache.org/jira/browse/OAK-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15276509#comment-15276509
 ] 

Julian Reschke edited comment on OAK-4094 at 5/10/16 12:29 PM:
---

trunk: http://svn.apache.org/r1733929
1.4: http://svn.apache.org/r1742983
1.2: http://svn.apache.org/r1743050
1.0: http://svn.apache.org/r1743165


was (Author: reschke):
trunk: http://svn.apache.org/r1733929
1.4: http://svn.apache.org/r1742983
1.2: http://svn.apache.org/r1743050


> RDBDocumentStore: upgrade PostgreSQL JDBC driver dependency to 9.4.1208
> ---
>
> Key: OAK-4094
> URL: https://issues.apache.org/jira/browse/OAK-4094
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: rdbmk
>Affects Versions: 1.2.12, 1.0.28, 1.4.0
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Trivial
> Fix For: 1.5.0, 1.0.31, 1.2.15, 1.4.3
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OAK-4094) RDBDocumentStore: upgrade PostgreSQL JDBC driver dependency to 9.4.1208

2016-05-10 Thread Julian Reschke (JIRA)

 [ 
https://issues.apache.org/jira/browse/OAK-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-4094:

Fix Version/s: 1.0.31

> RDBDocumentStore: upgrade PostgreSQL JDBC driver dependency to 9.4.1208
> ---
>
> Key: OAK-4094
> URL: https://issues.apache.org/jira/browse/OAK-4094
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: rdbmk
>Affects Versions: 1.2.12, 1.0.28, 1.4.0
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Trivial
> Fix For: 1.5.0, 1.0.31, 1.2.15, 1.4.3
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OAK-4094) RDBDocumentStore: upgrade PostgreSQL JDBC driver dependency to 9.4.1208

2016-05-10 Thread Julian Reschke (JIRA)

 [ 
https://issues.apache.org/jira/browse/OAK-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-4094:

Labels:   (was: candidate_oak_1_0)

> RDBDocumentStore: upgrade PostgreSQL JDBC driver dependency to 9.4.1208
> ---
>
> Key: OAK-4094
> URL: https://issues.apache.org/jira/browse/OAK-4094
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: rdbmk
>Affects Versions: 1.2.12, 1.0.28, 1.4.0
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Trivial
> Fix For: 1.5.0, 1.0.31, 1.2.15, 1.4.3
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OAK-1953) Oak console on MongoMK fails with NPE

2016-05-10 Thread Julian Reschke (JIRA)

[ 
https://issues.apache.org/jira/browse/OAK-1953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15278011#comment-15278011
 ] 

Julian Reschke commented on OAK-1953:
-

Fixed LastRevRecoverAgent for 1.0 in http://svn.apache.org/r1743164

> Oak console on MongoMK fails with NPE
> -
>
> Key: OAK-1953
> URL: https://issues.apache.org/jira/browse/OAK-1953
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: core, documentmk, mongomk, rdbmk, run
>Affects Versions: 1.0.30
>Reporter: Marcel Reutegger
>Assignee: Marcel Reutegger
> Fix For: 1.1.0, 1.0.31
>
>
> The exception is:
> {noformat}
> Apache Jackrabbit Oak 1.1-SNAPSHOT
> Exception in thread "main" java.lang.NullPointerException: Lease End Time not 
> set
>   at 
> com.google.common.base.Preconditions.checkNotNull(Preconditions.java:209)
>   at 
> org.apache.jackrabbit.oak.plugins.document.ClusterNodeInfoDocument.getLeaseEndTime(ClusterNodeInfoDocument.java:41)
>   at 
> org.apache.jackrabbit.oak.plugins.document.LastRevRecoveryAgent.recover(LastRevRecoveryAgent.java:81)
>   at 
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStore.checkLastRevRecovery(DocumentNodeStore.java:425)
>   at 
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStore.(DocumentNodeStore.java:404)
>   at 
> org.apache.jackrabbit.oak.plugins.document.DocumentMK$Builder.getNodeStore(DocumentMK.java:582)
>   at org.apache.jackrabbit.oak.console.Console.main(Console.java:72)
>   at org.apache.jackrabbit.oak.run.Main.main(Main.java:118)
> {noformat}
> The document in the clusterNodes collection looks like this:
> {noformat}
> {
>   "_id" : "1",
>   "state" : null,
>   "leaseEnd" : null,
>   "instance" : "/Users/mreutegg/test",
>   "machine" : "mac:685b35b878ea",
>   "recoveryLock" : null,
>   "info" : "id: 1,\nstartTime: 1404725920370,\nmachineId: 
> mac:685b35b878ea,\ninstanceId: /Users/mreutegg/test,\npid: 40619,\nuuid: 
> 5cca6177-1062-441c-a86b-ec7bf848917d,\nreadWriteMode: null,\nstate: 
> NONE,\nrevLock: NONE",
>   "_modCount" : NumberLong(52)
> }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OAK-1953) Oak console on MongoMK fails with NPE

2016-05-10 Thread Julian Reschke (JIRA)

 [ 
https://issues.apache.org/jira/browse/OAK-1953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-1953:

Labels:   (was: candidate_oak_1_0)

> Oak console on MongoMK fails with NPE
> -
>
> Key: OAK-1953
> URL: https://issues.apache.org/jira/browse/OAK-1953
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: core, documentmk, mongomk, rdbmk, run
>Affects Versions: 1.0.30
>Reporter: Marcel Reutegger
>Assignee: Marcel Reutegger
> Fix For: 1.1.0, 1.0.31
>
>
> The exception is:
> {noformat}
> Apache Jackrabbit Oak 1.1-SNAPSHOT
> Exception in thread "main" java.lang.NullPointerException: Lease End Time not 
> set
>   at 
> com.google.common.base.Preconditions.checkNotNull(Preconditions.java:209)
>   at 
> org.apache.jackrabbit.oak.plugins.document.ClusterNodeInfoDocument.getLeaseEndTime(ClusterNodeInfoDocument.java:41)
>   at 
> org.apache.jackrabbit.oak.plugins.document.LastRevRecoveryAgent.recover(LastRevRecoveryAgent.java:81)
>   at 
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStore.checkLastRevRecovery(DocumentNodeStore.java:425)
>   at 
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStore.(DocumentNodeStore.java:404)
>   at 
> org.apache.jackrabbit.oak.plugins.document.DocumentMK$Builder.getNodeStore(DocumentMK.java:582)
>   at org.apache.jackrabbit.oak.console.Console.main(Console.java:72)
>   at org.apache.jackrabbit.oak.run.Main.main(Main.java:118)
> {noformat}
> The document in the clusterNodes collection looks like this:
> {noformat}
> {
>   "_id" : "1",
>   "state" : null,
>   "leaseEnd" : null,
>   "instance" : "/Users/mreutegg/test",
>   "machine" : "mac:685b35b878ea",
>   "recoveryLock" : null,
>   "info" : "id: 1,\nstartTime: 1404725920370,\nmachineId: 
> mac:685b35b878ea,\ninstanceId: /Users/mreutegg/test,\npid: 40619,\nuuid: 
> 5cca6177-1062-441c-a86b-ec7bf848917d,\nreadWriteMode: null,\nstate: 
> NONE,\nrevLock: NONE",
>   "_modCount" : NumberLong(52)
> }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OAK-1953) Oak console on MongoMK fails with NPE

2016-05-10 Thread Julian Reschke (JIRA)

 [ 
https://issues.apache.org/jira/browse/OAK-1953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-1953:

Fix Version/s: 1.0.31

> Oak console on MongoMK fails with NPE
> -
>
> Key: OAK-1953
> URL: https://issues.apache.org/jira/browse/OAK-1953
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: core, documentmk, mongomk, rdbmk, run
>Affects Versions: 1.0.30
>Reporter: Marcel Reutegger
>Assignee: Marcel Reutegger
> Fix For: 1.1.0, 1.0.31
>
>
> The exception is:
> {noformat}
> Apache Jackrabbit Oak 1.1-SNAPSHOT
> Exception in thread "main" java.lang.NullPointerException: Lease End Time not 
> set
>   at 
> com.google.common.base.Preconditions.checkNotNull(Preconditions.java:209)
>   at 
> org.apache.jackrabbit.oak.plugins.document.ClusterNodeInfoDocument.getLeaseEndTime(ClusterNodeInfoDocument.java:41)
>   at 
> org.apache.jackrabbit.oak.plugins.document.LastRevRecoveryAgent.recover(LastRevRecoveryAgent.java:81)
>   at 
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStore.checkLastRevRecovery(DocumentNodeStore.java:425)
>   at 
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStore.(DocumentNodeStore.java:404)
>   at 
> org.apache.jackrabbit.oak.plugins.document.DocumentMK$Builder.getNodeStore(DocumentMK.java:582)
>   at org.apache.jackrabbit.oak.console.Console.main(Console.java:72)
>   at org.apache.jackrabbit.oak.run.Main.main(Main.java:118)
> {noformat}
> The document in the clusterNodes collection looks like this:
> {noformat}
> {
>   "_id" : "1",
>   "state" : null,
>   "leaseEnd" : null,
>   "instance" : "/Users/mreutegg/test",
>   "machine" : "mac:685b35b878ea",
>   "recoveryLock" : null,
>   "info" : "id: 1,\nstartTime: 1404725920370,\nmachineId: 
> mac:685b35b878ea,\ninstanceId: /Users/mreutegg/test,\npid: 40619,\nuuid: 
> 5cca6177-1062-441c-a86b-ec7bf848917d,\nreadWriteMode: null,\nstate: 
> NONE,\nrevLock: NONE",
>   "_modCount" : NumberLong(52)
> }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (OAK-4356) DocumentNodeStoreIT.modifiedResetWithDiff fails for various RDBs

2016-05-10 Thread Julian Reschke (JIRA)

 [ 
https://issues.apache.org/jira/browse/OAK-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke resolved OAK-4356.
-
Resolution: Duplicate

This was fixed for 1.1.0 but not backported to 1.0 branch.

> DocumentNodeStoreIT.modifiedResetWithDiff fails for various RDBs
> 
>
> Key: OAK-4356
> URL: https://issues.apache.org/jira/browse/OAK-4356
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: documentmk, rdbmk
>Affects Versions: 1.0.30
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
>
> java.lang.NullPointerException: Lease End Time not set
>   at 
> com.google.common.base.Preconditions.checkNotNull(Preconditions.java:209)
>   at 
> org.apache.jackrabbit.oak.plugins.document.ClusterNodeInfoDocument.getLeaseEndTime(ClusterNodeInfoDocument.java:43)
>   at 
> org.apache.jackrabbit.oak.plugins.document.LastRevRecoveryAgent.recover(LastRevRecoveryAgent.java:84)
>   at 
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStore.checkLastRevRecovery(DocumentNodeStore.java:506)
>   at 
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStore.(DocumentNodeStore.java:483)
>   at 
> org.apache.jackrabbit.oak.plugins.document.DocumentMK$Builder.getNodeStore(DocumentMK.java:667)
>   at 
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreIT.modifiedResetWithDiff(DocumentNodeStoreIT.java:70)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>   at java.lang.reflect.Method.invoke(Method.java:597)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at org.junit.runners.Suite.runChild(Suite.java:128)
>   at org.junit.runners.Suite.runChild(Suite.java:27)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at 
> org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:86)
>   at 
> org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
>   at 
> org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:459)
>   at 
> org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:675)
>   at 
> org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:382)
>   at 
> org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:192)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OAK-1953) Oak console on MongoMK fails with NPE

2016-05-10 Thread Julian Reschke (JIRA)

 [ 
https://issues.apache.org/jira/browse/OAK-1953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-1953:

Labels: candidate_oak_1_0  (was: )

> Oak console on MongoMK fails with NPE
> -
>
> Key: OAK-1953
> URL: https://issues.apache.org/jira/browse/OAK-1953
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: core, documentmk, mongomk, rdbmk, run
>Affects Versions: 1.0.30
>Reporter: Marcel Reutegger
>Assignee: Marcel Reutegger
>  Labels: candidate_oak_1_0
> Fix For: 1.1.0
>
>
> The exception is:
> {noformat}
> Apache Jackrabbit Oak 1.1-SNAPSHOT
> Exception in thread "main" java.lang.NullPointerException: Lease End Time not 
> set
>   at 
> com.google.common.base.Preconditions.checkNotNull(Preconditions.java:209)
>   at 
> org.apache.jackrabbit.oak.plugins.document.ClusterNodeInfoDocument.getLeaseEndTime(ClusterNodeInfoDocument.java:41)
>   at 
> org.apache.jackrabbit.oak.plugins.document.LastRevRecoveryAgent.recover(LastRevRecoveryAgent.java:81)
>   at 
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStore.checkLastRevRecovery(DocumentNodeStore.java:425)
>   at 
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStore.(DocumentNodeStore.java:404)
>   at 
> org.apache.jackrabbit.oak.plugins.document.DocumentMK$Builder.getNodeStore(DocumentMK.java:582)
>   at org.apache.jackrabbit.oak.console.Console.main(Console.java:72)
>   at org.apache.jackrabbit.oak.run.Main.main(Main.java:118)
> {noformat}
> The document in the clusterNodes collection looks like this:
> {noformat}
> {
>   "_id" : "1",
>   "state" : null,
>   "leaseEnd" : null,
>   "instance" : "/Users/mreutegg/test",
>   "machine" : "mac:685b35b878ea",
>   "recoveryLock" : null,
>   "info" : "id: 1,\nstartTime: 1404725920370,\nmachineId: 
> mac:685b35b878ea,\ninstanceId: /Users/mreutegg/test,\npid: 40619,\nuuid: 
> 5cca6177-1062-441c-a86b-ec7bf848917d,\nreadWriteMode: null,\nstate: 
> NONE,\nrevLock: NONE",
>   "_modCount" : NumberLong(52)
> }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OAK-1953) Oak console on MongoMK fails with NPE

2016-05-10 Thread Julian Reschke (JIRA)

 [ 
https://issues.apache.org/jira/browse/OAK-1953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-1953:

Component/s: rdbmk
 documentmk

> Oak console on MongoMK fails with NPE
> -
>
> Key: OAK-1953
> URL: https://issues.apache.org/jira/browse/OAK-1953
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: core, documentmk, mongomk, rdbmk, run
>Affects Versions: 1.0.30
>Reporter: Marcel Reutegger
>Assignee: Marcel Reutegger
> Fix For: 1.1.0
>
>
> The exception is:
> {noformat}
> Apache Jackrabbit Oak 1.1-SNAPSHOT
> Exception in thread "main" java.lang.NullPointerException: Lease End Time not 
> set
>   at 
> com.google.common.base.Preconditions.checkNotNull(Preconditions.java:209)
>   at 
> org.apache.jackrabbit.oak.plugins.document.ClusterNodeInfoDocument.getLeaseEndTime(ClusterNodeInfoDocument.java:41)
>   at 
> org.apache.jackrabbit.oak.plugins.document.LastRevRecoveryAgent.recover(LastRevRecoveryAgent.java:81)
>   at 
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStore.checkLastRevRecovery(DocumentNodeStore.java:425)
>   at 
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStore.(DocumentNodeStore.java:404)
>   at 
> org.apache.jackrabbit.oak.plugins.document.DocumentMK$Builder.getNodeStore(DocumentMK.java:582)
>   at org.apache.jackrabbit.oak.console.Console.main(Console.java:72)
>   at org.apache.jackrabbit.oak.run.Main.main(Main.java:118)
> {noformat}
> The document in the clusterNodes collection looks like this:
> {noformat}
> {
>   "_id" : "1",
>   "state" : null,
>   "leaseEnd" : null,
>   "instance" : "/Users/mreutegg/test",
>   "machine" : "mac:685b35b878ea",
>   "recoveryLock" : null,
>   "info" : "id: 1,\nstartTime: 1404725920370,\nmachineId: 
> mac:685b35b878ea,\ninstanceId: /Users/mreutegg/test,\npid: 40619,\nuuid: 
> 5cca6177-1062-441c-a86b-ec7bf848917d,\nreadWriteMode: null,\nstate: 
> NONE,\nrevLock: NONE",
>   "_modCount" : NumberLong(52)
> }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OAK-1953) Oak console on MongoMK fails with NPE

2016-05-10 Thread Julian Reschke (JIRA)

 [ 
https://issues.apache.org/jira/browse/OAK-1953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-1953:

Affects Version/s: (was: 1.0)
   1.0.30

> Oak console on MongoMK fails with NPE
> -
>
> Key: OAK-1953
> URL: https://issues.apache.org/jira/browse/OAK-1953
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: core, documentmk, mongomk, rdbmk, run
>Affects Versions: 1.0.30
>Reporter: Marcel Reutegger
>Assignee: Marcel Reutegger
> Fix For: 1.1.0
>
>
> The exception is:
> {noformat}
> Apache Jackrabbit Oak 1.1-SNAPSHOT
> Exception in thread "main" java.lang.NullPointerException: Lease End Time not 
> set
>   at 
> com.google.common.base.Preconditions.checkNotNull(Preconditions.java:209)
>   at 
> org.apache.jackrabbit.oak.plugins.document.ClusterNodeInfoDocument.getLeaseEndTime(ClusterNodeInfoDocument.java:41)
>   at 
> org.apache.jackrabbit.oak.plugins.document.LastRevRecoveryAgent.recover(LastRevRecoveryAgent.java:81)
>   at 
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStore.checkLastRevRecovery(DocumentNodeStore.java:425)
>   at 
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStore.(DocumentNodeStore.java:404)
>   at 
> org.apache.jackrabbit.oak.plugins.document.DocumentMK$Builder.getNodeStore(DocumentMK.java:582)
>   at org.apache.jackrabbit.oak.console.Console.main(Console.java:72)
>   at org.apache.jackrabbit.oak.run.Main.main(Main.java:118)
> {noformat}
> The document in the clusterNodes collection looks like this:
> {noformat}
> {
>   "_id" : "1",
>   "state" : null,
>   "leaseEnd" : null,
>   "instance" : "/Users/mreutegg/test",
>   "machine" : "mac:685b35b878ea",
>   "recoveryLock" : null,
>   "info" : "id: 1,\nstartTime: 1404725920370,\nmachineId: 
> mac:685b35b878ea,\ninstanceId: /Users/mreutegg/test,\npid: 40619,\nuuid: 
> 5cca6177-1062-441c-a86b-ec7bf848917d,\nreadWriteMode: null,\nstate: 
> NONE,\nrevLock: NONE",
>   "_modCount" : NumberLong(52)
> }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OAK-4356) DocumentNodeStoreIT.modifiedResetWithDiff fails for various RDBs

2016-05-10 Thread Julian Reschke (JIRA)

[ 
https://issues.apache.org/jira/browse/OAK-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15277992#comment-15277992
 ] 

Julian Reschke commented on OAK-4356:
-

Apparently the same issue as OAK-1953.

> DocumentNodeStoreIT.modifiedResetWithDiff fails for various RDBs
> 
>
> Key: OAK-4356
> URL: https://issues.apache.org/jira/browse/OAK-4356
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: documentmk, rdbmk
>Affects Versions: 1.0.30
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
>
> java.lang.NullPointerException: Lease End Time not set
>   at 
> com.google.common.base.Preconditions.checkNotNull(Preconditions.java:209)
>   at 
> org.apache.jackrabbit.oak.plugins.document.ClusterNodeInfoDocument.getLeaseEndTime(ClusterNodeInfoDocument.java:43)
>   at 
> org.apache.jackrabbit.oak.plugins.document.LastRevRecoveryAgent.recover(LastRevRecoveryAgent.java:84)
>   at 
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStore.checkLastRevRecovery(DocumentNodeStore.java:506)
>   at 
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStore.(DocumentNodeStore.java:483)
>   at 
> org.apache.jackrabbit.oak.plugins.document.DocumentMK$Builder.getNodeStore(DocumentMK.java:667)
>   at 
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreIT.modifiedResetWithDiff(DocumentNodeStoreIT.java:70)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>   at java.lang.reflect.Method.invoke(Method.java:597)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at org.junit.runners.Suite.runChild(Suite.java:128)
>   at org.junit.runners.Suite.runChild(Suite.java:27)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at 
> org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:86)
>   at 
> org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
>   at 
> org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:459)
>   at 
> org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:675)
>   at 
> org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:382)
>   at 
> org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:192)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OAK-4356) DocumentNodeStoreIT.modifiedResetWithDiff fails for various RDBs

2016-05-10 Thread Julian Reschke (JIRA)

 [ 
https://issues.apache.org/jira/browse/OAK-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-4356:

Priority: Minor  (was: Major)

> DocumentNodeStoreIT.modifiedResetWithDiff fails for various RDBs
> 
>
> Key: OAK-4356
> URL: https://issues.apache.org/jira/browse/OAK-4356
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: documentmk, rdbmk
>Affects Versions: 1.0.30
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
>
> java.lang.NullPointerException: Lease End Time not set
>   at 
> com.google.common.base.Preconditions.checkNotNull(Preconditions.java:209)
>   at 
> org.apache.jackrabbit.oak.plugins.document.ClusterNodeInfoDocument.getLeaseEndTime(ClusterNodeInfoDocument.java:43)
>   at 
> org.apache.jackrabbit.oak.plugins.document.LastRevRecoveryAgent.recover(LastRevRecoveryAgent.java:84)
>   at 
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStore.checkLastRevRecovery(DocumentNodeStore.java:506)
>   at 
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStore.(DocumentNodeStore.java:483)
>   at 
> org.apache.jackrabbit.oak.plugins.document.DocumentMK$Builder.getNodeStore(DocumentMK.java:667)
>   at 
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreIT.modifiedResetWithDiff(DocumentNodeStoreIT.java:70)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>   at java.lang.reflect.Method.invoke(Method.java:597)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at org.junit.runners.Suite.runChild(Suite.java:128)
>   at org.junit.runners.Suite.runChild(Suite.java:27)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at 
> org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:86)
>   at 
> org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
>   at 
> org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:459)
>   at 
> org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:675)
>   at 
> org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:382)
>   at 
> org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:192)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (OAK-4294) Consider making FileStore.writer volatile

2016-05-10 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/OAK-4294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Dürig resolved OAK-4294.

Resolution: Fixed

Fixed at http://svn.apache.org/viewvc?rev=1743157=rev

> Consider making FileStore.writer volatile
> -
>
> Key: OAK-4294
> URL: https://issues.apache.org/jira/browse/OAK-4294
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: segment-tar
>Reporter: Michael Dürig
>Assignee: Michael Dürig
>Priority: Minor
>  Labels: technical_debt
> Fix For: 1.6
>
> Attachments: OAK_4294.patch
>
>
> That filed is not volatile although access by different threads. We should 
> consider changing it to volatile.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OAK-4356) DocumentNodeStoreIT.modifiedResetWithDiff fails for various RDBs

2016-05-10 Thread Julian Reschke (JIRA)

[ 
https://issues.apache.org/jira/browse/OAK-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15277966#comment-15277966
 ] 

Julian Reschke commented on OAK-4356:
-

Apparently this can happen if there's an existing cluster node info record from 
a different test run where leaseEnd == null.

We need to understand what exactly is leaving these entries around, and whether 
that state is ok.

> DocumentNodeStoreIT.modifiedResetWithDiff fails for various RDBs
> 
>
> Key: OAK-4356
> URL: https://issues.apache.org/jira/browse/OAK-4356
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: documentmk, rdbmk
>Affects Versions: 1.0.30
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>
> java.lang.NullPointerException: Lease End Time not set
>   at 
> com.google.common.base.Preconditions.checkNotNull(Preconditions.java:209)
>   at 
> org.apache.jackrabbit.oak.plugins.document.ClusterNodeInfoDocument.getLeaseEndTime(ClusterNodeInfoDocument.java:43)
>   at 
> org.apache.jackrabbit.oak.plugins.document.LastRevRecoveryAgent.recover(LastRevRecoveryAgent.java:84)
>   at 
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStore.checkLastRevRecovery(DocumentNodeStore.java:506)
>   at 
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStore.(DocumentNodeStore.java:483)
>   at 
> org.apache.jackrabbit.oak.plugins.document.DocumentMK$Builder.getNodeStore(DocumentMK.java:667)
>   at 
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreIT.modifiedResetWithDiff(DocumentNodeStoreIT.java:70)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>   at java.lang.reflect.Method.invoke(Method.java:597)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at org.junit.runners.Suite.runChild(Suite.java:128)
>   at org.junit.runners.Suite.runChild(Suite.java:27)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at 
> org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:86)
>   at 
> org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
>   at 
> org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:459)
>   at 
> org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:675)
>   at 
> org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:382)
>   at 
> org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:192)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Reopened] (OAK-4288) TarReader.calculateForwardReferences only used by oak-run graph tool

2016-05-10 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/OAK-4288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Dürig reopened OAK-4288:


Oops, wrong issue. Reopening. 

> TarReader.calculateForwardReferences only used by oak-run graph tool
> 
>
> Key: OAK-4288
> URL: https://issues.apache.org/jira/browse/OAK-4288
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: segment-tar
>Reporter: Michael Dürig
>Assignee: Michael Dürig
>Priority: Minor
>  Labels: cleanup, gc, tooling
> Fix For: 1.6
>
>
> {{TarReader.calculateForwardReferences}} is not used for production but only 
> for tooling so it would be good if we could remove that method from the 
> production code an put it into a tooling specific module. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Issue Comment Deleted] (OAK-4288) TarReader.calculateForwardReferences only used by oak-run graph tool

2016-05-10 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/OAK-4288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Dürig updated OAK-4288:
---
Comment: was deleted

(was: Fixed at http://svn.apache.org/viewvc?rev=1743157=rev)

> TarReader.calculateForwardReferences only used by oak-run graph tool
> 
>
> Key: OAK-4288
> URL: https://issues.apache.org/jira/browse/OAK-4288
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: segment-tar
>Reporter: Michael Dürig
>Assignee: Michael Dürig
>Priority: Minor
>  Labels: cleanup, gc, tooling
> Fix For: 1.6
>
>
> {{TarReader.calculateForwardReferences}} is not used for production but only 
> for tooling so it would be good if we could remove that method from the 
> production code an put it into a tooling specific module. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (OAK-4288) TarReader.calculateForwardReferences only used by oak-run graph tool

2016-05-10 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/OAK-4288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Dürig resolved OAK-4288.

Resolution: Fixed

Fixed at http://svn.apache.org/viewvc?rev=1743157=rev

> TarReader.calculateForwardReferences only used by oak-run graph tool
> 
>
> Key: OAK-4288
> URL: https://issues.apache.org/jira/browse/OAK-4288
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: segment-tar
>Reporter: Michael Dürig
>Assignee: Michael Dürig
>Priority: Minor
>  Labels: cleanup, gc, tooling
> Fix For: 1.6
>
>
> {{TarReader.calculateForwardReferences}} is not used for production but only 
> for tooling so it would be good if we could remove that method from the 
> production code an put it into a tooling specific module. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OAK-4356) DocumentNodeStoreIT.modifiedResetWithDiff fails for various RDBs

2016-05-10 Thread Julian Reschke (JIRA)
Julian Reschke created OAK-4356:
---

 Summary: DocumentNodeStoreIT.modifiedResetWithDiff fails for 
various RDBs
 Key: OAK-4356
 URL: https://issues.apache.org/jira/browse/OAK-4356
 Project: Jackrabbit Oak
  Issue Type: Technical task
  Components: documentmk, rdbmk
Affects Versions: 1.0.30
Reporter: Julian Reschke
Assignee: Julian Reschke


java.lang.NullPointerException: Lease End Time not set
at 
com.google.common.base.Preconditions.checkNotNull(Preconditions.java:209)
at 
org.apache.jackrabbit.oak.plugins.document.ClusterNodeInfoDocument.getLeaseEndTime(ClusterNodeInfoDocument.java:43)
at 
org.apache.jackrabbit.oak.plugins.document.LastRevRecoveryAgent.recover(LastRevRecoveryAgent.java:84)
at 
org.apache.jackrabbit.oak.plugins.document.DocumentNodeStore.checkLastRevRecovery(DocumentNodeStore.java:506)
at 
org.apache.jackrabbit.oak.plugins.document.DocumentNodeStore.(DocumentNodeStore.java:483)
at 
org.apache.jackrabbit.oak.plugins.document.DocumentMK$Builder.getNodeStore(DocumentMK.java:667)
at 
org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreIT.modifiedResetWithDiff(DocumentNodeStoreIT.java:70)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at 
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at 
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at org.junit.runners.Suite.runChild(Suite.java:128)
at org.junit.runners.Suite.runChild(Suite.java:27)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at 
org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:86)
at 
org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
at 
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:459)
at 
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:675)
at 
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:382)
at 
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:192)





--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Reopened] (OAK-4154) SynchronizationMBean.syncUsers(...) should optionally not force group sync.

2016-05-10 Thread angela (JIRA)

 [ 
https://issues.apache.org/jira/browse/OAK-4154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

angela reopened OAK-4154:
-

i don't see any test-cases for this new feature IMO this is crucial and a 
mandatory part of any changes. i already created an JIRA issue for the missing 
test-coverage for existing functionality but that doesn't mean that I am the 
responsible dev to write tests for new stuff you add.

therefore reopening issue.

> SynchronizationMBean.syncUsers(...) should optionally not force group sync.
> ---
>
> Key: OAK-4154
> URL: https://issues.apache.org/jira/browse/OAK-4154
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: auth-external
>Reporter: Manfred Baedke
>Assignee: Manfred Baedke
> Fix For: 1.6
>
>
> SynchronizationMBean.syncUsers(...) and related methods always force group 
> synchronization. This may have a huge negative impact on the performance of 
> these methods.
> Additional methods should be added to the interface 
> org.apache.jackrabbit.oak.spi.security.authentication.external.impl.jmx.SynchronizationMBean,
>  featuring an additional boolean argument to enable or disable group sync.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (OAK-4294) Consider making FileStore.writer volatile

2016-05-10 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/OAK-4294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Dürig reassigned OAK-4294:
--

Assignee: Michael Dürig

> Consider making FileStore.writer volatile
> -
>
> Key: OAK-4294
> URL: https://issues.apache.org/jira/browse/OAK-4294
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: segment-tar
>Reporter: Michael Dürig
>Assignee: Michael Dürig
>Priority: Minor
>  Labels: technical_debt
> Fix For: 1.6
>
> Attachments: OAK_4294.patch
>
>
> That filed is not volatile although access by different threads. We should 
> consider changing it to volatile.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (OAK-4286) Rework failing tests in CompactionAndCleanupIT

2016-05-10 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/OAK-4286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Dürig resolved OAK-4286.

Resolution: Fixed

FIxed at http://svn.apache.org/viewvc?rev=1743146=rev

> Rework failing tests in CompactionAndCleanupIT
> --
>
> Key: OAK-4286
> URL: https://issues.apache.org/jira/browse/OAK-4286
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: segment-tar
>Reporter: Michael Dürig
>Assignee: Michael Dürig
>  Labels: cleanup, compaction, gc, tests
> Fix For: 1.6
>
>
> The fix for OAK-3348 caused some of the tests in {{CompactionAndCleanupIT}} 
> to fail and I put the to ignored for the time being. We need to check whether 
> the test expectations still hold and rework them as required. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OAK-4321) Improve conflict exception message to show if conflict is unexpected

2016-05-10 Thread Marcel Reutegger (JIRA)

[ 
https://issues.apache.org/jira/browse/OAK-4321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15277870#comment-15277870
 ] 

Marcel Reutegger commented on OAK-4321:
---

The check is not quite correct, it will report that a revision is older than 
the base revision vector when it is actually equal. I think the patch should 
look like this:

{noformat}
--- 
a/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/document/Commit.java
+++ 
b/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/document/Commit.java
@@ -42,6 +42,7 @@ import org.apache.jackrabbit.oak.spi.state.NodeState;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
+import static com.google.common.base.Objects.equal;
 import static com.google.common.base.Preconditions.checkNotNull;
 import static com.google.common.collect.Iterables.filter;
 import static com.google.common.collect.Iterables.transform;
@@ -565,6 +566,10 @@ public class Commit {
 private String formatConflictRevision(Revision r) {
 if (nodeStore.getHeadRevision().isRevisionNewer(r)) {
 return r + " (not yet visible)";
+} else if (baseRevision != null
+&& !baseRevision.isRevisionNewer(r)
+&& !equal(baseRevision.getRevision(r.getClusterId()), r)) {
+return r + " (older than base - " + baseRevision + ")";
 } else {
 return r.toString();
 }
{noformat}

> Improve conflict exception message to show if conflict is unexpected
> 
>
> Key: OAK-4321
> URL: https://issues.apache.org/jira/browse/OAK-4321
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: core, documentmk
>Reporter: Vikas Saurabh
>Assignee: Vikas Saurabh
>Priority: Minor
>  Labels: candidate_oak_1_0, candidate_oak_1_2, candidate_oak_1_4
> Fix For: 1.6
>
> Attachments: OAK-4321-1.0.diff
>
>
> Merge exception (aka OakMerge) are often expected when concurrent 
> sessions do conflicting writes. But in some occasions, we've seen bugs in oak 
> which also lead to merge exception.
> This creates confusion during investigation to isolate if it's an issue in 
> oak or a genuine concurrent conflict.
> It'd be useful if the exception message has information to distinguish that.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OAK-1963) Expose URL for Blob source

2016-05-10 Thread Thomas Mueller (JIRA)

[ 
https://issues.apache.org/jira/browse/OAK-1963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15277825#comment-15277825
 ] 

Thomas Mueller commented on OAK-1963:
-

So this would only give access to data that is already available (another _way_ 
to access the same data). The problem is that an URL can be more easily copied 
because it is shorter. So it is more of an encapsulation / API design 
(philosophy) problem than an access right problem. Same as for JCR-3534.

It would be good to have more details on the exact use case. I assume it's just 
for Amazon S3 right now. Where is the URL used (is it rendered on the page for 
example), does it need to be available for any kind of user / session, or could 
the feature be restricted to certain cases (ACLs).

More details for justification would be nice. Do we want to improve 
performance, do we know how much it would bring, or do we want to reduce cost 
(reduce traffic to a web server), or both.

One option might be a new API to get the  a node path + property name + index 
(for multi-valued properties) to an S3 URL, and not directly for a 
javax.jcr.Binary or Value. So that access to the path and property could be 
checked.

> Expose URL for Blob source 
> ---
>
> Key: OAK-1963
> URL: https://issues.apache.org/jira/browse/OAK-1963
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: core
>Reporter: Pralaypati Ta
>Assignee: Chetan Mehrotra
>  Labels: datastore
> Fix For: 1.6
>
>
> In certain scenarios for performance reasons its desirable to have direct 
> access to the Blob source. 
> For e.g. if using a FileDataStore having a direct access to the native file 
> system path of the blob (if not stored in chunks) is more useful than 
> repository path e.g. native tools don't understand repository path, instead 
> file system path can be passed directly to native tools for processing binary.
> Another usecase being ability exposed signed S3 url which would allow access 
> to binary content directly



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OAK-3574) Query engine: support p=lowercase('x') and other function-based indexes

2016-05-10 Thread Thomas Mueller (JIRA)

 [ 
https://issues.apache.org/jira/browse/OAK-3574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Thomas Mueller updated OAK-3574:

Description: 
Currently, the query engine and indexes don't support function-based indexes 
for conditions of the form lowercase(property) = 'x'. This needs to be 
supported, specially for the Lucene property index.

Also important is lowercase(name()).

  was:Currently, the query engine and indexes don't support function-based 
indexes for conditions of the form lowercase(property) = 'x'. This needs to be 
supported, specially for the Lucene property index.


> Query engine: support p=lowercase('x') and other function-based indexes
> ---
>
> Key: OAK-3574
> URL: https://issues.apache.org/jira/browse/OAK-3574
> Project: Jackrabbit Oak
>  Issue Type: New Feature
>  Components: core, query
>Reporter: Thomas Mueller
>Assignee: Thomas Mueller
>
> Currently, the query engine and indexes don't support function-based indexes 
> for conditions of the form lowercase(property) = 'x'. This needs to be 
> supported, specially for the Lucene property index.
> Also important is lowercase(name()).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OAK-3879) Lucene index / compatVersion 2: search for 'abc!' does not work

2016-05-10 Thread Chetan Mehrotra (JIRA)

 [ 
https://issues.apache.org/jira/browse/OAK-3879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chetan Mehrotra updated OAK-3879:
-
   Labels: docs-impacting  (was: candidate_oak_1_2 docs-impacting)
Fix Version/s: 1.2.15

Merged to 
* 1.2 - [1743103|http://svn.apache.org/r1743103]

> Lucene index / compatVersion 2: search for 'abc!' does not work
> ---
>
> Key: OAK-3879
> URL: https://issues.apache.org/jira/browse/OAK-3879
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: lucene
>Reporter: Thomas Mueller
>Assignee: Chetan Mehrotra
>  Labels: docs-impacting
> Fix For: 1.4, 1.3.15, 1.2.15
>
> Attachments: OAK-3879-v1.patch
>
>
> When using a Lucene fulltext index with compatVersion 2, then the following 
> query does not return any results. When using compatVersion 1, the correct 
> result is returned.
> {noformat}
> SELECT * FROM [nt:unstructured] AS c 
> WHERE CONTAINS(c.[jcr:description], 'abc!') 
> AND ISDESCENDANTNODE(c, '/content')
> {noformat}
> With compatVersion 1 and 2, searching for just 'abc' works. Also, searching 
> with '=' instead of 'contains' works.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)