[jira] [Commented] (OAK-5022) add includeSubtreeOnDelete flag to OakEventFilter
[ https://issues.apache.org/jira/browse/OAK-5022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15620015#comment-15620015 ] Michael Marth commented on OAK-5022: 2 comments: * Hooray for being able (in the application) to access property values of deleted nodes. This is a long standing feature request - which should be rather doable in MVCC. * Re "includeSubtreeOnRemove": need to careful to not make this a very expensive operation for large subtrees. Could this be handled lazily? > add includeSubtreeOnDelete flag to OakEventFilter > - > > Key: OAK-5022 > URL: https://issues.apache.org/jira/browse/OAK-5022 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: jcr >Affects Versions: 1.5.12 >Reporter: Stefan Egli >Assignee: Stefan Egli > > (Originally reported as JCR-4037, but moved to Oak as a result of introducing > the OakEventFilter in OAK-5013. From the original description: ) > In some cases of observation it would be useful to receive events of child > node or properties of a parent/grandparent that was deleted. Currently (in > Oak at least) one only receives a deleted event for the node that was deleted > and none of the children. > Suggesting to (re)introduce a flag, eg as follows to the > JackrabbitEventFilter: > {code} > boolean includeSubtreeOnRemove; > {code} > (Open for any better name of course) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OAK-4969) ColdStandby does not fetch missing blobs
[ https://issues.apache.org/jira/browse/OAK-4969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothee Maret updated OAK-4969: Fix Version/s: 1.2 1.4 > ColdStandby does not fetch missing blobs > > > Key: OAK-4969 > URL: https://issues.apache.org/jira/browse/OAK-4969 > Project: Jackrabbit Oak > Issue Type: Bug > Components: segment-tar, segmentmk >Affects Versions: Segment Tar 0.0.10 >Reporter: Timothee Maret >Assignee: Timothee Maret > Fix For: 1.2, 1.4, 1.6, 1.5.13 > > Attachments: OAK-4969-oak-tarmk-standby.patch, OAK-4969.patch > > > 1. In a setup composed of two instances (primary, standby) configured with a > custom blob store (File blob store). > 2. On the primary instance, set/update a BINARY property of an existing > resource with > 2MB binary. > 3. Observe that the standby instance does not fetch the binary and instead, > enters a loop detecting the missing binary upon comparing node states. > For example, the following stack trace would be printed every 5 seconds on > the standby (the polling time is 5sec). > {code} > 19.10.2016 16:22:38.035 *DEBUG* [nioEventLoopGroup-1005-1] > org.apache.jackrabbit.oak.segment.standby.codec.ResponseDecoder Decoding 'get > head' response > 19.10.2016 16:22:38.038 *DEBUG* [sling-default-81-Registered Service.607] > org.apache.jackrabbit.oak.segment.standby.client.StandbyClient Channel closed > 19.10.2016 16:22:40.241 *DEBUG* [sling-default-81-Registered Service.607] > org.apache.jackrabbit.oak.segment.standby.client.StandbyClient Group shut down > 19.10.2016 16:22:40.242 *ERROR* [sling-default-81-Registered Service.607] > org.apache.jackrabbit.oak.segment.standby.client.StandbyClientSync Failed > synchronizing state. > java.lang.RuntimeException: Error occurred while obtaining InputStream for > blobId [4dfc748c91d518c9221031ec6115fd7ac04fe27b#10] > at > org.apache.jackrabbit.oak.plugins.blob.BlobStoreBlob.getNewStream(BlobStoreBlob.java:49) > at > org.apache.jackrabbit.oak.segment.SegmentBlob.getNewStream(SegmentBlob.java:252) > at > org.apache.jackrabbit.oak.segment.SegmentBlob.getNewStream(SegmentBlob.java:87) > at > org.apache.jackrabbit.oak.plugins.memory.AbstractBlob$1.getInput(AbstractBlob.java:45) > at > org.apache.jackrabbit.oak.plugins.memory.AbstractBlob$1.getInput(AbstractBlob.java:42) > at com.google.common.io.ByteStreams$3.openStream(ByteStreams.java:907) > at com.google.common.io.ByteSource.contentEquals(ByteSource.java:301) > at com.google.common.io.ByteStreams.equal(ByteStreams.java:661) > at > org.apache.jackrabbit.oak.plugins.memory.AbstractBlob.equal(AbstractBlob.java:68) > at > org.apache.jackrabbit.oak.segment.SegmentBlob.equals(SegmentBlob.java:193) > at com.google.common.base.Objects.equal(Objects.java:55) > at > org.apache.jackrabbit.oak.plugins.memory.AbstractPropertyState.equal(AbstractPropertyState.java:53) > at > org.apache.jackrabbit.oak.segment.SegmentPropertyState.equals(SegmentPropertyState.java:249) > at > org.apache.jackrabbit.oak.segment.SegmentNodeState.compareProperties(SegmentNodeState.java:622) > at > org.apache.jackrabbit.oak.segment.SegmentNodeState.compareAgainstBaseState(SegmentNodeState.java:516) > at > org.apache.jackrabbit.oak.segment.standby.client.StandbyDiff.process(StandbyDiff.java:216) > at > org.apache.jackrabbit.oak.segment.standby.client.StandbyDiff.childNodeChanged(StandbyDiff.java:186) > at > org.apache.jackrabbit.oak.segment.MapRecord.compare(MapRecord.java:415) > at > org.apache.jackrabbit.oak.segment.SegmentNodeState.compareAgainstBaseState(SegmentNodeState.java:609) > at > org.apache.jackrabbit.oak.segment.standby.client.StandbyDiff.process(StandbyDiff.java:216) > at > org.apache.jackrabbit.oak.segment.standby.client.StandbyDiff.childNodeChanged(StandbyDiff.java:186) > at > org.apache.jackrabbit.oak.segment.MapRecord.compare(MapRecord.java:457) > at > org.apache.jackrabbit.oak.segment.SegmentNodeState.compareAgainstBaseState(SegmentNodeState.java:609) > at > org.apache.jackrabbit.oak.segment.standby.client.StandbyDiff.process(StandbyDiff.java:216) > at > org.apache.jackrabbit.oak.segment.standby.client.StandbyDiff.childNodeChanged(StandbyDiff.java:186) > at > org.apache.jackrabbit.oak.segment.MapRecord$2.childNodeChanged(MapRecord.java:401) > at > org.apache.jackrabbit.oak.segment.MapRecord$3.childNodeChanged(MapRecord.java:442) > at > org.apache.jackrabbit.oak.segment.MapRecord.compare(MapRecord.java:485) > at > org.apache.jackrabbit.oak.segment.MapRecord.compare(MapRecord.java:433) > at > org.apache.jackrabbit.oak.segment.MapRecord.compare(MapRecord.
[jira] [Comment Edited] (OAK-4969) ColdStandby does not fetch missing blobs
[ https://issues.apache.org/jira/browse/OAK-4969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15616810#comment-15616810 ] Timothee Maret edited comment on OAK-4969 at 10/30/16 1:43 PM: --- [~frm] thanks for your insight. I found a clean way to fix this. Actually the {{StandbyDiff}} allows to intercept the exception at the required node level and attempt loading its binary properties. This issue affects the previous standby implementation ({{oak-tarmk-standby}}). I have attached two patches, one for each standby implementation, which contain 1. a test that reproduce the issue 2. the fix for the trunk [~frm] Could you have a look at the patch {{OAK-4969.patch}} (fix for {{oak-segment-tar}} ? [~alexparvulescu] Could you have a look at the patch {{OAK-4969-oak-tarmk-standby.patch}} (fix for {{oak-tarmk-standby}}) ? was (Author: marett): [~frm] thanks for your insight. I found a clean way to fix this. Actually the {{StandbyDiff}} allows to intercept the exception at the required node level and attempt loading its binary properties. I have attached a patch that contains 1. a test that reproduce the issue 2. the fix for the trunk Could you have a look at the patch ? This issue affects the previous standby implementation ({{oak-tarmk-standby}}). Should I open a separate issue for tracking the fix there (AFAIK, it is not strictly speaking a backport) ? > ColdStandby does not fetch missing blobs > > > Key: OAK-4969 > URL: https://issues.apache.org/jira/browse/OAK-4969 > Project: Jackrabbit Oak > Issue Type: Bug > Components: segment-tar, segmentmk >Affects Versions: Segment Tar 0.0.10 >Reporter: Timothee Maret >Assignee: Timothee Maret > Fix For: 1.6, 1.5.13 > > Attachments: OAK-4969-oak-tarmk-standby.patch, OAK-4969.patch > > > 1. In a setup composed of two instances (primary, standby) configured with a > custom blob store (File blob store). > 2. On the primary instance, set/update a BINARY property of an existing > resource with > 2MB binary. > 3. Observe that the standby instance does not fetch the binary and instead, > enters a loop detecting the missing binary upon comparing node states. > For example, the following stack trace would be printed every 5 seconds on > the standby (the polling time is 5sec). > {code} > 19.10.2016 16:22:38.035 *DEBUG* [nioEventLoopGroup-1005-1] > org.apache.jackrabbit.oak.segment.standby.codec.ResponseDecoder Decoding 'get > head' response > 19.10.2016 16:22:38.038 *DEBUG* [sling-default-81-Registered Service.607] > org.apache.jackrabbit.oak.segment.standby.client.StandbyClient Channel closed > 19.10.2016 16:22:40.241 *DEBUG* [sling-default-81-Registered Service.607] > org.apache.jackrabbit.oak.segment.standby.client.StandbyClient Group shut down > 19.10.2016 16:22:40.242 *ERROR* [sling-default-81-Registered Service.607] > org.apache.jackrabbit.oak.segment.standby.client.StandbyClientSync Failed > synchronizing state. > java.lang.RuntimeException: Error occurred while obtaining InputStream for > blobId [4dfc748c91d518c9221031ec6115fd7ac04fe27b#10] > at > org.apache.jackrabbit.oak.plugins.blob.BlobStoreBlob.getNewStream(BlobStoreBlob.java:49) > at > org.apache.jackrabbit.oak.segment.SegmentBlob.getNewStream(SegmentBlob.java:252) > at > org.apache.jackrabbit.oak.segment.SegmentBlob.getNewStream(SegmentBlob.java:87) > at > org.apache.jackrabbit.oak.plugins.memory.AbstractBlob$1.getInput(AbstractBlob.java:45) > at > org.apache.jackrabbit.oak.plugins.memory.AbstractBlob$1.getInput(AbstractBlob.java:42) > at com.google.common.io.ByteStreams$3.openStream(ByteStreams.java:907) > at com.google.common.io.ByteSource.contentEquals(ByteSource.java:301) > at com.google.common.io.ByteStreams.equal(ByteStreams.java:661) > at > org.apache.jackrabbit.oak.plugins.memory.AbstractBlob.equal(AbstractBlob.java:68) > at > org.apache.jackrabbit.oak.segment.SegmentBlob.equals(SegmentBlob.java:193) > at com.google.common.base.Objects.equal(Objects.java:55) > at > org.apache.jackrabbit.oak.plugins.memory.AbstractPropertyState.equal(AbstractPropertyState.java:53) > at > org.apache.jackrabbit.oak.segment.SegmentPropertyState.equals(SegmentPropertyState.java:249) > at > org.apache.jackrabbit.oak.segment.SegmentNodeState.compareProperties(SegmentNodeState.java:622) > at > org.apache.jackrabbit.oak.segment.SegmentNodeState.compareAgainstBaseState(SegmentNodeState.java:516) > at > org.apache.jackrabbit.oak.segment.standby.client.StandbyDiff.process(StandbyDiff.java:216) > at > org.apache.jackrabbit.oak.segment.standby.client.StandbyDiff.childNodeChanged(StandbyDiff.java:186) > at > org.apache.jackrabbit.oa
[jira] [Updated] (OAK-4969) ColdStandby does not fetch missing blobs
[ https://issues.apache.org/jira/browse/OAK-4969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothee Maret updated OAK-4969: Attachment: OAK-4969-oak-tarmk-standby.patch > ColdStandby does not fetch missing blobs > > > Key: OAK-4969 > URL: https://issues.apache.org/jira/browse/OAK-4969 > Project: Jackrabbit Oak > Issue Type: Bug > Components: segment-tar, segmentmk >Affects Versions: Segment Tar 0.0.10 >Reporter: Timothee Maret >Assignee: Timothee Maret > Fix For: 1.6, 1.5.13 > > Attachments: OAK-4969-oak-tarmk-standby.patch, OAK-4969.patch > > > 1. In a setup composed of two instances (primary, standby) configured with a > custom blob store (File blob store). > 2. On the primary instance, set/update a BINARY property of an existing > resource with > 2MB binary. > 3. Observe that the standby instance does not fetch the binary and instead, > enters a loop detecting the missing binary upon comparing node states. > For example, the following stack trace would be printed every 5 seconds on > the standby (the polling time is 5sec). > {code} > 19.10.2016 16:22:38.035 *DEBUG* [nioEventLoopGroup-1005-1] > org.apache.jackrabbit.oak.segment.standby.codec.ResponseDecoder Decoding 'get > head' response > 19.10.2016 16:22:38.038 *DEBUG* [sling-default-81-Registered Service.607] > org.apache.jackrabbit.oak.segment.standby.client.StandbyClient Channel closed > 19.10.2016 16:22:40.241 *DEBUG* [sling-default-81-Registered Service.607] > org.apache.jackrabbit.oak.segment.standby.client.StandbyClient Group shut down > 19.10.2016 16:22:40.242 *ERROR* [sling-default-81-Registered Service.607] > org.apache.jackrabbit.oak.segment.standby.client.StandbyClientSync Failed > synchronizing state. > java.lang.RuntimeException: Error occurred while obtaining InputStream for > blobId [4dfc748c91d518c9221031ec6115fd7ac04fe27b#10] > at > org.apache.jackrabbit.oak.plugins.blob.BlobStoreBlob.getNewStream(BlobStoreBlob.java:49) > at > org.apache.jackrabbit.oak.segment.SegmentBlob.getNewStream(SegmentBlob.java:252) > at > org.apache.jackrabbit.oak.segment.SegmentBlob.getNewStream(SegmentBlob.java:87) > at > org.apache.jackrabbit.oak.plugins.memory.AbstractBlob$1.getInput(AbstractBlob.java:45) > at > org.apache.jackrabbit.oak.plugins.memory.AbstractBlob$1.getInput(AbstractBlob.java:42) > at com.google.common.io.ByteStreams$3.openStream(ByteStreams.java:907) > at com.google.common.io.ByteSource.contentEquals(ByteSource.java:301) > at com.google.common.io.ByteStreams.equal(ByteStreams.java:661) > at > org.apache.jackrabbit.oak.plugins.memory.AbstractBlob.equal(AbstractBlob.java:68) > at > org.apache.jackrabbit.oak.segment.SegmentBlob.equals(SegmentBlob.java:193) > at com.google.common.base.Objects.equal(Objects.java:55) > at > org.apache.jackrabbit.oak.plugins.memory.AbstractPropertyState.equal(AbstractPropertyState.java:53) > at > org.apache.jackrabbit.oak.segment.SegmentPropertyState.equals(SegmentPropertyState.java:249) > at > org.apache.jackrabbit.oak.segment.SegmentNodeState.compareProperties(SegmentNodeState.java:622) > at > org.apache.jackrabbit.oak.segment.SegmentNodeState.compareAgainstBaseState(SegmentNodeState.java:516) > at > org.apache.jackrabbit.oak.segment.standby.client.StandbyDiff.process(StandbyDiff.java:216) > at > org.apache.jackrabbit.oak.segment.standby.client.StandbyDiff.childNodeChanged(StandbyDiff.java:186) > at > org.apache.jackrabbit.oak.segment.MapRecord.compare(MapRecord.java:415) > at > org.apache.jackrabbit.oak.segment.SegmentNodeState.compareAgainstBaseState(SegmentNodeState.java:609) > at > org.apache.jackrabbit.oak.segment.standby.client.StandbyDiff.process(StandbyDiff.java:216) > at > org.apache.jackrabbit.oak.segment.standby.client.StandbyDiff.childNodeChanged(StandbyDiff.java:186) > at > org.apache.jackrabbit.oak.segment.MapRecord.compare(MapRecord.java:457) > at > org.apache.jackrabbit.oak.segment.SegmentNodeState.compareAgainstBaseState(SegmentNodeState.java:609) > at > org.apache.jackrabbit.oak.segment.standby.client.StandbyDiff.process(StandbyDiff.java:216) > at > org.apache.jackrabbit.oak.segment.standby.client.StandbyDiff.childNodeChanged(StandbyDiff.java:186) > at > org.apache.jackrabbit.oak.segment.MapRecord$2.childNodeChanged(MapRecord.java:401) > at > org.apache.jackrabbit.oak.segment.MapRecord$3.childNodeChanged(MapRecord.java:442) > at > org.apache.jackrabbit.oak.segment.MapRecord.compare(MapRecord.java:485) > at > org.apache.jackrabbit.oak.segment.MapRecord.compare(MapRecord.java:433) > at > org.apache.jackrabbit.oak.segment.MapRecord.compare(MapRecord.java:39
[jira] [Updated] (OAK-4969) ColdStandby does not fetch missing blobs
[ https://issues.apache.org/jira/browse/OAK-4969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothee Maret updated OAK-4969: Component/s: segmentmk > ColdStandby does not fetch missing blobs > > > Key: OAK-4969 > URL: https://issues.apache.org/jira/browse/OAK-4969 > Project: Jackrabbit Oak > Issue Type: Bug > Components: segment-tar, segmentmk >Affects Versions: Segment Tar 0.0.10 >Reporter: Timothee Maret >Assignee: Timothee Maret > Fix For: 1.6, 1.5.13 > > Attachments: OAK-4969.patch > > > 1. In a setup composed of two instances (primary, standby) configured with a > custom blob store (File blob store). > 2. On the primary instance, set/update a BINARY property of an existing > resource with > 2MB binary. > 3. Observe that the standby instance does not fetch the binary and instead, > enters a loop detecting the missing binary upon comparing node states. > For example, the following stack trace would be printed every 5 seconds on > the standby (the polling time is 5sec). > {code} > 19.10.2016 16:22:38.035 *DEBUG* [nioEventLoopGroup-1005-1] > org.apache.jackrabbit.oak.segment.standby.codec.ResponseDecoder Decoding 'get > head' response > 19.10.2016 16:22:38.038 *DEBUG* [sling-default-81-Registered Service.607] > org.apache.jackrabbit.oak.segment.standby.client.StandbyClient Channel closed > 19.10.2016 16:22:40.241 *DEBUG* [sling-default-81-Registered Service.607] > org.apache.jackrabbit.oak.segment.standby.client.StandbyClient Group shut down > 19.10.2016 16:22:40.242 *ERROR* [sling-default-81-Registered Service.607] > org.apache.jackrabbit.oak.segment.standby.client.StandbyClientSync Failed > synchronizing state. > java.lang.RuntimeException: Error occurred while obtaining InputStream for > blobId [4dfc748c91d518c9221031ec6115fd7ac04fe27b#10] > at > org.apache.jackrabbit.oak.plugins.blob.BlobStoreBlob.getNewStream(BlobStoreBlob.java:49) > at > org.apache.jackrabbit.oak.segment.SegmentBlob.getNewStream(SegmentBlob.java:252) > at > org.apache.jackrabbit.oak.segment.SegmentBlob.getNewStream(SegmentBlob.java:87) > at > org.apache.jackrabbit.oak.plugins.memory.AbstractBlob$1.getInput(AbstractBlob.java:45) > at > org.apache.jackrabbit.oak.plugins.memory.AbstractBlob$1.getInput(AbstractBlob.java:42) > at com.google.common.io.ByteStreams$3.openStream(ByteStreams.java:907) > at com.google.common.io.ByteSource.contentEquals(ByteSource.java:301) > at com.google.common.io.ByteStreams.equal(ByteStreams.java:661) > at > org.apache.jackrabbit.oak.plugins.memory.AbstractBlob.equal(AbstractBlob.java:68) > at > org.apache.jackrabbit.oak.segment.SegmentBlob.equals(SegmentBlob.java:193) > at com.google.common.base.Objects.equal(Objects.java:55) > at > org.apache.jackrabbit.oak.plugins.memory.AbstractPropertyState.equal(AbstractPropertyState.java:53) > at > org.apache.jackrabbit.oak.segment.SegmentPropertyState.equals(SegmentPropertyState.java:249) > at > org.apache.jackrabbit.oak.segment.SegmentNodeState.compareProperties(SegmentNodeState.java:622) > at > org.apache.jackrabbit.oak.segment.SegmentNodeState.compareAgainstBaseState(SegmentNodeState.java:516) > at > org.apache.jackrabbit.oak.segment.standby.client.StandbyDiff.process(StandbyDiff.java:216) > at > org.apache.jackrabbit.oak.segment.standby.client.StandbyDiff.childNodeChanged(StandbyDiff.java:186) > at > org.apache.jackrabbit.oak.segment.MapRecord.compare(MapRecord.java:415) > at > org.apache.jackrabbit.oak.segment.SegmentNodeState.compareAgainstBaseState(SegmentNodeState.java:609) > at > org.apache.jackrabbit.oak.segment.standby.client.StandbyDiff.process(StandbyDiff.java:216) > at > org.apache.jackrabbit.oak.segment.standby.client.StandbyDiff.childNodeChanged(StandbyDiff.java:186) > at > org.apache.jackrabbit.oak.segment.MapRecord.compare(MapRecord.java:457) > at > org.apache.jackrabbit.oak.segment.SegmentNodeState.compareAgainstBaseState(SegmentNodeState.java:609) > at > org.apache.jackrabbit.oak.segment.standby.client.StandbyDiff.process(StandbyDiff.java:216) > at > org.apache.jackrabbit.oak.segment.standby.client.StandbyDiff.childNodeChanged(StandbyDiff.java:186) > at > org.apache.jackrabbit.oak.segment.MapRecord$2.childNodeChanged(MapRecord.java:401) > at > org.apache.jackrabbit.oak.segment.MapRecord$3.childNodeChanged(MapRecord.java:442) > at > org.apache.jackrabbit.oak.segment.MapRecord.compare(MapRecord.java:485) > at > org.apache.jackrabbit.oak.segment.MapRecord.compare(MapRecord.java:433) > at > org.apache.jackrabbit.oak.segment.MapRecord.compare(MapRecord.java:391) > at > org.apache.jackrabbit.oak.segment.Segme