[jira] [Commented] (OAK-6511) Switch to official OSGi versioning annotations

2017-08-02 Thread Konrad Windszus (JIRA)

[ 
https://issues.apache.org/jira/browse/OAK-6511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16112227#comment-16112227
 ] 

Konrad Windszus commented on OAK-6511:
--

Baselining only mandates a change of the micro version number. That shouldn't 
cause any harm because consumers should always have a import version range 
ignoring the micro number. But I guess since both annotations have a retention 
policy of {{CLASS}} bnd should not mandate that change. Can you open a bug at 
bnd for that?

> Switch to official OSGi versioning annotations
> --
>
> Key: OAK-6511
> URL: https://issues.apache.org/jira/browse/OAK-6511
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: parent
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
> Fix For: 1.8, 1.7.6
>
>
> When building Oak, several warnings are printed related to the usage of the 
> bnd versioning annotations:
> {noformat}[WARNING] Manifest 
> org.apache.jackrabbit:oak-auth-external:bundle:1.8-SNAPSHOT : 
> aQute.bnd.annotation.Version annotation used in class 
> org.apache.jackrabbit.oak.spi.security.authentication.external.package-info. 
> Bnd versioning annotations are deprecated as of Bnd 3.2 and support will be 
> removed in Bnd 4.0. Please change to use OSGi versioning 
> annotations.{noformat}
> Since it's a mostly mechanical change with a limited number of scenarios I 
> propose to just do it outright.
> {noformat}$ git grep aQute.bnd.annotation | wc -l
> 85{noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (OAK-6512) DocumentNodeStoreConfigTest::testRDBDocumentStore2Datasources is flaky

2017-08-02 Thread Sam Antha (JIRA)
Sam Antha created OAK-6512:
--

 Summary: 
DocumentNodeStoreConfigTest::testRDBDocumentStore2Datasources is flaky
 Key: OAK-6512
 URL: https://issues.apache.org/jira/browse/OAK-6512
 Project: Jackrabbit Oak
  Issue Type: Bug
Reporter: Sam Antha


This test fails for us on commit `abc011c309cb778823b7637b3dc1398406f6e7a9` but 
does not fail on the corresponding run on Travis 
([https://travis-ci.org/apache/jackrabbit-oak/jobs/254788126]):

{quote}
Running org.apache.jackrabbit.oak.run.osgi.DocumentNodeStoreConfigTest
Tests run: 10, Failures: 1, Errors: 0, Skipped: 2, Time elapsed: 11.09 sec <<< 
FAILURE! - in org.apache.jackrabbit.oak.run.osgi.DocumentNodeStoreConfigTest
testRDBDocumentStore2Datasources(org.apache.jackrabbit.oak.run.osgi.DocumentNodeStoreConfigTest)
  Time elapsed: 1.12 sec  <<< FAILURE!
java.lang.AssertionError: Service of type interface 
org.apache.jackrabbit.oak.spi.state.NodeStore was found. Expression: (sr == 
null). Values: sr = [org.apache.jackrabbit.oak.spi.state.NodeStore, 
org.apache.jackrabbit.oak.plugins.document.DocumentNodeStore, 
org.apache.jackrabbit.oak.spi.state.Clusterable]
at 
org.apache.jackrabbit.oak.run.osgi.DocumentNodeStoreConfigTest.testRDBDocumentStore2Datasources(DocumentNodeStoreConfigTest.groovy:110)
{quote}

Our tool comfirms this test is flaky. Note that we set up our build environment 
to be as close to your Travis environment as possible, using Ubuntu 12.04.5 
LTS, Java HotSpot 1.7.0_76 and Maven 3.2.5.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OAK-6509) Build Jackrabbit Oak #598 failed

2017-08-02 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/OAK-6509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1606#comment-1606
 ] 

Hudson commented on OAK-6509:
-

Previously failing build now is OK.
 Passed run: [Jackrabbit Oak 
#600|https://builds.apache.org/job/Jackrabbit%20Oak/600/] [console 
log|https://builds.apache.org/job/Jackrabbit%20Oak/600/console]

> Build Jackrabbit Oak #598 failed
> 
>
> Key: OAK-6509
> URL: https://issues.apache.org/jira/browse/OAK-6509
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: continuous integration
>Reporter: Hudson
>
> Jenkins CI failure: https://builds.apache.org/view/J/job/Jackrabbit%20Oak/
> The build Jackrabbit Oak #598 has failed.
> First failed run: [Jackrabbit Oak 
> #598|https://builds.apache.org/job/Jackrabbit%20Oak/598/] [console 
> log|https://builds.apache.org/job/Jackrabbit%20Oak/598/console]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OAK-6511) Switch to official OSGi versioning annotations

2017-08-02 Thread Robert Munteanu (JIRA)

[ 
https://issues.apache.org/jira/browse/OAK-6511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111083#comment-16111083
 ] 

Robert Munteanu commented on OAK-6511:
--

Hmmm, apparently the baseline plugin complains about switching the annotation 
provider types.

{noformat}
[INFO] --- maven-bundle-plugin:3.3.0:baseline (baseline) @ oak-api ---
[INFO] Baseline Report - Generated by Apache Felix Maven Bundle Plugin on 
2017-08-02T18:09Z based on Bnd - see http://www.aqute.biz/Bnd/Bnd
[INFO] Comparing bundle oak-api version 1.8-SNAPSHOT to version 1.6.2
[INFO] 
[INFO]   PACKAGE_NAME   DELTA  CUR_VER  
  BASE_VER   REC_VERWARNINGS  
[INFO] = == == 
== == == ==
[INFO] * org.apache.jackrabbit.oak.api  changed3.1.0
  3.1.0  3.1.1  Version increase required
[INFO]  ~ interface org.apache.jackrabbit.oak.api.QueryEngine
[INFO]  - annotated aQute.bnd.annotation.ProviderType
[INFO]  + annotated org.osgi.annotation.versioning.ProviderType
{noformat}

> Switch to official OSGi versioning annotations
> --
>
> Key: OAK-6511
> URL: https://issues.apache.org/jira/browse/OAK-6511
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: parent
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
> Fix For: 1.8, 1.7.6
>
>
> When building Oak, several warnings are printed related to the usage of the 
> bnd versioning annotations:
> {noformat}[WARNING] Manifest 
> org.apache.jackrabbit:oak-auth-external:bundle:1.8-SNAPSHOT : 
> aQute.bnd.annotation.Version annotation used in class 
> org.apache.jackrabbit.oak.spi.security.authentication.external.package-info. 
> Bnd versioning annotations are deprecated as of Bnd 3.2 and support will be 
> removed in Bnd 4.0. Please change to use OSGi versioning 
> annotations.{noformat}
> Since it's a mostly mechanical change with a limited number of scenarios I 
> propose to just do it outright.
> {noformat}$ git grep aQute.bnd.annotation | wc -l
> 85{noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OAK-6509) Build Jackrabbit Oak #598 failed

2017-08-02 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/OAK-6509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111025#comment-16111025
 ] 

Hudson commented on OAK-6509:
-

Previously failing build now is OK.
 Passed run: [Jackrabbit Oak 
#599|https://builds.apache.org/job/Jackrabbit%20Oak/599/] [console 
log|https://builds.apache.org/job/Jackrabbit%20Oak/599/console]

> Build Jackrabbit Oak #598 failed
> 
>
> Key: OAK-6509
> URL: https://issues.apache.org/jira/browse/OAK-6509
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: continuous integration
>Reporter: Hudson
>
> Jenkins CI failure: https://builds.apache.org/view/J/job/Jackrabbit%20Oak/
> The build Jackrabbit Oak #598 has failed.
> First failed run: [Jackrabbit Oak 
> #598|https://builds.apache.org/job/Jackrabbit%20Oak/598/] [console 
> log|https://builds.apache.org/job/Jackrabbit%20Oak/598/console]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (OAK-6511) Switch to official OSGi versioning annotations

2017-08-02 Thread Robert Munteanu (JIRA)
Robert Munteanu created OAK-6511:


 Summary: Switch to official OSGi versioning annotations
 Key: OAK-6511
 URL: https://issues.apache.org/jira/browse/OAK-6511
 Project: Jackrabbit Oak
  Issue Type: Task
  Components: parent
Reporter: Robert Munteanu
Assignee: Robert Munteanu
 Fix For: 1.8, 1.7.6


When building Oak, several warnings are printed related to the usage of the bnd 
versioning annotations:

{noformat}[WARNING] Manifest 
org.apache.jackrabbit:oak-auth-external:bundle:1.8-SNAPSHOT : 
aQute.bnd.annotation.Version annotation used in class 
org.apache.jackrabbit.oak.spi.security.authentication.external.package-info. 
Bnd versioning annotations are deprecated as of Bnd 3.2 and support will be 
removed in Bnd 4.0. Please change to use OSGi versioning annotations.{noformat}

Since it's a mostly mechanical change with a limited number of scenarios I 
propose to just do it outright.

{noformat}$ git grep aQute.bnd.annotation | wc -l
85{noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (OAK-6449) Stop using the maven-scr-plugin

2017-08-02 Thread Robert Munteanu (JIRA)

 [ 
https://issues.apache.org/jira/browse/OAK-6449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved OAK-6449.
--
Resolution: Fixed

Fixed in [r1803824|https://svn.apache.org/r1803824]

> Stop using the maven-scr-plugin
> ---
>
> Key: OAK-6449
> URL: https://issues.apache.org/jira/browse/OAK-6449
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: parent
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
> Fix For: 1.8, 1.7.6
>
>
> With the maven-bundle-plugin now being able to generate SCR metadata there is 
> no point in continuing to use the maven-scr-plugin.
> Also, the Eclipse integration for the maven-scr-plugin relies on  m2e-tycho, 
> which is becoming problematic and is not very well maintained.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OAK-6452) IllegalStateException: too much data for a segment during oak-upgrade from segment to segment-tar

2017-08-02 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/OAK-6452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Dürig reassigned OAK-6452:
--

Assignee: Michael Dürig

> IllegalStateException: too much data for a segment during oak-upgrade from 
> segment to segment-tar
> -
>
> Key: OAK-6452
> URL: https://issues.apache.org/jira/browse/OAK-6452
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: segment-tar, upgrade
>Affects Versions: 1.7.3
>Reporter: Valentin Olteanu
>Assignee: Michael Dürig
>Priority: Critical
> Fix For: 1.7.6
>
>
> During the migration of a big repo from the {{old-segment}} format to 
> {{segment-tar}} using {{oak-upgrade-1.7.3}}, I've got the following error:
> {code}
> 14.07.2017 09:05:51.920 [main] *INFO*  
> org.apache.jackrabbit.oak.upgrade.RepositorySidegrade - Copying node 
> #89333: /oak:index/uuid/:index/a9f9a3ed-6183-4e9e-9480-1b4fd196a829
> 14.07.2017 10:00:27.957 [TarMK flush 
> [extracted/crx-quickstart/repository-oak-upgrade/segmentstore]] *ERROR*  
> org.apache.jackrabbit.oak.segment.file.SafeRunnable - Uncaught exception in 
> TarMK flush [extracted/crx-quickstart/repository-oak-upgrade/segmentstore]
> java.lang.IllegalStateException: too much data for a segment
> at 
> org.apache.jackrabbit.oak.segment.SegmentBufferWriter.flush(SegmentBufferWriter.java:322)
>  ~[oak-upgrade-1.7.3.jar:1.7.3]
> at 
> org.apache.jackrabbit.oak.segment.SegmentBufferWriterPool.flush(SegmentBufferWriterPool.java:142)
>  ~[oak-upgrade-1.7.3.jar:1.7.3]
> at 
> org.apache.jackrabbit.oak.segment.DefaultSegmentWriter.flush(DefaultSegmentWriter.java:138)
>  ~[oak-upgrade-1.7.3.jar:1.7.3]
> at 
> org.apache.jackrabbit.oak.segment.file.FileStore$8.call(FileStore.java:345) 
> ~[oak-upgrade-1.7.3.jar:1.7.3]
> at 
> org.apache.jackrabbit.oak.segment.file.FileStore$8.call(FileStore.java:342) 
> ~[oak-upgrade-1.7.3.jar:1.7.3]
> at 
> org.apache.jackrabbit.oak.segment.file.TarRevisions.doFlush(TarRevisions.java:213)
>  ~[oak-upgrade-1.7.3.jar:1.7.3]
> at 
> org.apache.jackrabbit.oak.segment.file.TarRevisions.flush(TarRevisions.java:201)
>  ~[oak-upgrade-1.7.3.jar:1.7.3]
> at 
> org.apache.jackrabbit.oak.segment.file.FileStore.flush(FileStore.java:342) 
> ~[oak-upgrade-1.7.3.jar:1.7.3]
> at 
> org.apache.jackrabbit.oak.segment.file.FileStore$3.run(FileStore.java:242) 
> ~[oak-upgrade-1.7.3.jar:1.7.3]
> at 
> org.apache.jackrabbit.oak.segment.file.SafeRunnable.run(SafeRunnable.java:67) 
> ~[oak-upgrade-1.7.3.jar:1.7.3]
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) 
> [na:1.8.0_131]
> at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308) 
> [na:1.8.0_131]
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
>  [na:1.8.0_131]
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
>  [na:1.8.0_131]
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>  [na:1.8.0_131]
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>  [na:1.8.0_131]
> at java.lang.Thread.run(Thread.java:748) [na:1.8.0_131]
> 14.07.2017 10:00:28.448 [main] *INFO*  
> org.apache.jackrabbit.oak.segment.file.FileStore - TarMK closed: 
> extracted/crx-quickstart/repository-oak-upgrade/segmentstore
> 14.07.2017 10:00:28.658 [main] *INFO*  
> org.apache.jackrabbit.oak.plugins.segment.file.FileStore - TarMK closed: 
> extracted/crx-quickstart/repository/segmentstore
> Exception in thread "main" java.lang.OutOfMemoryError: GC overhead limit 
> exceeded
> at 
> org.apache.jackrabbit.oak.segment.RecordType.values(RecordType.java:24)
> at 
> org.apache.jackrabbit.oak.segment.ImmutableRecordNumbers$1$1.getType(ImmutableRecordNumbers.java:86)
> at 
> org.apache.jackrabbit.oak.segment.Segment.forEachRecord(Segment.java:703)
> at 
> org.apache.jackrabbit.oak.segment.file.AbstractFileStore.readBinaryReferences(AbstractFileStore.java:277)
> at 
> org.apache.jackrabbit.oak.segment.file.FileStore.writeSegment(FileStore.java:511)
> at 
> org.apache.jackrabbit.oak.segment.SegmentBufferWriter.flush(SegmentBufferWriter.java:356)
> at 
> org.apache.jackrabbit.oak.segment.SegmentBufferWriter.prepare(SegmentBufferWriter.java:423)
> at 
> org.apache.jackrabbit.oak.segment.RecordWriters$RecordWriter.write(RecordWriters.java:70)
> at 
> 

[jira] [Assigned] (OAK-6506) Ensure unique property indexes are consistent when mounting NodeStores

2017-08-02 Thread Robert Munteanu (JIRA)

 [ 
https://issues.apache.org/jira/browse/OAK-6506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu reassigned OAK-6506:


Assignee: Robert Munteanu

> Ensure unique property indexes are consistent when mounting NodeStores
> --
>
> Key: OAK-6506
> URL: https://issues.apache.org/jira/browse/OAK-6506
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: composite
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
> Fix For: 1.8, 1.7.6
>
>
> When mounting a NodeStore in a composite setup, we should validate that the 
> unique property indexes do not contain duplicate entries across all the node 
> stores.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (OAK-6510) Fix string representation of the old generation reclaimer

2017-08-02 Thread Francesco Mari (JIRA)

 [ 
https://issues.apache.org/jira/browse/OAK-6510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Francesco Mari resolved OAK-6510.
-
Resolution: Fixed

Fixed at r1803822.

> Fix string representation of the old generation reclaimer
> -
>
> Key: OAK-6510
> URL: https://issues.apache.org/jira/browse/OAK-6510
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: segment-tar
>Reporter: Francesco Mari
>Assignee: Francesco Mari
>Priority: Minor
> Fix For: 1.8, 1.7.6
>
>
> The old generation reclaimer is more complicated than its string 
> representation assumes. As such, the string representation should be more 
> descriptive than it currently is.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (OAK-6510) Fix string representation of the old generation reclaimer

2017-08-02 Thread Francesco Mari (JIRA)
Francesco Mari created OAK-6510:
---

 Summary: Fix string representation of the old generation reclaimer
 Key: OAK-6510
 URL: https://issues.apache.org/jira/browse/OAK-6510
 Project: Jackrabbit Oak
  Issue Type: Improvement
  Components: segment-tar
Reporter: Francesco Mari
Assignee: Francesco Mari
Priority: Minor
 Fix For: 1.8, 1.7.6


The old generation reclaimer is more complicated than its string representation 
assumes. As such, the string representation should be more descriptive than it 
currently is.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (OAK-6450) Stop relying on the service.pid property in SecurityProviderRegistration

2017-08-02 Thread Robert Munteanu (JIRA)

 [ 
https://issues.apache.org/jira/browse/OAK-6450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved OAK-6450.
--
Resolution: Fixed

Thanks for the review [~anchela]. Patch applied in 
[r1803820|https://svn.apache.org/r1803820]

> Stop relying on the service.pid property in SecurityProviderRegistration
> 
>
> Key: OAK-6450
> URL: https://issues.apache.org/jira/browse/OAK-6450
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: security
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
> Fix For: 1.8, 1.7.6
>
> Attachments: 
> 0001-OAK-6450-Stop-relying-on-the-service.pid-property-in.patch, 
> 0002-OAK-6450-Stop-relying-on-the-service.pid-property-in.patch, 
> OAK-6450-v3.patch
>
>
> As discussed in OAK-6111, we should stop relying on the {{service.pid}} OSGi 
> property for tracking required services as it was incorrectly set so far by 
> the {{maven-scr-plugin}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (OAK-6509) Build Jackrabbit Oak #598 failed

2017-08-02 Thread Hudson (JIRA)
Hudson created OAK-6509:
---

 Summary: Build Jackrabbit Oak #598 failed
 Key: OAK-6509
 URL: https://issues.apache.org/jira/browse/OAK-6509
 Project: Jackrabbit Oak
  Issue Type: Bug
  Components: continuous integration
Reporter: Hudson


Jenkins CI failure: https://builds.apache.org/view/J/job/Jackrabbit%20Oak/

The build Jackrabbit Oak #598 has failed.
First failed run: [Jackrabbit Oak 
#598|https://builds.apache.org/job/Jackrabbit%20Oak/598/] [console 
log|https://builds.apache.org/job/Jackrabbit%20Oak/598/console]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (OAK-6507) Cleanup incorrectly removes base state created by full compaction

2017-08-02 Thread Francesco Mari (JIRA)

 [ 
https://issues.apache.org/jira/browse/OAK-6507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Francesco Mari resolved OAK-6507.
-
Resolution: Fixed

Fixed at r1803818.

> Cleanup incorrectly removes base state created by full compaction
> -
>
> Key: OAK-6507
> URL: https://issues.apache.org/jira/browse/OAK-6507
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: segment-tar
>Reporter: Francesco Mari
>Assignee: Francesco Mari
> Fix For: 1.8, 1.7.6
>
>
> The predicate used to mark segments for cleanup marks segments written by 
> full compactions. These segments are needed to reconstruct the full state of 
> the repository, together with the state built by tail compactions.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OAK-6507) Cleanup incorrectly removes base state created by full compaction

2017-08-02 Thread Francesco Mari (JIRA)

 [ 
https://issues.apache.org/jira/browse/OAK-6507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Francesco Mari updated OAK-6507:

Fix Version/s: 1.7.6

> Cleanup incorrectly removes base state created by full compaction
> -
>
> Key: OAK-6507
> URL: https://issues.apache.org/jira/browse/OAK-6507
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: segment-tar
>Reporter: Francesco Mari
>Assignee: Francesco Mari
> Fix For: 1.8, 1.7.6
>
>
> The predicate used to mark segments for cleanup marks segments written by 
> full compactions. These segments are needed to reconstruct the full state of 
> the repository, together with the state built by tail compactions.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (OAK-6505) Ensure mounted node stores don't contain referenceable nodes

2017-08-02 Thread Robert Munteanu (JIRA)

 [ 
https://issues.apache.org/jira/browse/OAK-6505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved OAK-6505.
--
Resolution: Fixed

> Ensure mounted node stores don't contain referenceable nodes
> 
>
> Key: OAK-6505
> URL: https://issues.apache.org/jira/browse/OAK-6505
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: composite
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
> Fix For: 1.8, 1.7.6
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OAK-6505) Ensure mounted node stores don't contain referenceable nodes

2017-08-02 Thread Robert Munteanu (JIRA)

[ 
https://issues.apache.org/jira/browse/OAK-6505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110774#comment-16110774
 ] 

Robert Munteanu commented on OAK-6505:
--

Fixed in [r1803812|https://svn.apache.org/r1803812].

> Ensure mounted node stores don't contain referenceable nodes
> 
>
> Key: OAK-6505
> URL: https://issues.apache.org/jira/browse/OAK-6505
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: composite
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
> Fix For: 1.8, 1.7.6
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OAK-6507) Cleanup incorrectly removes base state created by full compaction

2017-08-02 Thread Francesco Mari (JIRA)

[ 
https://issues.apache.org/jira/browse/OAK-6507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110736#comment-16110736
 ] 

Francesco Mari commented on OAK-6507:
-

Added failing tests at r1803809.

> Cleanup incorrectly removes base state created by full compaction
> -
>
> Key: OAK-6507
> URL: https://issues.apache.org/jira/browse/OAK-6507
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: segment-tar
>Reporter: Francesco Mari
>Assignee: Francesco Mari
> Fix For: 1.8
>
>
> The predicate used to mark segments for cleanup marks segments written by 
> full compactions. These segments are needed to reconstruct the full state of 
> the repository, together with the state built by tail compactions.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OAK-6497) Support old Segment NodeStore setups for oak-run index tooling

2017-08-02 Thread Chetan Mehrotra (JIRA)

 [ 
https://issues.apache.org/jira/browse/OAK-6497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chetan Mehrotra updated OAK-6497:
-
Attachment: OAK-6497-v1.patch

[patch|^OAK-6497-v1.patch] for the same

[~mduerig] [~frm] Can you have a look. 

> Support old Segment NodeStore setups for oak-run index tooling
> --
>
> Key: OAK-6497
> URL: https://issues.apache.org/jira/browse/OAK-6497
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: run
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
> Fix For: 1.8
>
> Attachments: OAK-6497-v1.patch
>
>
> oak-run index command has been introduced in trunk and can be used in read 
> only mode against existing setups. This would work fine for all 
> DocumentNodeStore setups. However would not work SegmentNodeStore setups <= 
> Oak 1.4
> This task is meant to figure out possible approaches for enabling such a 
> support for oak-run builds from trunk



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (OAK-6508) Make it possible to exclude subtrees by configuration in Solr index

2017-08-02 Thread Tommaso Teofili (JIRA)
Tommaso Teofili created OAK-6508:


 Summary: Make it possible to exclude subtrees by configuration in 
Solr index
 Key: OAK-6508
 URL: https://issues.apache.org/jira/browse/OAK-6508
 Project: Jackrabbit Oak
  Issue Type: Improvement
  Components: solr
Reporter: Tommaso Teofili
Assignee: Tommaso Teofili
 Fix For: 1.8


While it's possible to configure per subtree Solr indexes (via persisted 
configuration), sometimes it's also useful to define index on a larger tree but 
still exclude some subtrees (e.g. /jcr:system, /var, etc.) for performance 
reasons (unneeded content in the index, performance).




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (OAK-6507) Cleanup incorrectly removes base state created by full compaction

2017-08-02 Thread Francesco Mari (JIRA)
Francesco Mari created OAK-6507:
---

 Summary: Cleanup incorrectly removes base state created by full 
compaction
 Key: OAK-6507
 URL: https://issues.apache.org/jira/browse/OAK-6507
 Project: Jackrabbit Oak
  Issue Type: Bug
  Components: segment-tar
Reporter: Francesco Mari
Assignee: Francesco Mari
 Fix For: 1.8


The predicate used to mark segments for cleanup marks segments written by full 
compactions. These segments are needed to reconstruct the full state of the 
repository, together with the state built by tail compactions.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OAK-6450) Stop relying on the service.pid property in SecurityProviderRegistration

2017-08-02 Thread angela (JIRA)

[ 
https://issues.apache.org/jira/browse/OAK-6450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110639#comment-16110639
 ] 

angela commented on OAK-6450:
-

[~rombert], had a quick look and i am fine with the new patch.

> Stop relying on the service.pid property in SecurityProviderRegistration
> 
>
> Key: OAK-6450
> URL: https://issues.apache.org/jira/browse/OAK-6450
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: security
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
> Fix For: 1.8, 1.7.6
>
> Attachments: 
> 0001-OAK-6450-Stop-relying-on-the-service.pid-property-in.patch, 
> 0002-OAK-6450-Stop-relying-on-the-service.pid-property-in.patch, 
> OAK-6450-v3.patch
>
>
> As discussed in OAK-6111, we should stop relying on the {{service.pid}} OSGi 
> property for tracking required services as it was incorrectly set so far by 
> the {{maven-scr-plugin}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Closed] (OAK-4693) Impersonating users can't unlock nodes

2017-08-02 Thread angela (JIRA)

 [ 
https://issues.apache.org/jira/browse/OAK-4693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

angela closed OAK-4693.
---

> Impersonating users can't unlock nodes
> --
>
> Key: OAK-4693
> URL: https://issues.apache.org/jira/browse/OAK-4693
> Project: Jackrabbit Oak
>  Issue Type: Wish
>  Components: jcr
>Affects Versions: 1.5.8
>Reporter: Zygmunt Wiercioch
>
> An impersonating user can lock a node, but can't unlock a node.  Relaxed 
> locking was introduced in OAK-1329,
> but {{SessionImpl.impersonate()}} can't pass the attributes to the 
> {{RepositoryImpl.login()}} method. 
> {code}
> return getRepository().login(impCreds, sd.getWorkspaceName());
> {code}
>  An attempt to unlock a node when impersonating will result in a failure 
> since "oak.relaxed-locking" is not set.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (OAK-4693) Impersonating users can't unlock nodes

2017-08-02 Thread angela (JIRA)

 [ 
https://issues.apache.org/jira/browse/OAK-4693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

angela resolved OAK-4693.
-
Resolution: Not A Problem

> Impersonating users can't unlock nodes
> --
>
> Key: OAK-4693
> URL: https://issues.apache.org/jira/browse/OAK-4693
> Project: Jackrabbit Oak
>  Issue Type: Wish
>  Components: jcr
>Affects Versions: 1.5.8
>Reporter: Zygmunt Wiercioch
>
> An impersonating user can lock a node, but can't unlock a node.  Relaxed 
> locking was introduced in OAK-1329,
> but {{SessionImpl.impersonate()}} can't pass the attributes to the 
> {{RepositoryImpl.login()}} method. 
> {code}
> return getRepository().login(impCreds, sd.getWorkspaceName());
> {code}
>  An attempt to unlock a node when impersonating will result in a failure 
> since "oak.relaxed-locking" is not set.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OAK-4693) Impersonating users can't unlock nodes

2017-08-02 Thread angela (JIRA)

[ 
https://issues.apache.org/jira/browse/OAK-4693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110592#comment-16110592
 ] 

angela commented on OAK-4693:
-

[~reschke], you are right. so, let's resolve this as not an issue.

> Impersonating users can't unlock nodes
> --
>
> Key: OAK-4693
> URL: https://issues.apache.org/jira/browse/OAK-4693
> Project: Jackrabbit Oak
>  Issue Type: Wish
>  Components: jcr
>Affects Versions: 1.5.8
>Reporter: Zygmunt Wiercioch
>
> An impersonating user can lock a node, but can't unlock a node.  Relaxed 
> locking was introduced in OAK-1329,
> but {{SessionImpl.impersonate()}} can't pass the attributes to the 
> {{RepositoryImpl.login()}} method. 
> {code}
> return getRepository().login(impCreds, sd.getWorkspaceName());
> {code}
>  An attempt to unlock a node when impersonating will result in a failure 
> since "oak.relaxed-locking" is not set.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OAK-6333) IndexPlanner should use actual entryCount instead of limiting it to 1000

2017-08-02 Thread Chetan Mehrotra (JIRA)

 [ 
https://issues.apache.org/jira/browse/OAK-6333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chetan Mehrotra updated OAK-6333:
-
   Labels:   (was: candidate_oak_1_4 candidate_oak_1_6)
Fix Version/s: 1.4.18
   1.6.4

Merged to 
* 1.6 - 1803762
* 1.4 - 1803776

For older branches this needs to be explicitly enabled by setting system 
property {{oak.lucene.useActualEntryCount}} to {{true}}

> IndexPlanner should use actual entryCount instead of limiting it to 1000
> 
>
> Key: OAK-6333
> URL: https://issues.apache.org/jira/browse/OAK-6333
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: lucene
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
> Fix For: 1.8, 1.7.4, 1.6.4, 1.4.18
>
>
> Currently IndexPlanner uses following logic for estimating the entryCount
> # If the index has fulltext indexing enable then and query has a fulltext 
> constraint clause specified
> ## If {{entryCount}} value is defined then min(entryCount, numOfDocs)
> ## If not then use the {{numDocs}} i.e. actual entry count
> # If the index is pure property index i.e. none of the property definitions 
> have {{analyzed}} set to true
> ## If {{entryCount}} value is defined then min(entryCount, numOfDocs)
> ## Else Take min(1000, numDocs)
> Revisiting the logic for #2 it appears in 1.0.x days (OAK-2200) we capped it 
> to 1000 because cost estimation for property indexes was inaccurate (they 
> used to report low values causing lucene index to loose). 
> With support for Counters the cost estimation for property index has improved 
> and now we should remove this capping and let it use numDocs.
> One area where it causes issue is when we have two indexes where one is 
> superset of other. For e.g. /oak:index/asset and /content/en/ 
> /oak:index/asset where both have some matching properties. Logically if query 
> can be handled by sub index then it should get picked but currently either of 
> them can be picked making query plan undeterministic



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)