[jira] [Commented] (OAK-5237) Change default query limit configuration
[ https://issues.apache.org/jira/browse/OAK-5237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15754668#comment-15754668 ] Chetan Mehrotra commented on OAK-5237: -- Yes they would be effective as QueryEngineSettingsService only comes into effect once any explicit OSGi config is present (config policy required). So by default system uses one defined in QueryEngineSettings > Change default query limit configuration > > > Key: OAK-5237 > URL: https://issues.apache.org/jira/browse/OAK-5237 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: query >Reporter: Thomas Mueller >Assignee: Thomas Mueller > Fix For: 1.5.16, 1.6 > > > By default, queries can read an unlimited number of nodes, and an unlimited > number of entries in memory (for "order by" and "union"). > I would like to change the default settings to: > {noformat} > -Doak.queryLimitInMemory=50 > -Doak.queryLimitReads=10 > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OAK-5237) Change default query limit configuration
[ https://issues.apache.org/jira/browse/OAK-5237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15754662#comment-15754662 ] Thomas Mueller commented on OAK-5237: - Linked OAK-5327 with OAK-5237 (2 and 3 swapped) > Change default query limit configuration > > > Key: OAK-5237 > URL: https://issues.apache.org/jira/browse/OAK-5237 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: query >Reporter: Thomas Mueller >Assignee: Thomas Mueller > Fix For: 1.5.16, 1.6 > > > By default, queries can read an unlimited number of nodes, and an unlimited > number of entries in memory (for "order by" and "union"). > I would like to change the default settings to: > {noformat} > -Doak.queryLimitInMemory=50 > -Doak.queryLimitReads=10 > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OAK-5237) Change default query limit configuration
[ https://issues.apache.org/jira/browse/OAK-5237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15754659#comment-15754659 ] Thomas Mueller commented on OAK-5237: - [~chetanm] sorry I just saw your comment now... I created OAK-5327 to track this. But to me it looks like the changes in this issue were still effective somehow (even thought I'm not sure why...) > Change default query limit configuration > > > Key: OAK-5237 > URL: https://issues.apache.org/jira/browse/OAK-5237 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: query >Reporter: Thomas Mueller >Assignee: Thomas Mueller > Fix For: 1.5.16, 1.6 > > > By default, queries can read an unlimited number of nodes, and an unlimited > number of entries in memory (for "order by" and "union"). > I would like to change the default settings to: > {noformat} > -Doak.queryLimitInMemory=50 > -Doak.queryLimitReads=10 > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OAK-5237) Change default query limit configuration
[ https://issues.apache.org/jira/browse/OAK-5237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15747440#comment-15747440 ] Chetan Mehrotra commented on OAK-5237: -- [~tmueller] Can you change the same in {{QueryEngineSettingsService}}. The OSGi config needs compile time static values for default so cannot refer to values defined in {{QueryEngineSettings}} > Change default query limit configuration > > > Key: OAK-5237 > URL: https://issues.apache.org/jira/browse/OAK-5237 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: query >Reporter: Thomas Mueller >Assignee: Thomas Mueller > Fix For: 1.6, 1.5.16 > > > By default, queries can read an unlimited number of nodes, and an unlimited > number of entries in memory (for "order by" and "union"). > I would like to change the default settings to: > {noformat} > -Doak.queryLimitInMemory=50 > -Doak.queryLimitReads=10 > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OAK-5237) Change default query limit configuration
[ https://issues.apache.org/jira/browse/OAK-5237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15745434#comment-15745434 ] Thomas Mueller commented on OAK-5237: - https://svn.apache.org/r1774036 (trunk) > Change default query limit configuration > > > Key: OAK-5237 > URL: https://issues.apache.org/jira/browse/OAK-5237 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: query >Reporter: Thomas Mueller >Assignee: Thomas Mueller > Fix For: 1.6 > > > By default, queries can read an unlimited number of nodes, and an unlimited > number of entries in memory (for "order by" and "union"). > I would like to change the default settings to: > {noformat} > -Doak.queryLimitInMemory=50 > -Doak.queryLimitReads=10 > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OAK-5237) Change default query limit configuration
[ https://issues.apache.org/jira/browse/OAK-5237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15745121#comment-15745121 ] Thomas Mueller commented on OAK-5237: - [~alexander.klimetschek] yes there is some overlap, both this issue and OAK-4888 try to prevent unexpected behavior (out-of-memory, very slow queries). But OAK-4888 is only ensures an index is used. When an index is used, OAK-4888 doesn't bark. But even with an index, queries can be slow, or run out of memory. For example queries that read many nodes (from an index), or sort by an unindexed column (that is, just use an index for filtering), and so on. This issue complements OAK-4888 by ensuring a query doesn't eat up too many resources. Query limits are a basic monitoring and intervention system. > Change default query limit configuration > > > Key: OAK-5237 > URL: https://issues.apache.org/jira/browse/OAK-5237 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: query >Reporter: Thomas Mueller >Assignee: Thomas Mueller > Fix For: 1.6 > > > By default, queries can read an unlimited number of nodes, and an unlimited > number of entries in memory (for "order by" and "union"). > I would like to change the default settings to: > {noformat} > -Doak.queryLimitInMemory=50 > -Doak.queryLimitReads=10 > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OAK-5237) Change default query limit configuration
[ https://issues.apache.org/jira/browse/OAK-5237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15733325#comment-15733325 ] Alexander Klimetschek commented on OAK-5237: This overlaps with OAK-4888 (failing unindexed queries, ad-hoc queries can add option(traversal ok) to query to allow it). Having both "hurdles" might be a bit confusing. Are there cases where this one would help better? > Change default query limit configuration > > > Key: OAK-5237 > URL: https://issues.apache.org/jira/browse/OAK-5237 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: query >Reporter: Thomas Mueller >Assignee: Thomas Mueller > Fix For: 1.6 > > > By default, queries can read an unlimited number of nodes, and an unlimited > number of entries in memory (for "order by" and "union"). > I would like to change the default settings to: > {noformat} > -Doak.queryLimitInMemory=50 > -Doak.queryLimitReads=10 > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)