[oi-dev] Feature #1744 add ruby 1.9.3 to oi-build

[Colin Ellis]

bitbucket https://bitbucket.org/cellis_oidev/oi-build/changeset/3c3b8bb07540
___
oi-dev mailing list
oi-dev@openindiana.org
http://openindiana.org/mailman/listinfo/oi-dev

Re: [oi-dev] Feature #1744 add ruby 1.9.3 to oi-build

[Josef 'Jeff' Sipek]

On Mon, Nov 07, 2011 at 04:52:51PM +, Colin Ellis wrote:
> bitbucket https://bitbucket.org/cellis_oidev/oi-build/changeset/3c3b8bb07540

I know nothing about ruby, but here are a few things I noticed...

- Oracle copyright/OSOL CDDL header.
- hardcoded "GMAKE=gmake -j16"
- GCC_ROOT hardcoded, is there an issue with gcc46?
- again, you are not Random Developer - check you p5m
- the .so have 'i386' hardcoded in the path (e.g.,
  path=usr/lib/$(MACH64)/ruby/1.9.1/i386-solaris2.11/enc/iso_8859_14.so)
- this is a lot of files; is this really one package? or should it be
  several?

Jeff.


> ___
> oi-dev mailing list
> oi-dev@openindiana.org
> http://openindiana.org/mailman/listinfo/oi-dev


-- 
What is the difference between Mechanical Engineers and Civil Engineers?
Mechanical Engineers build weapons, Civil Engineers build targets.

___
oi-dev mailing list
oi-dev@openindiana.org
http://openindiana.org/mailman/listinfo/oi-dev

Re: [oi-dev] Feature #1744 add ruby 1.9.3 to oi-build

[Colin Ellis]

Fixes are here:

https://bitbucket.org/cellis_oidev/oi-build/changeset/5bb1edf68a1d

Not sure about hardcoded bit in the p5m file.  It got generated like that.

I believe this should be a single package but others might disagree.  I
wouldn't know where to start to split it apart though!



On Sat, Nov 12, 2011 at 3:42 AM, Josef 'Jeff' Sipek
wrote:

> On Mon, Nov 07, 2011 at 04:52:51PM +, Colin Ellis wrote:
> > bitbucket
> https://bitbucket.org/cellis_oidev/oi-build/changeset/3c3b8bb07540
>
> I know nothing about ruby, but here are a few things I noticed...
>
> - Oracle copyright/OSOL CDDL header.
> - hardcoded "GMAKE=gmake -j16"
> - GCC_ROOT hardcoded, is there an issue with gcc46?
> - again, you are not Random Developer - check you p5m
> - the .so have 'i386' hardcoded in the path (e.g.,
>  path=usr/lib/$(MACH64)/ruby/1.9.1/i386-solaris2.11/enc/iso_8859_14.so)
> - this is a lot of files; is this really one package? or should it be
>  several?
>
> Jeff.
>
>
> > ___
> > oi-dev mailing list
> > oi-dev@openindiana.org
> > http://openindiana.org/mailman/listinfo/oi-dev
>
>
> --
> What is the difference between Mechanical Engineers and Civil Engineers?
> Mechanical Engineers build weapons, Civil Engineers build targets.
>
> ___
> oi-dev mailing list
> oi-dev@openindiana.org
> http://openindiana.org/mailman/listinfo/oi-dev
>
___
oi-dev mailing list
oi-dev@openindiana.org
http://openindiana.org/mailman/listinfo/oi-dev

Re: [oi-dev] Feature #1744 add ruby 1.9.3 to oi-build

[Josef 'Jeff' Sipek]

On Sat, Nov 12, 2011 at 06:40:00PM +, Colin Ellis wrote:
> Fixes are here:
> 
> https://bitbucket.org/cellis_oidev/oi-build/changeset/5bb1edf68a1d
> 
> Not sure about hardcoded bit in the p5m file.  It got generated like that.
> 
> I believe this should be a single package but others might disagree.  I
> wouldn't know where to start to split it apart though!

I've never dealt with Ruby so I don't have any intuition about this. So,
LGTM.

Jeff.

> 
> 
> On Sat, Nov 12, 2011 at 3:42 AM, Josef 'Jeff' Sipek
> wrote:
> 
> > On Mon, Nov 07, 2011 at 04:52:51PM +, Colin Ellis wrote:
> > > bitbucket
> > https://bitbucket.org/cellis_oidev/oi-build/changeset/3c3b8bb07540
> >
> > I know nothing about ruby, but here are a few things I noticed...
> >
> > - Oracle copyright/OSOL CDDL header.
> > - hardcoded "GMAKE=gmake -j16"
> > - GCC_ROOT hardcoded, is there an issue with gcc46?
> > - again, you are not Random Developer - check you p5m
> > - the .so have 'i386' hardcoded in the path (e.g.,
> >  path=usr/lib/$(MACH64)/ruby/1.9.1/i386-solaris2.11/enc/iso_8859_14.so)
> > - this is a lot of files; is this really one package? or should it be
> >  several?
> >
> > Jeff.
> >
> >
> > > ___
> > > oi-dev mailing list
> > > oi-dev@openindiana.org
> > > http://openindiana.org/mailman/listinfo/oi-dev
> >
> >
> > --
> > What is the difference between Mechanical Engineers and Civil Engineers?
> > Mechanical Engineers build weapons, Civil Engineers build targets.
> >
> > ___
> > oi-dev mailing list
> > oi-dev@openindiana.org
> > http://openindiana.org/mailman/listinfo/oi-dev
> >

> ___
> oi-dev mailing list
> oi-dev@openindiana.org
> http://openindiana.org/mailman/listinfo/oi-dev


-- 
I already backed up the [server] once, I can do it again.
- a sysadmin threatening to do more frequent backups

___
oi-dev mailing list
oi-dev@openindiana.org
http://openindiana.org/mailman/listinfo/oi-dev

Re: [oi-dev] Feature #1744 add ruby 1.9.3 to oi-build

[Guido Berhoerster]

* Colin Ellis  [2011-11-12 19:40]:
> Fixes are here:
> 
> https://bitbucket.org/cellis_oidev/oi-build/changeset/5bb1edf68a1d

Have you looked through the ruby 1.8 patches and checked which
are still applicable? At least the DTrace changes should probably
be ported over.
Have you checked the built ruby interpeter? Running "make test"
on the source tree after building should be an easy way to catch
any issues.
-- 
Guido Berhoerster

___
oi-dev mailing list
oi-dev@openindiana.org
http://openindiana.org/mailman/listinfo/oi-dev

Re: [oi-dev] Feature #1744 add ruby 1.9.3 to oi-build

[Colin Ellis]

https://bitbucket.org/cellis_oidev/oi-build/changeset/4c13f4869651

On Tue, Nov 15, 2011 at 9:32 AM, Guido Berhoerster wrote:

> * Colin Ellis  [2011-11-12 19:40]:
> > Fixes are here:
> >
> > https://bitbucket.org/cellis_oidev/oi-build/changeset/5bb1edf68a1d
>
> Have you looked through the ruby 1.8 patches and checked which
> are still applicable? At least the DTrace changes should probably
> be ported over.
> Have you checked the built ruby interpeter? Running "make test"
> on the source tree after building should be an easy way to catch
> any issues.
> --
> Guido Berhoerster
>
> ___
> oi-dev mailing list
> oi-dev@openindiana.org
> http://openindiana.org/mailman/listinfo/oi-dev
>
___
oi-dev mailing list
oi-dev@openindiana.org
http://openindiana.org/mailman/listinfo/oi-dev

Re: [oi-dev] Feature #1744 add ruby 1.9.3 to oi-build

[Alasdair Lumsden]

Hi Colin,

Great stuff! Only minor nitpicks:

On the Makefile, you've got multiple configure options per 
CONFIGURE_OPTION, and the indentation of the macros is a bit iffy. But 
if you like I can tidy these up when we commit, saving you the bother.


Did you have any luck finding out about the DTrace patches? Also did you 
give make test a go?


Cheers,

Alasdair

On 11/19/11 09:54 PM, Colin Ellis wrote:

https://bitbucket.org/cellis_oidev/oi-build/changeset/4c13f4869651

On Tue, Nov 15, 2011 at 9:32 AM, Guido Berhoerster mailto:g...@openindiana.org>> wrote:

* Colin Ellis mailto:panamaya...@gmail.com>>
[2011-11-12 19:40]:
 > Fixes are here:
 >
 > https://bitbucket.org/cellis_oidev/oi-build/changeset/5bb1edf68a1d

Have you looked through the ruby 1.8 patches and checked which
are still applicable? At least the DTrace changes should probably
be ported over.
Have you checked the built ruby interpeter? Running "make test"
on the source tree after building should be an easy way to catch
any issues.
--
Guido Berhoerster

___
oi-dev mailing list
oi-dev@openindiana.org 
http://openindiana.org/mailman/listinfo/oi-dev




___
oi-dev mailing list
oi-dev@openindiana.org
http://openindiana.org/mailman/listinfo/oi-dev



___
oi-dev mailing list
oi-dev@openindiana.org
http://openindiana.org/mailman/listinfo/oi-dev

Re: [oi-dev] Feature #1744 add ruby 1.9.3 to oi-build

[Colin Ellis]

I'm tidying up the files as requested.  I've run a make test, which passes.
I haven't found any DTrace patches for the 1.9 series of ruby.  The SFE
build of 1.9.0 doesn't have any applied.
I'd suggest having two ruby packages in the repo: ruby19 with latest code
and ruby18 with dtrace.

Any thoughts?

On Sat, Nov 19, 2011 at 10:35 PM, Alasdair Lumsden wrote:

> Hi Colin,
>
> Great stuff! Only minor nitpicks:
>
> On the Makefile, you've got multiple configure options per
> CONFIGURE_OPTION, and the indentation of the macros is a bit iffy. But if
> you like I can tidy these up when we commit, saving you the bother.
>
> Did you have any luck finding out about the DTrace patches? Also did you
> give make test a go?
>
> Cheers,
>
> Alasdair
>
>
> On 11/19/11 09:54 PM, Colin Ellis wrote:
>
>> https://bitbucket.org/cellis_**oidev/oi-build/changeset/**4c13f4869651
>>
>> On Tue, Nov 15, 2011 at 9:32 AM, Guido Berhoerster > > wrote:
>>
>>* Colin Ellis mailto:panamaya...@gmail.com>**>
>>
>>[2011-11-12 19:40]:
>> > Fixes are here:
>> >
>> > https://bitbucket.org/cellis_**oidev/oi-build/changeset/**
>> 5bb1edf68a1d
>>
>>Have you looked through the ruby 1.8 patches and checked which
>>are still applicable? At least the DTrace changes should probably
>>be ported over.
>>Have you checked the built ruby interpeter? Running "make test"
>>on the source tree after building should be an easy way to catch
>>any issues.
>>--
>>Guido Berhoerster
>>
>>__**_
>>oi-dev mailing list
>>oi-dev@openindiana.org 
>>
>> http://openindiana.org/**mailman/listinfo/oi-dev
>>
>>
>>
>>
>>
>> __**_
>> oi-dev mailing list
>> oi-dev@openindiana.org
>> http://openindiana.org/**mailman/listinfo/oi-dev
>>
>
>
> __**_
> oi-dev mailing list
> oi-dev@openindiana.org
> http://openindiana.org/**mailman/listinfo/oi-dev
>
___
oi-dev mailing list
oi-dev@openindiana.org
http://openindiana.org/mailman/listinfo/oi-dev

Re: [oi-dev] Feature #1744 add ruby 1.9.3 to oi-build

[Josef 'Jeff' Sipek]

On Sun, Nov 20, 2011 at 11:45:28AM +, Colin Ellis wrote:
> I'm tidying up the files as requested.  I've run a make test, which passes.
> I haven't found any DTrace patches for the 1.9 series of ruby.  The SFE
> build of 1.9.0 doesn't have any applied.
> I'd suggest having two ruby packages in the repo: ruby19 with latest code
> and ruby18 with dtrace.

Well, it feels like a regression to have a newer version without DTrace
support.  Or did I miss the memo and DTrace got mainlined?

Agreed on the nitpicks that Alasdair pointed out.

Jeff.

-- 
UNIX is user-friendly ... it's just selective about who its friends are

___
oi-dev mailing list
oi-dev@openindiana.org
http://openindiana.org/mailman/listinfo/oi-dev