[okular] [Bug 408849] okular crashes scrolling through certain pdf

2019-06-18 Thread Tobias Deiminger
https://bugs.kde.org/show_bug.cgi?id=408849

--- Comment #2 from Tobias Deiminger  ---
The problem is that Okular has bogus handling for Poppler::Link::OCGState. If a
document contains such a link, we meet the case arm

case Poppler::Link::OCGState:
Q_UNREACHABLE();

This aborts Okular immediately in debug builds when scrolling to the page, or
leads to construction of an Okular::ObjectRect with m_object = 0x0 in release
builds, causing the crash to happen later (that's what happened in my trial
from comment 2).

We either have to handle the "not implemented yet" situation more gracefully.
Or create a suitable Okular::Action object to expose the feature if Okular is
already capable of handling OCGState links. Didn't check what's the current
state here, does anybody know?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 408886] It do not open the pdf files

2019-06-18 Thread Luigi Toscano
https://bugs.kde.org/show_bug.cgi?id=408886

Luigi Toscano  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 CC||luigi.tosc...@tiscali.it
 Status|REPORTED|NEEDSINFO

--- Comment #1 from Luigi Toscano  ---
Is the "kinit" package installed? This may be
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=886867, fixed in a later
version of Okular.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 328465] Windows: Unable to open PDF file "Could not open C:/mydir/myfile.pdf"

2019-06-18 Thread Vittorio
https://bugs.kde.org/show_bug.cgi?id=328465

Vittorio  changed:

   What|Removed |Added

 CC||vittoriostaz...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 408886] New: It do not open the pdf files

2019-06-18 Thread Vittorio
https://bugs.kde.org/show_bug.cgi?id=408886

Bug ID: 408886
   Summary: It do not open the pdf files
   Product: okular
   Version: 1.4.1
  Platform: Debian stable
OS: Linux
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: PDF backend
  Assignee: okular-devel@kde.org
  Reporter: vittoriostaz...@gmail.com
  Target Milestone: ---

SUMMARY


STEPS TO REPRODUCE
1. I try to open simply a pdf file that I have on the desktop
2. 
3. 

OBSERVED RESULT

Return this message:
"could not open [...].pdf"

EXPECTED RESULT


SOFTWARE/OS VERSIONS

Linux/KDE Plasma: Debian strech 
(available in About System)
KDE Plasma Version: 5.28
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Moving to invent.kde.org

2019-06-18 Thread Oliver Sander
> So maybe we can move forward! (if I can suggest anything, I would just make
> sure that the repository is set to rebase on master when merging a single
> branch to not clutter the history).

Sorry for being late, but +1 for gitlab!



signature.asc
Description: OpenPGP digital signature


Re: Moving to invent.kde.org

2019-06-18 Thread Luigi Toscano
Albert Astals Cid ha scritto:
> El diumenge, 9 de juny de 2019, a les 20:44:34 CEST, Tobias Deiminger va 
> escriure:

>>
>> Branches on private clones could also be a good fit for GSoC.
>> Our last years approach to let phabricator track a GSoC branch
>> in the central repository caused quite some confusion.
> 
> That's my main aim.
> 


So maybe we can move forward! (if I can suggest anything, I would just make
sure that the repository is set to rebase on master when merging a single
branch to not clutter the history).

Ciao
-- 
Luigi


D15580: New annotation toolbar

2019-06-18 Thread Simone Gaiarin
simgunz added a comment.


  In D15580#481323 , @davidhurka 
wrote:
  
  > Don’t have UI feedback that asks for action already in this patch. :)
  >
  > In D15580#481270 , @simgunz 
wrote:
  >
  > > F6902170: Screenshot_20190617_165440.png 

  >
  >
  >
  >
  > - Maybe the 4 left buttons should indicate that they require further action 
(drawing). Currently they look like buttons in a word processor, where you have 
to select the text first. *1) Using the existing dynamic annotation icons might 
look better, as soon as someone made them more low-resolution friently.
  
  
  I am more in favor of using standard breeze icons for the annotation tools. I 
opened a bug to ask for the icons 
(https://bugs.kde.org/show_bug.cgi?id=408283), so we can ask for a specific 
design that make them understandable.
  
  > 
  > 
  > - The first two separators look a bit like only the first four buttons are 
annotation tools, and the next 3+2 buttons are just options. I. e. there is not 
a mutually exclusion between the 4+3+2 buttons, but only between the 4, 3, and 
2 individually. Maybe it’s better to group them not with separators, but with 
ToolActions/ToggleActionMenus. Could be tested later by customizing the toolbar 
via Configure Toolbars.
  
  I agree in removing the separators.
  
  > *1) Maybe an interesting idea: Select some text in Text Selection mode, 
then just click the annotation button.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D15580

To: simgunz, #okular
Cc: aacid, anthonyfieroni, davidhurka, knambiar, ngraham, tobiasdeiminger, 
okular-devel, fbampaloukas, joaonetto, tfella, darcyshen