[openib-general] sanity check on datapath

2006-08-14 Thread Michael S. Tsirkin
Roland, do we really need code like

if (wr-opcode = sizeof mthca_opcode / sizeof mthca_opcode[0])
{
ret = -1;
*bad_wr = wr;
goto out;
}

in mthca on data path? Should this be put within ifdef DEBUG or something?

-- 
MST

___
openib-general mailing list
openib-general@openib.org
http://openib.org/mailman/listinfo/openib-general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general



Re: [openib-general] sanity check on datapath

2006-08-14 Thread Roland Dreier
Michael if (wr-opcode = sizeof mthca_opcode / sizeof mthca_opcode[0])
Michael {
Michaelret = -1;
Michael*bad_wr = wr;
Michaelgoto out;
Michael }

Michael in mthca on data path? Should this be put within ifdef
Michael DEBUG or something?

Probably not needed -- I guess we can trust what the consumer gives
us.

 - R.

___
openib-general mailing list
openib-general@openib.org
http://openib.org/mailman/listinfo/openib-general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general