Re: [openib-general] [libibverbs/examples] [PATCH] Added resource cleaning before end of pingpong tests + ack to CQ events

2007-01-23 Thread Roland Dreier
Thanks, applied after s/num_of_events/num_cq_events/

  --- gen2_devel_user.orig/src/userspace/libibverbs/examples/rc_pingpong.c 
  2007-01-17 10:58:02.0 +0200
  +++ gen2_devel_user/src/userspace/libibverbs/examples/rc_pingpong.c  
  2007-01-17 11:09:59.0 +0200

BTW, can you make sure your patches apply to the libibverbs tree with
patch -p1 (or better yet, with git apply --whitespace=error-all)?
I had to edit the patch headers to apply this to my git tree.

 - R.

___
openib-general mailing list
openib-general@openib.org
http://openib.org/mailman/listinfo/openib-general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general



Re: [openib-general] [libibverbs/examples] [PATCH] Added resource cleaning before end of pingpong tests + ack to CQ events

2007-01-23 Thread dotanb
 Thanks, applied after s/num_of_events/num_cq_events/

   ---
 gen2_devel_user.orig/src/userspace/libibverbs/examples/rc_pingpong.c  
 2007-01-17
 10:58:02.0 +0200
   +++
 gen2_devel_user/src/userspace/libibverbs/examples/rc_pingpong.c   
 2007-01-17
 11:09:59.0 +0200

 BTW, can you make sure your patches apply to the libibverbs tree with
 patch -p1 (or better yet, with git apply --whitespace=error-all)?
 I had to edit the patch headers to apply this to my git tree.

  - R.


I tried to apply the patch locally with -p1, and everything was fine 
but anyway, next time i will check it using the git apply.


thanks
Dotan


___
openib-general mailing list
openib-general@openib.org
http://openib.org/mailman/listinfo/openib-general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general



Re: [openib-general] [libibverbs/examples] [PATCH] Added resource cleaning before end of pingpong tests + ack to CQ events

2007-01-23 Thread Roland Dreier
  I tried to apply the patch locally with -p1, and everything was fine 

I don't see how that could work... the patch headers have pathnames
like gen2_devel_user.orig/src/userspace/libibverbs/examples/rc_pingpong.c
in them, so stripping just one directory would leave something like
src/userspace/libibverbs/examples/rc_pingpong.c, which couldn't
possibly apply in my libibverbs directory.

___
openib-general mailing list
openib-general@openib.org
http://openib.org/mailman/listinfo/openib-general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general



Re: [openib-general] [libibverbs/examples] [PATCH] Added resource cleaning before end of pingpong tests + ack to CQ events

2007-01-23 Thread Michael S. Tsirkin
 Subject: Re: [libibverbs/examples] [PATCH] Added resource cleaning before end 
 of pingpong tests + ack to CQ events
 
 Thanks, applied after s/num_of_events/num_cq_events/
 
   --- gen2_devel_user.orig/src/userspace/libibverbs/examples/rc_pingpong.c   
 2007-01-17 10:58:02.0 +0200
   +++ gen2_devel_user/src/userspace/libibverbs/examples/rc_pingpong.c
 2007-01-17 11:09:59.0 +0200

This one looks like -p4.

 
 BTW, can you make sure your patches apply to the libibverbs tree with
 patch -p1 (or better yet, with git apply --whitespace=error-all)?
 I had to edit the patch headers to apply this to my git tree.

That's a bit extreme. git-apply gets the -pNUM flag, this should be sufficient.

-- 
MST

___
openib-general mailing list
openib-general@openib.org
http://openib.org/mailman/listinfo/openib-general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general



Re: [openib-general] [libibverbs/examples] [PATCH] Added resource cleaning before end of pingpong tests + ack to CQ events

2007-01-23 Thread Michael S. Tsirkin
 Quoting Roland Dreier [EMAIL PROTECTED]:
 Subject: Re: [libibverbs/examples] [PATCH] Added resource cleaning before end 
 of pingpong tests + ack to CQ events
 
   I tried to apply the patch locally with -p1, and everything was fine 
 
 I don't see how that could work... the patch headers have pathnames
 like gen2_devel_user.orig/src/userspace/libibverbs/examples/rc_pingpong.c
 in them, so stripping just one directory would leave something like
 src/userspace/libibverbs/examples/rc_pingpong.c, which couldn't
 possibly apply in my libibverbs directory.

I think Dotan's working in an OFED source tree, that's the directory
structure it has.

So if you stay in directory where OFED unpacked the sources, you see
src/userspace/libibverbs/examples/rc_pingpong.c, and this is
the format OFED uses for patches (otherwise we'd need some other way
to figure out which package to apply the patch to).

-- 
MST

___
openib-general mailing list
openib-general@openib.org
http://openib.org/mailman/listinfo/openib-general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general



Re: [openib-general] [libibverbs/examples] [PATCH] Added resource cleaning before end of pingpong tests + ack to CQ events

2007-01-22 Thread dotanb
 Added resource cleaning before end of pingpong tests + ack to CQ events.


Roland, did you had the chance to check this patch?

thanks
Dotan


___
openib-general mailing list
openib-general@openib.org
http://openib.org/mailman/listinfo/openib-general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general