Re: [openstack-dev] [all] Call for check: is your project ready for pylint 1.7.1?

2017-06-10 Thread Davanum Srinivas
Amrith,

"fell on deaf ears" Seriously?

It's a double revert and did not have the link to the email thread.
hence my +2. It still needed another +2 and +W before it would have
been on its way to merging. So the -1's would have stopped that from
another requirements person from doing that.

-- Dims

On Sat, Jun 10, 2017 at 4:24 PM, Amrith Kumar  wrote:
> I guess this mail thread and the questions asked here fell on deaf ears 
> because I see https://review.openstack.org/#/c/472891/1 marching its way to 
> merging.
>
> --
> Amrith Kumar
> amrith.ku...@gmail.com
>
>
>> -Original Message-
>> From: Doug Hellmann [mailto:d...@doughellmann.com]
>> Sent: Friday, June 9, 2017 12:34 PM
>> To: openstack-dev 
>> Subject: Re: [openstack-dev] [all] Call for check: is your project ready for
>> pylint 1.7.1?
>>
>> Excerpts from Akihiro Motoki's message of 2017-06-09 03:53:34 +0900:
>> > Hi all,
>> >
>> > Is your project ready for pylint 1.7.1?
>> > If you use pylint in your pep8 job, it is worth checked.
>> >
>> > Our current version of pylint is 1.4.5 but it is not safe in python 3.5.
>> > The global-requirements update was merged once [1], However, some
>> > projects (at least neutron) are not ready for pylint
>> > 1.7.1 and it was reverted [2].
>> > it is reasonable to give individual projects time to cope with pylint
>> 1.7.1.
>> >
>> > I believe bumping pylint version to 1.7.1 (or later) is the right
>> > direction in long term.
>> > I would suggest to make your project ready for pylint 1.7.1 soon (two
>> > weeks or some?) You can disable new rules in pylint 1.7.1 temporarily
>> > and clean up your code later as neutron does [3]. As far as I checked,
>> > most rules are reasonable and worth enabled.
>> >
>> > Thanks,
>> > Akihiro Motoki
>> >
>> > [1] https://review.openstack.org/#/c/470800/
>> > [2] https://review.openstack.org/#/c/471756/
>> > [3] https://review.openstack.org/#/c/471763/
>> >
>>
>> I thought we had linters in a list that didn't require the versions to be
>> synced across projects, to allow projects to update at their own pace. Did we
>> undo that work?
>>
>> Doug
>>
>> __
>> OpenStack Development Mailing List (not for usage questions)
>> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>



-- 
Davanum Srinivas :: https://twitter.com/dims

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [all] Call for check: is your project ready for pylint 1.7.1?

2017-06-10 Thread Amrith Kumar
I guess this mail thread and the questions asked here fell on deaf ears because 
I see https://review.openstack.org/#/c/472891/1 marching its way to merging.

--
Amrith Kumar
amrith.ku...@gmail.com


> -Original Message-
> From: Doug Hellmann [mailto:d...@doughellmann.com]
> Sent: Friday, June 9, 2017 12:34 PM
> To: openstack-dev 
> Subject: Re: [openstack-dev] [all] Call for check: is your project ready for
> pylint 1.7.1?
> 
> Excerpts from Akihiro Motoki's message of 2017-06-09 03:53:34 +0900:
> > Hi all,
> >
> > Is your project ready for pylint 1.7.1?
> > If you use pylint in your pep8 job, it is worth checked.
> >
> > Our current version of pylint is 1.4.5 but it is not safe in python 3.5.
> > The global-requirements update was merged once [1], However, some
> > projects (at least neutron) are not ready for pylint
> > 1.7.1 and it was reverted [2].
> > it is reasonable to give individual projects time to cope with pylint
> 1.7.1.
> >
> > I believe bumping pylint version to 1.7.1 (or later) is the right
> > direction in long term.
> > I would suggest to make your project ready for pylint 1.7.1 soon (two
> > weeks or some?) You can disable new rules in pylint 1.7.1 temporarily
> > and clean up your code later as neutron does [3]. As far as I checked,
> > most rules are reasonable and worth enabled.
> >
> > Thanks,
> > Akihiro Motoki
> >
> > [1] https://review.openstack.org/#/c/470800/
> > [2] https://review.openstack.org/#/c/471756/
> > [3] https://review.openstack.org/#/c/471763/
> >
> 
> I thought we had linters in a list that didn't require the versions to be
> synced across projects, to allow projects to update at their own pace. Did we
> undo that work?
> 
> Doug
> 
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev