[openstack-dev] [swift] Allow hostname for nodes in Ring

2014-10-09 Thread Osanai, Hisashi

Hi Swift folks,

Today the following patch was abandoned and I contacted with the author, 
so I would like to take it over if nobody else is chafing to take it.
Is it OK?

https://review.openstack.org/#/c/80421/

If it is OK, I will proceed it with following procedure.
(1) Open new bug report (there is no bug report for this)
I'm not sure that I should write a BP instead of a bug report.
(2) Make a patch based on the current patch on gerrit

Cheers,
Hisashi Osanai


___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [swift] Allow hostname for nodes in Ring

2014-10-14 Thread Osanai, Hisashi

Swift folks,

Could you please advise me about the following email?

Thanks in advance,
Hisashi Osanai

> -Original Message-
> From: Osanai, Hisashi [mailto:osanai.hisa...@jp.fujitsu.com]
> Sent: Friday, October 10, 2014 1:57 PM
> To: openstack-dev@lists.openstack.org
> Subject: [openstack-dev] [swift] Allow hostname for nodes in Ring
> 
> 
> Hi Swift folks,
> 
> Today the following patch was abandoned and I contacted with the author,
> so I would like to take it over if nobody else is chafing to take it.
> Is it OK?
> 
> https://review.openstack.org/#/c/80421/
> 
> If it is OK, I will proceed it with following procedure.
> (1) Open new bug report (there is no bug report for this)
> I'm not sure that I should write a BP instead of a bug report.
> (2) Make a patch based on the current patch on gerrit
> 
> Cheers,
> Hisashi Osanai
> 
> 
> ___
> OpenStack-dev mailing list
> OpenStack-dev@lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [swift] Allow hostname for nodes in Ring

2014-10-14 Thread Matthew Oliver
Hey Hisashi ,

It does indeed look abandoned. So if you want to take it over sure that's
OK :)

1) It isn't a bug, so no bug report is needed. You could raise a BP if you
wanted, jump on the freenode #openstack-swift channel if you want to
discuss.

2) You can do one of two things:
  - Continue where this one left off, in which case pull down the change
from gerrit and start working on it. But if you do this make sure you add a
'Co-Authored-By: name ' to attribute the work that was
already done by the original author*. And start working on it in a new
change.

  - Start from scratch, but then you will be starting again.

Regards,
Matt

*
https://wiki.openstack.org/wiki/GitCommitMessages#Including_external_references
___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [swift] Allow hostname for nodes in Ring

2014-10-14 Thread Osanai, Hisashi

Hi Matthew,

Thanks for the quick response.

On Wednesday, October 15, 2014 2:31 PM, Matthew Oliver wrote:
>   - Continue where this one left off, in which case pull down the change from 
> gerrit
> and start working on it. But if you do this make sure you add a 
> 'Co-Authored-By: name
> ' to attribute the work that was already done by the 
> original author*.
> And start working on it in a new change.

I discussed this with the original author and we would choose above.

Thanks again!
Hisashi Osanai

___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [swift] Allow hostname for nodes in Ring

2014-10-15 Thread Pete Zaitcev
On Fri, 10 Oct 2014 04:56:55 +
"Osanai, Hisashi"  wrote:

> Today the following patch was abandoned and I contacted with the author, 
> so I would like to take it over if nobody else is chafing to take it.
> Is it OK?
> 
> https://review.openstack.org/#/c/80421/
> 
> If it is OK, I will proceed it with following procedure.
> (1) Open new bug report (there is no bug report for this)
> I'm not sure that I should write a BP instead of a bug report.
> (2) Make a patch based on the current patch on gerrit

If the author agrees or ambivalent about it, you are free to re-use
the old Change ID.

And you're always free to post your patch anew.

I don't know if the bug report is all that necessary or useful.
The scope of the problem is well defined without, IMHO.

-- Pete

___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [swift] Allow hostname for nodes in Ring

2014-10-15 Thread Osanai, Hisashi

Thanks for your advice.

On Thursday, October 16, 2014 2:25 AM, Pete Zaitcev wrote:
> I don't know if the bug report is all that necessary or useful.
> The scope of the problem is well defined without, IMHO.

I really want to have clear rules for this but your thought looks 
pretty nice for me (good balance) so I will behave according to it.

Thanks again!
Hisashi Osanai


___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev