Re: [OpenWrt-Devel] [PATCH v2 1/3] ramips: Add DTS files for HiWiFi HC5x61 models

[Yousong Zhou]

On 10 October 2015 at 22:04, 康  wrote:
>
> At 2015-09-29 10:10:41, "Yousong Zhou"  wrote:
>>Hi,
>>
>>Previously this year, there were 2 attempts to add support for HC5661
>>and HC5761 to OpenWrt trunk [1,2].  I only had a HC5661 and it was
>>quite a while ago but the issues then should still remain.
>>
>>The first is about how MAC address is to be read.  The
>>"mtd-mac-address" DTS directives apparently won't work.  And if I
>>remember correctly simply reading and setting it for lan and wan also
>>has flaws that the WiFi interface still get the default hardcoded MAC
>>address by the driver.  The best way I can think of to workaround this
>>is to add a directive similar to what "mtd-mac-address" does for
>>binary-encoded MACs.
>>"target/linux/generic/patches-4.1/681-NET-add-of_get_mac_address_mtd.patch"
>>can work as a reference.
>
> Today I implemented the "mtd-mac-address-ascii" function, ethernet address
> works fine, but WiFi mac address remains the hardcoded one. It seems the
> driver read mac  from factory partition, and unfortunately all HiWiFi
> devices has the same mac in factory data...
>

I see and should have thought of that earlier...

I had the following patch (whitespace clean at [1]) in my local tree
at the time when I found mac addresses of those wifi interfaces were
not right.  Surely it's hacky and a cleaner approach has to be crafted
out.  The patch in link [2] tried to work around this by forging
together an eeprom file with correct mac address, still too hacky I
guess.

Another patch to get phy macaddress like what
package/kernel/mac80211/patches/605-rt2x00-load-eeprom-on-SoC-from-a-mtd-device-defines-.patch
does for ralink,mtd-eeprom?

 [1] http://sprunge.us/eKMI
 [2] ramips:Add support for HiWiFi HC5761,
https://lists.openwrt.org/pipermail/openwrt-devel/2015-April/032643.html

diff --git a/package/kernel/mac80211/files/lib/netifd/wireless/mac80211.sh
b/package/kernel/mac80211/files/lib/netifd/wireless/mac80211.sh
index e6241de..0d41e1f 100644
--- a/package/kernel/mac80211/files/lib/netifd/wireless/mac80211.sh
+++ b/package/kernel/mac80211/files/lib/netifd/wireless/mac80211.sh
@@ -1,6 +1,9 @@
 #!/bin/sh
 . /lib/netifd/netifd-wireless.sh
 . /lib/netifd/hostapd.sh
+# Needed by mtd_get_mac_ascii
+. /lib/functions.sh
+. /lib/functions/system.sh

 init_wireless_driver "$@"

@@ -330,9 +333,18 @@ mac80211_generate_mac() {
 local phy="$1"
 local id="${macidx:-0}"

-local ref="$(cat /sys/class/ieee80211/${phy}/macaddress)"
 local mask="$(cat /sys/class/ieee80211/${phy}/address_mask)"

+local ref
+case $(cat /tmp/sysinfo/board_name) in
+hiwifi-hc5661)
+ref=$(mtd_get_mac_ascii "bdinfo" "Vfac_mac ")
+;;
+*)
+ref="$(cat /sys/class/ieee80211/${phy}/macaddress)"
+;;
+esac
+
 [ "$mask" = "00:00:00:00:00:00" ] && mask="ff:ff:ff:ff:ff:ff";
 local oIFS="$IFS"; IFS=":"; set -- $mask; IFS="$oIFS"
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH v2 1/3] ramips: Add DTS files for HiWiFi HC5x61 models

[康]

At 2015-09-29 10:10:41, "Yousong Zhou"  wrote:
>Hi,
>
>Previously this year, there were 2 attempts to add support for HC5661
>and HC5761 to OpenWrt trunk [1,2].  I only had a HC5661 and it was
>quite a while ago but the issues then should still remain.
>
>The first is about how MAC address is to be read.  The
>"mtd-mac-address" DTS directives apparently won't work.  And if I
>remember correctly simply reading and setting it for lan and wan also
>has flaws that the WiFi interface still get the default hardcoded MAC
>address by the driver.  The best way I can think of to workaround this
>is to add a directive similar to what "mtd-mac-address" does for
>binary-encoded MACs.
>"target/linux/generic/patches-4.1/681-NET-add-of_get_mac_address_mtd.patch"
>can work as a reference.



Today I implemented the "mtd-mac-address-ascii" function, ethernet address 
works fine, but WiFi mac address remains the hardcoded one. It seems the driver 
read mac  from factory partition, and unfortunately all HiWiFi devices has the 
same mac in factory data...




>
>The second is about how the generated the firmwares is to be flashed
>to the those devices.  Are there plans to create wiki pages to clarify
>the details?  Again if I remember correctly, the U-Boot of HC5661 at
>least utilised pubkey firmware verification (though ...).  How regular
>users are supposed to workaround this?
>
> [1] HiWiFi HC5661 Support for Openwrt,
>https://lists.openwrt.org/pipermail/openwrt-devel/2015-April/032640.html
> [2] ramips:Add support for HiWiFi HC5761,
>https://lists.openwrt.org/pipermail/openwrt-devel/2015-April/032643.html
>
>Regard,
>
>yousong
>
>On 28 September 2015 at 22:42, Comman Kang  wrote:
>> HiWiFi HC5661/5761/5861 models are manufactured by http://www.hiwifi.com. 
>> These models have similar hardware specs(MT7620A + 128M DDR2 + 16M flash). 
>> This patch adds support for them.
>>
>> The original author is Justin Liu (rss...@gmail.com). I ported the patch to 
>> trunk and submitted it here with his approval.
>>
>> v2 fix
>>   1: Renamed files to remove manufacturer’s name.
>>   2: styling work
>>
>> Signed-off-by: Xiaoning Kang 
>>
>>
>> diff --git a/target/linux/ramips/dts/HC5661.dts 
>> b/target/linux/ramips/dts/HC5661.dts
>> new file mode 100644
>> index 000..b5b9d1a
>> --- /dev/null
>> +++ b/target/linux/ramips/dts/HC5661.dts
>> @@ -0,0 +1,172 @@
>> +/dts-v1/;
>> +
>> +/include/ "mt7620a.dtsi"
>> +
>> +/ {
>> +   compatible = "HC5661", "ralink,mt7620a-soc";
>> +   model = "HiWiFi HC5661";
>> +
>> +   chosen {
>> +   bootargs = "console=ttyS0,115200";
>> +   };
>> +
>> +   palmbus@1000 {
>> +   sysc@0 {
>> +   ralink,gpiomux = "i2c", "jtag";
>> +   ralink,uartmux = "gpio";
>> +   ralink,wdtmux = <1>;
>> +   };
>> +
>> +   gpio0: gpio@600 {
>> +   status = "okay";
>> +   };
>> +
>> +   gpio2: gpio@660 {
>> +   status = "okay";
>> +   };
>> +
>> +   gpio3: gpio@688 {
>> +   status = "okay";
>> +   };
>> +
>> +   spi@b00 {
>> +   status = "okay";
>> +
>> +   m25p80@0 {
>> +   #address-cells = <1>;
>> +   #size-cells = <1>;
>> +   compatible = "w25q128";
>> +   reg = <0 0>;
>> +   linux,modalias = "m25p80", "w25q128";
>> +   spi-max-frequency = <1000>;
>> +
>> +   partition@0 {
>> +   label = "u-boot";
>> +   reg = <0x0 0x3>;
>> +   };
>> +
>> +   partition@3 {
>> +   label = "u-boot-env";
>> +   reg = <0x3 0x1>;
>> +   read-only;
>> +   };
>> +
>> +   factory: partition@4 {
>> +   label = "factory";
>> +   reg = <0x4 0x1>;
>> +   };
>> +
>> +   partition@5 {
>> +   label = "firmware";
>> +   reg = <0x5 0xf8>;
>> +   };
>> +
>> +   partition@fd {
>> +   label = "hwf_config";
>> +   reg = <0xfd 0x1>;
>> +   };
>> +
>> +   bdinfo: partition@fe {

Re: [OpenWrt-Devel] [PATCH v2 1/3] ramips: Add DTS files for HiWiFi HC5x61 models

[康]

在 2015-10-02 23:49:52，"Piotr Dymacz"  写道：
>Hello,
>
>2015-10-02 15:53 GMT+02:00 康 :
>>
>> Hi,  Merging 3 dts into one dtsi has been done in patch V3 ,
>
>Sorry, I missed that.
>
>> Sorry I don't quite understand your question ,  do you mean how to flash on
>> those devices?
>
>Yes and I got the answer from your mail to Yousong:
>
>> For #2,  I can write the wiki page, though it is would be complicated.
>> HiWiFi provides an "official" way to unlock the U-Boot now, at the cost of
>> voiding warranty.  However, you have to follow a procedure which requires a
>> Chinese cellphone number, and a WeChat(a whatsapp clone app) account.
>> Understanding of Chinese is also a requirement.  Anyway, since HiWiFi
>> routers are sold in Chinese market only, I believe it won't be a big problem
>> for non-Chinese users.
>
>There are dozen ways to have devices for CN market in other parts of
>the the world.
>If there is no easier/ready way to switch from official firmware to
>OpenWrt on those devices, I'm not convinced about keeping official
>support for them in OpenWrt repository, but it's just mine opinion.



I think there are dozens of HiWiFi routers(more than 200K pcs at least)  which 
don't have the bootloader locked out in the market, They were manufactured 
before the locked bootloader was born. As  long as they don't get updated, they 
remain unlocked and can be flashed via tftp easily.   Also, for CN users like 
me, they can easily get the device unlocked by following the procedure, so they 
need official openwrt support, too.


Thanks


>
>Cheers,
>Piotr
>
>[snip]
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH v2 1/3] ramips: Add DTS files for HiWiFi HC5x61 models

[康]

Hi,  Merging 3 dts into one dtsi has been done in patch V3 ,



Sorry I don't quite understand your question ,  do you mean how to flash on 
those devices? 


At 2015-10-02 05:31:08, "Piotr Dymacz"  wrote:
>Hello,
>
>I don't have more comments, it looks good now. Maybe just think about
>my suggestion with common dtsi for all 3 models.
>And just one question - how does it look with flashing process on those 
>devices?
>
>Cheers,
>Piotr
>
>
>2015-09-29 18:13 GMT+02:00 Kang Xiaoning :
>>
>>
>> On Tue, Sep 29, 2015 at 4:31 AM, Piotr Dymacz  wrote:
>>>
>>> Hello,
>>>
>>> Just some small, cosmetic things... see inline, below.
>>>
>>> BTW.
>>> I see that these models are very similar (most of the dts files are
>>> just copy).
>>> Maybe it would be better to make for them one, common dtsi file and
>>> separated dts files per model (take Lenovo Y1/Y1S as example).
>>>
>>> Cheers,
>>> Piotr
>>>
>>> 2015-09-28 16:42 GMT+02:00 Comman Kang :
>>> > HiWiFi HC5661/5761/5861 models are manufactured by
>>> > http://www.hiwifi.com. These models have similar hardware specs(MT7620A +
>>> > 128M DDR2 + 16M flash). This patch adds support for them.
>>> >
>>> > The original author is Justin Liu (rss...@gmail.com). I ported the patch
>>> > to trunk and submitted it here with his approval.
>>> >
>>> > v2 fix
>>> >   1: Renamed files to remove manufacturer’s name.
>>> >   2: styling work
>>> >
>>> > Signed-off-by: Xiaoning Kang 
>>> >
>>> >
>>> > diff --git a/target/linux/ramips/dts/HC5661.dts
>>> > b/target/linux/ramips/dts/HC5661.dts
>>> > new file mode 100644
>>> > index 000..b5b9d1a
>>> > --- /dev/null
>>> > +++ b/target/linux/ramips/dts/HC5661.dts
>>> > @@ -0,0 +1,172 @@
>>> > +/dts-v1/;
>>> > +
>>> > +/include/ "mt7620a.dtsi"
>>> > +
>>> > +/ {
>>> > +   compatible = "HC5661", "ralink,mt7620a-soc";
>>> > +   model = "HiWiFi HC5661";
>>> > +
>>> > +   chosen {
>>> > +   bootargs = "console=ttyS0,115200";
>>> > +   };
>>> > +
>>> > +   palmbus@1000 {
>>> > +   sysc@0 {
>>> > +   ralink,gpiomux = "i2c", "jtag";
>>> > +   ralink,uartmux = "gpio";
>>> > +   ralink,wdtmux = <1>;
>>> > +   };
>>> > +
>>> > +   gpio0: gpio@600 {
>>> > +   status = "okay";
>>> > +   };
>>> > +
>>> > +   gpio2: gpio@660 {
>>> > +   status = "okay";
>>> > +   };
>>> > +
>>> > +   gpio3: gpio@688 {
>>> > +   status = "okay";
>>> > +   };
>>> > +
>>> > +   spi@b00 {
>>> > +   status = "okay";
>>> > +
>>> > +   m25p80@0 {
>>> > +   #address-cells = <1>;
>>> > +   #size-cells = <1>;
>>> > +   compatible = "w25q128";
>>> > +   reg = <0 0>;
>>> > +   linux,modalias = "m25p80", "w25q128";
>>> > +   spi-max-frequency = <1000>;
>>> > +
>>> > +   partition@0 {
>>> > +   label = "u-boot";
>>> > +   reg = <0x0 0x3>;
>>> > +   };
>>> > +
>>> > +   partition@3 {
>>> > +   label = "u-boot-env";
>>> > +   reg = <0x3 0x1>;
>>> > +   read-only;
>>> > +   };
>>> > +
>>> > +   factory: partition@4 {
>>> > +   label = "factory";
>>> > +   reg = <0x4 0x1>;
>>> > +   };
>>> > +
>>> > +   partition@5 {
>>> > +   label = "firmware";
>>> > +   reg = <0x5 0xf8>;
>>> > +   };
>>> > +
>>> > +   partition@fd {
>>> > +   label = "hwf_config";
>>> > +   reg = <0xfd 0x1>;
>>> > +   };
>>> > +
>>> > +   bdinfo: partition@fe {
>>> > +   label = "bdinfo";
>>> > +   reg = <0xfe 0x1>;
>>> > +   };
>>> > +
>>> > +   partition@ff {
>>> > +   label = "backup";
>>> > +   reg = <0xff 0x1>;
>>> > +   };
>>> > +   };
>>> > +  

Re: [OpenWrt-Devel] [PATCH v2 1/3] ramips: Add DTS files for HiWiFi HC5x61 models

[Yousong Zhou]

On 29 September 2015 at 23:45, Kang Xiaoning  wrote:
> Hi Yousong
>
> Thanks for helping. Your questions are both valid..
>
> My initiative is to put basic support into trunk, and try to solve those
> problems later.
>
> Regarding #1,  I'm not comfortable enough to make a function in dts driver
> solely for those particular devices. Maybe a hack script to update wireless
> uci config files at firstboot is better?

It's just an ancient idea from me.  The intention is that since we
already have mtd-mac-address for binary ones, why not also include
those ascii variants.  Maybe some other boards also suffer from this
issue too and can benefit from the change.  Anyway there are ramips
maintainers to make the decision.

>
> For #2,  I can write the wiki page, though it is would be complicated.
> HiWiFi provides an "official" way to unlock the U-Boot now, at the cost of
> voiding warranty.  However, you have to follow a procedure which requires a
> Chinese cellphone number, and a WeChat(a whatsapp clone app) account.
> Understanding of Chinese is also a requirement.  Anyway, since HiWiFi
> routers are sold in Chinese market only, I believe it won't be a big problem
> for non-Chinese users.
>

Maybe... back in Oct. 2014, information about a mt7620 dev board [1]
was sought.  Looks like the case was removed but the style of board
layout made me think that it could be a board by HiWiFi.  I think I
can somehow understand why the pubkey firmware verification was added
later.  But personally I think those technical facts and details
should be collected and documented.

 [1] desperately seeking info on this weird MT7620A/MT7610EN dev
board, 
https://lists.openwrt.org/pipermail/openwrt-devel/2014-October/028516.html

Regards,

yousong


> Thanks again!
>
> On Tue, Sep 29, 2015 at 10:10 AM, Yousong Zhou 
> wrote:
>>
>> Hi,
>>
>> Previously this year, there were 2 attempts to add support for HC5661
>> and HC5761 to OpenWrt trunk [1,2].  I only had a HC5661 and it was
>> quite a while ago but the issues then should still remain.
>>
>> The first is about how MAC address is to be read.  The
>> "mtd-mac-address" DTS directives apparently won't work.  And if I
>> remember correctly simply reading and setting it for lan and wan also
>> has flaws that the WiFi interface still get the default hardcoded MAC
>> address by the driver.  The best way I can think of to workaround this
>> is to add a directive similar to what "mtd-mac-address" does for
>> binary-encoded MACs.
>>
>> "target/linux/generic/patches-4.1/681-NET-add-of_get_mac_address_mtd.patch"
>> can work as a reference.
>
>
>
>
>>
>>
>> The second is about how the generated the firmwares is to be flashed
>> to the those devices.  Are there plans to create wiki pages to clarify
>> the details?  Again if I remember correctly, the U-Boot of HC5661 at
>> least utilised pubkey firmware verification (though ...).  How regular
>> users are supposed to workaround this?
>>
>>  [1] HiWiFi HC5661 Support for Openwrt,
>> https://lists.openwrt.org/pipermail/openwrt-devel/2015-April/032640.html
>>  [2] ramips:Add support for HiWiFi HC5761,
>> https://lists.openwrt.org/pipermail/openwrt-devel/2015-April/032643.html
>>
>> Regard,
>>
>> yousong
>>
>> On 28 September 2015 at 22:42, Comman Kang  wrote:
>> > HiWiFi HC5661/5761/5861 models are manufactured by
>> > http://www.hiwifi.com. These models have similar hardware specs(MT7620A +
>> > 128M DDR2 + 16M flash). This patch adds support for them.
>> >
>> > The original author is Justin Liu (rss...@gmail.com). I ported the patch
>> > to trunk and submitted it here with his approval.
>> >
>> > v2 fix
>> >   1: Renamed files to remove manufacturer’s name.
>> >   2: styling work
>> >
>> > Signed-off-by: Xiaoning Kang 
>> >
>> >
>> > diff --git a/target/linux/ramips/dts/HC5661.dts
>> > b/target/linux/ramips/dts/HC5661.dts
>> > new file mode 100644
>> > index 000..b5b9d1a
>> > --- /dev/null
>> > +++ b/target/linux/ramips/dts/HC5661.dts
>> > @@ -0,0 +1,172 @@
>> > +/dts-v1/;
>> > +
>> > +/include/ "mt7620a.dtsi"
>> > +
>> > +/ {
>> > +   compatible = "HC5661", "ralink,mt7620a-soc";
>> > +   model = "HiWiFi HC5661";
>> > +
>> > +   chosen {
>> > +   bootargs = "console=ttyS0,115200";
>> > +   };
>> > +
>> > +   palmbus@1000 {
>> > +   sysc@0 {
>> > +   ralink,gpiomux = "i2c", "jtag";
>> > +   ralink,uartmux = "gpio";
>> > +   ralink,wdtmux = <1>;
>> > +   };
>> > +
>> > +   gpio0: gpio@600 {
>> > +   status = "okay";
>> > +   };
>> > +
>> > +   gpio2: gpio@660 {
>> > +   status = "okay";
>> > +   };
>> > +
>> > +   gpio3: gpio@688 {
>> > +   status = "okay";
>> > +   };
>> > +
>> > +  

Re: [OpenWrt-Devel] [PATCH v2 1/3] ramips: Add DTS files for HiWiFi HC5x61 models

[Piotr Dymacz]

Hello,

2015-10-02 15:53 GMT+02:00 康 :
>
> Hi,  Merging 3 dts into one dtsi has been done in patch V3 ,

Sorry, I missed that.

> Sorry I don't quite understand your question ,  do you mean how to flash on
> those devices?

Yes and I got the answer from your mail to Yousong:

> For #2,  I can write the wiki page, though it is would be complicated.
> HiWiFi provides an "official" way to unlock the U-Boot now, at the cost of
> voiding warranty.  However, you have to follow a procedure which requires a
> Chinese cellphone number, and a WeChat(a whatsapp clone app) account.
> Understanding of Chinese is also a requirement.  Anyway, since HiWiFi
> routers are sold in Chinese market only, I believe it won't be a big problem
> for non-Chinese users.

There are dozen ways to have devices for CN market in other parts of
the the world.
If there is no easier/ready way to switch from official firmware to
OpenWrt on those devices, I'm not convinced about keeping official
support for them in OpenWrt repository, but it's just mine opinion.

Cheers,
Piotr

[snip]
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH v2 1/3] ramips: Add DTS files for HiWiFi HC5x61 models

[Piotr Dymacz]

Hello,

I don't have more comments, it looks good now. Maybe just think about
my suggestion with common dtsi for all 3 models.
And just one question - how does it look with flashing process on those devices?

Cheers,
Piotr


2015-09-29 18:13 GMT+02:00 Kang Xiaoning :
>
>
> On Tue, Sep 29, 2015 at 4:31 AM, Piotr Dymacz  wrote:
>>
>> Hello,
>>
>> Just some small, cosmetic things... see inline, below.
>>
>> BTW.
>> I see that these models are very similar (most of the dts files are
>> just copy).
>> Maybe it would be better to make for them one, common dtsi file and
>> separated dts files per model (take Lenovo Y1/Y1S as example).
>>
>> Cheers,
>> Piotr
>>
>> 2015-09-28 16:42 GMT+02:00 Comman Kang :
>> > HiWiFi HC5661/5761/5861 models are manufactured by
>> > http://www.hiwifi.com. These models have similar hardware specs(MT7620A +
>> > 128M DDR2 + 16M flash). This patch adds support for them.
>> >
>> > The original author is Justin Liu (rss...@gmail.com). I ported the patch
>> > to trunk and submitted it here with his approval.
>> >
>> > v2 fix
>> >   1: Renamed files to remove manufacturer’s name.
>> >   2: styling work
>> >
>> > Signed-off-by: Xiaoning Kang 
>> >
>> >
>> > diff --git a/target/linux/ramips/dts/HC5661.dts
>> > b/target/linux/ramips/dts/HC5661.dts
>> > new file mode 100644
>> > index 000..b5b9d1a
>> > --- /dev/null
>> > +++ b/target/linux/ramips/dts/HC5661.dts
>> > @@ -0,0 +1,172 @@
>> > +/dts-v1/;
>> > +
>> > +/include/ "mt7620a.dtsi"
>> > +
>> > +/ {
>> > +   compatible = "HC5661", "ralink,mt7620a-soc";
>> > +   model = "HiWiFi HC5661";
>> > +
>> > +   chosen {
>> > +   bootargs = "console=ttyS0,115200";
>> > +   };
>> > +
>> > +   palmbus@1000 {
>> > +   sysc@0 {
>> > +   ralink,gpiomux = "i2c", "jtag";
>> > +   ralink,uartmux = "gpio";
>> > +   ralink,wdtmux = <1>;
>> > +   };
>> > +
>> > +   gpio0: gpio@600 {
>> > +   status = "okay";
>> > +   };
>> > +
>> > +   gpio2: gpio@660 {
>> > +   status = "okay";
>> > +   };
>> > +
>> > +   gpio3: gpio@688 {
>> > +   status = "okay";
>> > +   };
>> > +
>> > +   spi@b00 {
>> > +   status = "okay";
>> > +
>> > +   m25p80@0 {
>> > +   #address-cells = <1>;
>> > +   #size-cells = <1>;
>> > +   compatible = "w25q128";
>> > +   reg = <0 0>;
>> > +   linux,modalias = "m25p80", "w25q128";
>> > +   spi-max-frequency = <1000>;
>> > +
>> > +   partition@0 {
>> > +   label = "u-boot";
>> > +   reg = <0x0 0x3>;
>> > +   };
>> > +
>> > +   partition@3 {
>> > +   label = "u-boot-env";
>> > +   reg = <0x3 0x1>;
>> > +   read-only;
>> > +   };
>> > +
>> > +   factory: partition@4 {
>> > +   label = "factory";
>> > +   reg = <0x4 0x1>;
>> > +   };
>> > +
>> > +   partition@5 {
>> > +   label = "firmware";
>> > +   reg = <0x5 0xf8>;
>> > +   };
>> > +
>> > +   partition@fd {
>> > +   label = "hwf_config";
>> > +   reg = <0xfd 0x1>;
>> > +   };
>> > +
>> > +   bdinfo: partition@fe {
>> > +   label = "bdinfo";
>> > +   reg = <0xfe 0x1>;
>> > +   };
>> > +
>> > +   partition@ff {
>> > +   label = "backup";
>> > +   reg = <0xff 0x1>;
>> > +   };
>> > +   };
>> > +   };
>> > +   };
>> > +
>> > +   ehci@101c {
>> > +   status = "okay";
>> > +   };
>> > +
>> > +   ohci@101c1000 {
>> > +   status = "okay";
>> > +   };
>> > +
>> > +   ethernet@1010 {
>> > +   pinctrl-names = "default";
>> > +   pinctrl-0 = <_pins>;
>> > +   

Re: [OpenWrt-Devel] [PATCH v2 1/3] ramips: Add DTS files for HiWiFi HC5x61 models

[Piotr Dymacz]

Hello,

Just some small, cosmetic things... see inline, below.

BTW.
I see that these models are very similar (most of the dts files are
just copy).
Maybe it would be better to make for them one, common dtsi file and
separated dts files per model (take Lenovo Y1/Y1S as example).

Cheers,
Piotr

2015-09-28 16:42 GMT+02:00 Comman Kang :
> HiWiFi HC5661/5761/5861 models are manufactured by http://www.hiwifi.com. 
> These models have similar hardware specs(MT7620A + 128M DDR2 + 16M flash). 
> This patch adds support for them.
>
> The original author is Justin Liu (rss...@gmail.com). I ported the patch to 
> trunk and submitted it here with his approval.
>
> v2 fix
>   1: Renamed files to remove manufacturer’s name.
>   2: styling work
>
> Signed-off-by: Xiaoning Kang 
>
>
> diff --git a/target/linux/ramips/dts/HC5661.dts 
> b/target/linux/ramips/dts/HC5661.dts
> new file mode 100644
> index 000..b5b9d1a
> --- /dev/null
> +++ b/target/linux/ramips/dts/HC5661.dts
> @@ -0,0 +1,172 @@
> +/dts-v1/;
> +
> +/include/ "mt7620a.dtsi"
> +
> +/ {
> +   compatible = "HC5661", "ralink,mt7620a-soc";
> +   model = "HiWiFi HC5661";
> +
> +   chosen {
> +   bootargs = "console=ttyS0,115200";
> +   };
> +
> +   palmbus@1000 {
> +   sysc@0 {
> +   ralink,gpiomux = "i2c", "jtag";
> +   ralink,uartmux = "gpio";
> +   ralink,wdtmux = <1>;
> +   };
> +
> +   gpio0: gpio@600 {
> +   status = "okay";
> +   };
> +
> +   gpio2: gpio@660 {
> +   status = "okay";
> +   };
> +
> +   gpio3: gpio@688 {
> +   status = "okay";
> +   };
> +
> +   spi@b00 {
> +   status = "okay";
> +
> +   m25p80@0 {
> +   #address-cells = <1>;
> +   #size-cells = <1>;
> +   compatible = "w25q128";
> +   reg = <0 0>;
> +   linux,modalias = "m25p80", "w25q128";
> +   spi-max-frequency = <1000>;
> +
> +   partition@0 {
> +   label = "u-boot";
> +   reg = <0x0 0x3>;
> +   };
> +
> +   partition@3 {
> +   label = "u-boot-env";
> +   reg = <0x3 0x1>;
> +   read-only;
> +   };
> +
> +   factory: partition@4 {
> +   label = "factory";
> +   reg = <0x4 0x1>;
> +   };
> +
> +   partition@5 {
> +   label = "firmware";
> +   reg = <0x5 0xf8>;
> +   };
> +
> +   partition@fd {
> +   label = "hwf_config";
> +   reg = <0xfd 0x1>;
> +   };
> +
> +   bdinfo: partition@fe {
> +   label = "bdinfo";
> +   reg = <0xfe 0x1>;
> +   };
> +
> +   partition@ff {
> +   label = "backup";
> +   reg = <0xff 0x1>;
> +   };
> +   };
> +   };
> +   };
> +
> +   ehci@101c {
> +   status = "okay";
> +   };
> +
> +   ohci@101c1000 {
> +   status = "okay";
> +   };
> +
> +   ethernet@1010 {
> +   pinctrl-names = "default";
> +   pinctrl-0 = <_pins>;
> +   mtd-mac-address = < 0x4>;
> +   ralink,port-map = "w";
> +   };
> +
> +   sdhci@1013 {
> +   status = "okay";
> +   };
> +
> +   wmac@1018 {
> +   ralink,mtd-eeprom = < 0>;
> +   };
> +
> +   pcie@1014 {
> +   status = "okay";
> +   };
> +
> +   pinctrl {
> +   state_default: pinctrl0 {
> +   gpio {
> +   ralink,group = "uartf", "wled", "nd_sd";
> +   ralink,function = "gpio";
> +   };
> +
> +   pa {
> +   ralink,group = "pa";
> +   ralink,function = "pa";
> 

[OpenWrt-Devel] [PATCH v2 1/3] ramips: Add DTS files for HiWiFi HC5x61 models

[Comman Kang]

HiWiFi HC5661/5761/5861 models are manufactured by http://www.hiwifi.com. These 
models have similar hardware specs(MT7620A + 128M DDR2 + 16M flash). This patch 
adds support for them.

The original author is Justin Liu (rss...@gmail.com). I ported the patch to 
trunk and submitted it here with his approval.

v2 fix
  1: Renamed files to remove manufacturer’s name.
  2: styling work

Signed-off-by: Xiaoning Kang 


diff --git a/target/linux/ramips/dts/HC5661.dts 
b/target/linux/ramips/dts/HC5661.dts
new file mode 100644
index 000..b5b9d1a
--- /dev/null
+++ b/target/linux/ramips/dts/HC5661.dts
@@ -0,0 +1,172 @@
+/dts-v1/;
+
+/include/ "mt7620a.dtsi"
+
+/ {
+   compatible = "HC5661", "ralink,mt7620a-soc";
+   model = "HiWiFi HC5661";
+
+   chosen {
+   bootargs = "console=ttyS0,115200";
+   };
+
+   palmbus@1000 {
+   sysc@0 {
+   ralink,gpiomux = "i2c", "jtag";
+   ralink,uartmux = "gpio";
+   ralink,wdtmux = <1>;
+   };
+
+   gpio0: gpio@600 {
+   status = "okay";
+   };
+
+   gpio2: gpio@660 {
+   status = "okay";
+   };
+
+   gpio3: gpio@688 {
+   status = "okay";
+   };
+
+   spi@b00 {
+   status = "okay";
+
+   m25p80@0 {
+   #address-cells = <1>;
+   #size-cells = <1>;
+   compatible = "w25q128";
+   reg = <0 0>;
+   linux,modalias = "m25p80", "w25q128";
+   spi-max-frequency = <1000>;
+
+   partition@0 {
+   label = "u-boot";
+   reg = <0x0 0x3>;
+   };
+
+   partition@3 {
+   label = "u-boot-env";
+   reg = <0x3 0x1>;
+   read-only;
+   };
+
+   factory: partition@4 {
+   label = "factory";
+   reg = <0x4 0x1>;
+   };
+
+   partition@5 {
+   label = "firmware";
+   reg = <0x5 0xf8>;
+   };
+
+   partition@fd {
+   label = "hwf_config";
+   reg = <0xfd 0x1>;
+   };
+
+   bdinfo: partition@fe {
+   label = "bdinfo";
+   reg = <0xfe 0x1>;
+   };
+
+   partition@ff {
+   label = "backup";
+   reg = <0xff 0x1>;
+   };
+   };
+   };
+   };
+
+   ehci@101c {
+   status = "okay";
+   };
+
+   ohci@101c1000 {
+   status = "okay";
+   };
+
+   ethernet@1010 {
+   pinctrl-names = "default";
+   pinctrl-0 = <_pins>;
+   mtd-mac-address = < 0x4>;
+   ralink,port-map = "w";
+   };
+
+   sdhci@1013 {
+   status = "okay";
+   };
+
+   wmac@1018 {
+   ralink,mtd-eeprom = < 0>;
+   };
+
+   pcie@1014 {
+   status = "okay";
+   };
+
+   pinctrl {
+   state_default: pinctrl0 {
+   gpio {
+   ralink,group = "uartf", "wled", "nd_sd";
+   ralink,function = "gpio";
+   };
+
+   pa {
+   ralink,group = "pa";
+   ralink,function = "pa";
+   };
+   };
+   };
+
+   gpio-leds {
+   compatible = "gpio-leds";
+
+   system {
+   label = "hc5661:blue:system";
+   gpios = < 9 1>;
+   };
+
+   internet {
+   label = "hc5661:blue:internet";
+   gpios = < 11 1>;
+   };
+
+   wlan2g {
+   label = "hc5661:blue:wlan2g";
+   gpios = < 0 1>;
+   };
+
+   wlan5g {
+   label = "hc5661:blue:wlan5g";
+