Re: [OpenWrt-Devel] [PATCH] scripts/env: too much quoting

2011-04-01 Thread John Crispin
applied in r26391

thanks, john
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


[OpenWrt-Devel] [PATCH] scripts/env: too much quoting

2011-02-25 Thread Benjamin Cama
Hi,

I think someone munching too much with Makefiles thought that quoting
strings with an asterisk in it in bash is OK; it's not. Fix that.

Regards,
benjamin

--
Index: scripts/env
===
--- scripts/env (revision 25704)
+++ scripts/env (working copy)
@@ -138,7 +138,7 @@
env_sync_data
if ask_bool 1 Do you want to keep your current config and files; then
mkdir -p $BASEDIR/files
-   cp -a $ENVDIR/files/* $BASEDIR/files 2/dev/null /dev/null
+   cp -a $ENVDIR/files/* $BASEDIR/files 2/dev/null /dev/null
cp $ENVDIR/.config $BASEDIR/
else
rm -rf $BASEDIR/files $BASEDIR/.config
@@ -193,7 +193,7 @@
if ask_bool 1 Do you want to keep your current config and 
files?; then
[ -d $BASEDIR/files -a \! -L $BASEDIR/files ]  {
mkdir -p $ENVDIR/files
-   mv $BASEDIR/files/* $ENVDIR/files/ 
2/dev/null
+   mv $BASEDIR/files/* $ENVDIR/files/ 
2/dev/null
rmdir $BASEDIR/files
}
env_sync


___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel