Re: [ovs-dev] [PATCH 0/2] Allow for smoother restarting of ovn-controller

2018-07-30 Thread Jakub Sitnicki
On Tue, 24 Jul 2018 16:30:04 -0400
Mark Michelson  wrote:

> When ovn-controller is restarted, the ovn-controller process is stopped
> and then started again. When the process is stopped, the process cleans
> itself up by removing all traces of itself from the central southbound
> database and the OVS database on the hypervisor. The issue with this is
> that this removes tunnels, meaning that traffic from other hypervisors
> in the cluster is unable to reach the local hypervisor. When restarting,
> it would be better to not clean up, thus allowing for uninterrupted
> traffic flow.
> 
> This patchset allows for ovn-controller to be stopped without cleaning
> itself up. This way, during a restart, traffic can still flow freely
> while ovn-controller is down.
> 
> Mark Michelson (2):
>   ovn: Add '--restart' flag to ovn-controller exit.
>   ovn: Modify restart_controller in ovn-ctl to use --restart
> 
>  ovn/controller/ovn-controller.c |  92 +++-
>  ovn/utilities/ovn-ctl   |   4 +-
>  tests/ovn.at| 186 
> 
>  utilities/ovs-lib.in|   2 +-
>  4 files changed, 241 insertions(+), 43 deletions(-)
> 

I had one minor comment. Otherwise LGTM:

Acked-by: Jakub Sitnicki 
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev


[ovs-dev] [PATCH 0/2] Allow for smoother restarting of ovn-controller

2018-07-24 Thread Mark Michelson
When ovn-controller is restarted, the ovn-controller process is stopped
and then started again. When the process is stopped, the process cleans
itself up by removing all traces of itself from the central southbound
database and the OVS database on the hypervisor. The issue with this is
that this removes tunnels, meaning that traffic from other hypervisors
in the cluster is unable to reach the local hypervisor. When restarting,
it would be better to not clean up, thus allowing for uninterrupted
traffic flow.

This patchset allows for ovn-controller to be stopped without cleaning
itself up. This way, during a restart, traffic can still flow freely
while ovn-controller is down.

Mark Michelson (2):
  ovn: Add '--restart' flag to ovn-controller exit.
  ovn: Modify restart_controller in ovn-ctl to use --restart

 ovn/controller/ovn-controller.c |  92 +++-
 ovn/utilities/ovn-ctl   |   4 +-
 tests/ovn.at| 186 
 utilities/ovs-lib.in|   2 +-
 4 files changed, 241 insertions(+), 43 deletions(-)

-- 
2.14.4

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev