[Bug 895592] Review Request: syntaxhighlighter - JavaScript syntax highlighter
https://bugzilla.redhat.com/show_bug.cgi?id=895592 --- Comment #2 from Remi Collet --- (In reply to Christopher Meng from comment #1) > Hmm...No javascript packaging guideline now, only a draft. > > From fedora-review seems OK, but somethings maybe you should fix: > > 1) I found that mixture of tab and space in License and Source0 tag. Agree, will fix it > 2) This library has its GitHub page, and the author has tagged the 3.0.83 > version. > > https://github.com/alexgorbatchev/SyntaxHighlighter/tags Yes, but the github only provides the "sources" and we don't have (yet) needed stuff to run the build (npm, jake, ...) In fact, "master" use node.js stuff, while old release 3.0.83 use phing. I will look if we can build from source (it seems we need lot of fix because it use a very old version... of course... 2010) But don't know if it worth the work... as will be broken as soon as a new version will be released. Build for JS is mostly: concat + compress (result still readable) > 3) Is this spec for EL only? I've seen many obsoleted lines and buildroot > tag. This spec target EL-5, so yes buildroot, ... are required. > 4) A little more blanks between sections. Not mandatory. > > 5) License: MIT or GPLv2. Why not "and"? Because https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#Dual_Licensing_Scenarios -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Zp6xgnOLqB&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 895592] Review Request: syntaxhighlighter - JavaScript syntax highlighter
https://bugzilla.redhat.com/show_bug.cgi?id=895592 --- Comment #3 from Remi Collet --- Build from github sources: https://github.com/remicollet/remirepo/commit/5f76f61988779c3f6a3e0099f8c464a26cddc95a Spec: https://raw.github.com/remicollet/remirepo/5f76f61988779c3f6a3e0099f8c464a26cddc95a/syntaxhighlighter/syntaxhighlighter.spec SRPM: http://rpms.famillecollet.com/SRPMS/syntaxhighlighter-3.0.83-2.remi.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=j0dPKRpott&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 929005] Review Request: rubygem-awestruct - A framework for creating static HTML sites
https://bugzilla.redhat.com/show_bug.cgi?id=929005 Axilleas Pipinellis changed: What|Removed |Added CC||axill...@archlinux.gr Summary|Review Request: |Review Request: |rubygem-awestruct: a|rubygem-awestruct - A |framework for creating |framework for creating |static HTML sites |static HTML sites -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6OM6eBlCUk&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 895592] Review Request: syntaxhighlighter - JavaScript syntax highlighter
https://bugzilla.redhat.com/show_bug.cgi?id=895592 --- Comment #4 from Remi Collet --- Fix for EPEL-6 build https://github.com/remicollet/remirepo/commit/e288517d88ccea6525b8c9329133a6e8c8f8b9cd https://github.com/remicollet/remirepo/commit/7fbb189ab904b70a6c5d5a89d2190296b87e32f5 Koji scratch build dist-6E-epel http://koji.fedoraproject.org/koji/taskinfo?taskID=5508854 Spec: https://raw.github.com/remicollet/remirepo/7fbb189ab904b70a6c5d5a89d2190296b87e32f5/syntaxhighlighter/syntaxhighlighter.spec Srpm: http://rpms.famillecollet.com/SRPMS/syntaxhighlighter-3.0.83-2.remi.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hhfhkz4PRV&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 972568] Review Request: uthash - A hash table for C structures
https://bugzilla.redhat.com/show_bug.cgi?id=972568 --- Comment #9 from Christopher Meng --- NEW Spec URL: http://cicku.me/uthash.spec NEW SRPM URL: http://cicku.me/uthash-1.9.8-3.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=y1rHTMh4dm&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 974834] New: Review Request: libgit2-glib - Git library for GLib
https://bugzilla.redhat.com/show_bug.cgi?id=974834 Bug ID: 974834 Summary: Review Request: libgit2-glib - Git library for GLib Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: kalevlem...@gmail.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://kalev.fedorapeople.org/libgit2-glib.spec SRPM URL: http://kalev.fedorapeople.org/libgit2-glib-0.0.2-1.fc20.src.rpm Description: libgit2-glib is a glib wrapper library around the libgit2 git access library. Fedora Account System Username: kalev -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Rg8o2xfNhh&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 974834] Review Request: libgit2-glib - Git library for GLib
https://bugzilla.redhat.com/show_bug.cgi?id=974834 Kalev Lember changed: What|Removed |Added Depends On||867959 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rFbD7ZCMDr&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 867959] Review Request: libgit2 - C library for git
https://bugzilla.redhat.com/show_bug.cgi?id=867959 Kalev Lember changed: What|Removed |Added Blocks||974834 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=V946EK7XbP&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 921286] Review Request: cmd - wrap bash functions into a command
https://bugzilla.redhat.com/show_bug.cgi?id=921286 Fedora Update System changed: What|Removed |Added Status|NEW |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9UnwATXMQI&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 921286] Review Request: cmd - wrap bash functions into a command
https://bugzilla.redhat.com/show_bug.cgi?id=921286 --- Comment #3 from Fedora Update System --- rf-0.4.18-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/rf-0.4.18-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=f3bgrf1m6T&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957520] Review Request: rf - read feeds from any source
https://bugzilla.redhat.com/show_bug.cgi?id=957520 --- Comment #6 from Fedora Update System --- rf-0.4.18-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/rf-0.4.18-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=RojunlOBY8&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957520] Review Request: rf - read feeds from any source
https://bugzilla.redhat.com/show_bug.cgi?id=957520 Fedora Update System changed: What|Removed |Added Status|NEW |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=x4CZC99oF9&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 961177] Review Request: python-grokmirror - Framework to smartly mirror git repositories
https://bugzilla.redhat.com/show_bug.cgi?id=961177
Mario Blättermann changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #5 from Mario Blättermann ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=5509040
$ rpmlint -i -v *python-grokmirror.src: I: checking
python-grokmirror.src: I: checking-url
https://git.kernel.org/cgit/utils/grokmirror/grokmirror.git (timeout 10
seconds)
python-grokmirror.src: I: checking-url
https://www.kernel.org/pub/software/network/grokmirror/grokmirror-0.3.4.tar.xz
(timeout 10 seconds)
python-grokmirror.noarch: I: checking
python-grokmirror.noarch: I: checking-url
https://git.kernel.org/cgit/utils/grokmirror/grokmirror.git (timeout 10
seconds)
python-grokmirror.spec: I: checking-url
https://www.kernel.org/pub/software/network/grokmirror/grokmirror-0.3.4.tar.xz
(timeout 10 seconds)
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is clean.
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
GPLv3+
[+] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use sha256sum for this task as it
is used by the sources file once imported into git. If no upstream URL can be
specified for this package, please see the Source URL Guidelines for how to
deal with this.
sha256sum *
b25d19c974326ba71816550b1493a6972e39adb879f9d8945928fe0ee4dc9810
grokmirror-0.3.4.tar.xz
b25d19c974326ba71816550b1493a6972e39adb879f9d8945928fe0ee4dc9810
grokmirror-0.3.4.tar.xz.orig
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
[+] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[.] MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[.] MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
[.] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
[+] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
[+] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings. (Notable exception: license texts in specific
situations)
[+] MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage. (The
definition of large is left up to the packager's best judgement, but is not
restricted to size. Large can refer to either size or quantity).
[+] MUST: If a package includes something as %doc, it must not affect the
runtime of the application. To s
[Bug 916433] Review Request: python-tw2-polymaps - Toscawidgets2 wrapper for polymaps - amazing javascript maps
https://bugzilla.redhat.com/show_bug.cgi?id=916433 Mario Blättermann changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2013-06-16 06:57:51 --- Comment #11 from Mario Blättermann --- Packages are in the stable repos now, so this ticket can be safely closed. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jAvz5JFw4Z&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 916436] Review Request: python-narcissus-app - WSGI components for Narcissus, realtime log visualization
https://bugzilla.redhat.com/show_bug.cgi?id=916436 Bug 916436 depends on bug 916433, which changed state. Bug 916433 Summary: Review Request: python-tw2-polymaps - Toscawidgets2 wrapper for polymaps - amazing javascript maps https://bugzilla.redhat.com/show_bug.cgi?id=916433 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |CURRENTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CVkUpGCu11&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 895592] Review Request: syntaxhighlighter - JavaScript syntax highlighter
https://bugzilla.redhat.com/show_bug.cgi?id=895592
Christopher Meng changed:
What|Removed |Added
Flags||fedora-review+
--- Comment #5 from Christopher Meng ---
cp %{SOURCE2} %{SOURCE3} .
should be:
cp -p %{SOURCE2} %{SOURCE3} .
And please preserve the ts when downloading these two licenses.
APPROVED.
Please FIX this problem before importing.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=BwgCb1tYL3&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 895592] Review Request: syntaxhighlighter - JavaScript syntax highlighter
https://bugzilla.redhat.com/show_bug.cgi?id=895592 --- Comment #6 from Christopher Meng --- Plus, no need for %defattr(-,root,root,-), it's only needed < RPM 4.4 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=U69vJkOUK6&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957520] Review Request: rf - read feeds from any source
https://bugzilla.redhat.com/show_bug.cgi?id=957520 --- Comment #7 from Fedora Update System --- rf-0.4.18-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/rf-0.4.18-2.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=m9rLrhb6Fr&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 974834] Review Request: libgit2-glib - Git library for GLib
https://bugzilla.redhat.com/show_bug.cgi?id=974834
--- Comment #1 from Ignacio Casal Quinteiro (nacho) ---
MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.[1]
[nacho@winterfell Downloads]$ rpmlint libgit2-glib-0.0.2-1.fc20.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
MUST: The package must be named according to the Package Naming Guidelines .
OK
MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. [2] .
OK
MUST: The package must meet the Packaging Guidelines .
OK
MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines .
OK.
MUST: The License field in the package spec file must match the actual license.
[3]
OK
MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.[4]
OK, it is included and set on doc
MUST: The spec file must be written in American English. [5]
OK
MUST: The spec file for the package MUST be legible. [6]
It is!
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. Reviewers should use sha256sum for this task as it is
used by the sources file once imported into git. If no upstream URL can be
specified for this package, please see the Source URL Guidelines for how to
deal with this.
[nacho@winterfell SPECS]$ sha256sum libgit2-glib-0.0.2.tar.xz
e1e0c6e0cb6897c09e06edc06ee70befca2a3e1b3eb629c449b8ca0f49db75e5
libgit2-glib-0.0.2.tar.xz
[nacho@winterfell SPECS]$ sha256sum ../SOURCES/libgit2-glib-0.0.2.tar.xz
e1e0c6e0cb6897c09e06edc06ee70befca2a3e1b3eb629c449b8ca0f49db75e5
../SOURCES/libgit2-glib-0.0.2.tar.xz
They both match correctly.
MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture. [7]
http://koji.fedoraproject.org/koji/taskinfo?taskID=5509104
MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line. [8]
It is fine for 64 and 32
MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
It is fine
MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.[9]
Not needed.
MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun. [10]
It does
MUST: Packages must NOT bundle copies of system libraries.[11]
It doesn't
MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker. [12]
Not needed
MUST: A package must own all directories that it creates. If it does not create
a directory that it uses, then it should require a package which does create
that directory. [13]
This is not completely correct, we should one of these:
1) have libgit2-glib depend on python3-gobject
2) have libgit2-glib also list /usr/lib64/python3.3/site-packages/gi/ and
/usr/lib64/python3.3/site-packages/gi/overrides/ in its files list
MUST: A Fedora package must not list a file more than once in the spec file's
%files listings. (Notable exception: license texts in specific situations)[14]
OK
MUST: Permissions on files must be set properly. Executables should be set with
executable permissions, for example. [15]
OK
MUST: Each package must consistently use macros. [16]
OK
MUST: The package must contain code, or permissable content. [17]
It does
MUST: Large documentation files must go in a -doc subpackage. (The definition
of large is left up to the packager's best judgement, but is not restricted to
size. Large can refer to either size or quantity). [18]
OK
MUST: If a package includes something as %doc, it must not affect the runtime
of the application. To summarize: If it is in %doc, the program must run
properly if it is not present. [18]
It just uses gtk-doc stuff so this is fine.
MUST: Static libraries must be in a -static package. [19]
Not needed.
MUST: Development files must be in a -devel package. [20]
OK
MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name}%{?_
[Bug 957520] Review Request: rf - read feeds from any source
https://bugzilla.redhat.com/show_bug.cgi?id=957520 --- Comment #8 from Fedora Update System --- rf-0.4.18-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/rf-0.4.18-2.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=s3zMnD2K91&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957520] Review Request: rf - read feeds from any source
https://bugzilla.redhat.com/show_bug.cgi?id=957520 --- Comment #9 from Fedora Update System --- rf-0.4.18-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/rf-0.4.18-2.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NeVDySsvAa&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 974834] Review Request: libgit2-glib - Git library for GLib
https://bugzilla.redhat.com/show_bug.cgi?id=974834 --- Comment #2 from Kalev Lember --- > MUST: A package must own all directories that it creates. If it does not > create a directory that it uses, then it should require a package which does > create that directory. [13] > This is not completely correct, we should one of these: > 1) have libgit2-glib depend on python3-gobject > 2) have libgit2-glib also list /usr/lib64/python3.3/site-packages/gi/ and > /usr/lib64/python3.3/site-packages/gi/overrides/ in its files list Fixed. * Sun Jun 16 2013 Kalev Lember - 0.0.2-2 - Review fixes: depend on python3-gobject (#974834) Spec URL: http://kalev.fedorapeople.org/libgit2-glib.spec SRPM URL: http://kalev.fedorapeople.org/libgit2-glib-0.0.2-2.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=C3rNqOl5mj&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 974834] Review Request: libgit2-glib - Git library for GLib
https://bugzilla.redhat.com/show_bug.cgi?id=974834 Ignacio Casal Quinteiro (nacho) changed: What|Removed |Added Assignee|nob...@fedoraproject.org|i...@gnome.org Flags||fedora-review+ --- Comment #3 from Ignacio Casal Quinteiro (nacho) --- It looks good to me now. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LyNN69QgJJ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 974834] Review Request: libgit2-glib - Git library for GLib
https://bugzilla.redhat.com/show_bug.cgi?id=974834 Kalev Lember changed: What|Removed |Added Flags||fedora-cvs? --- Comment #4 from Kalev Lember --- Thanks for the review, nacho! New Package SCM Request === Package Name: libgit2-glib Short Description: Git library for GLib Owners: nacho kalev Branches: f19 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6Je2EBBUAJ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 971059] Review Request: nimrod - A statically typed, imperative programming language
https://bugzilla.redhat.com/show_bug.cgi?id=971059 --- Comment #6 from Mario Blättermann --- Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5509118 $ rpmlint -i -v * nimrod.i686: I: checking nimrod.i686: W: spelling-error %description -l en_US runtime -> run time, run-time, rudiment The value of this tag appears to be misspelled. Please double-check. nimrod.i686: W: spelling-error %description -l en_US realtime -> mealtime, real time, real-time The value of this tag appears to be misspelled. Please double-check. nimrod.i686: I: checking-url http://nimrod-code.org (timeout 10 seconds) nimrod.i686: W: only-non-binary-in-usr-lib There are only non binary files in /usr/lib so they should be in /usr/share. nimrod.i686: W: devel-file-in-non-devel-package /usr/lib/nimrod/nimbase.h A development file (usually source code) is located in a non-devel package. If you want to include source code in your package, be sure to create a development package. nimrod.i686: W: file-not-utf8 /usr/share/doc/nimrod-0.9.2/contributors.txt The character encoding of this file is not UTF-8. Consider converting it in the specfile's %prep section for example using iconv(1). nimrod.i686: E: incorrect-fsf-address /usr/lib/nimrod/wrappers/cairo/cairo.nim The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. nimrod.i686: W: no-manual-page-for-binary nimrod Each executable in standard binary directories should have a man page. nimrod.src: I: checking nimrod.src: W: spelling-error %description -l en_US runtime -> run time, run-time, rudiment The value of this tag appears to be misspelled. Please double-check. nimrod.src: W: spelling-error %description -l en_US realtime -> mealtime, real time, real-time The value of this tag appears to be misspelled. Please double-check. nimrod.src: I: checking-url http://nimrod-code.org (timeout 10 seconds) nimrod.src: I: checking-url http://nimrod-code.org/download/nimrod_0.9.2.zip (timeout 10 seconds) nimrod.x86_64: I: checking nimrod.x86_64: W: spelling-error %description -l en_US runtime -> run time, run-time, rudiment The value of this tag appears to be misspelled. Please double-check. nimrod.x86_64: W: spelling-error %description -l en_US realtime -> mealtime, real time, real-time The value of this tag appears to be misspelled. Please double-check. nimrod.x86_64: I: checking-url http://nimrod-code.org (timeout 10 seconds) nimrod.x86_64: W: only-non-binary-in-usr-lib There are only non binary files in /usr/lib so they should be in /usr/share. nimrod.x86_64: W: file-not-utf8 /usr/share/doc/nimrod-0.9.2/contributors.txt The character encoding of this file is not UTF-8. Consider converting it in the specfile's %prep section for example using iconv(1). nimrod.x86_64: E: incorrect-fsf-address /usr/lib64/nimrod/wrappers/cairo/cairo.nim The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. nimrod.x86_64: W: devel-file-in-non-devel-package /usr/lib64/nimrod/nimbase.h A development file (usually source code) is located in a non-devel package. If you want to include source code in your package, be sure to create a development package. nimrod.x86_64: W: no-manual-page-for-binary nimrod Each executable in standard binary directories should have a man page. nimrod-debuginfo.i686: I: checking nimrod-debuginfo.i686: I: checking-url http://nimrod-code.org (timeout 10 seconds) nimrod-debuginfo.i686: E: debuginfo-without-sources This debuginfo package appears to contain debug symbols but no source files. This is often a sign of binaries being unexpectedly stripped too early during the build, or being compiled without compiler debug flags (which again often is a sign of distro's default compiler flags ignored which might have security consequences), or other compiler flags which result in rpmbuild's debuginfo extraction not working as expected. Verify that the binaries are not unexpectedly stripped and that the intended compiler flags are used. nimrod-debuginfo.x86_64: I: checking nimrod-debuginfo.x86_64: I: checking-url http://nimrod-code.org (timeout 10 seconds) nimrod-debuginfo.x86_64: E: debuginfo-without-sources This debuginfo package appears to contain debug symbols but no source files. This is often a sign of binaries being unexpectedly stripped too early during the build, or being compiled without compiler debug flags (which again often is a sign of distro's default compiler flags ignored which might have security consequences), or other compiler flags which result in rpmbuild's debuginfo extraction not working as expected. Verify that the binaries are not unexpectedly stripped and that the intended compiler flags are used. nimrod-doc.noarch: I: chec
[Bug 973780] Review Request: kde-plasma-applicationname - QML plasmoid to display the application title of the focused window
https://bugzilla.redhat.com/show_bug.cgi?id=973780
--- Comment #9 from Björn Esser ---
Created attachment 761828
--> https://bugzilla.redhat.com/attachment.cgi?id=761828&action=edit
Source0 with working direct url
Package is fine. No blockers found.
Not a blocker, but Souce0 can be modified to point to an URL, see attached
patch. It's up to you whether using or not. :)
#
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- update-desktop-database is invoked when required
Note: desktop file(s) in kde-plasma-applicationname
See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache
---> false positve: whether icons nor mime-info is installed.
- Package installs a %{name}.desktop using desktop-file-install if there is
such a file.
See: http://fedoraproject.org/wiki/Packaging/Guidelines#desktop
---> false positve: is no application, is KDE-widget
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. No licenses
found. Please check the source files for licenses manually.
---> License-Tag is fine.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 10240 bytes in 1 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
---> license is mentioned in README, should be enough here.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: SourceX tarball generation or download is documented.
Note: Package contains tarball without URL, check comments
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is
[Bug 973780] Review Request: kde-plasma-applicationname - QML plasmoid to display the application title of the focused window
https://bugzilla.redhat.com/show_bug.cgi?id=973780 Björn Esser changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=k0s2elmjIV&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 968597] Review Request: nodejs-ejs - Embedded JavaScript templates for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=968597 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TicRIqeb09&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 968597] Review Request: nodejs-ejs - Embedded JavaScript templates for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=968597 --- Comment #6 from Fedora Update System --- nodejs-ejs-0.8.4-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/nodejs-ejs-0.8.4-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4wsYkXo6uF&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 968597] Review Request: nodejs-ejs - Embedded JavaScript templates for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=968597 --- Comment #7 from Fedora Update System --- nodejs-ejs-0.8.4-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/nodejs-ejs-0.8.4-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=u2VToeoVoE&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 968598] Review Request: nodejs-escodegen - ECMAScript code generator
https://bugzilla.redhat.com/show_bug.cgi?id=968598 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=AqvGqLQEgx&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 968598] Review Request: nodejs-escodegen - ECMAScript code generator
https://bugzilla.redhat.com/show_bug.cgi?id=968598 --- Comment #7 from Fedora Update System --- nodejs-escodegen-0.0.22-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/nodejs-escodegen-0.0.22-2.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=XimKW18dWj&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 968598] Review Request: nodejs-escodegen - ECMAScript code generator
https://bugzilla.redhat.com/show_bug.cgi?id=968598 --- Comment #8 from Fedora Update System --- nodejs-escodegen-0.0.22-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/nodejs-escodegen-0.0.22-2.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=19aqo8rEx7&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 968598] Review Request: nodejs-escodegen - ECMAScript code generator
https://bugzilla.redhat.com/show_bug.cgi?id=968598 --- Comment #9 from Fedora Update System --- nodejs-escodegen-0.0.22-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/nodejs-escodegen-0.0.22-2.el6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gOukwrlRMK&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911038] Review Request: nodejs-mimeparse - A Node.js module with basic functions for handling mime-types
https://bugzilla.redhat.com/show_bug.cgi?id=911038 Jamie Nguyen changed: What|Removed |Added Flags||fedora-cvs? --- Comment #2 from Jamie Nguyen --- New Package SCM Request === Package Name: nodejs-mimeparse Short Description: A Node.js module with basic functions for handling mime-types Owners: jamielinux patches Branches: f18 f19 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Bbi1RuiqVH&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911035] Review Request: nodejs-isodate - JavaScript ISO 8601 date/time parser for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=911035 --- Comment #2 from Jamie Nguyen --- Spec URL: http://jamielinux.fedorapeople.org/buddycloud-server/nodejs-isodate.spec SRPM URL: http://jamielinux.fedorapeople.org/buddycloud-server/SRPMS/nodejs-isodate-0.1.4-2.fc19.src.rpm * Sun Jun 16 2013 Jamie Nguyen - 0.1.4-2 - include test.js -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=P11xGIfHZi&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911035] Review Request: nodejs-isodate - JavaScript ISO 8601 date/time parser for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=911035 Jamie Nguyen changed: What|Removed |Added Flags||fedora-cvs? --- Comment #3 from Jamie Nguyen --- New Package SCM Request === Package Name: nodejs-isodate Short Description: JavaScript ISO 8601 date/time parser for Node.js Owners: jamielinux patches Branches: f18 f19 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TwDMFp9I9I&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911034] Review Request: nodejs-i - Custom inflections for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=911034 Jamie Nguyen changed: What|Removed |Added Flags||fedora-cvs? --- Comment #2 from Jamie Nguyen --- New Package SCM Request === Package Name: nodejs-i Short Description: Custom inflections for Node.js Owners: jamielinux patches Branches: f18 f19 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ojSiHdsoZd&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911025] Review Request: nodejs-collections - Data structures with idiomatic JavaScript collection interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=911025 --- Comment #3 from Jamie Nguyen --- Spec URL: http://jamielinux.fedorapeople.org/buddycloud-server/nodejs-collections.spec SRPM URL: http://jamielinux.fedorapeople.org/buddycloud-server/SRPMS/nodejs-collections-0.1.20-2.fc19.src.rpm * Sun Jun 16 2013 Jamie Nguyen - 0.1.20-2 - fix URL - include copy of Montage BSD license -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LXGxd4nbqY&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911029] Review Request: nodejs-dep-graph - Node.js module for simple dependency graph management in JavaScript
https://bugzilla.redhat.com/show_bug.cgi?id=911029 --- Comment #3 from Jamie Nguyen --- Spec URL: http://jamielinux.fedorapeople.org/buddycloud-server/nodejs-dep-graph.spec SRPM URL: http://jamielinux.fedorapeople.org/buddycloud-server/SRPMS/nodejs-dep-graph-1.1.0-2.fc19.src.rpm * Sun Jun 16 2013 Jamie Nguyen - 1.1.0-2 - unconditionalize 'cake build' - improve Summary -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Y0lj1tCTFU&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911025] Review Request: nodejs-collections - Data structures with idiomatic JavaScript collection interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=911025 T.C. Hollingsworth changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #4 from T.C. Hollingsworth --- This package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=sIg8f5grrx&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911029] Review Request: nodejs-dep-graph - Node.js module for simple dependency graph management in JavaScript
https://bugzilla.redhat.com/show_bug.cgi?id=911029 T.C. Hollingsworth changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #4 from T.C. Hollingsworth --- Still builds in mock fine with `cake build` enabled, so APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=V2JUuYdb3M&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 961177] Review Request: python-grokmirror - Framework to smartly mirror git repositories
https://bugzilla.redhat.com/show_bug.cgi?id=961177 Konstantin Ryabitsev changed: What|Removed |Added CC|i...@fedoraproject.org | Flags||fedora-cvs? --- Comment #6 from Konstantin Ryabitsev --- Thanks, Mario! New Package SCM Request === Package Name: python-grokmirror Short Description: Framework to smartly mirror git repositories Owners: icon Branches: f18 f19 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EeagALN9o7&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 895592] Review Request: syntaxhighlighter - JavaScript syntax highlighter
https://bugzilla.redhat.com/show_bug.cgi?id=895592 Remi Collet changed: What|Removed |Added Flags||fedora-cvs? --- Comment #7 from Remi Collet --- Thanks for the review. I will clean the EL-5 stuff after import (EL-5 is no more a target as phing is missing) New Package SCM Request === Package Name: syntaxhighlighter Short Description: JavaScript syntax highlighter Owners: remi Branches: f18 f19 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=neEzi0cSvm&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 974852] New: Review Request: fish - A Friendly Interactive SHell
https://bugzilla.redhat.com/show_bug.cgi?id=974852 Bug ID: 974852 Summary: Review Request: fish - A Friendly Interactive SHell Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: unspecified Assignee: nob...@fedoraproject.org Reporter: laurence.mcglas...@gmail.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: https://github.com/lrm29/fish-rpm/blob/master/fish.spec SRPM URL: https://github.com/lrm29/fish-rpm/blob/master/fish-2.0.0-1.fc18.src.rpm Description: fish is a shell geared towards interactive use. Its features are focused on user friendliness and discoverability. The language syntax is simple but incompatible with other shell languages. Fedora Account System Username: lrm29 Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5509440 This is my first package, and I am seeking a sponsor. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=IWOcA4BOxT&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911029] Review Request: nodejs-dep-graph - Node.js module for simple dependency graph management in JavaScript
https://bugzilla.redhat.com/show_bug.cgi?id=911029 Jamie Nguyen changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from Jamie Nguyen --- New Package SCM Request === Package Name: nodejs-dep-graph Short Description: Simple dependency graph management in JavaScript Owners: jamielinux patches Branches: f18 f19 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=isUz5CAwPr&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 974852] Review Request: fish - A Friendly Interactive SHell
https://bugzilla.redhat.com/show_bug.cgi?id=974852 laurence.mcglas...@gmail.com changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SXfsVJEStv&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911025] Review Request: nodejs-collections - Data structures with idiomatic JavaScript collection interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=911025 --- Comment #5 from Jamie Nguyen --- New Package SCM Request === Package Name: nodejs-collections Short Description: Data structures with idiomatic JavaScript collection interfaces Owners: jamielinux patches Branches: f18 f19 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5FXKNArgrW&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911025] Review Request: nodejs-collections - Data structures with idiomatic JavaScript collection interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=911025 Jamie Nguyen changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5bA7xkdCfH&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 973904] Review Request: libserf - High-Performance Asynchronous HTTP Client Library
https://bugzilla.redhat.com/show_bug.cgi?id=973904 --- Comment #15 from Fedora Update System --- libserf-1.2.1-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/libserf-1.2.1-3.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BOn27cc3Ri&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 973904] Review Request: libserf - High-Performance Asynchronous HTTP Client Library
https://bugzilla.redhat.com/show_bug.cgi?id=973904 --- Comment #16 from Fedora Update System --- libserf-1.2.1-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/libserf-1.2.1-3.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=QfLA9bQZH6&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 973780] Review Request: kde-plasma-applicationname - QML plasmoid to display the application title of the focused window
https://bugzilla.redhat.com/show_bug.cgi?id=973780 Mario Blättermann changed: What|Removed |Added Flags||fedora-cvs? --- Comment #10 from Mario Blättermann --- Many thanks for your review! I'll have a look at your patch before importing it to the Git repo. New Package SCM Request === Package Name: kde-plasma-applicationname Short Description: QML plasmoid to display the application title of the focused window Owners: mariobl Branches: f18 f19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NcsQ41JcP1&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 852254] Review Request: python-clouddns - Python interface to Rackspace Cloud DNS
https://bugzilla.redhat.com/show_bug.cgi?id=852254 --- Comment #4 from Mario Blättermann --- The URL link is not available (HTTP 404). The new location is https://github.com/rackerlabs/python-clouddns. Moreover, python-devel is deprecated, use python2-devel instead: https://fedoraproject.org/wiki/Packaging:Python#BuildRequires -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=oPVLDSapfY&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 972719] Review Request: nicstat - prints out network statistics for all network interface
https://bugzilla.redhat.com/show_bug.cgi?id=972719 Tomasz Torcz changed: What|Removed |Added Attachment #760712|0 |1 is obsolete|| --- Comment #11 from Tomasz Torcz --- Created attachment 761881 --> https://bugzilla.redhat.com/attachment.cgi?id=761881&action=edit changes in nicstat.spec Spec: http://ttorcz.fedorapeople.org/nicstat.spec SRPM: http://ttorcz.fedorapeople.org/nicstat-1.92-5.fc18.src.rpm Thank you, Douglas. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8k6AAjZlRi&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911186] Review Request: mocha - A simple, flexible, fun test framework for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=911186 Fedora Update System changed: What|Removed |Added Fixed In Version||mocha-1.10.0-1.el6 --- Comment #18 from Fedora Update System --- mocha-1.10.0-1.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ox8dagP63O&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910150] Review Request: nodejs-express - Sinatra inspired web development framework for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=910150 Fedora Update System changed: What|Removed |Added Fixed In Version||nodejs-express-3.2.5-1.el6 --- Comment #12 from Fedora Update System --- nodejs-express-3.2.5-1.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LX9BRdhmLY&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967187] Review Request: wemux - A tool help improve multi-user terminal multiplexing
https://bugzilla.redhat.com/show_bug.cgi?id=967187 Fedora Update System changed: What|Removed |Added Fixed In Version|wemux-2.2.0-1.fc19 |wemux-2.2.0-1.el6 --- Comment #12 from Fedora Update System --- wemux-2.2.0-1.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gv6166C0KP&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 950296] Review Request: reposurgeon - A tool for doing surgical operations on repositories
https://bugzilla.redhat.com/show_bug.cgi?id=950296 Fedora Update System changed: What|Removed |Added Fixed In Version|reposurgeon-2.39-2.fc19 |reposurgeon-2.39-2.el6 --- Comment #19 from Fedora Update System --- reposurgeon-2.39-2.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=oGXdqk4vOX&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958344] Review Request: python-extras - Useful extra bits for Python
https://bugzilla.redhat.com/show_bug.cgi?id=958344 --- Comment #26 from Fedora Update System --- python-extras-0.0.3-2.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=VZUk0i3iTJ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910142] Review Request: nodejs-send - Better streaming static file server with Range and conditional-GET support
https://bugzilla.redhat.com/show_bug.cgi?id=910142 Fedora Update System changed: What|Removed |Added Fixed In Version||nodejs-send-0.1.0-3.el6 --- Comment #15 from Fedora Update System --- nodejs-send-0.1.0-3.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=d3R8opgr30&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 968859] Review Request: nodejs-through - Simplified stream construction for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=968859 Fedora Update System changed: What|Removed |Added Fixed In Version|nodejs-through-2.3.4-1.fc18 |nodejs-through-2.3.4-1.el6 --- Comment #9 from Fedora Update System --- nodejs-through-2.3.4-1.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=sK32EhnDll&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910148] Review Request: nodejs-connect - High performance middleware framework for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=910148 Fedora Update System changed: What|Removed |Added Fixed In Version||nodejs-connect-2.7.10-1.el6 --- Comment #17 from Fedora Update System --- nodejs-connect-2.7.10-1.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vZ3cdMYBnU&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 883413] Review Request: java-dirq - Directory based queue
https://bugzilla.redhat.com/show_bug.cgi?id=883413 --- Comment #21 from Fedora Update System --- java-dirq-1.3-3.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ql8kZMyJAd&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910119] Review Request: nodejs-commander - Node.js command-line interfaces made easy
https://bugzilla.redhat.com/show_bug.cgi?id=910119 Fedora Update System changed: What|Removed |Added Fixed In Version||nodejs-commander-1.1.1-1.el ||6 --- Comment #14 from Fedora Update System --- nodejs-commander-1.1.1-1.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kvUki9ZA4P&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911258] Review Request: expresso - A lightweight, fast, test-driven development (TDD) framework for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=911258 Fedora Update System changed: What|Removed |Added Fixed In Version||expresso-0.9.2-3.el6 --- Comment #11 from Fedora Update System --- expresso-0.9.2-3.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LQWjNzpcIq&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910145] Review Request: nodejs-ltx - A Node.js module for parsing, modifying and building XML
https://bugzilla.redhat.com/show_bug.cgi?id=910145 Fedora Update System changed: What|Removed |Added Fixed In Version||nodejs-ltx-0.2.3-1.el6 --- Comment #9 from Fedora Update System --- nodejs-ltx-0.2.3-1.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=IifDkHhKW6&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 968606] Review Request: nodejs-paperboy - A node.js module for delivering static files
https://bugzilla.redhat.com/show_bug.cgi?id=968606 Fedora Update System changed: What|Removed |Added Fixed In Version|nodejs-paperboy-0.0.5-1.fc1 |nodejs-paperboy-0.0.5-1.el6 |8 | --- Comment #9 from Fedora Update System --- nodejs-paperboy-0.0.5-1.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4BIPtD3a8M&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 962820] Review Request: pngquant - PNG quantization tool for reducing image file size
https://bugzilla.redhat.com/show_bug.cgi?id=962820 Fedora Update System changed: What|Removed |Added Fixed In Version|pngquant-1.8.3-6.fc19 |pngquant-1.8.3-6.el5 --- Comment #25 from Fedora Update System --- pngquant-1.8.3-6.el5 has been pushed to the Fedora EPEL 5 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=veKyaqC52x&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 962820] Review Request: pngquant - PNG quantization tool for reducing image file size
https://bugzilla.redhat.com/show_bug.cgi?id=962820 Fedora Update System changed: What|Removed |Added Fixed In Version|pngquant-1.8.3-6.el5|pngquant-1.8.3-6.el6 --- Comment #26 from Fedora Update System --- pngquant-1.8.3-6.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=i18zVpwvZS&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 883413] Review Request: java-dirq - Directory based queue
https://bugzilla.redhat.com/show_bug.cgi?id=883413 --- Comment #22 from Fedora Update System --- java-dirq-1.3-3.el5 has been pushed to the Fedora EPEL 5 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=h2VyNQhbK5&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911183] Review Request: nodejs-jade - Jade template engine for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=911183 Fedora Update System changed: What|Removed |Added Fixed In Version||nodejs-jade-0.28.2-1.el6 --- Comment #13 from Fedora Update System --- nodejs-jade-0.28.2-1.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gsiHzWxfsd&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 968855] Review Request: nodejs-defined - Return the first argument that is '!== undefined'
https://bugzilla.redhat.com/show_bug.cgi?id=968855 Fedora Update System changed: What|Removed |Added Fixed In Version|nodejs-defined-0.0.0-1.fc18 |nodejs-defined-0.0.0-1.el6 --- Comment #9 from Fedora Update System --- nodejs-defined-0.0.0-1.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=STDfpZIG4v&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 968598] Review Request: nodejs-escodegen - ECMAScript code generator
https://bugzilla.redhat.com/show_bug.cgi?id=968598 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #10 from Fedora Update System --- nodejs-escodegen-0.0.22-2.el6 has been pushed to the Fedora EPEL 6 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NzuRa6W93p&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 968856] Review Request: nodejs-jsonify - JSON without touching any globals
https://bugzilla.redhat.com/show_bug.cgi?id=968856 Fedora Update System changed: What|Removed |Added Fixed In Version|nodejs-jsonify-0.0.0-1.fc18 |nodejs-jsonify-0.0.0-1.el6 --- Comment #9 from Fedora Update System --- nodejs-jsonify-0.0.0-1.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6AsIwBuVnv&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785462] Review Request: sinfo - Show an overview of the available computers an their current load
https://bugzilla.redhat.com/show_bug.cgi?id=785462 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #23 from Fedora Update System --- sinfo-0.0.47-3.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=iJG5sQV7RY&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957520] Review Request: rf - read feeds from any source
https://bugzilla.redhat.com/show_bug.cgi?id=957520 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #10 from Fedora Update System --- rf-0.4.18-2.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=aHeACJ8DsF&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 968597] Review Request: nodejs-ejs - Embedded JavaScript templates for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=968597 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #8 from Fedora Update System --- nodejs-ejs-0.8.4-1.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=w6ptOt4PKp&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 956134] Review Request: mnmlicons-fonts - Perkins Less Web Framework webfonts
https://bugzilla.redhat.com/show_bug.cgi?id=956134 --- Comment #7 from Alec Leamas --- Hm... I'm still quite new to fonts, and things are not really clear to me. That said, the mnmlicons font is just a set of icons and not a traditional character font (and it's definitely not a Serif character font). All this means, still as I understand it, that the only meaningful usecase is when the app requests the mnmlicons font. It can't substitute for anything else, and can't be substituted. That's why I left the fontconfig file empty, right or wrong. I should have mentioned that this is packaged as a dependency of bug 957339, a web application which bundles this font upstream. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ACaFYE32l8&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 974348] Review Request: python-itsdangerous - Python library for passing trusted data to untrusted environments
https://bugzilla.redhat.com/show_bug.cgi?id=974348 --- Comment #3 from Dan Callaghan --- Thanks Ricky. Updated: http://fedorapeople.org/~dcallagh/python-itsdangerous/python-itsdangerous.spec http://fedorapeople.org/~dcallagh/python-itsdangerous/python-itsdangerous-0.21-2.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ERNZr1D4zF&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 814088] Review Request: fungal - a POJO kernel environment used by Ironjacamar standalone
https://bugzilla.redhat.com/show_bug.cgi?id=814088 --- Comment #8 from Lin Gao --- The developer will include a license file in next release, but I need to wait for that. so I will re-submit this package till next release of fungal. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=drEigLepQK&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920436] Review Request: rubygem-bootstrap-sass - Bootstrap, converted to Sass
https://bugzilla.redhat.com/show_bug.cgi?id=920436 Mamoru TASAKA changed: What|Removed |Added Flags|fedora-review? | -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5uW0nA5XBL&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 894524] Review Request: rubygem-openshift-origin-console - OpenShift Origin Management Console
https://bugzilla.redhat.com/show_bug.cgi?id=894524 Bug 894524 depends on bug 920436, which changed state. Bug 920436 Summary: Review Request: rubygem-bootstrap-sass - Bootstrap, converted to Sass https://bugzilla.redhat.com/show_bug.cgi?id=920436 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |INSUFFICIENT_DATA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Yqt2Fmlzfl&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920436] Review Request: rubygem-bootstrap-sass - Bootstrap, converted to Sass
https://bugzilla.redhat.com/show_bug.cgi?id=920436 Mamoru TASAKA changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |INSUFFICIENT_DATA Flags|needinfo?(dal...@redhat.com | |) | Last Closed||2013-06-16 20:10:43 --- Comment #11 from Mamoru TASAKA --- Closing. If someone is interested in this package, please open a new review request, thank you. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=aUb8vQJmVA&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 929005] Review Request: rubygem-awestruct - A framework for creating static HTML sites
https://bugzilla.redhat.com/show_bug.cgi?id=929005 Bug 929005 depends on bug 920436, which changed state. Bug 920436 Summary: Review Request: rubygem-bootstrap-sass - Bootstrap, converted to Sass https://bugzilla.redhat.com/show_bug.cgi?id=920436 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |INSUFFICIENT_DATA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hyo9MsvVxF&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 973448] Review Request: 64tass - cross assembler for 6502 microprocessor family
https://bugzilla.redhat.com/show_bug.cgi?id=973448 --- Comment #2 from Eric Smith --- The rpmlint warnings can be ignored. The lack of a manual page is because upstream does not provide one. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=u8pMWJqw4l&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 852214] Review Request: overpass-fonts - Typeface based on the U.S. interstate highway road signage type system
https://bugzilla.redhat.com/show_bug.cgi?id=852214 Ruediger Landmann changed: What|Removed |Added Flags||fedora-cvs? --- Comment #15 from Ruediger Landmann --- (In reply to Jon Ciesla from comment #14) > I assume spot has OKd this? Yes, via email: "I'm fine with that. ~tom" -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=uQS09Fnm10&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 956304] Review Request: fts - File Transfer Service V3
https://bugzilla.redhat.com/show_bug.cgi?id=956304
--- Comment #9 from Dominik 'Rathann' Mierzejewski ---
Please record the changes you make between each update you post here in the
%changelog section of the package.
I've also just noticed that the code is built with non-standard CFLAGS. -O3
overrides -O2. I think you should use
-D CMAKE_BUILD_TYPE=RelWithDebInfo instead of Release
There's no need to call /sbin/ldconfig in any %post/%postun scriptlets except
for -libs subpackage.
%defattr(-,root,root,-) is only necessary for EPEL5 packages. It's best to add
it in el5 branch only and keep the main spec file clutter-free.
The same goes for %clean section and rm -rf %{buildroot} at the beginning of
%install.
Likewise, BuildRoot: tag is not necessary (only on EPEL5).
Similarly, per https://fedoraproject.org/wiki/Packaging:Python , defining
%python_sitelib and %python_sitearch is necessary only on EPEL5. Moreover,
you're not using %python_sitelib anywhere in the spec.
You can drop %attr(0755,root,root) and %attr(0644,root,root) from -server
subpackage files unless the installed files have different access rights.
%files python
%defattr(-,root,root,-)
%dir %attr(0755,fts3,root) %{python_sitearch}/fts
Please explain the need for python-C glue libraries to be owned by non-root
user.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=bWUV5xEHx5&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 849496] Review Request: webbit - Event-based WebSocket and HTTP server for Java
https://bugzilla.redhat.com/show_bug.cgi?id=849496 Dan Callaghan changed: What|Removed |Added Flags|needinfo?(dcallagh@redhat.c | |om) | --- Comment #2 from Dan Callaghan --- Created attachment 761917 --> https://bugzilla.redhat.com/attachment.cgi?id=761917&action=edit rawhide build log for webbit-0.4.15-1 with test failure I've updated the package: http://fedorapeople.org/~dcallagh/webbit/webbit.spec http://fedorapeople.org/~dcallagh/webbit/webbit-0.4.15-1.fc18.src.rpm I believe it meets all guidelines now, however the build is failing in Rawhide for me because of a test failure. It seems to be related to the newer netty version in F19/Rawhide (I don't see the test failure in F18). If anyone has any ideas what's going wrong here I'd appreciate some help... -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ksOglcQp7D&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 974721] Review Request: ghc-maccatcher - Obtain the host MAC address on *NIX and Windows
https://bugzilla.redhat.com/show_bug.cgi?id=974721 Jens Petersen changed: What|Removed |Added Whiteboard||Ready -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=p6KV2VwXCr&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 838780] Review Request: ghc-shakespeare-text - Interpolation with quasi-quotation
https://bugzilla.redhat.com/show_bug.cgi?id=838780 --- Comment #6 from Jens Petersen --- Any change you could update this? (latest release is now 1.0.0.5 btw.) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=iWmnZugvSj&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 972719] Review Request: nicstat - prints out network statistics for all network interface
https://bugzilla.redhat.com/show_bug.cgi?id=972719
Douglas Schilling Landgraf changed:
What|Removed |Added
Status|ASSIGNED|NEW
Flags||fedora-review+
--- Comment #12 from Douglas Schilling Landgraf ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"Unknown or generated". 3 files have unknown license. Detailed output of
licensecheck in /home/fedora/972719-nicstat/licensecheck.txt
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[-]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 20480 bytes in 3 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Bui
[Bug 838780] Review Request: ghc-shakespeare-text - Interpolation with quasi-quotation
https://bugzilla.redhat.com/show_bug.cgi?id=838780 --- Comment #7 from Ben Boeckel --- Spec URL: http://benboeckel.net/packaging/ghc-shakespeare-text/ghc-shakespeare-text.spec SRPM URL: http://benboeckel.net/packaging/ghc-shakespeare-text/ghc-shakespeare-text-1.0.0.5-1.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UjeC3XsXFO&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 974889] New: Review Request: rubygem-mysql2 - A simple, fast Mysql library for Ruby, binding to libmysql
https://bugzilla.redhat.com/show_bug.cgi?id=974889 Bug ID: 974889 Summary: Review Request: rubygem-mysql2 - A simple, fast Mysql library for Ruby, binding to libmysql Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: acher...@mit.edu QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://web.mit.edu/achernya/www/fedora/rubygem-mysql2.spec SRPM URL: http://web.mit.edu/achernya/www/fedora/rubygem-mysql2-0.3.11-1.fc19.src.rpm Description: The Mysql2 gem is meant to serve the extremely common use-case of connecting, querying and iterating on results. Some database libraries out there serve as direct 1:1 mappings of the already complex C API\'s available. This one is not. Fedora Account System Username: achernya Note that this package upload will fix #787887, reducing the number of unpackaged gems that need to be installed to run rails. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1GlmJnthBc&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911069] Review Request: nodejs-stack-trace - Node.js module to get v8 stack traces as an array of CallSite objects
https://bugzilla.redhat.com/show_bug.cgi?id=911069 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||nodejs-stack-trace-0.0.6-3. ||fc19 Resolution|--- |ERRATA Last Closed||2013-06-17 00:32:11 --- Comment #10 from Fedora Update System --- nodejs-stack-trace-0.0.6-3.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xnZhrrwYft&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910159] Review Request: nodejs-jscoverage - A JavaScript coverage tool for Node.js and browser development
https://bugzilla.redhat.com/show_bug.cgi?id=910159 Fedora Update System changed: What|Removed |Added Fixed In Version||nodejs-jscoverage-0.3.7-4.f ||c19 --- Comment #15 from Fedora Update System --- nodejs-jscoverage-0.3.7-4.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vT6GcF7ZPW&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 910154] Review Request: buddycloud-http-api - The buddycloud HTTP API service for buddycloud-server
https://bugzilla.redhat.com/show_bug.cgi?id=910154 Bug 910154 depends on bug 969827, which changed state. Bug 969827 Summary: Review Request: nodejs-pubcontrol - HTTP Extensible Pubsub Control Protocol (EPCP) library for Node.js https://bugzilla.redhat.com/show_bug.cgi?id=969827 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DeN6uPk12r&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911060] Review Request: nodejs-winston - A multi-transport async logging library for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=911060 Bug 911060 depends on bug 911069, which changed state. Bug 911069 Summary: Review Request: nodejs-stack-trace - Node.js module to get v8 stack traces as an array of CallSite objects https://bugzilla.redhat.com/show_bug.cgi?id=911069 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=93dmudJP6O&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 968600] Review Request: nodejs-estraverse - ECMAScript JS AST traversal functions
https://bugzilla.redhat.com/show_bug.cgi?id=968600 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||nodejs-estraverse-1.1.1-1.f ||c19 Resolution|--- |ERRATA Last Closed||2013-06-17 00:33:09 --- Comment #8 from Fedora Update System --- nodejs-estraverse-1.1.1-1.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8EH0cIb73m&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 968598] Review Request: nodejs-escodegen - ECMAScript code generator
https://bugzilla.redhat.com/show_bug.cgi?id=968598 Bug 968598 depends on bug 968600, which changed state. Bug 968600 Summary: Review Request: nodejs-estraverse - ECMAScript JS AST traversal functions https://bugzilla.redhat.com/show_bug.cgi?id=968600 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hE7FpOyHEo&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 912110] Review Request: nodejs-watchit - A sensible wrapper around fs.watch for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=912110 Fedora Update System changed: What|Removed |Added Fixed In Version||nodejs-watchit-0.0.4-4.fc19 --- Comment #11 from Fedora Update System --- nodejs-watchit-0.0.4-4.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=OFxMPgtjbB&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
