[Bug 1222484] Review Request: rhythmbox-ampache - Ampache plugin for Rhythmbox

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1222484



--- Comment #8 from Pete Walter  ---
Yes, I would say so.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1241088] Review Request: python-oslo-reports - Oslo reports library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1241088



--- Comment #7 from Lukas Bezdicka  ---
Spec URL: https://fedorapeople.org/~social/python-oslo-reports.spec
SRPM URL:
https://fedorapeople.org/~social/python-oslo-reports-0.5.0-1.fc22.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 166515] Review Request: pbzip2 : parallel version of bzip2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=166515

Adam Tkac  changed:

   What|Removed |Added

 CC||von...@gmail.com



--- Comment #21 from Adam Tkac  ---
Package Change Request
==
Package Name: pbzip2
New Branches: epel7
Owners: atkac jeffg

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 166515] Review Request: pbzip2 : parallel version of bzip2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=166515

Adam Tkac  changed:

   What|Removed |Added

  Flags||fedora-cvs?



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1222484] Review Request: rhythmbox-ampache - Ampache plugin for Rhythmbox

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1222484



--- Comment #5 from Juan Orti  ---
(In reply to Pete Walter from comment #4)
> (In reply to Juan Orti from comment #3)
> > (In reply to Pete Walter from comment #2)
> > > 2) you install files to %{_libdir}/rhythmbox/plugins/ampache, yet the
> > > package is marked as noarch. noarch packages cannot include files under
> > > _libdir, because those are architecture dependent.
> > 
> > rhythmbox loads its plugins from there. The main package also places there
> > other python plugins like soundcloud, sendto, replaygain, rbzeitgeist, rb,
> > python-console.
> 
> Right, the issue is that on x86_64, _libdir expands to /usr/lib64, but on
> i686, it expands to /usr/lib. If you mark the package as noarch it needs to
> work on all architectures. In this case, it can't work because of the lib64
> vs lib mismatch.

I don't see the problem.

On i686, rhythmbox will use the folder /usr/lib/rhythmbox/plugins, so this
plugin must be installed there.
On x86_64 it will use /usr/lib64/rhythmbox/plugins, so everything works,
doesn't it?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1262807] New: Review Request: php-dmitry-php-sql-parser - A validating SQL lexer and parser with a focus on MySQL dialect

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1262807

Bug ID: 1262807
   Summary: Review Request: php-dmitry-php-sql-parser - A
validating SQL lexer and parser with a focus on MySQL
dialect
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: fed...@famillecollet.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://raw.githubusercontent.com/remicollet/remirepo/fcb77b1b636d2267d260e0ed97d2810f5ca50974/php/php-dmitry-php-sql-parser/php-dmitry-php-sql-parser.spec
SRPM URL: 
Description: 
A validating SQL lexer and parser with a focus on MySQL dialect.

This library was originally developed for phpMyAdmin during
the Google Summer of Code 2015.

To use this library, you just have to add, in your project:
  require_once '/usr/share/php/SqlParser/autoload.php';


Fedora Account System Username: remi

--
As usually, I will clean the old EL-5 stuff after import.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1222484] Review Request: rhythmbox-ampache - Ampache plugin for Rhythmbox

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1222484



--- Comment #6 from Pete Walter  ---
No, it expands _libdir during build time and depending on which builder it
happened to be built on, the final rpm is going to have either
/usr/lib/rhythmbox/plugins or /usr/lib64/rhythmbox/plugins hardcoded in it.

If you have a noarch package that installs the plugin to
/usr/lib/rhythmbox/plugins but you install it on x86_64 where rhythmbox only
searches /usr/lib64/rhythmbox/plugins, it just won't load.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1241088] Review Request: python-oslo-reports - Oslo reports library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1241088



--- Comment #8 from Lukas Bezdicka  ---
SRPM URL: https://fedorapeople.org/~social/python-oslo-reports-0.5.0-1.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1262807] Review Request: php-dmitry-php-sql-parser - A validating SQL lexer and parser with a focus on MySQL dialect

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1262807

Remi Collet  changed:

   What|Removed |Added

  Alias||dmitry-php/sql-parser



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1222484] Review Request: rhythmbox-ampache - Ampache plugin for Rhythmbox

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1222484



--- Comment #7 from Juan Orti  ---
(In reply to Pete Walter from comment #6)
> No, it expands _libdir during build time and depending on which builder it
> happened to be built on, the final rpm is going to have either
> /usr/lib/rhythmbox/plugins or /usr/lib64/rhythmbox/plugins hardcoded in it.
> 
> If you have a noarch package that installs the plugin to
> /usr/lib/rhythmbox/plugins but you install it on x86_64 where rhythmbox only
> searches /usr/lib64/rhythmbox/plugins, it just won't load.

Thanks for the explanation, now I got it.
So, I guess I should make the package arched to avoid this problem, right?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 490872] Review Request: jnettop - Network traffic tracker

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=490872

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1262807] Review Request: php-udan11-sql-parser - A validating SQL lexer and parser with a focus on MySQL dialect

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1262807

Remi Collet  changed:

   What|Removed |Added

Summary|Review Request: |Review Request:
   |php-udan11-php-sql-parser - |php-udan11-sql-parser - A
   |A validating SQL lexer and  |validating SQL lexer and
   |parser with a focus on  |parser with a focus on
   |MySQL dialect   |MySQL dialect



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1262807] Review Request: php-udan11-php-sql-parser - A validating SQL lexer and parser with a focus on MySQL dialect

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1262807

Remi Collet  changed:

   What|Removed |Added

Summary|Review Request: |Review Request:
   |php-dmitry-php-sql-parser - |php-udan11-php-sql-parser -
   |A validating SQL lexer and  |A validating SQL lexer and
   |parser with a focus on  |parser with a focus on
   |MySQL dialect   |MySQL dialect
  Alias|dmitry-php/sql-parser   |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1262807] Review Request: php-udan11-php-sql-parser - A validating SQL lexer and parser with a focus on MySQL dialect

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1262807



--- Comment #2 from Remi Collet  ---
switch to correct upstream and ref. for phpMyAdmin 4.5.0RC1

Spec:
https://raw.githubusercontent.com/remicollet/remirepo/01b7aad60d43acc99da7ebbb8e329e34a54258ef/php/php-udan11-sql-parser/php-udan11-sql-parser.spec
Srpm:
http://rpms.famillecollet.com/SRPMS/php-udan11-sql-parser-0-0.2.20150820git1b2988f.remi.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 460893] Review Request: ocaml-lwt - OCaml lightweight thread library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=460893



--- Comment #9 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 166515] Review Request: pbzip2 : parallel version of bzip2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=166515



--- Comment #22 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1221781] Review Request: zipios - C++ library for reading and writing Zip files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1221781



--- Comment #17 from Richard Shaw  ---
(In reply to Raphael Groner from comment #16)
> Still open issues that need to be fixed for package approval:
> 
> [!]: Package must own all directories that it creates.
>  Note: Directories without known owners: /usr/share/doc/zipios,
>  /usr/share/cmake, /usr/share/cmake/Modules

Fixed.


> => use of %doc with relative paths and installation of files directly into
> %_pkgdocdir in the same source package is forbidden. 
> https://fedoraproject.org/wiki/Packaging:Guidelines#Documentation

This needs to be better explained in the guidelines. Many packages install
documentation as part of "make install" but %doc is still used to pull in the
usual suspects, COPYING, README, ChangeLog, etc. 

I may post a question to the development mailing list to get clarification.


> => Add to devel package Requires: cmake

Done.


> [!]: Rpmlint is run on debuginfo package(s).
>  Note: There are rpmlint messages (see attachment).
> => Please fix.
> [!]: Rpmlint is run on all installed packages.
>  Note: There are rpmlint messages (see attachment).
> => Please fix.
> 
> You must fix at least the errors marked with "E".
> 
> zipios-doc.noarch: E: devel-dependency zipios-devel
> => Please fix.

I think this one can safely be ignored. The -doc package only contains
documentation relevant to development, so it is actually a devel package, but
rpmlint doesn't have a way of knowing this.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 460893] Review Request: ocaml-lwt - OCaml lightweight thread library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=460893

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1221781] Review Request: zipios - C++ library for reading and writing Zip files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1221781

Raphael Groner  changed:

   What|Removed |Added

  Flags||needinfo?(hobbes1069@gmail.
   ||com)



--- Comment #18 from Raphael Groner  ---
(In reply to Richard Shaw from comment #17)
…
> > => use of %doc with relative paths and installation of files directly into
> > %_pkgdocdir in the same source package is forbidden. 
> > https://fedoraproject.org/wiki/Packaging:Guidelines#Documentation
> 
> This needs to be better explained in the guidelines. Many packages install
> documentation as part of "make install" but %doc is still used to pull in
> the usual suspects, COPYING, README, ChangeLog, etc. 
> 
> I may post a question to the development mailing list to get clarification.

You can not use %doc here, either ask upstream to enhance the Makefile or use
install -p commands in spec file.

…
> > zipios-doc.noarch: E: devel-dependency zipios-devel
> > => Please fix.
> 
> I think this one can safely be ignored. The -doc package only contains
> documentation relevant to development, so it is actually a devel package,
> but rpmlint doesn't have a way of knowing this.

Please merge the doc package into devel. I do not see any reason why it's to be
separate when there's the devel intention only.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1245932] Review Request: shairplay - Apple airplay and raop protocol server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1245932

Tom "spot" Callaway  changed:

   What|Removed |Added

 CC||tcall...@redhat.com
 Blocks|182235 (FE-Legal)   |



--- Comment #8 from Tom "spot" Callaway  ---
Legal review concluded that there are no issues with this package (and its
components). Lifting FE-Legal.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=182235
[Bug 182235] Fedora Legal Tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=974725

Ben Boeckel  changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #20 from Ben Boeckel  ---
Oops. I wonder if the glob messed from the upload script or something?

New Package SCM Request
===
Package Name: ghc-pretty-show
Short Description: Tools for working with derived Show instances and generic
inspection of values
Upstream URL: https://hackage.haskell.org/package/pretty-show
Owners: mathstuf
Branches: devel
InitialCC: haskell-devel

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 490872] Review Request: jnettop - Network traffic tracker

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=490872



--- Comment #16 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1262807] Review Request: php-udan11-sql-parser - A validating SQL lexer and parser with a focus on MySQL dialect

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1262807

Remi Collet  changed:

   What|Removed |Added

  Alias|udan11/php-sql-parser   |udan11/sql-parser



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1262807] Review Request: php-udan11-php-sql-parser - A validating SQL lexer and parser with a focus on MySQL dialect

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1262807

Remi Collet  changed:

   What|Removed |Added

  Alias||udan11/php-sql-parser



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1262807] Review Request: php-dmitry-php-sql-parser - A validating SQL lexer and parser with a focus on MySQL dialect

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1262807



--- Comment #1 from Remi Collet  ---
Probably have to wait for upstream clarification
https://lists.phpmyadmin.net/pipermail/developers/2015-September/019116.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 241486] Review Request: ocaml-curl - OCaml Curl library (ocurl)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=241486

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 166515] Review Request: pbzip2 : parallel version of bzip2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=166515

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 241486] Review Request: ocaml-curl - OCaml Curl library (ocurl)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=241486



--- Comment #14 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1262872] New: Review Request: perl-TeX-Encode - Encoding to LaTeX escapes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1262872

Bug ID: 1262872
   Summary: Review Request: perl-TeX-Encode - Encoding to LaTeX
escapes
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: tcall...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://spot.fedorapeople.org/perl-TeX-Encode.spec
SRPM URL: https://spot.fedorapeople.org/perl-TeX-Encode-1.3-1.fc23.src.rpm
Description: 
This module provides encoding to LaTeX escapes from utf8 using mapping tables
in Pod::LaTeX and HTML::Entities. This covers only a subset of the Unicode
character table (undef warnings will occur for non-mapped chars).

Mileage will vary when decoding (converting LaTeX to utf8), as LaTeX is in
essence a programming language, and this module does not implement LaTeX.

Fedora Account System Username: spot
Koji Rawhide Scratch Build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=11080626

Note: This package is needed to resolve broken dependencies in the new TeXlive
bundle in rawhide.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=974725



--- Comment #21 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1221781] Review Request: zipios - C++ library for reading and writing Zip files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1221781



--- Comment #19 from Raphael Groner  ---
For more details about documentation, see
https://fedorahosted.org/fpc/ticket/338

Also, you could make devel depend on doc subpackage as an alternative to
include documentation directly into devel, but not vice versa.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1258874] Review Request: libmaxminddb - C library for the MaxMind DB file format

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1258874



--- Comment #16 from Christopher Meng  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated




= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (3 clause)", "GPL (v2 or later)", "Unknown or generated".
 35 files have unknown license. Detailed output of licensecheck:

BSD (3 clause)
--
libmaxminddb-1.1.1/src/maxminddb-compat-util.h

GPL (v2 or later)
-
libmaxminddb-1.1.1/ltmain.sh

Unknown or generated

libmaxminddb-1.1.1/bin/mmdblookup.c
libmaxminddb-1.1.1/include/maxminddb.h
libmaxminddb-1.1.1/projects/VS12/maxminddb_config.h
libmaxminddb-1.1.1/src/maxminddb.c
libmaxminddb-1.1.1/t/bad_pointers_t.c
libmaxminddb-1.1.1/t/basic_lookup_t.c
libmaxminddb-1.1.1/t/compile_c++_t.pl
libmaxminddb-1.1.1/t/data_entry_list_t.c
libmaxminddb-1.1.1/t/data_types_t.c
libmaxminddb-1.1.1/t/dump_t.c
libmaxminddb-1.1.1/t/get_value_pointer_bug_t.c
libmaxminddb-1.1.1/t/get_value_t.c
libmaxminddb-1.1.1/t/ipv4_start_cache_t.c
libmaxminddb-1.1.1/t/ipv6_lookup_in_ipv4_t.c
libmaxminddb-1.1.1/t/libtap/t/cmp_mem.c
libmaxminddb-1.1.1/t/libtap/t/cmpok.c
libmaxminddb-1.1.1/t/libtap/t/diesok.c
libmaxminddb-1.1.1/t/libtap/t/is.c
libmaxminddb-1.1.1/t/libtap/t/like.c
libmaxminddb-1.1.1/t/libtap/t/notediag.c
libmaxminddb-1.1.1/t/libtap/t/simple.c
libmaxminddb-1.1.1/t/libtap/t/skip.c
libmaxminddb-1.1.1/t/libtap/t/synopsis.c
libmaxminddb-1.1.1/t/libtap/t/todo.c
libmaxminddb-1.1.1/t/libtap/tap.c
libmaxminddb-1.1.1/t/libtap/tap.h
libmaxminddb-1.1.1/t/maxmind-db/test-data/write-test-data.pl
libmaxminddb-1.1.1/t/maxminddb_test_helper.c
libmaxminddb-1.1.1/t/maxminddb_test_helper.h
libmaxminddb-1.1.1/t/metadata_t.c
libmaxminddb-1.1.1/t/mmdblookup_t.pl
libmaxminddb-1.1.1/t/no_map_get_value_t.c
libmaxminddb-1.1.1/t/read_node_t.c
libmaxminddb-1.1.1/t/threads_t.c
libmaxminddb-1.1.1/t/version_t.c

[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in 

[Bug 1261042] Review Request: python-django-babel - Utilities for using Babel in Django

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1261042



--- Comment #8 from Fedora Update System  ---
python-django-babel-0.4.0-2.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2015-15838

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=974725

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1261042] Review Request: python-django-babel - Utilities for using Babel in Django

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1261042

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1255973] Review Request: libndn-cxx - C++ library, implementing Named Data Networking (NDN) primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1255973



--- Comment #8 from Susmit  ---
Addressing the comments.

http://www.cs.colostate.edu/~susmit/ndn/ndn-cxx-0.3.3-1.fc22.src.rpm
http://www.cs.colostate.edu/~susmit/ndn/libndn-cxx.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1261042] Review Request: python-django-babel - Utilities for using Babel in Django

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1261042



--- Comment #6 from Fedora Update System  ---
python-django-babel-0.4.0-2.el7 has been submitted as an update to Fedora EPEL
7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8075

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1261042] Review Request: python-django-babel - Utilities for using Babel in Django

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1261042



--- Comment #7 from Fedora Update System  ---
python-django-babel-0.4.0-2.fc22 has been submitted as an update to Fedora 22.
https://bodhi.fedoraproject.org/updates/FEDORA-2015-15837

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1262807] Review Request: php-udan11-sql-parser - A validating SQL lexer and parser with a focus on MySQL dialect

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1262807



--- Comment #3 from Remi Collet  ---
FYI
* rev 1b2988f is the one bundled in phpMyAdmin 4.5.0RC1.
* https://github.com/phpmyadmin/phpmyadmin/pull/11481 is merged
* change in phpMyAdmin specfile
https://github.com/remicollet/remirepo/commit/225596e25c4739d015478cd2b2d6dad537b3a8d8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1243550] Review Request: openstack-aodh - OpenStack Telemetry Alarming

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1243550



--- Comment #6 from Pradeep Kilambi  ---
Thanks! addressed your comments, New spec and src are here:

Spec URL: https://pkilambi.fedorapeople.org/openstack-aodh/openstack-aodh.spec
SRPM URL:
https://pkilambi.fedorapeople.org/openstack-aodh/openstack-aodh-1.0.0-1.fc22.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1250884] Review Request: future - Easy, clean, reliable Python 2/3 compatibility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1250884

Susmit  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+
   |needinfo?(thinklinux.ssh@gm |
   |ail.com)|



--- Comment #5 from Susmit  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


= MUST items =

[x]: The package must be named according to the Package Naming Guidelines .
[x]: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption..
[x]: The package must meet the Packaging Guidelines .
[x]: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines .
[x]: The License field in the package spec file must match the actual
license.
[x]: The spec file must be written in American English.
[x]: The spec file for the package MUST be legible.
[x]: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use sha256sum for this task as it
is used by the sources file once imported into git. If no upstream URL can be
specified for this package, please see the Source URL Guidelines for how to
deal with this.
[x]: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
[x]: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
[x]: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[x]: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[-]: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
[x]: Packages must NOT bundle copies of system libraries.
[-]: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
[x]: A Fedora package must not list a file more than once in the spec
file's %files listings. (Notable exception: license texts in specific
situations)
[x]: Permissions on files must be set properly. Executables should be set
with executable permissions, for example.
[x]: Each package must consistently use macros.
[x]: The package must contain code, or permissible content.
[x]: Large documentation files must go in a -doc subpackage. (The
definition of large is left up to the packager's best judgement, but is not
restricted to size. Large can refer to either size or quantity).
[x]: If a package includes something as %doc, it must not affect the
runtime of the application. To summarize: If it is in %doc, the program must
run properly if it is not present.
[-]: Static libraries must be in a -static package.
[-]: Development files must be in a -devel package.
   [-]: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name}%{?_isa} =
%{version}-%{release}
[-]: Packages must NOT contain any .la libtool archives, these must be
removed in the spec if they are built.
[-]: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section.
[+]: Packages must not own files or directories already owned by other
packages.
[+]: All filenames in rpm packages must be valid UTF-8.


Python:
[+]: If you build for more than one python runtime you must use the
%python_provide macro.
[+]: Python modules must be built from source. They cannot simply drop an
egg from upstream into the proper directory. (See prebuilt binaries Guidelines
for details)
[+]: Python modules must not download any dependencies during the build
process.
[-]: When building a compat package, it must install using easy_install -m
so it won't conflict with the main package.
[-]: When building multiple versions (for a compat package) one of the
packages must contain a default 

[Bug 1250884] Review Request: future - Easy, clean, reliable Python 2/3 compatibility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1250884

Antonio Trande  changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #6 from Antonio Trande  ---
Thanks.

New Package SCM Request
===
Package Name: future
Short Description: Easy, clean, reliable Python 2/3 compatibility
Upstream URL: http://python-future.org/
Owners: sagitter
Branches: f22 f23 el6 epel7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1193986] Review Request: openstack-rally - Benchmark as a service for OpenStack

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1193986



--- Comment #16 from Steve Linabery  ---
I updated my versions of the spec and srpm to help this effort along:
https://slinabery.fedorapeople.org/openstack-rally.spec
https://slinabery.fedorapeople.org/openstack-rally-0.0.4-1.fc20.src.rpm

Haikel, I think you meant python-requests. Correct me if I'm wrong.

Victoria, I think these are the changes recommended in #14, if you agree please
update the canonical spec/srpm for this review. Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1241088] Review Request: python-oslo-reports - Oslo reports library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1241088

Haïkel Guémar  changed:

   What|Removed |Added

  Flags||needinfo?(lbezdick@redhat.c
   ||om)



--- Comment #9 from Haïkel Guémar  ---
Four issues that must be fixed:  
* missing requirements for python3, please disable python3 subpackage until
it's fixed 
%global with_python3 0  
* missing dist tag 
Release:  1%{?dist}
* Drop %{python2_sitelib} and %{python3_sitelib} from %files as they should not
be owned by python modules packages.
* It also needs a changelog entry.

These are the last mile before approval.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1255973] Review Request: libndn-cxx - C++ library, implementing Named Data Networking (NDN) primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1255973



--- Comment #9 from Antonio Trande  ---
There is a double "waf configure" command.

* Tue Sep 08 2015 Susmit Shannigrahi  - 0.3.3-1
- Use waf to install files
- Fix review comments

* Fri Aug 21 2015 Susmit Shannigrahi  - 0.3.3-0
- Update package for 0.3.3

* Thu Feb 5 2015 Susmit Shannigrahi  - 0.3.0-0
- Initial Packaging

The Release number starts with 1, not with 0.

Make a scratch build with koji to test your package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1255179] Review Request: runc - CLI for running Open Containers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1255179

Jan Chaloupka  changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #22 from Jan Chaloupka  ---
New Package SCM Request
===
Package Name: runc
Short Description: CLI for running Open Containers
Upstream URL: https://github.com/opencontainers/runc
Owners: jchaloup
Branches: f23 f22 f21 el6 epel7
InitialCC: golang-sig

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1129224] Review Request: libsearpc - A simple and easy-to-use C language RPC framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1129224

Julien Enselme  changed:

   What|Removed |Added

   Assignee|i...@cicku.me  |juj...@jujens.eu
  Flags|fedora-review?  |fedora-review+



--- Comment #15 from Julien Enselme  ---
Looks good. Approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1263008] New: Review Request: openfortivpn - Client for PPP+SSL VPN tunnel services

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1263008

Bug ID: 1263008
   Summary: Review Request: openfortivpn - Client for PPP+SSL VPN
tunnel services
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: lkund...@v3.sk
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



SPEC: http://v3.sk/~lkundrak/SPECS/openfortivpn.spec
SRPM:
http://v3.sk/~lkundrak/SRPMS/openfortivpn-1.0.1-1.20150914gitb22d9eb.fc22.src.rpm
FAS username: lkundrak

Description:

openfortivpn is a client for PPP+SSL VPN tunnel services. It spawns a pppd
process and operates the communication between the gateway and this process.

It is compatible with Fortinet VPNs.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1129224] Review Request: libsearpc - A simple and easy-to-use C language RPC framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1129224



--- Comment #17 from Christopher Meng  ---
Looks fine here.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1222484] Review Request: rhythmbox-ampache - Ampache plugin for Rhythmbox

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1222484



--- Comment #10 from Pete Walter  ---
It fails to build:

error: Empty %files file
/builddir/build/BUILD/rhythmbox-ampache-7415a69d019da8cf973cfb9e1727156ad901e7c1/debugfiles.list

Probably needs something like '%global debug_package %{nil}' to turn off
debuginfo generation now that it is no longer noarch?

http://koji.fedoraproject.org/koji/taskinfo?taskID=11085092

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1222484] Review Request: rhythmbox-ampache - Ampache plugin for Rhythmbox

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1222484

Pete Walter  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #11 from Pete Walter  ---
Anyway, you can add '%global debug_package %{nil}' to the top of the file to
fix it up to properly build before importing.

rpmlint output:

rhythmbox-ampache.x86_64: W: spelling-error %description -l en_US metadata ->
meta data, meta-data, metatarsal
rhythmbox-ampache.x86_64: E: no-binary
rhythmbox-ampache.src: W: spelling-error %description -l en_US metadata -> meta
data, meta-data, metatarsal
2 packages and 0 specfiles checked; 1 errors, 2 warnings.

fedora-review has nothing interesting to say and I won't post its output here.

Everything seems fine to me, so the package is:

APPROVED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1223990] Review Request: openssl101e - A general purpose cryptography library with TLS implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1223990



--- Comment #3 from Robert Scheck  ---
Spec URL: http://labs.linuxnetz.de/bugzilla/openssl101e.spec
SRPM URL: http://labs.linuxnetz.de/bugzilla/openssl101e-1.0.1e-3.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1258874] Review Request: libmaxminddb - C library for the MaxMind DB file format

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1258874



--- Comment #17 from Jan Včelák  ---
Thank you for the review.

> 1. I'm against that -utils subpackage, better include it in -devel. Only one
> program doesn't need to be placed into another subpackage, time to reduce
> pointless subpkgs.

I think it is useful to have the utility to query the database even if you
don't do any development. It was logical for me to put it into a subpackage. On
the other hand, the -devel subpackage has almost no dependencies, so I'm also
fine with placing the utility into the -devel subpackage.

> 2. Group:  Development/Libraries
> 
> Drop it, it doesn't matter on RHEL6, and RHEL5.10+(IIRC)

OK. I'll do that.

> 3. I'd rather put 
> 
> %doc NOTICE Changes.md
> 
> to -devel subpkg.

OK. Makes sense.

> 4. %doc NOTICE 
> 
> No, it's %license.

OK. Good catch.

> 5. Looks like some code are bundled in tests, but using git submodule is ok
> so I will ignore this.

I think this is OK. The test binaries are not installed. There is a bunch of
libtap libraries around and this one is not packaged in Fedora. And it would be
pity to remove the tests execution from the build process.

I'll post updated specs soon.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1257336] Review Request: nodejs-async-queue - Simple FIFO queue to execute async functions linear

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1257336



--- Comment #10 from Fedora Update System  ---
nodejs-async-queue-0.1.0-2.fc21 has been pushed to the Fedora 21 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1257340] Review Request: nodejs-single-line-log - Keep writing to the same line in the terminal

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1257340



--- Comment #9 from Fedora Update System  ---
nodejs-single-line-log-1.0.0-1.fc21 has been pushed to the Fedora 21 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1257302] Review Request: nodejs-module-not-found-error - Create a module not found error

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1257302



--- Comment #10 from Fedora Update System  ---
nodejs-module-not-found-error-1.0.1-1.fc21 has been pushed to the Fedora 21
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1257338] Review Request: nodejs-progress-stream - Read the progress of a stream

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1257338
Bug 1257338 depends on bug 1257342, which changed state.

Bug 1257342 Summary: Review Request: nodejs-numeral - A javascript library for 
formatting and manipulating numbers
https://bugzilla.redhat.com/show_bug.cgi?id=1257342

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |NEXTRELEASE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1257340] Review Request: nodejs-single-line-log - Keep writing to the same line in the terminal

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1257340

Fedora Update System  changed:

   What|Removed |Added

   Fixed In Version|1.0.0-1.fc23|1.0.0-1.fc21



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1257342] Review Request: nodejs-numeral - A javascript library for formatting and manipulating numbers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1257342



--- Comment #11 from Fedora Update System  ---
nodejs-numeral-1.5.3-1.fc21 has been pushed to the Fedora 21 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1257342] Review Request: nodejs-numeral - A javascript library for formatting and manipulating numbers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1257342

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||1.5.3-1.fc21
 Resolution|--- |NEXTRELEASE
Last Closed||2015-09-14 18:19:01



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1257302] Review Request: nodejs-module-not-found-error - Create a module not found error

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1257302

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||1.0.1-1.fc21
 Resolution|--- |NEXTRELEASE
Last Closed||2015-09-14 18:18:58



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1257336] Review Request: nodejs-async-queue - Simple FIFO queue to execute async functions linear

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1257336

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||0.1.0-2.fc21
 Resolution|--- |NEXTRELEASE
Last Closed||2015-09-14 18:19:14



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1129224] Review Request: libsearpc - A simple and easy-to-use C language RPC framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1129224

Nikos Roussos  changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #16 from Nikos Roussos  ---
New Package SCM Request
===
Package Name: libsearpc
Short Description: A simple and easy-to-use C language RPC framework
Upstream URL: https://github.com/haiwen/libsearpc
Owners: comzeradd
Branches: f21 f22 f23
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1245791] Review Request: python-influxdb - Python client for interacting with InfluxDB

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1245791

Haïkel Guémar  changed:

   What|Removed |Added

 Blocks||1243533
   ||(RDO-LIBERTY-REVIEWS)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1243533
[Bug 1243533] (RDO) Tracker: Review requests for new RDO Liberty packages
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1255370] Review Request: golang-github-opencontainers-specs - Open Container Specifications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1255370



--- Comment #4 from Jan Chaloupka  ---
Updated:
- changelog maintainer name (full name)
- package description create from "The 5 principles of Standard Containers"
paragraph
- ExclusiveArch and BuildRequires updated (the same way as for runc)
- %license macro introduced, %copying removed (the same way as for runc)

> > > [!]: Latest version is packaged.
> > 
> > The latest version is not always the right candidate. runc uses this commit.
> > The newer can have problems with backward compatibility. Once the newer
> > version is required, the package gets updated.
> 
> This information is not present in either .spec file.  How would someone who's
> new to co-maintaining one package or another know that upgrades to the two
> need to be coordinated?

This is driven by runc package and content of Godeps/Godeps.json file. It
contains a list of dependencies with corresponding commits. (Co)-Maintainer of
https://github.com/opencontainers/specs will not be aware of this unless he
coordinates with runc (co)-maintainer.

Spec URL:
https://jchaloup.fedorapeople.org/reviews/golang-github-opencontainers-specs/golang-github-opencontainers-specs.spec

SRPM URL:
https://jchaloup.fedorapeople.org/reviews/golang-github-opencontainers-specs/golang-github-opencontainers-specs-0-0.1.git0c505a5.fc20.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1255179] Review Request: runc - CLI for running Open Containers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1255179

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1255179] Review Request: runc - CLI for running Open Containers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1255179



--- Comment #23 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1258874] Review Request: libmaxminddb - C library for the MaxMind DB file format

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1258874

Jan Včelák  changed:

   What|Removed |Added

  Flags||needinfo?(i...@cicku.me)



--- Comment #18 from Jan Včelák  ---
Spec:
https://jvcelak.fedorapeople.org/review/libmaxminddb/1.1.1-4/libmaxminddb.spec
SRPM:
https://jvcelak.fedorapeople.org/review/libmaxminddb/1.1.1-4/libmaxminddb-1.1.1-4.fc22.src.rpm
COPR build:
https://copr.fedoraproject.org/coprs/jvcelak/libmaxminddb/build/115565/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1245791] Review Request: python-influxdb - Python client for interacting with InfluxDB

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1245791



--- Comment #1 from Pradeep Kilambi  ---
rebased to 2.9.1, please review: 

Spec URL:
https://pkilambi.fedorapeople.org/python-influxdb/python-influxdb.spec
SRPM URL:
https://pkilambi.fedorapeople.org/python-influxdb/python-influxdb-2.9.1-1.fc22.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1255179] Review Request: runc - CLI for running Open Containers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1255179



--- Comment #21 from Jan Chaloupka  ---
Thanks Nalin. %license can not be moved to the top. It must be defined after
License tag, otherwise the tag is used instead of the macro. So the best place
for it is before %files section for which it is intended.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1250887] Review Request: preprocess - A portable multi-language file Python2 preprocessor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1250887



--- Comment #3 from Antonio Trande  ---
>- What is the point of the touch invocations in %install?  If you want to
>  preserve timestamps, those should instead read like this:
>
>  touch -r bin/preprocess $i

Indeed; i have used the file already installed on buildroot.

Spec URL: https://sagitter.fedorapeople.org/preprocess/preprocess.spec
SRPM URL:
https://sagitter.fedorapeople.org/preprocess/preprocess-1.2.1-1.20150914gitb23422.fc22.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1045963] Review Request: ghc-gtk3 - Binding to the Gtk+ graphical user interface library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1045963

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||0.14.1-1.fc22
 Resolution|--- |NEXTRELEASE
Last Closed||2015-09-14 19:19:25



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1045963] Review Request: ghc-gtk3 - Binding to the Gtk+ graphical user interface library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1045963



--- Comment #27 from Fedora Update System  ---
ghc-gtk3-0.14.1-1.fc22, gtk2hs-buildtools-0.13.0.4-1.fc22 has been pushed to
the Fedora 22 stable repository. If problems still persist, please make note of
it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1231427] Review Request: COPASI - Biochemical network simulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1231427



--- Comment #27 from Fedora Update System  ---
COPASI-4.16-0.13.20150817git3bc4e9.fc22 has been pushed to the Fedora 22 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1231427] Review Request: COPASI - Biochemical network simulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1231427

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||4.16-0.13.20150817git3bc4e9
   ||.fc22
 Resolution|--- |NEXTRELEASE
Last Closed||2015-09-14 19:19:34



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1257340] Review Request: nodejs-single-line-log - Keep writing to the same line in the terminal

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1257340

Fedora Update System  changed:

   What|Removed |Added

   Fixed In Version|1.0.0-1.fc21|1.0.0-1.fc22



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1257340] Review Request: nodejs-single-line-log - Keep writing to the same line in the terminal

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1257340



--- Comment #10 from Fedora Update System  ---
nodejs-single-line-log-1.0.0-1.fc22 has been pushed to the Fedora 22 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1257342] Review Request: nodejs-numeral - A javascript library for formatting and manipulating numbers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1257342

Fedora Update System  changed:

   What|Removed |Added

   Fixed In Version|1.5.3-1.fc21|1.5.3-1.fc22



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1258405] Review Request: python-colorclass - Yet another ANSI color text library for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1258405



--- Comment #11 from Julien Enselme  ---
I don't know. I suggest that you ask on the packaging list
(packag...@lists.fedoraproject.org). I think that whoever can answer that is on
this list.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1257336] Review Request: nodejs-async-queue - Simple FIFO queue to execute async functions linear

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1257336



--- Comment #11 from Fedora Update System  ---
nodejs-async-queue-0.1.0-2.fc22 has been pushed to the Fedora 22 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1257342] Review Request: nodejs-numeral - A javascript library for formatting and manipulating numbers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1257342



--- Comment #12 from Fedora Update System  ---
nodejs-numeral-1.5.3-1.fc22 has been pushed to the Fedora 22 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1257302] Review Request: nodejs-module-not-found-error - Create a module not found error

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1257302

Fedora Update System  changed:

   What|Removed |Added

   Fixed In Version|1.0.1-1.fc21|1.0.1-1.fc22



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1257302] Review Request: nodejs-module-not-found-error - Create a module not found error

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1257302



--- Comment #11 from Fedora Update System  ---
nodejs-module-not-found-error-1.0.1-1.fc22 has been pushed to the Fedora 22
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1222484] Review Request: rhythmbox-ampache - Ampache plugin for Rhythmbox

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1222484



--- Comment #9 from Juan Orti  ---
Ok, here is the arched package. I have also used the new Python macros:

Spec URL:
https://jorti.fedorapeople.org/rhythmbox-ampache/rhythmbox-ampache.spec
SRPM URL:
https://jorti.fedorapeople.org/rhythmbox-ampache/rhythmbox-ampache-0-0.4.20150518git7415a69.fc22.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1234208] Review Request: PyPDF2 - A Pure-Python library built as a PDF toolkit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1234208



--- Comment #24 from Major Hayden  ---
(In reply to Globe Trotter from comment #23)
> Major: Would you have interest in co-maintaining pdf-stapler? It is much in
> demand on Fedora

I'm actually not a package sponsor, unfortunately.  I aspire to get into that
group one day. ;)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1258874] Review Request: libmaxminddb - C library for the MaxMind DB file format

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1258874

Christopher Meng  changed:

   What|Removed |Added

  Flags|needinfo?(i...@cicku.me)   |



--- Comment #19 from Christopher Meng  ---
PACKAGE APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1258874] Review Request: libmaxminddb - C library for the MaxMind DB file format

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1258874

Christopher Meng  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1260246] Review Request: memtailor - C++ library of special-purpose memory allocators

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1260246

Jerry James  changed:

   What|Removed |Added

  Flags||fedora-cvs?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1222484] Review Request: rhythmbox-ampache - Ampache plugin for Rhythmbox

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1222484

Juan Orti  changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #13 from Juan Orti  ---
New Package SCM Request
===
Package Name: rhythmbox-ampache
Short Description: Ampache plugin for Rhythmbox
Upstream URL: https://github.com/lotan/rhythmbox-ampache
Owners: jorti
Branches: f21 f22 f23
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1208738] Review Request: vera++ - A tool for verification, analysis and transformation of C++ source code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1208738

Taylor Braun-Jones  changed:

   What|Removed |Added

  Flags|needinfo?(taylor@braun-jone |
   |s.org)  |



--- Comment #23 from Taylor Braun-Jones  ---
Yes, leaving closed for now makes sense. My schedule has changed leaving me
with less time to work on things like this. I may get back around to this in
the future though.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1260246] Review Request: memtailor - C++ library of special-purpose memory allocators

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1260246



--- Comment #3 from Jerry James  ---
New Package SCM Request
===
Package Name: memtailor
Short Description: C++ library of special-purpose memory allocators
Upstream URL: https://github.com/broune/memtailor
Owners: jjames
Branches: f23
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1250887] Review Request: preprocess - A portable multi-language file Python2 preprocessor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1250887



--- Comment #4 from Jerry James  ---
(In reply to Antonio Trande from comment #3)
> Indeed; i have used the file already installed on buildroot.

Okay, that's good, but two of the other issues have not been addressed, namely:

- Package uses either %{buildroot} or $RPM_BUILD_ROOT
  Note: Using both %{buildroot} and $RPM_BUILD_ROOT
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros

- Note the non-executable script complaint by rpmlint.  Either the library
  file should be executable (in which case, the shebang expression should
  be #!/usr/bin/python2 for %{python2_sitelib}/preprocess.py and
  #!/usr/bin/python3 for %{python3_sitelib}/preprocess.py), or the file
  should not be executable, in which case the shebang should be removed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1251034] Review Request: php-zendframework-zendpdf - Zend Framework ZendPdf component

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1251034



--- Comment #19 from Fedora Update System  ---
php-zendframework-zendpdf-2.0.2-1.el6 has been pushed to the Fedora EPEL 6
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1252924] Review Request: php-tecnickcom-tc-lib-barcode - PHP library to generate linear and bidimensional barcodes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1252924

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|NEXTRELEASE |---
   Keywords||Reopened



--- Comment #23 from Fedora Update System  ---
php-tecnickcom-tc-lib-barcode-1.4.3-1.el6,
php-tecnickcom-tc-lib-color-1.5.2-1.el6 has been pushed to the Fedora EPEL 6
testing repository. If problems still persist, please make note of it in this
bug report.\nIf you want to test the update, you can install it with \n su -c
'yum --enablerepo=updates-testing update php-tecnickcom-tc-lib-barcode
php-tecnickcom-tc-lib-color'. You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8070

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1252924] Review Request: php-tecnickcom-tc-lib-barcode - PHP library to generate linear and bidimensional barcodes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1252924
Bug 1252924 depends on bug 1252918, which changed state.

Bug 1252918 Summary: Review Request: php-tecnickcom-tc-lib-color - PHP library 
to manipulate various color representations
https://bugzilla.redhat.com/show_bug.cgi?id=1252918

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|NEXTRELEASE |---



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1252918] Review Request: php-tecnickcom-tc-lib-color - PHP library to manipulate various color representations

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1252918

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|NEXTRELEASE |---
   Keywords||Reopened



--- Comment #22 from Fedora Update System  ---
php-tecnickcom-tc-lib-barcode-1.4.3-1.el6,
php-tecnickcom-tc-lib-color-1.5.2-1.el6 has been pushed to the Fedora EPEL 6
testing repository. If problems still persist, please make note of it in this
bug report.\nIf you want to test the update, you can install it with \n su -c
'yum --enablerepo=updates-testing update php-tecnickcom-tc-lib-barcode
php-tecnickcom-tc-lib-color'. You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8070

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1222484] Review Request: rhythmbox-ampache - Ampache plugin for Rhythmbox

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1222484



--- Comment #12 from Juan Orti  ---
Thank you.

This is the package with the debug disabled:
Spec URL:
https://jorti.fedorapeople.org/rhythmbox-ampache/rhythmbox-ampache.spec
SRPM URL:
https://jorti.fedorapeople.org/rhythmbox-ampache/rhythmbox-ampache-0-0.5.20150518git7415a69.fc22.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1260246] Review Request: memtailor - C++ library of special-purpose memory allocators

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1260246



--- Comment #2 from Jerry James  ---
Antonio, thank you very much for the review!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1251034] Review Request: php-zendframework-zendpdf - Zend Framework ZendPdf component

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1251034

Fedora Update System  changed:

   What|Removed |Added

   Fixed In Version|2.0.2-1.fc21|2.0.2-1.el6



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1251034] Review Request: php-zendframework-zendpdf - Zend Framework ZendPdf component

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1251034

Fedora Update System  changed:

   What|Removed |Added

   Fixed In Version|2.0.2-1.el6 |2.0.2-1.el7



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review