[Bug 496777] Review Request: perl-MooseX-MethodAttributes - Introspect your code attributes
https://bugzilla.redhat.com/show_bug.cgi?id=496777 --- Comment #10 from Fedora Update System --- perl-MooseX-MethodAttributes-0.24-2.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 496777] Review Request: perl-MooseX-MethodAttributes - Introspect your code attributes
https://bugzilla.redhat.com/show_bug.cgi?id=496777 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed|2009-04-24 02:26:07 |2016-08-31 09:19:56 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 485001] Review Request: perl-MooseX-Emulate-Class-Accessor-Fast - Emulate Class::Accessor:: Fast behavior using Moose attributes
https://bugzilla.redhat.com/show_bug.cgi?id=485001 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed|2009-02-14 13:45:11 |2016-08-31 09:19:42 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 485001] Review Request: perl-MooseX-Emulate-Class-Accessor-Fast - Emulate Class::Accessor:: Fast behavior using Moose attributes
https://bugzilla.redhat.com/show_bug.cgi?id=485001 --- Comment #12 from Fedora Update System --- perl-MooseX-Emulate-Class-Accessor-Fast-0.00903-4.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1352408] Review Request: lasem - A library for rendering SVG and Mathml, implementing a DOM like API
https://bugzilla.redhat.com/show_bug.cgi?id=1352408 --- Comment #15 from Fedora Update System --- lasem-0.4.3-4.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-4060940fc7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1352408] Review Request: lasem - A library for rendering SVG and Mathml, implementing a DOM like API
https://bugzilla.redhat.com/show_bug.cgi?id=1352408 --- Comment #14 from Fedora Update System --- lasem-0.4.3-4.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-406d38c5ef -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1227972] Review Request: SDL_mng - Library to load MNG files for SDL
https://bugzilla.redhat.com/show_bug.cgi?id=1227972 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #18 from Fedora Update System --- SDL_mng-0.2.6-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-fed1426efc -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1367598] Review Request: gap-pkg-guava - Computing with error-correcting codes
https://bugzilla.redhat.com/show_bug.cgi?id=1367598 --- Comment #10 from Fedora Update System --- gap-pkg-guava-3.13.1-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-2547786f05 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1369374] Review Request: python2-faulthandler - Display the Python traceback on a crash
https://bugzilla.redhat.com/show_bug.cgi?id=1369374 --- Comment #12 from Fedora Update System --- python2-faulthandler-2.4-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-aba642f93a -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1350143] Review Request: fmt - Small, safe and fast formating library for C++
https://bugzilla.redhat.com/show_bug.cgi?id=1350143 --- Comment #28 from Fedora Update System --- fmt-3.0.0-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-7ef9eb36f2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1350143] Review Request: fmt - Small, safe and fast formating library for C++
https://bugzilla.redhat.com/show_bug.cgi?id=1350143 --- Comment #29 from Fedora Update System --- fmt-3.0.0-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-70fa132149 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1302876] Review Request: clatd - CLAT / SIIT-DC Edge Relay implementation for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1302876 --- Comment #23 from Fedora Update System --- clatd-1.4-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-01a13b182f -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1302876] Review Request: clatd - CLAT / SIIT-DC Edge Relay implementation for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1302876 --- Comment #22 from Fedora Update System --- clatd-1.4-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-6a8f0b2dcf -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1367033] Review Request: dumb-init - entrypoint wrapper for docker that pass signal and handle zombies
https://bugzilla.redhat.com/show_bug.cgi?id=1367033 --- Comment #36 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/dumb-init -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1369374] Review Request: python2-faulthandler - Display the Python traceback on a crash
https://bugzilla.redhat.com/show_bug.cgi?id=1369374 --- Comment #11 from Fedora Update System --- python2-faulthandler-2.4-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-6cf8254448 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1370874] Review Request: gap-pkg-automata - Finite automata algorithms
https://bugzilla.redhat.com/show_bug.cgi?id=1370874 --- Comment #6 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/gap-pkg-automata -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1371635] Review Request: adobe-source-serif-pro-fonts - A set of OpenType fonts designed to complement Source Sans Pro
https://bugzilla.redhat.com/show_bug.cgi?id=1371635 --- Comment #3 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/adobe-source-serif-pro-fonts -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1366839] Review Request: openhft-affinity - Java Thread Affinity library
https://bugzilla.redhat.com/show_bug.cgi?id=1366839 --- Comment #5 from gil cattaneo --- @Ben, need something else to finish the review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1367033] Review Request: dumb-init - entrypoint wrapper for docker that pass signal and handle zombies
https://bugzilla.redhat.com/show_bug.cgi?id=1367033
--- Comment #35 from Muayyad Alsadi ---
I was able to produce an rpm with %check that validates the build
1. after applying the merged upstream patch (not included in 1.1.3 release)
2. adding the following BR (to make it work for epel too)
%if 0%{?rhel}
BuildRequires: python34, python34-pytest python34-mock
%else
BuildRequires: python3, python3-pytest python3-mock
%endif
I've built it on copr
so it's your call now
1. we can go with the above spec which does not validate the build with %check
2. apply the merged upstream patch that fix the tests and ship
here is the new .src.rpm with tests included
https://copr-be.cloud.fedoraproject.org/results/alsadi/dumb-init/fedora-24-x86_64/00448255-dumb-init/dumb-init-1.1.3-9.fc24.src.rpm
the upstream patch
https://gist.githubusercontent.com/muayyad-alsadi/ca4153efc636f761e26b76a186832077/raw/a3de08469e3070a079ee2db0e8c26d4406d94740/dumb-init.fix-test.patch
the updated spec that includes the patch and the
https://gist.githubusercontent.com/muayyad-alsadi/ca4153efc636f761e26b76a186832077/raw/a3de08469e3070a079ee2db0e8c26d4406d94740/dumb-init.spec
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1348997] Review Request: backports.shutil_get_terminal_size - A backport of the get_terminal_size function
https://bugzilla.redhat.com/show_bug.cgi?id=1348997 --- Comment #19 from Fedora Update System --- python-backports-shutil_get_terminal_size-1.0.0-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1360365] Review Request: python-pytest-mock - Thin-wrapper around the mock package for easier use with py.test
https://bugzilla.redhat.com/show_bug.cgi?id=1360365
Zbigniew Jędrzejewski-Szmek changed:
What|Removed |Added
Status|ASSIGNED|POST
Flags|fedora-review? |fedora-review+
--- Comment #3 from Zbigniew Jędrzejewski-Szmek ---
> %{sum} macro is not necessary, you can write Summary: normally first time,
> and then use Summary: %{summary} for the subsequent ones.
> You don't need to actually delete .egg-info.
+ package name is OK
+ license is acceptable (MIT)
+ license is specified correctly
+ standard python packaging is used
+ python_provide is used
+ no scriptlets present or necessary
+ builds and installs OK
+ P/R/BR look OK
Package is APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1367033] Review Request: dumb-init - entrypoint wrapper for docker that pass signal and handle zombies
https://bugzilla.redhat.com/show_bug.cgi?id=1367033 --- Comment #34 from Muayyad Alsadi --- @dmitrij here is the latest spec url (which you can wget/curl) curl -L https://raw.githubusercontent.com/muayyad-alsadi/dumb-init/663474f99fa16106a8ba0f5ee261df8636b48fda/dumb-init.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1367033] Review Request: dumb-init - entrypoint wrapper for docker that pass signal and handle zombies
https://bugzilla.redhat.com/show_bug.cgi?id=1367033 --- Comment #33 from Muayyad Alsadi --- the tests can be done on both python2 or python3 for python2 making BR python-mock and python-test would work for both fedora and EPEL but for python3 in fedora they are called python3-test, python3-mock while on EPEL they are called python34-test, python34-mock I'll play it safe and go with python2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1370868] Review Request: wildfly-arquillian - The Wildfly Arquillian Adaptor
https://bugzilla.redhat.com/show_bug.cgi?id=1370868 --- Comment #4 from gil cattaneo --- Spec URL: https://gil.fedorapeople.org/wildfly-arquillian.spec SRPM URL: https://gil.fedorapeople.org/wildfly-arquillian-1.0.2-2.fc24.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1370868] Review Request: wildfly-arquillian - The Wildfly Arquillian Adaptor
https://bugzilla.redhat.com/show_bug.cgi?id=1370868 --- Comment #3 from gil cattaneo --- (In reply to Jerry James from comment #2) > Issues > == > 1. The spec file URL in the bug differs from the spec file inside the srpm. >See the diff below. Done > 2. Some files in this package have an ASL 2.0 license notice, and some have >an LGPLv2+ license notice. (For an example of the latter, see >common/src/main/java/org/jboss/as/arquillian/api/ServerSetup.java.) I > think >the license should be "ASL 2.0 and LGPLv2+", with a note in the spec file >describing the license breakdown. Done > 3. SHOULD: this is not the latest version. Versions 1.1.0 and 2.0.0 have > been >released. I am not interested for now to upgrade the package to 2.0.0.Final. This release id used in wildfly 10.1.0.Final > 4. SHOULD: package includes a non-upstream license file. Upstream already fixed the problem with https://github.com/wildfly/wildfly-arquillian/pull/60 but the patch available is not applicable for this release -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1369708] Review Request: tpm2-tss - TPM2.0 Software Stack
https://bugzilla.redhat.com/show_bug.cgi?id=1369708 --- Comment #5 from Igor Gnatenko --- (In reply to yunying.sun from comment #4) > the configure error "cannot run C compiled programs" is there, seems because > "%configure" adds an extra flag "-Werror" to CFLAGS, which turns some config > warnings to errors. With "./configure", koji build pass. > > @Igor, is it acceptable to use: > CONFIG_SITE=$(pwd)/lib/default_config.site ./configure > #%configure > > instead of: > export CONFIG_SITE=$(pwd)/lib/default_config.site > %configure > > I've verified that koji build pass if comment off "%configure". > updated SPEC: https://github.com/yunyings/share/blob/master/tpm2-tss.spec > koji rawhide build: > http://koji.fedoraproject.org/koji/taskinfo?taskID=15448486 not really, because then it (I suppose) will ignore Fedora CFLAGS/LDFLAGS/CXXFLAGS/ From your koji build it looks like %configure was executed and it worked. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1367033] Review Request: dumb-init - entrypoint wrapper for docker that pass signal and handle zombies
https://bugzilla.redhat.com/show_bug.cgi?id=1367033 Dmitrij S. Kryzhevich changed: What|Removed |Added CC||kryz...@ispms.ru --- Comment #32 from Dmitrij S. Kryzhevich --- Please place spec file in a place anyone could wget it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1369708] Review Request: tpm2-tss - TPM2.0 Software Stack
https://bugzilla.redhat.com/show_bug.cgi?id=1369708 --- Comment #4 from yunying@intel.com --- the configure error "cannot run C compiled programs" is there, seems because "%configure" adds an extra flag "-Werror" to CFLAGS, which turns some config warnings to errors. With "./configure", koji build pass. @Igor, is it acceptable to use: CONFIG_SITE=$(pwd)/lib/default_config.site ./configure #%configure instead of: export CONFIG_SITE=$(pwd)/lib/default_config.site %configure I've verified that koji build pass if comment off "%configure". updated SPEC: https://github.com/yunyings/share/blob/master/tpm2-tss.spec koji rawhide build: http://koji.fedoraproject.org/koji/taskinfo?taskID=15448486 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1349578] Review Request: python-pifpaf - Suite of fixtures to manage daemons
https://bugzilla.redhat.com/show_bug.cgi?id=1349578
Haïkel Guémar changed:
What|Removed |Added
Status|ASSIGNED|POST
CC||pkila...@redhat.com
Flags|needinfo?(karlthered@gmail. |needinfo?(pkilambi@redhat.c
|com)|om)
--- Comment #4 from Haïkel Guémar ---
One small glitch in Source0 to fix before import:
Source0:
https://pypi.io/packages/source/p/%{pypi_name}/%{pypi_name}-%{version}.tar.gz
This package is hereby approved.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "*No copyright* Apache (v2.0)". 8 files
have unknown license. Detailed output of licensecheck in
/home/haikel/1349578-python-pifpaf/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[!]: Sources can be downloaded from URI in Source: tag
Note: Could not download Source0:
https://pypi.io/packages/source/p/pifpaf-0.12.0.tar.gz
See: http://fedoraproject.org/wiki/Packaging:Guidelines#Tags
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[Bug 1348202] Review Request: rubygem-pcaprub - libpcap bindings for ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1348202 Germano Massullo changed: What|Removed |Added Depends On||1371845 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1371845 [Bug 1371845] spec file shortcomings -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1348202] Review Request: rubygem-pcaprub - libpcap bindings for ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1348202 --- Comment #8 from Vít Ondruch --- BTW, for the EPEL7, you probably want to follow these guidelines [1], which are referenced on the top of regular Fedora packaging guidelines. [1] https://fedoraproject.org/w/index.php?title=Packaging:Ruby&oldid=363159 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1348202] Review Request: rubygem-pcaprub - libpcap bindings for ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1348202 Vít Ondruch changed: What|Removed |Added CC||vondr...@redhat.com --- Comment #7 from Vít Ondruch --- I have a few comments. * The test suite is not executed - It is always good idea to execute the test suite to make sure the package works. There is test suite available in upstream repository, so it should not be a problem. * Please remove the binary extension from the source tree - Please see [1] how to do it and for the link to associated BZ with reasoning. * License - The license field does not contain valid Fedora identifier. Please see [2] and pick the correct one (likely LGPLv2?) [1] http://pkgs.fedoraproject.org/cgit/rpms/rubygem-sqlite3.git/tree/rubygem-sqlite3.spec#n49 [2] https://fedoraproject.org/wiki/Licensing:Main#Software_License_List -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1371810] Review Request: python-iowait - Platform-independent module for I/O completion events
https://bugzilla.redhat.com/show_bug.cgi?id=1371810 Igor Gnatenko changed: What|Removed |Added Alias||python-iowait -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1371810] New: Review Request: python-iowait - Platform-independent module for I/O completion events
https://bugzilla.redhat.com/show_bug.cgi?id=1371810 Bug ID: 1371810 Summary: Review Request: python-iowait - Platform-independent module for I/O completion events Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: ignate...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/python-iowait.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/python-iowait-0.2-1.fc26.src.rpm Description: Different operating systems provide different ways to wait for I/O completion events: there’s select(), poll(), epoll() and kqueue(). For cross-platform applications it can be a pain to support all this system functions, especially because each one provides a different interface. IOWait solves this problem by providing a unified interface and using always the best and faster function available in the platform. Its only limitation is that, on Windows, it only works for sockets. Fedora Account System Username: ignatenkobrain -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1366713] Review Request: nunit2 - unit-testing framework for .Net/ mono
https://bugzilla.redhat.com/show_bug.cgi?id=1366713 --- Comment #13 from Timotheus Pokorra --- @Raphael, I have requested commit rights on those 3 packages. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1371627] Review Request: inih - Simple INI file parser library
https://bugzilla.redhat.com/show_bug.cgi?id=1371627 --- Comment #10 from jfch --- implemented %license now release is 5 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1371627] Review Request: inih - Simple INI file parser library
https://bugzilla.redhat.com/show_bug.cgi?id=1371627
--- Comment #8 from Igor Gnatenko ---
(In reply to jfch from comment #7)
> Almost all done but %license tag causes local compilation fail.
> Looking at other rawhide srpms I didn't see it anywhere.
$ find -type f -name '*.spec' | xargs grep "^%license"
./hawkey/hawkey.spec:%license COPYING
./vte291/vte291.spec:%license COPYING
./python-iniparse/python-iniparse.spec:%license LICENSE LICENSE-PSF
./python-docker-squash/python-docker-squash.spec:%license LICENSE
./python-xunitparser/python-xunitparser.spec:%license LICENSE
[snip]
There is some guidelines about that. Though it fails only on EL6 I guess.
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines
https://fedoraproject.org/wiki/EPEL:Packaging#Previously_required_boilerplate
As a workaround you can add into beginning of spec:
%if 0%{?rhel} && 0%{?rhel} <= 6
%{!?_licensedir:%global license %%doc}
%endif
and it will start working.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1371627] Review Request: inih - Simple INI file parser library
https://bugzilla.redhat.com/show_bug.cgi?id=1371627 --- Comment #9 from Igor Gnatenko --- > If the source package includes the text of the license(s) in its own file, > then that file, containing the text of the license(s) for the package must be > included in %license. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
