[Bug 1433657] Review Request: vncpwd - VNC Password Decrypter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1433657



--- Comment #5 from Michal Ambroz  ---
Spec URL: http://rebus.fedorapeople.org/SPECS/vncpwd.spec
SRPM URL:
http://rebus.fedorapeople.org/SRPMS/vncpwd-0.0-3.20170607git596854c.fc27.src.rpm


>- Please update to latest git revision: 
>596854c237e26b3f615d933e8abd040f1ed9b5c9
updated

>- Please include a commit date for versioning:
added

>- use %make_build instead of just make
used

> - Group: is not used in Fedora. See 
> https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections
removed 

> - The package doesn't generate debugging symbols, you should add:
> %global debug_package   %{nil}
I have rather patched to honor the optflags


> - You should patch the FSF address in the README and notify upstream.
Reported upstream, but not patched

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519607] Review Request: gap-pkg-nautytracesinterface - GAP interface to nauty and Traces

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519607



--- Comment #1 from Luya Tshimbalanga  ---
Finally found the time for the review.
Additionally, replace %setup -q -n %{user}-NautyTracesInterface-%{shorttag} by
%autosetup -p1 -n %{user}-NautyTracesInterface-%{shorttag}


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- All build dependencies are listed in BuildRequires, except for any that
  are listed in the exceptions section of Packaging Guidelines.
  Note: These BR are not needed: gcc-c++
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[-]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Apache (v2.0)", "GPL (v2)".
Could you check with upstream about the licensing from the following:
Apache (v2.0)
-
sebasguts-NautyTracesInterface-5f16120/nauty26r7/COPYRIGHT

GPL (v2)

sebasguts-NautyTracesInterface-5f16120/COPYING

Main reason is the compatibility between Apache 2.0 and GPLv2 as highlighted by
https://fedoraproject.org/wiki/Licensing:Main#Good_Licenses

[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No 

[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=587978



--- Comment #26 from Michal Ambroz  ---
SPEC URL: https://rebus.fedorapeople.org/SPECS/whatweb.spec
SRPM URL: https://rebus.fedorapeople.org/SRPMS/whatweb-0.4.9-1.fc27.src.rpm

Bump to current upstream release.

>[!]: MUST Each %files section contains %defattr if rpm < 4.4
defattr removed

>[!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
cleaning of the buildroot removed

>[!]: MUST Sources used to build the package match the upstream source, as
The release should MD5 match much better than git commit ad-hoc snapshot
(please note that gzip contains timestamps so it might not be MD5 same).

>[!]: SHOULD Buildroot is not present
removed

>[!]: SHOULD Package has no %clean section with rm -rf %{buildroot} (or
removed

>[!]: SHOULD SourceX / PatchY prefixed with %{name}.
link to release source is now resulting in whatweb-0.4.9.tar.gz

>[!]: SHOULD Spec use %global instead of %define.
define changed to global


Best regards
Michal Ambroz

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1509590] Review Request: cool-retro-term - Terminal emulator mimicking a CRT display

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1509590

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-12-10 00:08:06



--- Comment #19 from Fedora Update System  ---
cool-retro-term-1.0.1-5.fc27 has been pushed to the Fedora 27 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1455899] Review Request: qt5-qtremoteobjects - Qt5 - Qt Remote Objects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1455899

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2017-11-20 14:07:00 |2017-12-10 00:03:33



--- Comment #6 from Fedora Update System  ---
qt5-qtremoteobjects-5.9.2-1.fc27 has been pushed to the Fedora 27 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1513375] Review Request: ghc-fingertree - Generic finger-tree structure, with example instances

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1513375



--- Comment #9 from Fedora Update System  ---
ghc-fingertree-0.1.2.1-1.fc27, ghc-reducers-3.12.2-1.fc27,
ghc-tasty-0.12-1.fc27, ghc-tasty-hunit-0.9.2-1.fc27,
ghc-tasty-quickcheck-0.9.1-1.fc27, ghc-tasty-rerun-1.1.7-1.fc27 has been pushed
to the Fedora 27 stable repository. If problems still persist, please make note
of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1514934] Review Request: esh - Simple templating engine based on shell

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1514934

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-12-10 00:03:25



--- Comment #10 from Fedora Update System  ---
esh-0.1.1-1.fc27 has been pushed to the Fedora 27 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1513777] Review Request: ghc-reducers - Semigroups, specialized containers and general map/reduce

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1513777



--- Comment #8 from Fedora Update System  ---
ghc-fingertree-0.1.2.1-1.fc27, ghc-reducers-3.12.2-1.fc27,
ghc-tasty-0.12-1.fc27, ghc-tasty-hunit-0.9.2-1.fc27,
ghc-tasty-quickcheck-0.9.1-1.fc27, ghc-tasty-rerun-1.1.7-1.fc27 has been pushed
to the Fedora 27 stable repository. If problems still persist, please make note
of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1514301] Review Request: ghc-tasty-hunit - HUnit support for the Tasty test framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1514301



--- Comment #8 from Fedora Update System  ---
ghc-fingertree-0.1.2.1-1.fc27, ghc-reducers-3.12.2-1.fc27,
ghc-tasty-0.12-1.fc27, ghc-tasty-hunit-0.9.2-1.fc27,
ghc-tasty-quickcheck-0.9.1-1.fc27, ghc-tasty-rerun-1.1.7-1.fc27 has been pushed
to the Fedora 27 stable repository. If problems still persist, please make note
of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1513715] Review Request: ghc-wai-cors - CORS for WAI

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1513715



--- Comment #7 from Fedora Update System  ---
ghc-wai-cors-0.2.5-1.fc27 has been pushed to the Fedora 27 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1513770] Review Request: ghc-tasty - Modern and extensible testing framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1513770



--- Comment #9 from Fedora Update System  ---
ghc-fingertree-0.1.2.1-1.fc27, ghc-reducers-3.12.2-1.fc27,
ghc-tasty-0.12-1.fc27, ghc-tasty-hunit-0.9.2-1.fc27,
ghc-tasty-quickcheck-0.9.1-1.fc27, ghc-tasty-rerun-1.1.7-1.fc27 has been pushed
to the Fedora 27 stable repository. If problems still persist, please make note
of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1514307] Review Request: ghc-tasty-rerun - Run tests by filtered by the result of previous test runs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1514307



--- Comment #8 from Fedora Update System  ---
ghc-fingertree-0.1.2.1-1.fc27, ghc-reducers-3.12.2-1.fc27,
ghc-tasty-0.12-1.fc27, ghc-tasty-hunit-0.9.2-1.fc27,
ghc-tasty-quickcheck-0.9.1-1.fc27, ghc-tasty-rerun-1.1.7-1.fc27 has been pushed
to the Fedora 27 stable repository. If problems still persist, please make note
of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1515504] Review Request: ghc-tasty-quickcheck - QuickCheck support for the Tasty test framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1515504



--- Comment #9 from Fedora Update System  ---
ghc-fingertree-0.1.2.1-1.fc27, ghc-reducers-3.12.2-1.fc27,
ghc-tasty-0.12-1.fc27, ghc-tasty-hunit-0.9.2-1.fc27,
ghc-tasty-quickcheck-0.9.1-1.fc27, ghc-tasty-rerun-1.1.7-1.fc27 has been pushed
to the Fedora 27 stable repository. If problems still persist, please make note
of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380105] Review Request: mingw-libdb - MinGW build of The Berkeley DB database library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380105

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-12-10 00:02:16



--- Comment #15 from Fedora Update System  ---
mingw-libdb-5.3.28-3.fc27 has been pushed to the Fedora 27 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 885919] Review Request: mingw-libdb - MinGW build of The Berkeley DB database library for C

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=885919

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-12-10 00:02:09



--- Comment #10 from Fedora Update System  ---
mingw-libdb-5.3.28-3.fc27 has been pushed to the Fedora 27 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519747] Review request: libdigidocpp - Library offers creating, signing and verification of digitally signed documents, according to XAdES and XML-DSIG standards

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519747



--- Comment #3 from Robert-André Mauchin  ---
%makeinstall should not be used, %make_install is good.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520585] Review Request: perl-Test-SQL-Data - Helps running SQL tests : database preparing and result matching

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520585



--- Comment #11 from Fedora Update System  ---
perl-Test-SQL-Data-0.0.6-1.fc27 has been pushed to the Fedora 27 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-eefda41e3a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520915] Review Request: tldr - command line client for tldr

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520915



--- Comment #11 from Fedora Update System  ---
tldr-0.4.1-1.fc27 has been pushed to the Fedora 27 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-8f6c9bf2c5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520568] Review Request: perl-Crypt-MySQL - Emulate MySQL PASSWORD() function

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520568



--- Comment #8 from Fedora Update System  ---
perl-Crypt-MySQL-0.04-1.fc27 has been pushed to the Fedora 27 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-89b5a07821

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520584] Review Request: perl-MooseX-Types-NetAddr-IP - NetAddr:: IP related types and coercions for Moose

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520584



--- Comment #8 from Fedora Update System  ---
perl-MooseX-Types-NetAddr-IP-0.07-1.fc27 has been pushed to the Fedora 27
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-e239663377

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1508080] Review Request: golang-github-yuin-gopher-lua - GopherLua: VM and compiler for Lua in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1508080

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #7 from Fedora Update System  ---
golang-github-yuin-gopher-lua-0-0.1.20171031git609c9cd.fc27 has been pushed to
the Fedora 27 testing repository. If problems still persist, please make note
of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-5492384dcd

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1419937] Review Request: pgdbf - Convert XBase / FoxPro databases to PostgreSQL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1419937



--- Comment #12 from Fedora Update System  ---
pgdbf-0.6.2-2.fc27 has been pushed to the Fedora 27 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-6b38b6615e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519844] Review Request: python-pymediainfo - Python wrapper around the MediaInfo library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519844



--- Comment #14 from Fedora Update System  ---
python-pymediainfo-2.2.0-1.fc27 has been pushed to the Fedora 27 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-5e373e99e1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1411984] Review Request: neofetch - a CLI system information tool written in Bash

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1411984

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|NEXTRELEASE |---
   Keywords||Reopened



--- Comment #35 from Fedora Update System  ---
neofetch-3.3.0-1.fc27 has been pushed to the Fedora 27 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-b9c158f42a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520863] Review Request: eclipse-sgx - Intel Software Guard Extensions Plug-in for Eclipse

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520863



--- Comment #7 from Fedora Update System  ---
eclipse-sgx-2.0-1.fc27 has been pushed to the Fedora 27 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-c4b0813d02

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520150] Review Request: gnome-shell-extension-disconnect-wifi - GNOME Shell Extension Disconnect Wifi by kgshank

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520150



--- Comment #10 from Fedora Update System  ---
gnome-shell-extension-disconnect-wifi-17-1.fc27 has been pushed to the Fedora
27 testing repository. If problems still persist, please make note of it in
this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-347bbcd678

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519747] Review request: libdigidocpp - Library offers creating, signing and verification of digitally signed documents, according to XAdES and XML-DSIG standards

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519747



--- Comment #2 from Germano Massullo  ---
Concerning
>  - make install DESTDIR=%{buildroot} → %make_install
https://fedoraproject.org/wiki/Packaging:Guidelines#Why_the_.25makeinstall_macro_should_not_be_used

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1518957] Review request: esteidcerts - Estonian ID card root, intermediate and OCSP certificates

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1518957

Robert-André Mauchin  changed:

   What|Removed |Added

  Flags|needinfo?(zebo...@gmail.com |
   |)   |



--- Comment #3 from Robert-André Mauchin  ---
Buildarch: should be BuildArch:

Also you should probably add your own %changelog entry.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package does not use a name that already exists.
  Note: A package with this name already exists. Please check
  https://admin.fedoraproject.org/pkgdb/package/esteidcerts
  See:
 
https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Conflicting_Package_Names


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[-]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 40 files have unknown license. Detailed
 output of licensecheck in /home/bob/packaging/review/esteidcerts
 /review-esteidcerts/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[!]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in 

[Bug 1518957] Review request: esteidcerts - Estonian ID card root, intermediate and OCSP certificates

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1518957

Germano Massullo  changed:

   What|Removed |Added

  Flags||needinfo?(zebo...@gmail.com
   ||)



--- Comment #2 from Germano Massullo  ---
you should fill the checklist you get from fedora-review command

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476237] Review Request: perl-Graphics-TIFF - Perl extension for the LibTIFF library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476237

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2017-08-01 08:58:54 |2017-12-09 17:24:22



--- Comment #6 from Fedora Update System  ---
perl-Graphics-TIFF-6-1.fc26, perl-PDF-API2-2.033-2.fc26 has been pushed to the
Fedora 26 stable repository. If problems still persist, please make note of it
in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1514307] Review Request: ghc-tasty-rerun - Run tests by filtered by the result of previous test runs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1514307
Bug 1514307 depends on bug 1513770, which changed state.

Bug 1513770 Summary: Review Request: ghc-tasty - Modern and extensible testing 
framework
https://bugzilla.redhat.com/show_bug.cgi?id=1513770

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1514301] Review Request: ghc-tasty-hunit - HUnit support for the Tasty test framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1514301

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-12-09 17:23:53



--- Comment #7 from Fedora Update System  ---
ghc-tasty-hunit-0.9.2-1.fc26 has been pushed to the Fedora 26 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1515504] Review Request: ghc-tasty-quickcheck - QuickCheck support for the Tasty test framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1515504

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-12-09 17:23:57



--- Comment #8 from Fedora Update System  ---
ghc-tasty-quickcheck-0.9.1-1.fc26 has been pushed to the Fedora 26 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1513770] Review Request: ghc-tasty - Modern and extensible testing framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1513770

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-12-09 17:23:46



--- Comment #8 from Fedora Update System  ---
ghc-tasty-0.12-1.fc26 has been pushed to the Fedora 26 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1514301] Review Request: ghc-tasty-hunit - HUnit support for the Tasty test framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1514301
Bug 1514301 depends on bug 1513770, which changed state.

Bug 1513770 Summary: Review Request: ghc-tasty - Modern and extensible testing 
framework
https://bugzilla.redhat.com/show_bug.cgi?id=1513770

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1513375] Review Request: ghc-fingertree - Generic finger-tree structure, with example instances

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1513375

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-12-09 17:23:42



--- Comment #8 from Fedora Update System  ---
ghc-fingertree-0.1.2.1-1.fc26 has been pushed to the Fedora 26 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1513715] Review Request: ghc-wai-cors - CORS for WAI

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1513715

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-12-09 17:23:36



--- Comment #6 from Fedora Update System  ---
ghc-wai-cors-0.2.5-1.fc26 has been pushed to the Fedora 26 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1513777] Review Request: ghc-reducers - Semigroups, specialized containers and general map/reduce

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1513777
Bug 1513777 depends on bug 1513375, which changed state.

Bug 1513375 Summary: Review Request: ghc-fingertree - Generic finger-tree 
structure, with example instances
https://bugzilla.redhat.com/show_bug.cgi?id=1513375

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1509262] Review Request: flatbuffers - memory efficient serialization library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1509262

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2017-11-14 08:57:51 |2017-12-09 17:23:17



--- Comment #13 from Fedora Update System  ---
flatbuffers-1.8.0-2.fc26 has been pushed to the Fedora 26 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1511966] Review Request: qmltermwidget - a QML port of QTermWidget

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1511966



--- Comment #19 from Fedora Update System  ---
qmltermwidget-0.1.0-3.20171027git08958f7.el6 has been pushed to the Fedora EPEL
6 stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1119197] Review Request: gnushogi - Shogi (Japanese Chess) AI engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1119197



--- Comment #16 from Ben Rosser  ---
> I'm still willing to package this game. Please let me have some time to catch 
> up with the latest development and prepare a new SRPM.

Great to hear you are still interested! Just let me know when the package is
ready.

Once the time comes, I can also sponsor you.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519844] Review Request: python-pymediainfo - Python wrapper around the MediaInfo library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519844



--- Comment #13 from Fedora Update System  ---
python-pymediainfo-2.2.0-1.el6 has been pushed to the Fedora EPEL 6 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-54baa1189e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1523909] Review Request: kernel-tools - Assortment of tools for the Linux kernel

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1523909



--- Comment #2 from Robert-André Mauchin  ---
I forgot a thing' if you install a systemd service file
(%{_unitdir}/cpupower.service), you must run the systemd scripplet as described
in: https://fedoraproject.org/wiki/Packaging:Scriptlets#Systemd

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1523909] Review Request: kernel-tools - Assortment of tools for the Linux kernel

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1523909

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #1 from Robert-André Mauchin  ---
I don't know if I am experienced enough to review this complex package, but
here a few preliminary remarks:

 - Group: is not used anymore in Fedora. See:
https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections

 - L103: generally the BuildRoot shouldn't need to be redefined.

 - L117: cpuspeed is obsoleted but there is no corresponding Provides

 - L141: python_sitearch is already defined by default, no need to redefine it.

 - L187: No need for rm -rf $RPM_BUILD_ROOT

 - Multiple times: make %{?_smp_mflags} → %make_build

 - Multiple times: make DESTDIR=%{buildroot} install → %make_install

 - L297-303: %clean is not needed anymore. Remove it:

###
### clean
###

%clean
rm -rf $RPM_BUILD_ROOT

 - L308-312 Since /sbin/ldconfig is the only thing called in %post and %postun,
use the -p syntax to avoid spawning a shell:

%post -n kernel-tools-libs -p /sbin/ldconfig
%postun -n kernel-tools-libs -p /sbin/ldconfig

 - In the %files, %defattr(-,root,root) is not needed, it is already the
default.

 - The %changelog must contain the version and release.

* Tue Nov 21 2017 Laura Abbott  - VERSION-RELEASE

  - Add "%license COPYING" in %files for all packages combinations (I believe
it's in perf, python-perf, and kernel-tools-libs)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1514274] Review Request: twitter-twemoji-fonts - Twitter Emoji for everyone

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1514274



--- Comment #3 from Neal Gompa  ---
General question: Why is Noto part of Twemoji? My understanding is that these
are different fonts altogether?

And what's exactly going on with the metadata mutation going on in the prep
stage?


> # Work around UTF-8
> export LANG=zh_CN.UTF-8

Please use "C.UTF-8". In Fedora, that is the generic locale that offers full
UTF-8 support.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1119197] Review Request: gnushogi - Shogi (Japanese Chess) AI engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1119197

Chen Chen  changed:

   What|Removed |Added

  Flags|needinfo?(aflyhorse@hotmail |
   |.com)   |



--- Comment #15 from Chen Chen  ---
(In reply to Ben Rosser from comment #14)
> It has been several years, but please reply if you are still interested in
> this submission, and I'd be willing to review.

Hi Ben,

I'm still willing to package this game. Please let me have some time to catch
up with the latest development and prepare a new SRPM.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org