[Bug 1773467] Review Request: avocado-vt - A avocado plugin for virtualization related tests
https://bugzilla.redhat.com/show_bug.cgi?id=1773467 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #31 from Fedora Update System --- FEDORA-2020-16b0770846 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-16b0770846 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823091] Review Request: python-freeipa - Lightweight FreeIPA client
https://bugzilla.redhat.com/show_bug.cgi?id=1823091
Carl George changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #1 from Carl George ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf
[Bug 1823151] Review Request: thinkpad-tools - Tools to manage ThinkPad properties
https://bugzilla.redhat.com/show_bug.cgi?id=1823151 Dev Singh changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823151] New: Review Request: thinkpad-tools - Tools to manage ThinkPad properties
https://bugzilla.redhat.com/show_bug.cgi?id=1823151 Bug ID: 1823151 Summary: Review Request: thinkpad-tools - Tools to manage ThinkPad properties Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nob...@fedoraproject.org Reporter: d...@singhk.dev QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://raw.githubusercontent.com/devksingh4/thinkpad-tools/master/python3-thinkpad-tools.spec SRPM URL: https://github.com/devksingh4/thinkpad-tools/releases/download/v0.11.0/python-thinkpad-tools-0.11.0-1.fc31.src.rpm Description: This CLI tool allows users of Lenovo ThinkPads to edit properties such as TrackPoint speed, battery status, and undervolting. Fedora Account System Username: dsingh This is my first package and I need a sponsor. I am also the author of the upstream software. Here's the link to a koji build for the software: https://koji.fedoraproject.org/koji/taskinfo?taskID=43256182 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823117] Review Request: opensurge - 2D retro platformer inspired by Sonic games
https://bugzilla.redhat.com/show_bug.cgi?id=1823117 --- Comment #2 from Artur Iwicki --- Took a better look at the game's assets. Updated the License: tag in the -data subpackage and unbundled Roboto fonts. spec: https://svgames.pl/fedora/opensurge-0.5.1.2-2.spec srpm: https://svgames.pl/fedora/opensurge-0.5.1.2-2.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=43255261 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823091] Review Request: python-freeipa - Lightweight FreeIPA client
https://bugzilla.redhat.com/show_bug.cgi?id=1823091 Carl George changed: What|Removed |Added CC||c...@redhat.com Assignee|nob...@fedoraproject.org|c...@redhat.com Doc Type|--- |If docs needed, set a value Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1804529] Review Request: pam-cryptsetup - PAM module for updating LUKS-encrypted volumes
https://bugzilla.redhat.com/show_bug.cgi?id=1804529 --- Comment #18 from Fedora Update System --- FEDORA-2020-b566e12a5e has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1813737] Review Request: azote - Wallpaper and colour manager for Sway, i3 and some other WMs
https://bugzilla.redhat.com/show_bug.cgi?id=1813737 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-04-11 22:21:01 --- Comment #19 from Fedora Update System --- FEDORA-2020-f5187a56b4 has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1809684] Review Request: git-repair - Repairs a damaged git repository
https://bugzilla.redhat.com/show_bug.cgi?id=1809684 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-04-11 22:21:04 --- Comment #9 from Fedora Update System --- FEDORA-2020-d853e0271e has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823132] Review Request: gearhead1 - Roguelike mecha role-playing game
https://bugzilla.redhat.com/show_bug.cgi?id=1823132 Artur Iwicki changed: What|Removed |Added Blocks||1364745 (FE-GAMESIG) Doc Type|--- |If docs needed, set a value Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1364745 [Bug 1364745] Games SIG tracker bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1820799] Review Request: golang-github-evilsocket-islazy - Go library containing a set of opinionated packages
https://bugzilla.redhat.com/show_bug.cgi?id=1820799 --- Comment #3 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-evilsocket-islazy -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823134] New: Review Request: GnuCOBOL - GnuCOBOL is a free implementation of the COBOL programming language.
https://bugzilla.redhat.com/show_bug.cgi?id=1823134 Bug ID: 1823134 Summary: Review Request: GnuCOBOL - GnuCOBOL is a free implementation of the COBOL programming language. Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: tachokni...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://tachoknight.fedorapeople.org/cobol-lang/cobol-lang.spec SRPM URL: https://tachoknight.fedorapeople.org/cobol-lang/GnuCOBOL-2.2-1.fc31.src.rpm Description: GnuCOBOL is a free implementation of the COBOL programming language. Fedora Account System Username: tachoknight -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823134] Review Request: GnuCOBOL - GnuCOBOL is a free implementation of the COBOL programming language.
https://bugzilla.redhat.com/show_bug.cgi?id=1823134 Ron Olson changed: What|Removed |Added Doc Type|--- |If docs needed, set a value --- Comment #1 from Ron Olson --- Rawhide scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=43250184 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1804529] Review Request: pam-cryptsetup - PAM module for updating LUKS-encrypted volumes
https://bugzilla.redhat.com/show_bug.cgi?id=1804529 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-04-11 21:51:26 --- Comment #17 from Fedora Update System --- FEDORA-2020-6b7dfaec4e has been pushed to the Fedora 30 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1820799] Review Request: golang-github-evilsocket-islazy - Go library containing a set of opinionated packages
https://bugzilla.redhat.com/show_bug.cgi?id=1820799 --- Comment #2 from Fabian Affolter --- Thanks for the review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823132] New: Review Request: gearhead1 - Roguelike mecha role-playing game
https://bugzilla.redhat.com/show_bug.cgi?id=1823132 Bug ID: 1823132 Summary: Review Request: gearhead1 - Roguelike mecha role-playing game Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: fed...@svgames.pl QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora spec: https://svgames.pl/fedora/gearhead1-1.310-1.spec srpm: https://svgames.pl/fedora/gearhead1-1.310-1.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=43249441 Description: Set a century and a half after nuclear war, in this game you explore a world where various factions compete to determine the future of the human race. Features include random plot generation and over two hundred mecha designs. Pilot a giant robot, a city smashing tank, a living jet fighter, or anything else that can be built using the game's sophisticated design system. Fedora Account System Username: suve -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823117] Review Request: opensurge - 2D retro platformer inspired by Sonic games
https://bugzilla.redhat.com/show_bug.cgi?id=1823117 Antonio T. (sagitter) changed: What|Removed |Added Status|NEW |ASSIGNED CC||anto.tra...@gmail.com Assignee|nob...@fedoraproject.org|anto.tra...@gmail.com --- Comment #1 from Antonio T. (sagitter) --- Interesting. I will review this package soon. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1809814] Review Request: protonvpn-cli - Linux command-line client for ProtonVPN written in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1809814 --- Comment #26 from Fedora Update System --- FEDORA-EPEL-2020-370bbcab84 has been pushed to the Fedora EPEL 7 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823117] Review Request: opensurge - 2D retro platformer inspired by Sonic games
https://bugzilla.redhat.com/show_bug.cgi?id=1823117 Artur Iwicki changed: What|Removed |Added Blocks||1364745 (FE-GAMESIG) Doc Type|--- |No Doc Update --- Doc Text *updated* --- If this bug requires documentation, please select an appropriate Doc Type value. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1364745 [Bug 1364745] Games SIG tracker bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823117] New: Review Request: opensurge - 2D retro platformer inspired by Sonic games
https://bugzilla.redhat.com/show_bug.cgi?id=1823117 Bug ID: 1823117 Summary: Review Request: opensurge - 2D retro platformer inspired by Sonic games Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: fed...@svgames.pl QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora spec: https://svgames.pl/fedora/opensurge-0.5.1.2-1.spec srpm: https://svgames.pl/fedora/opensurge-0.5.1.2-1.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=43247079 Description: Open Surge is a fun 2D retro platformer inspired by Sonic games, and a game creation system that lets you unleash your creativity! Fedora Account System Username: suve -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1809814] Review Request: protonvpn-cli - Linux command-line client for ProtonVPN written in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1809814 --- Comment #25 from Fedora Update System --- FEDORA-EPEL-2020-944d23ac95 has been pushed to the Fedora EPEL 8 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1809910] Review Request: python-registry - Read access to Windows Registry files
https://bugzilla.redhat.com/show_bug.cgi?id=1809910 --- Comment #14 from Fedora Update System --- FEDORA-EPEL-2020-0ffdf26ae2 has been pushed to the Fedora EPEL 8 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1808506] Review Request: python-mulpyplexer - Module that multiplexes interactions with lists of Python objects
https://bugzilla.redhat.com/show_bug.cgi?id=1808506 --- Comment #15 from Fedora Update System --- FEDORA-EPEL-2020-4df652c611 has been pushed to the Fedora EPEL 8 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1787218] Review Request: python-aiopg - Postgres integration with asyncio
https://bugzilla.redhat.com/show_bug.cgi?id=1787218 --- Comment #14 from Fedora Update System --- FEDORA-EPEL-2020-8fe9c815da has been pushed to the Fedora EPEL 8 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816759] Review Request: python-xpath-expressions - Treat XPath expressions as Python objects
https://bugzilla.redhat.com/show_bug.cgi?id=1816759 --- Comment #16 from Fedora Update System --- FEDORA-EPEL-2020-f72ecc6d78 has been pushed to the Fedora EPEL 8 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1822971] Review Request: notcurses - character graphics and TUI library
https://bugzilla.redhat.com/show_bug.cgi?id=1822971 --- Comment #6 from Nick Black --- The new RPMs are available from https://www.dsscaw.com/repos/dnf/, with the source RPM at https://www.dsscaw.com/repos/dnf/notcurses-1.2.9-1.fc32.src.rpm. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1813292] Review Request: pkgtreediff - Package tree diff tool
https://bugzilla.redhat.com/show_bug.cgi?id=1813292 --- Comment #9 from Fedora Update System --- FEDORA-2020-ffe744638d has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-ffe744638d \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-ffe744638d See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1821330] Review Request: python-apypie - Python bindings for Apipie
https://bugzilla.redhat.com/show_bug.cgi?id=1821330 --- Comment #18 from Fedora Update System --- FEDORA-2020-99d1b8f017 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-99d1b8f017 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-99d1b8f017 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1807753] Review Request: ydotool - Generic command-line automation tool
https://bugzilla.redhat.com/show_bug.cgi?id=1807753 --- Comment #22 from Fedora Update System --- FEDORA-2020-63261d7bce has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-63261d7bce \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-63261d7bce See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1822971] Review Request: notcurses - character graphics and TUI library
https://bugzilla.redhat.com/show_bug.cgi?id=1822971 --- Comment #5 from Nick Black --- I have cut the 1.2.9 release as required. I've likewise amended the specfile to properly install python into the new python3-notcurses package. I did a local install on a fresh F32 box, and verified that all binaries ran correctly. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1818886] Review Request: golang-github-bobesa-domain-util - Handler for URL parts and identification of TLD and subdomain
https://bugzilla.redhat.com/show_bug.cgi?id=1818886 --- Comment #3 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-bobesa-domain-util -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1822971] Review Request: notcurses - character graphics and TUI library
https://bugzilla.redhat.com/show_bug.cgi?id=1822971 --- Comment #4 from Nick Black --- OK, I've tested this up. I need to cut a new 1.2.9 release and put up a new SRPM to include some Python installation fixes (right now `rpmbuild -ba` fails due to a missing egg-info directory). Other than that, your suggested changes all seem to work. Thanks for the review, Artur! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1822971] Review Request: notcurses - character graphics and TUI library
https://bugzilla.redhat.com/show_bug.cgi?id=1822971
--- Comment #3 from Nick Black ---
Thanks for the review, Artur! I've made the requested changes; the updated spec
file (in raw, non-rich format) can be found here:
https://raw.githubusercontent.com/dankamongmen/notcurses/master/tools/notcurses.spec>%{python3_sitelib}/*egg-info/
> This should probably go in a separate package, like "python3-notcurses". Not
> everyone needs the python bindings.
Done
> Why are the tests disabled? Add a comment to the spec.
Done. doctest is not present in F32, so far as I can tell. I considered
downloading it at runtime or packaging it with notcurses, but given its
presence in other targeted distributions, I decided to wait on it appearing in
Fedora (or to package it for Fedora myself).
> This should be an archful dependency - "%{name}%{?_isa} =
> %{version}-%{release}"
Done. I've added a similar dependency to the new Python package.
> Do not assume that man pages will be gzipped. Use a wildcard that can match
> any compression method
Done.
> Also, you list every file in the resulting package individually, but you do
> not list the directories.
Done. That cleans up the file nicely, thanks. I've commited this to my git, and
will test it now.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823091] New: Review Request: python-freeipa - Lightweight FreeIPA client
https://bugzilla.redhat.com/show_bug.cgi?id=1823091 Bug ID: 1823091 Summary: Review Request: python-freeipa - Lightweight FreeIPA client Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: ngomp...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://ngompa.fedorapeople.org/for-review/python-freeipa.spec SRPM URL: https://ngompa.fedorapeople.org/for-review/python-freeipa-1.0.2-1.fc32.src.rpm Description: python-freeipa is lightweight FreeIPA client. Fedora Account System Username: ngompa -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1822362] Review Request: duc - Disk usage analyzer
https://bugzilla.redhat.com/show_bug.cgi?id=1822362 --- Comment #7 from Wart --- (In reply to Artur Iwicki from comment #3) > >Group: Applications/System > The "Group:" tag is no longer used in Fedora. > >%clean > The %clean section is no longer used in Fedora. > >%install > >rm -rf $RPM_BUILD_ROOT > Don't do this. > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections Fixed. > Also, looking at the upstream repo, there's no readily-executable configure > script, but configure.ac. The Makefile is also provided as Makefile.am. > Shouldn't you have "Requires: autoconf" and "Requires: automake" because of > this? These are not present in the upstream git repo (as I would expect), but they are present in the released tarball, which is what this is being built from. So no requirement on autoconf/automake is necessary. New spec: https://fedorapeople.org/~wart/duc.spec New srpm: https://fedorapeople.org/~wart/duc-1.4.4-4.fc33.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1822362] Review Request: duc - Disk usage analyzer
https://bugzilla.redhat.com/show_bug.cgi?id=1822362 --- Comment #6 from Wart --- (In reply to Robert Führicht from comment #2) > I've submitted this earlier > (https://bugzilla.redhat.com/show_bug.cgi?id=1764368), but it didn't gather > enough attention. My apologies. Had I seen this sooner I would have helped in your effort. Would you like to collaborate to get this approved? To be honest, I'm primarily interested in getting this into the epel7/epel8 branches and not as much in Fedora. > My 0.02 €: > > As duc relies on an index to work properly, I suggest periodical automated > generation (similar to mlocate): > > > - Have a system-wide index available to root in /var/cache/duc, which is > > updated without restriction daily and is used when root calls "duc ui". > > - Have a service available for users they can use to index their > > homedirectory. > > To match my use case I switched to a profile.d drop-in for now. > > What do you guys think? Reading through the comments in the earlier review, I think it would be best to drop the services to automatically index directories. I don't think the services are necessarily required to make duc usable, as one can also: * run it as a cron job * run it by hand for a one-off index * Use an index generated on a different host -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1822362] Review Request: duc - Disk usage analyzer
https://bugzilla.redhat.com/show_bug.cgi?id=1822362 --- Comment #5 from Wart --- (In reply to Fabian Affolter from comment #1) > Please update the spec file according the guidelines. Multiple parts are > obsolete. My bad. These were leftovers from the EPEL packaging that I had been using. I have removed them and will post a new spec/srpm shortly. > Also, the license is LGPLv3+ and not GPLv2. Upstream is inconsistent on this. The upstream release notes claim a switch to LGPL, while the COPYING file in the released source tarball is for GPLv2. Even though the intent was to make it LGPL, I feel I have to abide by what was actually delivered in the upstream tarball. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1822464] Review Request: python-siphash - SipHash in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1822464 Vitaly Zaitsev changed: What|Removed |Added Flags|fedora-review? |fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1822464] Review Request: python-siphash - SipHash in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1822464 --- Comment #3 from Vitaly Zaitsev --- > python3-siphash.noarch: E: useless-provides python-siphash > python3-siphash.noarch: E: useless-provides python38-siphash I think these errors are rpmlint bugs. Such entries were added automatically by Python dependency generator. All other looks good for me. Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1822464] Review Request: python-siphash - SipHash in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1822464
--- Comment #2 from Vitaly Zaitsev ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: There is no build directory. Running licensecheck on vanilla
upstream sources. No licenses found. Please check the source files for
licenses manually.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Binary eggs must be removed in %prep
Note: Cannot find any build in BUILD directory (--prebuilt option?)
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
[Bug 1822362] Review Request: duc - Disk usage analyzer
https://bugzilla.redhat.com/show_bug.cgi?id=1822362 Artur Iwicki changed: What|Removed |Added CC||fed...@svgames.pl --- Comment #3 from Artur Iwicki --- >Group: Applications/System The "Group:" tag is no longer used in Fedora. >%clean The %clean section is no longer used in Fedora. >%install >rm -rf $RPM_BUILD_ROOT Don't do this. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections Also, looking at the upstream repo, there's no readily-executable configure script, but configure.ac. The Makefile is also provided as Makefile.am. Shouldn't you have "Requires: autoconf" and "Requires: automake" because of this? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1822464] Review Request: python-siphash - SipHash in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1822464 Vitaly Zaitsev changed: What|Removed |Added Status|NEW |ASSIGNED CC||vit...@easycoding.org Assignee|nob...@fedoraproject.org|vit...@easycoding.org Doc Type|--- |If docs needed, set a value Flags||fedora-review? --- Comment #1 from Vitaly Zaitsev --- I will review this package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1822971] Review Request: notcurses - character graphics and TUI library
https://bugzilla.redhat.com/show_bug.cgi?id=1822971
Artur Iwicki changed:
What|Removed |Added
CC||fed...@svgames.pl
Doc Type|--- |If docs needed, set a value
--- Comment #2 from Artur Iwicki ---
>Spec URL:
>https://github.com/dankamongmen/notcurses/blob/master/tools/notcurses.spec
This link points to a syntax-highlighted HTML view of the file. Please use a
link to the raw file next time.
>%package devel
>Requires: %{name} = %{version}-%{release}
This should be an archful dependency - "%{name}%{?_isa} =
%{version}-%{release}"
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_requiring_base_package
>%build
>%cmake -DUSE_FFMPEG=off -DUSE_TESTS=off .
Why are the tests disabled? Add a comment to the spec.
>%{python3_sitelib}/*egg-info/
This should probably go in a separate package, like "python3-notcurses". Not
everyone needs the python bindings.
>%{_mandir}/man1/notcurses-demo.1.gz
>%{_mandir}/man1/notcurses-input.1.gz
>...
>%{_mandir}/man3/notcurses.3.gz
>%{_mandir}/man3/notcurses_cell.3.gz
>...
Do not assume that man pages will be gzipped. Use a wildcard that can match any
compression method (including no compression at all).
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages
Also, you list every file in the resulting package individually, but you do not
list the directories. This will cause RPM to consider the directories as
unowned (not belonging to any package). You should add directories to the
%files list. You can then also replace the list of files with a wildcard that
matches all of them.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1818886] Review Request: golang-github-bobesa-domain-util - Handler for URL parts and identification of TLD and subdomain
https://bugzilla.redhat.com/show_bug.cgi?id=1818886 --- Comment #2 from Fabian Affolter --- Thanks for the review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
