[Bug 1954468] Review Request: php-composer-metadata-minifier - Library that handles metadata minification and expansion
https://bugzilla.redhat.com/show_bug.cgi?id=1954468 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #5 from Fedora Update System --- FEDORA-2021-333d1bf1cf has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-333d1bf1cf -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1961033] New: Review Request: golang-github-masterminds-sprig - Useful template functions for Go templates
https://bugzilla.redhat.com/show_bug.cgi?id=1961033 Bug ID: 1961033 Summary: Review Request: golang-github-masterminds-sprig - Useful template functions for Go templates Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: dcava...@fb.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://dcavalca.fedorapeople.org/review/golang-github-masterminds-sprig/golang-github-masterminds-sprig.spec SRPM URL: https://dcavalca.fedorapeople.org/review/golang-github-masterminds-sprig/golang-github-masterminds-sprig-3.2.2-1.fc35.src.rpm Description: Useful template functions for Go templates. Fedora Account System Username: dcavalca -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1961027] Review Request: golang-github-lann-builder - Fluent immutable builders for golang
https://bugzilla.redhat.com/show_bug.cgi?id=1961027 Davide Cavalca changed: What|Removed |Added Blocks||1961028 Doc Type|--- |If docs needed, set a value Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1961028 [Bug 1961028] Review Request: golang-github-masterminds-squirrel - Fluent SQL generation for golang -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1961028] New: Review Request: golang-github-masterminds-squirrel - Fluent SQL generation for golang
https://bugzilla.redhat.com/show_bug.cgi?id=1961028 Bug ID: 1961028 Summary: Review Request: golang-github-masterminds-squirrel - Fluent SQL generation for golang Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: dcava...@fb.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://dcavalca.fedorapeople.org/review/golang-github-masterminds-squirrel/golang-github-masterminds-squirrel.spec SRPM URL: https://dcavalca.fedorapeople.org/review/golang-github-masterminds-squirrel/golang-github-masterminds-squirrel-1.5.0-1.fc35.src.rpm Description: Fluent SQL generation for golang. Fedora Account System Username: dcavalca -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1961028] Review Request: golang-github-masterminds-squirrel - Fluent SQL generation for golang
https://bugzilla.redhat.com/show_bug.cgi?id=1961028 Davide Cavalca changed: What|Removed |Added Depends On||1961027 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1961027 [Bug 1961027] Review Request: golang-github-lann-builder - Fluent immutable builders for golang -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1961027] Review Request: golang-github-lann-builder - Fluent immutable builders for golang
https://bugzilla.redhat.com/show_bug.cgi?id=1961027 Davide Cavalca changed: What|Removed |Added Depends On||1961026 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1961026 [Bug 1961026] Review Request: golang-github-lann-ps - Persistent data structures for Go -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1961026] Review Request: golang-github-lann-ps - Persistent data structures for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1961026 Davide Cavalca changed: What|Removed |Added Blocks||1961027 Doc Type|--- |If docs needed, set a value Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1961027 [Bug 1961027] Review Request: golang-github-lann-builder - Fluent immutable builders for golang -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1961027] New: Review Request: golang-github-lann-builder - Fluent immutable builders for golang
https://bugzilla.redhat.com/show_bug.cgi?id=1961027 Bug ID: 1961027 Summary: Review Request: golang-github-lann-builder - Fluent immutable builders for golang Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: dcava...@fb.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://dcavalca.fedorapeople.org/review/golang-github-lann-builder/golang-github-lann-builder.spec SRPM URL: https://dcavalca.fedorapeople.org/review/golang-github-lann-builder/golang-github-lann-builder-0-0.1.20210517git47ae307.fc35.src.rpm Description: Fluent immutable builders for golang. Fedora Account System Username: dcavalca -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1961026] New: Review Request: golang-github-lann-ps - Persistent data structures for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1961026 Bug ID: 1961026 Summary: Review Request: golang-github-lann-ps - Persistent data structures for Go Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: dcava...@fb.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://dcavalca.fedorapeople.org/review/golang-github-lann-ps/golang-github-lann-ps.spec SRPM URL: https://dcavalca.fedorapeople.org/review/golang-github-lann-ps/golang-github-lann-ps-0-0.1.20210517git62de8c4.fc35.src.rpm Description: Persistent data structures for Go. Fedora Account System Username: dcavalca -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1961025] Review Request: golang-github-gorp - Go Relational Persistence - an ORM-ish library for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1961025 --- Comment #1 from Davide Cavalca --- This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=68097717 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1961025] New: Review Request: golang-github-gorp - Go Relational Persistence - an ORM-ish library for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1961025 Bug ID: 1961025 Summary: Review Request: golang-github-gorp - Go Relational Persistence - an ORM-ish library for Go Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: dcava...@fb.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://dcavalca.fedorapeople.org/review/golang-github-gorp/golang-github-gorp.spec SRPM URL: https://dcavalca.fedorapeople.org/review/golang-github-gorp/golang-github-gorp-3.0.2-1.fc35.src.rpm Description: Go Relational Persistence - an ORM-ish library for Go. Fedora Account System Username: dcavalca -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1961017] New: Review Request: golang-github-gosuri-uitable - A go library to improve readability in terminal apps using tabular data
https://bugzilla.redhat.com/show_bug.cgi?id=1961017 Bug ID: 1961017 Summary: Review Request: golang-github-gosuri-uitable - A go library to improve readability in terminal apps using tabular data Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: dcava...@fb.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://dcavalca.fedorapeople.org/review/golang-github-gosuri-uitable/golang-github-gosuri-uitable.spec SRPM URL: https://dcavalca.fedorapeople.org/review/golang-github-gosuri-uitable/golang-github-gosuri-uitable-0.0.4-1.fc35.src.rpm Description: uitable is a go library for representing data as tables for terminal applications. It provides primitives for sizing and wrapping columns to improve readability. Fedora Account System Username: dcavalca -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1917075] Review Request: notekit - Hierarchical markdown notetaking application with tablet support
https://bugzilla.redhat.com/show_bug.cgi?id=1917075 --- Comment #18 from Fedora Update System --- FEDORA-2021-0f1c379ae3 has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1917075] Review Request: notekit - Hierarchical markdown notetaking application with tablet support
https://bugzilla.redhat.com/show_bug.cgi?id=1917075 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2021-05-17 03:08:37 --- Comment #17 from Fedora Update System --- FEDORA-2021-d528e516ba has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1956367] Review Request: rust-asn1 - ASN.1 (DER) parser and writer for Rust
https://bugzilla.redhat.com/show_bug.cgi?id=1956367 Bug 1956367 depends on bug 1956365, which changed state. Bug 1956365 Summary: Review Request: rust-asn1_derive - #[derive] support for asn1 https://bugzilla.redhat.com/show_bug.cgi?id=1956365 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1956365] Review Request: rust-asn1_derive - #[derive] support for asn1
https://bugzilla.redhat.com/show_bug.cgi?id=1956365 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2021-05-17 03:08:22 --- Comment #10 from Fedora Update System --- FEDORA-2021-8dc9949813 has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1960654] Review Request: rust-fn-error-context - Attribute macro to add context to errors from a function
https://bugzilla.redhat.com/show_bug.cgi?id=1960654 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #6 from Fedora Update System --- FEDORA-2021-97c10757a3 has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-97c10757a3 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-97c10757a3 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1960653] Review Request: rust-tzfile - Chrono::TimeZone implementation using system tz database
https://bugzilla.redhat.com/show_bug.cgi?id=1960653 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #5 from Fedora Update System --- FEDORA-2021-92e9a9c632 has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-92e9a9c632 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-92e9a9c632 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1959119] Review Request: rust-serde_fmt - Write any serde::Serialize using the standard formatting APIs
https://bugzilla.redhat.com/show_bug.cgi?id=1959119 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #5 from Fedora Update System --- FEDORA-2021-649f4b0386 has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-649f4b0386 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-649f4b0386 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1959341] Review Request: rust-webpki-roots - Mozilla's CA root certificates for use with webpki
https://bugzilla.redhat.com/show_bug.cgi?id=1959341 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #6 from Fedora Update System --- FEDORA-2021-f898fb78c7 has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-f898fb78c7 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-f898fb78c7 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1960240] Review Request: configsnap - Record and compare system state
https://bugzilla.redhat.com/show_bug.cgi?id=1960240 --- Comment #2 from Christos Triantafyllidis --- Thank you for the review! You are right on all of them :). New spec: https://fedorapeople.org/~ctria/packaging/configsnap/configsnap.spec New SRPM: https://kojipkgs.fedoraproject.org//work/tasks/9535/68079535/configsnap-0.20.1-1.fc35.src.rpm New scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=68080417 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1960654] Review Request: rust-fn-error-context - Attribute macro to add context to errors from a function
https://bugzilla.redhat.com/show_bug.cgi?id=1960654 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #5 from Fedora Update System --- FEDORA-2021-97c10757a3 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-97c10757a3 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1960653] Review Request: rust-tzfile - Chrono::TimeZone implementation using system tz database
https://bugzilla.redhat.com/show_bug.cgi?id=1960653 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #4 from Fedora Update System --- FEDORA-2021-92e9a9c632 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-92e9a9c632 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1960974] Review Request: rust-rustls - Modern TLS library written in Rust
https://bugzilla.redhat.com/show_bug.cgi?id=1960974 --- Comment #1 from Fabio Valentini --- This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=68078174 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1960974] New: Review Request: rust-rustls - Modern TLS library written in Rust
https://bugzilla.redhat.com/show_bug.cgi?id=1960974 Bug ID: 1960974 Summary: Review Request: rust-rustls - Modern TLS library written in Rust Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: decatho...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://decathorpe.fedorapeople.org/rust-rustls.spec SRPM URL: https://decathorpe.fedorapeople.org/rust-rustls-0.19.1-1.fc34.src.rpm Description: Modern TLS library written in Rust. Fedora Account System Username: decathorpe -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1960960] Review Request: sdl12-compat - SDL 1.2 runtime compatibility library using SDL 2.0
https://bugzilla.redhat.com/show_bug.cgi?id=1960960
Carl George 鸞 changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #1 from Carl George 鸞 ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "zlib/libpng license", "*No copyright*
Public domain". 58 files have unknown license. Detailed output of
licensecheck in
/home/carl/packaging/reviews/sdl12-compat/1960960-sdl12-compat/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[-]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]:
[Bug 1959119] Review Request: rust-serde_fmt - Write any serde::Serialize using the standard formatting APIs
https://bugzilla.redhat.com/show_bug.cgi?id=1959119 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #4 from Fedora Update System --- FEDORA-2021-649f4b0386 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-649f4b0386 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1959341] Review Request: rust-webpki-roots - Mozilla's CA root certificates for use with webpki
https://bugzilla.redhat.com/show_bug.cgi?id=1959341 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #5 from Fedora Update System --- FEDORA-2021-f898fb78c7 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-f898fb78c7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1960858] Review Request: maui-mauikit - Kit for developing Maui Apps
https://bugzilla.redhat.com/show_bug.cgi?id=1960858 --- Comment #10 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/maui-mauikit -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1960653] Review Request: rust-tzfile - Chrono::TimeZone implementation using system tz database
https://bugzilla.redhat.com/show_bug.cgi?id=1960653 --- Comment #3 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-tzfile -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1960654] Review Request: rust-fn-error-context - Attribute macro to add context to errors from a function
https://bugzilla.redhat.com/show_bug.cgi?id=1960654 --- Comment #4 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-fn-error-context -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1960880] Review Request: golang-github-lestrrat-apache-logformat - Port of Perl5's Apache::LogFormat::Compiler to golang
https://bugzilla.redhat.com/show_bug.cgi?id=1960880 --- Comment #2 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-lestrrat-apache-logformat -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1960879] Review Request: golang-github-lestrrat-strftime - Fast strftime for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1960879 --- Comment #2 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-lestrrat-strftime -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1960878] Review Request: golang-github-lestrrat-envload - Restore and load environment variables
https://bugzilla.redhat.com/show_bug.cgi?id=1960878 --- Comment #2 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-lestrrat-envload -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1960876] Review Request: golang-github-rodaine-hclencoder - HCL Encoder/Marshaller - Convert Go Types into HCL files
https://bugzilla.redhat.com/show_bug.cgi?id=1960876 --- Comment #2 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-rodaine-hclencoder -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1960823] Review Request: keysmith - OTP client for Plasma Mobile and Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1960823 --- Comment #2 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/keysmith -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1959785] Review Request: applet-window-buttons - Plasma 5 applet to show window buttons in panels
https://bugzilla.redhat.com/show_bug.cgi?id=1959785 --- Comment #3 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/applet-window-buttons -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1954842] Review Request: sndfile-tools - Programs to do interesting things with sound files
https://bugzilla.redhat.com/show_bug.cgi?id=1954842 --- Comment #7 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/sndfile-tools -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1959754] Review Request: rust-cranelift-entity - Data structures using entity references as mapping keys
https://bugzilla.redhat.com/show_bug.cgi?id=1959754 --- Comment #4 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-cranelift-entity -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1959780] Review Request: rust-cranelift-codegen-shared - For code shared between cranelift-codegen-meta and cranelift-codegen
https://bugzilla.redhat.com/show_bug.cgi?id=1959780 --- Comment #4 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-cranelift-codegen-shared -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1959668] Review Request: chess_db - Chess database opening tree indexer
https://bugzilla.redhat.com/show_bug.cgi?id=1959668 --- Comment #4 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/chess_db -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1959341] Review Request: rust-webpki-roots - Mozilla's CA root certificates for use with webpki
https://bugzilla.redhat.com/show_bug.cgi?id=1959341 --- Comment #4 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-webpki-roots -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1959119] Review Request: rust-serde_fmt - Write any serde::Serialize using the standard formatting APIs
https://bugzilla.redhat.com/show_bug.cgi?id=1959119 --- Comment #3 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-serde_fmt -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1959665] Review Request: scoutfish - Chess Query Engine
https://bugzilla.redhat.com/show_bug.cgi?id=1959665 --- Comment #4 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/scoutfish -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1959625] Review Request: rust-cursive - TUI (Text User Interface) library focused on ease-of-use
https://bugzilla.redhat.com/show_bug.cgi?id=1959625 --- Comment #3 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-cursive -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1959622] Review Request: rust-cursive_core - Core components for the Cursive TUI
https://bugzilla.redhat.com/show_bug.cgi?id=1959622 --- Comment #3 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-cursive_core -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1959619] Review Request: rust-wasmer_enumset - Library for creating compact sets of enums
https://bugzilla.redhat.com/show_bug.cgi?id=1959619 --- Comment #3 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-wasmer_enumset -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1959615] Review Request: rust-wasmer_enumset_derive - Internal helper crate for enumset
https://bugzilla.redhat.com/show_bug.cgi?id=1959615 --- Comment #4 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-wasmer_enumset_derive -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1959613] Review Request: rust-enum-map - Map with C-like enum keys represented internally as an array
https://bugzilla.redhat.com/show_bug.cgi?id=1959613 --- Comment #3 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-enum-map -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1959611] Review Request: rust-enum-map-derive - Macros 1.1 implementation of #[derive(Enum)]
https://bugzilla.redhat.com/show_bug.cgi?id=1959611 --- Comment #4 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-enum-map-derive -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1957816] Review Request: kweather - Convergent KDE weather application
https://bugzilla.redhat.com/show_bug.cgi?id=1957816 --- Comment #9 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/kweather -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1957702] Review Request: kweathercore - Library to facilitate retrieval of weather information
https://bugzilla.redhat.com/show_bug.cgi?id=1957702 --- Comment #4 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/kweathercore -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1906980] Review Request: highway - Efficient and performance-portable SIMD
https://bugzilla.redhat.com/show_bug.cgi?id=1906980 --- Comment #25 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/highway -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1960963] New: Review Request: i3-gaps - i3 with more features
https://bugzilla.redhat.com/show_bug.cgi?id=1960963 Bug ID: 1960963 Summary: Review Request: i3-gaps - i3 with more features Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: dan.cer...@cgc-instruments.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://pagure.io/i3-gaps/raw/de9eb34ae4b84a0e2a2f0bf17cca6b243c14a8ae/f/i3-gaps.spec SRPM URL: https://pagure.io/i3-gaps/blob/de9eb34ae4b84a0e2a2f0bf17cca6b243c14a8ae/f/i3-gaps-4.19.1-1.fc34.src.rpm Description: i3 with more features Fedora Account System Username: defolos koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=68070917 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
https://bugzilla.redhat.com/show_bug.cgi?id=587978 Otto Urpelainen changed: What|Removed |Added Flags|needinfo?(otu...@iki.fi)|needinfo?(re...@seznam.cz) --- Comment #34 from Otto Urpelainen --- Commenting only on items where I have something to all, for all others: Thank you for the explanation. (In reply to Michal Ambroz from comment #32) > (In reply to Otto Urpelainen from comment #31) > > > 3. Fixing env shebangs should not be required in Fedora anymore. If this is > > still needed for some reason (RHEL perhaps?), comment should be updated to > > match > > https://docs.fedoraproject.org/en-US/packaging-guidelines/Ruby/#_shebang_lines > > I consider env to be potential security problem and preffer to be explicit > about the interpreter used in the packaged stuff. > The guide is saying as well that it SHOULD use #!/usr/bin/ruby . > The "env ruby" is not always only /usr/bin/ruby. Depending on environment > settings it could be also /usr/local/bin/ruby or ~user/bin/ruby or even > /tmp/you_have_been_hacked/ruby . Ah, I apologize, I worded by comment badly and linked to wrong, only marginally relevant section of the guidelines. What I was trying to say was this: Nowadays, shebang lines are automatically modified to replace env with the correct interpreter, so there should be no need to do that manually. Reference: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_shebang_lines Doing that manually is not forbidden either, so it can stay that way if you prefer. But doing that explicitly does not change the result from what the defaults already do. > > 4. I do not understand this. Is this an issue with upstream man pages? If > > so, a fix or an issue should be submitted and referenced from the specfile. > > > > > # Unknown macros in manpage > > > sed -i -e 's|^.ni||; s|^\./plugins-disabled|+\./plugins-disabled|' > > > whatweb.1 > Yes ... I guess that on Ubuntu they use different groff for formatting the > man pages so it is ok for them. > On Fedora it complains so I have to remove that tags. I see, it may be for the '.ni' case. The './plugins-disabled' is for sure part of the example for enabling and disabling plugin directories. I took a closer look at the upstream whatweb.1, and my interpretation is that the file simply is in a bad shape and would benefit from a PR like this. I encourage submitting fixes. But if you do not want to do that, that's ok too, I won't reject this review for that. Regarding the substitutions: 1. Instead of 's|^.ni||', use 's|^\.ni||', to replace the unknown request '.ni' and not lines starting with 'Ani', 'Bni' etc. 2. Instead of 's|^\./plugins-disabled|+\./plugins-disabled|', use 's|^\./plugins-disabled|\\\./plugins-disabled|'. '+' is not a Groff way to escape '.', but happens to be Whatweb syntax and thus changes the example. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1960960] Review Request: sdl12-compat - SDL 1.2 runtime compatibility library using SDL 2.0
https://bugzilla.redhat.com/show_bug.cgi?id=1960960 Carl George 鸞 changed: What|Removed |Added CC||c...@redhat.com Assignee|nob...@fedoraproject.org|c...@redhat.com Doc Type|--- |If docs needed, set a value Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1960960] New: Review Request: sdl12-compat - SDL 1.2 runtime compatibility library using SDL 2.0
https://bugzilla.redhat.com/show_bug.cgi?id=1960960 Bug ID: 1960960 Summary: Review Request: sdl12-compat - SDL 1.2 runtime compatibility library using SDL 2.0 Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: ngomp...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://ngompa.fedorapeople.org/for-review/sdl12-compat.spec SRPM URL: https://ngompa.fedorapeople.org/for-review/sdl12-compat-0~git.20210515.9f2d88a-1.fc34.src.rpm Description: Simple DirectMedia Layer (SDL) is a cross-platform multimedia library designed to provide fast access to the graphics frame buffer and audio device. This code is a compatibility layer; it provides a binary-compatible API for programs written against SDL 1.2, but it uses SDL 2.0 behind the scenes. If you are writing new code, please target SDL 2.0 directly and do not use this layer. Fedora Account System Username: ngompa -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1960858] Review Request: maui-mauikit - Kit for developing Maui Apps
https://bugzilla.redhat.com/show_bug.cgi?id=1960858 Onuralp SEZER changed: What|Removed |Added Summary|Review Request: |Review Request: |maui-mauikit- Kit for |maui-mauikit - Kit for |developing Maui Apps|developing Maui Apps -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1960858] Review Request: maui-mauikit- Kit for developing Maui Apps
https://bugzilla.redhat.com/show_bug.cgi?id=1960858 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #9 from Robert-André Mauchin --- Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1960858] Review Request: maui-mauikit- Kit for developing Maui Apps
https://bugzilla.redhat.com/show_bug.cgi?id=1960858 --- Comment #8 from Onuralp SEZER --- (In reply to Onuralp SEZER from comment #7) > It is done(I used %exlude way) : > https://pagure.io/Maukit-Packages/blob/main/f/maui-mauikit/maui-mauikit.spec %exclude** way -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1960858] Review Request: maui-mauikit- Kit for developing Maui Apps
https://bugzilla.redhat.com/show_bug.cgi?id=1960858 --- Comment #7 from Onuralp SEZER --- It is done(I used %exlude way) : https://pagure.io/Maukit-Packages/blob/main/f/maui-mauikit/maui-mauikit.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1960858] Review Request: maui-mauikit- Kit for developing Maui Apps
https://bugzilla.redhat.com/show_bug.cgi?id=1960858 --- Comment #6 from Robert-André Mauchin --- I don't know why it isn't working but I'd recommend using %exclude as I initially recommended. (In reply to Onuralp SEZER from comment #2) > According the this change : > https://lists.fedoraproject.org/archives/list/de...@lists.fedoraproject.org/ > message/RWUGI5HAPH6FTM46QUC534ZE4HLMMOSG/ > > I decided to not use excludes but I fixed with a different way. > This change does not apply here, this change prevents using exclude to not include a file in any of the subpackage instead of deleting it at %install. Here we are using it the correct way to dispatch the files between subpackage. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1960858] Review Request: maui-mauikit- Kit for developing Maui Apps
https://bugzilla.redhat.com/show_bug.cgi?id=1960858
--- Comment #5 from Onuralp SEZER ---
When I made changes and add others as well like this;
%files
%license LICENSE
%dir %{_kf5_qmldir}/org/mauikit/
%dir %{_kf5_qmldir}/org/mauikit/controls/
%dir %{_kf5_qmldir}/org/mauikit/controls/labs/
%dir %{_kf5_qmldir}/org/mauikit/controls/plugin/
%dir %{_kf5_qmldir}/org/mauikit/controls/private/
%dir %{_kf5_qmldir}/org/mauikit/controls/private/shapes/
%dir %{_kf5_qmldir}/QtQuick/Controls.2/
%{_kf5_qmldir}/QtQuick/Controls.2/maui-style/
%{_kf5_qmldir}/org/mauikit/controls/*.qml
%{_kf5_qmldir}/org/mauikit/controls/labs/*.qml
%{_kf5_qmldir}/org/mauikit/controls/index.qdoc
%{_kf5_qmldir}/org/mauikit/controls/labs/index.qdoc
%{_kf5_qmldir}/org/mauikit/controls/plugin/*.qml
%{_kf5_qmldir}/org/mauikit/controls/private/*.qml
%{_kf5_qmldir}/org/mauikit/controls/private/shapes/*.qml
%files devel
%doc README.md
%dir %{_includedir}/MauiKit/
%dir %{_libdir}/cmake/MauiKit/
%dir %{_includedir}/MauiKit/Core/
%dir %{_kf5_qmldir}/org/mauikit/controls/
%dir %{_kf5_qmldir}/org/mauikit/controls/csd
%dir %{_kf5_libdir}/qt5/qml/org/mauikit/controls/csd/libappletdecoration/
%dir %{_kf5_qmldir}/org/mauikit/controls/csd/libappletdecoration/
%dir %{_kf5_qmldir}/org/mauikit/controls/libs/
%{_kf5_libdir}/libMauiKit.so
%{_includedir}/MauiKit/Core/*.h
%{_kf5_qmldir}/org/mauikit/controls/libs/*.h
%{_kf5_libdir}/qt5/qml/org/mauikit/controls/qmldir
%{_kf5_libdir}/qt5/qml/org/mauikit/controls/libMauiKit.so
%{_kf5_libdir}/qt5/qml/org/mauikit/controls/csd/libappletdecoration/prefix.sh
%{_kf5_qmldir}/org/mauikit/controls/csd/libappletdecoration/config-decoration.h
%{_libdir}/cmake/MauiKit/MauiKitConfig.cmake
%{_libdir}/cmake/MauiKit/MauiKitConfigVersion.cmake
%{_libdir}/cmake/MauiKit/MauiKitTargets-noconfig.cmake
%{_libdir}/cmake/MauiKit/MauiKitTargets.cmake
This is the review result;
[ ]: Package must own all directories that it creates.
Note: Directories without known owners:
/usr/lib64/qt5/qml/org/mauikit/controls/csd,
/usr/lib64/qt5/qml/org/mauikit/controls/csd/libappletdecoration,
/usr/lib64/qt5/qml/org/mauikit/controls/private/shapes,
/usr/lib64/qt5/qml/org/mauikit/controls/libs,
/usr/include/MauiKit/Core, /usr/lib64/qt5/qml/QtQuick/Controls.2
Any idea for that ?
Thank you.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1960858] Review Request: maui-mauikit- Kit for developing Maui Apps
https://bugzilla.redhat.com/show_bug.cgi?id=1960858
--- Comment #4 from Robert-André Mauchin ---
By doing this you do not own the directories where the files are located:
%dir %{_kf5_qmldir}/org/mauikit/
%dir %{_kf5_qmldir}/org/mauikit/controls/
%dir %{_kf5_qmldir}/org/mauikit/controls/labs/
%dir %{_kf5_qmldir}/org/mauikit/controls/plugin/
%dir %{_kf5_qmldir}/org/mauikit/controls/private/
%dir %{_includedir}/MauiKit/
%dir %{_libdir}/cmake/MauiKit/
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1960858] Review Request: maui-mauikit- Kit for developing Maui Apps
https://bugzilla.redhat.com/show_bug.cgi?id=1960858 --- Comment #3 from Onuralp SEZER --- side note : I pushed all changes into pagure -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1960858] Review Request: maui-mauikit- Kit for developing Maui Apps
https://bugzilla.redhat.com/show_bug.cgi?id=1960858
--- Comment #2 from Onuralp SEZER ---
According the this change :
https://lists.fedoraproject.org/archives/list/de...@lists.fedoraproject.org/message/RWUGI5HAPH6FTM46QUC534ZE4HLMMOSG/
I decided to not use excludes but I fixed with a different way.
%files
%license LICENSE
%{_kf5_qmldir}/QtQuick/Controls.2/maui-style/
%{_kf5_qmldir}/org/mauikit/controls/*.qml
%{_kf5_qmldir}/org/mauikit/controls/labs/*.qml
%{_kf5_qmldir}/org/mauikit/controls/index.qdoc
%{_kf5_qmldir}/org/mauikit/controls/labs/index.qdoc
%{_kf5_qmldir}/org/mauikit/controls/plugin/*.qml
%{_kf5_qmldir}/org/mauikit/controls/private/*.qml
%{_kf5_qmldir}/org/mauikit/controls/private/shapes/*.qml
%files devel
%doc README.md
%{_kf5_libdir}/libMauiKit.so
%{_includedir}/MauiKit/Core/*.h
%{_kf5_qmldir}/org/mauikit/controls/libs/*.h
%{_kf5_libdir}/qt5/qml/org/mauikit/controls/qmldir
%{_kf5_libdir}/qt5/qml/org/mauikit/controls/libMauiKit.so
%{_kf5_libdir}/qt5/qml/org/mauikit/controls/csd/libappletdecoration/prefix.sh
%{_kf5_qmldir}/org/mauikit/controls/csd/libappletdecoration/config-decoration.h
%{_libdir}/cmake/MauiKit/MauiKitConfig.cmake
%{_libdir}/cmake/MauiKit/MauiKitConfigVersion.cmake
%{_libdir}/cmake/MauiKit/MauiKitTargets-noconfig.cmake
%{_libdir}/cmake/MauiKit/MauiKitTargets.cmake
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1946030] Review Request: python-itemadapter - a wrapper for data container objects
https://bugzilla.redhat.com/show_bug.cgi?id=1946030 --- Comment #4 from Eduardo Echeverria --- https://pagure.io/releng/fedora-scm-requests/issue/34020 https://pagure.io/releng/fedora-scm-requests/issue/34021 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1960654] Review Request: rust-fn-error-context - Attribute macro to add context to errors from a function
https://bugzilla.redhat.com/show_bug.cgi?id=1960654 --- Comment #3 from Fabio Valentini --- Good catch! I'll fix that before importing the package. Thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1960849] Review Request: kclock - Clock app for Plasma Mobile
https://bugzilla.redhat.com/show_bug.cgi?id=1960849 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #3 from Robert-André Mauchin --- Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1960859] Review Request: mkdocs-markdownextradata-plugin - MkDocs plugin that injects mkdocs.yml extra variables
https://bugzilla.redhat.com/show_bug.cgi?id=1960859
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |POST
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Doc Type|--- |If docs needed, set a value
Flags||fedora-review+
--- Comment #1 from Robert-André Mauchin ---
Package approved.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "Expat License", "*No copyright* Expat
License". 12 files have unknown license. Detailed output of
licensecheck in /home/bob/packaging/review/mkdocs-markdownextradata-
plugin/review-mkdocs-markdownextradata-plugin/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include
[Bug 1960849] Review Request: kclock - Clock app for Plasma Mobile
https://bugzilla.redhat.com/show_bug.cgi?id=1960849 --- Comment #2 from Onuralp SEZER --- URL replaced https://invent.kde.org/plasma-mobile/kclock License:GPLv2+ (Done) All added. Thank you. > Please add: > > BuildRequires: cmake(Qt5Multimedia) > BuildRequires: cmake(KF5Notifications) > BuildRequires: cmake(KF5CoreAddons) > BuildRequires: cmake(KF5Plasma) > > > -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1960850] Review Request: kf5-kirigami2-addons - Convergent visual components ("widgets") for Kirigami-based applications
https://bugzilla.redhat.com/show_bug.cgi?id=1960850
--- Comment #2 from Onuralp SEZER ---
This is fixed. Thank you for review
%dir %{_kf5_qmldir}/org/kde
%dir %{_kf5_qmldir}/org/kde/kirigamiaddons
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1960858] Review Request: maui-mauikit- Kit for developing Maui Apps
https://bugzilla.redhat.com/show_bug.cgi?id=1960858
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Doc Type|--- |If docs needed, set a value
Flags||fedora-review?
--- Comment #1 from Robert-André Mauchin ---
- Use %exclude here to avoid including files twice + simplify includes
%files
%license LICENSE
%{_kf5_qmldir}/QtQuick/Controls.2/maui-style/
%{_kf5_qmldir}/org/mauikit/
%exclude
%{_kf5_qmldir}/org/mauikit/controls/csd/libappletdecoration/config-decoration.h
%exclude %{_kf5_qmldir}/org/mauikit/controls/libs/appview.h
%exclude %{_kf5_qmldir}/org/mauikit/controls/libs/tabview.h
%files devel
%doc README.md
%{_kf5_libdir}/libMauiKit.so
%{_includedir}/MauiKit/
%{_libdir}/cmake/MauiKit/
%{_kf5_qmldir}/org/mauikit/controls/csd/libappletdecoration/config-decoration.h
%{_kf5_qmldir}/org/mauikit/controls/libs/appview.h
%{_kf5_qmldir}/org/mauikit/controls/libs/tabview.h
- Fix this typo in the description:
maui-mauikit.x86_64: W: spelling-error %description -l en_US amoing -> among,
amounting
- Remove this GIT file:
maui-mauikit.x86_64: E: version-control-internal-file
/usr/lib64/qt5/qml/QtQuick/Controls.2/maui-style/.gitignore
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Header files in -devel subpackage, if present.
Note: maui-mauikit :
/usr/lib64/qt5/qml/org/mauikit/controls/csd/libappletdecoration/config-
decoration.h maui-mauikit :
/usr/lib64/qt5/qml/org/mauikit/controls/libs/appview.h maui-mauikit :
/usr/lib64/qt5/qml/org/mauikit/controls/libs/tabview.h
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/#_devel_packages
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "GNU Lesser General Public License,
Version 3", "GNU Library General Public License v2 or later", "GNU
Lesser General Public License, Version 3 GNU General Public License
v2.0 or later", "GNU General Public License v3.0 or later", "GNU
General Public License, Version 3", "GNU General Public License v2.0
or later", "GNU General Public License, Version 2". 189 files have
unknown license. Detailed output of licensecheck in
/home/bob/packaging/review/maui-mauikit/review-maui-
mauikit/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: Package requires other packages for directories it uses.
Note: No known owner of /usr/lib64/cmake/MauiKit,
/usr/include/MauiKit, /usr/include/MauiKit/Core
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[Bug 1960850] Review Request: kf5-kirigami2-addons - Convergent visual components ("widgets") for Kirigami-based applications
https://bugzilla.redhat.com/show_bug.cgi?id=1960850
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |POST
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Doc Type|--- |If docs needed, set a value
Flags||fedora-review+
--- Comment #1 from Robert-André Mauchin ---
- Use %dir to avoid including files multiple times:
%dir %{_kf5_qmldir}/org/kde
%dir %{_kf5_qmldir}/org/kde/kirigamiaddons
Package approved. Please fix the aforementioned issue before import.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
- Package does not contain duplicates in %files.
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "GNU General Public License, Version
2", "GNU Library General Public License, Version 2.0", "GNU Lesser
General Public License, Version 3", "*No copyright* GNU General Public
License, Version 3", "*No copyright* GNU General Public License,
Version 2". 44 files have unknown license. Detailed output of
licensecheck in
/home/bob/packaging/review/kf5-kirigami2-addons/review-
kf5-kirigami2-addons/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by:
/usr/lib64/qt5/qml/org/kde(kf5-kirigami, kf5-kdeclarative,
kf5-kirigami2, kf5-plasma, kf5-knewstuff)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Dist tag is present.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the
[Bug 1960849] Review Request: kclock - Clock app for Plasma Mobile
https://bugzilla.redhat.com/show_bug.cgi?id=1960849 Robert-André Mauchin changed: What|Removed |Added Status|NEW |ASSIGNED CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Doc Type|--- |If docs needed, set a value Flags||fedora-review? --- Comment #1 from Robert-André Mauchin --- - the URL is 404: https://invent.kde.org/utilities/kclock It should be: Url:https://invent.kde.org/plasma-mobile/kclock - License should be GPLv2+ License:GPLv2+ - Build error: CMake Error at /usr/lib64/cmake/Qt5/Qt5Config.cmake:28 (find_package): Could not find a package configuration file provided by "Qt5Multimedia" with any of the following names: Qt5MultimediaConfig.cmake qt5multimedia-config.cmake Add the installation prefix of "Qt5Multimedia" to CMAKE_PREFIX_PATH or set "Qt5Multimedia_DIR" to a directory containing one of the above files. If "Qt5Multimedia" provides a separate development package or SDK, be sure it has been installed. - Build error 2: - Could NOT find KF5Notifications (missing: KF5Notifications_DIR) -- Could NOT find KF5Notifications: found neither KF5NotificationsConfig.cmake nor kf5notifications-config.cmake -- Found KF5DBusAddons: /usr/lib64/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version "5.82.0") CMake Error at /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:230 (message): Could NOT find KF5 (missing: Config CoreAddons Plasma Notifications) (found suitable version "5.82.0", minimum required is "5.79.0") Please add: BuildRequires: cmake(Qt5Multimedia) BuildRequires: cmake(KF5Notifications) BuildRequires: cmake(KF5CoreAddons) BuildRequires: cmake(KF5Plasma) Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed = MUST items = C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License, Version 2", "GNU Library General Public License v2 or later". 67 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/kclock/review-kclock/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for
[Bug 1960823] Review Request: keysmith - OTP client for Plasma Mobile and Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1960823
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |POST
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Doc Type|--- |If docs needed, set a value
Flags||fedora-review+
--- Comment #1 from Robert-André Mauchin ---
Package approved.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "BSD 2-clause "Simplified" License",
"Creative Commons Attribution-ShareAlike 4.0 International License",
"*No copyright* Creative Commons CC0 Universal 1.0 Public Domain
Dedication", "GNU Lesser General Public License, Version 2.1", "GNU
Lesser General Public License, Version 3", "*No copyright* GNU Lesser
General Public License, Version 3". 208 files have unknown license.
Detailed output of licensecheck in
/home/bob/packaging/review/keysmith/review-keysmith/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license
[Bug 1960653] Review Request: rust-tzfile - Chrono::TimeZone implementation using system tz database
https://bugzilla.redhat.com/show_bug.cgi?id=1960653 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Doc Type|--- |If docs needed, set a value Flags||fedora-review+ --- Comment #2 from Robert-André Mauchin --- - License ok - Latest version packaged - Builds in mock - No rpmlint errors - Conforms to Packaging Guidelines Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1960654] Review Request: rust-fn-error-context - Attribute macro to add context to errors from a function
https://bugzilla.redhat.com/show_bug.cgi?id=1960654 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Doc Type|--- |If docs needed, set a value Flags||fedora-review+ --- Comment #2 from Robert-André Mauchin --- - Please fix the line encodings: rust-fn-error-context-devel.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/rust-fn-error-context-devel/CHANGELOG.md rust-fn-error-context-devel.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/rust-fn-error-context-devel/README.md - License ok - Latest version packaged - Builds in mock - Conforms to Packaging Guidelines Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1960240] Review Request: configsnap - Record and compare system state
https://bugzilla.redhat.com/show_bug.cgi?id=1960240
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Doc Type|--- |If docs needed, set a value
Flags||fedora-review?
--- Comment #1 from Robert-André Mauchin ---
- Should be pythonX-devel here:
%if 0%{?rhel} >= 8 || 0%{?fedora}
BuildRequires: python3-devel
%else
BuildRequires: python2-devel
%endif
- You include additional.conf twice doing this:
%config(noreplace) %{_sysconfdir}/%{name}/additional.conf
%{_sysconfdir}/%{name}
Instead use the %dir directive for the folder:
%dir %{_sysconfdir}/%{name}
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package does not contain duplicates in %files.
Note: warning: File listed twice: /etc/configsnap/additional.conf
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/#_duplicate_files
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "*No copyright* Apache License 2.0",
"Apache License 2.0". 20 files have unknown license. Detailed output
of licensecheck in /home/bob/packaging/review/configsnap/review-
configsnap/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[-]: Description
[Bug 1960876] Review Request: golang-github-rodaine-hclencoder - HCL Encoder/Marshaller - Convert Go Types into HCL files
https://bugzilla.redhat.com/show_bug.cgi?id=1960876 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #1 from Robert-André Mauchin --- - License ok - Latest version packaged - Builds in mock - No rpmlint errors - Conforms to Packaging Guidelines Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1960880] Review Request: golang-github-lestrrat-apache-logformat - Port of Perl5's Apache::LogFormat::Compiler to golang
https://bugzilla.redhat.com/show_bug.cgi?id=1960880 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #1 from Robert-André Mauchin --- - License ok - Latest version packaged - Builds in mock - No rpmlint errors - Conforms to Packaging Guidelines Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1960879] Review Request: golang-github-lestrrat-strftime - Fast strftime for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1960879 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #1 from Robert-André Mauchin --- - License ok - Latest version packaged - Builds in mock - No rpmlint errors - Conforms to Packaging Guidelines Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1960878] Review Request: golang-github-lestrrat-envload - Restore and load environment variables
https://bugzilla.redhat.com/show_bug.cgi?id=1960878 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #1 from Robert-André Mauchin --- - License ok - Latest version packaged - Builds in mock - No rpmlint errors - Conforms to Packaging Guidelines Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
https://bugzilla.redhat.com/show_bug.cgi?id=587978 --- Comment #33 from Mamoru TASAKA --- (In reply to Otto Urpelainen from comment #31) > 3. Fixing env shebangs should not be required in Fedora anymore. If this is > still needed for some reason (RHEL perhaps?), comment should be updated to > match > > > # Fedora using Rubypick > > sed -i -e 's|#!/usr/bin/env ruby|#!/usr/bin/ruby|; s|#!/bin/env > > ruby|#!/usr/bin/ruby|;' \ > whatweb plugin-development/find-common-stuff > plugin-development/get-pattern > > Reference: > https://docs.fedoraproject.org/en-US/packaging-guidelines/Ruby/ > #_shebang_lines > This does not say using env on shabang is permitted. The above guideline says when the package really needs jruby, you can write "#!/usr/bin/jruby" on shebang (but I don't think jruby on Fedora is well-maintained). All other should use "#!/usr/bin/ruby" on shebang. Anyway env should not be used on shebang. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1954842] Review Request: sndfile-tools - Programs to do interesting things with sound files
https://bugzilla.redhat.com/show_bug.cgi?id=1954842 --- Comment #6 from Guido Aulisi --- I missed the latest patch, now it's all ok. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1954842] Review Request: sndfile-tools - Programs to do interesting things with sound files
https://bugzilla.redhat.com/show_bug.cgi?id=1954842 --- Comment #5 from Guido Aulisi --- sndfile-spectrogram test still reports 0 errors, x bytes leaked valgrind bin/sndfile-spectrogram : 0 errors, 256 bytes leaked so I cannot simplify the checks. I will add the missing man page. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
