[Bug 1004029] Review Request: ovirt-engine-sdk - oVirt Engine Software Development Kit (Python)
https://bugzilla.redhat.com/show_bug.cgi?id=1004029
Christopher Meng cicku...@gmail.com changed:
What|Removed |Added
CC||cicku...@gmail.com
--- Comment #2 from Christopher Meng cicku...@gmail.com ---
1. No need to import setup.py nowadays.
Just
%{__python} setup.py build
2. Remove %defattr(-,root,root,-)
3. BR BuildRequires: python-setuptools-devel is incorrect. should be
BuildRequires: python-setuptools
4. No need to attr() if the permission is sane.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=dMYtUAPHfJa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004029] Review Request: ovirt-engine-sdk - oVirt Engine Software Development Kit (Python)
https://bugzilla.redhat.com/show_bug.cgi?id=1004029 --- Comment #3 from Juan Hernández juan.hernan...@redhat.com --- Thanks for your comments Christopher. I have updated the spec accordingly: Spec URL: http://jhernand.fedorapeople.org/rpms/ovirt-engine-sdk-python/3.3.0.6-2/ovirt-engine-sdk-python.spec SRPM URL: http://jhernand.fedorapeople.org/rpms/ovirt-engine-sdk-python/3.3.0.6-2/ovirt-engine-sdk-python-3.3.0.6-2.fc19.src.rpm The updated spec builds correctly in Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=5892889 I also suggested the same modifications to the spec used by the upstream maintainer (this spec is basically a copy of that): http://gerrit.ovirt.org/18868 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=OCh4chrtqFa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004029] Review Request: ovirt-engine-sdk - oVirt Engine Software Development Kit (Python)
https://bugzilla.redhat.com/show_bug.cgi?id=1004029 Christopher Meng cicku...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|cicku...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NWuI1i5SPea=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004029] Review Request: ovirt-engine-sdk - oVirt Engine Software Development Kit (Python)
https://bugzilla.redhat.com/show_bug.cgi?id=1004029 --- Comment #1 from Juan Hernández juan.hernan...@redhat.com --- The package builds correctly in koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=5887911 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=l5gU4bUTpNa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
