[Bug 1063038] Review Request: rubygem-cookiejar - The Ruby CookieJar is a library to help manage client-side cookies in pure Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1063038 Vít Ondruch changed: What|Removed |Added Status|ON_QA |CLOSED CC||vondr...@redhat.com Resolution|--- |CURRENTRELEASE Last Closed||2018-05-03 03:29:05 --- Comment #17 from Vít Ondruch --- This has been in Fedora for ages already. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1063038] Review Request: rubygem-cookiejar - The Ruby CookieJar is a library to help manage client-side cookies in pure Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1063038 Bugzilla account termination changed: What|Removed |Added Assignee|mmo...@redhat.com |nob...@fedoraproject.org -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1063038] Review Request: rubygem-cookiejar - The Ruby CookieJar is a library to help manage client-side cookies in pure Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1063038 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #15 from Fedora Update System --- rubygem-cookiejar-0.3.2-5.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1063038] Review Request: rubygem-cookiejar - The Ruby CookieJar is a library to help manage client-side cookies in pure Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1063038 --- Comment #14 from Fedora Update System --- rubygem-cookiejar-0.3.2-5.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/rubygem-cookiejar-0.3.2-5.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1063038] Review Request: rubygem-cookiejar - The Ruby CookieJar is a library to help manage client-side cookies in pure Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1063038 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1063038] Review Request: rubygem-cookiejar - The Ruby CookieJar is a library to help manage client-side cookies in pure Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1063038 --- Comment #13 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1063038] Review Request: rubygem-cookiejar - The Ruby CookieJar is a library to help manage client-side cookies in pure Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1063038 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1063038] Review Request: rubygem-cookiejar - The Ruby CookieJar is a library to help manage client-side cookies in pure Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1063038 Nitesh Narayan Lal changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1063038] Review Request: rubygem-cookiejar - The Ruby CookieJar is a library to help manage client-side cookies in pure Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1063038 Nitesh Narayan Lal changed: What|Removed |Added CC||niteshnarayanlalleo@gmail.c ||om --- Comment #12 from Nitesh Narayan Lal --- New Package SCM Request === Package Name:rubygem-cookiejar Short Description:The Ruby CookieJar is a library to help manage client-side cookies in pure Ruby Upstream URL: https://github.com/dwaite/cookiejar Owners: niteshnarayan, mmorsi Branches: f19 f20 f21 el6 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1063038] Review Request: rubygem-cookiejar - The Ruby CookieJar is a library to help manage client-side cookies in pure Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1063038 Mo Morsi changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1063038] Review Request: rubygem-cookiejar - The Ruby CookieJar is a library to help manage client-side cookies in pure Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1063038 --- Comment #11 from Nitesh Narayan Lal --- Final Changes made. SPEC:http://niteshnarayan.fedorapeople.org/SPECS/rubygem-cookiejar.spec SRPM:http://niteshnarayan.fedorapeople.org/SRPMS/rubygem-cookiejar-0.3.2-5.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1063038] Review Request: rubygem-cookiejar - The Ruby CookieJar is a library to help manage client-side cookies in pure Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1063038 --- Comment #10 from Mo Morsi --- Note, while I linked the draft guidelines, they have been approved and are just pending the move over to the main ruby guidelines page on the Fedora wiki: https://fedorahosted.org/fpc/ticket/409 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1063038] Review Request: rubygem-cookiejar - The Ruby CookieJar is a library to help manage client-side cookies in pure Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1063038 --- Comment #9 from Mo Morsi --- Went through this and compared it to the updated guidelines for rawhide https://fedoraproject.org/w/index.php?title=PackagingDrafts%2FRuby From what I see the only change that is needed is removing the automatic requires. If you are just submitting this to rawhide you can remove the following completely: Requires: ruby(release) Requires: rubygems As well as Provides: rubygem(%{gem_name}) = %{version} If you plan on including this package in F19 & F20, you will need to add the conditional around these, similar to here: https://bugzilla.redhat.com/show_bug.cgi?id=1063040 Other than that the spec still looks good. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1063038] Review Request: rubygem-cookiejar - The Ruby CookieJar is a library to help manage client-side cookies in pure Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1063038 --- Comment #8 from Nitesh Narayan Lal --- SPECS:http://niteshnarayan.fedorapeople.org/SPECS/rubygem-cookiejar.spec SRPM:http://niteshnarayan.fedorapeople.org/SRPMS/rubygem-cookiejar-0.3.1-3.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1063038] Review Request: rubygem-cookiejar - The Ruby CookieJar is a library to help manage client-side cookies in pure Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1063038 --- Comment #7 from Mo Morsi --- Looks good. Please make sure to add a comment w/ the full url to the final spec and srpm. Also going forward you may want to include more descriptive changelog entries than "update to comply with fedora guidelines". This package is fine, but something like "fix requirements" or "made __ specific change" for future changes / packages might be a good idea. Email'd a sponsor to inquire about getting your sponsorship (cc'd you). We can take that aspect from there. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1063038] Review Request: rubygem-cookiejar - The Ruby CookieJar is a library to help manage client-side cookies in pure Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1063038 --- Comment #6 from Nitesh Narayan Lal --- Hi, I had modified the spec as per the suggestions: SPECS:http://niteshnarayan.fedorapeople.org/SPECS/rubygem-cookiejar.spec SRPM:niteshnarayan.fedorapeople.org/SRPMS/rubygem-cookiejar-0.3.1-3.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1063038] Review Request: rubygem-cookiejar - The Ruby CookieJar is a library to help manage client-side cookies in pure Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1063038 Mo Morsi changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #5 from Mo Morsi --- Everything looks good nitesh save one nit, the 'Requires: ruby(rubygems)' should be 'Requires: rubygems'. Other than that fedora-review looks good (see below), package builds in koji, and satisfies guidelines. http://koji.fedoraproject.org/koji/taskinfo?taskID=6629677 Giving you the ACK provided you make that change (please upload the final version here w/ the new release / changelog entry) Note you still need sponsorship before this can make it in, we can sort that our via irc / email and/or continue working on packages. Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: === - gems should require rubygems package Note: Requires: rubygems missing in rubygem-cookiejar-doc See: http://fedoraproject.org/wiki/Packaging:Ruby#RubyGems = MUST items = Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 7 files have unknown license. Detailed output of licensecheck in /home/mmorsi/workspace/fedora/rubygem-cookiejar/1063038 -rubygem-cookiejar/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/gems/gems/cookiejar-0.3.1/spec [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/gems, /usr/share/gems/doc, /usr/share/gems/gems/cookiejar-0.3.1/spec [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Ruby: [ ]: Platform dependent files must all go under %{gem_extdir_mri}, platform independent under %{gem_dir}. [x]: Gem package must not define a non-gem subpackage [x]: Macro %{gem_extdir} is deprecated. [x]: Gem package is named rubygem-%{gem_n
[Bug 1063038] Review Request: rubygem-cookiejar - The Ruby CookieJar is a library to help manage client-side cookies in pure Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1063038 --- Comment #4 from Nitesh Narayan Lal --- Hi, I had updated the SPECS, thanks for holding on with this and helping. SPEC:http://niteshnarayan.fedorapeople.org/SPECS/rubygem-cookiejar.spec SRPMS:http://niteshnarayan.fedorapeople.org/SRPMS/rubygem-cookiejar-0.3.1-2.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1063038] Review Request: rubygem-cookiejar - The Ruby CookieJar is a library to help manage client-side cookies in pure Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1063038 --- Comment #3 from Mo Morsi --- Hey Nitesh some more comments: - Please rename the spec to 'rubygem-cookiejar.spec' so fedora-review will pick it up (srry for any confusion about this before) - Please bump the release up top (the next on should be 3) - Similarly please cleanup the changelog at the bottom, you should have an entry for each release w/ comments. The list should be in reverse chronological order, eg newest first to oldest last - The rspec command in the %check section should be "rspec -Ilib spec" - contributors.json should be rm'd or excluded - The "%{gem_instdir}/spec/*" under the files list should be replaced with "%doc %{gem_instdir}/spec/" - %{gem_cache} should be %exclude'd - the LICENSE file should be part of the main package and marked as %doc -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1063038] Review Request: rubygem-cookiejar - The Ruby CookieJar is a library to help manage client-side cookies in pure Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1063038 --- Comment #2 from Nitesh Narayan Lal --- Thanks for your comments, I had made the modifications as per your suggestions. SPEC:http://niteshnarayan.fedorapeople.org/SPECS/rubygem-cookiejar-0.3.1.spec SRPM:http://niteshnarayan.fedorapeople.org/SRPMS/rubygem-cookiejar-0.3.1-1.fc19.src.rpm Summary: Changed the License & corrected the URL along with the updated version of the package -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1063038] Review Request: rubygem-cookiejar - The Ruby CookieJar is a library to help manage client-side cookies in pure Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1063038 Mo Morsi changed: What|Removed |Added Status|NEW |ASSIGNED CC||mmo...@redhat.com Assignee|nob...@fedoraproject.org|mmo...@redhat.com Flags||fedora-review? --- Comment #1 from Mo Morsi --- Taking this one. Couple initial things: - Spec has the wrong URL (for amq-protocol) - License should be BSD - 0.3.1 just released, please update package to that (release would be 1 for the new version) - Package builds fine in koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=6551588 Will give you the official review after these changes. Thanks -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1063038] Review Request: rubygem-cookiejar - The Ruby CookieJar is a library to help manage client-side cookies in pure Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1063038 Michael Scherer changed: What|Removed |Added CC||m...@zarb.org Summary|Review Request: |Review Request: |rubygem-cookiejar - he Ruby |rubygem-cookiejar - The |CookieJar is a library to |Ruby CookieJar is a library |help manage client-side |to help manage client-side |cookies in pure Ruby|cookies in pure Ruby -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review