[Bug 1100477] Review Request: python-natsort - Python library that sorts lists using the natural order sort
https://bugzilla.redhat.com/show_bug.cgi?id=1100477 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|python-natsort-3.5.1-1.fc21 |python-natsort-3.5.1-1.fc20 --- Comment #15 from Fedora Update System upda...@fedoraproject.org --- python-natsort-3.5.1-1.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1100477] Review Request: python-natsort - Python library that sorts lists using the natural order sort
https://bugzilla.redhat.com/show_bug.cgi?id=1100477 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||python-natsort-3.5.1-1.fc21 Resolution|--- |ERRATA Last Closed||2014-10-03 00:02:27 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- python-natsort-3.5.1-1.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1100477] Review Request: python-natsort - Python library that sorts lists using the natural order sort
https://bugzilla.redhat.com/show_bug.cgi?id=1100477 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- Package python-natsort-3.5.1-1.fc21: * should fix your issue, * was pushed to the Fedora 21 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing python-natsort-3.5.1-1.fc21' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2014-11578/python-natsort-3.5.1-1.fc21 then log in and leave karma (feedback). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1100477] Review Request: python-natsort - Python library that sorts lists using the natural order sort
https://bugzilla.redhat.com/show_bug.cgi?id=1100477 José Matos jama...@fc.up.pt changed: What|Removed |Added Flags||fedora-cvs? --- Comment #8 from José Matos jama...@fc.up.pt --- I will take of the issues that you raised during in the next updates. Thank you. New Package SCM Request === Package Name: python-natsort Short Description: python library that sorts lists using the natural order sort Upstream URL: https://github.com/SethMMorton/natsort Owners: jamatos Branches: f19 f20 f21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1100477] Review Request: python-natsort - Python library that sorts lists using the natural order sort
https://bugzilla.redhat.com/show_bug.cgi?id=1100477 --- Comment #9 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1100477] Review Request: python-natsort - Python library that sorts lists using the natural order sort
https://bugzilla.redhat.com/show_bug.cgi?id=1100477 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1100477] Review Request: python-natsort - Python library that sorts lists using the natural order sort
https://bugzilla.redhat.com/show_bug.cgi?id=1100477 --- Comment #10 from José Matos jama...@fc.up.pt --- The package is imported in rawhide and I have updated it to the latest stable release 3.5.1 and I have added the %check section as required. The next step is to issue updates to f19, f20 and f21. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1100477] Review Request: python-natsort - Python library that sorts lists using the natural order sort
https://bugzilla.redhat.com/show_bug.cgi?id=1100477 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1100477] Review Request: python-natsort - Python library that sorts lists using the natural order sort
https://bugzilla.redhat.com/show_bug.cgi?id=1100477 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- python-natsort-3.5.1-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/python-natsort-3.5.1-1.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1100477] Review Request: python-natsort - Python library that sorts lists using the natural order sort
https://bugzilla.redhat.com/show_bug.cgi?id=1100477 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- python-natsort-3.5.1-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/python-natsort-3.5.1-1.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1100477] Review Request: python-natsort - Python library that sorts lists using the natural order sort
https://bugzilla.redhat.com/show_bug.cgi?id=1100477 Pete Travis m...@petetravis.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1100477] Review Request: python-natsort - Python library that sorts lists using the natural order sort
https://bugzilla.redhat.com/show_bug.cgi?id=1100477
Pete Travis m...@petetravis.com changed:
What|Removed |Added
Assignee|i...@cicku.me |m...@petetravis.com
Flags||fedora-review?
--- Comment #6 from Pete Travis m...@petetravis.com ---
Okay, not *soon* but:
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
[+] = Manual review pass
[0] = Manual review fail
= MUST items =
Generic:
[+]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[+]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Unknown or generated. 12 files have unknown license. Detailed output of
licensecheck in /home/pete/1100477-python-natsort/licensecheck.txt
[+]: License file installed when any subpackage combination is installed.
[+]: Package contains no bundled libraries without FPC exception.
[+]: Changelog in prescribed format.
[+]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[+]: Package uses nothing in %doc for runtime.
[+]: Package consistently uses macros (instead of hard-coded directory names).
[+]: Package is named according to the Package Naming Guidelines.
[+]: Package does not generate any conflict.
[+]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[+]: Requires correct, justified where necessary.
[+]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[+]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 61440 bytes in 4 files.
[+]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[+]: Python eggs must not download any dependencies during the build process.
[+]: A package which is used by another package via an egg interface should
provide egg info.
[+]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[+]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
python3-natsort
[+]: Package functions as described.
[+]: Latest version is packaged.
[+]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[+]: Package should compile and build into binary rpms on
[Bug 1100477] Review Request: python-natsort - Python library that sorts lists using the natural order sort
https://bugzilla.redhat.com/show_bug.cgi?id=1100477 --- Comment #7 from Pete Travis m...@petetravis.com --- No packaging complaints. Upstream has released 3.3.0, but it doesn't look like anything that will need to be addressed in the spec - besides the addition of a couple unit tests, and I'm not going to block the review for their inclusion. APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1100477] Review Request: python-natsort - Python library that sorts lists using the natural order sort
https://bugzilla.redhat.com/show_bug.cgi?id=1100477 --- Comment #5 from Pete Travis m...@petetravis.com --- I might grab this soon if I have some time for a thorough review. In the meantime, minor nitpick - you might mention the binary in the description as well. It gives the impression of a handy python library as-is, but I can think of a lot of situations where I'd like to work this kind of sorting into a bash script too. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1100477] Review Request: python-natsort - Python library that sorts lists using the natural order sort
https://bugzilla.redhat.com/show_bug.cgi?id=1100477 --- Comment #4 from José Matos jama...@fc.up.pt --- 1) I have replaced __python by __python2, thanks for the note. I think that it is overkill to provide both binaries. What would it be the purpose if they are functionally identical? My intent is to have the default python version to provide the binary. 2) fixed the typo in the python3-natsort %file section, my fault. A new iteration is available: Spec URL: http://jamatos.fedorapeople.org/python-natsort.spec SRPM URL: http://jamatos.fedorapeople.org/python-natsort-3.2.0-2.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1100477] Review Request: python-natsort - Python library that sorts lists using the natural order sort
https://bugzilla.redhat.com/show_bug.cgi?id=1100477
--- Comment #3 from Christopher Meng i...@cicku.me ---
1. %{__python} -- %{__python2}
2. %files
%{_bindir}/natsort
%doc LICENSE
%doc README.rst
%{python_sitelib}/natsort
%{python_sitelib}/natsort-%{version}-py*.egg-info
%files -n python3-natsort
%doc LICENSE
%doc README.rst
%{python_sitelib}/natsort
%{python_sitelib}/natsort-%{version}-py*.egg-info
1) You should also provide a bin in python3 subpkg.
2) %files -n python3-natsort
%doc LICENSE
%doc README.rst
%{python_sitelib}/natsort
%{python_sitelib}/natsort-%{version}-py*.egg-info
Still %{python_sitelib} ???
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1100477] Review Request: python-natsort - Python library that sorts lists using the natural order sort
https://bugzilla.redhat.com/show_bug.cgi?id=1100477 Pete Travis m...@petetravis.com changed: What|Removed |Added CC||m...@petetravis.com --- Comment #2 from Pete Travis m...@petetravis.com --- Fun, bugzilla was down for a bit earlier today and I threw together a spec file for this while I was waiting for it to come back up. Your version is cleaner, José :) Christopher, have you had time to look at this yet? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1100477] Review Request: python-natsort - Python library that sorts lists using the natural order sort
https://bugzilla.redhat.com/show_bug.cgi?id=1100477 --- Comment #1 from José Matos jama...@fc.up.pt --- Required for nikola 7.0 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1100477] Review Request: python-natsort - Python library that sorts lists using the natural order sort
https://bugzilla.redhat.com/show_bug.cgi?id=1100477 Christopher Meng i...@cicku.me changed: What|Removed |Added Status|NEW |ASSIGNED CC||i...@cicku.me Assignee|nob...@fedoraproject.org|i...@cicku.me -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
