[Bug 1121924] Review Request: perl-Term-ANSIColor - Color screen output using ANSI escape sequences

2014-08-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1121924

David Dick dd...@cpan.org changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |NEXTRELEASE
Last Closed||2014-08-14 06:05:14



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1121924] Review Request: perl-Term-ANSIColor - Color screen output using ANSI escape sequences

2014-08-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1121924



--- Comment #19 from Jitka Plesnikova jples...@redhat.com ---
(In reply to David Dick from comment #17)
 Okay.  Ticket has been raised at https://fedorahosted.org/rel-eng/ticket/5965

You should not delete the package from f21/rawhide branches. The
perl-Term-ANSIColor was already sub-package and mark as a dual-life at perl. 
The rawhide and f21 branches are broken now, because the package was removed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1121924] Review Request: perl-Term-ANSIColor - Color screen output using ANSI escape sequences

2014-08-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1121924



--- Comment #20 from David Dick dd...@cpan.org ---
Sorry Jitka.  Do i need to re-add the package in f21/master?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1121924] Review Request: perl-Term-ANSIColor - Color screen output using ANSI escape sequences

2014-08-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1121924



--- Comment #21 from Jitka Plesnikova jples...@redhat.com ---
(In reply to David Dick from comment #20)
 Sorry Jitka.  Do i need to re-add the package in f21/master?

Yes, please re-add them.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1121924] Review Request: perl-Term-ANSIColor - Color screen output using ANSI escape sequences

2014-08-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1121924



--- Comment #22 from David Dick dd...@cpan.org ---
done.

master at http://koji.fedoraproject.org/koji/taskinfo?taskID=7271628

f21 at http://koji.fedoraproject.org/koji/taskinfo?taskID=7271689

is this ok now?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1121924] Review Request: perl-Term-ANSIColor - Color screen output using ANSI escape sequences

2014-08-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1121924

Peter H. Jones jo...@er.uqam.ca changed:

   What|Removed |Added

 CC||jo...@er.uqam.ca



--- Comment #23 from Peter H. Jones jo...@er.uqam.ca ---
http://koji.fedoraproject.org/koji/tasks?state=allview=flatmethod=createLiveCDorder=-id

shows all Xfce builds as successfull (Aug 11, 2014). Thanks for the fix.

Some other builds have failed. The tail of livecd.log shows which requires
resulted in the failure.

Also posted this information to bug 1016251, which is closed, after being
scolded for posting my initial report there (see
https://bugzilla.redhat.com/show_bug.cgi?id=1016251#c2).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1121924] Review Request: perl-Term-ANSIColor - Color screen output using ANSI escape sequences

2014-08-09 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1121924



--- Comment #17 from David Dick dd...@cpan.org ---
Okay.  Ticket has been raised at https://fedorahosted.org/rel-eng/ticket/5965

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1121924] Review Request: perl-Term-ANSIColor - Color screen output using ANSI escape sequences

2014-08-09 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1121924

Till Maas opensou...@till.name changed:

   What|Removed |Added

 CC||opensou...@till.name



--- Comment #18 from Till Maas opensou...@till.name ---
(In reply to David Dick from comment #15)

 $ fedpkg retire Package incorrectly added to fedora. Already provided by
 perl
 Could not retire package: 'Namespace' object has no attribute 'msg'
 ERROR:rpkg:Could not retire package: 'Namespace' object has no attribute
 'msg'
 
 What have i done wrong?

You need to use fedpkg from updates-testing, hopefully it will get to stable
soon.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1121924] Review Request: perl-Term-ANSIColor - Color screen output using ANSI escape sequences

2014-08-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1121924

David Dick dd...@cpan.org changed:

   What|Removed |Added

 Blocks|1123583 |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1123583
[Bug 1123583] Review Request: perl-Data-Printer - Pretty printer for Perl
data structures
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1121924] Review Request: perl-Term-ANSIColor - Color screen output using ANSI escape sequences

2014-08-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1121924



--- Comment #16 from Paul Howarth p...@city-fan.org ---
I think regular packagers can only retire things in rawhide; other branches
will need a rel-eng ticket.

https://fedorahosted.org/rel-eng/report

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1121924] Review Request: perl-Term-ANSIColor - Color screen output using ANSI escape sequences

2014-08-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1121924



--- Comment #15 from David Dick dd...@cpan.org ---
This seems to be harder than i thought.

Following the instructions at
https://fedoraproject.org/wiki/How_to_remove_a_package_at_end_of_life

$ fedpkg switch-branch el6
Switched to branch 'el6'
INFO:rpkg:Switched to branch 'el6'
$ fedpkg retire Package incorrectly added to fedora. Already provided by perl
Could not retire package: 'Namespace' object has no attribute 'msg'
ERROR:rpkg:Could not retire package: 'Namespace' object has no attribute 'msg'

What have i done wrong?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1121924] Review Request: perl-Term-ANSIColor - Color screen output using ANSI escape sequences

2014-07-29 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1121924

Paul Howarth p...@city-fan.org changed:

   What|Removed |Added

 CC||p...@city-fan.org



--- Comment #10 from Paul Howarth p...@city-fan.org ---
Surely this package is replacing a core perl module in both Fedora (where it is
not sub-packaged from the main perl package) and RHEL (where replacing RHEL
functionality is not allowed by EPEL guidelines)?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1121924] Review Request: perl-Term-ANSIColor - Color screen output using ANSI escape sequences

2014-07-29 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1121924



--- Comment #11 from David Dick dd...@cpan.org ---
It does appear so.  What do i need to do to fix this?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1121924] Review Request: perl-Term-ANSIColor - Color screen output using ANSI escape sequences

2014-07-29 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1121924



--- Comment #12 from Paul Howarth p...@city-fan.org ---
It should be possible to coordinate with Petr/Jitka to get it sub-packaged in
Fedora like any other dual-lived package.

As for EPEL, I think you'll need to retire it; whilst it may get sub-packaged
in EL-8 if Fedora does so, you're still not allowed to replace it. This will
probably need a rel-eng ticket. Wait and see what Petr/Jitka have to say about
Fedora first though, in case you need to retire that as well for some reason.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1121924] Review Request: perl-Term-ANSIColor - Color screen output using ANSI escape sequences

2014-07-29 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1121924



--- Comment #13 from Jitka Plesnikova jples...@redhat.com ---
I'll create the sub-package at Fedora 21 and Fedora rawhide. 

Could you retired f20 branch and remove perl-Term-ANSIColor-4.03-1.fc20 update? 
The module is provided by perl, so it should not cause any problem.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1121924] Review Request: perl-Term-ANSIColor - Color screen output using ANSI escape sequences

2014-07-29 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1121924



--- Comment #14 from David Dick dd...@cpan.org ---
Okay.  Would be happy to retire it totally if that's easier for you.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1121924] Review Request: perl-Term-ANSIColor - Color screen output using ANSI escape sequences

2014-07-27 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1121924

David Dick dd...@cpan.org changed:

   What|Removed |Added

 Blocks||1123583




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1123583
[Bug 1123583] Review Request: perl-Data-Printer - Pretty printer for Perl
data structures
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1121924] Review Request: perl-Term-ANSIColor - Color screen output using ANSI escape sequences

2014-07-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1121924

Jitka Plesnikova jples...@redhat.com changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #4 from Jitka Plesnikova jples...@redhat.com ---


(In reply to David Dick from comment #3)
 (In reply to Jitka Plesnikova from comment #2)
  License is NOT ok
  FIX: In test directory, several files do not have the same license as Perl
  (for more details see Term-ANSIColor-4.03/LICENSE)
  The listed license should add in License tag.
  I don't know the correct shortcut for it and if it is valid license for
  Fedora,
  you can ask Fedora legal. You should also report it to upstream.
 
 Hi Jitka,
 
 The Expat license reference is to the license used by the expat package. 
 If you examine the wording between /usr/share/doc/expat/COPYING and the
 License: Expat section in Term-ANSIColor-4.03/LICENSE, you'll see the
 wording is identical.  As the License tag only covers the binary RPM, i
 don't think that i need to change the License tag either, as the Expat
 licensed files all appear to be for the test suite.  Is this ok?

In that case the license is ok

 
  FIX: Remove executable bit from
  /usr/share/doc/perl-Term-ANSIColor/examples/generate-colors
  Add 'chmod -c -x examples/*' to %prep section. It also clean up rpmlint
  warnings 'doc-file-dependency'.
 
 Done.

28a29
 chmod -c -x examples/*
Ok

Package APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1121924] Review Request: perl-Term-ANSIColor - Color screen output using ANSI escape sequences

2014-07-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1121924

David Dick dd...@cpan.org changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #5 from David Dick dd...@cpan.org ---
Thanks for the review Jitka! Most appreciated.

New Package SCM Request
===
Package Name: perl-Term-ANSIColor
Short Description: Color screen output using ANSI escape sequences
Upstream URL: http://search.cpan.org/dist/Term-ANSIColor/
Owners: ddick
Branches: f20, f21, el6, epel7
InitialCC: perl-sig

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1121924] Review Request: perl-Term-ANSIColor - Color screen output using ANSI escape sequences

2014-07-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1121924



--- Comment #6 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1121924] Review Request: perl-Term-ANSIColor - Color screen output using ANSI escape sequences

2014-07-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1121924

Jon Ciesla limburg...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1121924] Review Request: perl-Term-ANSIColor - Color screen output using ANSI escape sequences

2014-07-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1121924

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1121924] Review Request: perl-Term-ANSIColor - Color screen output using ANSI escape sequences

2014-07-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1121924



--- Comment #7 from Fedora Update System upda...@fedoraproject.org ---
perl-Term-ANSIColor-4.03-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/perl-Term-ANSIColor-4.03-1.fc20

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1121924] Review Request: perl-Term-ANSIColor - Color screen output using ANSI escape sequences

2014-07-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1121924



--- Comment #8 from Fedora Update System upda...@fedoraproject.org ---
perl-Term-ANSIColor-4.03-1.el6 has been submitted as an update for Fedora EPEL
6.
https://admin.fedoraproject.org/updates/perl-Term-ANSIColor-4.03-1.el6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1121924] Review Request: perl-Term-ANSIColor - Color screen output using ANSI escape sequences

2014-07-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1121924

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #9 from Fedora Update System upda...@fedoraproject.org ---
perl-Term-ANSIColor-4.03-1.el6 has been pushed to the Fedora EPEL 6 testing
repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1121924] Review Request: perl-Term-ANSIColor - Color screen output using ANSI escape sequences

2014-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1121924



--- Comment #1 from David Dick dd...@cpan.org ---
koji builds

el6 at http://koji.fedoraproject.org/koji/taskinfo?taskID=7176183

rawhide at http://koji.fedoraproject.org/koji/taskinfo?taskID=7176197

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1121924] Review Request: perl-Term-ANSIColor - Color screen output using ANSI escape sequences

2014-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1121924

Jitka Plesnikova jples...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jples...@redhat.com
   Assignee|nob...@fedoraproject.org|jples...@redhat.com
  Flags||fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1121924] Review Request: perl-Term-ANSIColor - Color screen output using ANSI escape sequences

2014-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1121924

Jitka Plesnikova jples...@redhat.com changed:

   What|Removed |Added

  Flags|fedora-review+  |fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1121924] Review Request: perl-Term-ANSIColor - Color screen output using ANSI escape sequences

2014-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1121924



--- Comment #2 from Jitka Plesnikova jples...@redhat.com ---
License is NOT ok
FIX: In test directory, several files do not have the same license as Perl
(for more details see Term-ANSIColor-4.03/LICENSE)
The listed license should add in License tag.
I don't know the correct shortcut for it and if it is valid license for Fedora,
you can ask Fedora legal. You should also report it to upstream.

URL and Source0 are ok

Summary and Description are ok

Package builds in F22 -
http://koji.fedoraproject.org/koji/taskinfo?taskID=7171971

Build-requires are ok

$ rpm -qp --provides perl-Term-ANSIColor-4.03-1.fc22.noarch.rpm | sort | uniq
-c
  1 perl(Term::ANSIColor) = 4.03
  1 perl-Term-ANSIColor = 4.03-1.fc22
Binary provides are ok

$ rpm -qp --requires perl-Term-ANSIColor-4.03-1.fc22.noarch.rpm | sort | uniq
-c
  1 /usr/bin/perl
  1 perl = 0:5.006
  1 perl(:MODULE_COMPAT_5.18.2)
  1 perl(Carp)
  1 perl(Exporter)
  1 perl(Term::ANSIColor) = 4.00
  1 perl(constant)
  1 perl(strict)
  1 perl(warnings)
  1 rpmlib(CompressedFileNames) = 3.0.4-1
  1 rpmlib(FileDigests) = 4.6.0-1
  1 rpmlib(PayloadFilesHavePrefix) = 4.0-1
  1 rpmlib(PayloadIsXz) = 5.2-1
Binary requires are ok

$ rpmlint ./perl-Term-ANSIColor*
perl-Term-ANSIColor.src: W: spelling-error %description -l en_US uncolor -
uncolored, councilor, uncool
perl-Term-ANSIColor.src: W: spelling-error %description -l en_US colorstrip -
color strip, color-strip, colors trip
perl-Term-ANSIColor.src: W: spelling-error %description -l en_US colorvalid -
color valid, color-valid, Corvallis
perl-Term-ANSIColor.src: W: spelling-error %description -l en_US coloralias -
color alias, color-alias, coloraturas
perl-Term-ANSIColor.noarch: W: spelling-error %description -l en_US uncolor -
uncolored, councilor, uncool
perl-Term-ANSIColor.noarch: W: spelling-error %description -l en_US colorstrip
- color strip, color-strip, colors trip
perl-Term-ANSIColor.noarch: W: spelling-error %description -l en_US colorvalid
- color valid, color-valid, Corvallis
perl-Term-ANSIColor.noarch: W: spelling-error %description -l en_US coloralias
- color alias, color-alias, coloraturas
perl-Term-ANSIColor.noarch: W: doc-file-dependency
/usr/share/doc/perl-Term-ANSIColor/examples/generate-colors /usr/bin/perl
perl-Term-ANSIColor.noarch: W: doc-file-dependency
/usr/share/doc/perl-Term-ANSIColor/examples/generate-colors perl(constant)
2 packages and 1 specfiles checked; 0 errors, 10 warnings.
Rpmlint is ok

$ rpm -qp -lv perl-Term-ANSIColor-4.03-1.fc22.noarch.rpm
drwxr-xr-x2 rootroot0 Jul 22 12:41
/usr/share/doc/perl-Term-ANSIColor
-rw-r--r--1 rootroot 2300 Mar 24 02:41
/usr/share/doc/perl-Term-ANSIColor/LICENSE
-rw-r--r--1 rootroot 9293 Mar 24 02:41
/usr/share/doc/perl-Term-ANSIColor/NEWS
-rw-r--r--1 rootroot10062 Mar 24 02:41
/usr/share/doc/perl-Term-ANSIColor/README
drwxr-xr-x2 rootroot0 Mar 24 02:41
/usr/share/doc/perl-Term-ANSIColor/examples
-rwxr-xr-x1 rootroot 8986 Mar 24 02:41
/usr/share/doc/perl-Term-ANSIColor/examples/generate-colors
-rw-r--r--1 rootroot11709 Jul 22 12:41
/usr/share/man/man3/Term::ANSIColor.3pm.gz
drwxr-xr-x2 rootroot0 Jul 22 12:41
/usr/share/perl5/vendor_perl/Term
-rw-r--r--1 rootroot47494 Jul 22 12:41
/usr/share/perl5/vendor_perl/Term/ANSIColor.pm
FIX: Remove executable bit from
/usr/share/doc/perl-Term-ANSIColor/examples/generate-colors
Add 'chmod -c -x examples/*' to %prep section. It also clean up rpmlint
warnings 'doc-file-dependency'.

Otherwise package looks good.

Please correct all `FIX' items and provide new spec file.
Package NOT approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1121924] Review Request: perl-Term-ANSIColor - Color screen output using ANSI escape sequences

2014-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1121924



--- Comment #3 from David Dick dd...@cpan.org ---
(In reply to Jitka Plesnikova from comment #2)
 License is NOT ok
 FIX: In test directory, several files do not have the same license as Perl
 (for more details see Term-ANSIColor-4.03/LICENSE)
 The listed license should add in License tag.
 I don't know the correct shortcut for it and if it is valid license for
 Fedora,
 you can ask Fedora legal. You should also report it to upstream.

Hi Jitka,

The Expat license reference is to the license used by the expat package.  If
you examine the wording between /usr/share/doc/expat/COPYING and the License:
Expat section in Term-ANSIColor-4.03/LICENSE, you'll see the wording is
identical.  As the License tag only covers the binary RPM, i don't think that i
need to change the License tag either, as the Expat licensed files all appear
to be for the test suite.  Is this ok?

 FIX: Remove executable bit from
 /usr/share/doc/perl-Term-ANSIColor/examples/generate-colors
 Add 'chmod -c -x examples/*' to %prep section. It also clean up rpmlint
 warnings 'doc-file-dependency'.

Done.

Spec URL: http://ddick.fedorapeople.org/packages/perl-Term-ANSIColor.spec
SRPM URL:
http://ddick.fedorapeople.org/packages/perl-Term-ANSIColor-4.03-1.fc20.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review