https://bugzilla.redhat.com/show_bug.cgi?id=1147921
--- Comment #1 from Honza Horak hho...@redhat.com ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- No %optflags macro used
https://fedoraproject.org/wiki/Packaging:Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS
- gtest could be un-bundled if possible, but since it is only build-time
dependency, it does not have to block review
- 1.0.0-0.1.rc0 should be used in changelog's version, see rpmlint output
https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs
- mongo-cxx-driver should obsolete libmongodb and the same for -devel packages
https://fedoraproject.org/wiki/Packaging:Guidelines#Renaming.2FReplacing_Existing_Packages
Even though libmongo-client might be replaced by mongo-cxx-driver in the
future as well, this does not have to be done from the beginning, since those
packages can co-exist, so this one is not problem.
- Dist should be used in Release tag.
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Using_the_.25.7B.3Fdist.7D_Tag
- There are some warnings worth fixing in rpmlint, see bellow
https://fedoraproject.org/wiki/Packaging:Guidelines#Use_rpmlint
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Apache (v2.0), GPL (v2 or later), Unknown or generated, *No
copyright* Public domain, BSD (3 clause), zlib/libpng. 17 files have
unknown license. Detailed output of licensecheck in /home/hhorak/tmp
/mongo-cxx-driver/1147921-mongo-cxx-driver/licensecheck.txt
- since gtest is not included in the final sources, it is fine
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by:
/usr/include/mongo/util/mongoutils(libmongodb-devel),
/usr/include/mongo/util/concurrency(libmongodb-devel),
/usr/include/mongo/util(libmongodb-devel), /usr/include/mongo/platform
(libmongodb-devel), /usr/include/mongo/client(libmongodb-devel),
/usr/include/mongo/bson/util(libmongodb-devel), /usr/include/mongo/db
(libmongodb-devel), /usr/include/mongo/base(libmongodb-devel),
/usr/include/mongo/bson(libmongodb-devel), /usr/include/mongo(libmongodb-
devel), /usr/include/mongo/util/net(libmongodb-devel)
- Not problem, this package is going to be replaced by mongo-cxx-driver
[!]: %build honors applicable compiler flags or justifies otherwise.
- No %optflags macro used
https://fedoraproject.org/wiki/Packaging:Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS
[!]: Package contains no bundled libraries without FPC exception.
- gtest could be un-bundled if possible, but since it is only build-time
dependency, it does not have to block review
[!]: Changelog in prescribed format.
- 1.0.0-0.1.rc0 should be used in changelog's version, see rpmlint output
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[!]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
- mongo-cxx-driver should obsolete libmongodb and the same for -devel packages
Even though libmongo-client might be replaced by mongo-cxx-driver in the
future as well, this does not have to be done from the beginning, since those
packages can co-exist, so this one is not problem.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
- Well, it is, but it is used sane. Do not forget to create a bug after package
is in fedora:
