[Bug 1174650] Review Request: ipsilon - An Identity Provider Server
https://bugzilla.redhat.com/show_bug.cgi?id=1174650 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||ipsilon-0.3.0-3.fc21 Resolution|--- |ERRATA Last Closed||2015-01-17 00:48:07 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- ipsilon-0.3.0-3.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1174650] Review Request: ipsilon - An Identity Provider Server
https://bugzilla.redhat.com/show_bug.cgi?id=1174650 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- ipsilon-0.3.0-3.fc21 has been pushed to the Fedora 21 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1174650] Review Request: ipsilon - An Identity Provider Server
https://bugzilla.redhat.com/show_bug.cgi?id=1174650 --- Comment #1 from Patrick Uiterwijk puiterw...@redhat.com --- This package built on koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=8395432 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1174650] Review Request: ipsilon - An Identity Provider Server
https://bugzilla.redhat.com/show_bug.cgi?id=1174650 --- Comment #2 from Patrick Uiterwijk puiterw...@redhat.com --- Fix shebang removal New Spec URL: http://puiterwijk.fedorapeople.org//ipsilon.spec New SRPM URL: http://puiterwijk.fedorapeople.org//ipsilon-0.3.0-2.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1174650] Review Request: ipsilon - An Identity Provider Server
https://bugzilla.redhat.com/show_bug.cgi?id=1174650
Ralph Bean rb...@redhat.com changed:
What|Removed |Added
CC||rb...@redhat.com
--- Comment #3 from Ralph Bean rb...@redhat.com ---
Original review as discussed over IRC:
Items that need work:
- Subpackage dependencies must be fixed. The providers should each have an
explicit Requires on the base ipsilon package.
- The base package should own correct directories where applicable.
Note: Directories without known owners: /usr/share/ipsilon,
/usr/share/ipsilon/ui, /usr/lib/python2.7/site-packages/ipsilon/info,
/usr/lib/python2.7/site-packages/ipsilon,
/usr/share/ipsilon/templates/install, /usr/lib/python2.7/site-
packages/ipsilon/providers, /usr/share/ipsilon/templates/login,
/usr/lib/python2.7/site-packages/ipsilon/login,
/usr/share/ipsilon/templates
- Please provide links to FPC tickets for temporary bundling exceptions for
javascript resources.
- One spelling error (s/agaist/against/).
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
GPL (v3 or later), Unknown or generated. 29 files have unknown
license. Detailed output of licensecheck in
/home/threebean/1174650-ipsilon/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/ipsilon,
/usr/share/ipsilon/ui, /usr/lib/python2.7/site-packages/ipsilon/info,
/usr/lib/python2.7/site-packages/ipsilon,
/usr/share/ipsilon/templates/install, /usr/lib/python2.7/site-
packages/ipsilon/providers, /usr/share/ipsilon/templates/login,
/usr/lib/python2.7/site-packages/ipsilon/login,
/usr/share/ipsilon/templates
[!]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[!]: Requires correct, justified where necessary. (subpackage deps)
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 102400 bytes in 6 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A
[Bug 1174650] Review Request: ipsilon - An Identity Provider Server
https://bugzilla.redhat.com/show_bug.cgi?id=1174650 Ralph Bean rb...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|rb...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1174650] Review Request: ipsilon - An Identity Provider Server
https://bugzilla.redhat.com/show_bug.cgi?id=1174650 --- Comment #4 from Patrick Uiterwijk puiterw...@redhat.com --- - Fix typo - Add comments on why the test suite is not in check - The subpackages require the base package - Add link to FPC ticket for bundling exception request New Spec URL: http://puiterwijk.fedorapeople.org//ipsilon.spec New SRPM URL: http://puiterwijk.fedorapeople.org//ipsilon-0.3.0-3.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1174650] Review Request: ipsilon - An Identity Provider Server
https://bugzilla.redhat.com/show_bug.cgi?id=1174650 Ralph Bean rb...@redhat.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #5 from Ralph Bean rb...@redhat.com --- Package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1174650] Review Request: ipsilon - An Identity Provider Server
https://bugzilla.redhat.com/show_bug.cgi?id=1174650 --- Comment #6 from Patrick Uiterwijk puiterw...@redhat.com --- New Package SCM Request === Package Name: ipsilon Short Description: An Identity Provider Server Upstream URL: https://fedorahosted.org/ipsilon/ Owners: puiterwijk simo Branches: f21 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1174650] Review Request: ipsilon - An Identity Provider Server
https://bugzilla.redhat.com/show_bug.cgi?id=1174650 Patrick Uiterwijk puiterw...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #7 from Patrick Uiterwijk puiterw...@redhat.com --- Thanks for reviewing! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1174650] Review Request: ipsilon - An Identity Provider Server
https://bugzilla.redhat.com/show_bug.cgi?id=1174650 --- Comment #8 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1174650] Review Request: ipsilon - An Identity Provider Server
https://bugzilla.redhat.com/show_bug.cgi?id=1174650 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1174650] Review Request: ipsilon - An Identity Provider Server
https://bugzilla.redhat.com/show_bug.cgi?id=1174650 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- ipsilon-0.3.0-3.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/ipsilon-0.3.0-3.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1174650] Review Request: ipsilon - An Identity Provider Server
https://bugzilla.redhat.com/show_bug.cgi?id=1174650 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
