[Bug 1190055] Review Request: massif-visualizer - Visualizer for Massif heap memory profiler data files
https://bugzilla.redhat.com/show_bug.cgi?id=1190055 Lubomir Rintel changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2015-02-11 05:13:58 --- Comment #7 from Lubomir Rintel --- Imported and built. Thank you! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190055] Review Request: massif-visualizer - Visualizer for Massif heap memory profiler data files
https://bugzilla.redhat.com/show_bug.cgi?id=1190055 Lubomir Rintel changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from Lubomir Rintel --- Thank you! New Package SCM Request === Package Name: massif-visualizer Short Description: Visualizer for Massif heap memory profiler data files Upstream URL: https://projects.kde.org/massif-visualizer Owners: lkundrak Branches: f20 f21 el6 epel7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190055] Review Request: massif-visualizer - Visualizer for Massif heap memory profiler data files
https://bugzilla.redhat.com/show_bug.cgi?id=1190055 --- Comment #6 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190055] Review Request: massif-visualizer - Visualizer for Massif heap memory profiler data files
https://bugzilla.redhat.com/show_bug.cgi?id=1190055 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190055] Review Request: massif-visualizer - Visualizer for Massif heap memory profiler data files
https://bugzilla.redhat.com/show_bug.cgi?id=1190055 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #4 from Zbigniew Jędrzejewski-Szmek --- (In reply to Lubomir Rintel from comment #3) > > - Please add an appdata file > > [https://fedoraproject.org/wiki/Packaging:AppData]. > > I suggest you use appstream-util validate (w/o -relax) while developing it, > > but leave validate-relax in the spec file. > > Seems like it's SHOULD now. Given massif-visualizer targets hackers who are > likely able to install the tool in a different way than GNOME software I > don't believe it's worth patching the appdata file now. > > I've contacted upstream and asked them to add the appdata file, offering > help if they need any. Could we do without the appdata file now and assume > upstream is going to include it in a later version anyway? Makes sense. > SPEC: http://v3.sk/~lkundrak/SPECS/massif-visualizer.spec > SRPM: http://v3.sk/~lkundrak/SRPMS/massif-visualizer-0.4.0-3.fc21.src.rpm fedora-review has nothing interesting to say. The only thing is mime datebase snippets: they are different than those on http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#mimeinfo. Is this on purpose? Rpmlint --- Checking: massif-visualizer-0.4.0-3.fc22.x86_64.rpm massif-visualizer-0.4.0-3.fc22.src.rpm massif-visualizer.x86_64: W: spelling-error Summary(en_US) profiler -> profile, profiles, profiled massif-visualizer.x86_64: W: spelling-error %description -l en_US pid -> peed, dip, pud massif-visualizer.x86_64: W: spelling-error %description -l en_US Gzip -> Zip, G zip, Grip massif-visualizer.x86_64: W: no-manual-page-for-binary massif-visualizer massif-visualizer.src: W: spelling-error Summary(en_US) profiler -> profile, profiles, profiled massif-visualizer.src: W: spelling-error %description -l en_US pid -> peed, dip, pud massif-visualizer.src: W: spelling-error %description -l en_US Gzip -> Zip, G zip, Grip 2 packages and 0 specfiles checked; 0 errors, 7 warnings. Package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190055] Review Request: massif-visualizer - Visualizer for Massif heap memory profiler data files
https://bugzilla.redhat.com/show_bug.cgi?id=1190055 --- Comment #3 from Lubomir Rintel --- Thank you (In reply to Zbigniew Jędrzejewski-Szmek from comment #2) > Issues: > === > - update-desktop-database is invoked in %post and %postun if package contains > desktop file(s) with a MimeType: entry. > Note: desktop file(s) with MimeType entry in massif-visualizer > See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop- > database Fixed. > - The license is GPLv2+. The sources might be mixed license, but the > resulting binary can only be under GPL, so there's no need to make things > complicated. Fixed. > - Please add an appdata file > [https://fedoraproject.org/wiki/Packaging:AppData]. > I suggest you use appstream-util validate (w/o -relax) while developing it, > but leave validate-relax in the spec file. Seems like it's SHOULD now. Given massif-visualizer targets hackers who are likely able to install the tool in a different way than GNOME software I don't believe it's worth patching the appdata file now. I've contacted upstream and asked them to add the appdata file, offering help if they need any. Could we do without the appdata file now and assume upstream is going to include it in a later version anyway? SPEC: http://v3.sk/~lkundrak/SPECS/massif-visualizer.spec SRPM: http://v3.sk/~lkundrak/SRPMS/massif-visualizer-0.4.0-3.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190055] Review Request: massif-visualizer - Visualizer for Massif heap memory profiler data files
https://bugzilla.redhat.com/show_bug.cgi?id=1190055 Kevin Kofler changed: What|Removed |Added Alias||massif-visualizer -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190055] Review Request: massif-visualizer - Visualizer for Massif heap memory profiler data files
https://bugzilla.redhat.com/show_bug.cgi?id=1190055 --- Comment #2 from Zbigniew Jędrzejewski-Szmek --- Issues: === - update-desktop-database is invoked in %post and %postun if package contains desktop file(s) with a MimeType: entry. Note: desktop file(s) with MimeType entry in massif-visualizer See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop- database - The license is GPLv2+. The sources might be mixed license, but the resulting binary can only be under GPL, so there's no need to make things complicated. - Please add an appdata file [https://fedoraproject.org/wiki/Packaging:AppData]. I suggest you use appstream-util validate (w/o -relax) while developing it, but leave validate-relax in the spec file. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190055] Review Request: massif-visualizer - Visualizer for Massif heap memory profiler data files
https://bugzilla.redhat.com/show_bug.cgi?id=1190055 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Status|NEW |ASSIGNED CC||zbys...@in.waw.pl Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190055] Review Request: massif-visualizer - Visualizer for Massif heap memory profiler data files
https://bugzilla.redhat.com/show_bug.cgi?id=1190055 Lubomir Rintel changed: What|Removed |Added CC||lrin...@redhat.com --- Comment #1 from Lubomir Rintel --- SPEC: http://v3.sk/~lkundrak/SPECS/massif-visualizer.spec SRPM: http://v3.sk/~lkundrak/SRPMS/massif-visualizer-0.4.0-2.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190055] Review Request: massif-visualizer - Visualizer for Massif heap memory profiler data files
https://bugzilla.redhat.com/show_bug.cgi?id=1190055 Rex Dieter changed: What|Removed |Added CC||rdie...@math.unl.edu Version|21 |rawhide Blocks||656997 (kde-reviews) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=656997 [Bug 656997] kde-related package review tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
