[Bug 1253244] Review Request: uClibc-ng - C library for embedded Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1253244

Nikola Forró  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |NOTABUG
  Flags|fedora-review+  |
Last Closed||2015-09-24 09:21:58



--- Comment #7 from Nikola Forró  ---
I'm closing this review request, as replacing uClibc doesn't seem to be the
best thing to do.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1253244] Review Request: uClibc-ng - C library for embedded Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1253244

Christopher Meng i...@cicku.me changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #6 from Christopher Meng i...@cicku.me ---
(In reply to Nikola Forró from comment #5)
  2. I'm not sure if uclibc in Fedora is a package or just another c lib, if
  just a package ,you still need to build it with %optflags
  (UCLIBC_EXTRA_CFLAGS)
 Including %{optflags} would break busybox's goal to build smallest binary
 possible, I think. After all, that's the reason why busybox links with
 uClibc rather than glibc.

Ok,-fno-stack-protector -nostdinc, I understand.

  3. About these 2, should they be enabled?
  
  Wide Character Support (UCLIBC_HAS_WCHAR) [N/y/?] n
  Locale Support (UCLIBC_HAS_LOCALE) [N/y/?] n
 Again, I'm not sure how this would affect busybox. I should consult it's
 maintainer.

I've read the wchar code from uclibc, it's broken. ;)

PACKAGE APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1253244] Review Request: uClibc-ng - C library for embedded Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1253244



--- Comment #5 from Nikola Forró nfo...@redhat.com ---
As far as I know, uClibc package in Fedora exists only to enable static linking
with busybox. Nothing else depends on it, and it's practical use is limited
because it only contains static library and headers. From this point of view, I
think replacing it with uClibc-ng is acceptable. Both libraries are very
similar/compatible and busybox builds fine with uClibc-ng.
On the other hand, should there be more use cases than just building busybox,
why don't let both libraries co-exist? 

(In reply to Christopher Meng from comment #3)
 1. I don't see the reason that uclibc-ng should obsolete uclibc, at least.
 not more suitable for different software development processes., POC?

 Fedora switches uclibc-ng may cause troubles to downstream folks or just
 users, have you measured the actual impact? As far as I can see from
 upstream, This might change in the future.
This is concerning only config file, so nothing that users should get in touch
with.

 If uclibc FTBFS, or no active upstream activities, then it's time to do the
 retire, but not now *I think*. Especially from upstream git I still can see
 commits in the past 3 years after its latest release.
You are right, but there has been no uClibc release for 3 years, while
uClibc-ng is released regularly. Also, uClibc-ng claims to implement changes
happening in uClibc.

 2. I'm not sure if uclibc in Fedora is a package or just another c lib, if
 just a package ,you still need to build it with %optflags
 (UCLIBC_EXTRA_CFLAGS)
Including %{optflags} would break busybox's goal to build smallest binary
possible, I think. After all, that's the reason why busybox links with uClibc
rather than glibc.

 3. About these 2, should they be enabled?
 
 Wide Character Support (UCLIBC_HAS_WCHAR) [N/y/?] n
 Locale Support (UCLIBC_HAS_LOCALE) [N/y/?] n
Again, I'm not sure how this would affect busybox. I should consult it's
maintainer.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1253244] Review Request: uClibc-ng - C library for embedded Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1253244



--- Comment #3 from Christopher Meng i...@cicku.me ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated




= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: *No copyright* GPL (v2 or later) (with incorrect FSF
 address), LGPL (v2.1 or later) (with incorrect FSF address), LGPL
 (v2 or later), GPL (v2 or later), Unknown or generated, BSD (4
 clause), BSD (3 clause) ISC, *No copyright* LGPL (v2 or later),
 LGPL (v2 or later) (with incorrect FSF address), ISC, BSD (3
 clause) ISC LGPL (v2 or later), LGPL (v2), Beerware, *No
 copyright* BSD, BSD (3 clause), BSD (2 clause), LGPL (v2.1 or
 later), *No copyright* LGPL (v2.1 or later), GPL (v2), BSD ISC,
 BSD (3 clause) LGPL (v2.1 or later). 2372 files have unknown
 license. Detailed output of licensecheck is available at attachment.

[?]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /usr/include/uClibc/bits
 (uClibc-devel), /usr/include/uClibc/neteconet(uClibc-devel),
 /usr/include/uClibc/sys(uClibc-devel), /usr/include/uClibc/scsi
 (uClibc-devel), /usr/include/uClibc/rpc(uClibc-devel),
 /usr/include/uClibc/netpacket(uClibc-devel),
 /usr/include/uClibc/protocols(uClibc-devel), /usr/include/uClibc/net
 (uClibc-devel), /usr/include/uClibc/arpa(uClibc-devel),
 /usr/include/uClibc/netipx(uClibc-devel), /usr/include/uClibc/netax25
 (uClibc-devel), /usr/include/uClibc(uClibc-devel),
 /usr/include/uClibc/netinet(uClibc-devel), /usr/lib/uClibc(uClibc-
 devel)
[?]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[?]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 30720 bytes in 5 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: Static libraries in -static or -devel 

[Bug 1253244] Review Request: uClibc-ng - C library for embedded Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1253244



--- Comment #4 from Christopher Meng i...@cicku.me ---
Created attachment 1066828
  -- https://bugzilla.redhat.com/attachment.cgi?id=1066828action=edit
licensecheck of uClibc-ng

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1253244] Review Request: uClibc-ng - C library for embedded Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1253244

Christopher Meng i...@cicku.me changed:

   What|Removed |Added

  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1253244] Review Request: uClibc-ng - C library for embedded Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1253244



--- Comment #2 from Nikola Forró nfo...@redhat.com ---
Updated to latest upstream version.

Spec URL: https://nforro.fedorapeople.org/uClibc-ng.spec
SRPM URL: https://nforro.fedorapeople.org/uClibc-ng-1.0.6-1.fc22.src.rpm
Koji scratchbuild URL:
http://koji.fedoraproject.org/koji/taskinfo?taskID=10802019

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1253244] Review Request: uClibc-ng - C library for embedded Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1253244

Christopher Meng i...@cicku.me changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||i...@cicku.me
   Assignee|nob...@fedoraproject.org|i...@cicku.me



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1253244] Review Request: uClibc-ng - C library for embedded Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1253244



--- Comment #1 from Nikola Forró nfo...@redhat.com ---
uClibc-ng replaces uClibc. Here is review request of the original package:
https://bugzilla.redhat.com/show_bug.cgi?id=506720

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1253244] Review Request: uClibc-ng - C library for embedded Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1253244

Nikola Forró nfo...@redhat.com changed:

   What|Removed |Added

 Blocks||1246847




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1246847
[Bug 1246847] [RFE]: replace it with uClibc-ng
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review