[Bug 1257705] Review Request: nodejs-should-equal - Deep comparison of two instances for should.js

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1257705
Bug 1257705 depends on bug 1257702, which changed state.

Bug 1257702 Summary: Review Request: nodejs-should-type - Simple module to get 
instance type
https://bugzilla.redhat.com/show_bug.cgi?id=1257702

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |NEXTRELEASE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1257705] Review Request: nodejs-should-equal - Deep comparison of two instances for should.js

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1257705



--- Comment #9 from Fedora Update System  ---
nodejs-should-equal-0.5.0-2.fc23, nodejs-should-format-0.3.0-2.fc23,
nodejs-should-type-0.2.0-2.fc23 has been pushed to the Fedora 23 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1257705] Review Request: nodejs-should-equal - Deep comparison of two instances for should.js

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1257705

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||0.3.0-2.fc23
 Resolution|--- |NEXTRELEASE
Last Closed||2015-09-18 14:34:19



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1257705] Review Request: nodejs-should-equal - Deep comparison of two instances for should.js

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1257705

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1257705] Review Request: nodejs-should-equal - Deep comparison of two instances for should.js

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1257705

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1257705] Review Request: nodejs-should-equal - Deep comparison of two instances for should.js

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1257705



--- Comment #7 from Fedora Update System  ---
nodejs-should-equal-0.5.0-2.fc23 nodejs-should-format-0.3.0-2.fc23
nodejs-should-type-0.2.0-2.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2015-15118

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1257705] Review Request: nodejs-should-equal - Deep comparison of two instances for should.js

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1257705

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #8 from Fedora Update System  ---
nodejs-should-equal-0.5.0-2.fc23, nodejs-should-format-0.3.0-2.fc23,
nodejs-should-type-0.2.0-2.fc23 has been pushed to the Fedora 23 testing
repository. If problems still persist, please make note of it in this bug
report.\nIf you want to test the update, you can install it with \n su -c 'yum
--enablerepo=updates-testing update nodejs-should-type nodejs-should-format
nodejs-should-equal'. You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2015-15118

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1257705] Review Request: nodejs-should-equal - Deep comparison of two instances for should.js

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1257705

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1257705] Review Request: nodejs-should-equal - Deep comparison of two instances for should.js

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1257705



--- Comment #6 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1257705] Review Request: nodejs-should-equal - Deep comparison of two instances for should.js

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1257705



--- Comment #4 from Jon Ciesla  ---
WARNING: Requested package name nodejs-shoudl-equal doesn't match bug summary
nodejs-should-equal

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1257705] Review Request: nodejs-should-equal - Deep comparison of two instances for should.js

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1257705

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1257705] Review Request: nodejs-should-equal - Deep comparison of two instances for should.js

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1257705

Tom Hughes  changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #5 from Tom Hughes  ---
New Package SCM Request
===
Package Name: nodejs-should-equal
Short Description: Deep comparison of two instances for should.js
Upstream URL: https://github.com/shouldjs/equal
Owners: tomh
Branches: f21 f22 f23

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1257705] Review Request: nodejs-should-equal - Deep comparison of two instances for should.js

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1257705

Piotr Popieluch  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||piotr1...@gmail.com
   Assignee|nob...@fedoraproject.org|piotr1...@gmail.com
  Flags||fedora-review+



--- Comment #2 from Piotr Popieluch  ---
APPROVED



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 3 files have unknown license. Detailed
 output of licensecheck in /home/piotr/rpmbuild/1257705-nodejs-should-
 equal/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, 

[Bug 1257705] Review Request: nodejs-should-equal - Deep comparison of two instances for should.js

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1257705

Tom Hughes  changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #3 from Tom Hughes  ---
Thanks for the review!

New Package SCM Request
===
Package Name: nodejs-shoudl-equal
Short Description: Deep comparison of two instances for should.js
Upstream URL: https://github.com/shouldjs/equal
Owners: tomh
Branches: f21 f22 f23

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1257705] Review Request: nodejs-should-equal - Deep comparison of two instances for should.js

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1257705



--- Comment #1 from Tom Hughes  ---
Fix line endings:

Spec URL: http://download.compton.nu/nodejs/nodejs-should-equal.spec
SRPM URL:
http://download.compton.nu/nodejs/nodejs-should-equal-0.5.0-2.fc22.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1257705] Review Request: nodejs-should-equal - Deep comparison of two instances for should.js

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1257705

Tom Hughes t...@compton.nu changed:

   What|Removed |Added

 Blocks||1101208




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1101208
[Bug 1101208] nodejs-should-7.0.4 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1257705] Review Request: nodejs-should-equal - Deep comparison of two instances for should.js

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1257705

Tom Hughes t...@compton.nu changed:

   What|Removed |Added

 Blocks||956806 (nodejs-reviews)
 Depends On||1257702




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=956806
[Bug 956806] Node.js Review Tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1257702
[Bug 1257702] Review Request: nodejs-should-type - Simple module to get
instance type
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review