[Bug 1260787] Review Request: xfce4-hardware-monitor-plugin - Xfce4 panel plugin to display various system stats

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1260787



--- Comment #16 from Fedora Update System  ---
xfce4-hardware-monitor-plugin-1.4.7-3.fc22 has been pushed to the Fedora 22
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1260787] Review Request: xfce4-hardware-monitor-plugin - Xfce4 panel plugin to display various system stats

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1260787

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2015-10-31 22:28:30



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1260787] Review Request: xfce4-hardware-monitor-plugin - Xfce4 panel plugin to display various system stats

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1260787



--- Comment #15 from Fedora Update System  ---
xfce4-hardware-monitor-plugin-1.4.7-3.fc23 has been pushed to the Fedora 23
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1260787] Review Request: xfce4-hardware-monitor-plugin - Xfce4 panel plugin to display various system stats

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1260787



--- Comment #14 from Fedora Update System  ---
xfce4-hardware-monitor-plugin-1.4.7-3.fc22 has been pushed to the Fedora 22
testing repository. If problems still persist, please make note of it in this
bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update xfce4-hardware-monitor-plugin'
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2015-4daf9e3c43

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1260787] Review Request: xfce4-hardware-monitor-plugin - Xfce4 panel plugin to display various system stats

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1260787

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #13 from Fedora Update System  ---
xfce4-hardware-monitor-plugin-1.4.7-3.fc23 has been pushed to the Fedora 23
testing repository. If problems still persist, please make note of it in this
bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update xfce4-hardware-monitor-plugin'
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2015-7fcc773010

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1260787] Review Request: xfce4-hardware-monitor-plugin - Xfce4 panel plugin to display various system stats

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1260787



--- Comment #12 from Fedora Update System  ---
xfce4-hardware-monitor-plugin-1.4.7-3.fc22 has been submitted as an update to
Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-4daf9e3c43

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1260787] Review Request: xfce4-hardware-monitor-plugin - Xfce4 panel plugin to display various system stats

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1260787

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1260787] Review Request: xfce4-hardware-monitor-plugin - Xfce4 panel plugin to display various system stats

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1260787



--- Comment #11 from Fedora Update System  ---
xfce4-hardware-monitor-plugin-1.4.7-3.fc23 has been submitted as an update to
Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-7fcc773010

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1260787] Review Request: xfce4-hardware-monitor-plugin - Xfce4 panel plugin to display various system stats

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1260787

William Moreno  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #9 from William Moreno  ---
Package Aproved
===

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1260787] Review Request: xfce4-hardware-monitor-plugin - Xfce4 panel plugin to display various system stats

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1260787



--- Comment #10 from Kevin Fenzi  ---
Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1260787] Review Request: xfce4-hardware-monitor-plugin - Xfce4 panel plugin to display various system stats

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1260787



--- Comment #7 from Upstream Release Monitoring 
 ---
kevin's scratch build of xfce4-hardware-monitor-plugin-1.4.7-3.fc24.src.rpm for
f24 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11491493

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1260787] Review Request: xfce4-hardware-monitor-plugin - Xfce4 panel plugin to display various system stats

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1260787

Kevin Fenzi  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



--- Comment #8 from Kevin Fenzi  ---
Right, we need to build with c++11 now since gtkmm30 does.

Spec URL:
https://www.scrye.com/~kevin/fedora/review/xfce4-hardware-monitor-plugin/xfce4-hardware-monitor-plugin.spec
SRPM URL:
https://www.scrye.com/~kevin/fedora/review/xfce4-hardware-monitor-plugin/xfce4-hardware-monitor-plugin-1.4.7-3.fc24.src.rpm

(scratch build above)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1260787] Review Request: xfce4-hardware-monitor-plugin - Xfce4 panel plugin to display various system stats

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1260787



--- Comment #6 from Raphael Groner  ---
/usr/include/c++/5.1.1/bits/c++0x_warning.h:32:2: error: #error This file
requires compiler and library support for the ISO C++ 2011 standard. This
support is currently experimental, and must be enabled with the -std=c++11 or
-std=gnu++11 compiler options.

And please set status to ASSIGNED as you're in the official review process.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1260787] Review Request: xfce4-hardware-monitor-plugin - Xfce4 panel plugin to display various system stats

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1260787



--- Comment #4 from Upstream Release Monitoring 
 ---
williamjmorenor's scratch build of
xfce4-hardware-monitor-plugin-1.4.7-2.fc24.src.rpm for rawhide failed
http://koji.fedoraproject.org/koji/taskinfo?taskID=11418809

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1260787] Review Request: xfce4-hardware-monitor-plugin - Xfce4 panel plugin to display various system stats

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1260787



--- Comment #5 from Upstream Release Monitoring 
 ---
williamjmorenor's scratch build of
xfce4-hardware-monitor-plugin-1.4.7-2.fc24.src.rpm for f23 failed
http://koji.fedoraproject.org/koji/taskinfo?taskID=11418884

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1260787] Review Request: xfce4-hardware-monitor-plugin - Xfce4 panel plugin to display various system stats

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1260787



--- Comment #3 from Kevin Fenzi  ---
Thanks for reviewing... 

1. fixed. 

2. This doesn't apply here. :) This is not a freedesktop application desktop
file, it's a xfce panel plugin desktop file. 

3. Sadly it seems something is messed up with the https version of the Source0
url. The http version works fine, so I switched to that for now. 

4. Yeah, upstream says:
"NOTE that I don't have any testers currently, just myself with a few VMs
- so consider the plugin to remain experimental until that changes."

5. Changed to "GPL+ and LGPLv2.1+" The only thing I see here thats BSD is some
of the autotools, and that doesn't affect the license of the binary package.
Where did you see GPLv3+?

6. fixed. 

7. yeah, I filed: https://bugzilla.xfce.org/show_bug.cgi?id=12195 on the
incorrect fsf address. 

Spec URL:
https://www.scrye.com/~kevin/fedora/review/xfce4-hardware-monitor-plugin/xfce4-hardware-monitor-plugin.spec
SRPM URL:
https://www.scrye.com/~kevin/fedora/review/xfce4-hardware-monitor-plugin/xfce4-hardware-monitor-plugin-1.4.7-2.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1260787] Review Request: xfce4-hardware-monitor-plugin - Xfce4 panel plugin to display various system stats

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1260787

William Moreno  changed:

   What|Removed |Added

  Flags||fedora-review?



--- Comment #2 from William Moreno  ---
Package Review
==

Issues:
===
1- Package does not contain any libtool archives (.la)
   Note: xfce4-hardware-monitor-plugin :
   /usr/lib64/xfce4/panel/plugins/libhardwaremonitor.la
   See: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries

2- Package installs a %{name}.desktop using desktop-file-install or desktop-
   file-validate if there is such a file.

3- [!]: Sources can be downloaded from URI in Source: tag
   [ ]: SourceX tarball generation or download is documented.
   Source0 is not available, you can document how to build the
   tarball from git sources in the spec.

4- [ ]: Development (unversioned) .so files in -devel subpackage, if present.
   Unversioned so-files

/usr/lib64/xfce4/panel/plugins/libhardwaremonitor.so

5- There is many licences in source, update the License tag to BSD and LGPL and
GPLv3+

6- There are orphan directories
Note: No known owner 
Note: Directories without known owners
/usr/share/xfce4-hardware-monitor-plugin/glade 
/usr/share/xfce4-hardware-monitor-plugin
[ ]: Package must own all directories that it creates.
[ ]: Package requires other packages for directories it uses.

7- There are a lot of erros with the debuginfo package :(
incorrect-fsf-address

Test Builds:
Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=11352606 
ARM:  http://arm.koji.fedoraproject.org/koji/taskinfo?taskID=3220064
PPC:  http://ppc.koji.fedoraproject.org/koji/taskinfo?taskID=2786215
S390: http://s390.koji.fedoraproject.org/koji/taskinfo?taskID=1953907

= MUST items =
C/C++:
[PASS]: Package does not contain kernel modules.
[PASS]: Package contains no static executables.
[PASS]: Rpath absent or only used for internal libs.
Generic:
[PASS]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[PASS]: %build honors applicable compiler flags or justifies otherwise.
[PASS]: Package contains no bundled libraries without FPC exception.
[PASS]: Changelog in prescribed format.
[PASS]: Sources contain only permissible code or content.
[PASS]: Development files must be in a -devel package
[PASS]: Package uses nothing in %doc for runtime.
[PASS]: The spec file handles locales properly.
[PASS]: Package consistently uses macros (instead of hard-coded directory
names).
[PASS]: Package is named according to the Package Naming Guidelines.
[PASS]: Package does not generate any conflict.
[PASS]: Package obeys FHS, except libexecdir and /usr/target.
[NA]:   If the package is a rename of another package, proper Obsoletes and
Provides are present.
[PASS]: Requires correct, justified where necessary.
[PASS]: Spec file is legible and written in American English.
[PASS]: Package contains systemd file(s) if in need.
[PASS]: Useful -debuginfo package or justification otherwise.
[PASS]: Package is not known to require an ExcludeArch tag.
[PASS]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 40960 bytes in 4 files.
[PASS]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[PASS]: Package installs properly.
[PASS]: Rpmlint is run on all rpms the build produces.
[PASS]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[PASS]: Package does not own files or directories owned by other packages.
[PASS]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[PASS]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[PASS]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[PASS]: Macros in Summary, %description expandable at SRPM build time.
[PASS]: Package contains desktop file if it is a GUI application.
[PASS]: Dist tag is present.
[PASS]: Package does not contain duplicates in %files.
[PASS]: Permissions on files are set properly.
[PASS]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[PASS]: Package is named using only allowed ASCII characters.
[PASS]: Package does not use a name that already exists.
[PASS]: Package is not relocatable.
[PASS]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[PASS]: Spec file name must match the spec 

[Bug 1260787] Review Request: xfce4-hardware-monitor-plugin - Xfce4 panel plugin to display various system stats

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1260787

William Moreno  changed:

   What|Removed |Added

 CC||williamjmore...@gmail.com
   Assignee|nob...@fedoraproject.org|williamjmore...@gmail.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1260787] Review Request: xfce4-hardware-monitor-plugin - Xfce4 panel plugin to display various system stats

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1260787



--- Comment #1 from Upstream Release Monitoring 
 ---
jgrulich's scratch build of kdevelop?#c8e2b9bc57f11e41f3dc6612cdbcc591078d9062
for f22-candidate and
git://pkgs.fedoraproject.org/kdevelop?#c8e2b9bc57f11e41f3dc6612cdbcc591078d9062
completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11212117

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review